[Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

--- toys/pending/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) From 2c386cc024a22cb890b12a69d6c2dab48a1375ef Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 29 Feb 2016 07:46:12 -0800 Subject: [PATCH] Fix file.c build and fix sense of fstat test. ---

[Toybox] [PATCH] Fix trailing spaces on ps -o cmdline.

--- toys/posix/ps.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) From 7b3f113f4c172c30f4905793be64791b2a8e3a1e Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 29 Feb 2016 10:34:07 -0800 Subject: [PATCH] Fix trailing spaces on ps -o cmdline. ---

[Toybox] [PATCH] include sys/sysmacros.h

The major/minor macros are defined in sys/sysmacros.h. This has historically been pulled in implicitly by sys/types.h, but C libs are moving away from that as they aren't in POSIX. Use the header directly as defined by BSD systems. --- toys.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Toybox] [PATCH] include sys/sysmacros.h

On 02/29/2016 12:36 PM, Mike Frysinger wrote: > The major/minor macros are defined in sys/sysmacros.h. This has > historically been pulled in implicitly by sys/types.h, http://man7.org/linux/man-pages/man3/major.3.html says sys/types.h, yes. > but C libs > are moving away from that as they

Re: [Toybox] [PATCH] Distinguish 32- and 64-bit variants in file(1) for x32.

On Mon, Feb 29, 2016 at 1:01 PM Rob Landley wrote: > On 02/29/2016 10:51 AM, enh wrote: > > On Sun, Feb 28, 2016 at 9:44 AM, Rob Landley wrote: > >>> as far as i know, there's only one. i've never come across another, > >>> even on Mac OS. > >> > >>

Re: [Toybox] [PATCH] include sys/sysmacros.h

On 29 Feb 2016 16:24, Rob Landley wrote: > On 02/29/2016 12:36 PM, Mike Frysinger wrote: > > The major/minor macros are defined in sys/sysmacros.h. This has > > historically been pulled in implicitly by sys/types.h, > > http://man7.org/linux/man-pages/man3/major.3.html says sys/types.h, yes.

[Toybox] [PATCH] Fix file for Java class files, improve script detection, and add tests.

--- tests/file.test | 21 + toys/pending/file.c | 5 - 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 tests/file.test From 04562ab2b0969ed8298d04940521875a976f219f Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 29 Feb

Re: [Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

Sigh. I am juggling too many things the past couple days. Rob On 02/29/2016 11:50 PM, enh wrote: > i think you want this patch rather than the one you committed > (c1161cf09f5d9646b0e0c6ec504ed26a0623e691) --- doesn't yours leak fd? > > On Mon, Feb 29, 2016 at 4:25 PM, enh

Re: [Toybox] [PATCH] include sys/sysmacros.h

seems like that glibc thread ground to a halt? did anyone actually rebuild debian with such a change? did glibc make this change? has it shipped yet? we had the same major/minor pollution bug reported against bionic but closed it as WAI saying that that's what glibc does. but if glibc removes the

Re: [Toybox] [PATCH] include sys/sysmacros.h

On 02/29/2016 10:16 PM, Mike Frysinger wrote: > On 29 Feb 2016 19:52, enh wrote: >> seems like that glibc thread ground to a halt? > > not really ... mailman is just really really crappy when it comes to > threads across month date lines. so if you look at later months, you > can see more info.

Re: [Toybox] [toybox] 0.7.0: scripts/make.sh: line 270: wait: pid XYZ is not a child of this shell (#24)

Hi, On Sat, Feb 27, 2016 at 12:52 PM, Nicolas Boichat wrote: >> Trying to get the number of execs in the dispatch/monitoring >> cycle down as small as possible. Then again once it can build under a >> toybox shell then it's just a fork() and not an exec, which is cheaper.

Re: [Toybox] Implement wget

Thanks for your comments, Rich Felker. I think 'get_info' function checked path length from url before calling strcpy as belows, if (strlen(url+i) < 1024) strcpy(path, url+i); else error_exit("too long path in URL"); Do you think it is not enough? And you commented whole string

Re: [Toybox] [PATCH] include sys/sysmacros.h

On Mon, Feb 29, 2016 at 05:53:02PM -0500, Mike Frysinger wrote: > On 29 Feb 2016 16:24, Rob Landley wrote: > > On 02/29/2016 12:36 PM, Mike Frysinger wrote: > > > The major/minor macros are defined in sys/sysmacros.h. This has > > > historically been pulled in implicitly by sys/types.h, > > > >

Re: [Toybox] Implement wget

On Tue, Mar 01, 2016 at 12:08:52PM +0900, Lipi C. H. Lee wrote: > Thanks for your comments, Rich Felker. > > I think 'get_info' function checked path length from url before calling > strcpy as belows, > > if (strlen(url+i) < 1024) strcpy(path, url+i); > else error_exit("too long path in

Re: [Toybox] [PATCH] include sys/sysmacros.h

On 29 Feb 2016 19:52, enh wrote: > seems like that glibc thread ground to a halt? not really ... mailman is just really really crappy when it comes to threads across month date lines. so if you look at later months, you can see more info. long story short, we're going to try to come up with a

Re: [Toybox] [PATCH] Fix file.c build and fix sense of fstat test.

i think you want this patch rather than the one you committed (c1161cf09f5d9646b0e0c6ec504ed26a0623e691) --- doesn't yours leak fd? On Mon, Feb 29, 2016 at 4:25 PM, enh wrote: > what's checked in now still doesn't work in the regular file case though... > > > Subject: [PATCH]

Re: [Toybox] [PATCH] include sys/sysmacros.h

Rich Felker wrote: ... > > glibc is the process of deprecating, and musl/uClibc would follow suit, > > if not just drop the include altogether. > > musl has never had the issue. :-) because we don't implicitly include > sys/sysmacros.h at all. The set of programs that have any use for > these