Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-17 Thread Rob Landley
On 10/17/2018 04:51 PM, enh wrote: > i think what you have is broken even for static builds, since you have > an ODR violation from the missing `static inline` on your no-op > function: > > ld.lld: error: duplicate symbol: __android_log_write defined at portability.h:282

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-17 Thread enh
On Wed, Oct 17, 2018 at 2:05 PM Rob Landley wrote: > > On 10/10/2018 11:43 AM, enh wrote: > >> Then it works with glibc and musl, but _not_ with the android NDKr18: > > > > yeah, hard to know what to do with something non-standard like that, > > but if we're in a world where some have one and

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-17 Thread Rob Landley
On 10/10/2018 11:43 AM, enh wrote: >> Then it works with glibc and musl, but _not_ with the android NDKr18: > > yeah, hard to know what to do with something non-standard like that, > but if we're in a world where some have one and others have the other, > we usually end up having both. Indeed.

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-10 Thread enh
On Sun, Oct 7, 2018 at 3:12 PM Rob Landley wrote: > > On 10/07/2018 11:30 AM, enh wrote: > > Bug: https://github.com/landley/toybox/issues/43 > > That fixes that one (once I pulled your email out of the spam filter, and yes > I > got unsubscribed from my own list again because gmail false

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-07 Thread Rob Landley
On 10/07/2018 11:30 AM, enh wrote: > Bug: https://github.com/landley/toybox/issues/43 This commit broke building on musl, because these: -static inline int get_sched_policy(int tid, void *policy) {return 0;} -static inline char *get_sched_policy_name(int policy) {return "unknown";} Need to be

Re: [Toybox] [PATCH] libcutils isn't in the NDK.

2018-10-07 Thread Rob Landley
On 10/07/2018 11:30 AM, enh wrote: > Bug: https://github.com/landley/toybox/issues/43 That fixes that one (once I pulled your email out of the spam filter, and yes I got unsubscribed from my own list again because gmail false positived on the "sorry if this one's a duplicate" email from earlier