Re: [Toybox] oh, the irony...

On 10/21/2018 11:54 PM, enh wrote: > On Sun, Oct 21, 2018 at 6:49 PM Rob Landley wrote: >> >> On 10/17/2018 06:24 PM, enh wrote: >>> $ ./toybox su --help >>> toybox: Not root (see "toybox --help") >>> >>> not sure what the fix is there though. >> >> Ok, dug into it some more. >> >> If you "chown

Re: [Toybox] oh, the irony...

On Sun, Oct 21, 2018 at 6:49 PM Rob Landley wrote: > > On 10/17/2018 06:24 PM, enh wrote: > > $ ./toybox su --help > > toybox: Not root (see "toybox --help") > > > > not sure what the fix is there though. > > Ok, dug into it some more. > > If you "chown root:root toybox" and "chmod +s toybox",

Re: [Toybox] oh, the irony...

On 10/17/2018 06:24 PM, enh wrote: > $ ./toybox su --help > toybox: Not root (see "toybox --help") > > not sure what the fix is there though. Ok, dug into it some more. If you "chown root:root toybox" and "chmod +s toybox", the su command then works as advertised. Including su --help. What's

Re: [Toybox] oh, the irony...

On 10/18/2018 12:59 PM, enh wrote:> On Thu, Oct 18, 2018, 10:51 Rob Landley > wrote: > > On 10/17/2018 06:24 PM, enh wrote: > > $ ./toybox su --help > > toybox: Not root (see "toybox --help") > > > > not sure what the fix is there though. > >

Re: [Toybox] oh, the irony...

On Thu, Oct 18, 2018, 10:51 Rob Landley wrote: > On 10/17/2018 06:24 PM, enh wrote: > > $ ./toybox su --help > > toybox: Not root (see "toybox --help") > > > > not sure what the fix is there though. > > Hmmm, I think it's that TOYFLAG_NEEDROOT should be checking geteuid() not > getuid(), but

Re: [Toybox] oh, the irony...

On 10/17/2018 06:24 PM, enh wrote: > $ ./toybox su --help > toybox: Not root (see "toybox --help") > > not sure what the fix is there though. Hmmm, I think it's that TOYFLAG_NEEDROOT should be checking geteuid() not getuid(), but that's a security thing and I want to go over all the users