Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-16 Thread Jarkko Sakkinen
On Mon, Mar 12, 2018 at 11:41:25AM +0100, Paul Menzel wrote: > Dear Jarkko, > > > On 03/12/18 11:17, Jarkko Sakkinen wrote: > > On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: > > > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > > > > and it's hanging at "memset(log_tbl, 0, siz

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Thiebaud Weksteen via tpmdd-devel
On Tue, Mar 13, 2018 at 2:43 PM Ard Biesheuvel wrote: > On 13 March 2018 at 13:41, Jeremy Cline wrote: > > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: > >>> Hi, > >>> > >>> > >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: > > >> ... >

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 13:41, Jeremy Cline wrote: > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: >> On 13 March 2018 at 07:47, Hans de Goede wrote: >>> Hi, >>> >>> >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... Hans, you said you configured the tablet to use the 32-bit versio

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Andy Shevchenko
On Tue, Mar 13, 2018 at 9:47 AM, Hans de Goede wrote: > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > Because this tablet, like (almost?) all Bay Trail hardware has a 32 bit > UEFI, > e

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 10:23, Thiebaud Weksteen wrote: > On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel > wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: ... >> > Could the problem perhaps be that the new code for the TPM event-log is >> > missing some handling to deal with running on a

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Thiebaud Weksteen via tpmdd-devel
On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: > > Hi, > > > > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: > >> > ... > >> > >> Hans, you said you configured the tablet to use the 32-bit version of grub > >> instead > >> of 64. Why's t

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 07:59, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the 32-bit version of grub >>> instead >>> of 64. Why's that? >> >> >> B

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 07:47, Hans de Goede wrote: > Hi, > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... >> >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > > > Because this tablet, like (almost?) all Bay Trail hardware has a 32

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Thiebaud Weksteen via tpmdd-devel
On Mon, Mar 12, 2018 at 10:03 PM Ard Biesheuvel wrote: > On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > > > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > > ard.biesheu.

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >> > wrote: >> > >> >> On 12 March 2018 at 17:01, Jere

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Thiebaud Weksteen via tpmdd-devel
On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < ard.biesheu...@linaro.org> > > wrote: > > > >> On 12 March 2018 at 17:01, Jeremy Cline wrote: > >>> On 03/12/2018 10:56 AM, Ard Biesheuvel w

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Thiebaud Weksteen via tpmdd-devel
On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel wrote: > On 12 March 2018 at 17:01, Jeremy Cline wrote: > > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: > >> On 12 March 2018 at 14:30, Jeremy Cline wrote: > >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10 March 2018 at 10:45, Thie

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 17:01, Jeremy Cline wrote: > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >> On 12 March 2018 at 14:30, Jeremy Cline wrote: >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 14:30, Jeremy Cline wrote: > On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >>> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >>> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > Thanks a

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > >> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: >> > Thanks a lot for trying out the patch! >> > >> > Please don't modify your install at this stage, I think we are hit

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Jarkko Sakkinen
On Sat, 2018-03-10 at 10:45 +, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > > and it's hanging at "memset(log_tbl, 0, sizeof(*log_tbl) + log_size);" > > Thanks. Well, it looks like the memory that is supposedly allocated is not > usable. I'm thinking this is

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-10 Thread Thiebaud Weksteen via tpmdd-devel
On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > > Thanks a lot for trying out the patch! > > > > Please don't modify your install at this stage, I think we are hitting a > > firmware bug and that would be awesome if we can

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-09 Thread James Bottomley
On Fri, 2018-03-09 at 10:29 +0100, Hans de Goede wrote: > Hi, > > On 08-03-18 18:26, Jeremy Cline wrote: > > > > On 03/08/2018 11:50 AM, Hans de Goede wrote: [...] > > > > The UEFI firmware does some measurements and so does shim. So > > > > you should have some event logs. What version of shim a

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-09 Thread Thiebaud Weksteen via tpmdd-devel
On Fri, Mar 9, 2018 at 10:29 AM Hans de Goede wrote: > Hi, > On 08-03-18 18:26, Jeremy Cline wrote: > > On 03/08/2018 11:50 AM, Hans de Goede wrote: > >> >> added these now> > >> > >> Hi, > >> > >> On 07-03-18 12:34, Javier Martinez Canillas wrote: > > > > > > > >>> Are you also able to read t

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-08 Thread Thiebaud Weksteen via tpmdd-devel
On Wed, Mar 7, 2018 at 6:33 PM Jeremy Cline wrote: > On 03/07/2018 03:41 AM, Thiebaud Weksteen wrote: > > Hi, > > > > Thanks for testing and sending this report! This patch relies heavily on > > the functions exposed by the firmware. My first guess would be that some of > > these may not be imple

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-07 Thread Javier Martinez Canillas
Hi Hans, On 03/07/2018 12:16 PM, Hans de Goede wrote: > Hi, > > On 07-03-18 09:41, Thiebaud Weksteen wrote: >> Hi, >> >> Thanks for testing and sending this report! This patch relies heavily on >> the functions exposed by the firmware. My first guess would be that some of >> these may not be impl

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-07 Thread Thiebaud Weksteen via tpmdd-devel
Hi, Thanks for testing and sending this report! This patch relies heavily on the functions exposed by the firmware. My first guess would be that some of these may not be implemented correctly by the manufacturer. Could you share more information on this specific device? Do you have any link to th