Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot

2017-04-06 Thread Jason Gunthorpe
On Thu, Apr 06, 2017 at 08:26:22PM +0200, Paul Menzel wrote: > >We added direct ACPI binding to the driver in addition to PNP, so if > >you have an ACPI table it goes down that path and does some additional > >validation of what is in the TPM. The BIOS must provide a > >acpi_dev_resource_memory

Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot

2017-04-06 Thread Jarkko Sakkinen
On Thu, Apr 06, 2017 at 10:55:57AM -0600, Jason Gunthorpe wrote: > On Thu, Apr 06, 2017 at 08:18:33AM +0200, Paul Menzel wrote: > > > Indeed, that improves the situation. I still need to pass `force=1` to the > > module to get `/dev/tpm0`. No idea, why it’s not in included in Linux 4.9 > > yet. >

Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot

2017-04-06 Thread Paul Menzel
On 2017-04-06 18:55, Jason Gunthorpe wrote: > On Thu, Apr 06, 2017 at 08:18:33AM +0200, Paul Menzel wrote: > >> Indeed, that improves the situation. I still need to pass `force=1` to >> the >> module to get `/dev/tpm0`. No idea, why it’s not in included in Linux >> 4.9 >> yet. > > Fair point..

Re: [tpmdd-devel] [RFC PATCH] tpm: msleep() delays - replace with usleep_range() in i2c nuvoton driver

2017-04-06 Thread Nayna
We continued analyzing the msleep() behaviour. I tested running msleep() (without TPM interactions), by writing a kernel module that runs msleep() in a loop for a fixed number of iterations. Based on these test results, as shown below, the observations are: 1. Non-cascading timers, as

Re: [tpmdd-devel] Regression between Linux 3.16 and 4.8/4.9 on Lenovo X60 with coreboot

2017-04-06 Thread Maciej S. Szmigiero
On 04/06/17 08:18, Paul Menzel wrote: > Dear Maciej, > > On 2017-04-05 13:03, Maciej S. Szmigiero wrote: > >>> tpm tpm0: Unable to read burstcount >>> tpm tpm0: tpm_transmit: tpm_send: error -16 >>> tpm_tis tpm_tis: Could not get TPM timeouts and durations >> >> This looks like a regression I

Re: [tpmdd-devel] [PATCH 4/4] tpm: introduce tpm_extend_pcr_digests()

2017-04-06 Thread Jarkko Sakkinen
On Wed, Apr 05, 2017 at 03:50:08PM +0200, Roberto Sassu wrote: > On 4/5/2017 2:14 PM, Jarkko Sakkinen wrote: > > On Wed, Mar 29, 2017 at 12:24:52PM +0200, Roberto Sassu wrote: > > > Allow TPM users to provide a digest for each PCR bank, > > > for the extend operation. > > > > > > Signed-off-by:

Re: [tpmdd-devel] [PATCH 4/4] Improve handling of TPM2 event logs

2017-04-06 Thread Jarkko Sakkinen
On Thu, Apr 06, 2017 at 09:44:54AM +0300, Jarkko Sakkinen wrote: > On Thu, Apr 06, 2017 at 09:35:34AM +0300, Jarkko Sakkinen wrote: > > On Wed, Apr 05, 2017 at 01:29:29PM -0700, Petr Vandrovec wrote: > > > Jarkko Sakkinen wrote: > > > > On Wed, Mar 29, 2017 at 12:43:30AM -0700, Petr Vandrovec

Re: [tpmdd-devel] [PATCH 4/4] Improve handling of TPM2 event logs

2017-04-06 Thread Jarkko Sakkinen
On Thu, Apr 06, 2017 at 09:35:34AM +0300, Jarkko Sakkinen wrote: > On Wed, Apr 05, 2017 at 01:29:29PM -0700, Petr Vandrovec wrote: > > Jarkko Sakkinen wrote: > > > On Wed, Mar 29, 2017 at 12:43:30AM -0700, Petr Vandrovec wrote: > > > > From: Petr Vandrovec > > > > > > > > When

Re: [tpmdd-devel] [PATCH 4/4] Improve handling of TPM2 event logs

2017-04-06 Thread Jarkko Sakkinen
On Wed, Apr 05, 2017 at 01:29:29PM -0700, Petr Vandrovec wrote: > Jarkko Sakkinen wrote: > > On Wed, Mar 29, 2017 at 12:43:30AM -0700, Petr Vandrovec wrote: > > > From: Petr Vandrovec > > > > > > When TPM2 log has entries with more than 3 digests, or with digests > > > not listed