Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-16 Thread Nayna
Sure Jason.. Taking care of split and other fixes in my V3 version of patch. Thanks & Regards, - Nayna On 08/13/2016 08:15 AM, Jason Gunthorpe wrote: > On Wed, Aug 10, 2016 at 04:42:20PM +0530, Nayna wrote: >> Thanks for reviewing. >> >> Sure, I will post next version with split as two

Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-12 Thread Jason Gunthorpe
On Wed, Aug 10, 2016 at 04:42:20PM +0530, Nayna wrote: > Thanks for reviewing. > > Sure, I will post next version with split as two patches and other fixes as > suggested. Below is the breakdown of two patches, let me know if this > doesn't sound ok. > > 1. First patch to clean up the code

Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-10 Thread Jarkko Sakkinen
On Tue, Aug 09, 2016 at 03:34:53PM -0400, Nayna Jain wrote: > Refactored eventlog.c file into tpm_eventlog.c and tpm_eventlog_init.c > > Breakdown is: > > * tpm_eventlog_init.c : Moved eventlog initialization methods like > to setup securityfs, to open and release seqfile from tpm_eventlog.c >

Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-10 Thread Nayna
Thanks for reviewing. Sure, I will post next version with split as two patches and other fixes as suggested. Below is the breakdown of two patches, let me know if this doesn't sound ok. 1. First patch to clean up the code related to tpm_eventlog_init.c - generic open() and bios_dir as dentry

Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-10 Thread Jarkko Sakkinen
On Tue, Aug 09, 2016 at 04:27:40PM -0600, Jason Gunthorpe wrote: > On Tue, Aug 09, 2016 at 03:34:53PM -0400, Nayna Jain wrote: > > Refactored eventlog.c file into tpm_eventlog.c and tpm_eventlog_init.c > > > > Breakdown is: > > > > * tpm_eventlog_init.c : Moved eventlog initialization methods

Re: [tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-09 Thread Jason Gunthorpe
On Tue, Aug 09, 2016 at 03:34:53PM -0400, Nayna Jain wrote: > Refactored eventlog.c file into tpm_eventlog.c and tpm_eventlog_init.c > > Breakdown is: > > * tpm_eventlog_init.c : Moved eventlog initialization methods like > to setup securityfs, to open and release seqfile from tpm_eventlog.c >

[tpmdd-devel] [PATCH v2 1/3] TPM2.0: Refactored eventlog init functions.

2016-08-09 Thread Nayna Jain
Refactored eventlog.c file into tpm_eventlog.c and tpm_eventlog_init.c Breakdown is: * tpm_eventlog_init.c : Moved eventlog initialization methods like to setup securityfs, to open and release seqfile from tpm_eventlog.c to this file. This is to keep the logic of initialization for TPM1.2 and