On Wed, Aug 10, 2016 at 04:42:20PM +0530, Nayna wrote: > Thanks for reviewing. > > Sure, I will post next version with split as two patches and other fixes as > suggested. Below is the breakdown of two patches, let me know if this > doesn't sound ok. > > 1. First patch to clean up the code related to tpm_eventlog_init.c - generic > open() and bios_dir as dentry array.
Split the patches further. One idea per patch. > 2. Second patch to have changes related to using of_node property and struct > tpm_chip in tpm_of.c. Includes adding CONFIG_OF. Yes > And one feedback which I didn't understand and so need your help with that > is > > >> -extern struct dentry **tpm_bios_log_setup(const char *); > >> -extern void tpm_bios_log_teardown(struct dentry **); > >> +extern void tpm_bios_log_setup(struct tpm_chip *chip); > >> +extern void tpm_bios_log_teardown(struct tpm_chip *chip); > > > > We are trying to get rid of these extra externs.. > > This is currently called by tpm_chip_register to setup the bios log. > So, what did it meant by getting rid of these ? The word extern in this context is unnecessary, just drop it when you edit the line. Jason ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
