Re: [tpmdd-devel] [PATCH 1/2] efi: call get_event_log before ExitBootServices

2017-09-06 Thread Ard Biesheuvel
Hi Thiebaud, On 6 September 2017 at 15:25, Thiebaud Weksteen wrote: > With TPM 2.0, access to the event log is only possible by using the > EFI TPM2 Boot Service. Modify the EFI stub to copy the log area to a new > Linux-specific EFI table so it remains accessible for future use. > > Signed-off-b

Re: [tpmdd-devel] [PATCH 2/2] tpm: surface TPM event log based on EFI table

2017-09-06 Thread Ard Biesheuvel
On 6 September 2017 at 15:25, Thiebaud Weksteen wrote: > Signed-off-by: Thiebaud Weksteen No empty commit logs please. If you expect people to review your code, you really need to explain what it does and why. On top of that, a cover letter that summarizes it and keeps track of the changes betwe

Re: [tpmdd-devel] [PATCH 1/2] efi: call get_event_log before ExitBootServices

2017-09-06 Thread Ard Biesheuvel
On 6 September 2017 at 15:53, Ard Biesheuvel wrote: > Hi Thiebaud, > > On 6 September 2017 at 15:25, Thiebaud Weksteen wrote: >> With TPM 2.0, access to the event log is only possible by using the >> EFI TPM2 Boot Service. Modify the EFI stub to copy the log area to a new

Re: [tpmdd-devel] [PATCH 1/2] efi: call get_event_log before ExitBootServices

2017-09-07 Thread Ard Biesheuvel
On 7 September 2017 at 16:24, Thiebaud Weksteen wrote: > Hi Ard, > > Thanks for reviewing the patch. (Non-addressed comments are fixed in the > next patch set). > > On Wed, Sep 06, 2017 at 03:53:33PM +0100, Ard Biesheuvel wrote: >> Hi Thiebaud, >> >> On

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: > On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: > >> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: >> > Thanks a lot for trying out the patch! >> > >> > Please don't modify your install at this stage, I think we are hit

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 14:30, Jeremy Cline wrote: > On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >>> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >>> >>>> On Fri, Mar 09, 2018 at 10:43:50AM +,

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 17:01, Jeremy Cline wrote: > On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >> On 12 March 2018 at 14:30, Jeremy Cline wrote: >>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >>>> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >>>&

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Ard Biesheuvel
On 12 March 2018 at 19:55, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >> > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >> > wrot

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 07:47, Hans de Goede wrote: > Hi, > > > On 12-03-18 20:55, Thiebaud Weksteen wrote: >> ... >> >> Hans, you said you configured the tablet to use the 32-bit version of grub >> instead >> of 64. Why's that? > > > Because this tablet, like (almost?) all Bay Trail hardware has a 32

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 07:59, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 10:23, Thiebaud Weksteen wrote: > On Tue, Mar 13, 2018 at 8:59 AM Ard Biesheuvel > wrote: > >> On 13 March 2018 at 07:47, Hans de Goede wrote: ... >> > Could the problem perhaps be that the new code for the TPM event-log is >> > missing some

Re: [tpmdd-devel] Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Ard Biesheuvel
On 13 March 2018 at 13:41, Jeremy Cline wrote: > On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: >> On 13 March 2018 at 07:47, Hans de Goede wrote: >>> Hi, >>> >>> >>> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>>> >> ... >&

Re: [tpmdd-devel] [PATCH] drivers: firmware: efi: fix gcc warning -Wint-conversion

2019-06-19 Thread Ard Biesheuvel
(+ Jarkko, tpmdd, Matthew) On Sat, 15 Jun 2019 at 06:02, Hariprasad Kelam wrote: > > This patch fixes below warning > > drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of > ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast > [-Wint-conversion] > > Signed-off-by: H