[Trac-dev] Discussing two changesets

2007-02-19 Thread Manuzhai
Hello all, I'd like to discuss two recent changesets with which I don't necessarily agree. The first is r4769 [1], which fixes issue #3421 [2]. This patch visually merges two or more consecutive changesets when the author and commit messages are the same, but I'm not sure this is a good idea.

[Trac-dev] Re: Discussing two changesets

2007-02-19 Thread Christian Boos
Hello Manuzhai, Manuzhai wrote: So I'd like to ask the list to consider these sentiments. ... Well, there's no point to jumping on the guns, as changes can always be discussed/amended. It's not because those changes are going into trunk that they're carved in stone. Quite to the

[Trac-dev] Re: Constructing trac base URL

2007-02-19 Thread Noah Kantrowitz
For 0.10, use req.href() or req.abs_href(). --Noah On Feb 19, 2007, at 5:38 AM, Christian Aust wrote: Hi, what's the recommended way for a component to evaluate the base URL of the current trac environment? I'm confused of when to use self.env.href, self.env.abs_href or Href(...) Would

[Trac-dev] Re: Discussing two changesets

2007-02-19 Thread Emmanuel Blot
I'll second this. I don't want Trac coalescing changesets. So do I. I'm not sure whether this feature can be useful, but if it is implemented and kept, it should be optional and *not* be enabled in the default settings. Knowing that there is a proliferation of configuration options that will