Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread RjOllos
On Sunday, July 27, 2014 10:49:18 PM UTC-7, Peter Suter wrote: On 28.07.2014 01:01, Jared Bownds wrote: Thanks for the feedback, i'm now confident ReadonlySignedTickets.py is enabled as a plugin. I've run a few tests on the code below. I created a user called temp1 that does

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
I'm receiving the same error. It can be reproduced by navigating to the any ticket *Stack trace:* https://gist.github.com/anonymous/c00aadd7d9a807d8b371 On Sun, Jul 27, 2014 at 11:55 PM, RjOllos rjol...@gmail.com wrote: On Sunday, July 27, 2014 10:49:18 PM UTC-7, Peter Suter wrote: On

[Trac] Unable to complete upgrade to 1.0.1

2014-07-28 Thread Anton Piatek
I just upgraded my Ubuntu 12.04 server to 14.04.1 and as part of that upgraded trac. I get the following error trying to complete the upgrade of trac when running the trac-admin ... upgrade command The upgrade failed. Please fix the issue and try again. AttributeError: I have enabled the

Re: [Trac] Unable to complete upgrade to 1.0.1

2014-07-28 Thread Steffen Hoffmann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28.07.2014 16:02, Anton Piatek wrote: I just upgraded my Ubuntu 12.04 server to 14.04.1 and as part of that upgraded trac. I get the following error trying to complete the upgrade of trac when running the trac-admin ... upgrade command

Re: [Trac] Unable to complete upgrade to 1.0.1

2014-07-28 Thread Ryan Ollos
On Jul 28, 2014 7:22 AM, Anton Piatek anton.pia...@gmail.com wrote: I just upgraded my Ubuntu 12.04 server to 14.04.1 and as part of that upgraded trac. I get the following error trying to complete the upgrade of trac when running the trac-admin ... upgrade command The upgrade failed. Please

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Steffen Hoffmann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28.07.2014 08:55, RjOllos wrote: Btw, in vulnerable_tickets.py, should the check be changed?: if 'VULNERABILITY_VIEW' not in perm: - if 'VULNERABILITY_VIEW' not in perm(resource): It depends on the intention. From earlier discussion I

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Peter Suter
On 28.07.2014 08:55, RjOllos wrote: I'm encountering the dreaded issue: RuntimeError: maximum recursion depth exceeded while calling a Python object The issue seems to be with the check: 'TRAC_ADMIN' in perm. Oops, right. I think adding `action == 'TRAC_ADMIN'` to the check (before the

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Peter Suter
Oops, and now I dropped the `if t['resolution'] == 'Signed':` test by mistake.. {{{ from trac.core import * from trac.perm import IPermissionPolicy from trac.ticket.model import Ticket class ReadonlySignedTickets(Component): implements(IPermissionPolicy) def check_permission(self,

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
You nailed it! The code below works. However, users are still able to 'edit' their own comments once a ticket is resolved as signed. {{{ from trac.core import * from trac.perm import IPermissionPolicy from trac.ticket.model import Ticket class ReadonlySignedTickets(Component):

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
Peter, Should this be included, or excluded? For clarity, please provide the entire block of code that should be used to implement the following behavior: - Once a ticket is resolved as 'Signed', the ticket is now read only except by TRAC_ADMIN Next, how do we implement the desired

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 10:55 AM, Jared Bownds jared.bow...@gmail.com wrote: You nailed it! The code below works. However, users are still able to 'edit' their own comments once a ticket is resolved as signed. {{{ from trac.core import * from trac.perm import IPermissionPolicy from

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 11:26 AM, Jared Bownds jared.bow...@gmail.com wrote: Next, how do we implement the desired error feedback outlined below? - Visually distinguish tickets resolved as 'Signed' by either slightly changing the color of the description body, or add a draft style

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
Hi Ryan, 2. Add site.html to your Environment templates directory: http://trac.edgewall.org/wiki/TracInterfaceCustomization#SiteAppearance (the first code snippet in that section is what you want to copy to site.html) Response: Is this the code I want to add in *site.html* contained within my

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
Peter's plugin shown above work for me on 1.0-stable, and users aren't able to edit comments even if they have been granted TICKET_ADMIN. I used resolution //signed// rather than //Signed// since all of Trac's predefined resolutions are in lowercase. I'm running version 1.0 On Monday, July

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 1:03 PM, Jared Bownds jared.bow...@gmail.com wrote: Hi Ryan, 2. Add site.html to your Environment templates directory: http://trac.edgewall.org/wiki/TracInterfaceCustomization#SiteAppearance (the first code snippet in that section is what you want to copy to

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 1:26 PM, Jared Bownds jared.bow...@gmail.com wrote: Hi Ryan, I'm using style.css, and it does show up in the source. The casing of Signed might cause an issue, but probably not. I left out a step: [ticket] decorate_fields = resolution -- You received this message

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
I left out a step: [ticket] decorate_fields = resolution I added to trac.ini, it's still not working. I'm at a loss as to why it's not working. [ticket] decorate_fields = resolution Here is a snippet from the log 2014-07-28 13:53:09,218 Trac[main] DEBUG: Dispatching RequestWithSession GET

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
Also, it turns out the this bit of code is not working. I thought it was working, but it turns out the test user (temp1) was not authenticated. Judging by the log, it seems as though everything is working as you would expect, temp1 should not be able to edit the request. However, the update

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 1:54 PM, Jared Bownds jared.bow...@gmail.com wrote: I left out a step: [ticket] decorate_fields = resolution I added to trac.ini, it's still not working. I'm at a loss as to why it's not working. [ticket] decorate_fields = resolution Here is a snippet from the

[Trac] Re: Custom fields in a custim ticket query

2014-07-28 Thread RjOllos
On Friday, February 1, 2013 8:15:52 AM UTC-8, Roger Oberholtzer wrote: On trac 0.12.3, I am doing a custom ticket query. In that context, custom ticket fields show up in everything - except the Group results by item. Do I need to do anything to make them available there? There are some

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 2:20 PM, Jared Bownds jared.bow...@gmail.com wrote: I think your onto something, the plugin may not be loading. Has anyone encountered this error before? Also, I opened a ticket regarding the error. http://trac-hacks.org/ticket/11889 *Trac detected an internal

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
I think your onto something, the plugin may not be loading. Has anyone encountered this error before? Also, I opened a ticket regarding the error. http://trac-hacks.org/ticket/11889 *Trac detected an internal error:* AttributeError: 'datetime.timedelta' object has no attribute

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
DevayedWiki was causing a problem, thanks for pointing that out - below is my configuration in trac.ini I'm still not sure why it's not working. Do you have any other ideas on what I can check? [components] contextchrome.cors.crossoriginresourcesharingenabler = disabled

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 3:01 PM, Jared Bownds jared.bow...@gmail.com wrote: DevayedWiki was causing a problem, thanks for pointing that out - below is my configuration in trac.ini I'm still not sure why it's not working. Do you have any other ideas on what I can check? [components]

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
Is that not the following? Trac[loader] DEBUG: Loading ContextChrome from /srv/trac/trac/plugins/ContextChrome-0.3-py2.6.egg On Mon, Jul 28, 2014 at 3:16 PM, Ryan Ollos rjol...@gmail.com wrote: On Mon, Jul 28, 2014 at 3:01 PM, Jared Bownds jared.bow...@gmail.com wrote: DevayedWiki was

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Ryan Ollos
On Mon, Jul 28, 2014 at 3:42 PM, Jared Bownds jared.bow...@gmail.com wrote: Is that not the following? Trac[loader] DEBUG: Loading ContextChrome from /srv/trac/trac/plugins/ContextChrome-0.3-py2.6.egg That looks good. Does the opening body tag on the ticket page have the class

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
resolution_is_signedbody class=resolution_is_Signed Taskdiv id=WzTtDiV style=visibility: hidden; position: absolute; overflow: hidden; padding: 0px; width: 1679px; left: -1680px; top: 0px;/div On Mon, Jul 28, 2014 at 3:46 PM, Ryan Ollos rjol...@gmail.com wrote: On Mon, Jul 28, 2014 at 3:42

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
I found it, it is case sensitive. According the the class name, resolution_is_signedbody class=resolution_is_Signed Taskdiv id=WzTtDiV style=visibility: hidden; position: absolute; overflow: hidden; padding: 0px; width: 1679px; left: -1680px; top: 0px;/div On Mon, Jul 28, 2014 at 3:46 PM,

Re: [Trac] Read only ticket according to custom resolution type

2014-07-28 Thread Jared Bownds
I found it, it is case sensitive. According the the class name, style.css needs to contain: style.css body.resolution_is_*S*igned { background-color: #b3caf5; /* soft blue */ } body tag resolution_is_signedbody class=resolution_is_Signed Taskdiv id=WzTtDiV style=visibility: hidden; position:

Re: [Trac] CommitTicketUpdate does not seem to be checking permission (Git)

2014-07-28 Thread Ryan Ollos
On Fri, Jul 18, 2014 at 8:13 AM, Sylvain Raybaud sylvain.rayb...@gmail.com wrote: Dear Trac users community, I'm facing a problem with my company trac installation. I've got a trac installation with a bunch of registered users (usernames and passwords in /var/trac/main/digest). But whoever

[Trac] Re: Read only ticket according to custom resolution type

2014-07-28 Thread Franz
Hi Jared, we need a similar solution. In our case, it's probably named released (instead of signed). The use-case is that nobody should change ticket properties when the ticket is released (only commenting). Have you created a Trac-Plugin on Trac-hacks [1] for that solution? Thank you, Franz