Maciej Szulik <solt...@gmail.com> added the comment:
One other option is to give different priorities. For example, if title has
bpo- we don't look further in the body and assume this is it. But I bet
people will complain about that approach as well. I doubt there's a golden
middle
Maciej Szulik added the comment:
> So after http://psf.upfronthosting.co.za/roundup/meta/msg3305 and
> http://psf.upfronthosting.co.za/roundup/meta/msg3306 I explicitly said "I'll
> commit it when I get a code review, thanks!" in my earlier comment, and you
> still did t
Maciej Szulik added the comment:
I'm back right now and just starting the initial work.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
We're currently working with Mark to migrate bpo to a different server. I'll
make sure this is fixed along the way.
--
nosy: +maciej.szulik
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co
Maciej Szulik added the comment:
I've personally used multiple issues under single PR (not for python, but in
general), but that was never than 2 or 3. So completely disabling, or rather
limiting to 1 is not a good solution. Lowering the limit by half, from 10 to 5,
seems ok to me
Maciej Szulik added the comment:
Initial patch from Ezio with my addons applied in
https://hg.python.org/tracker/roundup/rev/51efd8e5b8a8
--
status: in-progress -> testing
___
PSF Meta Tracker <metatrac...@psf.upfronthosting
Maciej Szulik added the comment:
Updated version with issue comment handled, as well.
--
nosy: +maciej.szulik
status: unread -> in-progress
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronth
Maciej Szulik added the comment:
Sorry Berker, didn't want to offend you by doing so.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
Updated patch with my changes applied here:
https://hg.python.org/tracker/roundup/rev/6d6954a7b401
--
status: chatting -> resolved
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za&
Maciej Szulik added the comment:
I've added more logging:
https://hg.python.org/tracker/roundup/rev/b5c6f372b227
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
I've created alternate solution in this patch:
http://psf.upfronthosting.co.za/roundup/meta/file459/issue613.patch
--
nosy: +maciej.szulik
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co
Maciej Szulik added the comment:
Brett, can I ask you to send me directly (or attach here) some of those
rejected requests? Based on the current one I don't see anything suspicious,
but maybe I'm overlooking something...
___
PSF Meta Tracker
Maciej Szulik added the comment:
Brett, the most worrying thing is missing `X-Hub-Signature` header in the
request from http://psf.upfronthosting.co.za/roundup/meta/msg3281. I've
uploaded tweaked patch from Berker but I've mostly switched to logging, we
don't want to simplify hacking our
Maciej Szulik added the comment:
Anish thanks! I had to tweak the patch a bit (just tests), since you forgot to
include pushevent5.txt, but I've created it manually :)
The change was pushed in https://hg.python.org/tracker/roundup/rev/3050f361cf3e
--
status: chatting -> test
Maciej Szulik added the comment:
Yeah, as soon as I fix the local testing of those things I'll get back to
having 4-digit requirement for bpo issues, that should additionally save us
from unnecessary errors, like the one above.
___
PSF Meta
Maciej Szulik added the comment:
Committed in https://hg.python.org/tracker/roundup/rev/bcf18f92716d.
--
status: in-progress -> testing
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronth
Maciej Szulik added the comment:
Patch updated and most importantly tested with github. Comments inline below:
> I think you'll end up with a user_id in the >1 case and a list (assuming
> filter returns a list) in the <1 case. At the end you take the first element
> of
Maciej Szulik added the comment:
Done in https://hg.python.org/tracker/roundup/rev/719a007ca12d and
https://hg.python.org/tracker/python-dev/rev/74d7030f0eef
Thanks everyone for help!
--
status: in-progress -> testing
___
PSF M
Maciej Szulik added the comment:
Still LGTM.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
SGTM
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
LGTM, Ezio or David mind merging this?
--
nosy: +ezio.melotti, maciej.szulik, r.david.murray
status: unread -> chatting
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za&
Maciej Szulik added the comment:
I'm uploading the current version of the patch, it's still not fully reviewed,
I've left a few TODO's here and there for what should be double checked.
___
PSF Meta Tracker <metat
Maciej Szulik added the comment:
Uploading fixed patch with Ezio's changes.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
The alternate version with pr number and repository fields.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
I've added slight changes to previous patch, fixing the look of the PRs table
and the class in hgrepos table header (it had typo, Header vs header).
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co
Maciej Szulik added the comment:
Permissions problem should be addressed as well, since I've added option to
unlink, rather than remove. Similarly to what is available for files.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co
Maciej Szulik added the comment:
Apparently I can't leave title set to none, I had to explicitly set it to empty
if none is set.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/rou
Maciej Szulik added the comment:
Addressed 1, 2, 4, 5. I'll handle 3rd along with title as a followup issue.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
> I have updated the patch.
Thank you, the patch itself LGTM.
> > We do need proper error handling, still.
> The problem is "err" variable has stdout of that process. So, even if we
> change/push branch, it will be non-empty. Any idea
Maciej Szulik added the comment:
LGTM
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
Thanks, works ok.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
Anish, can you please update the roundup part so that it applies cleanly and
apply all the suggestions discussed on core-workflow mailing list?
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
Maciej Szulik added the comment:
Anish while reviewing 592 I've got into trouble applying the roundup part on
top of 589, I guess due to the amount of changes in it. Can you please update
the patch so it applies cleanly?
___
PSF Meta Tracker
Maciej Szulik added the comment:
LGTM
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
> Sorry. I didn't get you. You mean, same tests for PR body, right?
Yeah, exactly that. I'd like to see both body and title tests. Sorry I was
initially noting down my thoughts and apparently forgot to "normalize" that
part of the sent
Maciej Szulik added the comment:
LGTM
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
roundup/pull_request.py:
> key = os.environ['SECRET_KEY']
If this env is missing the code throws KeyError, which is not nice. It would be
better
to check if it exists and fail nicely, informing about the problem.
> def testPullRequestEventForTitl
Maciej Szulik added the comment:
@Berker the work included in this issue is the main part of Anish work during
his GSoC time. I'm currently in the process of reviewing his submissions.
___
PSF Meta Tracker <metat
Maciej Szulik added the comment:
@David, @Berker the original idea of this patch is to entirely ignore gh
notifications and have that information available in bpo. Moreover, instead of
a bunch of comments you should get one combined information that the review has
be posted with a link
Maciej Szulik added the comment:
@anish since issue 589 needs update so does this one.
--
nosy: +anish.shah
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
@berker I've decided to split this into several steps for simplicity of
tracking Anish progress. For that I'd prefer to keep it separate, if you don't
mind.
___
PSF Meta Tracker <metat
Maciej Szulik added the comment:
@anish.shah
I still don't see my comments from previous review addressed. Additionally,
since issue 586 has changed the schema you should update it here as well.
@David:
> Hmm. Good question. We could use a specific user to create such issues.
The ot
Maciej Szulik added the comment:
LGTM
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Maciej Szulik added the comment:
@rouilj it's currently stuck, hopefully after summer I'll be able to get back
to the topic. Sorry :(
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/rou
Maciej Szulik added the comment:
@anish.shah
roundup/github_pullrequest_url.py
> def __init__(self, client):
>
> self._validate_webhook_secret()
> self._verify_request()
> self._extract()
Don't put the entire action in the constructor of the object. Its
Maciej Szulik added the comment:
@anish.shah
> I'm reconstructing because URL might contain fragment identifier/query
> string. What do you think?
Doesn't matter, the parsed_url is just an object representation of that url.
> I will change this. But, I will need to change th
Maciej Szulik added the comment:
Pefu my work is based on top of work started during GSoC. For now I've decided
to cut the current implementation just to have GET working (needed for github
migration). I'm hoping to work on enabling other actions as well. At the end of
the day my hope is we
Maciej Szulik added the comment:
The auth error seems to be minor with the fact that passing non-existent auth
data gives me full access to any data. Working on it now...
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
Maciej Szulik added the comment:
Still needs fixing:
- auth error
Additionally, if we want full-REST support we need:
- decide if we want to have delete at all
- post using json, not just form-data, since we return GET data with json
- fix validation when post-ing
Maciej Szulik added the comment:
This partially derived from #579.
Previous problem I've described was that any user was able to see others full
details, including password. I've finally nailed what was the problem when
calling hasPermissions item_id was not passed. I've fixed that and added
New submission from Maciej Szulik:
Copied from http://bugs.python.org/issue26399:
The "Download as CSV " feature of bugs.python.org does not properly "escape"
fields. This allows an adversary to turn a field into active content so when we
download the csv and opens it, the
Maciej Szulik added the comment:
After further investigating into the rest patch that I temporarily applied here
https://bitbucket.org/soltysh/roundup/branch/rest my current findings are:
- we return too much information on GET, any authenticated user gets ALL of the
details from any user
Maciej Szulik added the comment:
I've added the search for github user name according to the discussion on IRC.
I'm including the patch, but for the record, it's also being available at
https://bitbucket.org/soltysh/python-dev/branch/github
Maciej Szulik added the comment:
I did initial check whether patch from
https://bitbucket.org/kinggreedy1991/roundup-bpo/branc
hes/compare/kinggreedy1991/roundup-bpo:tip%0Dezio_melotti/roundup-bpo:bugs.python.org#diff
works correctly. From initial glimpses it's working ok, though I reserve
Maciej Szulik added the comment:
No, I have not :/ Lemme you give it a try and check those details.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
New submission from Maciej Szulik:
Add github field to user profile.
--
assignedto: ezio.melotti
files: gh.diff
messages: 3001
nosy: ezio.melotti, maciej.szulik
priority: feature
status: in-progress
title: Add github field in user profile
56 matches
Mail list logo
