Maciej Szulik added the comment: @anish.shah
> I'm reconstructing because URL might contain fragment identifier/query > string. What do you think? Doesn't matter, the parsed_url is just an object representation of that url. > I will change this. But, I will need to change this in all the patches that > I have submitted. Sorry, but yes please. And apply Berker's suggestion of not having github word in it, as well. > I have added a 'state' field in issue590 Cool. @Berker > Issue 589 is a different feature and it should be discussed there (by the way > it would be really nice if you could give more information about the feature > and the patch -- I had to read the whole patch to understand what it does). > The problem with this implementation is that I will need to go to > bugs.python.org/issueXXXX and paste a URL everytime I open a pull request on > GitHub. Instead of this manual step, Roundup should automatically look for > "Issue #NNNN" in all pull request titles and list all matched items by using > JavaScript on bugs.python.org/issueXXXX. It's exactly like David is saying. With issue 589 b.p.o is notified through github webhook of new events, such as PRs in which we parse the title and comment in search for bpoNNN and link the PR automatically. The idea of having a client side javascript assuming you have a gh opened in one tab and bpo in other doesn't seem right. I'm currently reviewing Anish all submissions from his GSoC and he'll soon create an extensive article describing all the things he has done. Anyway thanks for your time and review! _______________________________________________________ PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za> <http://psf.upfronthosting.co.za/roundup/meta/issue586> _______________________________________________________ _______________________________________________ Tracker-discuss mailing list Tracker-discuss@python.org https://mail.python.org/mailman/listinfo/tracker-discuss Code of Conduct: https://www.python.org/psf/codeofconduct/
