Berker Peksag added the comment:
Thanks for the report, but please create a new issue at
https://bugs.python.org/ or better ask your question at
https://mail.python.org/mailman/listinfo/python-list first. This tracker is for
development of our Roundup instance.
--
nosy
New submission from Berker Peksag:
>From https://wiki.python.org/moin/DesiredTrackerFeatures
> When an issue is closed stage should be automatically set to 'resolved'.
--
files: setresolved.diff
messages: 3041
nosy: berker.peksag
priority: feature
status: unread
title: Set
New submission from Berker Peksag:
See https://mail.python.org/pipermail/tracker-discuss/2007-June/000895.html for
discussion. The file can be seen at
http://bugs.python.org/@@file/recent-changes.xml
--
files: delete_changes_xml_writer.diff
messages: 3045
nosy: berker.peksag
priority
Berker Peksag added the comment:
This has been fixed recently.
--
nosy: +berker.peksag
status: chatting -> resolved
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/m
New submission from Berker Peksag:
This is one of my biggest annoyances of the current tracker. We should hide
queries if they are marked as 'retired'.
--
files: hide_retired_queries.diff
messages: 3046
nosy: berker.peksag
priority: bug
status: unread
title: Hide retired queries
Berker Peksag added the comment:
Duplicate of issue 387.
--
nosy: +berker.peksag
status: chatting -> resolved
superseder: +Need OpenID login for this tracker
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za&
Berker Peksag added the comment:
Duplicate of issue 551.
--
assignedto: geosim ->
nosy: +berker.peksag -geosim
status: in-progress -> resolved
superseder: +Make the user form uneditable if current user is not authenticated
and is not the owner of the profile -"broken for
New submission from Berker Peksag:
Here is an example http://bugs.python.org/issue25413#msg268427
--
messages: 3048
nosy: berker.peksag
priority: feature
status: unread
title: Strip content when replying to an issue via email
___
PSF
Berker Peksag added the comment:
So does that mean that the current 'Delete' button at query?@template=edit is
sort of misnamed (it actually retires the query)?
Instead of two steps (retire -> delete) can we just delete the query?
___
Berker Peksag added the comment:
Or maybe we can have two buttons: Retire (the current behavior) and Delete
We can mark retired queries with a different background in the sidebar.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co
New submission from Berker Peksag:
I'm getting an import error with the latest version of oic. Here is a patch to
fix this.
--
files: oic.diff
messages: 3040
nosy: berker.peksag
priority: bug
status: unread
title: Fix ImportError: cannot import name rndstr in oic_login.py
Berker Peksag added the comment:
Maciej, that sounds good to me but I agree with David. This needs to be
discussed on the core-workflow list. It would be nice to have a some sort of
mockup or flowchart to see what kind of information will be displayed in these
combined comments. It's a bit
Berker Peksag added the comment:
It's broken because we've deleted the devguide repository from hg.python.org.
Here is a patch.
--
nosy: +berker.peksag
status: unread -> chatting
___
PSF Meta Tracker <me
New submission from Berker Peksag:
Thanks for the patches! :)
GitHub already spams every single comment made on a pull request and this will
make it worse. I'm -1 on this.
It's fine if other core developers want to backup review comments, but it
shouldn't be shown on bugs.python.org
Berker Peksag added the comment:
How do you get the correct author information of the patch? I don't think there
is an easy way [1] to extract the author information to use it in the pull
requests.
[1] You could probably check the GitHub username field of the author but you
could have
Berker Peksag added the comment:
Issue 589 is a different feature and it should be discussed there (by the way
it would be really nice if you could give more information about the feature
and the patch -- I had to read the whole patch to understand what it does).
The problem
Berker Peksag added the comment:
+url = newvalues.get('url', '')
You should also return early if there is no 'url' key in newvalues.
i18n:translate="" can be removed. I don't think we are going to support a
non-English language.
I would also prefer a 'remove' link instea
Berker Peksag added the comment:
This is a duplicate of issue 463.
--
nosy: +berker.peksag
status: unread -> resolved
superseder: +HTTPS only version for login for this tracker
___
PSF Meta Tracker <me
New submission from Berker Peksag:
Do we need a separate issue for this? I think this can be done in issue 586.
--
nosy: +berker.peksag
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthost
Berker Peksag added the comment:
I don't have an objection to a general purpose webhook (I wrote such webhooks
for GitHub before.)
Using a webhook for a simple task like this will only make the implementation
more complicated. I don't see a reason to store pull request URLs in database
Berker Peksag added the comment:
The API call in my patch was just an example. GitHub does provide a search API.
However, the problem with my approach is that it ignores rate limiting of
GitHub API: https://api.github.com/rate_limit
So Anish's patch might be more reliable than mine
Berker Peksag added the comment:
The attached patch should fix the empty date issue.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Berker Peksag added the comment:
I tested this again and addressed David's review comment. Applied in
https://hg.python.org/tracker/python-dev/rev/5b89f6f8abd3
--
status: chatting -> testing
___
PSF Meta Tracker <me
Berker Peksag added the comment:
Another alternative is to only send notifications for 2.7 and master branches
for now [1] For example, see http://bugs.python.org/issue29407 we would only
see the latest notification with this approach:
http://bugs.python.org/msg286687 Since commit hashes
New submission from Berker Peksag:
I noticed that developer cannot edit or unlink pull requests. The attached
patch should fix this.
--
messages: 3272
nosy: berker.peksag, ezio.melotti
priority: bug
status: unread
title: Allow developers to edit and unlink pull requests
Berker Peksag added the comment:
Looks good to me too. I can do the merging if David or Ezio are busy.
--
nosy: +berker.peksag
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/rou
Berker Peksag added the comment:
I agree with Ned. Thanks, Ezio!
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Berker Peksag added the comment:
I think you need to be an administrator on that repo to see the payloads.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta
Berker Peksag added the comment:
Next time please let me push my own patches. If you have comments please left
them in the issue first. Doing your own thing on my patches without even try to
communicate is a bit rude.
___
PSF Meta Tracker
Berker Peksag added the comment:
I might miss some other cases, but for example, when you edit a file on GitHub
or when you merge your own PR.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthost
Berker Peksag added the comment:
I believe the 400 status code comes from one of the "raise Reject()" lines in
roundup/github.py. I will try to add some descriptive messages to them to help
debug the issue.
___
PSF Meta Tracker
Berker Peksag added the comment:
Here is a patch that tweaks some exception messages and adds logging.error()
calls in GitHubHandler class.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.z
Berker Peksag added the comment:
I converted Brett's payload example to a test case and I couldn't be able to
create a failing test case. Here is a patch with a test.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
Berker Peksag added the comment:
Here is a patch.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue619>
___diff --g
Berker Peksag added the comment:
Here's the second patch.
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue615>
_
Berker Peksag added the comment:
By the way, I can implement this in
http://psf.upfronthosting.co.za/roundup/meta/issue615
--
nosy: +berker.peksag
status: unread -> chatting
___
PSF Meta Tracker <metatrac...@psf.upfronthosting
Berker Peksag added the comment:
https://github.com/python/planet is probably the better place to report 404
errors.
--
nosy: +berker.peksag
___
PSF Meta Tracker <metatrac...@psf.upfronthosting.co.za>
<http://psf.upfronthost
Berker Peksag <berker.pek...@gmail.com> added the comment:
I agree with Mariatta. We should just look for the PR title. As a fallback, we
can check the body if we can't find an issue number in the title.
--
nosy: +berker.
Berker Peksag added the comment:
Ezio gave his LGTM on #python-dev and I just applied in
https://hg.python.org/tracker/python-dev/rev/aac421fdfffb
--
status: chatting -> resolved
___
PSF Meta Tracker
&l
Berker Peksag added the comment:
Here's a patch to fix this issue.
--
nosy: +berker.peksag, ezio.melotti
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
Addressed Ezio's review comments in issue654_v2.diff.
--
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
> * The server supports only older protocols, but not the current best TLS 1.2.
> Grade capped to C.
There is an open issue for this item: issue 578
I'm not sure whether we should close that as a duplicate of this one.
--
nosy: +berker.
Berker Peksag added the comment:
Good catch, Nick. Fixed in issue645_v2.diff. Thanks!
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue645>
___diff --git
Berker Peksag added the comment:
I just noticed that I probably need to update the clean_ok_message() function
in pydevutils.py to remove pull_requests.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: unread -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
Applied in https://hg.python.org/tracker/python-dev/rev/9c6cedab723d Thanks for
the review, Nick.
--
status: chatting -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundu
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
After 11 years, I think the better place to discuss this is the core-workflow
list. Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resolved
___
PSF Meta Tracker
&l
Berker Peksag added the comment:
I don't think it's worth to add OpenID login since the level of traffic and
active users are pretty low here.
--
nosy: +berker.peksag
status: unread -> resolved
___
PSF Meta Tracker
&l
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
I agree with Serhiy. Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
Ezio has just deployed 9363c06cda40 and confirmed that the bug is fixed.
Closing as 'resolved' again.
--
status: in-progress -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting
Berker Peksag added the comment:
Applied issue654_followup.diff in
https://hg.python.org/tracker/python-dev/rev/9363c06cda40
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
This has already been deployed. Closing as 'resolved'.
--
status: chatting -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
> 1. Add a 't' mark to mark our triagers
Ezio's suggestion in msg3197 is much better than mine. I will open a new issue
when I have a patch.
> 2. List only core developers in the 'assigned to' field
It seems too late to change this one. Othe
Berker Peksag added the comment:
We can use https://github.com/zapier/email-reply-parser to solve this issue.
--
nosy: +ezio.melotti
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundu
Berker Peksag added the comment:
> Ezio's suggestion in msg3197 is much better than mine. I will open a new
> issue when I have a patch.
I've opened issue654.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta
New submission from Berker Peksag :
Here's patch that implements Ezio's suggestion in msg3197.
--
files: add_triager_icon.diff
messages: 3461
nosy: berker.peksag, ezio.melotti, r.david.murray
priority: feature
status: unread
title: Add triager icon
Berker Peksag added the comment:
I've just committed John's suggested approach in
https://hg.python.org/tracker/python-dev/rev/9e1d65b4927c but it needs to be
deployed by bugs.p.o maintainers. Thank you, again!
> I'll keep poking at it to try to figure out why random seems to be
>
Berker Peksag added the comment:
Ezio has just deployed 9e1d65b4927c and I've confirmed that it works on
bugs.python.org. Closing as 'resolved'.
Thanks for the report, Cheryl.
--
status: testing -> resolved
___
PSF Meta Trac
Berker Peksag added the comment:
Implemented Nick's suggestion in
https://hg.python.org/tracker/python-dev/rev/ad6158d8414f
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
Thank you again for taking a look at this, John.
I didn't think about using random.Random() to be honest, thank you Nick! Is
there a reason why random.Random() is undocumented in the random module
documentation
Berker Peksag added the comment:
Ah, I've definitely missed the "You can instantiate your own instances of
Random to get generators that don’t share state." part. Thanks!
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za
Berker Peksag added the comment:
> In windows, we always give a path using '\' and python 3 can correctly dispose
> it just as we using '/' in Linux. But if you offer
> a path in windows with a '\' followed as 'r'. Everyting will goes wrong.
You need to use raw strings to avoid this
Berker Peksag added the comment:
Thanks for the report, but this is not the correct place to report such issues.
Please use https://bugs.python.org/ instead.
Also, I'd first try getting help on python-list
(https://mail.python.org/mailman/listinfo/python-list) or stackoverflow.com
Berker Peksag added the comment:
Thanks for the update, John.
For future readers, here's a link to the discussion on the roundup-devel list:
https://sourceforge.net/p/roundup/mailman/roundup-devel/thread/20180708014103.75EE34C0A5C%40itserver6.localdomain
Berker Peksag <berker.pek...@gmail.com> added the comment:
We may need to set custom rules for caching if we serve bugs.p.o behind Fastly
since data needs to be fresh all the time. Otherwise, we would need to purge
cache everytime we touch an issue.
--
nosy: +berker.
New submission from Berker Peksag :
Currently, I'm getting this email when I've submitted a PR:
--
keywords: +patch
pull_requests: +8502
stage: -> patch review
I think it would be nice if we could try to add the user to nosy list when
attaching a PR to an is
76 matches
Mail list logo
