Berker Peksag added the comment:
The django.contrib.syndication framework uses SITE_ID.
https://docs.djangoproject.com/en/1.4/ref/contrib/sites/#how-django-uses-the-sites-framework
--
nosy: +berker.peksag
___
PSF Meta Tracker
<h
Berker Peksag added the comment:
Thanks for the report, but please create a new issue at
https://bugs.python.org/ or better ask your question at
https://mail.python.org/mailman/listinfo/python-list first. This tracker is for
development of our Roundup instance.
--
nosy
New submission from Berker Peksag:
1. Add a 't' mark to mark our triagers
2. List only core developers in the 'assigned to' field
3. Fix style of the 'Submit Changes' button
--
messages: 3039
nosy: berker.peksag
priority: feature
status: unrea
New submission from Berker Peksag:
I'm getting an import error with the latest version of oic. Here is a patch to
fix this.
--
files: oic.diff
messages: 3040
nosy: berker.peksag
priority: bug
status: unread
title: Fix ImportError: cannot import name rndstr in oic_log
New submission from Berker Peksag:
>From https://wiki.python.org/moin/DesiredTrackerFeatures
> When an issue is closed stage should be automatically set to 'resolved'.
--
files: setresolved.diff
messages: 3041
nosy: berker.peksag
priority: feature
status: unread
tit
Berker Peksag added the comment:
Duplicate of issue 551.
--
assignedto: geosim ->
nosy: +berker.peksag -geosim
status: in-progress -> resolved
superseder: +Make the user form uneditable if current user is not authenticated
and is not the owner of the profile -"broken for
Berker Peksag added the comment:
This is not necessary if you've installed editable version of roundup:
$ pip install -e ../your/roundup/path
--
nosy: +berker.peksag
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za
Berker Peksag added the comment:
Duplicate of issue 387.
--
nosy: +berker.peksag
status: chatting -> resolved
superseder: +Need OpenID login for this tracker
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
New submission from Berker Peksag:
See https://mail.python.org/pipermail/tracker-discuss/2007-June/000895.html for
discussion. The file can be seen at
http://bugs.python.org/@@file/recent-changes.xml
--
files: delete_changes_xml_writer.diff
messages: 3045
nosy: berker.peksag
priority
New submission from Berker Peksag:
This is one of my biggest annoyances of the current tracker. We should hide
queries if they are marked as 'retired'.
--
files: hide_retired_queries.diff
messages: 3046
nosy: berker.peksag
priority: bug
status: unread
title: Hide retired
Berker Peksag added the comment:
This has been fixed recently.
--
nosy: +berker.peksag
status: chatting -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
New submission from Berker Peksag:
Here is an example http://bugs.python.org/issue25413#msg268427
--
messages: 3048
nosy: berker.peksag
priority: feature
status: unread
title: Strip content when replying to an issue via email
___
PSF
Berker Peksag added the comment:
So does that mean that the current 'Delete' button at query?@template=edit is
sort of misnamed (it actually retires the query)?
Instead of two steps (retire -> delete) can we just delete the query?
__
Berker Peksag added the comment:
Or maybe we can have two buttons: Retire (the current behavior) and Delete
We can mark retired queries with a different background in the sidebar.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roun
Berker Peksag added the comment:
+url = newvalues.get('url', '')
You should also return early if there is no 'url' key in newvalues.
i18n:translate="" can be removed. I don't think we are going to support a
non-English language.
I would
Berker Peksag added the comment:
Also, I'm not fan of such a manual work. I would prefer to have a JSON endpoint
which queries open pull requests on python/cpython and match if the title of a
pull request contains the issue number.
You can see https://code.djangoproject.com/ticket/2522
Berker Peksag added the comment:
Issue 589 is a different feature and it should be discussed there (by the way
it would be really nice if you could give more information about the feature
and the patch -- I had to read the whole patch to understand what it does).
The problem with this
Berker Peksag added the comment:
How do you get the correct author information of the patch? I don't think there
is an easy way [1] to extract the author information to use it in the pull
requests.
[1] You could probably check the GitHub username field of the author but you
could ha
New submission from Berker Peksag:
Thanks for the patches! :)
GitHub already spams every single comment made on a pull request and this will
make it worse. I'm -1 on this.
It's fine if other core developers want to backup review comments, but it
shouldn't be shown on bug
New submission from Berker Peksag:
Do we need a separate issue for this? I think this can be done in issue 586.
--
nosy: +berker.peksag
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
I'm not sure I explained myself clearly so here is a quick and dirty patch,
including a screenshot: https://dl.dropboxusercontent.com/u/166024/gh-pr.png
Since I don't have meaningful data I chose Django as
Berker Peksag added the comment:
I don't have an objection to a general purpose webhook (I wrote such webhooks
for GitHub before.)
Using a webhook for a simple task like this will only make the implementation
more complicated. I don't see a reason to store pull request URLs i
Berker Peksag added the comment:
> And if the PR doesn't reference an issue number, it should create a new issue.
Wouldn't that create too much noise for trivial pull requests like typo fixes,
documentation tweaks and code style changes?
Also how do we handle if the user do
Berker Peksag added the comment:
The API call in my patch was just an example. GitHub does provide a search API.
However, the problem with my approach is that it ignores rate limiting of
GitHub API: https://api.github.com/rate_limit
So Anish's patch might be more reliable than
Berker Peksag added the comment:
Sure, I suggested merging this into issue 586 because it was a bit hard to
review and test the patch :)
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
Maciej, that sounds good to me but I agree with David. This needs to be
discussed on the core-workflow list. It would be nice to have a some sort of
mockup or flowchart to see what kind of information will be displayed in these
combined comments. It's
Berker Peksag added the comment:
It's broken because we've deleted the devguide repository from hg.python.org.
Here is a patch.
--
nosy: +berker.peksag
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfr
Berker Peksag added the comment:
This is a duplicate of issue 463.
--
nosy: +berker.peksag
status: unread -> resolved
superseder: +HTTPS only version for login for this tracker
___
PSF Meta Tracker
<http://psf.upfronthosting
Berker Peksag added the comment:
> They are on a path to be a developer, so if they want to use it I don't see
> why they shouldn't.
It creates an unnecessary confusion. I don't want to check
https://docs.python.org/devguide/developers.html everytime I want to commit a
Berker Peksag added the comment:
I don't see a lot of C issues in the "easy issues" list. I agree that some of
them (including a few pure Python ones) shouldn't be classified as "easy".
I'd say we should remove the following issues from the list:
*
Berker Peksag added the comment:
Adding new keywords will make triagers' and core developers' life harder in my
opinion. There are already too much fields and keywords in the issue page.
We probably have 30-35 issues (there are 300+ issues marked as "easy") that
requires
Berker Peksag added the comment:
What do you think about the rest of the patch? Do you want me to remove the
assigned-to part?
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
The patch also helped Ezio so I just committed it in
https://hg.python.org/tracker/python-dev/rev/46237fce3bfe and pinged him.
--
status: unread -> resolved
___
PSF Meta Tracker
&l
Berker Peksag added the comment:
Looks good to me too. I can do the merging if David or Ezio are busy.
--
nosy: +berker.peksag
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
> Also, automatic closure isn't the correct behavior, [...]
I agree with Zachary.
BTW, there is a separate issue to set appropriate fields when an issue is
manually closed: http://psf.upfronthosting.co.za/roundup/meta/issue595 (I
should probably
Berker Peksag added the comment:
Another alternative is to only send notifications for 2.7 and master branches
for now [1] For example, see http://bugs.python.org/issue29407 we would only
see the latest notification with this approach:
http://bugs.python.org/msg286687 Since commit hashes
Berker Peksag added the comment:
I tested this again and addressed David's review comment. Applied in
https://hg.python.org/tracker/python-dev/rev/5b89f6f8abd3
--
status: chatting -> testing
___
PSF Meta Tracke
Berker Peksag added the comment:
The attached patch should fix the empty date issue.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue611>
___diff --git a/r
New submission from Berker Peksag:
See http://bugs.python.org/issue29438#msg287733 for example.
All PRs have been correctly set bpo- in the ir commit messages.
--
messages: 3246
nosy: berker.peksag, ezio.melotti, maciej.szulik
priority: bug
status: unread
title: Commits
Berker Peksag added the comment:
I got an email for http://bugs.python.org/issue29534
Mark Dickinson added the comment:
New changeset 6d1dece06d13a7d40637e07b2c79f34aab368766 by Mark Dickinson in
branch 'master':
Fixed #29534 - _decimal difference with _pydecimal (#65)
https://
Berker Peksag added the comment:
> Note that "Mark Dickinson added the comment" should be "Roundup Robot added
> the comment".
Ezio told me that this was an intentional change. Sorry for the noise.
Brett, is there an easy way to resend payloads so we can de
Berker Peksag added the comment:
> Is the PR id always automatically added at the end of the commit message,
> between (...)?
Yes, but backport PRs can have titles like
Fix some sphinx warnings (#9) (#81)
#9 is the original PR number and #81 is the backport PR number.
See:
New submission from Berker Peksag:
I wonder if we should be defensive and check the value of the stage field first.
--
nosy: +berker.peksag
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundu
New submission from Berker Peksag:
I noticed that developer cannot edit or unlink pull requests. The attached
patch should fix this.
--
messages: 3272
nosy: berker.peksag, ezio.melotti
priority: bug
status: unread
title: Allow developers to edit and unlink pull requests
Berker Peksag added the comment:
Ezio gave his LGTM on #python-dev and I applied the patch in
https://hg.python.org/tracker/python-dev/rev/545a7d7ef9e4.
--
status: unread -> resolved
___
PSF Meta Tracker
&l
New submission from Berker Peksag:
New changeset 6336f0d156feec0f109a8d01da108cf96e3d9c60 by GitHub in branch
'3.5':
bpo-29554: Improve docs for pstat module and profile. (#88) (#228)
https://github.com/python/cpython/commit/6336f0d156feec0f109a8d01da108cf96e3d9c60
I think we
Berker Peksag added the comment:
I can reproduce this again, reopening.
--
status: done-cbb -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
See
https://github.com/python/cpython/commit/0dadf56737f591c83d18db5e445960d39448583e
for example. The commit message contains bpo-29655 and there should be a
comment similar to http://psf.upfronthosting.co.za/roundup/meta/msg3247 at
https://bugs.python.org
Berker Peksag added the comment:
Update: It looks like it sometimes works for 3.6 branch:
* http://bugs.python.org/issue28893#msg288853 (2017-03-03 06:16)
But not for master branch:
* https://bugs.python.org/issue9303#msg288877 (2017-03-03 13:11
Berker Peksag added the comment:
I might miss some other cases, but for example, when you edit a file on GitHub
or when you merge your own PR.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
I believe the 400 status code comes from one of the "raise Reject()" lines in
roundup/github.py. I will try to add some descriptive messages to them to help
debug the issue.
___
PSF Meta Trac
Berker Peksag added the comment:
Here is a patch that tweaks some exception messages and adds logging.error()
calls in GitHubHandler class.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
I converted Brett's payload example to a test case and I couldn't be able to
create a failing test case. Here is a patch with a test.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za
Berker Peksag added the comment:
You can see an example of this in the patch I posted at
http://psf.upfronthosting.co.za/roundup/meta/issue613:
New changeset 9d07aceedabcdc9826489f8b9ba056283bb3 by GitHub (Brett Cannon)
in branch '3.6':
bpo-1: Mention coverage.py in tr
Berker Peksag added the comment:
Here is a patch.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue619>
___diff --git a/roundup/github.py b/roundup/github.py
Berker Peksag added the comment:
Note that there is an open issue for the committer name thing:
http://psf.upfronthosting.co.za/roundup/meta/issue619
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
I think you need to be an administrator on that repo to see the payloads.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
Next time please let me push my own patches. If you have comments please left
them in the issue first. Doing your own thing on my patches without even try to
communicate is a bit rude.
___
PSF Meta Tracker
Berker Peksag added the comment:
I agree with Ned. Thanks, Ezio!
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
https://github.com/python/planet is probably the better place to report 404
errors.
--
nosy: +berker.peksag
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
By the way, I can implement this in
http://psf.upfronthosting.co.za/roundup/meta/issue615
--
nosy: +berker.peksag
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting
Berker Peksag added the comment:
Thanks for the feedback. Here's a patch that updates 'stage' and 'keywords'
fields. This patch updates the detector. I'll upload another one for the
webhook.
I'll commit
Berker Peksag added the comment:
Here's the second patch.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue615>
___diff --git a/roundup/github.py b/roundu
Berker Peksag added the comment:
Thank you for the report, but this is not the correct place to report issues
with third-party Python modules.
The exception message suggests that your Python version is 2.7 and it comes
from PyList_Size():
https://github.com/python/cpython/blob
Berker Peksag added the comment:
So after http://psf.upfronthosting.co.za/roundup/meta/msg3305 and
http://psf.upfronthosting.co.za/roundup/meta/msg3306 I explicitly said "I'll
commit it when I get a code review, thanks!" in my earlier comment, and you
still did the same t
Berker Peksag added the comment:
issue627.diff looks good to me. I'd use assertIsNotNone instead of assertTrue
but that's not a big deal. Thanks!
--
nosy: +berker.peksag
priority: wish -> feature
___
PSF Meta T
Berker Peksag added the comment:
>From
>http://www.roundup-tracker.org/docs/customizing.html#extensions-adding-capabilities-to-your-tracker
All files from this dir are loaded when tracker instance is created, [...]
It's not clear to me when this was added, but it seems like
Berker Peksag added the comment:
Hi John, do you know a workaround to make the random issue extension work again?
--
nosy: +rouilj
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
I agree with Mariatta. We should just look for the PR title. As a fallback, we
can check the body if we can't find an issue number in the title.
--
nosy: +berker.peksag
___
PSF Meta Tracker
Berker Peksag added the comment:
Thank you for your quick response and for your detailed analysis, John.
I will attach a patch to implement your suggestions.
> My thought was that the random function wasn't so random. The new 1.5.1+
> (what will be 1.6) roundup uses more rando
Berker Peksag added the comment:
We may need to set custom rules for caching if we serve bugs.p.o behind Fastly
since data needs to be fresh all the time. Otherwise, we would need to purge
cache everytime we touch an issue.
--
nosy: +berker.peksag
Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 644.
--
nosy: +berker.peksag
status: unread -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
Thank you for taking a look at this again, John. I will incorporate your
suggestions and prepare a patch this weekend.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
I've just committed John's suggested approach in
https://hg.python.org/tracker/python-dev/rev/9e1d65b4927c but it needs to be
deployed by bugs.p.o maintainers. Thank you, again!
> I'll keep poking at it to try to figure out why random se
Berker Peksag added the comment:
Ezio has just deployed 9e1d65b4927c and I've confirmed that it works on
bugs.python.org. Closing as 'resolved'.
Thanks for the report, Cheryl.
--
status: testing -> resolved
__
Berker Peksag added the comment:
This has already been deployed. Closing as 'resolved'.
--
status: chatting -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/round
Berker Peksag added the comment:
> 1. Add a 't' mark to mark our triagers
Ezio's suggestion in msg3197 is much better than mine. I will open a new issue
when I have a patch.
> 2. List only core developers in the 'assigned to' field
It seems too late
Berker Peksag added the comment:
We can use https://github.com/zapier/email-reply-parser to solve this issue.
--
nosy: +ezio.melotti
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundu
New submission from Berker Peksag :
Here's patch that implements Ezio's suggestion in msg3197.
--
files: add_triager_icon.diff
messages: 3461
nosy: berker.peksag, ezio.melotti, r.david.murray
priority: feature
status: unread
title: Add tr
Berker Peksag added the comment:
> Ezio's suggestion in msg3197 is much better than mine. I will open a new
> issue when I have a patch.
I've opened issue654.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/ro
Berker Peksag added the comment:
Thank you again for taking a look at this, John.
I didn't think about using random.Random() to be honest, thank you Nick! Is
there a reason why random.Random() is undocumented in the random module
document
Berker Peksag added the comment:
Ah, I've definitely missed the "You can instantiate your own instances of
Random to get generators that don’t share state." part. Thanks!
___
PSF Meta Tracker
<http://psf.upfronthosting.
Berker Peksag added the comment:
Implemented Nick's suggestion in
https://hg.python.org/tracker/python-dev/rev/ad6158d8414f
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/
Berker Peksag added the comment:
Addressed Ezio's review comments in issue654_v2.diff.
--
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/me
Berker Peksag added the comment:
Ezio gave his LGTM on #python-dev and I just applied in
https://hg.python.org/tracker/python-dev/rev/aac421fdfffb
--
status: chatting -> resolved
___
PSF Meta Tracker
&l
Berker Peksag added the comment:
This is a duplicate of issue491.
--
status: chatting -> resolved
superseder: +Ignore email signatures
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/is
Berker Peksag added the comment:
Reading issue 491 again, I don't think this is exactly a duplicate of that
issue. Reopening.
--
status: resolved -> chatting
superseder: -Ignore email signatures
___
PSF Meta Tracke
Berker Peksag added the comment:
This appears to be working now. I've just set it in my profile:
https://bugs.python.org/user14674
Closing as 'resolved'.
--
nosy: +berker.peksag
status: in-progress -> resolved
__
Berker Peksag added the comment:
> * The server supports only older protocols, but not the current best TLS 1.2.
> Grade capped to C.
There is an open issue for this item: issue 578
I'm not sure whether we should close that as a duplicate of this one.
--
nosy: +be
Berker Peksag added the comment:
Here's patch to fix this issue.
Example output:
--
components: +Tkinter
versions: +Python 2.4
pull_request: https://github.com/python/cpython/pull/341
Old version:
--
components: +Tkinter
versions: +Python 2.4
pull_requests
Berker Peksag added the comment:
Here's a patch to fix this issue.
--
nosy: +berker.peksag, ezio.melotti
status: unread -> chatting
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/me
Berker Peksag added the comment:
Good catch, Nick. Fixed in issue645_v2.diff. Thanks!
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue645>
___diff --git
Berker Peksag added the comment:
Note that the regex code can be probably be simplified, I'm open to
suggestions. I'm not sure whether re.S is still needed.
+pr_number = db.pull_request.get(pr_number, 'number')
Also, I need to be more defensive here and don&
Berker Peksag added the comment:
I tried to copy is_coordinator() first, but request.client.userid gives the ID
of the user who made the request, so it would return invalid results.
Did you get the traceback on production? Is it possible to add a print to see
the userid?
Also, I can be
Berker Peksag added the comment:
I just noticed that I probably need to update the clean_ok_message() function
in pydevutils.py to remove pull_requests.
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
Applied issue654_followup.diff in
https://hg.python.org/tracker/python-dev/rev/9363c06cda40
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundup/meta/issue
Berker Peksag added the comment:
Ezio has just deployed 9363c06cda40 and confirmed that the bug is fixed.
Closing as 'resolved' again.
--
status: in-progress -> resolved
___
PSF Meta Tracker
<http://psf.upfr
Berker Peksag added the comment:
Applied in https://hg.python.org/tracker/python-dev/rev/9c6cedab723d Thanks for
the review, Nick.
--
status: chatting -> resolved
___
PSF Meta Tracker
<http://psf.upfronthosting.co.za/roundu
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
Berker Peksag added the comment:
The recommended way of contributing to Python is now GitHub pull requests and
we no longer maintain our Rietveld instance.
Closing this issue.
--
nosy: +berker.peksag
status: chatting -> resol
1 - 100 of 121 matches
Mail list logo
