[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page

2016-07-13 Thread Anish Shah
Anish Shah added the comment: @berker.peksag Thank you for the review. I will make those changes. > Also, I'm not fan of such a manual work. I would prefer to have a JSON > endpoint > which queries open pull requests on python/cpython and match if > the title of a > pull request contains the

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

2016-07-13 Thread Berker Peksag
New submission from Berker Peksag: Thanks for the patches! :) GitHub already spams every single comment made on a pull request and this will make it worse. I'm -1 on this. It's fine if other core developers want to backup review comments, but it shouldn't be shown on bugs.python.org by

[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page

2016-07-13 Thread R David Murray
R David Murray added the comment: Berker: I presume the point here is that this creates the field, and issue 589 fills it in automatically by having github call roundup when a PR is created. I haven't looked at either patch closely enough to know if I'm right, but that's what I'd expect the

[Tracker-discuss] [issue600] Convert patches to GitHub Pull Request

2016-07-13 Thread Berker Peksag
Berker Peksag added the comment: How do you get the correct author information of the patch? I don't think there is an easy way [1] to extract the author information to use it in the pull requests. [1] You could probably check the GitHub username field of the author but you could have to

[Tracker-discuss] [issue586] Add GitHub Pull Request URL on issue page

2016-07-13 Thread Berker Peksag
Berker Peksag added the comment: Issue 589 is a different feature and it should be discussed there (by the way it would be really nice if you could give more information about the feature and the patch -- I had to read the whole patch to understand what it does). The problem with this

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

2016-07-13 Thread R David Murray
R David Murray added the comment: If github batched the review comments, what we would want (what we've wanted for a long time from reitveld) is a note posted to b.p.o that there *are* review comments. But since github does *not* batch review comments, posting every comment (especially

[Tracker-discuss] [issue590] Show Pull Request status on b.p.o

2016-07-13 Thread Berker Peksag
New submission from Berker Peksag: Do we need a separate issue for this? I think this can be done in issue 586. -- nosy: +berker.peksag ___ PSF Meta Tracker

[Tracker-discuss] [issue592] Show GitHub comments on b.p.o

2016-07-13 Thread R David Murray
R David Murray added the comment: But, really, this level of discussion should take place on the workflow mailing list, not in the context of the patch. ___ PSF Meta Tracker