Re: [tryton-dev] Active Record the next step

2012-04-30 Thread Jean Cavallo
I tried to have a look at everything, though as a tryton newcommer I admit that I could not understand perfectly. Maybe you should upgrade a simple (or dummy) module and make a before-after comparison ? I saw bits of it in a few (mostly) test classes, but it often is renaming _name, removing

Re: [tryton-dev] Active Record the next step

2012-04-30 Thread Cédric Krier
On 30/04/12 11:08 +0200, Jean Cavallo wrote: I tried to have a look at everything, though as a tryton newcommer I admit that I could not understand perfectly. Maybe you should upgrade a simple (or dummy) module and make a before-after comparison ? I saw bits of it in a few (mostly) test

Re: [tryton-dev] Active Record the next step

2012-04-30 Thread Jean Cavallo
Maybe you should upgrade a simple (or dummy) module and make a before-after comparison ? I saw bits of it in a few (mostly) test classes, but it often is renaming _name, removing _description and adding @staticmethod / @classmethod everywhere. There are modules: ir, res and webdav. I

Re: [tryton-dev] Active Record the next step

2012-04-29 Thread Albert Cervera i Areny
A Dimecres, 25 d'abril de 2012 13:46:18, Cédric Krier va escriure: On 25/04/12 11:37 +, cedric.kr...@b2ck.com wrote: Please review this at http://codereview.tryton.org/346003/ This is a first draft for our next step to the Active Record pattern. Let's talk here about the design. Here

Re: [tryton-dev] Active Record the next step

2012-04-29 Thread Cédric Krier
On 29/04/12 19:16 +0200, Albert Cervera i Areny wrote: A Dimecres, 25 d'abril de 2012 13:46:18, Cédric Krier va escriure: On 25/04/12 11:37 +, cedric.kr...@b2ck.com wrote: Please review this at http://codereview.tryton.org/346003/ This is a first draft for our next step to the

Re: [tryton-dev] Active Record the next step

2012-04-29 Thread Albert Cervera i Areny
A Diumenge, 29 d'abril de 2012 20:17:25, Cédric Krier va escriure: Also the fact that some get functions of fields.Function use @classmethod and others use standard functions makes it a bit more complex. Could we standarize and always use the same mechanism? Indeed the simplier is the

Re: [tryton-dev] Active Record the next step

2012-04-29 Thread Cédric Krier
On 29/04/12 20:45 +0200, Albert Cervera i Areny wrote: A Diumenge, 29 d'abril de 2012 20:17:25, Cédric Krier va escriure: Also the fact that some get functions of fields.Function use @classmethod and others use standard functions makes it a bit more complex. Could we standarize and

Re: [tryton-dev] Active Record the next step

2012-04-28 Thread Cédric Krier
On 28/04/12 17:10 +0200, Albert Cervera i Areny wrote: A Dissabte, 28 d'abril de 2012 16:41:35, Cédric Krier va escriure: On 25/04/12 13:46 +0200, Cédric Krier wrote: Really ! Still no comments? Guys, I need to know your thoughts and ideas to improve it before starting patches for

Re: [tryton-dev] Active Record the next step

2012-04-28 Thread Jean Cavallo
Well, the patch is huuuge :) +1, I'm on it but I will need a few days to go through everything. Jean -- tryton-dev@googlegroups.com mailing list