Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

> You've done all the right things. :) Thanks for clarifications and congrats on your newborn! сб, 10 мар. 2018 г. в 7:58, Glyph : > On Mar 9, 2018, at 4:03 AM, Ilya Skriblovsky > wrote: > > > Just wanted to make sure, did I all what I should do for putting this > ticket into review: https://tw

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

On 10 March 2018 at 04:57, Glyph wrote: > On Mar 9, 2018, at 4:03 AM, Ilya Skriblovsky > wrote: > > > Just wanted to make sure, did I all what I should do for putting this ticket > into review: https://twistedmatrix.com/trac/ticket/9374 ? > Should I just wait for maintainers to review it? > > > Y

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

On Mar 9, 2018, at 4:03 AM, Ilya Skriblovsky wrote: > > Just wanted to make sure, did I all what I should do for putting this ticket > into review: https://twistedmatrix.com/trac/ticket/9374 > ? > Should I just wait for maintainers to review it? You

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

Just wanted to make sure, did I all what I should do for putting this ticket into review: https://twistedmatrix.com/trac/ticket/9374 ? Should I just wait for maintainers to review it? Thanks вт, 30 янв. 2018 г. в 6:28, Glyph : > > > On Jan 29, 2018, at 12:27 PM, Ilya Skriblovsky > wrote: > > Ne

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

> On Jan 29, 2018, at 12:27 PM, Ilya Skriblovsky > wrote: > > Never mind, I realized I didn't some steps 10+ from The Manual > http://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch > > Will fix that >

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

Never mind, I realized I didn't some steps 10+ from The Manual http://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch Will fix that пн, 29 янв. 2018 г., 16:52 Ilya Skriblovsky : > So, no action is required from me right now? > Sorry, that's a first time I'm trying to contribute to

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

So, no action is required from me right now? Sorry, that's a first time I'm trying to contribute to Twisted itself :) вс, 28 янв. 2018 г. в 9:37, Glyph : > > > On Jan 27, 2018, at 12:33 PM, Ilya Skriblovsky > wrote: > > I've created the pull request with breaking cycles in connectionLost, > plea

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

> On Jan 27, 2018, at 12:33 PM, Ilya Skriblovsky > wrote: > > I've created the pull request with breaking cycles in connectionLost, please > consider: https://github.com/twisted/twisted/pull/955 > > > This change seems to fit well to the reasoni

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

I've created the pull request with breaking cycles in connectionLost, please consider: https://github.com/twisted/twisted/pull/955 This change seems to fit well to the reasoning of Compatibility Exception process. Should I create new thread in the mailing list with "INCOMPATIBLE CHANGE" in a subje

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

On Jan 20, 2018, at 9:32 AM, Ilya Skriblovsky wrote: > > Yes, doing it only for TLSMemoryBIOProtocol fails test too :( > > SSL-related seem to be touching both ends of this reference cycle after > connectionLost: > > 1. twisted/test/test_sslverify.py:2102 > self.assertEqual(sProto.wrappedProto

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

Yes, doing it only for TLSMemoryBIOProtocol fails test too :( SSL-related seem to be touching both ends of this reference cycle after connectionLost: 1. twisted/test/test_sslverify.py:2102 self.assertEqual(sProto.wrappedProtocol.data, b'') This one touches `wrappedProtocol` 2. twisted/test/proto

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

> On Jan 19, 2018, at 11:52 AM, Ilya Skriblovsky > wrote: > > > Protocols and transports have a fairly defined lifecycle, and as L. Daniel > > Burr already pointed out, it would probably be appropriate to explicitly > > break these reference cycles in connectionLost. > > Explicitly breaking

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

> Protocols and transports have a fairly defined lifecycle, and as L. Daniel Burr already pointed out, it would probably be appropriate to explicitly break these reference cycles in connectionLost. Explicitly breaking cycle in ProtocolWrapper.connectionLost by any of: • self.wrappedProtocol = None

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

> On Jan 17, 2018, at 1:09 PM, Ilya Skriblovsky > wrote: > > Hello, > > I have the Twisted app that serves tons of short-lived TLS connections using > TLSMemoryBIOFactory. I usually set loosened garbage collector thresholds in > production environment for the sake of performance. But I've n

Re: [Twisted-Python] Circular references in TLSMemoryBIOProtocol

Hi Ilya, On January 17, 2018 at 3:09:52 PM, Ilya Skriblovsky (ilyaskriblov...@gmail.com) wrote: [Trimmed for context] So using weakrefs makes all protocol instances and instances of TLSMemoryBIOProtocol to be deleted right after a connection is closed. Less circular-dependent objects → less G

[Twisted-Python] Circular references in TLSMemoryBIOProtocol

Hello, I have the Twisted app that serves tons of short-lived TLS connections using TLSMemoryBIOFactory. I usually set loosened garbage collector thresholds in production environment for the sake of performance. But I've noticed that this app's RAM usage quickly grows up to unreasonable values. Di