Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-06-06 Thread Glyph
> On Jun 5, 2016, at 8:15 AM, Craig Rodrigues wrote: > > At Pycon, Glyph and cyli managed to review and merge a number of my patches. I would like to point out that at the sprints, I was nearly continuously engaged in conversation, so I should be able to review many

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-06-05 Thread Craig Rodrigues
On Fri, May 27, 2016 at 5:13 AM, Itamar Turner-Trauring wrote: On 05/27/2016 04:19 AM, Craig Rodrigues wrote: > > I think they're fine to accept insofar as: > > 1. There is strong ongoing momentum for the port now, so these changes > makes porting module-by-module easier

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-06-04 Thread Wolfgang Rohdewald
Am Samstag, 4. Juni 2016, 04:41:37 schrieb Craig Rodrigues: > On Fri, May 27, 2016 at 6:14 AM, Wolfgang Rohdewald < > wolfgang@rohdewald.de> wrote: > > > Am Freitag, 27. Mai 2016, 08:13:10 schrieb Itamar Turner-Trauring: > > > > This would have been helpful when I tried to port PB to python3.

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-05-27 Thread Adi Roiban
On 27 May 2016 at 13:13, Itamar Turner-Trauring wrote: > >> [snip] I think they're fine to accept insofar as: > > 1. There is strong ongoing momentum for the port now, so these changes > makes porting module-by-module easier and won't just bitrot. > How do you define a

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-05-27 Thread Wolfgang Rohdewald
Am Freitag, 27. Mai 2016, 08:13:10 schrieb Itamar Turner-Trauring: > On 05/27/2016 04:19 AM, Craig Rodrigues wrote: > > However, Adi has mentioned that in this document: > > http://twistedmatrix.com/trac/wiki/Plan/Python3, > > the strategy of submitting incremental Python3 fixes is not mentioned.

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-05-27 Thread Itamar Turner-Trauring
On 05/27/2016 04:19 AM, Craig Rodrigues wrote: However, Adi has mentioned that in this document: http://twistedmatrix.com/trac/wiki/Plan/Python3, the strategy of submitting incremental Python3 fixes is not mentioned. Before doing any further reviews, Adi would like clarification that these

[Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-05-27 Thread Craig Rodrigues
Hi, I have submitted some Python 3 patches for Twisted. 1. PATCHES REVIEWED AND COMMITTED TO TRUNK = Use new syntax for catching exceptions https://twistedmatrix.com/trac/ticket/8344 Use new syntax for raising exceptions