Re: [Twisted-Python] Required tests for a PR to be merged

2017-10-02 Thread Jean-Paul Calderone
On Mon, Oct 2, 2017 at 7:35 AM, Adi Roiban wrote: > On 2 October 2017 at 12:24, Jean-Paul Calderone > wrote: > > On Mon, Oct 2, 2017 at 7:20 AM, Adi Roiban wrote: > > [snip] > > >> Am I doing something wrong? > >> Is there a simple way? > >> Am I the only one who thinks this is not productive?

Re: [Twisted-Python] Required tests for a PR to be merged

2017-10-02 Thread Adi Roiban
On 2 October 2017 at 14:41, Tristan Seligmann wrote: > On Mon, 2 Oct 2017 at 13:36 Adi Roiban wrote: >> >> Will it trigger the Buidlbot stable builders? >> >> From what I can see in the code, it only creates the branch. > > > I believe buildbot will trigger a build on the branch being pushed, no

Re: [Twisted-Python] Required tests for a PR to be merged

2017-10-02 Thread Tristan Seligmann
On Mon, 2 Oct 2017 at 13:36 Adi Roiban wrote: > Will it trigger the Buidlbot stable builders? > > From what I can see in the code, it only creates the branch. > I believe buildbot will trigger a build on the branch being pushed, no need for a separate PR. Then, because GitHub commit statuses are

Re: [Twisted-Python] Required tests for a PR to be merged

2017-10-02 Thread Adi Roiban
On 2 October 2017 at 12:24, Jean-Paul Calderone wrote: > On Mon, Oct 2, 2017 at 7:20 AM, Adi Roiban wrote: [snip] >> Am I doing something wrong? >> Is there a simple way? >> Am I the only one who thinks this is not productive? > > > Use admin/pr_as_branch Will it trigger the Buidlbot stable bu

Re: [Twisted-Python] Required tests for a PR to be merged

2017-10-02 Thread Jean-Paul Calderone
On Mon, Oct 2, 2017 at 7:20 AM, Adi Roiban wrote: > Hi, > > 1. Are Travis OSX builds functional yet? Can we switch to Travis for > OSX builder? > > Over https://www.traviscistatus.com/ I see no backlog for macOS. > > No backlog right now but what about most of the rest of the time? Monday at 7AM

[Twisted-Python] Required tests for a PR to be merged

2017-10-02 Thread Adi Roiban
Hi, 1. Are Travis OSX builds functional yet? Can we switch to Travis for OSX builder? Over https://www.traviscistatus.com/ I see no backlog for macOS. 2. Right now, when we receive a PR from a non-team member, I think that the only way to trigger the required tests is to create a n