Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-28 Thread Richard van der Hoff
On 28/02/2021 07:38, Craig Rodrigues wrote: Thomas Grainger and Adi Roiban have worked together to bump up the minimum Python version to 3.5.3 for this release ( https://github.com/twisted/twisted/pull/1524 ), and are not approving the PR that I have submitted in PR 1525.  Even though you

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-27 Thread Craig Rodrigues
On Thu, Feb 25, 2021 at 7:03 PM Craig Rodrigues wrote: > > > On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff > wrote: > >> As it happens, it also fails (for an import of typing.Deque) on Python >> 3.5.3, as used by Debian oldstable. >> >> Craig, what is your intention here? I think it's ok

[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-27 Thread Craig Rodrigues
On Monday, February 15, 2021, Kyle Altendorf wrote: > > > I went ahead and set pip_pre=true in pytest-twisted's tox.ini to try it > out and got warnings/errors with PyPy 3.7 about use of t.i.d.returnValue > claiming it should only be used in @inlineCallbacks decorated functions > even though the

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-25 Thread Craig Rodrigues
On Mon, Feb 22, 2021 at 5:30 AM Richard van der Hoff wrote: > As it happens, it also fails (for an import of typing.Deque) on Python > 3.5.3, as used by Debian oldstable. > > Craig, what is your intention here? I think it's ok to drop support for > these ancient versions of Python 3.5, but

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-22 Thread Richard van der Hoff
On 21/02/2021 01:36, Craig Rodrigues wrote: Awww, this is unfortunate. It looks like our CI on GitHub Actions is testing *Python 3.5.10*. Over the past year, we have added a lot of type annotations to the codebase, and it has been a struggle to still keep things working with Python 3.5, but

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-20 Thread Richard van der Hoff
On 21/02/2021 00:31, Richard van der Hoff wrote: On 15/02/2021 02:53, Craig Rodrigues wrote: It's time for another Twisted release! There are two major announcements for this release: - *Python 2.7 support has been dropped*.  Twisted 21.2.0 supports Python 3.5 and higher only - *This will

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-20 Thread Richard van der Hoff
On 15/02/2021 02:53, Craig Rodrigues wrote: It's time for another Twisted release! There are two major announcements for this release: - *Python 2.7 support has been dropped*.  Twisted 21.2.0 supports Python 3.5 and higher only - *This will be the last Twisted release to support Python 3.5*.

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-15 Thread Glyph
Thank you Craig for getting this out! On Valentines day, no less :-) ❤️. Very excited that the release train is back on the tracks!  It's been a very rough year. Thank you to everyone who contributed to the 225 tickets that have been closed during this release, and thanks also to everyone

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-15 Thread Craig Rodrigues
On Monday, February 15, 2021, Kyle Altendorf wrote: > > NonLocalExitTests > test_returnValueNonLocalDeferred ... [FAIL] > test_returnValueNonLocalWarning ... [FAIL] > > Ticketed as https://twistedmatrix.com/trac/ticket/10093. > > > > Thanks for the testing, detailed analysis, and ticket. If you

Re: [Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-15 Thread Kyle Altendorf
On 2021-02-14 21:53, Craig Rodrigues wrote: > Please test it, and let me know how your applications fare, good or bad! Hi Craig, Thanks for all the work to get us into the next Twisted release. All, I went ahead and set pip_pre=true in pytest-twisted's tox.ini to try it out and got

[Twisted-Python] Twisted 21.2.0rc1 Release Candidate Announcement

2021-02-14 Thread Craig Rodrigues
It's time for another Twisted release! There are two major announcements for this release: - *Python 2.7 support has been dropped*. Twisted 21.2.0 supports Python 3.5 and higher only - *This will be the last Twisted release to support Python 3.5*. Twisted 21.2.0rc1 brings the following: -