Re: [Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls

2019-05-27 Thread Thomas Westfeld
: [Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls I filed https://twistedmatrix.com/trac/ticket/9643 and submitted a PR: https://github.com/twisted/twisted/pull/1146 ---Tom On Thu, May 23, 2019, at 11:50 PM, Glyph wrote: > I definitely agree with this! > > -g > > > On

Re: [Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls

2019-05-26 Thread Tom Most
I filed https://twistedmatrix.com/trac/ticket/9643 and submitted a PR: https://github.com/twisted/twisted/pull/1146 ---Tom On Thu, May 23, 2019, at 11:50 PM, Glyph wrote: > I definitely agree with this! > > -g > > > On May 23, 2019, at 9:08 PM, Tom Most wrote: > > > > This looks like a strai

Re: [Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls

2019-05-23 Thread Glyph
I definitely agree with this! -g > On May 23, 2019, at 9:08 PM, Tom Most wrote: > > This looks like a straightforward bug to me. I don't see any reason we can't > change the implementation to either raise TypeError immediately or accept a > string, since any code that passes a string doesn't

Re: [Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls

2019-05-23 Thread Tom Most
This looks like a straightforward bug to me. I don't see any reason we can't change the implementation to either raise TypeError immediately or accept a string, since any code that passes a string doesn't work right now. Would you file a bug at https://twistedmatrix.com/trac/newticket? ---Tom

[Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls

2019-05-20 Thread Thomas Westfeld
Dear all, I just migrated some quite basic twisted code from Python 2.7 to Python 3. Everything worked quite nicely, the main issue was the correct handling of strings vs. bytes. There was a mean error I made when using the Twisted Agent http client: I specified the method as a Unicode string,