[Txaws-dev] [Merge] lp:~therve/txaws/old-signature into lp:txaws

2010-05-14 Thread Thomas Herve
Thomas Herve has proposed merging lp:~therve/txaws/old-signature into lp:txaws. Requested reviews: txAWS Developers (txaws-dev) Related bugs: #580544 Support SignatureVersion 1 https://bugs.launchpad.net/bugs/580544 -- https://code.launchpad.net/~therve/txaws/old-signature/+merge/25335

[Txaws-dev] [Merge] lp:~therve/txaws/post-support into lp:txaws

2010-10-25 Thread Thomas Herve
Thomas Herve has proposed merging lp:~therve/txaws/post-support into lp:txaws. Requested reviews: txAWS Developers (txaws-dev) Related bugs: #666487 ec2 client doesn't really support POST https://bugs.launchpad.net/bugs/666487 -- https://code.launchpad.net/~therve/txaws/post-su

[Txaws-dev] [Merge] lp:~therve/txaws/import-keypair into lp:txaws

2011-03-19 Thread Thomas Herve
Thomas Herve has proposed merging lp:~therve/txaws/import-keypair into lp:txaws. Requested reviews: txAWS Developers (txaws-dev) Related bugs: Bug #738131 in txAWS: "Add support for ImportKeyPair" https://bugs.launchpad.net/txaws/+bug/738131 For more details,

[Txaws-dev] [Merge] lp:~therve/txaws/safe-unicode-errors into lp:txaws

2011-11-10 Thread Thomas Herve
Thomas Herve has proposed merging lp:~therve/txaws/safe-unicode-errors into lp:txaws. Requested reviews: txAWS Developers (txaws-dev) Related bugs: Bug #888445 in txAWS: "txAWS fails to handle exceptions with unicode data" https://bugs.launchpad.net/txaws/+bug/888445 For more de

[Txaws-dev] [Merge] lp:~therve/txaws/ssl-verify into lp:txaws

2011-11-29 Thread Thomas Herve
Thomas Herve has proposed merging lp:~therve/txaws/ssl-verify into lp:txaws. Requested reviews: txAWS Developers (txaws-dev) Related bugs: Bug #781949 in txAWS: "Must check certificates for validity" https://bugs.launchpad.net/txaws/+bug/781949 For more details,

[Txaws-dev] [Merge] lp:~therve/txaws/ec2-unicode into lp:txaws

2012-01-24 Thread Thomas Herve
Thomas Herve has proposed merging lp:~therve/txaws/ec2-unicode into lp:txaws. Requested reviews: txAWS Technical List (txaws-tech) Related bugs: Bug #920915 in txAWS: "Support unicode parameters to the EC2 client" https://bugs.launchpad.net/txaws/+bug/920915 For more details,

Re: [Txaws-dev] [Merge] lp:~radix/txaws/parameter-enrichment into lp:txaws

2012-04-26 Thread Thomas Herve
Review: Approve [1] In _secret_convert_old_schema, you should pass item.name as name parameter to List, to keep compatibility. [2] You also need to forward the optional parameter. [3] Still in the sample, it seems you should forward the default value, and use [] otherwise as default. [4] In _

Re: [Txaws-dev] [Merge] lp:~radix/txaws/parameter-enrichment into lp:txaws

2012-04-26 Thread Thomas Herve
Review: Needs Fixing -- https://code.launchpad.net/~radix/txaws/parameter-enrichment/+merge/103592 Your team txAWS Technical List is requested to review the proposed merge of lp:~radix/txaws/parameter-enrichment into lp:txaws. ___ Mailing list: https

Re: [Txaws-dev] [Merge] lp:~radix/txaws/parameter-enrichment into lp:txaws

2012-04-26 Thread Thomas Herve
Review: Approve [6] +_result.update(self._convert_nest_to_flat(v, _result=_result, + _prefix=path)) You can remove the update call, or remove passing the result value, but I don't think you need to do both. Looks good to m