Review: Approve
[1] In _secret_convert_old_schema, you should pass item.name as name parameter
to List, to keep compatibility.
[2] You also need to forward the optional parameter.
[3] Still in the sample, it seems you should forward the default value, and use
[] otherwise as default.
[4] In _convert_nest_to_flat, you return as soon as you get a dict: if you have
more params, they get ignore. You should probably call _result.update instead.
[5]
+ {'foo.1.bar': 'value',
+ 'foo.2.baz': 'value'}
+
+ to::
+
+ {'foo': {'1': {'bar': 'value'},
+ '2': {'baz': 'value'}}}
I think we talked about that, but what's the reason we don't convert this to:
{'foo': [{'bar': 'value'}, {'baz': 'value'}]} ?
FWIW, I discovered most of this running Landscape/Clouddeck. We can deal with
some small incompatibilities, but it'd be nice to narrow them down. Thanks!
--
https://code.launchpad.net/~radix/txaws/parameter-enrichment/+merge/103592
Your team txAWS Technical List is requested to review the proposed merge of
lp:~radix/txaws/parameter-enrichment into lp:txaws.
_______________________________________________
Mailing list: https://launchpad.net/~txaws-dev
Post to : txaws-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~txaws-dev
More help : https://help.launchpad.net/ListHelp
