Re: [U-Boot] [PATCH v2 17/28] x86: acpi: Use u32 in table write routines

2016-05-07 Thread Bin Meng
Hi Simon, On Sun, May 8, 2016 at 2:46 AM, Simon Glass wrote: > On 7 May 2016 at 08:46, Bin Meng wrote: >> Use u32 instead of unsigned long in the table write routines, as >> other routines do. >> >> Signed-off-by: Bin Meng >> >> --- >>

Re: [U-Boot] [PATCH v2 00/28] x86: Initial ACPI support for Intel BayTrail

2016-05-07 Thread Bin Meng
Hi Simon, On Sun, May 8, 2016 at 2:45 AM, Simon Glass wrote: > Hi Bin, > > On 7 May 2016 at 08:46, Bin Meng wrote: >> This series introduces initial ACPI support for Intel BayTrail. >> >> Advanced Configuration and Power Interface (ACPI) aims to establish

Re: [U-Boot] [PATCH 1/6] arm/arm64: Move barrier instructions into separate header

2016-05-07 Thread André Przywara
Hi Tom, On 04/05/16 22:15, Andre Przywara wrote: > Commit bfb33f0bc45b ("sunxi: mctl_mem_matches: Add missing memory > barrier") broke compilation for the Pine64, as dram_helper.c now > includes , which does not compile on arm64. I just realized that the 2016.05 release is due anytime now. Can

Re: [U-Boot] [PATCH v2 1/2] serial: Introduce linflex uart support

2016-05-07 Thread Eddy Petrișor
Pe 7 mai 2016 5:56 p.m., "Bin Meng" a scris: > > +Simon > > Hi Eddy, > > On Thu, Apr 28, 2016 at 6:07 AM, Eddy Petrișor wrote: > > From: Stoica Cosmin-Stefan > > > > The Linflex module is integrated on some NXP

Re: [U-Boot] [PATCH v2 2/2] armv8: s32v234: Introduce basic support for s32v234evb

2016-05-07 Thread Eddy Petrișor
Pe 7 mai 2016 7:22 p.m., "Alexander Graf" a scris: > > > On Apr 28, 2016, at 12:07 AM, Eddy Petrișor wrote: > > > From: Eddy Petrișor > > […] > > > +#define CONFIG_CMD_ENV > > +#define CONFIG_EXTRA_ENV_SETTINGS \ > > +

Re: [U-Boot] [PATCH 59/60] ARM: tegra: unify+move tegra.h to mach-tegra/

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Most of arch/arm/include/asm/arch-tegra*/tegra.h is only used by code in > arch/arm/mach-tegra, so move the header files there to avoid polluting the > global include path.

Re: [U-Boot] [PATCH 60/60] ARM: tegra: move clock headers

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > These are the last files in arch/arm/include/asm/arch-tegra*. Move them > into arch/arm/mach-tegra. The Tegra clock API currently exposes a lot of > internal implementation

Re: [U-Boot] [PATCH 58/60] ARM: tegra: clean up board include statements

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Tegra board files currently include many headers they don't need. Remove > the unused include statements. > > Signed-off-by: Stephen Warren > --- >

Re: [U-Boot] [PATCH 00/60] ARM: tegra: cleanup part 1

2016-05-07 Thread Simon Glass
Hi Stephen, On 19 April 2016 at 14:58, Stephen Warren wrote: > From: Stephen Warren > > This series cleans up Tegra code: > - Removes unused definitions. > - Unifies duplicate definitions and code. > - Moves Tegra headers from arch/arm/include to

Re: [U-Boot] [PATCH 57/60] ARM: tegra: don't access Boot Info Table from board code

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > The only use of the BIT was to print a message indicating whether the > system booted via cold boot or USB ReCovery Mode (RCM). If that is worth > doing for some boards, it's

Re: [U-Boot] [PATCH 54/60] video: tegra: move pinmux setup to board files

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Remove funcmux calls from the Tegra20 video driver. Knowledge of pinmux > setup must come from either board files or DT; it should not be embedded > into board-agnostic driver

Re: [U-Boot] [PATCH 56/60] ARM: tegra: remove funcmux API

2016-05-07 Thread Simon Glass
Hi Stephen, On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Replace all usage of funcmux APIs with the pinmux functions previously > added to replace then. Delete the funcmux implementation since it's no > longer used. This

Re: [U-Boot] [PATCH 53/60] tegra: keyboard: move pinmux setup to board files

2016-05-07 Thread Simon Glass
Hi Stephen. On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Remove funcmux calls from the Tegra keyboard driver. Knowledge of pinmux > setup must come from either board files or DT; it should not be embedded > into

Re: [U-Boot] [PATCH 49/60] ARM: tegra: convert boards to new hooks

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Implementations of the following functions are converted to use the new > standardized hooks: gpio_early_init, gpio_early_init_uart, pinmux_init, > board_init_uart_f. This

Re: [U-Boot] [PATCH 52/60] ARM: tegra: convert pin_mux_*() to new hooks

2016-05-07 Thread Simon Glass
Hi Stephen, On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Implementations of the following functions are converted to use the new > standardized hooks: pin_mux_usb, pin_mux_spi, pin_mux_nand, pin_mux_mmc, >

Re: [U-Boot] [PATCH 50/60] ARM: tegra: remove unused includes

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Signed-off-by: Stephen Warren > --- > arch/arm/mach-tegra/board2.c | 8 > 1 file changed, 8 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 51/60] ARM: tegra: move SPL-specific GPIO device to spl.c

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > SPL-specific code generally belongs in an SPL-specific file. This allows > an ifdef to be removed too:-) > > Signed-off-by: Stephen Warren > --- >

Re: [U-Boot] [PATCH 46/60] ARM: tegra: add pinmux APIs to replace funcmux

2016-05-07 Thread Simon Glass
Hi Stephen. On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > The existing funcmux APIs have the disadvantage that clients call a single > monolithic/IOCTL-style function which performs different operations based > on its

Re: [U-Boot] [PATCH 45/60] ARM: tegra: move custom pinmux.h to

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Machine-specific headers should be in this location. Eventually, we'll > move all headers from arch/arm/include to arch/arm/mach-tegra/include, > or find a way to delete them. >

Re: [U-Boot] [PATCH 47/60] ARM: tegra: provide API for SPL code to init UART

2016-05-07 Thread Simon Glass
Hi Stephen, On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Currently, SPL console initialization on Tegra suffers from two problems: > > 1) It's a monolithic function that knows about all possibilities using > tables and

Re: [U-Boot] [PATCH 43/60] ARM: tegra: move PLLX configuration into SoC directories

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > Rather than building a large table of all possible PLLX configurations > into U-Boot and having it select the right one at run-time, push the > configuration into SoC-specific

Re: [U-Boot] [PATCH 44/60] ARM: tegra: remove tegra_get_chip_sku()

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > This is now only used by some Tegra20-specific code, and only to select > between T20/T25 code paths. Introduce a simpler function for that case, > and isolate it to the

Re: [U-Boot] [PATCH 42/60] ARM: tegra: move EMC code to tegra20/ directory

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > EMC scaling is specific to Tegra20. Move the code into tegra20/ to isolate > it. If it becomes more generic in the future, it should likely be moved > somewhere in drivers/, but

Re: [U-Boot] [PATCH 41/60] ARM: tegra: remove tegra_get_sku_info()

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > This is part of the internal implementation of tegra_get_chip_sku(). > > Signed-off-by: Stephen Warren > --- > arch/arm/mach-tegra/ap.c | 14

Re: [U-Boot] [PATCH 40/60] ARM: tegra: remove gp_padctrl.h

2016-05-07 Thread Simon Glass
On 19 April 2016 at 14:59, Stephen Warren wrote: > From: Stephen Warren > > The only place this is still used is Tegra20's warmboot.c. Keep the T20 > copy around for that use, but remove the other unused duplicates. > > Signed-off-by: Stephen Warren

Re: [U-Boot] [PATCH v2 00/24] dm: mmc: Add driver-model block-device support to MMC

2016-05-07 Thread Simon Glass
Hi, On 1 May 2016 at 13:52, Simon Glass wrote: > This series adds support for using CONFIG_BLK with MMC, such that it uses > the block interface correctly. The old interface in part.c is removed. > > With driver model, when CONFIG_BLK is enabled, MMC devices must have a child

Re: [U-Boot] [PATCH v2 00/44] dm: blk: Add more driver-model support for block devices

2016-05-07 Thread Simon Glass
Hi, On 1 May 2016 at 11:35, Simon Glass wrote: > This series adjusts the block device code to support conversion to driver > model. Specifically > > - A new 'legacy' block interface is created, allowing block devices to be > defined by a linker list and accessed through

Re: [U-Boot] [PATCH v2 00/25] exynos: video: Convert exynos LCD driver to use driver model

2016-05-07 Thread Simon Glass
Hi, On 1 March 2016 at 18:51, Minkyu Kang wrote: > Hi, > > On 29/02/16 16:18, Jaehoon Chung wrote: >> Hi, >> >> On 02/29/2016 01:23 PM, Simon Glass wrote: >>> Hi, >>> >>> On 23 February 2016 at 05:04, Minkyu Kang wrote: Dear Simon Glass,

Re: [U-Boot] [RESEND PATCH V2 6/6] gpio: exynos(s5p): remove gpio_xlate routine

2016-05-07 Thread Simon Glass
On 20 April 2016 at 09:37, Eric Nelson wrote: > With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, > the Exynos/S5P gpio driver doesn't need a custom xlate routine. > > Signed-off-by: Eric Nelson > Acked-by: Simon Glass > Acked-by:

Re: [U-Boot] [RESEND PATCH V2 5/6] gpio: rk: remove gpio_xlate routine

2016-05-07 Thread Simon Glass
On 20 April 2016 at 09:37, Eric Nelson wrote: > With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, > the Rockchip gpio driver doesn't need a custom xlate routine. > > Signed-off-by: Eric Nelson > Acked-by: Simon Glass > --- > V2

Re: [U-Boot] [RESEND PATCH V2 3/6] gpio: omap: remove gpio_xlate routine

2016-05-07 Thread Simon Glass
On 20 April 2016 at 09:37, Eric Nelson wrote: > With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, > the omap gpio driver doesn't need a custom xlate routine. > > Signed-off-by: Eric Nelson > Acked-by: Simon Glass > --- > V2

Re: [U-Boot] [RESEND PATCH V2 4/6] gpio: pic32: remove gpio_xlate routine

2016-05-07 Thread Simon Glass
On 20 April 2016 at 09:37, Eric Nelson wrote: > With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, > the pic32 gpio driver doesn't need a custom xlate routine. > > Signed-off-by: Eric Nelson > Acked-by: Simon Glass > Reviewed-by:

Re: [U-Boot] [RESEND PATCH V2 2/6] gpio: intel_broadwell: remove gpio_xlate routine

2016-05-07 Thread Simon Glass
On 20 April 2016 at 09:37, Eric Nelson wrote: > With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass, > the intel_broadwell driver doesn't need a custom xlate routine. > > Signed-off-by: Eric Nelson > Acked-by: Simon Glass > --- >

Re: [U-Boot] [PATCH V4, 1/6] dm: gpio: add a default gpio xlate routine

2016-05-07 Thread Simon Glass
On 27 April 2016 at 09:12, Simon Glass wrote: > On 24 April 2016 at 17:32, Eric Nelson wrote: >> Many drivers use a common form of offset + flags for device >> tree nodes. e.g.: >> < 2 GPIO_ACTIVE_LOW> >> >> This patch adds a common implementation of

Re: [U-Boot] [PATCH V4 4/4] dm: gpio: introduce 74x164 driver

2016-05-07 Thread Simon Glass
On 2 May 2016 at 20:02, Peng Fan wrote: > Introduce driver to support "fairchild,74hc595" devices. > 1. Take linux drivers/drivers/gpio/gpio-74x164.c as reference. > 2. Following the naming used in Linux driver with gen_7x164 as the prefix. > 3. Enable CONFIG_DM_74X164 to

Re: [U-Boot] [PATCH V4 2/4] dm: spi: soft_spi: switch to use linux compatible string

2016-05-07 Thread Simon Glass
On 2 May 2016 at 20:02, Peng Fan wrote: > 1. Support compatible string "spi-gpio" which is used by Linux >Linux use different bindings, so use UBOOT_COMPAT and >LINUX_COMPAT to differentiate them. > 2. Introduce SPI_MASTER_NO_RX and SPI_MASTER_NO_TX to handle >

Re: [U-Boot] [PATCH 1/1] drivers: usb: common: add common code for usb drivers to use

2016-05-07 Thread Simon Glass
On 13 April 2016 at 05:47, Marek Vasut wrote: > On 04/13/2016 01:19 PM, Simon Glass wrote: >> On 12 April 2016 at 04:31, Mugunthan V N wrote: >>> Add common usb code which usb drivers makes use of it. >>> >>> Signed-off-by: Mugunthan V N

Re: [U-Boot] [PATCH V4 3/4] dm: spi: introduce dm api

2016-05-07 Thread Simon Glass
Applied to u-boot-dm, thanks! On 7 May 2016 at 09:11, Simon Glass wrote: > On 2 May 2016 at 20:02, Peng Fan wrote: >> Introduce dm_spi_claim_bus, dm_spi_release_bus and dm_spi_xfer >> Convert spi_claim_bus, spi_release_bus and spi_xfer to use >> the new

Re: [U-Boot] [PATCH 1/2] dm: core: allow drivers to refuse to bind

2016-05-07 Thread Simon Glass
On 4 May 2016 at 14:09, Simon Glass wrote: > Hi Stephen, > > On 4 May 2016 at 14:02, Stephen Warren wrote: >> On 05/04/2016 01:48 PM, Simon Glass wrote: >>> >>> +Tom Rini >>> >>> Hi Stephen, >>> >>> On 4 May 2016 at 13:46, Stephen Warren

Re: [U-Boot] [PATCH V4 1/4] dm: spi: soft_spi bug fix

2016-05-07 Thread Simon Glass
On 2 May 2016 at 19:59, Peng Fan wrote: > When doing xfer, should use device->parent, but not device > When doing bit xfer, should use "!!(tmpdout & 0x80)", but not > "(tmpdout & 0x80)" > > Signed-off-by: Peng Fan > Cc: Simon Glass

Re: [U-Boot] [PATCH V2] buildman: allow more incremental building

2016-05-07 Thread Simon Glass
On 4 May 2016 at 14:30, Simon Glass wrote: > On 4 May 2016 at 14:27, Tom Rini wrote: >> On Wed, May 04, 2016 at 01:30:47PM -0600, Simon Glass wrote: >>> Hi Tom, >>> >>> On 4 May 2016 at 13:09, Stephen Warren wrote: >>> > On

Re: [U-Boot] [PATCH 2/2] video: tegra: refuse to bind to disabled dcs

2016-05-07 Thread Simon Glass
On 20 April 2016 at 07:16, Simon Glass wrote: > On 19 April 2016 at 16:19, Stephen Warren wrote: >> From: Stephen Warren >> >> This prevents the following boot-time message on any board where only the >> first DC is in use, yet the

Re: [U-Boot] [PATCH] fdt: fix dev_get_addr_name node offset

2016-05-07 Thread Simon Glass
On 29 April 2016 at 08:02, Simon Glass wrote: > On 28 April 2016 at 16:04, Stephen Warren wrote: >> From: Stephen Warren >> >> Use the device's own DT offset, not the device's parent's. >> >> Fixes: 43c4d44e3330 ("fdt: implement

Re: [U-Boot] [PATCH v2 28/28] x86: doc: Document ACPI support

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Remove ACPI from the TODO list and add a new section to document > current ACPI support in U-Boot. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Update ACPI support status in more details: what's

Re: [U-Boot] [PATCH v2 27/28] x86: doc: Minor update for accuracy

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > This updates the doc for the following places: > - Mention CRB for Bayley Bay > - Mention Congatec QEVAL 2.0 & conga-QA3/E3845 > - Limit part of the QEMU paragraphs to 80 cols > - Correct some typos (drive, it's, Ubuntu) > - Add

Re: [U-Boot] [PATCH v2 22/28] x86: baytrail: Add platform ASL files

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > This adds basic BayTrail platform ASL files. They are intended to be > included in dsdt.asl of any board that is based on this platform. > > Note: ACPI mode support for GPIO/LPSS/SCC/LPE are not supported for > now. They will be added

Re: [U-Boot] [PATCH v2 25/28] x86: baytrail: Add .gitignore for ACPI enabled boards

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Let git ignore dsdt.aml, dsdt.asl.tmp and dsdt.c files. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese > --- > > Changes in v2: None > >

Re: [U-Boot] [PATCH v2 24/28] x86: baytrail: Enable ACPI table generation for all boards

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Enable ACPI table generation by creating a DSDT table for all baytrail > boards: conga-qeval20-qa3-e3845, bayleybay and minnowmax. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by:

Re: [U-Boot] [PATCH v2 26/28] x86: Remove acpi=off boot parameter when ACPI is on

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Remove the kernel boot parameter acpi=off so that kernel can turn on > ACPI support. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese > --- > > Changes

Re: [U-Boot] [PATCH v2 23/28] x86: baytrail: Generate ACPI FADT/MADT tables

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > FADT/MADT tables are platform specific. Generate them for BayTrail. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Use existing macros in FADT whenever possible > - Rename acpi_madt_irq_overrides() to

Re: [U-Boot] [PATCH v2 17/28] x86: acpi: Use u32 in table write routines

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Use u32 instead of unsigned long in the table write routines, as > other routines do. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Update several more places to use u32 in acpi_table.c > >

Re: [U-Boot] [PATCH v2 18/28] x86: acpi: Align FACS table to a 64 byte boundary

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Per ACPI spec, the FACS table address must be aligned to a 64 byte > boundary (Windows checks this, but Linux does not). > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan

Re: [U-Boot] [PATCH v2 21/28] x86: acpi: Return table length in acpi_create_madt_lapics()

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Like other MADT table write routines, make acpi_create_madt_lapics() > return how many bytes it has written instead of the table end addr. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - New patch to

Re: [U-Boot] [PATCH v2 19/28] x86: acpi: Clean up table header revisions

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > The comment of initializing table header revision says: > > /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */ > > which might mislead it may increase per ACPI spec revision. > However this is not the case. It's actually a fixed

Re: [U-Boot] [PATCH v2 20/28] x86: acpi: Add some generic ASL libraries

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > This adds several generic ASL libraries that can be included by > other ASL files, which are: > > - debug.asl: for debug output using POST I/O port and legacy serial port > - globutil.asl: for string compare routines > - statdef.asl:

Re: [U-Boot] [PATCH v2 11/28] x86: acpi: Remove unused codes

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > - Remove #include <> header files. > - Remove APM_CNT register defines, which should not be here as > they are SMI related. > - Remove MP_IRQ_ defines as they are duplicates of the same ones > in asm/mpspec.h. > - Remove ACTL

Re: [U-Boot] [PATCH v2 16/28] x86: acpi: Adjust order in acpi_table.c

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Rearrange the routine order a little bit, to follow the order > in which ACPI table is defined in acpi_table.h. > > Signed-off-by: Bin Meng > > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese

Re: [U-Boot] [PATCH v2 12/28] x86: acpi: Various changes to acpi_table.h

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > - Use "U-BOOT" and "U-BOOTBL" for the OEM ID and OEM table ID. > - Do not typedef acpi_header_t, instead use struct acpi_table_hader. > - Use a shorter name aslc_id and aslc-revision. > - Change MCFG base address to use 32-bit value

Re: [U-Boot] [PATCH v2 14/28] x86: acpi: Remove acpi_create_ssdt_generator()

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > This acpi_create_ssdt_generator() currently does nothing. > Remove this for now. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese > --- > > Changes in

Re: [U-Boot] [PATCH v2 15/28] x86: acpi: Change fill_header()

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Rename fill_header() to acpi_fill_header() for consistency. > Change its signature to remove the 'length' parameter and > make it a public API. > > Also remove the unnecessary include files, and improve the > AmlCode[] comment a little

Re: [U-Boot] [PATCH v2 13/28] x86: acpi: Reorder code in acpi_table.h

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Reorder the ACPI tables appearance by following the order: > RSDP, RSDT, XSDT, FADT, FACS, MADT, MCFG. And adjust the > table flag defines accordingly. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese

Re: [U-Boot] [PATCH v2 10/28] acpi: Output all errors/warnings/remarks when compiling ASL

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Remove -va option when invoking IASL compiler so that we can see > errors/warnings/remarks in the build log. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese

Re: [U-Boot] [PATCH v2 08/28] acpi: Explicitly spell out dsdt.c in the make rule

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Currently the make rule for dsdt.c uses a wildcard, as below: > > $(obj)/%.c:$(src)/%.asl > > To avoid any side effect, explicitly mention dsdt.c as this is > the file we intend to use for ACPI DSDT AML generation. > >

Re: [U-Boot] [PATCH 05/26] x86: irq: Enable SCI on IRQ9

2016-05-07 Thread Simon Glass
On 2 May 2016 at 01:33, Bin Meng wrote: > By default SCI is disabled after power on. ACTL is the register to > enable SCI and route it to PIC/APIC. To support both ACPI in PIC > mode and APIC mode, configure SCI to use IRQ9. > > Signed-off-by: Bin Meng >

Re: [U-Boot] [PATCH v2 09/28] acpi: Specify U-Boot include path for ASL files

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > It will be much easier if we split the whole dsdt.asl file into > multiple smaller ASL parts and have access to U-Boot include files. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese >

Re: [U-Boot] [PATCH v2 07/28] acpi: Change build log for ASL files

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Currently when compiling U-Boot with ASL file, the build log says: > > ASL board/intel/bayleybay/dsdt.c > > This looks odd as ASL compiler's input is ASL file, not C file. > Change the make rule to use >lt; instead. > >

Re: [U-Boot] [PATCH v2 04/28] x86: irq: Reserve IRQ9 for ACPI in PIC mode

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Reserve IRQ9 which is to be used as SCI interrupt number > for ACPI in PIC mode. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese > > --- > > Changes

Re: [U-Boot] [PATCH v2 06/28] x86: dts: Update to include ACTL register details

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > This updates all x86 boards that currently have IRQ router in the > dts files to include ACTL register details. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese

Re: [U-Boot] [PATCH v2 01/28] x86: Drop asm/acpi.h

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Remove asm/acpi.h which is never used. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese > Tested-by: Stefan Roese > --- > > Changes in v2: None > > arch/x86/cpu/ivybridge/lpc.c

Re: [U-Boot] [PATCH v2 02/28] x86: Fix build warning in tables.c when CONFIG_SEABIOS

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > The following build warning is seen in tables.c: > > warning: implicit declaration of function 'memalign' > > Add the missing header file to fix it. > > Signed-off-by: Bin Meng > Reviewed-by: Stefan Roese

Re: [U-Boot] [PATCH v2 03/28] x86: acpi: Fix compiler warnings in write_acpi_tables()

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Fix the following two build warnings in function 'write_acpi_tables': > > warning: format '%lx' expects argument of type 'long unsigned int', > but argument 2 has type 'u32' [-Wformat=] > > Signed-off-by: Bin Meng

Re: [U-Boot] [PATCH v2 00/28] x86: Initial ACPI support for Intel BayTrail

2016-05-07 Thread Simon Glass
Hi Bin, On 7 May 2016 at 08:46, Bin Meng wrote: > This series introduces initial ACPI support for Intel BayTrail. > > Advanced Configuration and Power Interface (ACPI) aims to establish > industry-standard interfaces enabling OS-directed configuration, power > management, and

Re: [U-Boot] Partition UUIDs in U-Boot and Linux (blkid vs 'part list')

2016-05-07 Thread Tom Rini
On Sat, May 07, 2016 at 11:51:12AM -0600, Simon Glass wrote: > Hi, > > I find that blkid provides different output from 'part list' and I'm > not sure why: > > => part list scsi 0 > > Partition Map for SCSI device 0 -- Partition Type: EFI > > Part Start LBA End LBA Name > Attributes > Type

[U-Boot] Partition UUIDs in U-Boot and Linux (blkid vs 'part list')

2016-05-07 Thread Simon Glass
Hi, I find that blkid provides different output from 'part list' and I'm not sure why: => part list scsi 0 Partition Map for SCSI device 0 -- Partition Type: EFI Part Start LBA End LBA Name Attributes Type GUID Partition GUID 1 0x0800 0x001007ff "" attrs: 0x type:

Re: [U-Boot] [PATCH v2 2/2] armv8: s32v234: Introduce basic support for s32v234evb

2016-05-07 Thread Alexander Graf
On Apr 28, 2016, at 12:07 AM, Eddy Petrișor wrote: > From: Eddy Petrișor > > Add initial support for NXP's S32V234 SoC and S32V234EVB board. > > The S32V230 family is designed to support computation-intensive applications > for image

Re: [U-Boot] [PATCH 05/26] x86: irq: Enable SCI on IRQ9

2016-05-07 Thread Stefan Roese
Hi Bin, On 07.05.2016 17:46, Bin Meng wrote: On Sat, May 7, 2016 at 11:42 PM, Stefan Roese wrote: Hi Bin, On 07.05.2016 16:06, Bin Meng wrote: On Tue, May 3, 2016 at 8:31 PM, Stefan Roese wrote: Hi Bin, On 02.05.2016 09:33, Bin Meng wrote: By default

Re: [U-Boot] [PATCH 05/26] x86: irq: Enable SCI on IRQ9

2016-05-07 Thread Bin Meng
Hi Stefan, On Sat, May 7, 2016 at 11:42 PM, Stefan Roese wrote: > Hi Bin, > > > On 07.05.2016 16:06, Bin Meng wrote: >> >> On Tue, May 3, 2016 at 8:31 PM, Stefan Roese wrote: >>> >>> Hi Bin, >>> >>> >>> On 02.05.2016 09:33, Bin Meng wrote: By default

Re: [U-Boot] [PATCH 05/26] x86: irq: Enable SCI on IRQ9

2016-05-07 Thread Stefan Roese
Hi Bin, On 07.05.2016 16:06, Bin Meng wrote: On Tue, May 3, 2016 at 8:31 PM, Stefan Roese wrote: Hi Bin, On 02.05.2016 09:33, Bin Meng wrote: By default SCI is disabled after power on. ACTL is the register to enable SCI and route it to PIC/APIC. To support both ACPI in PIC

Re: [U-Boot] [PATCH] dm: core: Add dev_get_addr_ptr() to return a pointer to the reg address

2016-05-07 Thread Stefan Roese
Hi Simon, On 07.05.2016 17:33, Simon Glass wrote: Hi Bin, On 7 May 2016 at 09:31, Bin Meng wrote: Hi Simon, On Sat, May 7, 2016 at 11:19 PM, Simon Glass wrote: Hi Stefan, On 20 April 2016 at 10:10, Simon Glass wrote: Hi Stefan,

Re: [U-Boot] [PATCH] dm: core: Add dev_get_addr_ptr() to return a pointer to the reg address

2016-05-07 Thread Simon Glass
Hi Bin, On 7 May 2016 at 09:31, Bin Meng wrote: > Hi Simon, > > On Sat, May 7, 2016 at 11:19 PM, Simon Glass wrote: >> Hi Stefan, >> >> On 20 April 2016 at 10:10, Simon Glass wrote: >>> Hi Stefan, >>> >>> On 20 April 2016 at 10:08,

Re: [U-Boot] [PATCH] dm: core: Add dev_get_addr_ptr() to return a pointer to the reg address

2016-05-07 Thread Bin Meng
Hi Simon, On Sat, May 7, 2016 at 11:19 PM, Simon Glass wrote: > Hi Stefan, > > On 20 April 2016 at 10:10, Simon Glass wrote: >> Hi Stefan, >> >> On 20 April 2016 at 10:08, Stefan Roese wrote: >>> On some platforms (e.g. x86), the return value

Re: [U-Boot] [PATCH] dm: core: Add dev_get_addr_ptr() to return a pointer to the reg address

2016-05-07 Thread Simon Glass
Hi Stefan, On 20 April 2016 at 10:10, Simon Glass wrote: > Hi Stefan, > > On 20 April 2016 at 10:08, Stefan Roese wrote: >> On some platforms (e.g. x86), the return value of dev_get_addr() can't >> be assigned to a pointer type variable directly. As there might

Re: [U-Boot] [PATCH V4 3/4] dm: spi: introduce dm api

2016-05-07 Thread Simon Glass
On 2 May 2016 at 20:02, Peng Fan wrote: > Introduce dm_spi_claim_bus, dm_spi_release_bus and dm_spi_xfer > Convert spi_claim_bus, spi_release_bus and spi_xfer to use > the new API. > > Signed-off-by: Peng Fan > Cc: Simon Glass >

Re: [U-Boot] [PATCH v2 1/2] serial: Introduce linflex uart support

2016-05-07 Thread Bin Meng
+Simon Hi Eddy, On Thu, Apr 28, 2016 at 6:07 AM, Eddy Petrișor wrote: > From: Stoica Cosmin-Stefan > > The Linflex module is integrated on some NXP automotive SoCs part of the > former > Freescale portfolio, like S32V234, an SoC for

[U-Boot] [PATCH v2 28/28] x86: doc: Document ACPI support

2016-05-07 Thread Bin Meng
Remove ACPI from the TODO list and add a new section to document current ACPI support in U-Boot. Signed-off-by: Bin Meng --- Changes in v2: - Update ACPI support status in more details: what's supported, what's not supported, what's optional. doc/README.x86 | 44

[U-Boot] [PATCH v2 27/28] x86: doc: Minor update for accuracy

2016-05-07 Thread Bin Meng
This updates the doc for the following places: - Mention CRB for Bayley Bay - Mention Congatec QEVAL 2.0 & conga-QA3/E3845 - Limit part of the QEMU paragraphs to 80 cols - Correct some typos (drive, it's, Ubuntu) - Add description for "console=ttyS0,115200" - Remove CONFIG_BOOTDELAY description

[U-Boot] [PATCH v2 26/28] x86: Remove acpi=off boot parameter when ACPI is on

2016-05-07 Thread Bin Meng
Remove the kernel boot parameter acpi=off so that kernel can turn on ACPI support. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None include/configs/x86-common.h | 9 +++-- 1 file changed, 7

[U-Boot] [PATCH v2 23/28] x86: baytrail: Generate ACPI FADT/MADT tables

2016-05-07 Thread Bin Meng
FADT/MADT tables are platform specific. Generate them for BayTrail. Signed-off-by: Bin Meng --- Changes in v2: - Use existing macros in FADT whenever possible - Rename acpi_madt_irq_overrides() to acpi_create_madt_irq_overrides() for consistency, and make it static -

[U-Boot] [PATCH v2 25/28] x86: baytrail: Add .gitignore for ACPI enabled boards

2016-05-07 Thread Bin Meng
Let git ignore dsdt.aml, dsdt.asl.tmp and dsdt.c files. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None board/congatec/conga-qeval20-qa3-e3845/.gitignore | 3 +++

[U-Boot] [PATCH v2 18/28] x86: acpi: Align FACS table to a 64 byte boundary

2016-05-07 Thread Bin Meng
Per ACPI spec, the FACS table address must be aligned to a 64 byte boundary (Windows checks this, but Linux does not). Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: - Add comments before the 64

[U-Boot] [PATCH v2 22/28] x86: baytrail: Add platform ASL files

2016-05-07 Thread Bin Meng
This adds basic BayTrail platform ASL files. They are intended to be included in dsdt.asl of any board that is based on this platform. Note: ACPI mode support for GPIO/LPSS/SCC/LPE are not supported for now. They will be added in the future. Signed-off-by: Bin Meng ---

[U-Boot] [PATCH v2 24/28] x86: baytrail: Enable ACPI table generation for all boards

2016-05-07 Thread Bin Meng
Enable ACPI table generation by creating a DSDT table for all baytrail boards: conga-qeval20-qa3-e3845, bayleybay and minnowmax. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None

[U-Boot] [PATCH v2 17/28] x86: acpi: Use u32 in table write routines

2016-05-07 Thread Bin Meng
Use u32 instead of unsigned long in the table write routines, as other routines do. Signed-off-by: Bin Meng --- Changes in v2: - Update several more places to use u32 in acpi_table.c arch/x86/include/asm/acpi_table.h | 4 ++-- arch/x86/lib/acpi_table.c | 14

[U-Boot] [PATCH v2 20/28] x86: acpi: Add some generic ASL libraries

2016-05-07 Thread Bin Meng
This adds several generic ASL libraries that can be included by other ASL files, which are: - debug.asl: for debug output using POST I/O port and legacy serial port - globutil.asl: for string compare routines - statdef.asl: for _STA status values Signed-off-by: Bin Meng

[U-Boot] [PATCH v2 14/28] x86: acpi: Remove acpi_create_ssdt_generator()

2016-05-07 Thread Bin Meng
This acpi_create_ssdt_generator() currently does nothing. Remove this for now. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None arch/x86/include/asm/acpi_table.h | 3 ---

[U-Boot] [PATCH v2 19/28] x86: acpi: Clean up table header revisions

2016-05-07 Thread Bin Meng
The comment of initializing table header revision says: /* ACPI 1.0/2.0: 1, ACPI 3.0: 2, ACPI 4.0: 3 */ which might mislead it may increase per ACPI spec revision. However this is not the case. It's actually a fixed number as defined in ACPI spec, and in the laest ACPI spec 6.1, some table

[U-Boot] [PATCH v2 16/28] x86: acpi: Adjust order in acpi_table.c

2016-05-07 Thread Bin Meng
Rearrange the routine order a little bit, to follow the order in which ACPI table is defined in acpi_table.h. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: - Change 'orders' to 'order' in the

[U-Boot] [PATCH v2 12/28] x86: acpi: Various changes to acpi_table.h

2016-05-07 Thread Bin Meng
- Use "U-BOOT" and "U-BOOTBL" for the OEM ID and OEM table ID. - Do not typedef acpi_header_t, instead use struct acpi_table_hader. - Use a shorter name aslc_id and aslc-revision. - Change MCFG base address to use 32-bit value pairs (_l and _h). - Apply ACPI_APIC_ prefix to MADT APIC type macros

[U-Boot] [PATCH v2 21/28] x86: acpi: Return table length in acpi_create_madt_lapics()

2016-05-07 Thread Bin Meng
Like other MADT table write routines, make acpi_create_madt_lapics() return how many bytes it has written instead of the table end addr. Signed-off-by: Bin Meng --- Changes in v2: - New patch to return table length in acpi_create_madt_lapics()

[U-Boot] [PATCH v2 13/28] x86: acpi: Reorder code in acpi_table.h

2016-05-07 Thread Bin Meng
Reorder the ACPI tables appearance by following the order: RSDP, RSDT, XSDT, FADT, FACS, MADT, MCFG. And adjust the table flag defines accordingly. Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: -

  1   2   >