Re: [U-Boot] [PATCH] x86: mmc: Fix mapping of BAR memory

2018-03-18 Thread Bin Meng
On Thu, Feb 15, 2018 at 4:09 PM, Bernhard Messerklinger wrote: > Use dm_pci_map_bar function for BAR mapping. This has the advantage > of clearing BAR flags and and only accepting mapped memory. > > Signed-off-by: Bernhard Messerklinger >

Re: [U-Boot] [PATCH v3] x86: zImage: pass device tree setup data to the kernel

2018-03-18 Thread Bin Meng
Hi Ivan, On Sat, Mar 17, 2018 at 8:32 AM, Ivan Gorinov wrote: > On x86 platforms, U-Boot does not provide Device Tree data to the kernel. > This prevents the kernel from using the same hardware description. > > Make a copy of DTB data with setup_data header and insert new

[U-Boot] Please pull u-boot-usb/topic-xhci

2018-03-18 Thread Bin Meng
Hi Marek, The following changes since commit 958ad42b77be9d9a69f059066622ef0c15c603ee: usb: dwc2: Replace printf, pr_err by dev_info, dev_err (2018-03-19 11:03:46 +0800) are available in the git repository at: git://git.denx.de/u-boot-usb.git topic-xhci for you to fetch changes up to

Re: [U-Boot] [PATCH 1/1] usb: xhci-exynos5: correct error checking

2018-03-18 Thread Bin Meng
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote: > On Sun, Mar 18, 2018 at 8:51 PM, Heinrich Schuchardt > wrote: >> If fdtdec_next_compatible_subnode() fails it returns a negative value. >> The check (node <= 0) cannot identify this if node is unsigned.

Re: [U-Boot] [PATCH 1/1] usb: xhci-ring: remove superfluous assignment

2018-03-18 Thread Bin Meng
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote: > On Sun, Mar 18, 2018 at 9:01 PM, Heinrich Schuchardt > wrote: >> No need to set a variable to NULL if the next use is an assignment. >> Do not define variables in the middle of nowhere. >> >>

Re: [U-Boot] [PATCH 1/1] usb: xhci-keystone: remove superfluous assignment

2018-03-18 Thread Bin Meng
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote: > On Sun, Mar 18, 2018 at 8:55 PM, Heinrich Schuchardt > wrote: >> There is no need to set variables to NULL if they are not used before >> the next assignment. >> >> Signed-off-by: Heinrich Schuchardt

Re: [U-Boot] [PATCH 1/1] usb: xhci: remove superfluous assignment

2018-03-18 Thread Bin Meng
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote: > On Sun, Mar 18, 2018 at 9:04 PM, Heinrich Schuchardt > wrote: >> There is not need to set variables to NULL before an assignment. >> >> Signed-off-by: Heinrich Schuchardt >> --- >>

Re: [U-Boot] [PATCH 1/1] usb: xhci-exynos5: correct error checking

2018-03-18 Thread Bin Meng
On Sun, Mar 18, 2018 at 8:51 PM, Heinrich Schuchardt wrote: > If fdtdec_next_compatible_subnode() fails it returns a negative value. > The check (node <= 0) cannot identify this if node is unsigned. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [U-Boot] [PATCH 1/1] usb: xhci-keystone: remove superfluous assignment

2018-03-18 Thread Bin Meng
On Sun, Mar 18, 2018 at 8:55 PM, Heinrich Schuchardt wrote: > There is no need to set variables to NULL if they are not used before > the next assignment. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/usb/host/xhci-keystone.c | 4 ++-- > 1 file

Re: [U-Boot] [PATCH 1/1] usb: xhci-ring: remove superfluous assignment

2018-03-18 Thread Bin Meng
On Sun, Mar 18, 2018 at 9:01 PM, Heinrich Schuchardt wrote: > No need to set a variable to NULL if the next use is an assignment. > Do not define variables in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [U-Boot] [PATCH 1/1] usb: xhci: remove superfluous assignment

2018-03-18 Thread Bin Meng
On Sun, Mar 18, 2018 at 9:04 PM, Heinrich Schuchardt wrote: > There is not need to set variables to NULL before an assignment. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/usb/host/xhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [U-Boot] [PATCH v2 0/3] bmips: add support for bcm6318 usbh phy

2018-03-18 Thread Daniel Schwierzeck
On 04.02.2018 21:11, Álvaro Fernández Rojas wrote: > Add support for BCM6318 usbh phy. > > v2: use correct phy driver > > Álvaro Fernández Rojas (3): > phy: add support for bcm6318 usbh phy > mips: bmips: add support for bcm6318 usb > mips: bmips: add ar-5315 usb support > >

Re: [U-Boot] [PATCH v2 0/9] bmips: add support for bcm6368 usbh phy

2018-03-18 Thread Daniel Schwierzeck
On 04.02.2018 21:10, Álvaro Fernández Rojas wrote: > Add support for BCM 6328/6362/6368/63268 usbh phy. > > v2: use correct phy driver and simplify code. > > Álvaro Fernández Rojas (9): > phy: add support for bcm6368 usbh phy > mips: bmips: add support for bcm6368 usb > mips: bmips: add

Re: [U-Boot] [PATCH v2 1/1] lib/slre: remove superfluous assignment

2018-03-18 Thread Tom Rini
On Sun, Mar 18, 2018 at 11:28:20PM +0100, Heinrich Schuchardt wrote: > It makes no sense to assign a value to 'res' if the next use of the > variable is an assignment. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc

Re: [U-Boot] [PATCH 0/4] bmips: add support for bcm6358 usbh phy

2018-03-18 Thread Daniel Schwierzeck
On 04.02.2018 11:19, Álvaro Fernández Rojas wrote: > Add support for BCM6358 usbh phy. > > Álvaro Fernández Rojas (4): > phy: add support for bcm6358 usbh phy > mips: bmips: add support for bcm6358 usb > mips: bmips: add hg556a usb support > mips: bmips: add nb4-ser usb support > >

Re: [U-Boot] [PATCH 0/3] bmips: add support for bcm6348 usbh phy

2018-03-18 Thread Daniel Schwierzeck
On 04.02.2018 11:18, Álvaro Fernández Rojas wrote: > Add support for BCM6348 usbh phy. > > Álvaro Fernández Rojas (3): > phy: add support for bcm6348 usbh phy > mips: bmips: add support for bcm6348 usb > mips: bmips: add ct-5361 usb support > > arch/mips/dts/brcm,bcm6348.dtsi | 20

Re: [U-Boot] [PATCH 1/1] mips: micronas/vct: check array bounds before access

2018-03-18 Thread Daniel Schwierzeck
On 18.03.2018 23:43, Heinrich Schuchardt wrote: > If we check an index against array bounds, we should do so before > accessing the array and not afterwards. > > Signed-off-by: Heinrich Schuchardt > --- > board/micronas/vct/scc.c | 4 +++- > 1 file changed, 3

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

2018-03-18 Thread Marek Vasut
On 03/19/2018 12:48 AM, Philipp Tomsich wrote: >> Assigning f_rkusb->reboot_flag twice doesn't make sense. >> >> Signed-off-by: Heinrich Schuchardt >> Acked-by: Philipp Tomsich >> Reviewed-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, 1/1] video: rk3399_mipi: correct error checking

2018-03-18 Thread Philipp Tomsich
> Pointers are never negative. Use macro IS_ERR() for checking. > cf. rk3288_mipi.c > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- >

Re: [U-Boot] rockchip: clk: rk3188: update dpll settings to make EMAC work

2018-03-18 Thread Philipp Tomsich
> The patch set dpll settings for 300MHz to values used by binary > blob[1]. With new values dpll still generate 300MHz clock, but > EMAC work. Probably with new values dpll generate more stable clock. > > dpll on rk3188 provide clocks to DDR and EMAC. With current > dpll settings EMAC doesn't

Re: [U-Boot] [U-Boot, RFC, 1/1] driver: ram: rockchip: rk3399: missing counter increment

2018-03-18 Thread Philipp Tomsich
> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > I do not have the

Re: [U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

2018-03-18 Thread Philipp Tomsich
> The error checking should also catch the case that no range has beeen > defined. > syscon_get_first_range() returns NULL if no range is defined. > cf. rk3399_mipi.c > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich >

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

2018-03-18 Thread Philipp Tomsich
> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich > --- > drivers/usb/gadget/f_rockusb.c

Re: [U-Boot] [U-Boot, 2/2] rockchip: pinctrl: rk3188: Move the iomux definitions into pinctrl-driver

2018-03-18 Thread Philipp Tomsich
> Clean the iomux definitions at grf_rk3188.h, and move them into > pinctrl-driver for resolving the compiling error of redefinition. > > Signed-off-by: Alexander Kochetkov > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, 1/2] rockchip: pinctrl: rk3036: Move the iomux definitions into pinctrl-driver

2018-03-18 Thread Philipp Tomsich
> Clean the iomux definitions at grf_rk3036.h, and move them into > pinctrl-driver for resolving the compiling error of redefinition. > > Signed-off-by: Alexander Kochetkov > Acked-by: Philipp Tomsich > Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

2018-03-18 Thread Duncan Hare
On Sat, 17 Mar 2018 16:36:14 + Calvin Johnson wrote: > It would be good to have this cosmetic change into a separate patch. Ok. But at this stage I'm at the "Forgive me Lord for I know not what I do" > IMO, better place for this definition and associated

[U-Boot] [PATCH 1/1] mips: micronas/vct: check array bounds before access

2018-03-18 Thread Heinrich Schuchardt
If we check an index against array bounds, we should do so before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- board/micronas/vct/scc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/board/micronas/vct/scc.c

[U-Boot] [PATCH v2 1/1] lib/slre: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
It makes no sense to assign a value to 'res' if the next use of the variable is an assignment. Signed-off-by: Heinrich Schuchardt --- v2 correct commit message --- lib/slre.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/slre.c b/lib/slre.c index

Re: [U-Boot] [PATCH 1/1] lib/slre: remove superfluous assignment

2018-03-18 Thread Tom Rini
On Sun, Mar 18, 2018 at 11:12:10PM +0100, Heinrich Schuchardt wrote: > It makes to assign a value to 'res' if the next use of the variable is an > assignment. I think you meant "It makes no sense to " ... Thanks (and for all of the other load of fixes you've been posting)! -- Tom

[U-Boot] [PATCH 1/1] lib/slre: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
It makes to assign a value to 'res' if the next use of the variable is an assignment. Signed-off-by: Heinrich Schuchardt --- lib/slre.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/slre.c b/lib/slre.c index e26d344865..969c46a859 100644 --- a/lib/slre.c +++

Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI

2018-03-18 Thread Heinrich Schuchardt
On 03/18/2018 10:21 PM, Maxime Ripard wrote: > Hi, > > On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: >> doc/driver-model/MIGRATION.txt requires to move block drivers to the >> the driver model by v2018.05 >> >> So make the switch for the SUNXI block drivers. >> >> Select

Re: [U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI

2018-03-18 Thread Maxime Ripard
Hi, On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote: > doc/driver-model/MIGRATION.txt requires to move block drivers to the > the driver model by v2018.05 > > So make the switch for the SUNXI block drivers. > > Select BLK, DM_MMC, and DM_SCSI. > > DM_USB dpends on USB but

[U-Boot] dhcp command not populating dnsip environment variable

2018-03-18 Thread Duncan Hare
Cause: u-boot/Kconfig DISTRO_DEFAULTS missing variables in Kconfig files u-boot/ config DISTRO_DEFAULTS contains these directives: select HUSH_PARSER select BOOTP_BOOTPATH if NET && CMD_NET select BOOTP_DNS if NET && CMD_NET select BOOTP_GATEWAY if NET && CMD_NET

Re: [U-Boot] [ANN] U-Boot v2018.03 released

2018-03-18 Thread Wolfgang Denk
Dear Tom, In message <20180313121344.gk1...@bill-the-cat.ec.rr.com> you wrote: > > We're a day off schedule, but I wanted to see a final comment on one > last bug fix. So, now, I've released v2018.03 and it's live on git and > FTP and ACD (along with the PGP sig file). Sorry for the long delay

Re: [U-Boot] iminfo and zImages

2018-03-18 Thread Wolfgang Denk
Dear Andy, In message you wrote: > > Is it just not possible for the zImages in RAM to be decoded as per the > uImages ? You can decode only the information that is in there. uImage adds an extra 64 byte header

Re: [U-Boot] [U-Boot, 1/3] ubifs: Reintroduce using CONFIG_UBIFS_SILENCE_MSG

2018-03-18 Thread Petr Vorel
Hi, > Use of CONFIG_UBIFS_SILENCE_MSG was added in > 147162dac6 ("ubi: ubifs: Turn off verbose prints") > > Then it was removed in > ff94bc40af ("mtd, ubi, ubifs: resync with Linux-3.14") > > Cc: Joe Hershberger > Cc: Heiko Schocher > Signed-off-by: Petr

Re: [U-Boot] [PATCH v1] rtc: rewrite isl1208 to support DM

2018-03-18 Thread Dr. Philipp Tomsich
> On 18 Mar 2018, at 18:35, Klaus Goger > wrote: > > Adds devicemodel support to the ISL1208 driver. > This patch drops the non-dm API as no board was using it anyway. > Also add it to Kconfig. > > Signed-off-by: Klaus Goger

Re: [U-Boot] [PATCH] davinci: omapl138_lcdk: fix PLL0 frequency

2018-03-18 Thread Mike Looijmans
On 16-03-18 16:56, David Lechner wrote: On 03/16/2018 01:26 AM, Mike Looijmans wrote: On 15-03-18 02:36, David Lechner wrote: commit 1601dd97edc6 ("davinci: omapl138_lcdk: increase PLL0 frequency") changed the PLL0 frequency to 456MHz, which is needed for the LCDC IP block. However, in doing

[U-Boot] [PATCH v3] tools/mxsimage: Support building with LibreSSL

2018-03-18 Thread Hauke Mehrtens
The mxsimage utility fails to compile against LibreSSL version < 2.7.0 because LibreSSL says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 interface. LibreSSL defines OPENSSL_VERSION_NUMBER with 0x2000L and therefor claims to have an API compatible with OpenSSL 2.0, but

[U-Boot] [PATCH v1] rtc: rewrite isl1208 to support DM

2018-03-18 Thread Klaus Goger
Adds devicemodel support to the ISL1208 driver. This patch drops the non-dm API as no board was using it anyway. Also add it to Kconfig. Signed-off-by: Klaus Goger --- drivers/rtc/Kconfig | 7 +++ drivers/rtc/isl1208.c | 141

Re: [U-Boot] [U-Boot, 1/1] video: rk3399_mipi: correct error checking

2018-03-18 Thread Philipp Tomsich
> Pointers are never negative. Use macro IS_ERR() for checking. > cf. rk3288_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > drivers/video/rockchip/rk3399_mipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

2018-03-18 Thread Philipp Tomsich
> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Philipp Tomsich > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Philipp

Re: [U-Boot] [U-Boot, RFC, 1/1] driver: ram: rockchip: rk3399: missing counter increment

2018-03-18 Thread Philipp Tomsich
> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1

Re: [U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

2018-03-18 Thread Philipp Tomsich
> The error checking should also catch the case that no range has beeen > defined. > syscon_get_first_range() returns NULL if no range is defined. > cf. rk3399_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > I do not possess the hardware for testing. But the coding is

Re: [U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

2018-03-18 Thread Philipp Tomsich
> The error checking should also catch the case that no range has beeen > defined. > syscon_get_first_range() returns NULL if no range is defined. > cf. rk3399_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > I do not possess the hardware for testing. But the coding is

Re: [U-Boot] [U-Boot, 1/1] video: rk3399_mipi: correct error checking

2018-03-18 Thread Philipp Tomsich
> Pointers are never negative. Use macro IS_ERR() for checking. > cf. rk3288_mipi.c > > Signed-off-by: Heinrich Schuchardt > --- > drivers/video/rockchip/rk3399_mipi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v2] rockchip: i2c: enable new I2C controller for rk3066 and rk3188

2018-03-18 Thread Philipp Tomsich
> rk3066 and rk3188 has two I2C controller implementations. > Current I2C driver wan't work with legacy implementation. > Switching between controllers is performed using a bit inside > GFR_SOC_CON1 register. The bit setting is performed by pinctrl > driver. The patch ask pinctrl to do settings. >

Re: [U-Boot] [U-Boot, RFC, 1/1] driver: ram: rockchip: rk3399: missing counter increment

2018-03-18 Thread Philipp Tomsich
> If we want to check the duration we need to increment the counter. > > Signed-off-by: Heinrich Schuchardt > --- > I do not have the hardware for testing. But the current coding is > obviously flawed. > --- > drivers/ram/rockchip/sdram_rk3399.c | 1 + > 1 file changed, 1

Re: [U-Boot] [U-Boot, 1/1] usb: rockchip: remove duplicate assignement.

2018-03-18 Thread Philipp Tomsich
> Assigning f_rkusb->reboot_flag twice doesn't make sense. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/usb/gadget/f_rockusb.c | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Philipp Tomsich

Re: [U-Boot] rockchip: rk3399: set fdtfile

2018-03-18 Thread Philipp Tomsich
> Signed-off-by: Mark Kettenis > --- > include/configs/rk3399_common.h | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Philipp Tomsich ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [U-Boot, v1, 2/2] rockchip: pinctrl: rk3399: add support for I2C[123467]

2018-03-18 Thread Philipp Tomsich
> From: Philipp Tomsich > > This adds support for the (to date unsupported) I2C controllers 1~4 > and 6~7 (i.e. now all controllers except I2C5, which is not accessible > on the RK3399-Q7, are supported by pinctrl). > > Signed-off-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, v1, 1/2] rockchip: pinctrl: rk3399: fix GPIO2B1 and GPIO2B2 shift value

2018-03-18 Thread Philipp Tomsich
> From: Philipp Tomsich > > The shift values for GPIO2B1 and GPIO2B2 had in fact referred to > GPIO2B0 and GPIO2B1, respectively. This substitutes the correct > values. > > Signed-off-by: Philipp Tomsich >

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Heinrich Schuchardt
On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Marek Vasut
On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt

[U-Boot] [PATCH 1/1] configs: sunxi: enable BLK, DM_MMC, DM_SCSI

2018-03-18 Thread Heinrich Schuchardt
doc/driver-model/MIGRATION.txt requires to move block drivers to the the driver model by v2018.05 So make the switch for the SUNXI block drivers. Select BLK, DM_MMC, and DM_SCSI. DM_USB dpends on USB but there is no necessity to make it depend on DISTRO_DEFAULTS. Signed-off-by: Heinrich

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: TI SYSTEM SECURITY: remove invalid file

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 11:58:33PM +0100, Heinrich Schuchardt wrote: > Remove a link to a non-existent file. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Andrew F. Davis Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM TI: remove invalid paths

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 11:40:29PM +0100, Heinrich Schuchardt wrote: > Remove non-existing paths. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM HISILICON: correct maintained path

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 11:02:17PM +0100, Heinrich Schuchardt wrote: > Fix an incorrect path. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot

Re: [U-Boot] [U-Boot, v2, 5/5] common: move init_helpers.h prototypes in init.h

2018-03-18 Thread Tom Rini
On Tue, Mar 13, 2018 at 01:57:04PM +0100, Patrick Delaunay wrote: > Merge init_helpers.h in the new file init.h > with only prototypes for init_cache_f_r > used in common/board_f.c > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom

Re: [U-Boot] [U-Boot, v2, 1/5] common: move board_f.c prototypes in init.h

2018-03-18 Thread Tom Rini
On Tue, Mar 13, 2018 at 01:57:00PM +0100, Patrick Delaunay wrote: > Move prototypes for function used in common/board_f.c > from common.h to init.h > Remove weak for arch_reserve_stacks in prototype > (checkpatch issue) > > Signed-off-by: Patrick Delaunay Applied to

Re: [U-Boot] [U-Boot, v2, 4/5] common: move board_info.c prototypes in init.h

2018-03-18 Thread Tom Rini
On Tue, Mar 13, 2018 at 01:57:03PM +0100, Patrick Delaunay wrote: > Move function prototype for common/init/board_init.c > from common.h to init.h > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [U-Boot] [U-Boot, v2, 3/5] common: move board_r.c prototypes in init.h

2018-03-18 Thread Tom Rini
On Tue, Mar 13, 2018 at 01:57:02PM +0100, Patrick Delaunay wrote: > Move function prototypes used in common/board_r.c > from common.h to init.h > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [U-Boot] post: remove reference to power functions

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 09:22:44AM +0100, Patrick Delaunay wrote: > The 2 functions board_power_mode and board_poweroff > are no more existing in U-Boot code (check with grep) > This patch updates the documentation and removes > the unnecessary prototypes. > > Signed-off-by: Patrick Delaunay

Re: [U-Boot] [U-Boot, v2, 2/5] common: move board_init.c prototypes in init.h

2018-03-18 Thread Tom Rini
On Tue, Mar 13, 2018 at 01:57:01PM +0100, Patrick Delaunay wrote: > Move function prototypes for common/init/board_init.c > from common.h to init.h > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [U-Boot] ppc: Remove orphan xilinx_irq.h file

2018-03-18 Thread Tom Rini
On Tue, Mar 13, 2018 at 11:17:07AM +0100, Michal Simek wrote: > This file is completely unused and it should be removed as the part of > ppc405/ppc440 xilinx platform removal. > > Signed-off-by: Michal Simek Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: FLATTENED DEVICE TREE: correct maintained path

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 11:08:09PM +0100, Heinrich Schuchardt wrote: > Change due to commit b08c8c487083 ("libfdt: move headers to > and ") > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM SAMSUNG: remove invalid paths

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 11:17:11PM +0100, Heinrich Schuchardt wrote: > Remove non-existing directories. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Minkyu Kang Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [U-Boot] [U-Boot, 1/1] MAINTAINERS: ARM FREESCALE IMX: remove invalid path

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 10:56:18PM +0100, Heinrich Schuchardt wrote: > arch/arm/cpu/armv7/mx*/ does not relate to any existing directory. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Fabio Estevam Applied to u-boot/master, thanks! -- Tom

Re: [U-Boot] common: remove unused prototypes

2018-03-18 Thread Tom Rini
On Mon, Mar 12, 2018 at 09:19:22AM +0100, Patrick Delaunay wrote: > Remove the prototypes for 4 functions no more existing > in U-Boot code (checked by grep): > - checkflash > - checkdram > - mdm_init > - setup_board_extra > > Signed-off-by: Patrick Delaunay Applied to

Re: [U-Boot] [U-Boot, v3] common: add a prototype for mach_cpu_init()

2018-03-18 Thread Tom Rini
On Fri, Mar 09, 2018 at 06:28:12PM +0100, Patrick Delaunay wrote: > Add a new file init.h with the prototype for arch_cpu_init > Add a prototype for mach_cpu_init() to avoid a warning: > no previous prototype for ‘mach_cpu_init’ > > It is a first step to move all the functions prototype > used

Re: [U-Boot] [PATCH v4 1/2] ARM: AM43xx: Add support for RTC only + DDR in self-refresh mode

2018-03-18 Thread Tom Rini
On Sat, Mar 17, 2018 at 01:32:52PM +0530, Keerthy wrote: > From: Tero Kristo > > Kernel stores information to the RTC_SCRATCH0 and RTC_SCRATCH1 registers > for wakeup from RTC-only mode with DDR in self-refresh. Parse these > registers during SPL boot and jump to the kernel

Re: [U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
On 03/18/2018 01:10 PM, Marek Vasut wrote: > On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote: >> In >> >> struct dwc3_request *r = NULL; >> r = A; >> >> the first assignment has no effect. Remove it. >> >> Signed-off-by: Heinrich Schuchardt > > The driver is

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Heinrich Schuchardt
On 03/18/2018 01:27 PM, Marek Vasut wrote: > On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >> Assigning a value to ret if it is immediately overwritten does not make >> sense. >> >> Signed-off-by: Heinrich Schuchardt > > Did you even compile-test this ? I have a feeling

[U-Boot] [RFC 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

2018-03-18 Thread Heinrich Schuchardt
The error checking should also catch the case that no range has beeen defined. syscon_get_first_range() returns NULL if no range is defined. cf. rk3399_mipi.c Signed-off-by: Heinrich Schuchardt --- I do not possess the hardware for testing. But the coding is not consistent

[U-Boot] [PATCH 1/1] video: rk3399_mipi: correct error checking

2018-03-18 Thread Heinrich Schuchardt
Pointers are never negative. Use macro IS_ERR() for checking. cf. rk3288_mipi.c Signed-off-by: Heinrich Schuchardt --- drivers/video/rockchip/rk3399_mipi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/rockchip/rk3399_mipi.c

[U-Boot] [PATCH 1/1] video: exynos: remove redundant assignments

2018-03-18 Thread Heinrich Schuchardt
No need to initialize variables if the next usage is an assignment. Signed-off-by: Heinrich Schuchardt --- drivers/video/exynos/exynos_dp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/exynos/exynos_dp.c

[U-Boot] [PATCH 1/1] video, da8xx-fb: fix time out in wait_for_event()

2018-03-18 Thread Heinrich Schuchardt
If an event does not occur the current coding stays in an endless loop. Signed-off-by: Heinrich Schuchardt --- drivers/video/da8xx-fb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index

[U-Boot] [PATCH 1/1] video: stb_truetype: simplify expression

2018-03-18 Thread Heinrich Schuchardt
Eliminate (x2 - x2) which is always zero. Signed-off-by: Heinrich Schuchardt --- drivers/video/stb_truetype.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/stb_truetype.h b/drivers/video/stb_truetype.h index 26e483cf56..5d00bff9fd 100644

[U-Boot] [PATCH 1/1] video: cfb_console: simplify logical constraint

2018-03-18 Thread Heinrich Schuchardt
(A || !A && B) == (A || B) Signed-off-by: Heinrich Schuchardt --- drivers/video/cfb_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c index 0b25897062..5b7795dd44 100644 ---

[U-Boot] [PATCH 1/1] usb: musb-new: misplaced out of bounds check

2018-03-18 Thread Heinrich Schuchardt
musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt --- drivers/usb/musb-new/musb_gadget_ep0.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [U-Boot] tools/mxsimage: Support building with LibreSSL

2018-03-18 Thread Hauke Mehrtens
On 03/18/2018 01:33 AM, Jonathan Gray wrote: > On Sat, Mar 17, 2018 at 05:24:47PM +0100, Marek Vasut wrote: >> On 03/17/2018 04:09 PM, Hauke Mehrtens wrote: >>> On 03/17/2018 03:47 PM, Marek Vasut wrote: On 03/17/2018 01:23 PM, Hauke Mehrtens wrote: > The mxsimage utility fails to compile

Re: [U-Boot] [PATCH] davinci: omapl138_lcdk: fix PLL0 frequency

2018-03-18 Thread Peter Howard
On Fri, 2018-03-16 at 10:45 -0500, David Lechner wrote: > On 03/16/2018 04:26 AM, Sekhar Nori wrote: > > On Thursday 15 March 2018 08:02 PM, David Lechner wrote: > > > > > > Thanks for the tips. I've actually done exactly that (using my > > > own SD > > > card). > > > > > > However, these

[U-Boot] pci modify [.l .w .b]

2018-03-18 Thread Steven Seeger
Hi list. If a pci modify command is issued, do_pci() takes the size specifier (.l, .w, .b) and turns it into one of PCI_SIZE_8, PCI_SIZE_16, or PCI_SIZE_32, which correspond to 0, 1, and 2. Consequently, the address increment moves at 0, 1, or 2 bytes. This would be a trivial patch for me to

[U-Boot] [PATCH v2] tools/mxsimage: Support building with LibreSSL

2018-03-18 Thread Hauke Mehrtens
The mxsimage utility fails to compile against LibreSSL because LibreSSL says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 interface. LibreSSL defines OPENSSL_VERSION_NUMBER with 0x2000L and therefor claims to have an API compatible with OpenSSL 2.0, but it does not

Re: [U-Boot] tools/mxsimage: Support building with LibreSSL

2018-03-18 Thread Hauke Mehrtens
On 03/17/2018 03:47 PM, Marek Vasut wrote: > On 03/17/2018 01:23 PM, Hauke Mehrtens wrote: >> The mxsimage utility fails to compile against LibreSSL because LibreSSL >> says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 >> interface. > > The mxsimage does support OpenSSL 1.1

[U-Boot] tools/mxsimage: Support building with LibreSSL

2018-03-18 Thread Hauke Mehrtens
The mxsimage utility fails to compile against LibreSSL because LibreSSL says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1 interface. Signed-off-by: Hauke Mehrtens --- tools/mxsimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 1/1] usb: musb: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
Setting ret = -EINVAL is superfluous. Signed-off-by: Heinrich Schuchardt --- drivers/usb/musb-new/musb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb-new/musb_core.c b/drivers/usb/musb-new/musb_core.c index 79e118ef85..19c072a67e

[U-Boot] [PATCH 1/1] usb: xhci: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
There is not need to set variables to NULL before an assignment. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index

[U-Boot] [PATCH 1/1] usb: xhci-ring: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
No need to set a variable to NULL if the next use is an assignment. Do not define variables in the middle of nowhere. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 1/1] usb: xhci-keystone: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
There is no need to set variables to NULL if they are not used before the next assignment. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci-keystone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-keystone.c

[U-Boot] [PATCH 1/1] usb: xhci-exynos5: correct error checking

2018-03-18 Thread Heinrich Schuchardt
If fdtdec_next_compatible_subnode() fails it returns a negative value. The check (node <= 0) cannot identify this if node is unsigned. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/xhci-exynos5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH 1/1] usb: sl811-hcd: remove duplicat assignment

2018-03-18 Thread Heinrich Schuchardt
Don't make the same assignment twice. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/sl811-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c index b29c67e189..e587895bfc 100644 ---

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Marek Vasut
On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: > Assigning a value to ret if it is immediately overwritten does not make > sense. > > Signed-off-by: Heinrich Schuchardt Did you even compile-test this ? I have a feeling this file is not used at all, so maybe we should

[U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Heinrich Schuchardt
Assigning a value to ret if it is immediately overwritten does not make sense. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/ehci-faraday.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-faraday.c

[U-Boot] [PATCH 1/1] usb: rockchip: remove duplicate assignement.

2018-03-18 Thread Heinrich Schuchardt
Assigning f_rkusb->reboot_flag twice doesn't make sense. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/f_rockusb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/f_rockusb.c b/drivers/usb/gadget/f_rockusb.c index d5a10f1904..ad3ae91e6d

[U-Boot] [PATCH 1/1] usb: f_mass_storage: simplify logical expression

2018-03-18 Thread Heinrich Schuchardt
An unsigned int is always >= 0. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index

Re: [U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

2018-03-18 Thread Marek Vasut
On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote: > In > > struct dwc3_request *r = NULL; > r = A; > > the first assignment has no effect. Remove it. > > Signed-off-by: Heinrich Schuchardt The driver is imported from Linux, did you fix it in Linux too ? >

[U-Boot] [PATCH 1/1] usb: gadget: remove duplicate assignment.

2018-03-18 Thread Heinrich Schuchardt
We should not make the same assignement twice. Signed-off-by: Heinrich Schuchardt --- drivers/usb/gadget/composite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index

[U-Boot] [PATCH 1/1] usb: dwc3: remove superfluous assignment

2018-03-18 Thread Heinrich Schuchardt
In struct dwc3_request *r = NULL; r = A; the first assignment has no effect. Remove it. Signed-off-by: Heinrich Schuchardt --- drivers/usb/dwc3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/ep0.c

[U-Boot] [PATCH 1/1] spi: lpc32xx: simplify logical expression

2018-03-18 Thread Heinrich Schuchardt
A & A & B == A & B Signed-off-by: Heinrich Schuchardt --- drivers/spi/lpc32xx_ssp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/lpc32xx_ssp.c b/drivers/spi/lpc32xx_ssp.c index e2a593b934..b8bce3d6e8 100644 --- a/drivers/spi/lpc32xx_ssp.c

  1   2   >