Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Michal Simek
On 18.7.2018 22:11, Marek Vasut wrote: > On 07/18/2018 04:57 PM, Michal Simek wrote: >> On 18.7.2018 16:24, Marek Vasut wrote: >>> On 07/18/2018 04:18 PM, Michal Simek wrote: On 18.7.2018 16:15, Marek Vasut wrote: > On 07/18/2018 04:00 PM, Michal Simek wrote: >> On 18.7.2018 14:54,

Re: [U-Boot] [PATCH 3/4] x86: fsp: Eliminate the reset_cpu() call

2018-07-18 Thread Bin Meng
Hi Simon, On Mon, Jul 9, 2018 at 10:39 AM, Simon Glass wrote: > Hi Bin, > > On 3 July 2018 at 02:48, Bin Meng wrote: >> In preparation for the reset driver conversion, eliminate the >> reset_cpu() call in the FSP init path as it's too early for the >> reset driver to work. >> >> Signed-off-by:

Re: [U-Boot] [PATCH 2/4] dm: sysreset: x86: Add a sysreset driver

2018-07-18 Thread Bin Meng
On Mon, Jul 9, 2018 at 10:39 AM, Simon Glass wrote: > On 3 July 2018 at 02:48, Bin Meng wrote: >> This adds a generic reset driver for x86 processor. >> >> Signed-off-by: Bin Meng >> --- >> >> drivers/sysreset/Kconfig| 6 + >> drivers/sysreset/Makefile | 1 + >>

Re: [U-Boot] [PATCH 1/4] x86: quark: acpi: Add full reset bit to the reset register value in FADT

2018-07-18 Thread Bin Meng
On Mon, Jul 9, 2018 at 10:39 AM, Simon Glass wrote: > On 3 July 2018 at 02:48, Bin Meng wrote: >> This adds full reset bit in the reset register value in the ACPI FADT >> table, so that kernel can do a thorough reboot. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/cpu/quark/acpi.c | 2 +-

[U-Boot] [PATCH v2 2/3] x86: acpi: Don't touch ACPI hardware in write_acpi_tables()

2018-07-18 Thread Bin Meng
write_acpi_tables() currently touches ACPI hardware to switch to ACPI mode at the end. Move such operation out of this function, so that it only does what the function name tells us. Signed-off-by: Bin Meng --- Changes in v2: - move variable definition to the first line in the function

[U-Boot] [PATCH v2 3/3] x86: acpi: Prevent acpi_table.h from being included more than once

2018-07-18 Thread Bin Meng
The wrapper #ifndef is currently missing in acpi_table.h. Add it to prevent it from being included multiple times. Signed-off-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/acpi_table.h | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/include/asm/acpi_table.h

[U-Boot] [PATCH v2 1/3] x86: acpi: Move APIs unrelated to ACPI tables generation to a separate library

2018-07-18 Thread Bin Meng
acpi_find_fadt(), acpi_find_wakeup_vector() and enter_acpi_mode() are something unrelated to ACPI tables generation. Move these to a separate library. This also fixes several style issues reported by checkpatch in the original codes. Signed-off-by: Bin Meng --- Changes in v2: None

Re: [U-Boot] [PATCH 0/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

2018-07-18 Thread Prabhakar Kushwaha
> -Original Message- > From: Pankaj Bansal > Sent: Friday, July 13, 2018 8:11 PM > To: u-boot@lists.denx.de > Cc: Prabhakar Kushwaha ; Priyanka Jain > ; Varun Sethi ; York Sun > ; joe.hershber...@ni.com; Pankaj Bansal > > Subject: [PATCH 0/6] driver: net: fsl-mc: Add support of multiple

Re: [U-Boot] [RFC PATCH 01/15] test/py: Extend fpga command to test all fpga load types

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Add support for info, load, loadp, loadb, loadbp, loadmk_legacy, > loadmk_legacy_gz, loadmk_fit, loadfs also with variable support. > > There are probably missing failed tests. > > Signed-off-by: Michal Simek > --- > > test/py/tests/test_fpga.py |

Re: [U-Boot] [RFC PATCH 13/15] cmd: fpga: Use CMD_RET_FAILURE instead of simple 1

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Use standard return command failure macro. > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Simon Glass ___

Re: [U-Boot] [RFC PATCH 09/15] cmd: fpga: Extract fpga info command to separate function

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Move fpga info to U_BOOT_CMD_MKENT subcommand. > Also use strtol instead of simple_strtoul. The reason is that if -1 is > passed (or fpga info without "fpga" variable) the list of all fpgas is > shown. > This functionality is in the fpga core but it

Re: [U-Boot] [RFC PATCH 05/15] cmd: fpga: Move parameter checking for loadfs/loads

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > There is no reason to check parameters in separate switch before main > one. This patch is simplifying error path and checking parameters right > after assignment. > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c | 44

Re: [U-Boot] [PATCH v2] sysreset: Add support for gpio-restart

2018-07-18 Thread Simon Glass
On 17 July 2018 at 06:59, Michal Simek wrote: > The Linux kernel has binding for gpio-restart node. > This patch is adding basic support without supporting any optional > properties. > This driver was tested on Microblaze system where gpio is connected to > SoC reset logic. > Output value is

Re: [U-Boot] [PATCH] fdt: fix fdtdec_setup_memory_banksize()

2018-07-18 Thread Simon Glass
Hi Jens, On 17 July 2018 at 09:42, Jens Wiklander wrote: > On Sun, Jul 15, 2018 at 11:20:39PM -0600, Simon Glass wrote: >> On 13 July 2018 at 04:12, Jens Wiklander wrote: >> > Prior to this patch is fdtdec_setup_memory_banksize() incorrectly >> > ignoring the "status" field. This patch fixes

Re: [U-Boot] [RFC PATCH 07/15] cmd: fpga: Clean wrong_parms handling

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > There is no reason to check parameters in separate switch. Check them > directly when they are read. Also there is no reason to check loadmk > case separately because fpga_data address must be non zero too. > > Signed-off-by: Michal Simek > --- > >

Re: [U-Boot] [PATCH] binman: ensure temp filenames don't collide

2018-07-18 Thread Simon Glass
Hi Stephen, On 16 July 2018 at 16:51, Stephen Warren wrote: > From: Stephen Warren > > The U-Boot Makefile can invoke binman multiple times in parallel. This > is problematic because binman uses a static hard-coded temporary file > name. If two instances of binman use that filename at the same

Re: [U-Boot] [RFC PATCH 10/15] cmd: fpga: Fix dump and all direct fpga load commands

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Separate dump, load, loadb, loadp and loadbp commands to separate > functions to make it clear how they are called and what parameters they > need. > > Signed-off-by: Michal Simek > --- > > Maybe they can be still groupped together with one

Re: [U-Boot] [PATCH 35/41] dm: core: device: enable power domain in probe

2018-07-18 Thread Simon Glass
Hi Peng, On 18 July 2018 at 06:56, Peng Fan wrote: > Hi Simon > >> -Original Message- >> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass >> Sent: 2018年5月31日 3:19 >> To: Peng Fan >> Cc: Stefano Babic ; Fabio Estevam >> ; U-Boot Mailing List >> Subject: Re: [PATCH

Re: [U-Boot] [RFC PATCH 08/15] cmd: fpga: Create new do_fpga_wrapper for using u-boot subcommands

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Create command wrapper to clean fpga subcommands. > The function logic is taken from cmd_dm.c > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c | 42 -- > 1 file changed, 40 insertions(+), 2 deletions(-)

Re: [U-Boot] [RFC PATCH 06/15] cmd: fpga: Remove parameter checking from fpga loadfs command

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Parameter checking is dead code because all the time there must be all > params assigned. If they are not assigned there is no 9th parameters > passed and checking before return CMD_RET_USAGE. > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c |

Re: [U-Boot] [RFC PATCH 04/15] cmd: fpga: Cleanup error handling in connection to FPGA_NONE

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Incorrect command is already handled and FPGA_NONE should be used only > one. In case of error CMD_RET_USAGE can be returned directly without any > addition logic around. > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c | 8 ++-- > 1 file

Re: [U-Boot] [PATCH 3/3] rockchip: rk3399: Add more instructions to the README

2018-07-18 Thread Simon Glass
On 16 July 2018 at 13:41, Ezequiel Garcia wrote: > This commit adds a content section and also instructions > on how to create a bootable SD/MMC device for RK3399 boards. > > Signed-off-by: Ezequiel Garcia > --- > board/rockchip/evb_rk3399/README | 55 ++-- > 1 file

Re: [U-Boot] [PATCH 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

2018-07-18 Thread Simon Glass
On 16 July 2018 at 13:41, Ezequiel Garcia wrote: > From: Randy Li > > Those pins would be used by many boards. > > Signed-off-by: Randy Li > Signed-off-by: Heiko Stuebner > Signed-off-by: Ezequiel Garcia > --- > arch/arm/dts/rk3399.dtsi | 55 +++- > 1 file

Re: [U-Boot] [PATCH 2/3] ARM: add RK3399 Ficus board

2018-07-18 Thread Simon Glass
On 16 July 2018 at 13:41, Ezequiel Garcia wrote: > This commit adds support for RK3399 Ficus board, > aka ROCK960 Enterprise Edition. > > Following peripherals are tested and known to work: > * Gigabit Ethernet > * USB 2.0 > * MMC > > Signed-off-by: Ezequiel Garcia > --- > arch/arm/dts/Makefile

Re: [U-Boot] [RFC PATCH 15/15] MAINTAINERS: Add myself as the FPGA maintainer

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > FPGA subsystem requires special care that's why it should be maintained > via one tree. > > Signed-off-by: Michal Simek > --- > > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [RFC PATCH 03/15] cmd: fpga: Move fpga_get_op to avoid local function declaration

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Move fpga_get_op() to top of file to remove local function declaration > and also remove useless retyping. > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c | 85 > ++ > 1 file

Re: [U-Boot] [RFC PATCH 02/15] cmd: fpga: Move error handling to do_fpga()

2018-07-18 Thread Simon Glass
On 18 July 2018 at 09:16, Michal Simek wrote: > Clean fpga_get_op() error handling by moving checking/print to do_fpga. > > Signed-off-by: Michal Simek > --- > > cmd/fpga.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 5/6] tpm: make TPM_V2 be compiled by default

2018-07-18 Thread Simon Glass
On 14 July 2018 at 06:16, Miquel Raynal wrote: > TPM_V1 was already compiled by default. Now that both can be compiled > at the same time, compiled them both by default. > > Signed-off-by: Miquel Raynal > --- > drivers/tpm/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon

Re: [U-Boot] [PATCH 4/6] test/py: tpm2: switch from 'tpm' to 'tpm2' command

2018-07-18 Thread Simon Glass
On 14 July 2018 at 06:16, Miquel Raynal wrote: > While using the 'tpm' command should work on most cases, this test suite > only works with TPMv2 and since the work to make both versions build at > the same time, we might end up having both 'tpm' (TPMv1) and 'tpm2' > (TPMv2) commands available at

Re: [U-Boot] [PATCH v2 3/3] watchdog: Convert Xilinx Axi watchdog driver to driver model

2018-07-18 Thread Simon Glass
Hi Shreenidhi, On 14 July 2018 at 14:35, Shreenidhi Shedi wrote: > Xilinx Axi wdt driver conversion to driver model & Kconfig update > for the same. > > Changes in V1: > - Xilinx Axi wdt driver conversion to DM initial version > > Changes in V2: > - Rectified print message > - Removed stop

Re: [U-Boot] [PATCH] watchdog: dm: Support manual relocation for watchdogs

2018-07-18 Thread Simon Glass
Hi Michal, On 15 July 2018 at 23:34, Michal Simek wrote: > On 15.7.2018 23:21, Simon Glass wrote: >> Hi Michal, >> >> On 11 July 2018 at 23:47, Michal Simek wrote: >>> On 11.7.2018 22:13, Simon Glass wrote: On 11 July 2018 at 08:41, Michal Simek wrote: > Relocate watchdog ops as was

Re: [U-Boot] [PATCH v5 3/5] arm: zynq: Dont define SDRAM_BASE and SDRAM_SIZE in .h

2018-07-18 Thread Simon Glass
On 16 July 2018 at 07:37, Michal Simek wrote: > From: Siva Durga Prasad Paladugu > > Remove the SDRAM_BASE nad SDRAM_SIZE as it can now get these and > details from DT. > > Signed-off-by: Siva Durga Prasad Paladugu > Signed-off-by: Michal Simek > --- > > Changes in v5: None > Changes in v4:

Re: [U-Boot] [PATCH 3/6] tpm: allow TPM v1 and v2 to be compiled at the same time

2018-07-18 Thread Simon Glass
Hi Miquel, On 14 July 2018 at 06:16, Miquel Raynal wrote: > While there is probably no reason to do so in a real life situation, it > will allow to compile test both stacks with the same sandbox defconfig. > > As we cannot define two 'tpm' commands at the same time, the command for > TPM v1 is

Re: [U-Boot] [PATCH 6/6] sandbox: compile both TPM stack versions and drivers

2018-07-18 Thread Simon Glass
On 14 July 2018 at 06:16, Miquel Raynal wrote: > Now that TPMv1 and TPMv2 can be compiled at the same time, let's compile > them both with Sandbox as well as both drivers (and, it is already > implied in Kconfig: both commands). > > Signed-off-by: Miquel Raynal > --- > configs/sandbox_defconfig

Re: [U-Boot] [PATCH 2/6] tpm: compile Sandbox driver by default

2018-07-18 Thread Simon Glass
On 14 July 2018 at 06:16, Miquel Raynal wrote: > When Sandbox and the TPM stack are both selected, compile Sandbox TPM > driver by default. > > Signed-off-by: Miquel Raynal > --- > drivers/tpm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 1/6] tpm: fix typo in kernel doc

2018-07-18 Thread Simon Glass
On 14 July 2018 at 06:16, Miquel Raynal wrote: > The udevice given to the open() function of course must be opened, > not closed. > > Signed-off-by: Miquel Raynal > --- > include/tpm-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

[U-Boot] [PATCH] mtd: nand: denali: correct buffer alignment for DMA transfer

2018-07-18 Thread Masahiro Yamada
The NAND framework makes sure to pass in the buffer with at least chip->buf_align alignment. Currently, the Denali NAND driver only requests 16 byte alignment. This causes unaligned cache operations for the DMA transfer. [Error Example] => nand read 8110 0 1000 NAND read: device 0 offset

Re: [U-Boot] [PATCH] omap3: beagle: re-enable EFI support after the following commit removed it by mistake:

2018-07-18 Thread Derald D. Woods
On Wed, Jul 18, 2018 at 09:38:44PM +0200, Guillaume GARDET wrote: > commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b > ARM: omap3: beagle: Enable DM_SERIAL, update distro usage and NAND layout I have found no compile or runtime issues, on my BeagleBoard Rev. C4 or xM, with the current default

Re: [U-Boot] [RFC] Make U-Boot log great again

2018-07-18 Thread Sam Protsenko
On Wed, Jul 18, 2018 at 1:14 AM, Sam Protsenko wrote: > On Tue, Jul 10, 2018 at 5:38 PM, Tom Rini wrote: >> On Tue, Jul 10, 2018 at 11:01:14AM +0800, Bin Meng wrote: >>> Hello, >>> >>> On Fri, Mar 23, 2018 at 1:44 PM, Bin Meng wrote: >>> > Hi, >>> > >>> > On Sat, Feb 17, 2018 at 3:49 AM, Robert

[U-Boot] [RFC] env: Fix errors printing on env loading

2018-07-18 Thread Sam Protsenko
This is just a draft to discuss ideas related to "Make U-Boot log great again" thread. With this patch we will have something like this: Attempting to load environment from FAT: MMC: no card present ** Bad device mmc 0 ** Failed (-5) Attempting to load environment from MMC:

Re: [U-Boot] [RESEND PATCH v2 2/2] Migrate bootlimit to Kconfig

2018-07-18 Thread Lukasz Majewski
Hi Alex, > Migrate boards which set bootlimit in the environment to Kconfig. > > We exclude gurnard_defconfig which includes a bootlimit=, but doesn't > set CONFIG_BOOTCOUNT_LIMIT, so we'd fail to include a bootlimit > setting if we migrated it. > > display5_defconfig and

[U-Boot] Re : Re: Re : Commit d233ccb1d84b90 broke MMC access on BeagleBoard xM

2018-07-18 Thread Guillaume GARDET
- Derald D. Woods a écrit : > On Wed, Jul 18, 2018 at 05:04:45PM +0200, Guillaume GARDET wrote: > > > > - Guillaume GARDET a écrit : > > > > > > Hi, > > > > > > commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b (HEAD, refs/bisect/bad) > > > Author: Derald D. Woods > > > Date: Mon

Re: [U-Boot] Re : Commit d233ccb1d84b90 broke MMC access on BeagleBoard xM

2018-07-18 Thread Derald D. Woods
On Wed, Jul 18, 2018 at 05:04:45PM +0200, Guillaume GARDET wrote: > > - Guillaume GARDET a écrit : > > > > Hi, > > > > commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b (HEAD, refs/bisect/bad) > > Author: Derald D. Woods > > Date: Mon Feb 26 17:52:58 2018 -0600 > > > > ARM: omap3:

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Marek Vasut
On 07/18/2018 04:57 PM, Michal Simek wrote: > On 18.7.2018 16:24, Marek Vasut wrote: >> On 07/18/2018 04:18 PM, Michal Simek wrote: >>> On 18.7.2018 16:15, Marek Vasut wrote: On 07/18/2018 04:00 PM, Michal Simek wrote: > On 18.7.2018 14:54, Marek Vasut wrote: >> On 07/18/2018 02:51

[U-Boot] [PATCH] omap3: beagle: re-enable EFI support after the following commit removed it by mistake:

2018-07-18 Thread Guillaume GARDET
commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b ARM: omap3: beagle: Enable DM_SERIAL, update distro usage and NAND layout Signed-off-by: Guillaume GARDET Cc: Derald D. Woods Cc: Tom Rini --- configs/omap3_beagle_defconfig | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [U-Boot] [PATCH 21/25] fastboot: sunxi: Update fastboot mmc default device

2018-07-18 Thread Alex Kiernan
On Tue, Jul 17, 2018 at 12:57 PM Maxime Ripard wrote: > > On Mon, Jul 16, 2018 at 12:11:59PM +0100, Alex Kiernan wrote: > > On Mon, Jul 16, 2018 at 11:13 AM Jagan Teki > > wrote: > > > > > > On Mon, Jul 16, 2018 at 3:16 PM, Maxime Ripard > > > wrote: > > > > On Mon, Jul 16, 2018 at 01:49:52PM

[U-Boot] [PATCH v2] mtd: add spi flash id s25fl128l

2018-07-18 Thread Clément Laigle
Add support for SPANSION s25fl128l 256k and 64k Changes for v2: - Fix EXT_ID Signed-off-by: Clément Laigle --- drivers/mtd/spi/spi_flash_ids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/spi/spi_flash_ids.c b/drivers/mtd/spi/spi_flash_ids.c index

Re: [U-Boot] [RFC PATCH 4/4] arm: zynq: spl: implement FPGA load from FIT

2018-07-18 Thread Luis Araneda
Hi Michal, On Wed, Jul 18, 2018 at 9:22 AM Michal Simek wrote: > I was playing with this a little bit. There is no reason to allocate > any space in malloc area because its/fit should already contain load > address which you should use instead. I initially thought the same, but unfortunately

Re: [U-Boot] [RFC PATCH 0/4] arm: zynq: implement FPGA load from SPL

2018-07-18 Thread Luis Araneda
Hi Michal, On Wed, Jul 18, 2018 at 4:00 AM Michal Simek wrote: > Can you please also send defconfig/config changes? > Separate patch is fine. The changes required to the defconfigs test/support this are: CONFIG_SPL_LOAD_FIT=y CONFIG_SPL_FPGA_SUPPORT=y I didn't send them because just changing

Re: [U-Boot] [PATCH 3/3] bcm968380gerg: add initial support

2018-07-18 Thread Daniel Schwierzeck
On 16.07.2018 19:06, Philippe Reynes wrote: > This add the initial support of the broadcom reference > board bcm968380gerg with a bcm68380 SoC. > > This board has 512 MB of RAM, 128 MB of flash (nand), > 2 USB port, 1 UART, 4 ethernet ports and BCM43217 (wifi). > > Signed-off-by: Philippe

Re: [U-Boot] [PATCH 2/3] bcm6838: add initial support

2018-07-18 Thread Daniel Schwierzeck
On 16.07.2018 19:06, Philippe Reynes wrote: > This adds the initial support of the Broadcom BCM6838 SoC familly, > only cpu, dram, uart and leds are supported. > > Signed-off-by: Philippe Reynes > --- > arch/mips/dts/brcm,bcm6838.dtsi | 75 > + >

Re: [U-Boot] [PATCH 1/3] bmips: ram: add an option to force the size of the ram

2018-07-18 Thread Daniel Schwierzeck
On 16.07.2018 19:06, Philippe Reynes wrote: > This adds an option to force the size of the ram, and > avoid the detection of ram size. > > Signed-off-by: Philippe Reynes > --- > drivers/ram/bmips_ram.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Daniel

Re: [U-Boot] [PATCH v3] env: Added support to save env to spi through Kconfig

2018-07-18 Thread Maxime Ripard
On Wed, Jul 18, 2018 at 04:04:37PM +0200, Michal Simek wrote: > On 18.7.2018 14:28, Maxime Ripard wrote: > > 1;5202;0c > > On Wed, Jul 18, 2018 at 09:11:35AM +0200, Michal Simek wrote: > >> From: Vipul Kumar > >> > >> This patch added support to enable CONFIG_ENV_SIZE, CONFIG_ENV_OFFSET > >> and

Re: [U-Boot] [RFC 17/35] clk: sunxi: Add initial CLK driver for H3_H5

2018-07-18 Thread Maxime Ripard
On Tue, Jul 17, 2018 at 10:20:42PM +0530, Jagan Teki wrote: > On Tue, Jul 17, 2018 at 6:06 PM, Maxime Ripard > wrote: > > On Mon, Jul 16, 2018 at 05:55:25PM +0100, Andre Przywara wrote: > >> Hi, > >> > >> On 16/07/18 13:59, Maxime Ripard wrote: > >> > On Mon, Jul 16, 2018 at 04:58:32PM +0530,

[U-Boot] [RFC PATCH 09/15] cmd: fpga: Extract fpga info command to separate function

2018-07-18 Thread Michal Simek
Move fpga info to U_BOOT_CMD_MKENT subcommand. Also use strtol instead of simple_strtoul. The reason is that if -1 is passed (or fpga info without "fpga" variable) the list of all fpgas is shown. This functionality is in the fpga core but it couldn't be performed. Signed-off-by: Michal Simek ---

[U-Boot] [RFC PATCH 14/15] cmd: fpga: Fix loads command

2018-07-18 Thread Michal Simek
loads fpga loads loads use debug instead of puts Signed-off-by: Michal Simek --- cmd/fpga.c | 148 +++-- 1 file changed, 36 insertions(+), 112 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index 5fabfca39a2b..b82f1175b01f 100644

[U-Boot] [RFC PATCH 06/15] cmd: fpga: Remove parameter checking from fpga loadfs command

2018-07-18 Thread Michal Simek
Parameter checking is dead code because all the time there must be all params assigned. If they are not assigned there is no 9th parameters passed and checking before return CMD_RET_USAGE. Signed-off-by: Michal Simek --- cmd/fpga.c | 7 --- 1 file changed, 7 deletions(-) diff --git

[U-Boot] [RFC PATCH 08/15] cmd: fpga: Create new do_fpga_wrapper for using u-boot subcommands

2018-07-18 Thread Michal Simek
Create command wrapper to clean fpga subcommands. The function logic is taken from cmd_dm.c Signed-off-by: Michal Simek --- cmd/fpga.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index

[U-Boot] [RFC PATCH 10/15] cmd: fpga: Fix dump and all direct fpga load commands

2018-07-18 Thread Michal Simek
Separate dump, load, loadb, loadp and loadbp commands to separate functions to make it clear how they are called and what parameters they need. Signed-off-by: Michal Simek --- Maybe they can be still groupped together with one switch/case but it can be done later. --- cmd/fpga.c | 166

[U-Boot] [RFC PATCH 13/15] cmd: fpga: Use CMD_RET_FAILURE instead of simple 1

2018-07-18 Thread Michal Simek
Use standard return command failure macro. Signed-off-by: Michal Simek --- cmd/fpga.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index 8237bbc219b4..5fabfca39a2b 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -357,12 +357,12 @@

[U-Boot] [RFC PATCH 04/15] cmd: fpga: Cleanup error handling in connection to FPGA_NONE

2018-07-18 Thread Michal Simek
Incorrect command is already handled and FPGA_NONE should be used only one. In case of error CMD_RET_USAGE can be returned directly without any addition logic around. Signed-off-by: Michal Simek --- cmd/fpga.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[U-Boot] [RFC PATCH 07/15] cmd: fpga: Clean wrong_parms handling

2018-07-18 Thread Michal Simek
There is no reason to check parameters in separate switch. Check them directly when they are read. Also there is no reason to check loadmk case separately because fpga_data address must be non zero too. Signed-off-by: Michal Simek --- cmd/fpga.c | 35 --- 1 file

[U-Boot] [RFC PATCH 12/15] cmd: fpga: Fix loadmk command

2018-07-18 Thread Michal Simek
Signed-off-by: Michal Simek --- cmd/fpga.c | 240 - 1 file changed, 125 insertions(+), 115 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index 826f63371a66..8237bbc219b4 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -65,7 +65,6 @@

[U-Boot] [RFC PATCH 15/15] MAINTAINERS: Add myself as the FPGA maintainer

2018-07-18 Thread Michal Simek
FPGA subsystem requires special care that's why it should be maintained via one tree. Signed-off-by: Michal Simek --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 570bc6d1a525..3bded710b15c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[U-Boot] [RFC PATCH 11/15] cmd: fpga: Fix loadfs command

2018-07-18 Thread Michal Simek
loadfs Revert "loafs" This reverts commit 4ec8e7247396458dca5d0185b5df308df7b0ef2b. Add loadfs This reverts commit d6b0e830b8c7a31d4cc87cfd44e70c41417114bb. Signed-off-by: Michal Simek fslo` --- cmd/fpga.c | 58 -- 1 file changed,

[U-Boot] [RFC PATCH 05/15] cmd: fpga: Move parameter checking for loadfs/loads

2018-07-18 Thread Michal Simek
There is no reason to check parameters in separate switch before main one. This patch is simplifying error path and checking parameters right after assignment. Signed-off-by: Michal Simek --- cmd/fpga.c | 44 +--- 1 file changed, 21 insertions(+), 23

[U-Boot] [RFC PATCH 03/15] cmd: fpga: Move fpga_get_op to avoid local function declaration

2018-07-18 Thread Michal Simek
Move fpga_get_op() to top of file to remove local function declaration and also remove useless retyping. Signed-off-by: Michal Simek --- cmd/fpga.c | 85 ++ 1 file changed, 41 insertions(+), 44 deletions(-) diff --git a/cmd/fpga.c

[U-Boot] [RFC PATCH 01/15] test/py: Extend fpga command to test all fpga load types

2018-07-18 Thread Michal Simek
Add support for info, load, loadp, loadb, loadbp, loadmk_legacy, loadmk_legacy_gz, loadmk_fit, loadfs also with variable support. There are probably missing failed tests. Signed-off-by: Michal Simek --- test/py/tests/test_fpga.py | 516 + 1 file

[U-Boot] [RFC PATCH 02/15] cmd: fpga: Move error handling to do_fpga()

2018-07-18 Thread Michal Simek
Clean fpga_get_op() error handling by moving checking/print to do_fpga. Signed-off-by: Michal Simek --- cmd/fpga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/fpga.c b/cmd/fpga.c index 791fe5cb7718..abe683720285 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@

[U-Boot] [RFC PATCH 00/15] cmd: fpga: Fix fpga command handling and add some fpga tests

2018-07-18 Thread Michal Simek
Hi, We are using this framework for a while and by adding more and more features it requires small redesigned how commands are handled. This is something what I have put together to improve readability of this code and also remove code which is bogus and completely untested. The series depends

[U-Boot] Re : Commit d233ccb1d84b90 broke MMC access on BeagleBoard xM

2018-07-18 Thread Guillaume GARDET
- Guillaume GARDET a écrit : > > Hi, > > commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b (HEAD, refs/bisect/bad) > Author: Derald D. Woods > Date: Mon Feb 26 17:52:58 2018 -0600 > > ARM: omap3: beagle: Enable DM_SERIAL, update distro usage and NAND layout > > broke MMC access on

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Michal Simek
On 18.7.2018 16:24, Marek Vasut wrote: > On 07/18/2018 04:18 PM, Michal Simek wrote: >> On 18.7.2018 16:15, Marek Vasut wrote: >>> On 07/18/2018 04:00 PM, Michal Simek wrote: On 18.7.2018 14:54, Marek Vasut wrote: > On 07/18/2018 02:51 PM, Michal Simek wrote: >> There shouldn't be a

[U-Boot] Commit d233ccb1d84b90 broke MMC access on BeagleBoard xM

2018-07-18 Thread Guillaume GARDET
Hi, commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b (HEAD, refs/bisect/bad) Author: Derald D. Woods Date: Mon Feb 26 17:52:58 2018 -0600 ARM: omap3: beagle: Enable DM_SERIAL, update distro usage and NAND layout broke MMC access on Beagleboard xM (rev. B). For my SD card with 2

Re: [U-Boot] [PATCH v4 6/6] common: Generic loader for file system

2018-07-18 Thread Michal Simek
On 6.7.2018 10:28, tien.fong.c...@intel.com wrote: > From: Tien Fong Chee > > This is file system generic loader which can be used to load > the file image from the storage into target such as memory. > The consumer driver would then use this loader to program whatever, > ie. the FPGA device. >

Re: [U-Boot] [PATCH v4 0/6] Generic file system firmware loader DM

2018-07-18 Thread Michal Simek
On 6.7.2018 10:24, tien.fong.c...@intel.com wrote: > From: Tien Fong Chee > > This patchset contains generic file system loader DM which is very close to > Linux firmware loader but for U-Boot framework. Generic file system firmware > loader can be used load whatever into target location, and

Re: [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env

2018-07-18 Thread Tom Rini
On Wed, Jul 18, 2018 at 04:04:49PM +0300, Sam Protsenko wrote: > On Wed, Jul 18, 2018 at 3:53 PM, Tom Rini wrote: > > On Wed, Jul 18, 2018 at 01:09:12AM +0300, Sam Protsenko wrote: > > > >> This is just a draft to discuss ideas related to "Make U-Boot log great > >> again" thread. > >> > >> With

Re: [U-Boot] Clarification ECC bytes

2018-07-18 Thread Fernando AE
Thanks for your reply. Following your suggestion, should I ask Scott Wood? In some mailing lists we are advised not to directly send emails, if not invited. Regards, Fernando On Wed, Jul 18, 2018 at 4:03 PM, Wolfgang Denk wrote: > Dear Fernando, > > In message > you > wrote: >> >> I'm

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Marek Vasut
On 07/18/2018 04:18 PM, Michal Simek wrote: > On 18.7.2018 16:15, Marek Vasut wrote: >> On 07/18/2018 04:00 PM, Michal Simek wrote: >>> On 18.7.2018 14:54, Marek Vasut wrote: On 07/18/2018 02:51 PM, Michal Simek wrote: > There shouldn't be a need to call private spl_load_fpga_image()

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Michal Simek
On 18.7.2018 16:15, Marek Vasut wrote: > On 07/18/2018 04:00 PM, Michal Simek wrote: >> On 18.7.2018 14:54, Marek Vasut wrote: >>> On 07/18/2018 02:51 PM, Michal Simek wrote: There shouldn't be a need to call private spl_load_fpga_image() because the whole sequence should be already

Re: [U-Boot] [ANN] U-Boot v2018.07 released

2018-07-18 Thread Wolfgang Denk
Dear Tom, In message <20180718123401.GC4609@bill-the-cat> you wrote: > > Ah, and now I see the other details. Yes, if there's stuff out of tree > in "gitdm" that would be needed to use it here, then no, it doesn't make > sense to try and put the config files under doc/ or something in U-Boot >

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Marek Vasut
On 07/18/2018 04:00 PM, Michal Simek wrote: > On 18.7.2018 14:54, Marek Vasut wrote: >> On 07/18/2018 02:51 PM, Michal Simek wrote: >>> There shouldn't be a need to call private spl_load_fpga_image() >>> because the whole sequence should be already handled by fpga_load(). >>> The patch let

Re: [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env

2018-07-18 Thread Wolfgang Denk
Dear Tom, In message <20180718125351.GE4609@bill-the-cat> you wrote: > > > Loading Environment from FAT... > >--> MMC: no card present > >--> ** Bad device mmc 0 ** > >--> Failed (-5) > > Loading Environment from MMC... > >--> OK > > > > instead of: > >

Re: [U-Boot] [PATCH v3] env: Added support to save env to spi through Kconfig

2018-07-18 Thread Michal Simek
On 18.7.2018 14:28, Maxime Ripard wrote: > 1;5202;0c > On Wed, Jul 18, 2018 at 09:11:35AM +0200, Michal Simek wrote: >> From: Vipul Kumar >> >> This patch added support to enable CONFIG_ENV_SIZE, CONFIG_ENV_OFFSET >> and CONFIG_ENV_SECT_SIZE through Kconfig for Zynq and Zynqmp. >> >>

Re: [U-Boot] Clarification ECC bytes

2018-07-18 Thread Wolfgang Denk
Dear Fernando, In message you wrote: > > I'm rebasing our internal code over v2017.11 and I found an unexpected > change in drivers/mtd/nand/nand_base.c: In such cases it is always a good idea to run "git blame" to find out where the code is coming from... > /* See nand_bch_init() for

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Michal Simek
On 18.7.2018 14:54, Marek Vasut wrote: > On 07/18/2018 02:51 PM, Michal Simek wrote: >> There shouldn't be a need to call private spl_load_fpga_image() >> because the whole sequence should be already handled by fpga_load(). >> The patch let spl_load_fit_image() to load data to right location based

Re: [U-Boot] [RFC PATCH 1/4] spl: fit: display a message when an FPGA image is loaded

2018-07-18 Thread Michal Simek
On 18.7.2018 09:41, Luis Araneda wrote: > A message should be displayed if an image is loaded > to an FPGA, because the hardware might have changed, > and the user should be informed > > Signed-off-by: Luis Araneda > --- > common/spl/spl_fit.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [U-Boot] [RFC PATCH 3/4] arm: zynq: spl: fix FPGA initialization

2018-07-18 Thread Michal Simek
On 18.7.2018 09:41, Luis Araneda wrote: > commit 4aba5fb857c1 ("arm: zynq: Rework FPGA initialization") > moved FPGA initialization from board_init() to arch_early_init_r(), > which is not called as part of the SPL > > Fix this by calling arch_early_init_r() in the spl_board_init() > function, so

Re: [U-Boot] [RFC PATCH 2/4] drivers: fpga: zynqpl: fix compilation with SPL

2018-07-18 Thread Michal Simek
On 18.7.2018 09:41, Luis Araneda wrote: > Disable the use of function zynq_loadfs when compiling > the driver for the SPL, as the following filesystem > functions are not found by the linker: > - fs_set_blk_dev > - fs_read > - fs_set_blk_dev > - fs_read > - fs_read > > Signed-off-by: Luis Araneda

Re: [U-Boot] [RFC PATCH 4/4] arm: zynq: spl: implement FPGA load from FIT

2018-07-18 Thread Michal Simek
On 18.7.2018 09:41, Luis Araneda wrote: > Implement FPGA bitstream loading from SPL. The bitstream > is loaded from a FIT image into dynamically allocated memory > before programming the FPGA. > > Signed-off-by: Luis Araneda > --- > arch/arm/mach-zynq/spl.c | 39

Re: [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env

2018-07-18 Thread Sam Protsenko
On Wed, Jul 18, 2018 at 3:53 PM, Tom Rini wrote: > On Wed, Jul 18, 2018 at 01:09:12AM +0300, Sam Protsenko wrote: > >> This is just a draft to discuss ideas related to "Make U-Boot log great >> again" thread. >> >> With this patch we will see something like: >> >> Loading Environment from

Re: [U-Boot] [PATCH 35/41] dm: core: device: enable power domain in probe

2018-07-18 Thread Peng Fan
Hi Simon > -Original Message- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: 2018年5月31日 3:19 > To: Peng Fan > Cc: Stefano Babic ; Fabio Estevam > ; U-Boot Mailing List > Subject: Re: [PATCH 35/41] dm: core: device: enable power domain in probe > > On

Re: [U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Marek Vasut
On 07/18/2018 02:51 PM, Michal Simek wrote: > There shouldn't be a need to call private spl_load_fpga_image() > because the whole sequence should be already handled by fpga_load(). > The patch let spl_load_fit_image() to load data to right location based > on "load" property in FIT and then call

Re: [U-Boot] [RFC 2/2] env: Add prefix to error messages when loading env

2018-07-18 Thread Tom Rini
On Wed, Jul 18, 2018 at 01:09:12AM +0300, Sam Protsenko wrote: > This is just a draft to discuss ideas related to "Make U-Boot log great > again" thread. > > With this patch we will see something like: > > Loading Environment from FAT... >--> MMC: no card present >--> ** Bad

[U-Boot] [PATCH] spl: fpga: Implement fpga bistream loading with fpga_load

2018-07-18 Thread Michal Simek
There shouldn't be a need to call private spl_load_fpga_image() because the whole sequence should be already handled by fpga_load(). The patch let spl_load_fit_image() to load data to right location based on "load" property in FIT and then call fpga_load(). The patch is partially reverting "spl:

Re: [U-Boot] [RFC 1/2] env: Drop error messages when loading environment

2018-07-18 Thread Tom Rini
On Wed, Jul 18, 2018 at 08:19:50AM +0200, Wolfgang Denk wrote: > Dear Sam, > > In message <20180717220912.11358-1-semen.protse...@linaro.org> you wrote: > > This is just a draft to discuss ideas related to "Make U-Boot log great > > again" thread. > > > > With this patch we will have something

Re: [U-Boot] [RFC 1/2] env: Drop error messages when loading environment

2018-07-18 Thread Sam Protsenko
On Wed, Jul 18, 2018 at 9:19 AM, Wolfgang Denk wrote: > Dear Sam, > > In message <20180717220912.11358-1-semen.protse...@linaro.org> you wrote: >> This is just a draft to discuss ideas related to "Make U-Boot log great >> again" thread. >> >> With this patch we will have something like this: >>

Re: [U-Boot] [PATCH V2 00/32] i.MX: Add i.MX8QXP support

2018-07-18 Thread Peng Fan
> -Original Message- > From: Peter Robinson [mailto:pbrobin...@gmail.com] > Sent: 2018年7月18日 20:44 > To: Peng Fan > Cc: Lokesh Vutla ; sba...@denx.de; Fabio Estevam > ; u-boot@lists.denx.de; dl-linux-imx > > Subject: Re: [U-Boot] [PATCH V2 00/32] i.MX: Add i.MX8QXP support > > >> On

Re: [U-Boot] [PATCH V2 00/32] i.MX: Add i.MX8QXP support

2018-07-18 Thread Peter Robinson
>> On Wednesday 18 July 2018 07:05 AM, Peng Fan wrote: >> > This patchset is to upstream i.MX8QXP and mek board support, with some >> > drivers update to support i.MX8QXP. The information about the >> > processor could be found >> >

Re: [U-Boot] [ANN] U-Boot v2018.07 released

2018-07-18 Thread Tom Rini
On Wed, Jul 18, 2018 at 08:59:20AM +0200, Wolfgang Denk wrote: > Dear Michal, > > In message you wrote: > > > > > Of course we can do that (actually it's two files, > > > "u-boot-config/aliases" and "u-boot-config/domain-map"). > > > > and gitdm.config right? (not sure if that

Re: [U-Boot] [PATCH v3] env: Added support to save env to spi through Kconfig

2018-07-18 Thread Maxime Ripard
1;5202;0c On Wed, Jul 18, 2018 at 09:11:35AM +0200, Michal Simek wrote: > From: Vipul Kumar > > This patch added support to enable CONFIG_ENV_SIZE, CONFIG_ENV_OFFSET > and CONFIG_ENV_SECT_SIZE through Kconfig for Zynq and Zynqmp. > > Signed-off-by: Vipul Kumar > Signed-off-by: Michal Simek >

  1   2   >