Re: [PATCH v2] clk: imx8mp: Fill in DWC3 USB, USB PHY, HSIOMIX clock

2022-04-06 Thread Peng Fan (OSS)
On 2022/4/1 22:30, Marek Vasut wrote: Add clock tables required to bring up DWC3 USB, USB PHY and HSIOMIX domain. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: Ye Li Reviewed-by: Peng Fan --- V2: - Get and probe 24m clock without registering it

Re: [PATCH] imx: power-domain: Add i.MX8MP support

2022-04-06 Thread Peng Fan (OSS)
On 2022/4/1 9:12, Marek Vasut wrote: Add i.MX8MP power domain handling into the driver. This is based on the Linux GPCv2 driver state which is soon to be in Linux next. Do we really need this in U-Boot? You will also port the blk-ctrl part? That would be lots code! Thanks, Peng.

Re: [PATCH] ARM: imx: Get rid of only i.MX8M SMCCC arch call

2022-04-06 Thread Peng Fan (OSS)
On 2022/3/31 10:56, Marek Vasut wrote: This is the only place where i.MX8M code does SMCCC call, remove it. The output has little value as it prints some part of commit ID, and worse, if there is no SMC handler installed, the code outright hangs or crashes the system. By removing this one

Re: [PATCH] arm: imx: parse-container: add some missing end of line

2022-04-06 Thread Peng Fan (OSS)
On 2022/3/30 19:49, Clément Péron wrote: Some printf() have strings that doesn't terminate with end of line and make the output hard to read. Signed-off-by: Clément Péron Reviewed-by: Peng Fan --- arch/arm/mach-imx/parse-container.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] imx8ulp: clock: Fix lcd clock algo

2022-04-06 Thread Peng Fan (OSS)
On 2022/3/31 18:39, Loic Poulain wrote: The div loop uses reassign and reuse parent_rate, which causes the parent rate reference to be wrong after the first loop, the resulting clock becomes incorrect for div != 1. Fixes: 829e06bf4175 ("imx8ulp: clock: Add MIPI DSI clock and DCNano clock")

[PATCH u-boot-net v4 14/14] net: phy: don't require PHY interface mode during PHY creation

2022-04-06 Thread Marek Behún
From: Marek Behún Currently we require PHY interface mode to be known when finding/creating the PHY - the functions * phy_connect_phy_id() * phy_device_create() * create_phy_by_mask() * search_for_existing_phy() * get_phy_device_by_mask() * phy_find_by_mask() all require the

[PATCH u-boot-net v4 13/14] bcmgenet, sun8i_emac: Don't connect PHY two times

2022-04-06 Thread Marek Behún
From: Marek Behún The bcmgenet and sun8i_emac drivers call phy_connect(), which finds / creates the PHY and also connects it to the eth device via phy_connect_dev(), then set some phydev members (bcmgenet only), and then call phy_connect_dev() explicitly again. Drop the second

[PATCH u-boot-net v4 09/14] treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA

2022-04-06 Thread Marek Behún
From: Marek Behún Rename constant PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA to make it compatible with Linux' naming. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean --- board/freescale/corenet_ds/eth_hydra.c | 2 +-

[PATCH u-boot-net v4 07/14] net: introduce helpers to get PHY interface mode from a device/ofnode

2022-04-06 Thread Marek Behún
From: Marek Behún Add helpers ofnode_read_phy_mode() and dev_read_phy_mode() to parse the "phy-mode" / "phy-connection-type" property. Add corresponding UT test. Use them treewide. This allows us to inline the phy_get_interface_by_name() into ofnode_read_phy_mode(), since the former is not

[PATCH u-boot-net v4 12/14] net: phy: use ->is_c45 instead of is_10g_interface()

2022-04-06 Thread Marek Behún
From: Marek Behún Use phydev->is_c45 instead of is_10g_interface(phydev->interface) to determine whether clause 45 protocol should be used. Signed-off-by: Marek Behún Reviewed-by: Ramon Fried --- drivers/net/phy/phy.c | 8 include/phy.h | 12 2 files changed, 4

[PATCH u-boot-net v4 10/14] phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum definition

2022-04-06 Thread Marek Behún
From: Marek Behún Move PHY_INTERFACE_MODE_NA to the beginning of the enum definition to make it have zero value. This makes it possible (although not encouraged) to test for invalid/nonexistent interface mode with !val instead of val == PHY_INTERFACE_MODE_NA. The comment near the definition

[PATCH u-boot-net v4 11/14] net: phy: xilinx: Check interface type in ->config(), not ->probe()

2022-04-06 Thread Marek Behún
From: Marek Behún We want to be able to have phydev->interface uninitialized during ->probe(). We should assume that phydev->interface is initialized only before ->config(). Signed-off-by: Marek Behún Reviewed-by: Ramon Fried --- drivers/net/phy/xilinx_gmii2rgmii.c | 10 +- 1 file

[PATCH u-boot-net v4 08/14] treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX

2022-04-06 Thread Marek Behún
From: Marek Behún Rename constant PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX to make it compatible with Linux' naming. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Vladimir Oltean --- drivers/core/ofnode.c | 2 +- drivers/net/phy/aquantia.c | 2 +-

[PATCH u-boot-net v4 05/14] treewide: use dm_mdio_read/write/reset() wrappers

2022-04-06 Thread Marek Behún
From: Marek Behún Use the new dm_mdio_read/write/reset() wrappers treewide, instead of always getting and dereferencing MDIO operations structure pointer. Signed-off-by: Marek Behún Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean --- drivers/net/mdio_mux_sandbox.c | 6 ++

[PATCH u-boot-net v4 06/14] net: phy: fix parsing wrong property

2022-04-06 Thread Marek Behún
From: Marek Behún The "phy-interface-type" property should be "phy-connection-type". Signed-off-by: Marek Behún Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy.c

[PATCH u-boot-net v4 04/14] net: mdio-uclass: add wrappers for read/write/reset operations

2022-04-06 Thread Marek Behún
From: Marek Behún Add wrappers dm_mdio_read(), dm_mdio_write() and dm_mdio_reset() for DM MDIO's .read(), .write() and .reset() operations. Signed-off-by: Marek Behún Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean --- include/miiphy.h | 31 +++

[PATCH u-boot-net v4 03/14] net: introduce helpers to get PHY ofnode from MAC

2022-04-06 Thread Marek Behún
From: Marek Behún Add helpers ofnode_get_phy_node() and dev_get_phy_node() and use it in net/mdio-uclass.c function dm_eth_connect_phy_handle(). Also add corresponding UT test. This is useful because other part's of U-Boot may want to get PHY ofnode without connecting a PHY. Signed-off-by:

[PATCH u-boot-net v4 02/14] net: mdio-uclass: use ARRAY_SIZE()

2022-04-06 Thread Marek Behún
From: Marek Behún Use the ARRAY_SIZE() macro instead of hardcoding sizes of arrays in macros. Signed-off-by: Marek Behún Reviewed-by: Vladimir Oltean --- net/mdio-uclass.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c

[PATCH u-boot-net v4 01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str

2022-04-06 Thread Marek Behún
From: Marek Behún These global variables should both have type static const char * const Signed-off-by: Marek Behún Reviewed-by: Ramon Fried Reviewed-by: Vladimir Oltean --- net/mdio-uclass.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/mdio-uclass.c

[PATCH u-boot-net v4 00/14] u-boot-net refactors, fixes, cleanups

2022-04-06 Thread Marek Behún
From: Marek Behún Hello, this is v4 of https://patchwork.ozlabs.org/project/uboot/list/?series=290889. Changes since v3: - rebased on top of origin/next - fixed binman failure: added #address-cells/#sice-cells to sandbox' test.dts' mdio node in patch Changes since v2: - added UT tests for

Re: [PATCH 1/3] binman: add sign option for binman

2022-04-06 Thread Alper Nebi Yasak
On 06/04/2022 23:28, Ivan Mikhaylov wrote: > On Tue, 2022-04-05 at 21:54 +0300, Alper Nebi Yasak wrote: >> On 22/03/2022 00:43, Ivan Mikhaylov wrote: >>> Introduce proof of concept for binman's new option which provides >>> sign >>> and replace sections in binary images. >>> >>> Usage as example:

[PATCH] fs: Allow to compile FS_SQUASHFS only for proper U-Boot

2022-04-06 Thread Pali Rohár
CONFIG_SPL_FS_SQUASHFS cannot be disabled when CONFIG_FS_SQUASHFS is enabled. Fix it. Signed-off-by: Pali Rohár --- fs/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fs.c b/fs/fs.c index 7bf8c440886a..b4306cf8499e 100644 --- a/fs/fs.c +++ b/fs/fs.c @@ -286,7 +286,7

[PATCH] squashfs: Fix compilation on big endian systems

2022-04-06 Thread Pali Rohár
Signed-off-by: Pali Rohár --- fs/squashfs/sqfs.c | 3 +-- fs/squashfs/sqfs_dir.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c index 5d9c52af80ba..41cb811c1b32 100644 --- a/fs/squashfs/sqfs.c +++ b/fs/squashfs/sqfs.c @@ -11,8

[PATCH 2/2] rockchip: Enable AHCI/SCSI/SATA on rockpro64-rk3399.

2022-04-06 Thread Vagrant Cascadian
Add options to enable AHCI, SCSI and SATA. Signed-off-by: Vagrant Cascadian --- configs/rockpro64-rk3399_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index d5e98a4f73..858410e8f7 100644 ---

[PATCH 1/2] rockchip: Enable SCSI in distro bootcmd for rk3399.

2022-04-06 Thread Vagrant Cascadian
Include SCSI in the list of boot targets if CONFIG_CMD_SCSI is enabled. Signed-off-by: Vagrant Cascadian --- include/configs/rockchip-common.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h index

[PATCH 0/2] Enable booting from SCSI on rockpro64-rk3399.

2022-04-06 Thread Vagrant Cascadian
This patch series adds SCSI booting to rockchip-common.h to enable scsi boot options from distro boot, and enables SCSI options in the rockpro64-rk3399 configuration. Vagrant Cascadian (2): rockchip: Enable SCSI in distro bootcmd for rk3399. rockchip: Enable AHCI/SCSI/SATA on

Re: [PATCH 0/6] introduce Arm FF-A support

2022-04-06 Thread Tom Rini
On Tue, Mar 29, 2022 at 04:16:53PM +0100, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > This patchset adds support for Arm FF-A (Arm Firmware Framework for Armv8-A > v1.0). > > FF-A support is generic by design and can be used by any Arm platform. > > The features added

Re: [PATCH v1 0/6] Add Nuvoton NPCM750 support

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 03:57:31PM +0800, Jim Liu wrote: > The patch series add basic supoorts for NPCM750, which > is Nuvoton's 3th-generation BMC (Baseboard Management Controller). > Add drivers to support Clock,Timer,Uart for NPCM7xx SoC. > > the NPCM750 computing subsystem comprises a

Re: [PATCH 5/5] arm: mvebu: turris_mox: Add NVMe and SCSI to boot targets

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 11:39:36 +0200 Pali Rohár wrote: > U-Boot for Turris Mox has already enabled NVMe and SCSI support. So add > NVMe and SCSI to boot targets. > > Signed-off-by: Pali Rohár And for MOX I am not sure whether NVME and SCSI can be disabled in menuconfig. Either we need to update

Re: [PATCH 4/5] arm: mvebu: turris_omnia: Add NVMe to boot targets

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 11:39:35 +0200 Pali Rohár wrote: > U-Boot for Turris Omnia has already enabled NVMe support. So add NVMe to > boot targets. As in my previous message, an user may want to compile U-Boot without NVMe support. They can do this now with menuconfig. If NVME support is to be

Re: [PATCH 3/5] arm: mvebu: turris_omnia: Always enable MMC, SCSI and USB boot targets

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 11:39:34 +0200 Pali Rohár wrote: > U-Boot for Turris Omnia is always compiled with MMC, SCSI and USB support, > so always enable macros for booting from these devices. This is not true. Attaching config where scsi is disabled. If we want to enforce MMC, SCSI and USB, we

Re: [PATCH 2/5] arm: mvebu: turris_omnia: Define CONFIG_ETHPRIME instead of ethact= ENV

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 11:39:33 +0200 Pali Rohár wrote: > CONFIG_ETHPRIME defines primary ethernet device and env variable $ethact > stores currently active ethernet device. > > So there is no point to set ethact= in default environment. Instead set > CONFIG_ETHPRIME properly. > > Signed-off-by:

Re: [PATCH 1/5] arm: mvebu: turris_omnia: Fix RESET button message

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 11:39:32 +0200 Pali Rohár wrote: > Signed-off-by: Pali Rohár nitpick: if you don't have anything to say in commit message, don't leave it empty. At least copy the commit title. Reviewed-by: Marek Behún

Re: [PATCH] tools: kwboot: Replace fstat()+st_size by lseek()+SEEK_END

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 15:18:59 +0200 Pali Rohár wrote: > fstat()'s st_size works only for regular files. lseek() with SEEK_END works > also for block or MTD devices. This replacement allows kwboot to load > kwbimage from /dev/mtd0 for booting another device over /dev/ttyS0. > > Signed-off-by:

Re: [PATCH] arm: mvebu: Add support for reading LD0 and LD1 eFuse

2022-04-06 Thread Marek Behún
On Wed, 6 Apr 2022 14:18:18 +0200 Pali Rohár wrote: > Armada 385 contains 64 lines of HD eFuse and 2 lines of LD eFuse. HD eFuse > is used for secure boot and each line is 64 bits long + 1 lock bit. LD > eFuse lines are 256 bits long + 1 lock bit. LD 0 line is reserved for > Marvell Internal

Re: [PATCH 1/3] binman: add sign option for binman

2022-04-06 Thread Ivan Mikhaylov
On Tue, 2022-04-05 at 21:54 +0300, Alper Nebi Yasak wrote: > On 22/03/2022 00:43, Ivan Mikhaylov wrote: > > Introduce proof of concept for binman's new option which provides > > sign > > and replace sections in binary images. > > > > Usage as example: > > > > from: > > mkimage -G privateky -r -o

[PATCH v2] IOMUX: Fix access past end of console_devices

2022-04-06 Thread Sean Anderson
We should only access console_devices[file][i] once we have checked that i < cd_count[file]. Otherwise, we will access uninitialized memory at the end of the loop. console_devices[file][i] should not be NULL, but putting the assignment in the loop condition allows us to ensure that i is checked

Re: [PATCH 0/8] Fix misc ASAN reports

2022-04-06 Thread Sean Anderson
On 4/3/22 6:39 AM, Andrew Scull wrote: I've been experimenting with ASAN on sandbox and turned up a few issues that are fixed in this series. Basic ASAN was easy to turn on, but integrating with dlmalloc was messier and fairly intrusive. Even when I had it working, there was only a small

Re: [PATCH v1 5/6] clk: nuvoton: Add support for NPCM750

2022-04-06 Thread Sean Anderson
On 4/6/22 3:57 AM, Jim Liu wrote: Add clock controller driver for NPCM750 Signed-off-by: Jim Liu This looks very similar to the NPCM845 driver. Would it be possible to combine them? --Sean --- drivers/clk/Makefile | 1 + drivers/clk/nuvoton/Makefile

Re: [PATCH] clk: imx8mp: Add ECSPI clocks

2022-04-06 Thread Fabio Estevam
Hi Elmar, On 06/04/2022 08:39, Elmar Albert wrote: Add clock tables required for bing up ECSPI interfaces nit: s/bing/bring Signed-off-by: Elmar Albert Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: uboot-imx Signed-off-by: Elmar Albert Reviewed-by: Fabio Esteva,

Re: [RFC PATCH v2] mips: dts: add initial support for ls1c300 SoC

2022-04-06 Thread Sean Anderson
Hi Du, Some of my comments on your previous patch still apply. This should be broken up into separate commits for submission. On 4/5/22 5:12 PM, Du Huanpeng wrote: Loongson 1C is a cost-effective SOC chip for industrial control and the Internet of Things. The Loongson 1C includes a

Re: [RFC PATCH] mips: dts: add initial support for ls1c300 SoC

2022-04-06 Thread Sean Anderson
On 4/6/22 5:22 AM, d...@hodcarrier.org wrote: Hi, Sean, thank you for the comments, I have fix most issues and sent a v2 patch.  > See Techinical Reference Manual for details: https://www.loongson.cn/  Can you provide a direct link please? I looked around a bit but I don't  read Chinese 

Re: [PULL] u-boot-riscv/master

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 04:43:30AM +, Leo Liang wrote: > Hi Tom, > > The following changes since commit 59bffec43a657598b194b9eb30dc01eec06078c7: > > Merge branch '2022-04-04-platform-updates' (2022-04-05 13:45:22 -0400) > > are available in the Git repository at: > >

Re: [PATCH] Makefile: add endian link flag to u-boot-elf.o

2022-04-06 Thread Tom Rini
On Thu, Mar 31, 2022 at 02:41:42AM +0800, Du Huanpeng wrote: > From: Du Huanpeng > > fix compile error when using a little-endian to build with configs: > sfr_nb4-ser_ram_defconfig > comtrend_wap5813n_ram_defconfig > comtrend_ar5387un_ram_defconfig >

Re: [PATCH] tools: mkimage: No need to verify_header for header_v2

2022-04-06 Thread Tom Rini
On Wed, Mar 30, 2022 at 06:05:59PM +0800, Kever Yang wrote: > From: Yi Liu > > rockchip header_v2 do not have a spl_hdr, so remove the verify. > > Signed-off-by: Yi Liu > Signed-off-by: Kever Yang Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] dm: fix function documentation in include/dm/ofnode.h

2022-04-06 Thread Tom Rini
On Thu, Mar 24, 2022 at 04:22:32PM +0100, Heinrich Schuchardt wrote: > We use Sphinx style comments to describe functions. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Bin Meng Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] tools: mkimage: Call verify_header after writing image to disk

2022-04-06 Thread Tom Rini
On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Rohár wrote: > If image backend provides verify_header callback then call it after writing > image to disk. This ensures that written image is correct. > > Signed-off-by: Pali Rohár > Reviewed-by: Stefan Roese > Reviewed-by: Simon Glass Applied

Re: [PATCH v2 2/3] power: pmic: Provide DM_PMIC support for tps65217 driver

2022-04-06 Thread Tom Rini
On Sat, Mar 12, 2022 at 08:11:11AM +0100, Lukasz Majewski wrote: > The tps65217 PMIC driver is used with am335x SoC based designs. > > It is used in the SPL (MLO) as well, so the DM conversion only is > for u-boot proper. > > This driver only allows simple reading/writing/dumping of the content

Re: [PATCH v2 1/3] power: Rename CONFIG_POWER_TPS65217 with CONFIG_PMIC_TPS65217

2022-04-06 Thread Tom Rini
On Sat, Mar 12, 2022 at 08:11:10AM +0100, Lukasz Majewski wrote: > Up till now the CONFIG_POWER_TPS65217 has been defined in several header > files for am335x SoC. > > This patch renames it to CONFIG_PMIC_TPS65217, which better reflects the > role of this IC circuit. > > Moreover, new

Re: [PATCH 0/6] introduce Arm FF-A support

2022-04-06 Thread Abdellatif El Khlifi
Hello guys, gentle ping, any thoughts about these changes ? On Tue, Mar 29, 2022 at 04:16:53PM +0100, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > This patchset adds support for Arm FF-A (Arm Firmware Framework for Armv8-A > v1.0). > > FF-A support is generic by design

Re: [PATCH] driver: gpio: fix gpio glitch for output-high gpio-hog

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 08:30:31AM -0700, Tim Harvey wrote: > On Wed, Apr 6, 2022 at 5:27 AM Tom Rini wrote: > > > > On Wed, Mar 02, 2022 at 06:01:08PM -0800, Tim Harvey wrote: > > > > > A gpio-hog can be specified as output-low, output-high, or input where > > > output-low means 'de-asserted'

Re: [PATCH] driver: gpio: fix gpio glitch for output-high gpio-hog

2022-04-06 Thread Tim Harvey
On Wed, Apr 6, 2022 at 5:27 AM Tom Rini wrote: > > On Wed, Mar 02, 2022 at 06:01:08PM -0800, Tim Harvey wrote: > > > A gpio-hog can be specified as output-low, output-high, or input where > > output-low means 'de-asserted' and 'output-high' means asserted vs > > voltage levels. > > > > When a hog

Re: [PATCH v4 09/12] rockchip: mmc: rockchip_dw_mmc: add rk3066/rk3188 support

2022-04-06 Thread Johan Jonker
Hi, On 4/6/22 16:50, Kever Yang wrote: > Hi Johan, > > On 2022/4/4 07:06, Johan Jonker wrote: >> The Rockchip SoCs rk3066/rk3188 have mmc DT nodes >> with as compatible string "rockchip,rk2928-dw-mshc". >> Add support to the existing driver with help of >> a DM_DRIVER_ALIAS. >> >> This type

[PATCH] dt-bindings: nvmem: u-boot, env: add Broadcom's variant binding

2022-04-06 Thread Rafał Miłecki
From: Rafał Miłecki Broadcom uses U-Boot for some of their recent platforms like BCM4908. They decided to use modified environment variables variables format though. Their header includes 2 extra 32 b fields at the beginning. The first field meaning is unknown, the second one stores length of

[PATCH] pci: Do not enable PCIe ASMedia ASM2824 workaround by default

2022-04-06 Thread Pali Rohár
PCIe ASMedia ASM2824 workaround code unconditionally increase size of all SPL binaries with PCIe support, even those which do not use ASMedia ASM2824 PCIe switch. Moreover this workaround is enabled for all existing hardware and also all future PCIe hardware, which opens a hole that other PCIe

Re: [PATCH 1/9] net: gmac_rockchip: Fix misuse of GENMASK macro

2022-04-06 Thread Kever Yang
Add David, Hi David,     Could you help to check this patch? Thanks, - Kever On 2022/3/16 23:39, Pierre-Clément Tosi wrote: Swap the arguments as that seems to have been the author's intention. Note: This fix wasn't tested on hardware and will result in more bits being set by the

Re: [PATCH v9 01/16] rockchip: rk3066-power: sync power domain dt-binding header from Linux

2022-04-06 Thread Kever Yang
On 2022/4/4 22:19, Johan Jonker wrote: In order to update the DT for rk3066 sync the power domain dt-binding header. This is the state as of v5.12 in Linux. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- include/dt-bindings/power/rk3066-power.h | 22

Re: [PATCH v4 12/12] rockchip: serial: Kconfig: add select SYS_NS16550 to config ROCKCHIP_SERIAL

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The Rockchip serial driver depends on an enabled NS16550 driver, so add select SYS_NS16550 to config ROCKCHIP_SERIAL. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever --- drivers/serial/Kconfig | 1 +

Re: [PATCH v4 11/12] rockchip: serial: move driver alias to serial_rockchip.c

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The Rockchip uart DT nodes have "snps,dw-apb-uart" as fall back string. The driver ns16550.c has CONFIG_IS_ENABLED(OF_REAL) as condition to of_match and does not copy dtplat data. For TPL/SPL the driver serial_rockchip.c is used. Move driver alias to

Re: [PATCH] doc: distro: Update list of all support boot types

2022-04-06 Thread Heinrich Schuchardt
On 4/6/22 11:35, Pali Rohár wrote: Signed-off-by: Pali Rohár --- doc/develop/distro.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/distro.rst b/doc/develop/distro.rst index c522be693498..5ac07912f7d1 100644 --- a/doc/develop/distro.rst +++

Re: [PATCH v4 10/12] rockchip: serial: restyle the serial_rockchip.c driver

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The ns16550.c driver has the following conditions for .of_match: CONFIG_IS_ENABLED(OF_REAL) For Rockchip SoCs with TPL/SPL and platform data that need serial support the serial_rockchip.c driver was made. It copies this data and then calls

Re: [PATCH v4 09/12] rockchip: mmc: rockchip_dw_mmc: add rk3066/rk3188 support

2022-04-06 Thread Kever Yang
Hi Johan, On 2022/4/4 07:06, Johan Jonker wrote: The Rockchip SoCs rk3066/rk3188 have mmc DT nodes with as compatible string "rockchip,rk2928-dw-mshc". Add support to the existing driver with help of a DM_DRIVER_ALIAS. This type needs a permanent enabled fifo. The other Rockchip SoCs not

Re: [PATCH v4 08/12] rockchip: mmc: rockchip_dw_mmc: fix ciu clock index

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The document rockchip-dw-mshc.yaml decribes a maximum of 4 clocks. In the rockchip_dw_mmc driver the clock name in use was "fixed" to "ciu" with index 1, but later reverted back to index 0. The clock drivers can handle both, but the calling driver should

Re: [PATCH v4 07/12] rockchip: timer: dw-apb-timer: fix whitespace in U_BOOT_DRIVER structure

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The line with .of_to_plat in the U_BOOT_DRIVER structure of dw-apb-timer.c is not aligned with the rest. Add an extra TAB to fix the whitespace. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH v4 06/12] rockchip: timer: add OF_PLATDATA support for dw-apb-timer

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The Rockchip rk3066 SoC has 3 dw-apb-timer nodes. U-boot is compiled with OF_PLATDATA TPL/SPL options, so add OF_PLATDATA support for the dw-apb-timer. Also change driver name to be able to compile with U-boot scripts. No reset OF_PLATDATA support was

Re: [PATCH v4 05/12] rockchip: tpl: use IS_ENABLED for timer_init() call condition

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: Not all Rockchip SoC models use the ARM arch timer. Call the function timer_init() only when CONFIG_SYS_ARCH_TIMER is available. Use the call condition IS_ENABLED to increase build coverage and make the code easier to read. Signed-off-by: Johan Jonker

Re: [PATCH v4 04/12] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: Not all Rockchip SoC models use the ARM arch timer. Call the function timer_init() only when CONFIG_SYS_ARCH_TIMER is available. Replace the ifdef call condition by IS_ENABLED to increase build coverage and make the code easier to read. The commit

[PATCH] Convert CONFIG_SYS_MEM_TOP_HIDE to Kconfig

2022-04-06 Thread Tom Rini
This converts the following to Kconfig: CONFIG_SYS_MEM_TOP_HIDE Signed-off-by: Tom Rini --- Kconfig | 11 +++ README | 21 - board/samsung/common/board.c| 4 ++-- common/board_f.c

[PATCH 2/2] nvmem: add driver handling U-Boot environment variables

2022-04-06 Thread Rafał Miłecki
From: Rafał Miłecki U-Boot stores its setup as environment variables. It's a list of key-value pairs stored on flash device with a custom header. This commit adds an NVMEM driver that: 1. Provides NVMEM access to environment vars binary data 2. Extracts variables as NVMEM cells It can be used

[PATCH 1/2] mtd: call of_platform_populate() for MTD partitions

2022-04-06 Thread Rafał Miłecki
From: Rafał Miłecki Until this change MTD subsystem supported handling partitions only with MTD partitions parsers. That's a specific / limited API designed around partitions. Some MTD partitions may however require different handling. They may contain specific data that needs to be parsed and

[PATCH u-boot-marvell v2 3/3] arm: mvebu: Enable CONFIG_SPL_SYS_NO_VECTOR_TABLE for 32-bit mvebu

2022-04-06 Thread Pali Rohár
U-Boot SPL is on 32-bit mvebu executed by the BootROM. And BootROM expects that U-Boot SPL returns execution back to the BootROM. Vectors during execution of U-Boot SPL should not be changed as BootROM does not expect it and uses its own vectors. So do not overwrite vectors in SPL build.

[PATCH u-boot-marvell v2 1/3] arm: Introduce new CONFIG_SPL_SYS_NO_VECTOR_TABLE option

2022-04-06 Thread Pali Rohár
Move OMAP4 specific option for disabling overwriting vector table into config option CONFIG_SPL_SYS_NO_VECTOR_TABLE. Signed-off-by: Pali Rohár --- arch/arm/Kconfig| 4 arch/arm/cpu/armv7/start.S | 4 +--- arch/arm/mach-omap2/Kconfig | 1 + 3 files changed, 6 insertions(+), 3

[PATCH u-boot-marvell v2 2/3] arm: Do not compile vector table when SYS_NO_VECTOR_TABLE is enabled

2022-04-06 Thread Pali Rohár
Vector table is not used when SYS_NO_VECTOR_TABLE is enabled. So do not compile it and reduce image size. Signed-off-by: Pali Rohár --- arch/arm/lib/vectors.S | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S index

Re: [PATCH 10/11] virtio: rng: Check length before copying

2022-04-06 Thread Pierre-Clément Tosi
Hi, On Thu, Mar 31, 2022 at 10:09:48AM +, Andrew Scull wrote: > Check the length of data written by the device is consistent with the > size of the buffers to avoid out-of-bounds memory accesses in case > values aren't consistent. > > Signed-off-by: Andrew Scull > Cc: Sughosh Ganu > --- >

Re: [PATCH v4 03/12] rockchip: tpl: change call condition rockchip_stimer_init()

2022-04-06 Thread Kever Yang
On 2022/4/4 07:06, Johan Jonker wrote: The Rockchip SoCs rk3066/rk3188 have no CONFIG_ROCKCHIP_STIMER_BASE defined. Currently only rk3188 has an exception. Make this more generic and call the function rockchip_stimer_init() only when CONFIG_ROCKCHIP_STIMER_BASE is available. Signed-off-by:

Re: [PATCH v4 02/12] rockchip: spl: change call condition rockchip_stimer_init()

2022-04-06 Thread Kever Yang
Hi Johan, On 2022/4/4 07:06, Johan Jonker wrote: The Rockchip SoCs rk3066/rk3188 have no CONFIG_ROCKCHIP_STIMER_BASE defined. Currently only rk3188 has an exception. Make this more generic and call the function rockchip_stimer_init() only when CONFIG_ROCKCHIP_STIMER_BASE is available.

Re: [PATCH v4 01/12] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig

2022-04-06 Thread Kever Yang
Hi Johan, On 2022/4/4 07:06, Johan Jonker wrote: Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker Reviewed-by: Kever Yang Thanks, - Kever --- Changed V4: rebase remove depends on rk3188/rk3066 must now disable ROCKCHIP_STIMER in defconfig with defconfig

Re: [PATCH u-boot-net v3 07/14] net: introduce helpers to get PHY interface mode from a device/ofnode

2022-04-06 Thread Patrice CHOTARD
Hi Marek On 3/29/22 22:08, Marek Behún wrote: > From: Marek Behún > > Add helpers ofnode_read_phy_mode() and dev_read_phy_mode() to parse the > "phy-mode" / "phy-connection-type" property. Add corresponding UT test. > > Use them treewide. > > This allows us to inline the

Re: [PATCH v1 6/6] arm: nuvoton: Add support for Nuvoton NPCM750 BMC

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 03:57:37PM +0800, Jim Liu wrote: > Add basic support for the Nuvoton NPCM750 BMC > > Signed-off-by: Jim Liu [snip] > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 4567c183fb..45ab2793b2 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -922,6

Re: [PATCH v1 1/6] ARM: configs: Add defconfig for Nuvoton NPCM750

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 03:57:32PM +0800, Jim Liu wrote: > Add defconfig for NPCM750 BUV (Poleg). > > Signed-off-by: Jim Liu > --- > board/nuvoton/poleg/MAINTAINERS | 7 + > configs/PolegRunBMC_defconfig | 50 + This defconfig was not made with "make

Re: [PATCH v1 2/6] ARM: dts: Add Nuvoton NPCM750 device tree

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 03:57:33PM +0800, Jim Liu wrote: > Add a common device tree for all Nuvoton NPCM7xx BMCs and a board > specific device tree for the NPCM750(Poleg) evaluation board. > > Signed-off-by: Jim Liu Have these been submitted to upstream Linux yet? And please note: > --- >

Re: [PATCH u-boot-net v3 14/14] net: phy: don't require PHY interface mode during PHY creation

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:45PM +0200, Marek Behún wrote: > From: Marek Behún > > Currently we require PHY interface mode to be known when > finding/creating the PHY - the functions > * phy_device_create() > * create_phy_by_mask() > * search_for_existing_phy() > *

Re: [RFC PATCH] RFC: Replace CONFIG_SYS_BAUDRATE_TABLE by board and UART driver rounding functions

2022-04-06 Thread Tom Rini
On Wed, Apr 06, 2022 at 03:30:11PM +0200, Pali Rohár wrote: > PING. Any progress in this direction? Any comments or objections in this > approach? I keep meaning to reply to this. I think this is the right direction, I'd just like to see it implemented for some other UARTs as well, and this

Re: [RFC PATCH] RFC: Replace CONFIG_SYS_BAUDRATE_TABLE by board and UART driver rounding functions

2022-04-06 Thread Pali Rohár
PING. Any progress in this direction? Any comments or objections in this approach? On Saturday 25 September 2021 16:23:13 Pali Rohár wrote: > On Saturday 25 September 2021 09:51:08 Tom Rini wrote: > > On Sat, Sep 25, 2021 at 02:19:58PM +0200, Pali Rohár wrote: > > > > > Add new functions which

Re: [PATCH] armv8: sec_firmware: drop unneeded ARMV8_SEC_FIRMWARE_SUPPORT check

2022-04-06 Thread Michael Walle
Am 2022-04-06 15:09, schrieb Tom Rini: On Fri, Nov 26, 2021 at 05:11:36PM +0100, Michael Walle wrote: This module will only be compiled if this symbol is set. Remove the useless check. While at it, invert the return code, to return 0 if the function succeeds. The only user of this function in

[PATCH] arm: mvebu: turris_omnia: Enable CONFIG_CMD_FUSE

2022-04-06 Thread Pali Rohár
This allows to read eFuse on Turris Omnia. Signed-off-by: Pali Rohár --- configs/turris_omnia_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig index d3c5c34b3b94..3daafe61785e 100644 ---

Re: [PATCH u-boot-net v3 09/14] treewide: Rename PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:40PM +0200, Marek Behún wrote: > From: Marek Behún > > Rename constant PHY_INTERFACE_MODE_NONE to PHY_INTERFACE_MODE_NA to make > it compatible with Linux' naming. > > Signed-off-by: Marek Behún > Reviewed-by: Stefan Roese > Reviewed-by: Ramon Fried > ---

Re: [PATCH u-boot-net v3 08/14] treewide: Rename PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:39PM +0200, Marek Behún wrote: > From: Marek Behún > > Rename constant PHY_INTERFACE_MODE_COUNT to PHY_INTERFACE_MODE_MAX to > make it compatible with Linux' naming. > > Signed-off-by: Marek Behún > Reviewed-by: Stefan Roese > --- Reviewed-by: Vladimir Oltean

[RESEND, RFC 4/8] config: yaml: j721e_evm: Add board config for J721E EVM

2022-04-06 Thread Neha Malcom Francis
Board config file must be provided in board/ti/ in YAML. These can then be consumed for generation of binaries to package system firmware. Added YAML config for J721E EVM in particular. It is to be noted that the bootflow followed by J721E requires tiboot3.bin, TIFS and board config binaries to

[PATCH] clk: imx8mp: Add ECSPI clocks

2022-04-06 Thread Elmar Albert
Add clock tables required for bing up ECSPI interfaces Signed-off-by: Elmar Albert Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: uboot-imx Signed-off-by: Elmar Albert --- drivers/clk/imx/clk-imx8mp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff

[PATCH] tools: kwboot: Replace fstat()+st_size by lseek()+SEEK_END

2022-04-06 Thread Pali Rohár
fstat()'s st_size works only for regular files. lseek() with SEEK_END works also for block or MTD devices. This replacement allows kwboot to load kwbimage from /dev/mtd0 for booting another device over /dev/ttyS0. Signed-off-by: Pali Rohár --- tools/kwboot.c | 19 +++ 1 file

Re: [PATCH u-boot-net v3 06/14] net: phy: fix parsing wrong property

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:37PM +0200, Marek Behún wrote: > From: Marek Behún > > The "phy-interface-type" property should be "phy-connection-type". > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean > drivers/net/phy/phy.c | 2 +- > 1 file

Re: [PATCH u-boot-net v3 05/14] treewide: use dm_mdio_read/write/reset() wrappers

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:36PM +0200, Marek Behún wrote: > From: Marek Behún > > Use the new dm_mdio_read/write/reset() wrappers treewide, instead of > always getting and dereferencing MDIO operations structure pointer. > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > ---

Re: [PATCH] imx: add i.MX8MN DDR3L evk board support

2022-04-06 Thread Marcel Ziswiler
Hi Heiko On Wed, 2022-04-06 at 14:08 +0200, Heiko Thiery wrote: > Add the support for the 8MNANOD3L-EVK board. The board has an i.MX8MNano > UltraLite Quad SoC and uses 1GB DDR3L memory. > > U-Boot 2022.04-00011-gf0e15e3761 (Apr 06 2022 - 13:54:41 +0200) > > CPU:   Freescale i.MX8MNano

Re: [PATCH u-boot-net v3 04/14] net: mdio-uclass: add wrappers for read/write/reset operations

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:35PM +0200, Marek Behún wrote: > From: Marek Behún > > Add wrappers dm_mdio_read(), dm_mdio_write() and dm_mdio_reset() for > DM MDIO's .read(), .write() and .reset() operations. > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > --- Reviewed-by:

Re: [PATCH u-boot-net v3 02/14] net: mdio-uclass: use ARRAY_SIZE()

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:33PM +0200, Marek Behún wrote: > From: Marek Behún > > Use the ARRAY_SIZE() macro instead of hardcoding sizes of arrays in > macros. > > Signed-off-by: Marek Behún > --- Reviewed-by: Vladimir Oltean > net/mdio-uclass.c | 11 +-- > 1 file changed, 5

Re: [PATCH 3/3] imx: power-domain: Get rid of SMCCC dependency

2022-04-06 Thread Marek Vasut
On 4/6/22 14:40, Adam Ford wrote: On Wed, Apr 6, 2022 at 7:27 AM Fabio Estevam wrote: Hi Adam, On Wed, Apr 6, 2022 at 9:22 AM Adam Ford wrote: I tried to build the imx8mq last night, but I ran into issues. I never built an imx8mq bootloader before, so I think I'm missing something. I'll

Re: [PATCH u-boot-net v3 01/14] net: mdio-uclass: fix type for phy_mode_str and phy_handle_str

2022-04-06 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 10:08:32PM +0200, Marek Behún wrote: > From: Marek Behún > > These global variables should both have type > static const char * const > > Signed-off-by: Marek Behún > Reviewed-by: Ramon Fried > --- Reviewed-by: Vladimir Oltean > net/mdio-uclass.c | 11 ++-

Re: [PATCH] armv8: sec_firmware: drop unneeded ARMV8_SEC_FIRMWARE_SUPPORT check

2022-04-06 Thread Tom Rini
On Fri, Nov 26, 2021 at 05:11:36PM +0100, Michael Walle wrote: > This module will only be compiled if this symbol is set. Remove the > useless check. While at it, invert the return code, to return 0 if the > function succeeds. The only user of this function in >

Re: [PATCH v1 2/2] mx6: ddr: Wait before issuing the first MRS cmd

2022-04-06 Thread Fabio Estevam
Hi Francesco, On Wed, Apr 6, 2022 at 8:53 AM Francesco Dolcini wrote: > > Wait 1ms before issuing the first MRS command to write DDR3 Mode > registers. > > There is a requirement to wait a minimum time before issuing command to > the DDR3 device, according to the JEDEC standard this time is

  1   2   >