RE: [EXT] Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-07 Thread Gaurav Jain
Hi Fabio > -Original Message- > From: Fabio Estevam > Sent: Wednesday, June 8, 2022 4:20 AM > To: Heiko Thiery > Cc: Stefan Roese ; U-Boot-Denx ; Gaurav > Jain ; dullf...@yahoo.com; Rasmus Villemoes > ; Schrempf Frieder > ; ZHIZHIKIN Andrey geosystems.com>; Horia Geanta ; Thomas

Re: [PATCH] watchdog: add amlogic watchdog support

2022-06-07 Thread Stefan Roese
On 07.06.22 15:28, Philippe Boos wrote: Add support for hardware watchdog timer for Amlogic SoCs. This driver has been heavily inspired by his Linux equivalent (meson_gxbb_wdt.c). Reviewed-by: Jerome Brunet Signed-off-by: Philippe Boos --- This watchdog driver has been tested on a GXL

Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-07 Thread Jincheng Wang
To be honest, I don't have experience Reference to the article " https://events19.linuxfoundation.org/wp-content/uploads/2018/07/may_be_maintainer-2.pdf; , I tried to do some work. 1. checkpatch (√) 2. no new compile warnings (√) 3. if bug fix, verify the bug is fixed (√) I tried some

Re: [PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-07 Thread Samuel Holland
On 6/7/22 7:06 PM, Andre Przywara wrote: > The Allwinner USB PHY driver is still using the legacy GPIO interface, > which is now implemented by the DM_GPIO compat functions. > Those seem to have some design flaws, as setting the direction, then > later setting the value will not work, if the

Re: [PATCH] armv8: always use current exception level for TCR_ELx access

2022-06-07 Thread Andre Przywara
On Tue, 7 Jun 2022 19:45:14 +0200 (CEST) Mark Kettenis wrote: > > From: Andre Przywara > > Date: Tue, 7 Jun 2022 15:08:34 +0100 > > > > Currently get_tcr() takes an "el" parameter, to select the proper > > version of the TCR_ELx system register. > > This is problematic in case of the Apple

Re: [BUG] keyboard doesn't work on Olimex teres-I notebook

2022-06-07 Thread Andre Przywara
On Tue, 19 Apr 2022 14:27:24 +0200 Milan P. Stanić wrote: Hi Milan, > [ Please CC to me, I'm not subscribed to mailing list ] > > Hi, > > On u-boot release 2022.04 keyboard doesn't work in u-boot on Olimex > TERES-I notebook. Thanks for the report, and sorry for the delay! > With git bisect

[PATCH] sunxi: usb: convert PHY GPIO functions to DM

2022-06-07 Thread Andre Przywara
The Allwinner USB PHY driver is still using the legacy GPIO interface, which is now implemented by the DM_GPIO compat functions. Those seem to have some design flaws, as setting the direction, then later setting the value will not work, if the DM_GPIO driver is implementing set_flags. Fix this by

[PATCH] usb: host: ehci-generic: Make resets and clocks optional

2022-06-07 Thread Andre Przywara
The generic EHCI binding does not *require* resets and clocks properties, and indeed for instance the Allwinner A20 SoCs does not need or define any resets in its DT. Don't easily give up if clk_get_bulk() or reset_get_bulk() return an error, but check if that is due to the DT simply having no

Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE

2022-06-07 Thread Marek Vasut
On 6/7/22 22:54, Alper Nebi Yasak wrote: On 07/06/2022 21:11, Marek Vasut wrote: On 6/7/22 19:26, Alper Nebi Yasak wrote: On 06/06/2022 17:07, Marek Vasut wrote: On 6/3/22 09:17, Peng Fan (OSS) wrote: From: Peng Fan i.MX8M use FIT image, not RAW image. And to support binman symbols,

Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-07 Thread Fabio Estevam
On Tue, Jun 7, 2022 at 2:27 PM Fabio Estevam wrote: > > Hi Heiko, > > On Tue, Jun 7, 2022 at 4:48 AM Heiko Thiery wrote: > > >> Thomas Schäfer sees this behavior also on an imx8mn NXP evk board. > >> Thus I added him to this thread. > > Thanks for the feedback. > > I managed to reproduce the

[PULL] u-boot-usb/master

2022-06-07 Thread Marek Vasut
The following changes since commit 8f527342db4160a1f030de6fe4a1591787cce65a: Prepare v2022.07-rc4 (2022-06-06 10:25:13 -0400) are available in the Git repository at: git://source.denx.de/u-boot-usb.git master for you to fetch changes up to 02544db9a7ffd352129f51c8987fc5a6e2b31a8b:

Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE

2022-06-07 Thread Alper Nebi Yasak
On 07/06/2022 21:11, Marek Vasut wrote: > On 6/7/22 19:26, Alper Nebi Yasak wrote: >> On 06/06/2022 17:07, Marek Vasut wrote: >>> On 6/3/22 09:17, Peng Fan (OSS) wrote: From: Peng Fan i.MX8M use FIT image, not RAW image. And to support binman symbols, u_boot_any could be

Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE

2022-06-07 Thread Marek Vasut
On 6/7/22 19:26, Alper Nebi Yasak wrote: On 06/06/2022 17:07, Marek Vasut wrote: On 6/3/22 09:17, Peng Fan (OSS) wrote: From: Peng Fan i.MX8M use FIT image, not RAW image. And to support binman symbols, u_boot_any could be optimized if RAW image is not selected, otherwise there will be build

Re: binman: Why is the first word the compressed size in compressed data

2022-06-07 Thread Alper Nebi Yasak
On 03/06/2022 18:07, Stefan Herbrechtsmeier wrote: > Am 02.06.2022 um 20:10 schrieb Alper Nebi Yasak: >> On 01/06/2022 11:29, Stefan Herbrechtsmeier wrote: >>> Hi Simon, >>> >>> I want to compress a FPGA Image on the fly via binman but this doesn't >>> work. I have add a bintool implementation for

Re: [PATCH] armv8: always use current exception level for TCR_ELx access

2022-06-07 Thread Mark Kettenis
> From: Andre Przywara > Date: Tue, 7 Jun 2022 15:08:34 +0100 > > Currently get_tcr() takes an "el" parameter, to select the proper > version of the TCR_ELx system register. > This is problematic in case of the Apple M1, since it runs with > HCR_EL2.E2H fixed to 1, so TCR_EL2 is actually using

Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-06-07 Thread Fabio Estevam
Hi Heiko, On Tue, Jun 7, 2022 at 4:48 AM Heiko Thiery wrote: >> Thomas Schäfer sees this behavior also on an imx8mn NXP evk board. >> Thus I added him to this thread. Thanks for the feedback. I managed to reproduce the problem on an imx8mm-evk board. On top of tree U-Boot I added: ---

Re: [PATCH 2/8] configs: imx8mm_data_modul_edm_sbc: not select SPL_RAM_DEVICE

2022-06-07 Thread Alper Nebi Yasak
On 06/06/2022 17:07, Marek Vasut wrote: > On 6/3/22 09:17, Peng Fan (OSS) wrote: >> From: Peng Fan >> >> i.MX8M use FIT image, not RAW image. And to support binman symbols, >> u_boot_any could be optimized if RAW image is not selected, otherwise >> there will be build failure. So not select

Re: [PATCH] serial: Replace CONFIG_DEBUG_UART_BASE by CONFIG_VAL(DEBUG_UART_BASE)

2022-06-07 Thread Tom Rini
On Fri, May 27, 2022 at 10:15:24PM +0200, Pali Rohár wrote: > CONFIG_VAL(DEBUG_UART_BASE) expands to CONFIG_DEBUG_UART_BASE or > CONFIG_SPL_DEBUG_UART_BASE or CONFIG_TPL_DEBUG_UART_BASE and allows boards > to set different values for SPL, TPL and U-Boot Proper. > > For ns16550 driver this

Re: [PATCH] qfw: Don't fail if setup data size is 0

2022-06-07 Thread Tom Rini
On Wed, May 25, 2022 at 02:38:55PM +0100, Pierre-Clément Tosi wrote: > Skip missing setup data (which is valid) rather than failing with an > error. > > Cc: Bin Meng > Cc: Simon Glass > Reported-by: Andrew Walbran > Signed-off-by: Pierre-Clément Tosi Applied to u-boot/next, thanks! --

Re: [PATCH] ubifs: Add missing dependency on GZIP

2022-06-07 Thread Tom Rini
On Mon, May 23, 2022 at 10:50:36PM +0200, Pali Rohár wrote: > GZIP option can be manually de-selected when UBIFS is enabled. This cause > following compile error because ubifs calls gzip functions. > > /tmp/ccxVrh2c.ltrans1.ltrans.o: in function `gzip_decompress.lto_priv.566': >

Re: [PATCH V2] include/configs: Remove rootwait=1 to all the affected boards

2022-06-07 Thread Tom Rini
On Sun, May 22, 2022 at 03:22:08PM +0200, Michael Trimarchi wrote: > rootwait=1 is not a valid kernel boot parameters. According > to the documenation is only rootwait > > rootwait [KNL] Wait (indefinitely) for root device to show up. > Useful for devices that are

Re: [PATCH] common/board_r.c: drop legacy and unused bi_enetaddr

2022-06-07 Thread Tom Rini
On Fri, May 20, 2022 at 01:19:08PM +0200, Rasmus Villemoes wrote: > The bi_enetaddr field in struct bd_info is write-only; nothing ever > reads back the value. > > Moreover, the value we write is more or less random, and certainly not > something one can rely on: If the board has a writable

Re: [PATCH] bootm: Fix Linux silent console on newer kernels

2022-06-07 Thread Tom Rini
On Thu, May 19, 2022 at 06:26:05PM -0400, Sean Anderson wrote: > Linux determines its console based on several sources: > > 1. the console command line parameter > 2. device tree (e.g. /chosen/stdout-path) > 3. various other board- and arch-specific sources > > If the console parameter

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2022-06-07 Thread Tom Rini
On Thu, May 19, 2022 at 05:48:30PM +0100, Pierre-Clément Tosi wrote: > Add a check for calloc() failing to allocate the requested memory. > > Make decode_regions() return an error code. > > Cc: Bin Meng > Cc: Simon Glass > Cc: Stefan Roese > Signed-off-by: Pierre-Clément Tosi >

Re: [PATCH] fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ

2022-06-07 Thread Tom Rini
On Thu, May 19, 2022 at 11:10:43AM +0200, Rasmus Villemoes wrote: > Asking if the alias we found actually points at the device tree node > we passed in (in the guise of its offset from blob) can be done simply > by asking if the fdt_path_offset() of the alias' path is identical to > offset. > >

Re: [PATCH] dm: core: convert of_machine_is_compatible to livetree

2022-06-07 Thread Tom Rini
On Tue, May 17, 2022 at 02:37:05PM +0200, Patrick Delaunay wrote: > Replace in the function of_machine_is_compatible(), the used API > fdt_node_check_compatible() by ofnode_device_is_compatible() > to support a live tree. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Patrice Chotard

Re: [PATCH] serial: smh: Fake tstc

2022-06-07 Thread Tom Rini
On Tue, May 17, 2022 at 01:55:07PM -0400, Sean Anderson wrote: > ARM semihosting provides no provisions for determining if there is > pending input. The only way to determine if there is console input is to > do a read (and block until the user types something). For this reason, > we always

Re: [PATCH v3 2/2] mkimage: Support signing 'auto' FITs

2022-06-07 Thread Tom Rini
On Mon, May 16, 2022 at 04:11:08PM -0400, Sean Anderson wrote: > This adds support for signing images in auto-generated FITs. To do this, > we need to add a signature node. The algorithm name property already has > its own option, but we need one for the key name hint. We could have > gone the -G

Re: [PATCH v3 1/2] mkimage: Document more misc options

2022-06-07 Thread Tom Rini
On Mon, May 16, 2022 at 04:11:07PM -0400, Sean Anderson wrote: > Document -G and the secondary image types which can be used with -R. > Also reword the documentation of -s for clarity. > > Signed-off-by: Sean Anderson Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 2/2] event: fix static events for CONFIG_NEEDS_MANUAL_RELOC

2022-06-07 Thread Tom Rini
On Sun, May 15, 2022 at 09:40:29PM +0300, Ovidiu Panait wrote: > Static events do not currently work post-relocation for boards that enable > CONFIG_NEEDS_MANUAL_RELOC. Relocate event handler pointers for all event > spies to fix this. > > Tested on Microblaze. > > Signed-off-by: Ovidiu Panait

Re: [PATCH 1/2] event: remove CONFIG_EVENT_DYNAMIC check in event_register()

2022-06-07 Thread Tom Rini
On Sun, May 15, 2022 at 09:40:28PM +0300, Ovidiu Panait wrote: > The whole event_register() function is wrapped in EVENT_DYNAMIC #ifdef > checks, so the inner check is not needed: > > #if CONFIG_IS_ENABLED(EVENT_DYNAMIC) > ... > int event_register(...) > { > ... > if

Re: [PATCH] mtd: mtdpart: Change size type from fdt_addr_t to fdt_size_t

2022-06-07 Thread Tom Rini
On Fri, May 13, 2022 at 10:24:51PM +0200, Pali Rohár wrote: > Set correct type for 3rd argument of ofnode_get_addr_size_index_notrans() > function. It expects fdt_size_t * and not fdt_addr_t *. > > When these two types do not have same size then U-Boot throw compile > warning: > >

Re: [PATCH] scripts: Introduce {quiet_,}cmd_bin2c

2022-06-07 Thread Tom Rini
On Wed, May 11, 2022 at 10:36:07AM +0100, Pierre-Clément Tosi wrote: > Add a make command to compile binary files as C data through bin2c with > > $(call,bin2c,) > > Note that this requires BUILD_BIN2C=y. > > Cc: Simon Glass > Signed-off-by: Pierre-Clément Tosi Applied to u-boot/next,

Re: [PATCH 1/1] fs/squashfs: fix sqfs_read_sblk()

2022-06-07 Thread Tom Rini
On Tue, May 10, 2022 at 09:53:25PM +0200, Heinrich Schuchardt wrote: > Setting sblk = NULL has no effect on the caller. > We want to set *sblk = NULL if an error occurrs to avoid usage after free. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH 1/1] btrfs: simplify lookup_data_extent()

2022-06-07 Thread Tom Rini
On Tue, May 10, 2022 at 09:43:38PM +0200, Heinrich Schuchardt wrote: > After returning if ret <= 0 we know that ret > 0. No need to check it. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Qu Wenruo > Reviewed-by: Anand Jain Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH] zlib: Port fix for CVE-2018-25032 to U-Boot

2022-06-07 Thread Tom Rini
On Tue, May 10, 2022 at 02:36:59PM -0400, Tom Rini wrote: > While our copy of zlib is missing upstream commit 263b1a05b04e ("Allow > deflatePrime() to insert bits in the middle of a stream.") we do have > Z_FIXED support, and so the majority of the code changes in 5c44459c3b28 > ("Fix a bug that

Re: [v2] misc: Correct Kconfig dependencies for a number of options

2022-06-07 Thread Tom Rini
On Tue, May 10, 2022 at 12:51:47PM -0400, Tom Rini wrote: > We have many cases of SPL (or TPL or VPL) drivers that don't depend on > SPL_MISC (and so on) but rather just MISC. > > Cc: Sean Anderson > Signed-off-by: Tom Rini > Reviewed-by: Sean Anderson Applied to u-boot/next, thanks! --

Re: [PATCH] doc: regulator: Add regulator-force-boot-off binding

2022-06-07 Thread Tom Rini
On Tue, May 10, 2022 at 09:58:28AM +1200, Chris Packham wrote: > The actual support was added in commit fec8c900c8b2 ("power: regulator: > Add support for regulator-force-boot-off"), update the docs to include > this. > > Signed-off-by: Chris Packham Applied to u-boot/next, thanks! -- Tom

Re: [PATCH] cmd: dm: migrate dm command to use U_BOOT_CMD_WITH_SUBCMDS()

2022-06-07 Thread Tom Rini
On Sun, May 08, 2022 at 01:01:42PM +0300, Ovidiu Panait wrote: > Migrate dm command to use U_BOOT_CMD_WITH_SUBCMDS() helper macro, to reduce > duplicated code. We can also drop the CONFIG_NEEDS_MANUAL_RELOC exception, > as the command list is updated post relocation in board_r.c initcall >

Re: [PATCH v2 1/1] dm: fix DM_EVENT dependencies

2022-06-07 Thread Tom Rini
On Sat, May 07, 2022 at 10:39:01PM +0200, Heinrich Schuchardt wrote: > CONFIG_DM_EVENT without CONFIG_EVENT is non-functional. > Let CONFIG_DM_EVENT depend on CONFIG_EVENT. > > Remove superfluous stub in include/event.h. > > Fixes: 5b896ed5856f ("event: Add events for device probe/remove") >

Re: [PATCH] boot: image-pre-load: drop unused CONFIG_SYS_BOOTM_LEN

2022-06-07 Thread Tom Rini
On Sat, May 07, 2022 at 09:23:05PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > CONFIG_SYS_BOOTM_LEN is not used in this file, drop it. > > Signed-off-by: Peng Fan > Reviewed-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] .gitignore: add files produced by b4

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 10:13:00AM +0200, Andrey Zhizhikin wrote: > b4 utility [1] is introduced by Linux Kernel developers and used to > fetch patches and patch series from lore.kernel.org and is proven > to be useful for U-Boot development. Detailed usage of the tool can be > read under post

Re: Please pull u-boot-watchdog/master

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 10:44:52AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the following watchdog related fix: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [GIT PULL] xilinx patches for v2022.07-rc4-v2

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 09:37:21AM +0200, Michal Simek wrote: > Hi Tom, > > please pull this one patch to your tree. I found one issue with some boards > that's why I would like to fix it in this release. > > Thanks, > Michal > > The following changes since commit

Re: BUG in u-boot for ODROID-XU3/XU4/HC1/HC2

2022-06-07 Thread Tom Rini
On Sat, May 28, 2022 at 03:10:51AM +0300, Gabriel Hojda wrote: > hi, > > i've recently tried u-boot 2022.04 (u-boot-v2022.04.tar.bz2) and my > odroid-hc2 didn't boot with uefi (default since Fedora 35) but worked when i > used exlinux.conf > > trying to track down the problem, i've found that

Re: Unpatched Critical Flaws Disclosed in U-Boot Bootloader for Embedded Devices

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 08:06:07PM +0800, Turritopsis Dohrnii Teo En Ming wrote: > Subject: Unpatched Critical Flaws Disclosed in U-Boot Bootloader for > Embedded Devices > > Good day from Singapore, > > I am sharing this news article for more awareness. > > Article: Unpatched Critical Flaws

Re: [PATCH] watchdog: add amlogic watchdog support

2022-06-07 Thread Neil Armstrong
On 07/06/2022 16:00, Neil Armstrong wrote: On 07/06/2022 15:28, Philippe Boos wrote: Add support for hardware watchdog timer for Amlogic SoCs. This driver has been heavily inspired by his Linux equivalent (meson_gxbb_wdt.c). Reviewed-by: Jerome Brunet Signed-off-by: Philippe Boos --- This

[PATCH] armv8: always use current exception level for TCR_ELx access

2022-06-07 Thread Andre Przywara
Currently get_tcr() takes an "el" parameter, to select the proper version of the TCR_ELx system register. This is problematic in case of the Apple M1, since it runs with HCR_EL2.E2H fixed to 1, so TCR_EL2 is actually using the TCR_EL1 layout, and we get the wrong version. For U-Boot's purposes

Re: [PATCH] watchdog: add amlogic watchdog support

2022-06-07 Thread Neil Armstrong
On 07/06/2022 15:28, Philippe Boos wrote: Add support for hardware watchdog timer for Amlogic SoCs. This driver has been heavily inspired by his Linux equivalent (meson_gxbb_wdt.c). Reviewed-by: Jerome Brunet Signed-off-by: Philippe Boos --- This watchdog driver has been tested on a GXL

Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 06:00:38PM +0800, Jincheng Wang wrote: > It works well, thanks for your work. Can you please provide a Tested-by? Thanks! > > > Miquel Raynal 于2022年6月3日周五 23:26写道: > > > > Following Jincheng's report, an out-of-band write leading to arbitrary > > code execution is

[PATCH] watchdog: add amlogic watchdog support

2022-06-07 Thread Philippe Boos
Add support for hardware watchdog timer for Amlogic SoCs. This driver has been heavily inspired by his Linux equivalent (meson_gxbb_wdt.c). Reviewed-by: Jerome Brunet Signed-off-by: Philippe Boos --- This watchdog driver has been tested on a GXL libretech-cc board and also on a custom G12a

Unpatched Critical Flaws Disclosed in U-Boot Bootloader for Embedded Devices

2022-06-07 Thread Turritopsis Dohrnii Teo En Ming
Subject: Unpatched Critical Flaws Disclosed in U-Boot Bootloader for Embedded Devices Good day from Singapore, I am sharing this news article for more awareness. Article: Unpatched Critical Flaws Disclosed in U-Boot Bootloader for Embedded Devices Link:

Re: [PATCH v9 05/13] fpga: add fpga_compatible2flag

2022-06-07 Thread Oleksandr Suvorov
On Tue, Jun 7, 2022 at 3:11 PM Michal Simek wrote: > > > > On 6/1/22 10:46, Oleksandr Suvorov wrote: > > Add a "compatible" string to binary flag converter, which uses > > a callback str2flag() of given FPGA driver if available. > > > > Signed-off-by: Oleksandr Suvorov > > --- > > > > (no

Re: [PATCH v9 00/13] fpga: zynqmp: Adding support of loading authenticated images

2022-06-07 Thread Oleksandr Suvorov
Hi Adrian, On Tue, Jun 7, 2022 at 4:01 PM Adrian Fiergolski wrote: > > Oleksandr, > > yes, I will try to find some time slot to test them. However, don't you > want to first implement Michael's suggestions, so I test the final version? Sure, no problem, Adrian. > > Regards, > Adrian > > On

Re: [PATCH v9 03/13] fpga: xilinx: add bitstream flags to driver desc

2022-06-07 Thread Oleksandr Suvorov
Hi Michal, On Tue, Jun 7, 2022 at 3:47 PM Michal Simek wrote: > > Hi, > > On 6/7/22 13:37, Oleksandr Suvorov wrote: > > Hi Michal, > > > > On Tue, Jun 7, 2022 at 2:32 PM Michal Simek wrote: > >> > >> > >> > >> On 6/1/22 10:46, Oleksandr Suvorov wrote: > >>> Store a set of supported bitstream

Re: [PATCH] armv8: Fix TCR 64-bit writes

2022-06-07 Thread Andre Przywara
On Mon, 6 Jun 2022 23:00:08 +0200 (CEST) Mark Kettenis wrote: Hi Mark, > > From: Andre Przywara > > Date: Mon, 9 May 2022 17:08:49 +0100 > > > > The AArch64 TCR_ELx register is a 64-bit register, and many newer > > architecture features use bits in the upper half. So far U-Boot was > >

Re: [PATCH v9 00/13] fpga: zynqmp: Adding support of loading authenticated images

2022-06-07 Thread Adrian Fiergolski
Oleksandr, yes, I will try to find some time slot to test them. However, don't you want to first implement Michael's suggestions, so I test the final version? Regards, Adrian On 02.06.2022 17:11, Oleksandr Suvorov wrote: Adrian, I don't have access to the ZynqMP hardware for now, so could

Re: [PATCH v9 03/13] fpga: xilinx: add bitstream flags to driver desc

2022-06-07 Thread Michal Simek
Hi, On 6/7/22 13:37, Oleksandr Suvorov wrote: Hi Michal, On Tue, Jun 7, 2022 at 2:32 PM Michal Simek wrote: On 6/1/22 10:46, Oleksandr Suvorov wrote: Store a set of supported bitstream types in xilinx_desc structure. It will be used to determine whether an FPGA image is able to be loaded

Re: [PATCH v9 12/13] fpga: zynqmp: support loading authenticated images

2022-06-07 Thread Michal Simek
On 6/1/22 10:46, Oleksandr Suvorov wrote: Add supporting new compatible string "u-boot,zynqmp-fpga-ddrauth" to handle loading authenticated images (DDR). Based on solution by Jorge Ramirez-Ortiz Signed-off-by: Oleksandr Suvorov --- (no changes since v1) boot/Kconfig

Re: [ANN] U-Boot v2022.07-rc4 released

2022-06-07 Thread Tom Rini
On Tue, Jun 07, 2022 at 11:11:20AM +0200, Christian Gmeiner wrote: > Am Mo., 6. Juni 2022 um 16:26 Uhr schrieb Tom Rini : > > > > Hey all, > > > > It's release day and so here's v2022.07-rc4. There were a few more > > fixes that I had seen that were either regressions or minor and > > seemingly

Re: [PATCH v9 08/13] spl: fit: pass real compatible flags to fpga_load()

2022-06-07 Thread Michal Simek
On 6/1/22 10:46, Oleksandr Suvorov wrote: Convert taken FPGA image "compatible" string to a binary compatible flag and pass it to an FPGA driver. Signed-off-by: Oleksandr Suvorov --- (no changes since v1) common/spl/spl_fit.c | 10 +++--- 1 file changed, 7 insertions(+), 3

Re: [PATCH v9 05/13] fpga: add fpga_compatible2flag

2022-06-07 Thread Michal Simek
On 6/1/22 10:46, Oleksandr Suvorov wrote: Add a "compatible" string to binary flag converter, which uses a callback str2flag() of given FPGA driver if available. Signed-off-by: Oleksandr Suvorov --- (no changes since v1) drivers/fpga/fpga.c | 26 ++

Re: [PATCH v9 03/13] fpga: xilinx: add bitstream flags to driver desc

2022-06-07 Thread Michal Simek
On 6/1/22 10:46, Oleksandr Suvorov wrote: Store a set of supported bitstream types in xilinx_desc structure. It will be used to determine whether an FPGA image is able to be loaded with a given driver. Signed-off-by: Oleksandr Suvorov --- (no changes since v1) include/versalpl.h | 2 +-

Re: [PATCH v9 03/13] fpga: xilinx: add bitstream flags to driver desc

2022-06-07 Thread Oleksandr Suvorov
Hi Michal, On Tue, Jun 7, 2022 at 2:32 PM Michal Simek wrote: > > > > On 6/1/22 10:46, Oleksandr Suvorov wrote: > > Store a set of supported bitstream types in xilinx_desc structure. > > It will be used to determine whether an FPGA image is able to be > > loaded with a given driver. > > > >

Re: [PATCH v9 03/13] fpga: xilinx: add bitstream flags to driver desc

2022-06-07 Thread Michal Simek
On 6/1/22 10:46, Oleksandr Suvorov wrote: Store a set of supported bitstream types in xilinx_desc structure. It will be used to determine whether an FPGA image is able to be loaded with a given driver. Signed-off-by: Oleksandr Suvorov --- (no changes since v1) include/versalpl.h | 2 +-

Re: [PATCH 1/2] drivers: tee: optee: discover OP-TEE services

2022-06-07 Thread Ilias Apalodimas
Hi Etienne, [...] > > > + > > > +#ifndef CONFIG_OPTEE_SERVICE_DISCOVERY > > > /* > > >* in U-Boot, the discovery of TA on the TEE bus is not supported: > > >* only bind the drivers associated to the supported OP-TEE TA > > >*/ > > > if

[PATCH v3 2/3] drivers: tee: optee: discover OP-TEE services

2022-06-07 Thread Etienne Carriere
This change defines resources for OP-TEE service drivers to register themselves for being bound to when OP-TEE firmware reports the related service is supported. OP-TEE services are discovered during optee driver probe sequence which mandates optee driver is always probe once bound. Discovery of

[PATCH v3 3/3] drivers: rng: optee_rng: register to CONFIG_OPTEE_SERVICE_DISCOVERY

2022-06-07 Thread Etienne Carriere
Changes optee_rng driver to register itself has a OP-TEE service so that a device is bound for the driver when OP-TEE enumerates the PTA RNG service. Cc: Sughosh Ganu Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- No change since v2. No change since v1. --- drivers/rng/Kconfig

[PATCH v3 1/3] drivers: tee: optee: remove unused probe local variable

2022-06-07 Thread Etienne Carriere
Removes local variable child in optee_probe() that is not used. Cc: Patrick Delaunay Signed-off-by: Etienne Carriere --- No change since v2. New change not in v1 series. --- drivers/tee/optee/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tee/optee/core.c

Re: [PATCH] fs/squashfs: sqfs_read: Prevent arbitrary code execution

2022-06-07 Thread Jincheng Wang
It works well, thanks for your work. Miquel Raynal 于2022年6月3日周五 23:26写道: > > Following Jincheng's report, an out-of-band write leading to arbitrary > code execution is possible because on one side the squashfs logic > accepts directory names up to 65535 bytes (u16), while U-Boot fs logic >

Re: [PATCH v2 01/14] cmd: cpu: migrate cpu command to U_BOOT_CMD_WITH_SUBCMDS()

2022-06-07 Thread Ovidiu Panait
that fixes the pointers after relocation (the cpu driver makes use of the events feature)? Without this, in my testing the event handlers are not called at all after relocation: https://lore.kernel.org/u-boot/20220515184029.2169025-2-ovpan...@gmail.com/ It seems it is not currently applied to the 2022

Re: [PATCH 1/2] drivers: tee: optee: discover OP-TEE services

2022-06-07 Thread Etienne Carriere
Hi Ilias, On Mon, 6 Jun 2022 at 11:49, Ilias Apalodimas wrote: > > Hi Etienne, > > On Wed, Jun 01, 2022 at 10:27:51AM +0200, Etienne Carriere wrote: > > This change defines resources for OP-TEE service drivers to register > > themselves for being bound to when OP-TEE firmware reports the related

Re: [ANN] U-Boot v2022.07-rc4 released

2022-06-07 Thread Christian Gmeiner
Am Mo., 6. Juni 2022 um 16:26 Uhr schrieb Tom Rini : > > Hey all, > > It's release day and so here's v2022.07-rc4. There were a few more > fixes that I had seen that were either regressions or minor and > seemingly safe fixes that I've pulled them in. If there are any bug > fixes people are

Re: [PATCH v3 0/3] usb: add isp1760 hcd support

2022-06-07 Thread Rui Miguel Silva
Hi all, On Wed, May 25, 2022 at 02:22:48PM +0100, Rui Miguel Silva wrote: > Add support for the usb isp1760 host controller family, which > for example is present in MPS3 FPGA board from Arm (isp1763). > > First we move some helper functions and defines to a more > common place to be shared by

Re: [PATCH 7/8] tpm: Implement state command for Cr50

2022-06-07 Thread Ilias Apalodimas
On Mon, Feb 28, 2022 at 05:11:24PM -0700, Simon Glass wrote: > Add a vendor-specific TPM2 command for this and implement it for Cr50. > > Signed-off-by: Simon Glass > --- > > drivers/tpm/cr50_i2c.c | 117 + > include/tpm-v2.h | 54

Re: [PATCH 5/8] tpm: sandbox: Allow init of TPM in a different phase

2022-06-07 Thread Ilias Apalodimas
Hi Simon, On Mon, Feb 28, 2022 at 05:11:22PM -0700, Simon Glass wrote: > At present the emulator assumes that the TPM is inited in the same phase > where it is used. But in fact SPL may init the TPM, so we don't want to > complain when U-Boot proper later uses it. Remove this check. > > It

Re: [PATCH 4/8] tpm: Correct the define-space command in TPMv2

2022-06-07 Thread Ilias Apalodimas
Hi Simon, Thanks for fixing this. On Mon, Feb 28, 2022 at 05:11:21PM -0700, Simon Glass wrote: > The message format is incorrect. Fix it. > > Signed-off-by: Simon Glass > --- > > lib/tpm-v2.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git

Please pull u-boot-watchdog/master

2022-06-07 Thread Stefan Roese
Hi Tom, please pull the following watchdog related fix: - Fix SPL build with watchdog disabled in asm files (Pali) Here the Azure build, without any issues:

Re: [PATCH 3/8] tpm: Correct the permissions command in TPMv1

2022-06-07 Thread Ilias Apalodimas
Hi Simon, On Mon, Feb 28, 2022 at 05:11:20PM -0700, Simon Glass wrote: > The offset here is incorrect. Fix it. > > Signed-off-by: Simon Glass > --- > > lib/tpm-v1.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/tpm-v1.c b/lib/tpm-v1.c > index

Re: [PATCH] watchdog: Fix SPL build with watchdog disabled in asm files

2022-06-07 Thread Stefan Roese
On 04.06.22 15:06, Pali Rohár wrote: PING? On Thursday 28 April 2022 13:33:09 Pali Rohár wrote: Allow to compile assembler files in SPL build which calls WATCHDOG_RESET function when watchdog is disabled in SPL and enabled in U-Boot proper. This issue was fixed in past by commit 7fbd42f5afc4

Re: [PATCH 2/8] tpm: Require a digest source when extending the PCR

2022-06-07 Thread Ilias Apalodimas
On Mon, Feb 28, 2022 at 05:11:19PM -0700, Simon Glass wrote: > This feature is used for measured boot. It is not currently supported in > the TPM drivers, but add it to the API so that code which expects it can > signal its request. > > Signed-off-by: Simon Glass > --- > > cmd/tpm-v1.c |

Re: [PATCH v2 10/14] microblaze: cache: introduce cpuinfo structure

2022-06-07 Thread Michal Simek
út 31. 5. 2022 v 20:15 odesílatel Ovidiu Panait napsal: > > Introduce a minimal cpuinfo structure to hold cache related info. The > instruction/data cache size and cache line size are initialized early in > the boot to default Kconfig values. They will be overwritten with data > from PVR/dtb if

[PATCH v1] misc: nuvoton: Add host interface configuartion driver

2022-06-07 Thread Jim Liu
add nuvoton BMC npcm750 host configuartion driver Signed-off-by: Jim Liu --- drivers/misc/Makefile | 1 + drivers/misc/npcm_host_intf.c | 110 ++ 2 files changed, 111 insertions(+) create mode 100644 drivers/misc/npcm_host_intf.c diff --git

[PATCH v1] misc: nuvoton: Add NPCM7xx otp controller driver

2022-06-07 Thread Jim Liu
Add Nuvoton BMC npcm750 otp driver Signed-off-by: Jim Liu --- arch/arm/include/asm/arch-npcm7xx/otp.h | 90 + drivers/misc/Kconfig| 9 + drivers/misc/Makefile | 1 + drivers/misc/npcm_otp.c | 512 4 files

Re: [PATCH v2 01/14] cmd: cpu: migrate cpu command to U_BOOT_CMD_WITH_SUBCMDS()

2022-06-07 Thread Michal Simek
út 31. 5. 2022 v 20:14 odesílatel Ovidiu Panait napsal: > > Migrate cpu command to use U_BOOT_CMD_WITH_SUBCMDS() helper macro, to > reduce duplicated code. This also fixes the cpu command on boards that > enable CONFIG_NEEDS_MANUAL_RELOC. > > Signed-off-by: Ovidiu Panait > --- > NOTE: this

[PATCH v1 2/2] crypto: nuvoton: Add NPCM7xx SHA driver

2022-06-07 Thread Jim Liu
add nuvoton BMC npcm750 SHA driver Signed-off-by: Jim Liu --- drivers/crypto/nuvoton/Kconfig| 6 + drivers/crypto/nuvoton/Makefile | 1 + drivers/crypto/nuvoton/npcm_sha.c | 897 ++ 3 files changed, 904 insertions(+) create mode 100644

[PATCH v1 1/2] crypto: nuvoton: Add NPCM7xx AES driver

2022-06-07 Thread Jim Liu
add nuvoton BMC npcm750 AES driver Signed-off-by: Jim Liu --- arch/arm/include/asm/arch-npcm7xx/aes.h | 53 + drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile | 1 + drivers/crypto/nuvoton/Kconfig | 8 + drivers/crypto/nuvoton/Makefile

[PATCH v1 0/2] add npcm750 AES/SHA driver

2022-06-07 Thread Jim Liu
Nuvoton BMC npcm750 have AES HW engine and SHA HW engine Jim Liu (2): crypto: nuvoton: Add NPCM7xx AES driver crypto: nuvoton: Add NPCM7xx SHA driver arch/arm/include/asm/arch-npcm7xx/aes.h | 53 ++ drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile |

Re: [PATCH 1/8] tpm: Export the TPM-version functions

2022-06-07 Thread Ilias Apalodimas
Hi Simon, Apologies the late reply. I wasn't cc'ed on those and missed them in my mailbox. On Mon, Feb 28, 2022 at 05:11:18PM -0700, Simon Glass wrote: > These functions should really be available outside the TPM code, so that > other callers can find out which version the TPM is. Rename them

Re: [PATCH 0/6] Add video damage tracking

2022-06-07 Thread Heinrich Schuchardt
On 6/7/22 01:43, Alexander Graf wrote: This patch set speeds up graphics output on ARM by a factor of 60x. On most ARM SBCs, we keep the frame buffer in DRAM and map it as cached, but need it accessible by the display controller which reads directly from a later point of consistency. Hence, we

[PATCH v2 18/23] microblaze: Create SYM_ADDR macro to deal with symbols

2022-06-07 Thread Michal Simek
Symbol handling depends on compilation flags. Right now manual relocation is used that's why symbols can be referenced just by name and there is no need to find them out. But when position independent code (PIC) is used symbols need to be described differently. That's why having one macro change

[PATCH v2 20/23] tools: relocate-rela: Check that relocation works only for EM_AARCH64

2022-06-07 Thread Michal Simek
Relocation support is only for EM_AARCH64 that's why check machine type to make sure that the code will never run on any unsupported one. Signed-off-by: Michal Simek --- (no changes since v1) tools/relocate-rela.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/relocate-rela.c

[PATCH v2 19/23] tools: relocate-rela: Extract elf64 reloc to special function

2022-06-07 Thread Michal Simek
Adding support for new type requires to change code layout that's why move elf64 code to own function for easier maintenance. It also solves the problem with not calling fclose in case of error. Return value from rela_elf64 is saved to variable that's why fclose() is called all the time.

[PATCH v2 22/23] tools: relocate-rela: Add support for 32bit Microblaze relocation

2022-06-07 Thread Michal Simek
Microblaze is 32bit that's why it is using elf32 format. Relocation code requires to get information about rela and dynsym senctions and also text base which was used for compilation. Code build with -fPIC and linked with -pic generates 4 relocation types. R_MICROBLAZE_NONE is the easiest one

[PATCH v2 21/23] tools: relocate-rela: Add support for elf32 decoding

2022-06-07 Thread Michal Simek
Add support for 32bit ELF format which is used by Microblaze. Also check that code runs only for Microblaze. Function finds information about rela.dyn and dynsym which will be used later for relocation. Signed-off-by: Michal Simek --- (no changes since v1) tools/relocate-rela.c | 141

[PATCH v2 12/23] microblaze: Separate code end substraction

2022-06-07 Thread Michal Simek
Follow up patch will convert symbol handling that's why it is necessary to separate logic around symbols to special instruction. It adds 4B for new instruction but it is worth to do it to have code ready for for full relocation. Signed-off-by: Michal Simek --- (no changes since v1)

Re: [PATCH v2] xilinx: zynqmp: Do not use 0 as spl bss start address

2022-06-07 Thread Michal Simek
út 7. 6. 2022 v 9:44 odesílatel Stefan Herbrechtsmeier napsal: > > From: Stefan Herbrechtsmeier > > Do not use 0 as address for memory because of the special meaning for > pointers (null pointer). Change the spl bss start address to the second > page. > > Signed-off-by: Stefan Herbrechtsmeier >

[PATCH] .gitignore: add files produced by b4

2022-06-07 Thread Andrey Zhizhikin
b4 utility [1] is introduced by Linux Kernel developers and used to fetch patches and patch series from lore.kernel.org and is proven to be useful for U-Boot development. Detailed usage of the tool can be read under post from the original author [2]. This tool fetches files from the list and

[PATCH v2 23/23] microblaze: Add support for run time relocation

2022-06-07 Thread Michal Simek
Microblaze is using NEEDS_MANUAL_RELOC from the beginnging. This is causing issues with function pointer arrays which need to be updated manually after relocation. Building code with -fPIC and linking with -pic will remove this limitation and there is no longer need to run manual update. By

[PATCH v2 16/23] microblaze: Remove _start symbol handling at U-Boot start

2022-06-07 Thread Michal Simek
Right now U-Boot runs all the time from the same address where it is loaded but going to full relocation code starting address doesn't need to be fixed and can be simply discovered from reading PC register. That's why use r20 to get PC address and subtract offset from the beginning to get starting

  1   2   >