Re: [PATCH v3 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

2023-05-06 Thread Jagan Teki
On Thu, 27 Apr 2023 at 13:05, Eugen Hristev wrote: > > From: Joseph Chen > > Add the node for PCIe 2x1l 2 device together with the corresponding > combphy. > > Signed-off-by: Joseph Chen > [eugen.hris...@collabora.com: moved to -u-boot.dtsi, minor > adaptations] > Signed-off-by: Eugen Hristev

[PATCH 5/5] rockchip: rockpro64: Build u-boot-rockchip-spi.bin

2023-05-06 Thread Jonas Karlman
Enable CONFIG_ROCKCHIP_SPI_IMAGE to build u-boot-rockchip-spi.bin. Define CONFIG_SYS_SPI_U_BOOT_OFFS to write u-boot.itb at the expected offset. Enable CONFIG_LTO to reduce size of SPL so that the mkimage output fit before the 0x6 offset in u-boot-rockchip-spi.bin. => sf probe SF:

[PATCH 4/5] rockchip: rock-pi-4: Use SDMA to boost eMMC performance

2023-05-06 Thread Jonas Karlman
Enable the use of SDMA mode to boost eMMC performance on ROCK Pi 4. Also add missing flags to indicate the supported MMC modes. Using mmc read command to read 32 MiB data shows following improvement: => time mmc read 1000 2000 1 Before: time: 3.178 seconds After: time: 0.402 seconds

[PATCH 3/5] rockchip: rockpro64: Use SDMA to boost eMMC performance

2023-05-06 Thread Jonas Karlman
Enable the use of SDMA mode to boost eMMC performance on RockPro64. Also add missing flags to indicate the supported MMC modes. Using mmc read command to read 32 MiB data shows following improvement: => time mmc read 1000 2000 1 Before: time: 3.178 seconds After: time: 0.402 seconds

[PATCH 2/5] mmc: rockchip_sdhci: Disable DMA mode using a device tree property

2023-05-06 Thread Jonas Karlman
Loading part of TF-A into SRAM from eMMC using DMA fails on RK3399 similar to other Rockchip SoCs. Checksum validation fails with: ## Checking hash(es) for Image atf-2 ... sha256 error! Bad hash value for 'hash' hash node in 'atf-2' image node spl_load_simple_fit: can't load image loadables

[PATCH 1/5] mmc: rockchip_sdhci: Skip blocks read workaround on RK3399

2023-05-06 Thread Jonas Karlman
The workaround to limit number of blocks to read in a single command should only be applied to RK3568 and RK3588. Change to be more strict when to apply the workaround. Fixes: 2cc6cde647e2 ("mmc: rockchip_sdhci: Limit number of blocks read in a single command") Suggested-by: Simon Glass

[PATCH 0/5] rockchip: Fix eMMC performance regression

2023-05-06 Thread Jonas Karlman
The eMMC performance on RK3399 was reduced sigificant by the commit 2cc6cde647e2 ("mmc: rockchip_sdhci: Limit number of blocks read in a single command"). That workaround should only have been applied to RK3568 and RK3588. This series fixes that and also help boost eMMC performance on two RK3399

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Jonas Karlman
On 2023-05-06 18:24, Jonas Karlman wrote: > On 2023-05-06 18:00, Tom Rini wrote: >> On Sat, May 06, 2023 at 03:59:57PM +, Jonas Karlman wrote: >>> Hi Simon, >>> >>> On 2023-05-06 04:03, Simon Glass wrote: This causes crashes on some boards, e.g. rockpro64. In any case, we should not

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Jonas Karlman
On 2023-05-06 18:00, Tom Rini wrote: > On Sat, May 06, 2023 at 03:59:57PM +, Jonas Karlman wrote: >> Hi Simon, >> >> On 2023-05-06 04:03, Simon Glass wrote: >>> This causes crashes on some boards, e.g. rockpro64. In any case, we >>> should not do it. >>> >>> Check the usb_started flag to avoid

[PATCH] power: imx8m-power-domain: Add delay to align with kernel driver

2023-05-06 Thread Fabio Estevam
From: Fabio Estevam In the imx8m power domain kernel driver, there is an extra udelay(5) prior to requesting the domain to power up: https://github.com/torvalds/linux/blob/v6.3/drivers/soc/imx/gpcv2.c#L347-L375 Haven't observed any issues due to the lack of this delay in U-Boot yet, but better

Re: [PATCH 3/3] bootstd: Require HUSH_PARSER for script booting

2023-05-06 Thread Jonas Karlman
Hi Simon, On 2023-05-06 04:03, Simon Glass wrote: > Armbian uses a script which needs the HUSH parser. It is likely that > other distros will do the same. Enable it by default, just in case. > > Signed-off-by: Simon Glass > --- > > boot/Kconfig | 1 + > 1 file changed, 1 insertion(+) > With

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Tom Rini
On Sat, May 06, 2023 at 03:59:57PM +, Jonas Karlman wrote: > Hi Simon, > > On 2023-05-06 04:03, Simon Glass wrote: > > This causes crashes on some boards, e.g. rockpro64. In any case, we > > should not do it. > > > > Check the usb_started flag to avoid this. > > > > Signed-off-by: Simon

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Tom Rini
On Fri, May 05, 2023 at 08:03:04PM -0600, Simon Glass wrote: > This causes crashes on some boards, e.g. rockpro64. In any case, we > should not do it. > > Check the usb_started flag to avoid this. > > Signed-off-by: Simon Glass Tested-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [PATCH 2/3] bootstd: usb: Avoid initing USB twice

2023-05-06 Thread Jonas Karlman
Hi Simon, On 2023-05-06 04:03, Simon Glass wrote: > This causes crashes on some boards, e.g. rockpro64. In any case, we > should not do it. > > Check the usb_started flag to avoid this. > > Signed-off-by: Simon Glass > --- > > drivers/usb/host/usb_bootdev.c | 3 +++ > test/boot/bootdev.c

Re: [RFC] power: imx8m-power-domain: Add delay to align with kernel driver

2023-05-06 Thread Marek Vasut
On 4/28/23 21:52, Fabio Estevam wrote: From: Fabio Estevam In the imx8m power domain kernel driver, there is an extra udelay(5) prior to requesting the domain to power up: https://github.com/torvalds/linux/blob/v6.3/drivers/soc/imx/gpcv2.c#L347-L375 Haven't observed any issues due to the

Re: [PATCH 1/3] usb: Tidy up the usb_start flag

2023-05-06 Thread Marek Vasut
On 5/6/23 04:03, Simon Glass wrote: This should be declared in a header file so that type-checking works correctly. Add a single declaration to usb.h and remove the others. Signed-off-by: Simon Glass Reviewed-by: Marek Vasut

[PATCH 3/3] doc: boards: amlogic: add documentation for KII Pro

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi Add build instructions for the KII Pro set-top box. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + doc/board/amlogic/index.rst | 1 + doc/board/amlogic/videostrong-kii-pro.rst | 112 ++ 3 files

[PATCH 2/3] boards: amlogic: add KII Pro defconfig

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi Add configurations for the Videostrong KII Pro set-top box. This defconfig is cloned from the WeTek Play2's. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + configs/videostrong-kii-pro_defconfig | 70 +++ 2 files

[PATCH 1/3] arm: dts: add support for Videostrong KII Pro

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi Import the device tree from mainline linux (v6.4-rc1) and add the old PHY reset bindings in the PHY node, else U-Boot and linux won't be able to use the PHY. Signed-off-by: Ferass El Hafidi --- arch/arm/dts/Makefile | 1 +

[PATCH 0/3] initial support for the Videostrong KII Pro

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi The Videostrong KII Pro is a set-top box based on the Amlogic p201 reference board and with the following specification: - Amlogic S905 ARM Cortex-A53 quad-core SoC @ 1.5GHz - ARM Mali 450 GPU - 2GB DDR3 SDRAM - 16GB eMMC - Gigabit Ethernet - Boardcom BCM4335 WiFi

Re: [PATCH v2 1/3] net: support being a TCP server to unblock TCP fastboot

2023-05-06 Thread Tom Rini
On Wed, Apr 12, 2023 at 07:49:29PM +0100, Dmitrii Merkurev wrote: > Make following changes to unblock TCP fastboot support: > > 1. Implement being a TCP server support > 2. Introduce dedicated TCP traffic handler (get rid of UDP signature) > 3. Ensure seq_num and ack_num are respected in

Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-05-06 Thread Tom Rini
On Tue, Apr 25, 2023 at 04:06:58PM +0300, Eugen Hristev wrote: > Add minimal support for 8125B version. > Changes are based on the Linux driver. > Tested on Radxa Rock 5B Rk3588 board. > > Connection to a laptop worked fine in 100 Mbps mode. > 1000 Mbps mode is not working at the moment. > >

Re: [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.

2023-05-06 Thread Tom Rini
On Mon, Feb 20, 2023 at 04:03:15PM +0100, Elmar Psilog wrote: > Without that patch it lost track to the node to scan > speed and duplex. > Patch was created by Marek Vasut, just tested by me. > > Signed-off-by: Elmar Psilog > Reviewed-by: Marek Vasut Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 2/2] drivers: net: fsl-mc: fix MAC address fixup procedure

2023-05-06 Thread Tom Rini
On Thu, Feb 09, 2023 at 06:07:04PM +0200, Ioana Ciornei wrote: > In the process of adopting CONFIG_DM_ETH on the DPAA2 based platforms, > interfaces which were previously defined as "xgmii" were transitioned to > be defined as "xfi" in the DTS. > See the commit below for reference: > commit

Re: [PATCH 1/2] drivers: net: ldpaa: export driver name and API to get DPMAC id

2023-05-06 Thread Tom Rini
On Thu, Feb 09, 2023 at 06:07:03PM +0200, Ioana Ciornei wrote: > Export the ldpaa_eth_get_dpmac_id() function so that it can be used from > other drivers, especially by fsl-mc which will need it the next patch. > Also, create a macro for the Ethernet ldpaa driver name and export it as > well. >

Re: [PATCH 1/3] net: ksz9477: remove unnecessary dsa_set_tagging call

2023-05-06 Thread Tom Rini
On Tue, Feb 07, 2023 at 03:37:16PM -0800, Tim Harvey wrote: > packet tagging is not used for this driver so we do not need to > call dsa_set_tagging. > > Signed-off-by: Tim Harvey > Reviewed-by: Ramon Fried For the series, applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH V3 3/3] net: phy: Make phy_interface_is_rgmii a switch statement

2023-05-06 Thread Tom Rini
On Fri, Apr 14, 2023 at 05:06:45PM -0500, Nishanth Menon wrote: > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This exposed a problem > in range checking functions to identify the interface type. Though > this specific api

Re: [PATCH V3 2/3] net: phy: Drop phy_interface_is_sgmii

2023-05-06 Thread Tom Rini
On Fri, Apr 14, 2023 at 05:06:44PM -0500, Nishanth Menon wrote: > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This caused the range of > enums that this api was checking to go bad. > > There aren't anymore users of

Re: [PATCH V3 1/3] net: phy: dp83867: Explicitly check against sgmii

2023-05-06 Thread Tom Rini
On Fri, Apr 14, 2023 at 05:06:43PM -0500, Nishanth Menon wrote: > dp83867 driver only supports sgmii and not all the newer protocols. > Drop the usage of the generic phy_interface_is_sgmii function and just > matchup to the specific mode supported. > > Reported-by: Tom Rini > Suggested-by:

Re: [PATCH v2] net: phy: gmii2rgmii: Support external rgmii-id phy

2023-05-06 Thread Tom Rini
On Wed, Mar 22, 2023 at 09:42:47AM +0100, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > Read the phy mode of the external phy from the device tree if available > and check that it is a RGMII variant. > > Signed-off-by: Stefan Herbrechtsmeier Applied to u-boot/master,

Re: [PATCH] net: phy: Request rgmii-id phy reset gpio as output

2023-05-06 Thread Tom Rini
On Tue, May 02, 2023 at 02:50:43PM +0200, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > Request the reset gpio of the rgmii-id phy as output to be consistent > with the eth-phy-uclass driver. > > Signed-off-by: Stefan Herbrechtsmeier > Reviewed-by: Michal Simek Applied to

Re: [PATCH] phy: realtek: don't duplicate genphy_startup

2023-05-06 Thread Tom Rini
On Tue, Mar 28, 2023 at 11:21:08PM +0200, Rasmus Villemoes wrote: > rtl8211e_startup() is an exact copy of genphy_startup(). Use that > instead of duplicating it. > > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] phy: broadcom: don't duplicate genphy_startup

2023-05-06 Thread Tom Rini
On Tue, Mar 28, 2023 at 11:12:47PM +0200, Rasmus Villemoes wrote: > Functionally, bcm_cygnus_startup() is an exact copy of > genphy_startup(). > > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 3/3] test: eth: IPv6 network discovery unit test

2023-05-06 Thread Tom Rini
On Fri, Apr 21, 2023 at 05:08:23PM -0700, emohand...@linux.microsoft.com wrote: > From: Ehsan Mohandesi > > Test router advertisement validation and processing functions. > > Signed-off-by: Ehsan Mohandesi > Reviewed-by: Viacheslav Mitrofanov Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v4 2/3] test/py: IPv6 network discovery test

2023-05-06 Thread Tom Rini
On Fri, Apr 21, 2023 at 05:08:22PM -0700, emohand...@linux.microsoft.com wrote: > From: Ehsan Mohandesi > > Test the IPv6 network discovery feature if indicated by boardenv file. > > Signed-off-by: Ehsan Mohandesi > Reviewed-by: Viacheslav Mitrofanov Applied to u-boot/master, thanks! --

Re: [PATCH v4 1/3] net: ipv6: Add support for default gateway discovery.

2023-05-06 Thread Tom Rini
On Fri, Apr 21, 2023 at 05:08:21PM -0700, emohand...@linux.microsoft.com wrote: > From: Ehsan Mohandesi > > In IPv6, the default gateway and prefix length are determined by receiving > a router advertisement as defined in - > https://www.rfc-editor.org/rfc/rfc4861. > > Add support for sending

Re: [PATCH v3 3/3] net: dhcp6: Add a sandbox test for dhcp6

2023-05-06 Thread Tom Rini
On Tue, Apr 11, 2023 at 10:48:48AM -0700, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > Requires proper environment with DHCP6 server provisioned. > > Signed-off-by: Sean Edmond > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH v3 2/3] net: dhcp6: pxe: Add DHCP/PXE commands for IPv6

2023-05-06 Thread Tom Rini
On Tue, Apr 11, 2023 at 10:48:47AM -0700, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > Adds commands to support DHCP and PXE with IPv6. > > New configs added: > - CMD_DHCP6 > - DHCP6_PXE_CLIENTARCH > - DHCP6_PXE_DHCP_OPTION > - DHCP6_ENTERPRISE_ID > > New commands added (when

Re: [PATCH v3 1/3] net: dhcp6: Add DHCPv6 (DHCP for IPv6)

2023-05-06 Thread Tom Rini
On Tue, Apr 11, 2023 at 10:48:46AM -0700, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > Adds DHCPv6 protocol to u-boot. > > Allows for address assignement with DHCPv6 4-message exchange > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes DHCPv6 options > required by RFC 8415.

Re: [PATCH] net: ipv6: IPv6 environment variable cleanup

2023-05-06 Thread Tom Rini
On Wed, Feb 15, 2023 at 08:38:36PM -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > Fix "setenv gatewayip6". > > Synchronize IPv6 local variables with environment variables > in netboot_update_env() > > Signed-off-by: Sean Edmond Applied to u-boot/master, thanks! --

Re: [PATCH v2 1/4] nfs: convert supported_nfs_versions bitfield to an enum

2023-05-06 Thread Tom Rini
On Fri, Mar 10, 2023 at 10:51:52AM +0100, Christian Gmeiner wrote: > From: Thomas RIENOESSL > > Prep. work to support nfs v1. > > Signed-off-by: Thomas RIENOESSL For the series, applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH v2] serial: mxs: Add MXS AUART driver

2023-05-06 Thread Marek Vasut
Add trivial driver for the MXS AUART IP. This is the other UART IP present in i.MX23 and i.MX28, used to drive the non-DUART ports. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Andrejs Cainikovs Cc: Fabio Estevam Cc: Fedor Ross Cc: Jim Liu Cc: Johan Jonker Cc: Marek Vasut

[PATCH 4/4] usb: gadget: Add and use matching SPL USB ethernet gadget Kconfig symbols

2023-05-06 Thread Marek Vasut
Define SPL_USB_ETH_RNDIS symbol to make it possible to select USB gadget ethernet support in SPL and U-Boot separately in Kconfig . Make use of the new symbols in gadget Makefile and move the rndis.o just below the now merged USB_ETHER symbol in Makefile. Signed-off-by: Marek Vasut --- Cc:

[PATCH 3/4] usb: Move SPL_USB_GADGET and related Kconfig symbols to drivers/usb/

2023-05-06 Thread Marek Vasut
To avoid piling up all the various Kconfig symbols in one place, i.e. common/spl/Kconfig, move the USB Kconfig symbols into drivers/usb/ . This commit moves SPL_USB_GADGET and related symbols. Fix typo and rename SPL_USB_GADGET to "USB Gadget Support in SPL" . Update the gadget Makefile to match

[PATCH 2/4] usb: Move SPL_USB_STORAGE Kconfig symbol to drivers/usb/

2023-05-06 Thread Marek Vasut
To avoid piling up all the various Kconfig symbols in one place, i.e. common/spl/Kconfig, move the USB Kconfig symbols into drivers/usb/ . This commit moves SPL_USB_STORAGE and matching SYS_USB_FAT_BOOT_PARTITION . Signed-off-by: Marek Vasut --- Cc: Andrew Davis Cc: Chris Packham Cc: Jim Liu

[PATCH 1/4] usb: Move SPL_USB_HOST Kconfig symbol to drivers/usb/

2023-05-06 Thread Marek Vasut
To avoid piling up all the various Kconfig symbols in one place, i.e. common/spl/Kconfig, move the USB Kconfig symbols into drivers/usb/ . This commit moves SPL_USB_HOST and updates help text of both USB_HOST and SPL_USB_HOST . Signed-off-by: Marek Vasut --- Cc: Andrew Davis Cc: Chris Packham

[PATCH] bootstd: Correct default boot command

2023-05-06 Thread Simon Glass
The patch to relax flag requirements was not accepted[1], so we still have to have separate bootcommands depending on CMD_BOOTFLOW_FULL. The previous attempt at this did not work, since it used the wrong name for the options. Fix this and change the message to mention BOOTSTD_FULL since this

Re: [PATCH v5 1/6] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-05-06 Thread Kever Yang
Hi Eugen,     When I try to apply this patch, I got conflict for rk3588-rock-5b-u-boot.dtsi, could you please help to send a rebase? Thanks, - Kever On 2023/4/19 21:40, Eugen Hristev wrote: Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu

Re: [PATCH v5 1/6] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-05-06 Thread Kever Yang
On 2023/4/19 21:40, Eugen Hristev wrote: Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v5: - none Changes in v4: - removed u-boot,dm-spl on regulator which was

Re: [PATCH 04/14] rockchip: rk3566-radxa-cm3-io: Use pinctrl for sdmmc and sdhci in SPL

2023-05-06 Thread Kever Yang
On 2023/4/22 09:23, Jonas Karlman wrote: Enable pinctrl for sdmmc and sdhci in SPL to support loading of FIT image from SD and eMMC storage when booting from SPI NOR flash. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever ---

Re: [PATCH 03/14] rockchip: rk3566-radxa-cm3-io: Update defconfig

2023-05-06 Thread Kever Yang
On 2023/4/22 09:23, Jonas Karlman wrote: Update defconfig for rk3566-radxa-cm3-io with new defaults. Also add missing supported mmc modes to sdhci node. Remove the SPL_ROCKCHIP_BACK_TO_BROM=y option, SPL is expected to load next stage from a FIT image and then jump to next stage not back to

Re: [PATCH 02/14] rockchip: rk356x-u-boot: Add xin24m clock node to SPL

2023-05-06 Thread Kever Yang
On 2023/4/22 09:23, Jonas Karlman wrote: Add bootph-all prop to xin24m clock node, it is referenced by cru node. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x-u-boot.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 01/14] spi: rockchip_sfc: Use linux rockchip,sfc-no-dma prop

2023-05-06 Thread Kever Yang
On 2023/4/22 09:23, Jonas Karlman wrote: Use the same prop as linux to control the use of fifo or dma mode. Also add a u-boot,spl-sfc-no-dma prop to control the same in SPL. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/spi/rockchip_sfc.c | 10

Re: [PATCH v3 7/7] configs: rock5b-rk3588: add PCI drivers and command

2023-05-06 Thread Kever Yang
On 2023/4/27 15:35, Eugen Hristev wrote: Add drivers for PCIe , phy, and command. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v3; - s/pciE/PCIe Changes in v2: - binman_fdt is now removed configs/rock5b-rk3588_defconfig | 4 1 file

Re: [PATCH v3 6/7] ARM: dts: rockchip: rock5b: enable pcie2x1l2 and associated combphy

2023-05-06 Thread Kever Yang
On 2023/4/27 15:35, Eugen Hristev wrote: From: Christopher Obbard Enable the PCIe 2x1l 2 device and associated combphy. On this bus, the Rock5B has an Ethernet transceiver connected. Signed-off-by: Christopher Obbard [eugen.hris...@collabora.com: minor tweaks] Signed-off-by: Eugen Hristev

Re: [PATCH v3 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

2023-05-06 Thread Kever Yang
On 2023/4/27 15:35, Eugen Hristev wrote: From: Joseph Chen Add the node for PCIe 2x1l 2 device together with the corresponding combphy. Signed-off-by: Joseph Chen [eugen.hris...@collabora.com: moved to -u-boot.dtsi, minor adaptations] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: adapt

Re: [PATCH] board: rockchip: add Anbernic RGXX3 Series Devices

2023-05-06 Thread Kever Yang
On 2023/4/21 23:59, Chris Morgan wrote: From: Chris Morgan The Anbernic RGxx3 is a "pseudo-device" that encompasses the following devices: - Anbernic RG353M - Anbernic RG353P - Anbernic RG353V - Anbernic RG353VS - Anbernic RG503 The rk3566-anbernic-rgxx3.dtsi is synced with

Re: [PATCH v5 4/6] phy: remove phy-supply related code

2023-05-06 Thread Kever Yang
Hi Neil,     Could you take a look at this patch? Thanks, - Kever On 2023/4/19 21:40, Eugen Hristev wrote: phy-supply is now handled at uclass level. Remove it from the drivers that implement it at the driver level. Suggested-by: Jonas Karlman Signed-off-by: Eugen Hristev ---

Re: [PATCH v5 6/6] phy: Keep balance of counts when ops is missing

2023-05-06 Thread Kever Yang
On 2023/4/19 21:40, Eugen Hristev wrote: From: Jonas Karlman Fixes: 226fce6108fe ("phy: Track power-on and init counts in uclass") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/phy-uclass.c | 80 1 file

Re: [PATCH v5 5/6] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-05-06 Thread Kever Yang
On 2023/4/19 21:40, Eugen Hristev wrote: Add initial support for the rk3588 PHY variant. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first check for reg == 0. Co-developed-by: Frank Wang Signed-off-by: Frank Wang

Re: [PATCH v5 3/6] phy: add support for phy-supply

2023-05-06 Thread Kever Yang
On 2023/4/19 21:40, Eugen Hristev wrote: Some phys require a phy-supply property that is a phandle to a regulator that needs to be enabled for phy operations. Implement basic supply lookup, enable and disabling, if DM_REGULATOR is available. [jo...@kwiboo.se: use

Re: [PATCH v5 2/6] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-05-06 Thread Kever Yang
On 2023/4/19 21:40, Eugen Hristev wrote: Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock5b-rk3588_defconfig | 17 + 1 file changed, 17 insertions(+)

Re: [PATCH 05/13] x86: coreboot: Collect the address of the ACPI tables

2023-05-06 Thread Bin Meng
Hi Simon, On Fri, Mar 24, 2023 at 1:55 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 20 Mar 2023 at 20:44, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass wrote: > > > > > > Pick this up from the sysinfo tables and display it with the cbsysinfo > > >