Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-12-28 Thread Simon Glass
Hi Sughosh, On Fri, Dec 29, 2023 at 6:53 AM Sughosh Ganu wrote: > > hi Simon, > > On Wed, 27 Dec 2023 at 23:19, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Mon, Dec 4, 2023 at 7:15 AM Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Sat, 2 Dec 2023 at 00:02, Simon Glass wrote: >

Re: [PATCH v4 2/9] acpi: carve out qfw_acpi.c

2023-12-28 Thread Ilias Apalodimas
On Tue, Dec 19, 2023 at 04:04:01PM +0100, Heinrich Schuchardt wrote: > Move the code related to copying tables from QEMU to a separate code > module. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Tom Rini > Reviewed-by: Simon Glass > --- > v4: > no change > v3: > no change

Re: [PATCH v4 5/9] acpi: enable writing ACPI tables on QEMU

2023-12-28 Thread Ilias Apalodimas
On Tue, Dec 19, 2023 at 04:04:04PM +0100, Heinrich Schuchardt wrote: > Invoke write_acpi_tables() via EVT_LAST_STAGE_INIT on QEMU except on X86. > X86 calls write_acpi_tables() in write_tables(). > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > --- > v4: > no change >

Re: New TPM commands.

2023-12-28 Thread Ilias Apalodimas
Hi Niek, On Thu, Dec 21, 2023 at 02:12:49AM +, niek.nooij...@omron.com wrote: > Hi Ilias > > I implemented the feedback and checked the htmldocs build target. no error > there. > I also applied the patch to the latest github version (was using an older > one, but no compatibility issues)

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-12-28 Thread Sughosh Ganu
hi Simon, On Wed, 27 Dec 2023 at 23:19, Simon Glass wrote: > > Hi Sughosh, > > On Mon, Dec 4, 2023 at 7:15 AM Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sat, 2 Dec 2023 at 00:02, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Thu, 30 Nov 2023 at 23:39, Sughosh Ganu > > >

Re: [PATCH v6 5/8] binman: j721s2: Add firewall configurations

2023-12-28 Thread Manorit Chawdhry
Hi Simon, On 09:50-20231226, Simon Glass wrote: > Hi Manorit, > > On Wed, Dec 6, 2023 at 9:51 AM Manorit Chawdhry wrote: > > > > The following commits adds the configuration of firewalls required to > > protect ATF and OP-TEE memory region from non-secure reads and > > writes using master and

Re: Proposal: U-Boot memory management

2023-12-28 Thread Ilias Apalodimas
Hi Simon, On Fri, 29 Dec 2023 at 07:36, Simon Glass wrote: > > Hi Ilias, > > On Fri, Dec 22, 2023 at 12:02 PM Ilias Apalodimas > wrote: > > > > Hi Simon > > > > I'll respond to the rest more thoroughly but I since I caught this early, > > > > [...] > > > > > > > > 5. Avoid calling

Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree

2023-12-28 Thread Simon Glass
Hi Masahiro, On Thu, Dec 14, 2023 at 7:34 AM Masahiro Yamada wrote: > > On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada wrote: > > > > On Thu, Dec 14, 2023 at 1:03 PM Chen-Yu Tsai wrote: > > > > > > On Sun, Dec 10, 2023 at 1:31 AM Geert Uytterhoeven > > > wrote: > > > > > > > > Hi Laurent, >

Re: [PATCH v4 08/12] bloblist: Handle alignment with a void entry

2023-12-28 Thread Ilias Apalodimas
On Thu, 28 Dec 2023 at 18:04, Raymond Mao wrote: > > Hi Ilias, > > On Thu, 28 Dec 2023 at 06:32, Ilias Apalodimas > wrote: >> >> Hi Raymond, >> >> On Wed, 27 Dec 2023 at 23:08, Raymond Mao wrote: >> > >> > From: Simon Glass >> > >> > Rather than setting the alignment using the header size,

Re: [PATCH v4 7/7] smbios: Require the caller to align the SMBIOS table

2023-12-28 Thread Ilias Apalodimas
On Thu, 28 Dec 2023 at 23:00, Heinrich Schuchardt wrote: > > > > Am 28. Dezember 2023 20:48:04 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Thu, Dec 28, 2023 at 5:36 PM Heinrich Schuchardt > >wrote: > >> > >> > >> > >> Am 28. Dezember 2023 14:37:19 MEZ schrieb Simon Glass : > >> >Hi

Re: Proposal: U-Boot memory management

2023-12-28 Thread Simon Glass
Hi, On Sat, Dec 16, 2023 at 6:01 PM Simon Glass wrote: > > Hi, > > This records my thoughts after a discussion with Ilias & Heinrich re > memory allocation in U-Boot. > > 1. malloc() > > malloc() is used for programmatic memory allocation. It allows memory > to be freed. It is not designed for

Re: Proposal: U-Boot memory management

2023-12-28 Thread Simon Glass
Hi Ilias, On Fri, Dec 22, 2023 at 12:02 PM Ilias Apalodimas wrote: > > Hi Simon > > I'll respond to the rest more thoroughly but I since I caught this early, > > [...] > > > > > 5. Avoid calling efi_allocate_pages() and efi_allocate_pool() outside > > boot-time services. This solves the problem

Re: [PATCH] include: env: ti: default_findfdt: Follow the bootstd/distro conventions

2023-12-28 Thread Jon Humphreys
Nishanth Menon writes: > Distroboot and bootstd both mandate a findfdt variable pointing to the > correct device tree blob. Current mechanism calls a find_fdt function > to set this variable. We do not need a find_fdt command to set the > environment variable to a single dtb. Simplify the

[PATCH] net: phy: ncsi: fixed not nullify the pointers after free

2023-12-28 Thread Jacky Chou
The issue occurs the UAF (use-after-free) to cause double free when do the realloc function for the pointers during the reinitialization NC-SI process, and it will cause the memory management occurs error. So, nullify these pointers after free. Signed-off-by: Jacky Chou ---

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Mario Marietto
Is my version the correct one ? root@devuan-bunsen:/mnt/zroot2/zroot2/OS/Chromebook/freebsd-xen/domU-freebsd/bootloaders# strings u-boot.bin | grep U-Boot ** Invalid partition type "%.32s" (expect "U-Boot") scan_dev_for_scripts=for script in ${boot_scripts}; do if test -e ${devtype}

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Mario Marietto
Maybe some parameter is wrong inside the snow_defconfig file ? Can you give a look ? CONFIG_ARM=y CONFIG_SKIP_LOWLEVEL_INIT=y CONFIG_SPL_SKIP_LOWLEVEL_INIT=y CONFIG_ARCH_CPU_INIT=y # CONFIG_SPL_USE_ARCH_MEMCPY is not set # CONFIG_SPL_USE_ARCH_MEMSET is not set CONFIG_ARCH_EXYNOS=y

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Mario Marietto
I've just built it with Ubuntu 18.04 / gcc 7.5.0 ; I have my u-boot.bin and I tried to see if it worked,but unfortunately it doesn't. root@devuan-bunsen:/mnt/zroot2/zroot2/OS/Chromebook/freebsd-xen/domU-freebsd# ./start-freebsd Parsing config from freebsd.cfg xc: error: panic: xg_dom_core.c:689:

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Tony Dinh
On Thu, Dec 28, 2023 at 11:48 AM Simon Glass wrote: > > Hi Mario, > > On Thu, Dec 28, 2023 at 3:48 PM Mario Marietto wrote: > > > > I tried to compile it,but If failed : > > > > /mnt/zroot2/zroot2/OS/Chromebook/freebsd-xen/domU-freebsd/bootloaders/u-boot-2017.05# > > ARCH=arm

Re: [PATCH v6] fdt: Allow the devicetree to come from a bloblist

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 07:47:25PM +, Simon Glass wrote: > Standard passage provides for a bloblist to be passed from one firmware > phase to the next. That can be used to pass the devicetree along as well. > Add an option to support this. > > Tests for this will be added as part of the

Re: [PATCH v13 00/24] Modernize U-Boot shell

2023-12-28 Thread Tom Rini
On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote: > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, > based > on LIL, to U-Boot [1, 2]. > While one of the goals of this contribution was to address the fact actual > U-Boot shell, which is based on Busybox hush,

Re: [PATCH v4 7/7] smbios: Require the caller to align the SMBIOS table

2023-12-28 Thread Heinrich Schuchardt
Am 28. Dezember 2023 20:48:04 MEZ schrieb Simon Glass : >Hi Heinrich, > >On Thu, Dec 28, 2023 at 5:36 PM Heinrich Schuchardt wrote: >> >> >> >> Am 28. Dezember 2023 14:37:19 MEZ schrieb Simon Glass : >> >Hi Ilias, >> > >> >On Wed, Dec 27, 2023 at 11:12 AM Ilias Apalodimas >> > wrote: >> >> >>

Re: [PATCH 0/9] dts: Move to SoC-specific build rules

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 07:48:08PM +, Simon Glass wrote: > Hi Tom, > > On Thu, Dec 28, 2023 at 3:40 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 03:09:40PM +, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, Dec 28, 2023 at 2:23 PM Tom Rini wrote: > > > > > > > > On Thu, Dec

Re: [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 07:48:13PM +, Simon Glass wrote: > Hi Tom, > > On Thu, Dec 28, 2023 at 3:25 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 03:09:41PM +, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, Dec 28, 2023 at 1:56 PM Tom Rini wrote: > > > > > > > > On Thu, Dec

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 07:48:06PM +, Simon Glass wrote: > Hi Tom, > > On Thu, Dec 28, 2023 at 3:54 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 03:09:12PM +, Simon Glass wrote: > > > Hi Tom, Sumit, > > > > > > On Thu, Dec 28, 2023 at 2:03 PM Tom Rini wrote: > > > > > > > > On

Re: [PATCH v6 4/6] common: console: record console from the beginning

2023-12-28 Thread Svyatoslav Ryhel
чт, 28 груд. 2023 р. о 21:48 Simon Glass пише: > > On Thu, Dec 28, 2023 at 6:02 PM Svyatoslav Ryhel wrote: > > > > From: Ion Agorria > > > > Set flag to enable console record on console_record_init > > and not only on console_record_reset_enable. This fixes > > missing start of U-Boot log for

Re: [PATCH v3 1/9] bloblist: add API to check the register conventions

2023-12-28 Thread Simon Glass
Hi Raymond, On Thu, Dec 28, 2023 at 3:13 PM Raymond Mao wrote: > > Hi Simon, > > On Thu, 28 Dec 2023 at 08:38, Simon Glass wrote: >> >> Hi Raymond, >> >> On Wed, Dec 27, 2023 at 4:06 PM Raymond Mao wrote: >> > >> > Hi Simon, >> > >> > On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: >> >> >>

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Simon Glass
Hi Mario, On Thu, Dec 28, 2023 at 3:48 PM Mario Marietto wrote: > > I tried to compile it,but If failed : > > /mnt/zroot2/zroot2/OS/Chromebook/freebsd-xen/domU-freebsd/bootloaders/u-boot-2017.05# > ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make snow_defconfig > > HOSTCC scripts/basic/fixdep

Re: [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-28 Thread Simon Glass
Hi Tom, On Thu, Dec 28, 2023 at 3:25 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 03:09:41PM +, Simon Glass wrote: > > Hi Tom, > > > > On Thu, Dec 28, 2023 at 1:56 PM Tom Rini wrote: > > > > > > On Thu, Dec 28, 2023 at 01:37:11PM +, Simon Glass wrote: > > > > Hi Sumit, > > > > > > > >

Re: [PATCH v6 4/6] common: console: record console from the beginning

2023-12-28 Thread Simon Glass
On Thu, Dec 28, 2023 at 6:02 PM Svyatoslav Ryhel wrote: > > From: Ion Agorria > > Set flag to enable console record on console_record_init > and not only on console_record_reset_enable. This fixes > missing start of U-Boot log for fastboot oem console > command. > > Signed-off-by: Ion Agorria >

Re: [PATCH v6 3/6] common: console: introduce console_record_isempty helper

2023-12-28 Thread Simon Glass
On Thu, Dec 28, 2023 at 6:02 PM Svyatoslav Ryhel wrote: > > From: Ion Agorria > > Add console_record_isempty to check if console record buffer > contains any data. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > Reviewed-by: Mattijs Korpershoek > --- > common/console.c |

Re: [PATCH 0/9] dts: Move to SoC-specific build rules

2023-12-28 Thread Simon Glass
Hi Tom, On Thu, Dec 28, 2023 at 3:40 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 03:09:40PM +, Simon Glass wrote: > > Hi Tom, > > > > On Thu, Dec 28, 2023 at 2:23 PM Tom Rini wrote: > > > > > > On Thu, Dec 28, 2023 at 01:37:07PM +, Simon Glass wrote: > > > > Hi Tom, > > > > > > > >

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2023-12-28 Thread Simon Glass
Hi Tom, On Thu, Dec 28, 2023 at 3:54 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 03:09:12PM +, Simon Glass wrote: > > Hi Tom, Sumit, > > > > On Thu, Dec 28, 2023 at 2:03 PM Tom Rini wrote: > > > > > > On Thu, Dec 28, 2023 at 01:37:26PM +, Simon Glass wrote: > > > > Hi Sumit, > > > >

Re: [PATCH 5/5] test: unit test for smbios command

2023-12-28 Thread Simon Glass
Hi Heinrich, On Thu, Dec 28, 2023 at 5:11 PM Heinrich Schuchardt wrote: > > > > Am 27. Dezember 2023 08:40:40 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Tue, Dec 26, 2023 at 10:11 AM Heinrich Schuchardt > >wrote: > >> > >> On 12/26/23 10:47, Simon Glass wrote: > >> > Hi Heinrich, > >>

Re: [PATCH v4 7/7] smbios: Require the caller to align the SMBIOS table

2023-12-28 Thread Simon Glass
Hi Heinrich, On Thu, Dec 28, 2023 at 5:36 PM Heinrich Schuchardt wrote: > > > > Am 28. Dezember 2023 14:37:19 MEZ schrieb Simon Glass : > >Hi Ilias, > > > >On Wed, Dec 27, 2023 at 11:12 AM Ilias Apalodimas > > wrote: > >> > >> Hi Simon, > >> > >> I commented on v3 as well, but in case you miss

[PATCH v6] fdt: Allow the devicetree to come from a bloblist

2023-12-28 Thread Simon Glass
Standard passage provides for a bloblist to be passed from one firmware phase to the next. That can be used to pass the devicetree along as well. Add an option to support this. Tests for this will be added as part of the Universal Payload work. Signed-off-by: Simon Glass --- The discussion on

[PATCH v6 6/6] fastboot: add oem console command support

2023-12-28 Thread Svyatoslav Ryhel
From: Ion Agorria "oem console" serves to read console record buffer. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek --- doc/android/fastboot.rst | 1 + drivers/fastboot/Kconfig | 7 +++ drivers/fastboot/fb_command.c | 39

[PATCH v6 5/6] lib: membuff: fix readline not returning line in case of overflow

2023-12-28 Thread Svyatoslav Ryhel
From: Ion Agorria If line overflows readline it will not be returned, fix this behavior, make it optional and documented properly. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek Reviewed-by: Simon Glass --- boot/bootmeth_extlinux.c | 2 +-

[PATCH v6 4/6] common: console: record console from the beginning

2023-12-28 Thread Svyatoslav Ryhel
From: Ion Agorria Set flag to enable console record on console_record_init and not only on console_record_reset_enable. This fixes missing start of U-Boot log for fastboot oem console command. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek ---

[PATCH v6 3/6] common: console: introduce console_record_isempty helper

2023-12-28 Thread Svyatoslav Ryhel
From: Ion Agorria Add console_record_isempty to check if console record buffer contains any data. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek --- common/console.c | 5 + include/console.h | 13 + 2 files changed, 18

[PATCH v6 2/6] fastboot: implement "getvar all"

2023-12-28 Thread Svyatoslav Ryhel
From: Ion Agorria This commit implements "fastboot getvar all" listing by iterating the existing dispatchers that don't require parameters (as we pass NULL), uses fastboot multiresponse. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek ---

[PATCH v6 1/6] fastboot: multiresponse support

2023-12-28 Thread Svyatoslav Ryhel
From: Ion Agorria Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of

[PATCH v6 0/6] Implement fastboot multiresponce

2023-12-28 Thread Svyatoslav Ryhel
Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of response) proposed in this

Re: [PATCH v4 4/7] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 03:46:09PM +0100, Mark Kettenis wrote: > > From: Simon Glass > > Date: Thu, 28 Dec 2023 13:37:03 + > > > > Hi Ilias, > > > > On Wed, Dec 27, 2023 at 11:05 AM Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Wed, 27 Dec 2023 at 09:40, Simon Glass

Re: Regression: i.MX6ULL reset not working

2023-12-28 Thread Fabio Estevam
On Thu, Dec 28, 2023 at 2:23 PM Francesco Dolcini wrote: > Are you sure? After the related kconfig changes you'll have CONFIG_WDT > enabled, and with that the watchdog is started and you need to > periodically refresh it. At the moment the watchdog is not enabled at > boot and it is used only

Re: [PATCH v4 7/7] smbios: Require the caller to align the SMBIOS table

2023-12-28 Thread Heinrich Schuchardt
Am 28. Dezember 2023 14:37:19 MEZ schrieb Simon Glass : >Hi Ilias, > >On Wed, Dec 27, 2023 at 11:12 AM Ilias Apalodimas > wrote: >> >> Hi Simon, >> >> I commented on v3 as well, but in case you miss that >> >> On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: >> > >> > All callers handle this

Re: [PATCH 26/26] arm: dts: k3-am654: convert bootph-pre-ram to bootph-all

2023-12-28 Thread Bryan Brattlof
On December 27, 2023 thus sayeth Nishanth Menon: > On 11:44-20231221, Bryan Brattlof wrote: > [..] > > diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > > b/arch/arm/dts/k3-am654-base-board-u-boot.dtsi > > index a9b2d0d2a3036..770c7d129339f 100644 > > ---

Re: Regression: i.MX6ULL reset not working

2023-12-28 Thread Francesco Dolcini
On Thu, Dec 28, 2023 at 02:08:33PM -0300, Fabio Estevam wrote: > On Thu, Dec 28, 2023 at 1:46 PM Francesco Dolcini > wrote: > > > With that we would have to enable the watchdog, something that is not > > done today. Any potential downside on doing it? > > I don't see any. > > The watchdog was

Re: [PATCH 5/5] test: unit test for smbios command

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 06:06:23PM +0100, Heinrich Schuchardt wrote: > > > Am 27. Dezember 2023 08:40:40 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Tue, Dec 26, 2023 at 10:11 AM Heinrich Schuchardt > >wrote: > >> > >> On 12/26/23 10:47, Simon Glass wrote: > >> > Hi Heinrich, > >> > >

Re: [PATCH 12/26] arm: dts: k3-am654: add needed regs to udmap nodes

2023-12-28 Thread Bryan Brattlof
On December 27, 2023 thus sayeth Nishanth Menon: > On 11:43-20231221, Bryan Brattlof wrote: > > Ethernet is one of a few IPs in U-Boot that depend on DMA to operate. > > However there are a few missing registers ranges in the udmap nodes > > need to properly setup DMA for the am65x. > > > > A fix

Re: Regression: i.MX6ULL reset not working

2023-12-28 Thread Fabio Estevam
On Thu, Dec 28, 2023 at 1:46 PM Francesco Dolcini wrote: > With that we would have to enable the watchdog, something that is not > done today. Any potential downside on doing it? I don't see any. The watchdog was being used originally too, but not via DM.

Re: [PATCH 5/5] test: unit test for smbios command

2023-12-28 Thread Heinrich Schuchardt
Am 27. Dezember 2023 08:40:40 MEZ schrieb Simon Glass : >Hi Heinrich, > >On Tue, Dec 26, 2023 at 10:11 AM Heinrich Schuchardt >wrote: >> >> On 12/26/23 10:47, Simon Glass wrote: >> > Hi Heinrich, >> > >> > On Sat, Dec 23, 2023 at 12:49 AM Heinrich Schuchardt >> > wrote: >> >> >> >> Provide

Re: [PATCH] cmd: net: nfs: Enable the NFS command by default

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 12:04:12PM +0530, Tejas Bhumkar wrote: > Activated the default use of NFS command for booting > images via network using the NFS protocol. > > Signed-off-by: Tejas Bhumkar > --- > cmd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cmd/Kconfig

Re: [GIT PULL] u-boot-riscv/next

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 01:38:11PM +0800, Leo Liang wrote: > Hi Tom, > > The following changes since commit 4b151562bb8e54160adedbc6a1c0c749c00a2f84: > > bootmeth: pass size to efi_binary_run() (2023-12-22 10:36:50 -0500) > > are available in the Git repository at: > >

Re: [PATCH v1 09/12] cmd: allow to enable CMD_NAND for SPI NAND devices

2023-12-28 Thread Sean Anderson
On 12/28/23 10:39, Alexey Romanov wrote: > Boards with SPI NAND also can use this command. > > Signed-off-by: Alexey Romanov > --- > cmd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index c47523a03b..c8484576e2 100644 > ---

Re: [PATCH v1 11/12] fastboot: enable FASTBOOT_FLASH option for SPI NAND devices

2023-12-28 Thread Sean Anderson
On 12/28/23 10:39, Alexey Romanov wrote: > From now we can use FASTBOOT_FLASH_NAND option for SPI NAND. > > Signed-off-by: Alexey Romanov > --- > drivers/fastboot/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fastboot/Kconfig

Re: [PATCH v1 10/12] fastboot: check device type for SPI NAND too

2023-12-28 Thread Sean Anderson
On 12/28/23 10:39, Alexey Romanov wrote: > SPI NAND devices also supports 'fastboot erase / flash' commands. > > Signed-off-by: Alexey Romanov > --- > drivers/fastboot/fb_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fastboot/fb_nand.c

Re: [PATCH v1 12/12] fastboot: fb_nand: add missing newlines in pr_err() macro

2023-12-28 Thread Sean Anderson
On 12/28/23 10:39, Alexey Romanov wrote: > pr_err() doesn't add an newline symbol when printing. > > Signed-off-by: Alexey Romanov > --- > drivers/fastboot/fb_nand.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/fastboot/fb_nand.c

Re: [PATCH v1 01/12] nand: move NAND initialization API to nand/core.c

2023-12-28 Thread Sean Anderson
On 12/28/23 10:39, Alexey Romanov wrote: > nand_register() and nand_init() is generic API for both > RAW and SPI NAND's. We have to move this functions > from drivers/mtd/nand/raw/nand.c to drivers/mtd/nand/core.c. > > Functions designed to work with RAW NAND should remain > in

Re: [PATCH v4 10/12] bloblist: Adjust the bloblist header

2023-12-28 Thread Ilias Apalodimas
On Thu, 28 Dec 2023 at 15:37, Simon Glass wrote: > > Hi Ilias, > > On Thu, Dec 28, 2023 at 7:37 AM Ilias Apalodimas > wrote: > > > > Hi Raymond, > > > > [...] > > > > > > > > void bloblist_show_list(void) > > > @@ -463,7 +477,7 @@ void bloblist_reloc(void *to, uint to_size, void > > > *from,

Re: Regression: i.MX6ULL reset not working

2023-12-28 Thread Francesco Dolcini
On Thu, Dec 28, 2023 at 01:35:31PM -0300, Fabio Estevam wrote: > Hi Francesco, > > On Thu, Dec 28, 2023 at 12:49 PM Francesco Dolcini > wrote: > > > > Hello Marek and all, > > I just tried latest master on colibri-imx6ull-emmc and the reset command > > is broken - it does nothing. > > > > From

Re: [PATCH v1] fastboot: introduce 'oem board' subcommand

2023-12-28 Thread Sean Anderson
On 12/28/23 10:25, Alexey Romanov wrote: > Currently, fastboot protocol in U-Boot has no opportunity > to execute vendor custom code with verifed boot. Well, I would say the most conventional way to do this would be something like => fastboot 0 => source \# CONFIG_FASTBOOT_BUF_ADDR and on your

Re: Regression: i.MX6ULL reset not working

2023-12-28 Thread Fabio Estevam
Hi Francesco, On Thu, Dec 28, 2023 at 12:49 PM Francesco Dolcini wrote: > > Hello Marek and all, > I just tried latest master on colibri-imx6ull-emmc and the reset command > is broken - it does nothing. > > From a bisect the issue was introduced with commit 68dcbdd594d4 ("ARM: > imx: Add weak

Re: [PATCH v4 10/12] bloblist: Adjust the bloblist header

2023-12-28 Thread Raymond Mao
Hi Ilias, On Thu, 28 Dec 2023 at 02:37, Ilias Apalodimas wrote: > Hi Raymond, > > [...] > > > > > void bloblist_show_list(void) > > @@ -463,7 +477,7 @@ void bloblist_reloc(void *to, uint to_size, void > *from, uint from_size) > > > > memcpy(to, from, from_size); > > hdr = to; >

Re: Regression: i.MX6ULL reset not working

2023-12-28 Thread Francesco Dolcini
On Thu, Dec 28, 2023 at 04:49:33PM +0100, Francesco Dolcini wrote: > Hello Marek and all, > I just tried latest master on colibri-imx6ull-emmc and the reset command > is broken - it does nothing. > > >From a bisect the issue was introduced with commit 68dcbdd594d4 ("ARM: > imx: Add weak default

Re: [PATCH v4 08/12] bloblist: Handle alignment with a void entry

2023-12-28 Thread Raymond Mao
Hi Ilias, On Thu, 28 Dec 2023 at 06:32, Ilias Apalodimas wrote: > Hi Raymond, > > On Wed, 27 Dec 2023 at 23:08, Raymond Mao wrote: > > > > From: Simon Glass > > > > Rather than setting the alignment using the header size, add an entirely > > new entry to cover the gap left by the alignment. >

Re: [PATCH v5] fdt: Allow the devicetree to come from a bloblist

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 01:36:54PM +, Simon Glass wrote: > Standard passage provides for a bloblist to be passed from one firmware > phase to the next. That can be used to pass the devicetree along as well. > Add an option to support this. > > Tests for this will be added as part of the

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 03:09:12PM +, Simon Glass wrote: > Hi Tom, Sumit, > > On Thu, Dec 28, 2023 at 2:03 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 01:37:26PM +, Simon Glass wrote: > > > Hi Sumit, > > > > > > On Thu, Dec 28, 2023 at 11:58 AM Sumit Garg wrote: > > > > > > > >

Regression: i.MX6ULL reset not working

2023-12-28 Thread Francesco Dolcini
Hello Marek and all, I just tried latest master on colibri-imx6ull-emmc and the reset command is broken - it does nothing. >From a bisect the issue was introduced with commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()"), U-Boot releases >= v2023.07 are broken. Any hint? I did not try

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Mario Marietto
I tried to compile it,but If failed : /mnt/zroot2/zroot2/OS/Chromebook/freebsd-xen/domU-freebsd/bootloaders/u-boot-2017.05# ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make snow_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/zconf.tab.o In

[PATCH v1 12/12] fastboot: fb_nand: add missing newlines in pr_err() macro

2023-12-28 Thread Alexey Romanov
pr_err() doesn't add an newline symbol when printing. Signed-off-by: Alexey Romanov --- drivers/fastboot/fb_nand.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c index 39d888301f..9db1903e41 100644 ---

[PATCH v1 11/12] fastboot: enable FASTBOOT_FLASH option for SPI NAND devices

2023-12-28 Thread Alexey Romanov
>From now we can use FASTBOOT_FLASH_NAND option for SPI NAND. Signed-off-by: Alexey Romanov --- drivers/fastboot/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig index a3df9aa3d0..3cfeea4837 100644 ---

[PATCH v1 10/12] fastboot: check device type for SPI NAND too

2023-12-28 Thread Alexey Romanov
SPI NAND devices also supports 'fastboot erase / flash' commands. Signed-off-by: Alexey Romanov --- drivers/fastboot/fb_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c index 6d3a900c77..39d888301f 100644 ---

[PATCH v1 09/12] cmd: allow to enable CMD_NAND for SPI NAND devices

2023-12-28 Thread Alexey Romanov
Boards with SPI NAND also can use this command. Signed-off-by: Alexey Romanov --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index c47523a03b..c8484576e2 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1367,7 +1367,7 @@ config

[PATCH v1 07/12] mtdparts: use negative error codes

2023-12-28 Thread Alexey Romanov
It is bad practice to use such error codes. Error codes must be negative. Also, fastboot code expects that if successful, mtdparts functions will return a value greater than 0. You can see fastboot_nand_get_part_info() functions calls inside getvar_get_part_info(). And use 'return

[PATCH v1 08/12] jffs2: use negative error codes

2023-12-28 Thread Alexey Romanov
It is bad practice to use such error codes. Error codes must be negative. And use CMD_RET_FAILURE and CMD_RET_SUCCESS defines instead of 1 and 0. Signed-off-by: Alexey Romanov --- cmd/jffs2.c | 45 +++-- 1 file changed, 23 insertions(+), 22 deletions(-)

[PATCH v1 06/12] spi: use nand_register() instead of add_mtd_device()

2023-12-28 Thread Alexey Romanov
Most functions that work with NAND device (for example fastboot), use the get_nand_dev_by_index() function to work with NAND MTD. In order to use this feature, SPI NAND must be registered via nand_register(). Signed-off-by: Alexey Romanov --- drivers/mtd/nand/spi/core.c | 3 ++- 1 file changed,

[PATCH v1 05/12] spi: add board_nand_init() function

2023-12-28 Thread Alexey Romanov
By analogy with RAW NAND drivers, select SYS_NAND_SELF_INIT option and implement board_nand_init() function. It will be called from nand_init(). Signed-off-by: Alexey Romanov --- drivers/mtd/nand/spi/Kconfig | 1 + drivers/mtd/nand/spi/core.c | 14 ++ 2 files changed, 15

[PATCH v1 04/12] nand: move nand_erase_opts() to core NAND folder

2023-12-28 Thread Alexey Romanov
Currently nand_erase_opts() placed in the nand/raw/ folder, because it uses the RAW NAND specific API (struct nand_chip). This patch move it to core NAND folder and make function generic, for both RAW/SPI NAND's usage. Also, nand_erase_opts() used in fastboot/fb_nand.c, cmd/nand.c and env/nand.c

[PATCH v1 03/12] nand: move nand_util.c to NAND core folder

2023-12-28 Thread Alexey Romanov
This is right place for this API. Now, fastboot code uses this API: these functions should be available regardless of the selected NAND type (RAW / SPI). Signed-off-by: Alexey Romanov --- drivers/mtd/nand/Makefile| 2 +- drivers/mtd/nand/raw/nand_util.c | 511

[PATCH v1 01/12] nand: move NAND initialization API to nand/core.c

2023-12-28 Thread Alexey Romanov
nand_register() and nand_init() is generic API for both RAW and SPI NAND's. We have to move this functions from drivers/mtd/nand/raw/nand.c to drivers/mtd/nand/core.c. Functions designed to work with RAW NAND should remain in drivers/mtd/nand/raw/nand.c. Signed-off-by: Alexey Romanov ---

[PATCH v1 00/12] Support SPI NAND in fastboot protocol

2023-12-28 Thread Alexey Romanov
Currently, fastboot in U-Boot doens't support SPI NAND devices. This patchset adds support for SPI NAND in fastboot nand subsystem. Alexey Romanov (12): nand: move NAND initialization API to nand/core.c nand: don't overwrite mtd name in nand_register() nand: move nand_util.c to NAND core

[PATCH v1 02/12] nand: don't overwrite mtd name in nand_register()

2023-12-28 Thread Alexey Romanov
We use this function in SPI NAND subsystem, which already filled mtd->name field with "spi-nand0" string. Signed-off-by: Alexey Romanov --- drivers/mtd/nand/core.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c

[PATCH v1] fastboot: introduce 'oem board' subcommand

2023-12-28 Thread Alexey Romanov
Currently, fastboot protocol in U-Boot has no opportunity to execute vendor custom code with verifed boot. This patch introduce new fastboot subcommand fastboot oem board:, which allow to run custom oem_board function. Default implementation is __weak. Vendor must redefine it in board/ folder

[PATCH v1] arch: meson: add helper for boot partitition flashing

2023-12-28 Thread Alexey Romanov
Amlogic uses its own scheme for flashing bootloader partition. This patch adds helper function that can be used by Amlogic BootROM and custom protocols. Signed-off-by: Alexey Romanov --- arch/arm/include/asm/arch-meson/nand.h | 88 arch/arm/mach-meson/Kconfig| 16

Re: [PATCH 0/9] dts: Move to SoC-specific build rules

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 03:09:40PM +, Simon Glass wrote: > Hi Tom, > > On Thu, Dec 28, 2023 at 2:23 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 01:37:07PM +, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, Dec 27, 2023 at 1:21 PM Tom Rini wrote: > > > > > > > > On Wed, Dec

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 03:09:45PM +, Simon Glass wrote: > Hi Tom, > > On Thu, Dec 28, 2023 at 1:48 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 01:37:39PM +, Simon Glass wrote: > > > Hi Tom, > > > > > > > > > On Wed, Dec 27, 2023 at 8:06 PM Tom Rini wrote: > > > > > > > > On Wed,

Re: [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-28 Thread Tom Rini
On Thu, Dec 28, 2023 at 03:09:41PM +, Simon Glass wrote: > Hi Tom, > > On Thu, Dec 28, 2023 at 1:56 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 01:37:11PM +, Simon Glass wrote: > > > Hi Sumit, > > > > > > On Thu, Dec 28, 2023 at 11:59 AM Sumit Garg wrote: > > > > > > > > Although

Re: [PATCH v3 4/9] arm: armv7: save boot arguments

2023-12-28 Thread Raymond Mao
Hi Simon, On Thu, 28 Dec 2023 at 08:37, Simon Glass wrote: > Hi Raymond, > > On Wed, Dec 27, 2023 at 3:52 PM Raymond Mao > wrote: > > > > Hi Simon, > > > > On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: > >> > >> Hi Raymond, > >> > >> On Fri, Dec 22, 2023 at 9:31 PM Raymond Mao > wrote: >

Re: [PATCH] Add imx93-var-som support

2023-12-28 Thread Fabio Estevam
[Adding Peng] On Thu, Dec 28, 2023 at 12:20 PM Fabio Estevam wrote: > > Hi Mathieu, > > On Thu, Dec 28, 2023 at 11:54 AM Mathieu Othacehe > wrote: > > > For now, I am testing the bootloaders I produce using those > > instructions: > >

Re: [PATCH] Add imx93-var-som support

2023-12-28 Thread Fabio Estevam
Hi Mathieu, On Thu, Dec 28, 2023 at 11:54 AM Mathieu Othacehe wrote: > For now, I am testing the bootloaders I produce using those > instructions: > https://variwiki.com/index.php?title=Yocto_Build_U-Boot=mx93-yocto-mickledore-6.1.36_2.1.0-v1.1 > > I understand that it would be nice to have

Re: [PATCH v3 1/9] bloblist: add API to check the register conventions

2023-12-28 Thread Raymond Mao
Hi Simon, On Thu, 28 Dec 2023 at 08:38, Simon Glass wrote: > Hi Raymond, > > On Wed, Dec 27, 2023 at 4:06 PM Raymond Mao > wrote: > > > > Hi Simon, > > > > On Tue, 26 Dec 2023 at 04:48, Simon Glass wrote: > >> > >> Hi Raymond, > >> > >> On Fri, Dec 22, 2023 at 9:31 PM Raymond Mao > wrote: >

[PATCH v2] Add imx93-var-som support

2023-12-28 Thread Mathieu Othacehe
From: Mathieu Othacehe Add support for the Variscite VAR-SOM-IMX93 evaluation kit. The SoM consists of an NXP iMX93 dual A55 CPU. The SoM is mounted on a Variscite Symphony SBC. Signed-off-by: Mathieu Othacehe --- v1: https://lists.denx.de/pipermail/u-boot/2023-December/539825.html Changes in

Re: [PATCH] Add imx93-var-som support

2023-12-28 Thread Mathieu Othacehe
Hello Fabio, Thanks for the review! > It would also be helpful to add doc/board/variscite/imx93_var_som.rst > that explains > how to build U-Boot for this board, how to get the firmware, ATF, > binaries, etc, and how to flash it to the boot medium. For now, I am testing the bootloaders I

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-28 Thread Simon Glass
Hi Tom, On Thu, Dec 28, 2023 at 1:48 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 01:37:39PM +, Simon Glass wrote: > > Hi Tom, > > > > > > On Wed, Dec 27, 2023 at 8:06 PM Tom Rini wrote: > > > > > > On Wed, Dec 27, 2023 at 05:48:42PM +, Simon Glass wrote: > > > > Hi Tom, > > > > > > >

Re: [PATCH v3 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-28 Thread Simon Glass
Hi Tom, On Thu, Dec 28, 2023 at 1:56 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 01:37:11PM +, Simon Glass wrote: > > Hi Sumit, > > > > On Thu, Dec 28, 2023 at 11:59 AM Sumit Garg wrote: > > > > > > Although there were still some variations in board DTS files based on > > > meson-gxbb

Re: [PATCH 0/9] dts: Move to SoC-specific build rules

2023-12-28 Thread Simon Glass
Hi Tom, On Thu, Dec 28, 2023 at 2:23 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 01:37:07PM +, Simon Glass wrote: > > Hi Tom, > > > > On Wed, Dec 27, 2023 at 1:21 PM Tom Rini wrote: > > > > > > On Wed, Dec 27, 2023 at 08:23:56AM +, Simon Glass wrote: > > > > > > > U-Boot builds

Re: [PATCH v4] fdt: Allow the devicetree to come from a bloblist

2023-12-28 Thread Simon Glass
Hi Ilias, On Thu, Dec 28, 2023 at 1:58 PM Ilias Apalodimas wrote: > > [...] > > > > > > > > > > > Same here. On top of that the bloblist has a few items in there, e.g a > > > > > TPM eventlog. What are we going to do? Add a Kconfig for each item? > > > > > > > > No, but that is just a straw man.

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2023-12-28 Thread Simon Glass
Hi Tom, Sumit, On Thu, Dec 28, 2023 at 2:03 PM Tom Rini wrote: > > On Thu, Dec 28, 2023 at 01:37:26PM +, Simon Glass wrote: > > Hi Sumit, > > > > On Thu, Dec 28, 2023 at 11:58 AM Sumit Garg wrote: > > > > > > Allow platform owners to mirror devicetree files from devitree-rebasing > > >

Re: I'm looking for the source code of a specific u-boot version.

2023-12-28 Thread Mario Marietto
Hello. Can someone provide the right link to download u-boot-2017.0.5 , please ? I've found it here,but I'm not sure that it's the correct version :

Re: [PATCH v4 4/7] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-12-28 Thread Mark Kettenis
> From: Simon Glass > Date: Thu, 28 Dec 2023 13:37:03 + > > Hi Ilias, > > On Wed, Dec 27, 2023 at 11:05 AM Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Wed, 27 Dec 2023 at 09:40, Simon Glass wrote: > > > > > > When the SMBIOS table is written to an address above 4GB a 32-bit

  1   2   >