Re: [PATCH 2/2] part: efi: Treat unused partition type GUID as a valid case

2024-03-28 Thread Heinrich Schuchardt
On 3/28/24 23:29, Sam Protsenko wrote: Some platforms use the "unused" (all-zero) GUID as a partition type GUID to make some partitions hidden from the OS. For example, Samsung phones and other devices often have GPT partition tables like that, created by their "gpt_builder" tool [1]. All

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Tony Dinh
Hi Michael, Hi Stefan, It seems either the Denx server or Gmail has failed to send/deliver Stefan's response to my Inbox. Luckily, I also monitored lore.kernel.org and I saw the response. So I'd like to answer that below. On Thu, Mar 28, 2024 at 12:41 AM Michael Walle wrote: > > Hi, > > On Thu

Re: [PATCH] mtd: spi-nor: Add support to exit 4-byte mode

2024-03-28 Thread Greg Malysa
Hi Tejas, + Ian Roberts, my coworker has the following comments: I do not think it is appropriate to put what appears to be use-case specific logic into the core functionality. Your problem statement sounds like the chip is stuck in a stateful mode after a reset. As alternatives, I would

Re: [PATCH 1/2] part: Check all partitions in part_get_info_by_name()

2024-03-28 Thread Heinrich Schuchardt
On 3/28/24 23:29, Sam Protsenko wrote: In part_get_info_by_name() the inability to get some partition info shouldn't be a reason for dropping out of the loop. That might happen e.g. if the partition is hidden or unused. An example of such case are Samsung devices, where they use the "unused"

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-28 Thread Chris Morgan
On Thu, Mar 28, 2024 at 04:02:09PM -0400, Tom Rini wrote: > On Wed, Mar 27, 2024 at 10:03:11AM -0500, Chris Morgan wrote: > > On Wed, Mar 27, 2024 at 04:21:49PM +0200, Eugen Hristev wrote: > > > On 3/27/24 15:32, Chris Morgan wrote: > > > > On Wed, Mar 27, 2024 at 06:32:06PM +0800, Kever Yang

[PATCH 2/2] part: efi: Treat unused partition type GUID as a valid case

2024-03-28 Thread Sam Protsenko
Some platforms use the "unused" (all-zero) GUID as a partition type GUID to make some partitions hidden from the OS. For example, Samsung phones and other devices often have GPT partition tables like that, created by their "gpt_builder" tool [1]. All partitions with FILESYS=0 value (second column

[PATCH 1/2] part: Check all partitions in part_get_info_by_name()

2024-03-28 Thread Sam Protsenko
In part_get_info_by_name() the inability to get some partition info shouldn't be a reason for dropping out of the loop. That might happen e.g. if the partition is hidden or unused. An example of such case are Samsung devices, where they use the "unused" GUID type

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-28 Thread Tom Rini
On Thu, Mar 28, 2024 at 04:58:53PM -0500, Chris Morgan wrote: > On Thu, Mar 28, 2024 at 04:02:09PM -0400, Tom Rini wrote: > > On Wed, Mar 27, 2024 at 10:03:11AM -0500, Chris Morgan wrote: > > > On Wed, Mar 27, 2024 at 04:21:49PM +0200, Eugen Hristev wrote: > > > > On 3/27/24 15:32, Chris Morgan

[PATCH 1/1] riscv: starfive: MMC card detect

2024-03-28 Thread Heinrich Schuchardt
The VisionFive 2 board uses GPIO 41 as card detect as documented in https://doc-en.rvspace.org/VisionFive2/PDF/SCH_RV002_V1.2A_20221216.pdf. Signed-off-by: Heinrich Schuchardt --- arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Upcoming Analog Devices SoC Support Submission

2024-03-28 Thread Tom Rini
On Mon, Mar 25, 2024 at 10:47:30PM -0400, Greg Malysa wrote: > Hi Tom, > > I wanted to get a little bit of guidance before dumping some patches > on the mailing list. I've been preparing to submit support we've > developed for the Analog Devices SC5xx SoCs including both core SoC > support and

Re: [PATCH v10 2/2] dt-bindings: mtd: fixed-partition: Add binman compatibles

2024-03-28 Thread Rob Herring
On Tue, 26 Mar 2024 14:06:45 -0600, Simon Glass wrote: > Add two compatibles for binman entries, as a starting point for the > schema. > > Note that, after discussion on v2, we decided to keep the existing > meaning of label so as not to require changes to existing userspace > software when

[PATCH 1/1] doc: missing :: in doc/usage/cmd/itest.rst

2024-03-28 Thread Heinrich Schuchardt
Add :: for correct formatting of example. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/itest.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/usage/cmd/itest.rst b/doc/usage/cmd/itest.rst index ab933db760d..9c307fb4bf4 100644 --- a/doc/usage/cmd/itest.rst +++

Re: Pull request doc-2024-04-rc6

2024-03-28 Thread Tom Rini
On Thu, Mar 28, 2024 at 08:56:54PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit dde373bde392c38649c8c4420e0c98ef8d38d9dc: > > Prepare v2024.04-rc5 (2024-03-25 21:56:50 -0400) > > are available in the Git repository at: > >

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-28 Thread Tom Rini
On Wed, Mar 27, 2024 at 10:03:11AM -0500, Chris Morgan wrote: > On Wed, Mar 27, 2024 at 04:21:49PM +0200, Eugen Hristev wrote: > > On 3/27/24 15:32, Chris Morgan wrote: > > > On Wed, Mar 27, 2024 at 06:32:06PM +0800, Kever Yang wrote: > > >> Hi Chris, > > >> > > >>     The ATAGS is used for

Re: [PATCH 0/4] zlib: Address CVE-2016-9841

2024-03-28 Thread Tom Rini
On Wed, Mar 27, 2024 at 03:14:49PM +0100, Michal Simek wrote: > Hi, > > it looks like that only CVE-2016-9841 is not fixed and this series is > trying to address it. The first two patches are just preparation based on > changes which happened in past. The third one is actual fix and the last >

Pull request doc-2024-04-rc6

2024-03-28 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit dde373bde392c38649c8c4420e0c98ef8d38d9dc: Prepare v2024.04-rc5 (2024-03-25 21:56:50 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/doc-2024-04-rc6 for you to fetch changes up to

[PATCH] imx8mq_evk: Remove FEC and Ethernet PHY board code

2024-03-28 Thread Fabio Estevam
With Ethernet DM in place, there is no longer the need for having the board_phy_config() and setup_fec() functions anymore. Remove them. Successfully tested a TFTP transfer after these changes. Signed-off-by: Fabio Estevam --- board/freescale/imx8mq_evk/imx8mq_evk.c | 30

[PATCH v5 16/16] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-28 Thread Caleb Connolly
The patch introducing support for dynamic sector sizes changed the types used in some divisions, resulting in the compiler attempting to use libgcc helpers (__aeabi_ldivmod). Replace these divisions with calls to lldiv() to handle this correctly. Fixes: 74e56e0c5065 ("usb: gadget: UMS: support

[PATCH v5 15/16] qcom_defconfig: enable USB

2024-03-28 Thread Caleb Connolly
Enable support for the DWC3 USB controller and required dependencies for Qualcomm boards, specifically the DB845c: * IOMMU / SMMU * USB high-speed PHYs * Mass storage and ACM gadgets Signed-off-by: Caleb Connolly --- configs/qcom_defconfig | 52 --

[PATCH v5 14/16] qcom_defconfig: enable livetree

2024-03-28 Thread Caleb Connolly
Qualcomm FDTs are on the larger size, and with the addition of DT modifications during board_init() it makes sense to enable OF_LIVE globally. The cost of building the tree should be offset by the increased efficiency at which we can walk it. Some rough measurements with CONFIG_BOOTSTAGE suggests

[PATCH v5 13/16] dts: sdm845-db845c: add u-boot fixups

2024-03-28 Thread Caleb Connolly
The USB VBUS supply for the type-A port is enabled via a GPIO regulator. This is incorrectly modelled in Linux where only the PCIe dependency is expressed. The correct way to handle this will be through a usb-connector node, but for now we'll just mark the regulator as always-on so that it will be

[PATCH v5 12/16] mach-snapdragon: call regulators_enable_boot_on()

2024-03-28 Thread Caleb Connolly
Make sure we power on any boot-on or always-on regulators. These are used for peripherals like USB on some platforms. Signed-off-by: Caleb Connolly --- arch/arm/mach-snapdragon/board.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-snapdragon/board.c

[PATCH v5 11/16] mach-snapdragon: fixup power-domains

2024-03-28 Thread Caleb Connolly
We don't support the RPM(h)PD power domains in U-Boot, and we don't need to - the necessary resources are on, and we aren't going to enter any low power modes. We could try using a no-op device, but this requires adding a compatible for every platform, and just pollutes the driver model. So

[PATCH v5 10/16] mach-snapdragon: fixup USB nodes

2024-03-28 Thread Caleb Connolly
We don't support USB super-speed in U-Boot yet, we lack the SS PHY drivers, however from my testing even with a PHY driver there seem to be other issues when talking to super-speed peripherals. In pursuit of maintaining upstream DT compatibility, and simplifying porting for new devices, let's

[PATCH v5 08/16] gpio: msm_gpio: add .set_flags op

2024-03-28 Thread Caleb Connolly
The .direction_input and .direction_output ops are deprecated, and don't seem to behave properly for us. Implement our own .set_flags op to handle this correctly. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/gpio/msm_gpio.c | 27 +-- 1 file changed,

[PATCH v5 09/16] serial: msm-geni: support livetree

2024-03-28 Thread Caleb Connolly
When using OF_LIVE, the debug UART driver won't be probed if it's a subnode of the geni-se-qup controller. Add a NOP driver for the controller to correctly discover its child nodes. Reviewed-by: Neil Armstrong Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly ---

[PATCH v5 06/16] clk/qcom: sdm845: add gdscs

2024-03-28 Thread Caleb Connolly
Define the GDSC power domains for SDM845. Reviewed-by: Neil Armstrong Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-sdm845.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/clk/qcom/clock-sdm845.c

[PATCH v5 07/16] clk/qcom: sdm845: add USB clocks

2024-03-28 Thread Caleb Connolly
Most devices only initialise the USB clocks for us if we boot via "fastboot boot", add the missing clock configuration to get both USB ports working regardless of the bootloader state. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-sdm845.c | 25

[PATCH v5 05/16] clk/qcom: use offsets for RCG registers

2024-03-28 Thread Caleb Connolly
The RCG registers always have the same offsets, so only store the base CMD register address and calculate the others relative to that. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-apq8016.c | 39 + drivers/clk/qcom/clock-apq8096.c | 28

[PATCH v5 04/16] mach-snapdragon: disable power-domains for pre-reloc drivers

2024-03-28 Thread Caleb Connolly
Some devices like the UART and clock controller reference an RPM(h) power domain. We don't support this device in U-Boot, so add DM_FLAG_DEFAULT_PD_CTRL_OFF to tell DM core not to try and enable the power domain. Reviewed-by: Sumit Garg Signed-off-by: Caleb Connolly ---

[PATCH v5 03/16] phy: qcom: Add SNPS femto v2 USB HS phy

2024-03-28 Thread Caleb Connolly
From: Bhupesh Sharma Some Qualcomm SoCs newer than SDM845 feature a so-called "7nm phy" driver, notable the SM8250 SoC which will gain U-Boot support in upcoming patches. Introduce a driver based on the Linux driver. Signed-off-by: Bhupesh Sharma [code cleanup, align symbol names with Linux,

[PATCH v5 02/16] phy: qcom: add Qualcomm QUSB2 USB PHY driver

2024-03-28 Thread Caleb Connolly
From: Bhupesh Sharma The Snapdragon 845 and several other Qualcomm SoCs feature this USB high-speed phy. Add a driver for it based on the Linux driver, with support for the SDM845, and the QCM2290 and SM6115 SoCs which will gain support in U-Boot in future patches. Signed-off-by: Bhupesh Sharma

[PATCH v5 01/16] mailmap: update Bhupesh's email address

2024-03-28 Thread Caleb Connolly
Update Bhupesh's email to his new one. Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- Cc: Bhupesh Sharma --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index d1f08f3eca8a..f6e0847b2168 100644 --- a/.mailmap +++ b/.mailmap @@ -29,8 +29,9 @@

[PATCH v5 00/16] Qualcomm platform USB support

2024-03-28 Thread Caleb Connolly
This series enables USB on Qualcomm SDM845 platforms and lays the foundation for future SoCs as well. It introduces two new high-speed PHY drivers, one for SDM845 and one for an upcoming platform. The SDM845 clock driver gains support for configuring the USB clocks, and the GPIO driver is updated

[PATCH v2] tpm-v2: allow algoirthm name to be configured for pcr_read and pcr_extend

2024-03-28 Thread Tim Harvey
For pcr_read and pcr_extend commands allow the digest algorithm to be specified by an additional argument. If not specified it will default to SHA256 for backwards compatibility. A follow-on to this could be to extend all PCR banks with the detected algo when the argument is 'auto'.

Re: [PATCH 2/6] arm: xea: Add support for reading SoM (CPU) and base board HW revision

2024-03-28 Thread Fabio Estevam
Hi Lukasz, On Thu, Mar 28, 2024 at 12:34 PM Lukasz Majewski wrote: > +static inline u8 get_som_rev(void) There is no need for 'inline' here. Also, get_som_rev() is only used 5/6, so I suggest to squash this patch with 5/6. Besides that, the series looks good.

Re: [PATCH] tpm-v2: allow algo name to be conigured for pcr_read and pcr_extend

2024-03-28 Thread Ilias Apalodimas
On Thu, 28 Mar 2024 at 17:33, Tim Harvey wrote: > > On Thu, Mar 28, 2024 at 12:37 AM Ilias Apalodimas > wrote: > > > > Hi Tim, > > > > [...] > > > > > > > > +/** > > > + * tpm2_algo_len() - Return an algo value and length given a algorithm > > > name > > > + * > > > + * @name: algorithm name >

Re: [PATCH v2 4/6] board: starfive: support Milk-V Mars board

2024-03-28 Thread Heinrich Schuchardt
On 24.03.24 16:00, Aurelien Jarno wrote: On 2024-03-21 19:11, Heinrich Schuchardt wrote: The differences between the Milk-V Mars board and the VisionFive 2 board are small enough that we can support both using the same U-Boot build. * The model and compatible property are taken from proposed

Re: [PATCH] net: phy: ncsi: reslove the unaligned access issue

2024-03-28 Thread Marek Vasut
On 3/28/24 4:08 PM, Tom Rini wrote: On Mon, Feb 05, 2024 at 04:13:23PM +0800, Jacky Chou wrote: From the ethernet header is not on aligned, because the length of the ethernet header is 14 bytes. Therefore, unaligned access must be done here. Signed-off-by: Jacky Chou Applied to

[PATCH] mtd: spi-nor: Add support to exit 4-byte mode

2024-03-28 Thread Tejas Bhumkar
The Kria board features a recovery application that activates when the FW_EN button is pressed. Upon power-up flash operates in 3B mode, However, the recovery application changes it back to 4B mode. Following a reset, u-boot activates the CONFIG_SPI_FLASH_BAR and expects the flash to be in 3B

[PATCH 6/6] config: xea: Add limits for SPL and u-boot proper sizes

2024-03-28 Thread Lukasz Majewski
The XEA board has following hard constraints regarding size of binaries: - u-boot.sb < 48 KiB - u-boot.img < 448 KiB Added values are supposed to avoid exceeding size of binaries during future u-boot development. Signed-off-by: Lukasz Majewski --- configs/imx28_xea_defconfig | 3 +++ 1 file

[PATCH 5/6] arm: xea: Print information about XEA's SoM HW revision

2024-03-28 Thread Lukasz Majewski
As now XEA has its second HW revision - this information is printed when u-boot proper starts. Signed-off-by: Lukasz Majewski --- board/liebherr/xea/xea.c | 9 + 1 file changed, 9 insertions(+) diff --git a/board/liebherr/xea/xea.c b/board/liebherr/xea/xea.c index

[PATCH 4/6] config: xea: Enable late board initialization to set revision variable

2024-03-28 Thread Lukasz Majewski
The 'board_som_rev' environment variable will be used to point correct configuration from the Linux FIT file. Signed-off-by: Lukasz Majewski --- board/liebherr/xea/xea.c | 12 configs/imx28_xea_defconfig| 1 + configs/imx28_xea_sb_defconfig | 1 + 3 files changed, 14

[PATCH 3/6] arm: spl: Add definition for PHY reset GPIO for XEA HW rev. 2

2024-03-28 Thread Lukasz Majewski
The imx287 based XEA board's revision 2 uses GPIO_3_21 for PHY reset It is safe to keep the GPIO_2_13 as well, as in the SPL SPI1 is not used for transmission. This simplifies the code, as the proper configuration is performed either in falcon boot's read DTB or in u-boot proper (with correct FIT

[PATCH 2/6] arm: xea: Add support for reading SoM (CPU) and base board HW revision

2024-03-28 Thread Lukasz Majewski
The XEA board now has several HW revisions for both SoM and base boards. This patch provides support for reading those revision ID values in SPL (u-boot.sb) and then pass this information to u-boot proper, as the maximal SPL size (~55KiB) is not allowing for having FIT support in it. It was

[PATCH 1/6] arm: spl: xea: Remove I2S pins configuration from early initialization

2024-03-28 Thread Lukasz Majewski
XEA is not supporting and using I2S codec, so there is no need to configure pins for it. Signed-off-by: Lukasz Majewski --- board/liebherr/xea/spl_xea.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/board/liebherr/xea/spl_xea.c b/board/liebherr/xea/spl_xea.c index

[PATCH 0/6] arm: xea: Provide enhancements for XEA board

2024-03-28 Thread Lukasz Majewski
This patch series is a preparatory patch for supporting different versions of XEA board HW (until problem with Linux kernel support for multiple revisions is resorted). Moreover, limits for u-boot.sb and u-boot.img has been set to avoid binary sizes exceeding in the future. Lukasz Majewski

Re: [PATCH] tpm-v2: allow algo name to be conigured for pcr_read and pcr_extend

2024-03-28 Thread Tim Harvey
On Thu, Mar 28, 2024 at 12:37 AM Ilias Apalodimas wrote: > > Hi Tim, > > [...] > > > > > +/** > > + * tpm2_algo_len() - Return an algo value and length given a algorithm name > > + * > > + * @name: algorithm name > > + * @rwlen: pointer to integer to populate with algorithm length if non-null > >

Re: [PATCH 2/5] configs/am62x_beagleplay_a53_defconfig: enable DM_ETH_PHY

2024-03-28 Thread Tom Rini
On Tue, Mar 05, 2024 at 03:24:54PM +0200, Roger Quadros wrote: > Reset GPIO handling is done in ETH PHY Class driver. > Enable DM_ETH_PHY. > > We don't use Fixed PHY so disable PHY_FIXED. > > Signed-off-by: Roger Quadros Applied to u-boot/next, thanks! -- Tom signature.asc Description:

Re: [PATCH 1/5] net: mdio-uclass: Bind and probe generic Ethernet PHY driver

2024-03-28 Thread Tom Rini
On Tue, Mar 05, 2024 at 03:24:53PM +0200, Roger Quadros wrote: > If DM_ETH_PHY is enabled then try to bind and probe the > generic Ethernet PHY driver for each child of MDIO bus. > > This is to ensure that GPIO reset handling is done if available > before MDIO bus driver scans for the PHYs. > >

Re: [PATCH] e1000: add support for i225-IT

2024-03-28 Thread Tom Rini
On Mon, Mar 04, 2024 at 04:23:38PM +0100, Marjolaine Amate wrote: > This patch adds support for i225-IT in e1000 driver. > Add e1000_phy_igc. > > Signed-off-by: Marjolaine Amate Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 1/5] net: hifemac_mdio: use log_msg_ret() correctly, report error by dev_err()

2024-03-28 Thread Tom Rini
On Mon, Jan 22, 2024 at 10:33:20PM +0800, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > The initial commit used log_msg_ret() wrongly. Fix that by moving error > report to a separate dev_err() call and shrink the first argument of > log_msg_ret() to no more than 4 chars. > > Fixes:

Re: [PATCH] net: phy: the NC-SI phy device do not require mdio bus

2024-03-28 Thread Tom Rini
On Mon, Jan 15, 2024 at 06:34:47PM +0800, Jacky Chou wrote: > As with fixed-link phy device, the NC-SI phy devive does not > require an mdio bus. So, a condition is added to check the > NC-SI phy id to avoid accessing the bus pointer that is NULL. > > Signed-off-by: Jacky Chou Applied to

Re: [PATCH 1/1] net: phy: Fix signed shift overflow

2024-03-28 Thread Tom Rini
On Thu, Jan 04, 2024 at 05:26:23AM +0100, Heinrich Schuchardt wrote: > From: Eugeniu Rosca > > Booting R-Car Gen3 arm64 U-Boot with CONFIG_UBSAN=y resulted in: > > = > UBSAN: Undefined behaviour in

Re: [PATCH] net: phy: broadcom: Configure LEDs on BCM54210E

2024-03-28 Thread Tom Rini
On Mon, Jan 01, 2024 at 10:07:47PM +0100, Marek Vasut wrote: > Configure LEDs on BCM54210E so they would blink on activity > and indicate link speed. Without this the LEDs are always on > if cable is plugged in. > > Signed-off-by: Marek Vasut Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v3] net: phy: Factor out PHY GPIO reset code

2024-03-28 Thread Tom Rini
On Mon, Mar 18, 2024 at 03:57:01PM +0100, Marek Vasut wrote: > Pull the PHY GPIO reset code into separate function, since > this is and will be reused multiple times. Set up default > reset assert and deassert timing to generous 20ms and 1ms > for maximum compatibility in case those DT properties

Re: [PATCH] net: phy: ncsi: reslove the unaligned access issue

2024-03-28 Thread Tom Rini
On Mon, Feb 05, 2024 at 04:13:23PM +0800, Jacky Chou wrote: > From the ethernet header is not on aligned, because the length > of the ethernet header is 14 bytes. > Therefore, unaligned access must be done here. > > Signed-off-by: Jacky Chou Applied to u-boot/next, thanks! -- Tom

Re: [PATCH] net: phy: ncsi: Correct the endian of the checksum

2024-03-28 Thread Tom Rini
On Mon, Feb 05, 2024 at 04:02:28PM +0800, Jacky Chou wrote: > There is no need to perform the endian twice here. > > Signed-off-by: Jacky Chou > Reviewed-by: Dan Carpenter Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] net: phy: ncsi: fixed not nullify the pointers after free

2024-03-28 Thread Tom Rini
On Fri, Dec 29, 2023 at 09:45:55AM +0800, Jacky Chou wrote: > The issue occurs the UAF (use-after-free) to cause double free > when do the realloc function for the pointers during the > reinitialization NC-SI process, and it will cause the memory > management occurs error. > So, nullify these

Re: [NEXT] Pull request acpi-next-20240328

2024-03-28 Thread Tom Rini
tory at: > > https://source.denx.de/u-boot/custodians/u-boot-efi.git > tags/acpi-next-20240328 > > for you to fetch changes up to 6eca28b61af1835e70a6feb86f86a0b18b1708c6: > > smbios: fill wake-up type (2024-03-27 09:23:30 +0100) > > Gitlab CI showed no issues: >

Re: [RFC] Makefile.lib: find capsule ESL dtsi file when CONFIG_OF_UPSTREAM=y

2024-03-28 Thread Sughosh Ganu
On Thu, 28 Mar 2024 at 09:34, Jon Humphreys wrote: > > Sughosh Ganu writes: > > > hi Jonathan, > > > > On Wed, 27 Mar 2024 at 08:05, Jonathan Humphreys wrote: > >> > >> When CONFIG_OF_UPSTREAM is enabled, DTS files are in SOC subdirectories > >> (vs the > >> top level dts directory), but when

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Marek Behún
On Thu, 28 Mar 2024 14:01:22 +0100 Stefan Roese wrote: > On 3/28/24 12:21, Marek Behún wrote: > > On Thu, 28 Mar 2024 11:04:45 +0100 > > Stefan Roese wrote: > > > >>> +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t > >>> type) > >>> +{ > >>> + struct regmap *regmap =

Re: [PATCH v4 0/5] imx93: Conver to OF_UPSTREAM

2024-03-28 Thread Mathieu Othacehe
Hello, > Mathieu: please help test the boards you maintain when you have time. I have tried both imx93_var_som and imx93-phyboard-segin configurations. Compilation works but I only get garbage on the UART on those two different boards. I will try to conduct further investigations later on,

Re: [PATCH] mx6cuboxi: Do not print devicetree model

2024-03-28 Thread Fabio Estevam
Hi Christian, On Thu, Mar 28, 2024 at 4:18 AM Christian Gmeiner wrote: > This is not what this patch is doing. show_board_info() is the only > caller of checkboard() > so we end with the following output: You're right. The attached patch should do what we want. From

[PATCH] usb: dwc2: update reset method for host and device mode

2024-03-28 Thread Kongyang Liu
Starting from version 4.20a, there has been a change in the reset method. A new bit, GRSTCTL_CSFTRST_DONE, has been introduced in the GRSTCTL register to indicate whether the reset has been completed. Signed-off-by: Kongyang Liu --- drivers/usb/gadget/dwc2_udc_otg.c | 18

Re: [PATCH] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-03-28 Thread Fabio Estevam
Hi Josua, On Thu, Mar 28, 2024 at 10:03 AM Josua Mayer wrote: > I suggest changing their status to disabled, and keeping the nodes. > >> + > >> +phy: ethernet-phy@0 { > > This node name is shared with upstream imx6qdl-sr-som.dtsi > Give this one a u-boot-only internal name, maybe

Re: [PATCH] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-03-28 Thread Josua Mayer
Am 28.03.24 um 13:51 schrieb Josua Mayer: > Am 28.03.24 um 13:21 schrieb Fabio Estevam: >> From: Josua Mayer >> >> The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying >> addresses. U-Boot needs to auto-detect which phy is actually present, >> and at which address it is

Re: Thoughts about U-boot binary size increase

2024-03-28 Thread Lukasz Majewski
Hi Tom, > On Thu, Mar 28, 2024 at 01:55:22PM +0100, Lukasz Majewski wrote: > > Hi Tom, > > > > > On Thu, Mar 28, 2024 at 10:20:49AM +0100, Lukasz Majewski wrote: > > > > Dear Community, > > > > > > > > I'd like to share with you some thoughts about growth of > > > > u-boot's binary size for

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Stefan Roese
On 3/28/24 12:21, Marek Behún wrote: On Thu, 28 Mar 2024 11:04:45 +0100 Stefan Roese wrote: +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type) +{ + struct regmap *regmap = syscon_get_regmap(dev->parent); + uint bit; + + if (type != SYSRESET_COLD) +

Re: Thoughts about U-boot binary size increase

2024-03-28 Thread Tom Rini
On Thu, Mar 28, 2024 at 01:55:22PM +0100, Lukasz Majewski wrote: > Hi Tom, > > > On Thu, Mar 28, 2024 at 10:20:49AM +0100, Lukasz Majewski wrote: > > > Dear Community, > > > > > > I'd like to share with you some thoughts about growth of u-boot's > > > binary size for SPL and u-boot proper. > > >

Re: Thoughts about U-boot binary size increase

2024-03-28 Thread Lukasz Majewski
Hi Tom, > On Thu, Mar 28, 2024 at 10:20:49AM +0100, Lukasz Majewski wrote: > > Dear Community, > > > > I'd like to share with you some thoughts about growth of u-boot's > > binary size for SPL and u-boot proper. > > > > Board: XEA > > SoC : imx287 (still in active production) > > Problem: SPL

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Stefan Roese
On 3/28/24 12:17, Marek Behún wrote: On Thu, 28 Mar 2024 10:56:01 +0100 Stefan Roese wrote: On 3/27/24 17:23, Marek Behún wrote: Implement reading board serial number, first MAC address and board version from MCU. MCU supports board information if the FEAT_BOARD_INFO feature bit is set in

Re: Thoughts about U-boot binary size increase

2024-03-28 Thread Lukasz Majewski
Hi Fabio, > Hi Lukasz, > > On Thu, Mar 28, 2024 at 6:20 AM Lukasz Majewski wrote: > > > > Dear Community, > > > > I'd like to share with you some thoughts about growth of u-boot's > > binary size for SPL and u-boot proper. > > > > Board: XEA > > SoC : imx287 (still in active production) > >

Re: [PATCH] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-03-28 Thread Josua Mayer
Am 28.03.24 um 13:21 schrieb Fabio Estevam: > From: Josua Mayer > > The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying > addresses. U-Boot needs to auto-detect which phy is actually present, > and at which address it is responding. > > Auto-detection from multiple phy nodes

[PATCH] mx6cuboxi: Fix Ethernet after DT sync with Linux

2024-03-28 Thread Fabio Estevam
From: Josua Mayer The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying addresses. U-Boot needs to auto-detect which phy is actually present, and at which address it is responding. Auto-detection from multiple phy nodes specified in device-tree does not currently work correct.

Re: Thoughts about U-boot binary size increase

2024-03-28 Thread Fabio Estevam
Hi Lukasz, On Thu, Mar 28, 2024 at 6:20 AM Lukasz Majewski wrote: > > Dear Community, > > I'd like to share with you some thoughts about growth of u-boot's > binary size for SPL and u-boot proper. > > Board: XEA > SoC : imx287 (still in active production) > Problem: SPL size constrained to ~55

Re: Thoughts about U-boot binary size increase

2024-03-28 Thread Tom Rini
On Thu, Mar 28, 2024 at 10:20:49AM +0100, Lukasz Majewski wrote: > Dear Community, > > I'd like to share with you some thoughts about growth of u-boot's > binary size for SPL and u-boot proper. > > Board: XEA > SoC : imx287 (still in active production) > Problem: SPL size constrained to ~55 KiB

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Nishanth Menon
On 11:53-20240328, Sverdlin, Alexander wrote: [..] > > Btw, this no longer applies on next. only applies on master. Depending > > on where Tom would like to apply this change, might need a rebase. > > Thanks for the hint! I've totally missed this! > And I'm even not sure

Re: [PATCH v2] riscv: Move virtio scan to board_late_init()

2024-03-28 Thread Leo Liang
On Thu, Mar 28, 2024 at 10:58:24AM +0100, Łukasz Stelmach wrote: > [EXTERNAL MAIL] > > When virtio_init() gets called from board_init() PCI isn't ready. Thus, > virtio-over-PCI (e.g. network interfaces) devices can't be detected and > used without additional `virtio scan` scan in the shell or a

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-28 Thread Michael Walle
Hi, On Thu Mar 28, 2024 at 12:18 PM CET, Neha Malcom Francis wrote: > On 27-Mar-24 8:03 PM, Michael Walle wrote: > > On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: > >> On 26/03/24 19:18, Michael Walle wrote: > >>> On Fri Mar 22, 2024 at 2:10 PM CET, Neha Malcom Francis wrote: >

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Sverdlin, Alexander
Hi Nishanth! On Thu, 2024-03-28 at 06:45 -0500, Nishanth Menon wrote: > On 07:29-20240328, A. Sverdlin wrote: > > From: Alexander Sverdlin > > > > am65_cpsw_ofdata_parse_phy() tries to handle the case when PHY is not > > specified in DT gracefully: > >

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Nishanth Menon
On 07:29-20240328, A. Sverdlin wrote: > From: Alexander Sverdlin > > am65_cpsw_ofdata_parse_phy() tries to handle the case when PHY is not > specified in DT gracefully: > > am65_cpsw_nuss_port ethernet@800port@1: can't parse phy-handle port 1 (-2) > > am65_

[PATCH v1] arm: mach-k3: common: EFI loader map memory below ram top

2024-03-28 Thread Vitor Soares
From: Vitor Soares During the boot, the EFI loader maps the memory from ram_top to ram_end as EFI_BOOT_SERVICES_DATA. When LMB does boot_fdt_add_mem_rsv_regions() to OPTEE, TFA, R5, and M4F DMA/memory "no-map" for the kernel it produces the following error message: ERROR: reserving fdt memory

[PATCH v2] riscv: Move virtio scan to board_late_init()

2024-03-28 Thread Łukasz Stelmach
When virtio_init() gets called from board_init() PCI isn't ready. Thus, virtio-over-PCI (e.g. network interfaces) devices can't be detected and used without additional `virtio scan` scan in the shell or a script. Signed-off-by: Łukasz Stelmach --- Changes since v1: - remove virtio_init() call

Re: [PATCH] mx6cuboxi: Do not print devicetree model

2024-03-28 Thread Christian Gmeiner
Hi Fabio > The mx6cuboxi_defconfig target supports several board > variants. All of these variants use the hummingboard devicetree in U-Boot. > > Currently, the devicetree model as well as the board variant name > are shown: > > U-Boot 2024.04-rc5-3-g774ec4fda8 (Mar 27 2024 - 16:48:35

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Siddharth Vadapalli
On Thu, Mar 28, 2024 at 07:29:10AM +0100, A. Sverdlin wrote: > From: Alexander Sverdlin > > am65_cpsw_ofdata_parse_phy() tries to handle the case when PHY is not > specified in DT gracefully: > > am65_cpsw_nuss_port ethernet@800port@1: can't parse phy-handle port 1 (-2) > >

[PATCH v1 1/1] [U-Boot] drivers: misc: Fixes: Rename CONFIG_SPL_SOCFPGA_SEC_REG to CONFIG_SPL_SOCFPGA_DT_REG

2024-03-28 Thread wan . yee . lau
From: Wan Yee Lau Commit 3f190c55a4211215914126b74357344342329943 ("drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA") This commit rename CONFIG_SPL_SOCFPGA_SEC_REG to CONFIG_SPL_SOCFPGA_DT_REG in Makefile. Signed-off-by: Wan Yee Lau --- drivers/misc/Makefile | 2 +- 1 file changed,

Re: [PATCH] net: ti: am65-cpsw-nuss: Don't crash in am65_cpsw_phy_init()

2024-03-28 Thread Siddharth Vadapalli
On Wed, Mar 27, 2024 at 06:09:40PM +0100, A. Sverdlin wrote: > From: Alexander Sverdlin In the $subject, "Don't crash.." seems to indicate the consequence of not handling the absence of PHYs gracefully within am65_cpsw_phy_init(). So the subject should probably be reworded to emphasize this

[PATCH v4 5/5] imx93: convert to OF_UPSTREAM

2024-03-28 Thread Peng Fan (OSS)
From: Peng Fan Convert all i.MX93 boards to OF_UPSTREAM. Add lpi2c2 nodes for imx93-11x11-evk-u-boot.dtsi. Add usbotg1 nodes in imx93-u-boot.dtsi and board u-boot.dtsi. The nodes could be removed after upstream linux supports them. Signed-off-by: Peng Fan --- arch/arm/dts/Makefile

Re: [RFC] Makefile.lib: find capsule ESL dtsi file when CONFIG_OF_UPSTREAM=y

2024-03-28 Thread Jon Humphreys
Sughosh Ganu writes: > hi Jonathan, > > On Wed, 27 Mar 2024 at 08:05, Jonathan Humphreys wrote: >> >> When CONFIG_OF_UPSTREAM is enabled, DTS files are in SOC subdirectories (vs >> the >> top level dts directory), but when CONFIG_EFI_CAPSULE_AUTHENTICATE is >> enabled, >> the dynamically

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Marek Behún
On Thu, 28 Mar 2024 11:04:45 +0100 Stefan Roese wrote: > > +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t > > type) > > +{ > > + struct regmap *regmap = syscon_get_regmap(dev->parent); > > + uint bit; > > + > > + if (type != SYSRESET_COLD) > > + return

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-28 Thread Neha Malcom Francis
Hi Michael On 27-Mar-24 8:03 PM, Michael Walle wrote: Hi, On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: On 26/03/24 19:18, Michael Walle wrote: On Fri Mar 22, 2024 at 2:10 PM CET, Neha Malcom Francis wrote: Clean up templatized boot binaries for all K3 boards. This includes

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Marek Behún
On Thu, 28 Mar 2024 10:56:01 +0100 Stefan Roese wrote: > On 3/27/24 17:23, Marek Behún wrote: > > Implement reading board serial number, first MAC address and board > > version from MCU. MCU supports board information if the FEAT_BOARD_INFO > > feature bit is set in MCU features. > > > > Prefer

[PATCH] net: fec_mxc: Avoid enable regulator failure

2024-03-28 Thread Ye Li
Change to regulator_set_enable_if_allowed to avoid enable failure, in case same phy supply shared by multiple FEC controllers. Signed-off-by: Ye Li --- drivers/net/fec_mxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index

[PATCH] arm: imx: Fix incorrect return value

2024-03-28 Thread Ye Li
The spl_spi_get_uboot_offs weak function is defined unsigned int. Signed-off-by: Ye Li --- arch/arm/mach-imx/image-container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/image-container.c b/arch/arm/mach-imx/image-container.c index c9455fe..35da0ae

[PATCH] thermal: imx_tmu: Fix TMU error on iMX8MQ

2024-03-28 Thread Ye Li
imx_tmu_arch_init does not implement for iMX8MQ, error is returned Signed-off-by: Ye Li --- drivers/thermal/imx_tmu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thermal/imx_tmu.c b/drivers/thermal/imx_tmu.c index 4721cfb..ca775e5 100644 --- a/drivers/thermal/imx_tmu.c +++

[PATCH] arm: imx9: Fix MMU map table overlap

2024-03-28 Thread Ye Li
The size for flexspi AHB buffer space is wrong, so correct it. Signed-off-by: Ye Li --- arch/arm/mach-imx/imx9/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/imx9/soc.c b/arch/arm/mach-imx/imx9/soc.c index 15e87b8..2117489 100644 ---

[PATCH 2/2] arm: imx9: Call imx9_probe_mu for DM post in board_r

2024-03-28 Thread Ye Li
This event callback imx9_probe_mu needs to be called in board_r as well, because many ELE APIs depending on this MU probed Signed-off-by: Ye Li --- arch/arm/mach-imx/imx9/soc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/imx9/soc.c b/arch/arm/mach-imx/imx9/soc.c index

[PATCH 1/2] arm: imx9: Correct imx9_probe_mu prototype

2024-03-28 Thread Ye Li
Since the event callback imx9_probe_mu is re-defined, update its prototype. Signed-off-by: Ye Li --- arch/arm/include/asm/arch-imx9/mu.h | 2 +- board/freescale/imx93_evk/spl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/arch-imx9/mu.h

[PATCH v2 3/3] configs: colibri-imx7: allow accessing job-rings from non-TrustZone

2024-03-28 Thread Emanuele Ghidoli
From: Emanuele Ghidoli Set FSL_CAAM_JR_NTZ_ACCESS configuration since colibri-imx7 uses Freescale CAAM Job Ring linux driver Signed-off-by: Emanuele Ghidoli --- configs/colibri_imx7_defconfig | 1 + configs/colibri_imx7_emmc_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git

  1   2   >