[PATCH v5 4/4] fs: remove explicit efi configuration dependency

2024-01-16 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- fs/fs.c | 7 +++ 1 file changed, 3

[PATCH v5 3/4] net: tftp: remove explicit efi configuration dependency

2024-01-16 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro Reviewed-by: Ramon Fried Reviewed-by: Tom Rini --- net/tftp.c | 10 +++

[PATCH v5 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2024-01-16 Thread AKASHI Takahiro
At this point, EFI boot manager interfaces is fully independent from bootefi command. So just rename the configuration parameter. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- boot/Makefile | 2 +- cmd/Kconfig | 4 ++-- cmd/efidebug.c | 4 ++-- lib

[PATCH v5 1/4] efi_loader: split unrelated code from efi_bootmgr.c

2024-01-16 Thread AKASHI Takahiro
w EFI boot manager is implemented. So introduce a new configuration, CONFIG_EFI_BINARY_EXEC, to enforce them opted out explicitly. Signed-off-by: AKASHI Takahiro --- boot/Kconfig | 4 +- cmd/Kconfig | 6 +- include/efi_loader.h | 28 +- lib/

[PATCH v5 0/4] cmd: bootefi: refactor the code for bootmgr

2024-01-16 Thread AKASHI Takahiro
ex-patch#5 RFC (Oct 26, 2023) [1] https://lists.denx.de/pipermail/u-boot/2023-October/534598.html [2] https://dev.azure.com/u-boot/u-boot/_build/results?buildId=7760=results AKASHI Takahiro (4): efi_loader: split unrelated code from efi_bootmgr.c efi_loader: rename BOOTEFI_BOOTMGR to EFI_

Re: [PATCH v4 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2024-01-16 Thread AKASHI Takahiro
On Tue, Jan 16, 2024 at 07:44:22PM +0100, Heinrich Schuchardt wrote: > On 1/16/24 02:43, AKASHI Takahiro wrote: > > On Mon, Jan 15, 2024 at 03:16:22PM +0100, Heinrich Schuchardt wrote: > > > On 15.01.24 11:12, AKASHI Takahiro wrote: > > > > On Mon, Jan 15, 2024

Re: [PATCH v4 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2024-01-15 Thread AKASHI Takahiro
On Mon, Jan 15, 2024 at 03:16:22PM +0100, Heinrich Schuchardt wrote: > On 15.01.24 11:12, AKASHI Takahiro wrote: > > On Mon, Jan 15, 2024 at 09:34:51AM +0100, Heinrich Schuchardt wrote: > > > On 1/15/24 01:58, AKASHI Takahiro wrote: > > > > On Sun, Jan 14, 2024

Re: [PATCH v4 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2024-01-15 Thread AKASHI Takahiro
On Mon, Jan 15, 2024 at 09:34:51AM +0100, Heinrich Schuchardt wrote: > On 1/15/24 01:58, AKASHI Takahiro wrote: > > On Sun, Jan 14, 2024 at 01:46:45PM +0100, Heinrich Schuchardt wrote: > > > On 1/10/24 02:16, AKASHI Takahiro wrote: > > > > At this point, EFI bo

Re: [PATCH v4 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2024-01-14 Thread AKASHI Takahiro
On Sun, Jan 14, 2024 at 01:46:45PM +0100, Heinrich Schuchardt wrote: > On 1/10/24 02:16, AKASHI Takahiro wrote: > > At this point, EFI boot manager interfaces is fully independent from > > bootefi command. So just rename the configuration parameter. > > > > Sig

[PATCH v4 4/4] fs: remove explicit efi configuration dependency

2024-01-09 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- fs/fs.c | 7 +++ 1 file changed, 3

[PATCH v4 3/4] net: tftp: remove explicit efi configuration dependency

2024-01-09 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro Reviewed-by: Ramon Fried Reviewed-by: Tom Rini --- net/tftp.c | 10 +++

[PATCH v4 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2024-01-09 Thread AKASHI Takahiro
At this point, EFI boot manager interfaces is fully independent from bootefi command. So just rename the configuration parameter. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- boot/Makefile | 2 +- cmd/Kconfig | 4 ++-- cmd/efidebug.c | 4 ++-- lib

[PATCH v4 1/4] efi_loader: split unrelated code from efi_bootmgr.c

2024-01-09 Thread AKASHI Takahiro
w EFI boot manager is implemented. So introduce a new configuration, CONFIG_EFI_BINARY_EXEC, to enforce them opted out explicitly. Signed-off-by: AKASHI Takahiro --- v4 * moved binary execution portion of code (EFI_BINARY_EXEC) to a new file, efi_bootbin.c --- boot/Kconfig |

[PATCH v4 0/4] cmd: bootefi: refactor the code for bootmgr

2024-01-09 Thread AKASHI Takahiro
ps://lists.denx.de/pipermail/u-boot/2023-October/534598.html AKASHI Takahiro (4): efi_loader: split unrelated code from efi_bootmgr.c efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR net: tftp: remove explicit efi configuration dependency fs: remove explicit efi configuration dependency

Re: [PATCH v3 3/4] net: tftp: remove explicit efi configuration dependency

2023-12-26 Thread AKASHI Takahiro
Hi Simon, On Tue, Dec 26, 2023 at 09:47:03AM +, Simon Glass wrote: > Hi Heinrich, > > On Wed, Dec 20, 2023 at 9:17???AM Heinrich Schuchardt > wrote: > > > > > > > > Am 20. Dezember 2023 05:46:16 MEZ schrieb Simon Glass : > > >Hi, > > &

Re: [PATCH v3 1/4] efi_loader: split unrelated code from efi_bootmgr.c

2023-12-26 Thread AKASHI Takahiro
On Mon, Dec 25, 2023 at 10:17:06AM +0100, Heinrich Schuchardt wrote: > On 12/18/23 03:38, AKASHI Takahiro wrote: > > Some code moved from cmd/bootefi.c is actually necessary only for "bootefi > > " command (starting an image manually loaded by a user using U-Boot > >

Re: [PATCH v3 1/4] efi_loader: split unrelated code from efi_bootmgr.c

2023-12-18 Thread AKASHI Takahiro
On Mon, Dec 18, 2023 at 08:01:51AM -0700, Simon Glass wrote: > Hi AKASHI, > > On Sun, 17 Dec 2023 at 19:39, AKASHI Takahiro > wrote: > > > > Some code moved from cmd/bootefi.c is actually necessary only for "bootefi > > " command (starting an image manuall

Re: [PATCH v3 3/4] net: tftp: remove explicit efi configuration dependency

2023-12-18 Thread AKASHI Takahiro
Hi Simon, On Mon, Dec 18, 2023 at 08:01:46AM -0700, Simon Glass wrote: > Hi AKASHI, > > On Sun, 17 Dec 2023 at 19:39, AKASHI Takahiro > wrote: > > > > Now it is clear that the feature actually depends on efi interfaces, > > not "bootefi" comma

[PATCH v3 4/4] fs: remove explicit efi configuration dependency

2023-12-17 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- fs/fs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletion

[PATCH v3 3/4] net: tftp: remove explicit efi configuration dependency

2023-12-17 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- net/tftp.c | 10 -- 1 file changed, 4 insertions(+), 6

[PATCH v3 1/4] efi_loader: split unrelated code from efi_bootmgr.c

2023-12-17 Thread AKASHI Takahiro
w EFI boot manager is implemented. So introduce a new configuration, CONFIG_EFI_BINARY_EXEC, to enforce theem opted out explicitly. Signed-off-by: AKASHI Takahiro --- boot/Kconfig | 4 +- cmd/Kconfig | 6 +- include/efi_loader.h | 28 +- lib/

[PATCH v3 2/4] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2023-12-17 Thread AKASHI Takahiro
At this point, EFI boot manager interfaces is fully independent from bootefi command. So just rename the configuration parameter. Signed-off-by: AKASHI Takahiro --- boot/Makefile | 2 +- cmd/Kconfig | 4 ++-- cmd/efidebug.c | 4 ++-- lib/efi_loader/Kconfig | 2

[PATCH v3 0/4] cmd: bootefi: refactor the code for bootmgr

2023-12-17 Thread AKASHI Takahiro
* remove already merged commits * revise commit messages * add patch #5 which was split from ex-patch#5 RFC (Oct 26, 2023) [1] https://lists.denx.de/pipermail/u-boot/2023-October/534598.html AKASHI Takahiro (4): efi_loader: split unrelated code from efi_bootmgr.c efi_loader: rename BOOTEFI_BO

Re: [PATCH] efi_loader: eliminate efi_disk_obj structure

2023-12-13 Thread AKASHI Takahiro
Hi Kojima-san, On Wed, Dec 13, 2023 at 05:57:37PM +0900, Masahisa Kojima wrote: > Current code uses struct efi_disk_obj to keep information > about block devices and partitions. As the efi handle already > has a field with the udevice, we should eliminate > struct efi_disk_obj and use an pointer

Re: [PATCH v2 02/12] cmd: bootefi: re-organize do_bootefi()

2023-12-07 Thread AKASHI Takahiro
Hi Ilias, On Fri, Dec 08, 2023 at 08:33:11AM +0200, Ilias Apalodimas wrote: > Akashi-san, > > [...] > > > > > > > help > > > > > > This compiles a standard EFI hello world application with > > > > > > U-Boot so > > > > > > @@ -395,6 +405,7 @@ config CMD_BOOTEFI_HELLO > > > > > >

Re: [PATCH v2 02/12] cmd: bootefi: re-organize do_bootefi()

2023-12-05 Thread AKASHI Takahiro
On Tue, Dec 05, 2023 at 10:54:23AM +0200, Ilias Apalodimas wrote: > Hello Akashi-san, > Thanks for taking a shot at the cleanup > > On Tue, 21 Nov 2023 at 06:53, AKASHI Takahiro > wrote: > > > > Hi Heinrich, > > > > On Tue, Nov 21, 2023 at 04:31:40AM +0100,

Re: [PATCH v2 00/12] cmd: bootefi: refactor the code for bootmgr

2023-12-03 Thread AKASHI Takahiro
Hi Heinrich, Ilias On Tue, Nov 21, 2023 at 10:29:38AM +0900, AKASHI Takahiro wrote: > This patch set is motivated by the discussion[1] regarding > CONFIG_BOOTEFI_BOOTMGR option. > > At the end, bootefi.c will be decomposed into two parts, one for > providing the command

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-21 Thread AKASHI Takahiro
On Tue, Nov 21, 2023 at 11:57:12PM +, Shantur Rathore wrote: > Currently U-boot uses ESP as storage for EFI variables. > Devices with SPI Flash are used for storing environment with this > commit we allow EFI variables to be stored on SPI Flash. > > Signed-off-by: Shantur Rathore > --- > >

Re: [PATCH v1 1/3] efi: filestore: don't compile when config disabled

2023-11-21 Thread AKASHI Takahiro
On Tue, Nov 21, 2023 at 11:57:11PM +, Shantur Rathore wrote: > Compile out filestore functions when config isn't enabled. > > Signed-off-by: Shantur Rathore > --- > > include/efi_variable.h| 21 - > lib/efi_loader/efi_var_file.c | 13 +++-- >

Re: [PATCH v2 03/12] cmd: bootefi: carve out EFI boot manager interface

2023-11-20 Thread AKASHI Takahiro
On Tue, Nov 21, 2023 at 04:38:12AM +0100, Heinrich Schuchardt wrote: > On 11/21/23 02:29, AKASHI Takahiro wrote: > > Carve EFI boot manager related code out of do_bootefi_image() in order > > to move boot manager specific code into library directory in the later > > commit

Re: [PATCH v2 02/12] cmd: bootefi: re-organize do_bootefi()

2023-11-20 Thread AKASHI Takahiro
Hi Heinrich, On Tue, Nov 21, 2023 at 04:31:40AM +0100, Heinrich Schuchardt wrote: > On 11/21/23 02:29, AKASHI Takahiro wrote: > > Replicate some code and re-organize do_bootefi() into three cases, which > > will be carved out as independent functions in the next two commits. >

[PATCH v2 09/12] efi_loader: split unrelated code from efi_bootmgr.c

2023-11-20 Thread AKASHI Takahiro
w EFI boot manager is implemented. So introduce a new configuration, CONFIG_EFI_BINARY_EXEC, to enforce theem opted out explicitly. Signed-off-by: AKASHI Takahiro --- boot/Kconfig | 4 +- cmd/Kconfig | 6 +- include/efi_loader.h | 28 +- lib/

[PATCH v2 11/12] net: tftp: remove explicit efi configuration dependency

2023-11-20 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- net/tftp.c | 10 -- 1 file changed, 4 insertions(+), 6

[PATCH v2 10/12] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2023-11-20 Thread AKASHI Takahiro
At this point, EFI boot manager interfaces is fully independent from bootefi command. So just rename the configuration parameter. Signed-off-by: AKASHI Takahiro --- boot/Makefile | 2 +- cmd/Kconfig | 4 ++-- cmd/efidebug.c | 4 ++-- lib/efi_loader/Kconfig | 2

[PATCH v2 12/12] fs: remove explicit efi configuration dependency

2023-11-20 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- fs/fs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletion

[PATCH v2 08/12] bootmeth: use efi_loader interfaces instead of bootefi command

2023-11-20 Thread AKASHI Takahiro
Now that efi_loader subsystem provides interfaces that are equivalent with bootefi command, we can replace command invocations with APIs. Signed-off-by: AKASHI Takahiro --- boot/Kconfig| 4 ++-- boot/Makefile | 2 +- boot/bootm_os.c | 31

[PATCH v2 04/12] cmd: bootefi: carve out binary execution interface

2023-11-20 Thread AKASHI Takahiro
Carve binary execution code out of do_bootefi_image() in order to move binary-execution specific code into library directory in the later commit. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 46 -- 1 file changed, 32 insertions(+), 14 deletions

[PATCH v2 07/12] cmd: efidebug: ease efi configuration dependency

2023-11-20 Thread AKASHI Takahiro
Now it is clear that the command actually depends on interfaces, not "bootefi bootmgr" command. Signed-off-by: AKASHI Takahiro --- cmd/efidebug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 78ef16f4cb5c..e10fbf891

[PATCH v2 06/12] cmd: bootefi: move library interfaces under lib/efi_loader

2023-11-20 Thread AKASHI Takahiro
In the prior commits, interfaces for executing EFI binary and boot manager were carved out. Move them under efi_loader directory so that they can be called from other places without depending on bootefi command. Only efi_selftest-related code will be left in bootefi.c. Signed-off-by: AKASHI

[PATCH v2 05/12] cmd: bootefi: localize global device paths for efi_selftest

2023-11-20 Thread AKASHI Takahiro
Device paths allocated in bootefi_test_prepare() will be immediately consumed by do_efi_selftest() and there is no need to keep them for later use. Introduce test-specific varialbles to make it easier to move other bootmgr functions into library directory in the next commit. Signed-off-by: AKASHI

[PATCH v2 03/12] cmd: bootefi: carve out EFI boot manager interface

2023-11-20 Thread AKASHI Takahiro
Carve EFI boot manager related code out of do_bootefi_image() in order to move boot manager specific code into library directory in the later commit. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions

[PATCH v2 02/12] cmd: bootefi: re-organize do_bootefi()

2023-11-20 Thread AKASHI Takahiro
Replicate some code and re-organize do_bootefi() into three cases, which will be carved out as independent functions in the next two commits. Signed-off-by: AKASHI Takahiro --- cmd/Kconfig | 15 ++-- cmd/bootefi.c| 82 ++-- include

[PATCH v2 01/12] cmd: bootefi: unfold do_bootefi_image()

2023-11-20 Thread AKASHI Takahiro
Unfold do_bootefi_image() into do_bootefi() in order to make it easier to re-organize do_bootefi() in the next commit. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 101 ++ 1 file changed, 37 insertions(+), 64 deletions(-) diff --git a/cmd

[PATCH v2 00/12] cmd: bootefi: refactor the code for bootmgr

2023-11-20 Thread AKASHI Takahiro
t from ex-patch#5 RFC (Oct 26, 2023) [1] https://lists.denx.de/pipermail/u-boot/2023-October/534598.html AKASHI Takahiro (12): cmd: bootefi: unfold do_bootefi_image() cmd: bootefi: re-organize do_bootefi() cmd: bootefi: carve out EFI boot manager interface cmd: bootefi: carve out b

[PATCH] xen: pvblock: fix the maximum io size in one operation

2023-11-14 Thread AKASHI Takahiro
PAGE_MASK; end = ((uintptr_t)aiocbp->aio_buf + aiocbp->aio_nbytes + PAGE_SIZE - 1) & PAGE_MASK; Then this will lead to BUG_ON() above. This can be fixed by decreasing the maximum size of aio_nbytes. Signed-off-by: AKASHI Takahiro Fixes: commit 3a739cc6c948 ("xen:

[PATCH v3 5/5] test: dm: add scmi command test

2023-11-13 Thread AKASHI Takahiro
In this test, "scmi" command is tested against different sub-commands. Please note that scmi command is for debug purpose and is not intended in production system. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v9 * return -EAGAIN if we wa

[PATCH v3 4/5] doc: cmd: add documentation for scmi

2023-11-13 Thread AKASHI Takahiro
This is a help text for scmi command. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v6 * add the manual to doc/usage/index.rst v4 * s/tranport/transport/ v2 * add more descriptions about SCMI --- doc/usage/cmd/scmi.rst | 126

[PATCH v3 3/5] cmd: add scmi command for SCMI firmware

2023-11-13 Thread AKASHI Takahiro
This command, "scmi", may provide a command line interface to various SCMI protocols. It supports at least initially SCMI base protocol and is intended mainly for debug purpose. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v8 (actually

[PATCH v3 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-11-13 Thread AKASHI Takahiro
This change will be useful when we manually test SCMI on sandbox by enabling/disabling a specific SCMI protocol. Signed-off-by: AKASHI Takahiro --- v9 * use CONFIG_IS_ENABLED() rather than IS_ENABLED() * remove goto by introducing a not_supported() function --- drivers/firmware/scmi/sandbox

[PATCH v3 1/5] test: dm: skip scmi tests against disabled protocols

2023-11-13 Thread AKASHI Takahiro
This is a precautionary change to make scmi tests workable whether or not a specific protocol be enabled. If a given protocol is not configured, we skip the test by returning -EAGAIN. Signed-off-by: AKASHI Takahiro --- v9 * return -EAGAIN if we want to skip a test * use CONFIG_IS_ENABLED

[PATCH v3 0/5] cmd: add scmi command

2023-11-13 Thread AKASHI Takahiro
23) * return -EAGAIN if we want to skip a test. * use CONFIG_IS_ENABLED() rather than IS_ENABLED(). * remove goto by introducing a function in sandbox implementation. v2(Nov 13, 2023) * localize global variables to avoid pytest errors. AKASHI Takahiro (5): test: dm: skip scmi tests against disabled

Re: [PATCH v2 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-11-13 Thread AKASHI Takahiro
On Mon, Nov 13, 2023 at 11:01:20AM -0700, Simon Glass wrote: > Hi AKASHI, > > On Sun, 12 Nov 2023 at 18:49, AKASHI Takahiro > wrote: > > > > This change will be useful when we manually test SCMI on sandbox > > by enabling/disabling a specific SCMI protocol. > >

Re: [PATCH v2 1/5] test: dm: skip scmi tests against disabled protocols

2023-11-13 Thread AKASHI Takahiro
On Mon, Nov 13, 2023 at 11:01:18AM -0700, Simon Glass wrote: > Hi AKASHI, > > On Sun, 12 Nov 2023 at 18:49, AKASHI Takahiro > wrote: > > > > This is a precautionary change to make scmi tests workable whether or not > > a specific protocol be enabled. > >

Re: [PATCH 5/5] test: dm: add scmi command test

2023-11-13 Thread AKASHI Takahiro
On Mon, Nov 13, 2023 at 11:01:17AM -0700, Simon Glass wrote: > Hi, > > On Sun, 12 Nov 2023 at 18:46, AKASHI Takahiro > wrote: > > > > Hi Tom, > > > > On Fri, Nov 10, 2023 at 01:21:37PM -0500, Tom Rini wrote: > > > On Wed, Oct 25, 20

[PATCH v2 5/5] test: dm: add scmi command test

2023-11-12 Thread AKASHI Takahiro
In this test, "scmi" command is tested against different sub-commands. Please note that scmi command is for debug purpose and is not intended in production system. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v7 * make test assertions mor

[PATCH v2 4/5] doc: cmd: add documentation for scmi

2023-11-12 Thread AKASHI Takahiro
This is a help text for scmi command. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v6 * add the manual to doc/usage/index.rst v4 * s/tranport/transport/ v2 * add more descriptions about SCMI --- doc/usage/cmd/scmi.rst | 126

[PATCH v2 3/5] cmd: add scmi command for SCMI firmware

2023-11-12 Thread AKASHI Takahiro
This command, "scmi", may provide a command line interface to various SCMI protocols. It supports at least initially SCMI base protocol and is intended mainly for debug purpose. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v8 (actually

[PATCH v2 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-11-12 Thread AKASHI Takahiro
This change will be useful when we manually test SCMI on sandbox by enabling/disabling a specific SCMI protocol. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/sandbox-scmi_agent.c | 27 ++- drivers/firmware/scmi/sandbox-scmi_devices.c | 78 2 files changed

[PATCH v2 1/5] test: dm: skip scmi tests against disabled protocols

2023-11-12 Thread AKASHI Takahiro
This is a precautionary change to make scmi tests workable whether or not a specific protocol be enabled. Signed-off-by: AKASHI Takahiro --- test/dm/scmi.c | 12 1 file changed, 12 insertions(+) diff --git a/test/dm/scmi.c b/test/dm/scmi.c index da45314f2e4c..2f63f2da16fb 100644

[PATCH v2 0/5] cmd: add scmi command

2023-11-12 Thread AKASHI Takahiro
3) * localize global variables to avoid pytest errors. AKASHI Takahiro (5): test: dm: skip scmi tests against disabled protocols firmware: scmi: support protocols on sandbox only if enabled cmd: add scmi command for SCMI firmware doc: cmd: add documentation for scmi test: dm: add scmi comman

Re: [PATCH 5/5] test: dm: add scmi command test

2023-11-12 Thread AKASHI Takahiro
Hi Tom, On Fri, Nov 10, 2023 at 01:21:37PM -0500, Tom Rini wrote: > On Wed, Oct 25, 2023 at 02:14:27PM +0900, AKASHI Takahiro wrote: > > > In this test, "scmi" command is tested against different sub-commands. > > Please note that scmi command is for debug

[PATCH] firmware: scmi: correct a validity check against power domain id

2023-11-06 Thread AKASHI Takahiro
A power domain id on sandbox should be in the range from zero to ARRAY_SIZE(scmi_pwdom) - 1. Correct the validity check logic. Signed-off-by: AKASHI Takahiro Fixes: CID 467401 Fixes: CID 467405 --- drivers/firmware/scmi/sandbox-scmi_agent.c | 8 1 file changed, 4 insertions(+), 4

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-29 Thread AKASHI Takahiro
Hi Ilias, On Fri, Oct 27, 2023 at 03:23:07PM +0300, Ilias Apalodimas wrote: > Akashi-san > > On Fri, 27 Oct 2023 at 04:00, Tom Rini wrote: > > > > On Fri, Oct 27, 2023 at 09:25:44AM +0900, AKASHI Takahiro wrote: > > > On Thu, Oct 26, 2023 at 01:01:52PM +0

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 08:47:52AM -0400, Tom Rini wrote: > On Thu, Oct 26, 2023 at 05:48:30PM +0900, AKASHI Takahiro wrote: > > On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > > > > > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb

Re: [RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 12:44:00PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Decompose and re-organize do_bootefi_image() into three parts for > > the succeeding refactor work. > > > > Signed-off-by: AKASHI Takahiro > > --

Re: [RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 01:01:52PM +0200, Heinrich Schuchardt wrote: > On 10/26/23 07:30, AKASHI Takahiro wrote: > > Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding > > refactor work. > > > > Signed-off-by: AKASHI Takahiro > &

Re: [RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-26 Thread AKASHI Takahiro
On Thu, Oct 26, 2023 at 09:58:53AM +0200, Heinrich Schuchardt wrote: > > > Am 26. Oktober 2023 07:30:50 MESZ schrieb AKASHI Takahiro > : > >Now it is clear that the feature actually depends on efi interfaces, > >not "bootefi" command. efi_set_bootdev

[RFC 13/13] block: rkmtd: select CONFIG_RANDOM_UUID explicitly

2023-10-25 Thread AKASHI Takahiro
This option is necessary to compile any way. Signed-off-by: AKASHI Takahiro --- drivers/block/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 048a6caef00f..5cda21551043 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig

[RFC 12/13] lib: uuid: move CONFIG_RANDOM_UUID

2023-10-25 Thread AKASHI Takahiro
This option is independent from any commands and should be managed under lib. For instance, drivers/block/rkmtd.c is a user. It would be better to remove this configuration. Signed-off-by: AKASHI Takahiro --- cmd/Kconfig | 7 --- lib/Kconfig | 7 +++ 2 files changed, 7 insertions(+), 7

[RFC 11/13] fs: remove explicit efi configuration dependency

2023-10-25 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- fs/fs.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletion

[RFC 10/13] net: tftp: remove explicit efi configuration dependency

2023-10-25 Thread AKASHI Takahiro
Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- net/tftp.c | 10 -- 1 file changed, 4 insertions(+), 6

[RFC 09/13] efi_loader: rename BOOTEFI_BOOTMGR to EFI_BOOTMGR

2023-10-25 Thread AKASHI Takahiro
At this point, EFI boot manager interfaces is fully independent from bootefi command. So just rename the configuration parameter. Signed-off-by: AKASHI Takahiro --- boot/Makefile | 2 +- cmd/Kconfig | 4 ++-- cmd/efidebug.c | 4 ++-- lib/efi_loader/Kconfig | 2

[RFC 08/13] efi_loader: split unrelated code from efi_bootmgr.c

2023-10-25 Thread AKASHI Takahiro
w EFI boot manager is implemented. So introduce a new configuration, CONFIG_EFI_BINARY_EXEC, to enforce theem opted out explicitly. Signed-off-by: AKASHI Takahiro --- boot/Kconfig | 4 +- cmd/Kconfig | 6 +- include/efi_loader.h | 28 +- lib/

[RFC 05/13] cmd: bootefi: move library interfaces under lib/efi_loader

2023-10-25 Thread AKASHI Takahiro
In the prior commits, interfaces for executing EFI binary or boot manager were carved out. Move them under efi_loader directory so that they can be called from other places without depending on bootefi command. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c| 546

[RFC 07/13] bootmeth: use efi_loader interfaces instead of bootefi command

2023-10-25 Thread AKASHI Takahiro
Now that efi_loader subsystem provides interfaces that are equivalent with bootefi command, we can replace command invocations with APIs. Signed-off-by: AKASHI Takahiro --- boot/Kconfig| 4 ++-- boot/Makefile | 2 +- boot/bootm_os.c | 31

[RFC 06/13] cmd: efidebug: ease efi configuration dependency

2023-10-25 Thread AKASHI Takahiro
Now it is clear that the command actually depends on interfaces, not "bootefi bootmgr" command. Signed-off-by: AKASHI Takahiro --- cmd/efidebug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 201531ac19fc..c2b2b074e

[RFC 04/13] cmd: bootefi: carve out binary execution interface

2023-10-25 Thread AKASHI Takahiro
Carve binary execution code out of do_bootefi_image(). Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 46 -- 1 file changed, 32 insertions(+), 14 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index 899ed90f6817..8b0bd07f1ff8 100644

[RFC 03/13] cmd: bootefi: carve out EFI boot manager interface

2023-10-25 Thread AKASHI Takahiro
Carve EFI boot manager related code out of do_bootefi_image(). Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index ae00bba3b4f0..899ed90f6817 100644

[RFC 02/13] cmd: bootefi: re-organize do_bootefi_image()

2023-10-25 Thread AKASHI Takahiro
Decompose and re-organize do_bootefi_image() into three parts for the succeeding refactor work. Signed-off-by: AKASHI Takahiro --- cmd/Kconfig | 15 ++-- cmd/bootefi.c| 82 ++-- include/efi_loader.h | 2 -- 3 files changed, 69

[RFC 01/13] cmd: bootefi: unfold do_bootefi_image()

2023-10-25 Thread AKASHI Takahiro
Unfold do_bootefi_image() into do_bootefi() for the sake of the succeeding refactor work. Signed-off-by: AKASHI Takahiro --- cmd/bootefi.c | 101 ++ 1 file changed, 37 insertions(+), 64 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c

[RFC 00/13] cmd: bootefi: refactor the code for bootmgr

2023-10-25 Thread AKASHI Takahiro
tly related to the patch's aim, but they are necessary to compile U-Boot on sandbox (sandbox_defconfig) without CONFIG_CMDLINE. [1] https://lists.denx.de/pipermail/u-boot/2023-October/534598.html [2] origin/TEST/v4.1-tidy-up-use-of-CONFIG_CMDLINE AKASHI Takahiro (13): cmd: bootefi: u

Re: [PATCH 3/5] cmd: add scmi command for SCMI firmware

2023-10-25 Thread AKASHI Takahiro
Hi Michal, On Wed, Oct 25, 2023 at 09:29:04AM +0200, Michal Simek wrote: > > > On 10/25/23 07:14, AKASHI Takahiro wrote: > > This command, "scmi", may provide a command line interface to various SCMI > > protocols. It supports at least initially SCMI base prot

[PATCH 5/5] test: dm: add scmi command test

2023-10-24 Thread AKASHI Takahiro
In this test, "scmi" command is tested against different sub-commands. Please note that scmi command is for debug purpose and is not intended in production system. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v7 * make test assertions mor

[PATCH 4/5] doc: cmd: add documentation for scmi

2023-10-24 Thread AKASHI Takahiro
This is a help text for scmi command. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v6 * add the manual to doc/usage/index.rst v4 * s/tranport/transport/ v2 * add more descriptions about SCMI --- doc/usage/cmd/scmi.rst | 126

[PATCH 3/5] cmd: add scmi command for SCMI firmware

2023-10-24 Thread AKASHI Takahiro
This command, "scmi", may provide a command line interface to various SCMI protocols. It supports at least initially SCMI base protocol and is intended mainly for debug purpose. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass Reviewed-by: Etienne Carriere --- v3

[PATCH 2/5] firmware: scmi: support protocols on sandbox only if enabled

2023-10-24 Thread AKASHI Takahiro
This change will be useful when we manually test SCMI on sandbox by enabling/disabling a specific SCMI protocol. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/sandbox-scmi_agent.c | 27 ++- drivers/firmware/scmi/sandbox-scmi_devices.c | 78 2 files changed

[PATCH 1/5] test: dm: skip scmi tests against disabled protocols

2023-10-24 Thread AKASHI Takahiro
This is a precautious change to make scmi tests workable whether or not a specific protocol be enabled. Signed-off-by: AKASHI Takahiro --- test/dm/scmi.c | 12 1 file changed, 12 insertions(+) diff --git a/test/dm/scmi.c b/test/dm/scmi.c index da45314f2e4c..2f63f2da16fb 100644

[PATCH 0/5] cmd: add scmi command

2023-10-24 Thread AKASHI Takahiro
col for test purpose. Each commit may have some change history inherited from the preceding patch series. Test The patch series was tested on the following platforms: * sandbox Prerequisite: = * This patch series is based on the latest master. AKASHI Takahiro (5): test:

Re: [PATCH v5 14/16] cmd: add scmi command for SCMI firmware

2023-10-24 Thread AKASHI Takahiro
Hi Tom, Michal, On Tue, Oct 24, 2023 at 06:24:07PM -0400, Tom Rini wrote: > On Tue, Oct 24, 2023 at 10:27:44AM +0200, Michal Simek wrote: > > Hi Takahiro, > > > > ?t 26. 9. 2023 v 9:00 odes?latel AKASHI Takahiro > > napsal: > > > > > > This command,

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-20 Thread AKASHI Takahiro
brary functionality. Add a > > > new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the > > > same code is built. > > > > > > Signed-off-by: Simon Glass > > > Suggested-by: AKASHI Takahiro > > > --- > > > Cc: Heinrich Schuchardt

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread AKASHI Takahiro
On Thu, Oct 19, 2023 at 08:01:11AM -0600, Simon Glass wrote: > Hi Heinrich, > > On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt wrote: > > > > On 10/17/23 16:09, Tom Rini wrote: > > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > > > >> Since efi_device_path.c calls

Re: [PATCH v3 21/32] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-16 Thread AKASHI Takahiro
> Signed-off-by: Simon Glass > Suggested-by: AKASHI Takahiro > --- > > Changes in v3: > - Add new patch to rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR > > cmd/Kconfig | 9 + > lib/efi_loader/Kconfig | 7 +++ > lib/efi_loader/Makefile | 2

[PATCH v2 1/4] firmware: scmi: add power domain protocol support

2023-10-15 Thread AKASHI Takahiro
In this patch, added are helper functions to directly manipulate SCMI power domain management protocol. DM compliant power domain driver will be implemented on top of those interfaces in a succeeding patch. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/Makefile | 1 + drivers

[PATCH v2 4/4] test: dm: add SCMI power domain protocol test

2023-10-15 Thread AKASHI Takahiro
This ut has tests for the SCMI power domain protocol as well as DM interfaces for power domain devices. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- v2 * remove a change at "test_scmi_cmd" because "scmi" command is no longer provided ---

[PATCH v2 3/4] sandbox: add SCMI power domain protocol support for testing

2023-10-15 Thread AKASHI Takahiro
SCMI power domain management protocol is supported on sandbox for test purpose. Add fake agent interfaces and associated power domain devices. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- v2 * add a comment for a member, pstate, of struct sandbox_scmi_pwd --- arch/sandbox/dts

[PATCH v2 2/4] power: domain: add SCMI driver

2023-10-15 Thread AKASHI Takahiro
Add power domain driver based on SCMI power domain management protocol. Signed-off-by: AKASHI Takahiro --- v2 * remove tentative code which was enclosed by "#if 0" * free allocated memory at the failure of probe function --- drivers/firmware/scmi/scmi_agent-uclass.c | 11 ++ dri

[PATCH v2 0/4] firmware: scmi: add SCMI power domain protocol support

2023-10-15 Thread AKASHI Takahiro
#2: Add power domain driver Patch#3-#4: Test related Change history: === v2 (Oct 16, 2023) * remove a change on "test_scmi_cmd" because "scmi" command is no longer provided with base protocol v6 * some cleanup v1 (Sep 26, 2023) * initial release AKASHI Takahir

Re: [PATCH 4/4] test: dm: add SCMI power domain protocol test

2023-10-15 Thread AKASHI Takahiro
Hi Tom, On Fri, Oct 13, 2023 at 09:20:48PM -0400, Tom Rini wrote: > On Tue, Sep 26, 2023 at 04:00:43PM +0900, AKASHI Takahiro wrote: > > > This ut has tests for the SCMI power domain protocol as well as DM > > interfaces for power domain devices. > > > >

Re: [PATCH v6 08/14] firmware: scmi: add a version check against base protocol

2023-10-11 Thread AKASHI Takahiro
Hi Etienne, Thank you again for your review. On Wed, Oct 11, 2023 at 03:44:36PM +, Etienne CARRIERE - foss wrote: > > From: U-Boot on behalf of AKASHI Takahiro > > > > Sent: Wednesday, October 11, 2023 12:07 PM > > > > In SCMI base protocol versi

[PATCH v6 14/14] firmware: scmi: add a check against availability of protocols

2023-10-11 Thread AKASHI Takahiro
Now that we have Base protocol support, we will be able to check if a given protocol is really supported by the SCMI server (firmware). Signed-off-by: AKASHI Takahiro Reviewed-by: Etienne Carriere Reviewed-by: Simon Glass --- v3 * new; import this patch from my followup patch set --- drivers

  1   2   3   4   5   6   7   8   9   10   >