Re: [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines

2011-09-22 Thread Andy Fleming
On Mon, Sep 5, 2011 at 12:24 PM, Vladimir Zapolskiy wrote: > This change slightly improves readability of the phydev speed/duplex > assignment logic. Shoot, I just saw this patch in my tree. It's incorrect. > @@ -318,13 +318,10 @@ static int genphy_parse_link(struct phy_device *phydev) >      

[U-Boot] Please pull u-boot-mmc.git

2011-09-04 Thread Andy Fleming
are available in the git repository at: git://www.denx.de/git/u-boot-mmc.git master Macpaul Lin (1): ftsdc010: add support of ftsdc010 mmc controller Marek Vasut (1): mmc: Fix mmc_send_status() drivers/mmc/Makefile |1 + drivers/mmc/ftsdc010_esdhc.c | 667 +++

Re: [U-Boot] [PATCH] mmc: retry the cmd8 to meet 74 clocks requirement in the spec

2011-09-04 Thread Andy Fleming
On Sun, Sep 4, 2011 at 5:18 PM, Marek Vasut wrote: > On Saturday, September 03, 2011 05:34:17 AM Lei Wen wrote: >> For some controller it has dynamic clock gating, and only toggle out clk >> when the first cmd0 send out, while some card strictly obey the 74 >> clocks rule, the interval may not be

Re: [U-Boot] [PATCH 9/9] OMAP3: Remove legacy mmc driver

2011-09-03 Thread Andy Fleming
On Tue, Aug 30, 2011 at 2:19 AM, Marek Vasut wrote: >> > >> >  drivers/mmc/omap3_mmc.h |  233 --- >> >  3 files changed, 0 insertions(+), 804 deletions(-) >> >  delete mode 100644 drivers/mmc/omap3_mmc.c >> >  delete mode 100644 drivers/mmc/omap3_mmc.h >> >> Similar patch was poste

Re: [U-Boot] [PATCH 1/1] mmc: omap: enable high capacity

2011-09-03 Thread Andy Fleming
Isn't high-capacity capability also connected to board capabilities? Is it safe to enable this across all users of this driver? Andy On Thu, Aug 25, 2011 at 9:46 AM, Balaji T K wrote: > Enable high capacity to host capability. > Fixes eMMC detection on boot from MMC/SD card. > > Signed-off-by: B

Re: [U-Boot] [PATCH] s5p-mmc: Fix ambiguous setting of data transfer width

2011-08-31 Thread Andy Fleming
On Tue, Aug 30, 2011 at 5:55 AM, Chander Kashyap wrote: > mmc data transfer width is set as following: > WIDE8[5]: > 0 = Depend on WIDE4 > 1 = 8-bit mode > WIDE4[1]: > 1 = 4-bit mode > 0 = 1-bit mode > > In case of 4-bit mode reset 8-bit mode and > in case of 1-bit mode reset 8-bit mode and 4-bit

Re: [U-Boot] [PATCH v3] ftsdc010: add support of ftsdc010 mmc controller

2011-08-16 Thread Andy Fleming
On Wed, Aug 10, 2011 at 9:12 PM, 馬克泡 wrote: > Hi Andy, > > 2011/7/21 Macpaul Lin : >> Faraday FTSDC010 controller is a SD/MMC controller for SoC chip. >> >> Signed-off-by: Macpaul Lin Applied, thx! ___ U-Boot mailing list U-Boot@lists.denx.de http://li

Re: [U-Boot] [RFC 2/3][v4] mmc: SEND_OP_COND considers card capabilities (voltage)

2011-08-16 Thread Andy Fleming
MC_MODE_HC. Let me know if that patch didn't solve your problem. Andy On Thu, Jul 28, 2011 at 2:25 PM, Gary Thomas wrote: > On 2011-04-13 05:24, Andy Fleming wrote: >> >> On Fri, Mar 11, 2011 at 6:01 AM, Raffaele Recalcati >>  wrote: >>> >>> From: R

Re: [U-Boot] [PATCH] mmc: dcache: Replace ext_csd buffer with cache aligned one

2011-08-16 Thread Andy Fleming
c.c is allowing for buffer allocation > with proper cache alignment. > > The common/dlmalloc.c [c|m]alloc alignment is hardwired to 8 bytes, > so out of the box functions cannot be safely used with L1 D cache. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Pa

Re: [U-Boot] [PATCH] am3517evm: Use generic MMC driver

2011-08-16 Thread Andy Fleming
t; > Signed-off-by: Vaibhav Hiremath > Signed-off-by: Sanjeev Premi Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] omap3evm: Use generic MMC driver

2011-08-16 Thread Andy Fleming
t; > Signed-off-by: Vaibhav Hiremath > Signed-off-by: Sanjeev Premi Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/7] mmc: rescan fails on empty slot

2011-08-16 Thread Andy Fleming
Ok, I feel dumb. I apparently applied this already. But I'm still interested in a response to my comments/questions. :) On Tue, Aug 16, 2011 at 9:15 PM, Andy Fleming wrote: > On Mon, Jul 18, 2011 at 9:40 AM, Michael Jones > wrote: >> Fail in 'mmc rescan' if mmc_init(

Re: [U-Boot] [PATCH v2 4/7] mmc: rescan fails on empty slot

2011-08-16 Thread Andy Fleming
On Mon, Jul 18, 2011 at 9:40 AM, Michael Jones wrote: > Fail in 'mmc rescan' if mmc_init() returns error I think, if we're going to do this, we should change them all. Also, for the purpose you want, it seems like we should consider adding or modifying a command to just report whether the slot h

[U-Boot] [PATCH] phylib: Work around bug in Teranetics PHY

2011-08-16 Thread Andy Fleming
. Signed-off-by: Andy Fleming --- drivers/net/phy/teranetics.c | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/drivers/net/phy/teranetics.c b/drivers/net/phy/teranetics.c index a771791..a13b48c 100644 --- a/drivers/net/phy/teranetics.c +++ b/drivers/net/phy

Re: [U-Boot] MII - Incorrect type specified for offset addr

2011-08-10 Thread Andy Fleming
I know I'm a bit late to this, but this doesn't sound right. MII isn't a very flexible protocol. The registers have to fit in 5 bits. In order for larger values to be used, you would need to be using clause 45 of MDIO, which requires not just 16-bit register offsets, but an additional argument (de

Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

2011-08-10 Thread Andy Fleming
On Aug 10, 2011, at 2:12 AM, Joe Hershberger wrote: > Previously only the last N were included based on the current one in use. > > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Mingkai Hu > Cc: Andy Fleming > Cc: Kumar Gala > Cc: Detlev Zundel

Re: [U-Boot] [PATCH V2] mmc: Fix mmc_send_status()

2011-08-10 Thread Andy Fleming
On Aug 10, 2011, at 2:26 PM, Detlev Zundel wrote: > Hi Lei, > >> Hi Marek, >> >> On Wed, Aug 10, 2011 at 3:24 PM, Marek Vasut wrote: >>> The mmc_send_status() function sets cmd.arg = 0. That's incorrect, so fix >>> it. >>> >>> Signed-off-by: Marek Vasut Applied (with lei wen's "tested-by")

Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

2011-08-10 Thread Andy Fleming
indices to zero */ >>>rxIdx = 0; >>>txIdx = 0; >>> >>> So can you tell me, what your change actually does? I cannot remember >>> that we have concurrency issues here, or do we? >> >> My apologies... I ported this patch

Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

2011-08-10 Thread Andy Fleming
On Aug 10, 2011, at 2:12 AM, Joe Hershberger wrote: > Previously only the last N were included based on the current one in use. > > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Mingkai Hu > Cc: Andy Fleming > Cc: Kumar Gala > Cc: Detlev Zundel

[U-Boot] Please pull u-boot-mmc.git

2011-08-02 Thread Andy Fleming
are available in the git repository at: git://www.denx.de/git/u-boot-mmc.git master Andy Fleming (1): Revert "AT91:mmc:fix multiple read/write error" drivers/mmc/atmel_mci.h |9 + drivers/mmc/gen_atmel_mci.c |4 2 files changed, 1 insertions(+), 12

[U-Boot] [PATCH] Revert "AT91:mmc:fix multiple read/write error"

2011-08-02 Thread Andy Fleming
This reverts commit c310fc840472a36e4b9d2505830e9dc8d458d63c. The Atmel custodian had apparently rejected this patch's approach in another thread, so this patch reverts it for now. Signed-off-by: Andy Fleming --- I have pushed this up to my repository, and will submit a pull reque

Re: [U-Boot] [PATCH] AT91:mmc:fix multiple read/write error

2011-08-02 Thread Andy Fleming
> I find it highly irregular that this patch has made it into mainline! > > 1. We have had a discussion about that I think the approach in this > patch is wrong. My concerns have not been addressed yet. I have seen no such discussion. I saw no comments on this patch, so I applied it. In an idea w

Re: [U-Boot] [PATCH] phy.c: make less verbose - turn printf() into debug()

2011-07-29 Thread Andy Fleming
On Jul 27, 2011, at 8:22 AM, Kumar Gala wrote: > > On Jul 25, 2011, at 2:39 AM, Wolfgang Denk wrote: > >> The PHY driver was too verbose and corrupted the boot message display >> like this: >> >> ... >> Net: TSEC0 connected to Marvell 88ES >> TSEC1 connected to Marvell 88E

[U-Boot] Please pull u-boot-mmc.git

2011-07-18 Thread Andy Fleming
are available in the git repository at: git://www.denx.de/git/u-boot-mmc.git master Lei Wen (4): MMC: unify mmc read and write operation MMC: add erase function to both mmc and sd MMC: add sdhci generic framework MMC: add marvell sdhci driver Michael Jones (1): mm

Re: [U-Boot] [PATCH] ftsdc010: add support of ftsdc010 mmc controller

2011-07-18 Thread Andy Fleming
On Fri, Jul 8, 2011 at 3:01 AM, Macpaul Lin wrote: > + */ > +static struct mmc mmc_dev[CONFIG_FTSDC010_NUMBER]; > +static struct mmc_host mmc_host[CONFIG_FTSDC010_NUMBER]; Probably should have less generic names for all of these. > + > +static struct ftsdc010_mmc *ftsdc010_get_base_mmc(int dev_i

Re: [U-Boot] [RFC] Allow for parallel builds and saved output

2011-05-18 Thread Andy Fleming
On Sat, Apr 30, 2011 at 2:49 PM, Wolfgang Denk wrote: > Dear Andy Fleming, > > In message <1302687759-1649-1-git-send-email-aflem...@freescale.com> you > wrote: >> The MAKEALL script cleverly runs make with the appropriate options >> to use all of the cores on the s

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-05-18 Thread Andy Fleming
> > I have submit another round of patch, please review it whether it meet > your expectation. Applied, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] MMC: omap_hsmmc.c: Add missing prototype header

2011-05-18 Thread Andy Fleming
> omap_hsmmc.c:474: warning: implicit declaration of function 'get_cpu_rev' > > introduced by commit "MMC: omap_hsmmc.c: disable > multiblock rw on old rev omap34xx silicon" > (4ca9244d74f146a0605f5bee28a66e39aae88d3e) > > Sig

Re: [U-Boot] [PATCH] fsl_esdhc: Initialize mmc->b_max

2011-05-18 Thread Andy Fleming
On Fri, May 13, 2011 at 4:07 AM, Stefano Babic wrote: > On 05/12/2011 09:33 PM, Fabio Estevam wrote: >> commit 262951(MMC: make b_max unconditional) missed to update fsl_esdhc. >> >> Signed-off-by: Fabio Estevam Applied (and upstreamed), thanks! ___ U

[U-Boot] [PATCH] phylib: Detect link on 10G devices correctly

2011-05-18 Thread Andy Fleming
mask so only link-reporting devices are checked. Signed-off-by: Andy Fleming Reported-by: Ed Swarthout --- drivers/net/phy/generic_10g.c |8 ++-- include/linux/mdio.h |8 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/generic_10

[U-Boot] Please pull u-boot-mmc.git

2011-05-18 Thread Andy Fleming
are available in the git repository at: git://www.denx.de/git/u-boot-mmc.git master Dirk Behme (1): MMC: omap_hsmmc.c: Add missing prototype header Fabio Estevam (1): fsl_esdhc: Initialize mmc->b_max Lei Wen (2): cmd_mmc: eliminate device num in the mmc command mmc: en

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-05-11 Thread Andy Fleming
On Mon, May 2, 2011 at 9:27 PM, Lei Wen wrote: > > I have submit another round of patch, please review it whether it meet > your expectation. This is just a quick note to say I haven't forgotten about these or other patches in my queue. I'm just buried in other work at the moment. I intend to g

Re: [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1010RDB

2011-05-04 Thread Andy Fleming
>> >> + >> >> +#define udelay(x) {int i, j; for (i = 0; i < x; i++) for (j = 0; j < >> >> 1; j++); } >> > There were many comments on this udelay before, we should not use this >> > define, but use the udelay() which u-boot provides. >> > >> >> Is there a udelay that is defined for the nand_sp

[U-Boot] Please pull u-boot-mmc.git

2011-04-29 Thread Andy Fleming
are available in the git repository at: git://www.denx.de/git/u-boot-mmc.git master Jason Liu (1): fsl_esdhc: Fix multi-block read restriction on i.MX53 eSDHCv2 John Rigby (2): MMC: make b_max unconditional MMC: omap_hsmmc.c: disable multiblock rw on old rev omap34xx silicon

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-29 Thread Andy Fleming
On Wed, Apr 27, 2011 at 10:44 PM, Lei Wen wrote: >>> -                       mmc_init(mmc); >>> +               return 0; >>> +       } else if (strncmp(argv[1], "part", 4) == 0) { >>> +               block_dev_desc_t *mmc_dev; >>> +               struct mmc *mmc = find_mmc_device(mmc_cur_dev); >

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-29 Thread Andy Fleming
On Wed, Apr 27, 2011 at 2:12 PM, Wolfgang Denk wrote: > Dear Andy Fleming, > > In message you wrote: >> >> > From now on, follow the general rule "mmc dev [dev]" to change the >> > mmc command applied device, like ide and usb... > ... >>

[U-Boot] [PATCH] tsec: Fix MDIO on devices with eTSEC2

2011-04-29 Thread Andy Fleming
The tsec driver was defining the default MDIO address as the TSEC_BASE + 0x520, but on eTSEC2 controllers, the first TSEC's registers are separated from the MDIO registers. Use the existing MDIO_BASE_ADDR, instead. Signed-off-by: Andy Fleming --- include/tsec.h |2 +- 1 files chang

Re: [U-Boot] [PATCH v3 3/3] ARMV7: Vexpress: Add MMC support

2011-04-28 Thread Andy Fleming
It's on my todo list for today On Apr 28, 2011, at 1:46 PM, John Rigby wrote: > On Sat, Apr 16, 2011 at 3:53 PM, Matt Waddel > wrote: >> On 04/13/2011 05:09 AM, Andy Fleming wrote: >>> On Wed, Mar 2, 2011 at 11:22 PM, wrote: >>>> From: Matt Wadde

Re: [U-Boot] [PATCH V2 1/2] cmd_mmc: eliminate device num in the mmc command

2011-04-27 Thread Andy Fleming
On Fri, Apr 15, 2011 at 9:17 PM, Lei Wen wrote: > From now on, follow the general rule "mmc dev [dev]" to change the > mmc command applied device, like ide and usb... > > Signed-off-by: Lei Wen > --- > Changelog: > V2: use the "mmc_cur_dev" to replace explicitly specify the dev num >    in mmc co

[U-Boot] Please pull u-boot-mmc.git phylib

2011-04-20 Thread Andy Fleming
-boot-mmc.git phylib Andy Fleming (7): Remove instances of phy_read/write miiphy: Fix some formatting issues Create PHY Lib for U-Boot phylib: Add a bunch of PHY drivers from tsec tsec: Convert tsec to use PHY Lib fsl: Change fsl_phy_enet_if to phy_interface_t

Re: [U-Boot] [PATCHv2] MMC: disable multiblock rw on old rev OMAP3 silicon

2011-04-14 Thread Andy Fleming
On Apr 14, 2011, at 10:46 AM, John Rigby wrote: > Make existing field b_max field in struct mmc unconditional > and use it instead of CONFIG_SYS_MMC_MAX_BLK_COUNT in mmc_bread > and mmc_bwrite. > > Initialize b_max to CONFIG_SYS_MMC_MAX_BLK_COUNT in mmc_register > if it has not been initialized

[U-Boot] Please pull u-boot-mmc.git

2011-04-13 Thread Andy Fleming
I apologize for the long delay. Hopefully now that we're beginning to push out all of this p4080 stuff, I'll be able to stay on top of what's happening outside of Freescale. The following changes since commit b16aadf411280fc426d7488ddd8a5b2038b7194d: Lei Wen (1): disk/part.c: fix potent

Re: [U-Boot] [PATCH] cfi_flash: Fix CONFIG_SYS_FLASH_AUTOPROTECT_LIST

2011-04-13 Thread Andy Fleming
Ha! That's what I get for reading my emails in reverse. Peter already fixed it. On Wed, Apr 13, 2011 at 2:32 PM, Andy Fleming wrote: > The patch which created flash_protect_default(), moved the autoprotect > list code into that function, but left its variable declarations in

Re: [U-Boot] building breakage for xpedite5xxx boards

2011-04-13 Thread Andy Fleming
On Wed, Apr 13, 2011 at 10:08 AM, Kumar Gala wrote: > Not sure what broke it: > > [galak@right u-boot-85xx]$ cat LOG/xpedite520x.ERR > cfi_flash.c: In function 'flash_protect_default': > cfi_flash.c:2118:7: error: 'i' undeclared (first use in this function) > cfi_flash.c:2118:7: note: each undecla

[U-Boot] [PATCH] cfi_flash: Fix CONFIG_SYS_FLASH_AUTOPROTECT_LIST

2011-04-13 Thread Andy Fleming
The patch which created flash_protect_default(), moved the autoprotect list code into that function, but left its variable declarations in the init function. Signed-off-by: Andy Fleming --- drivers/mtd/cfi_flash.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff

Re: [U-Boot] [PATCH v3 1/4] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

2011-04-13 Thread Andy Fleming
> +       ret = smsc95xx_read_reg(dev, HW_CFG, &read_buf); > +       if (ret < 0) { > +               debug("Failed to read HW_CFG: %d\n", ret); > +               return ret; > +       } > +       debug("Read Value from HW_CFG: 0x%08x\n", read_buf); > + > +       if (turbo_mode) > +               r

Re: [U-Boot] [PATCH v5 0/9] Universal PHY Infrastructure

2011-04-13 Thread Andy Fleming
On Apr 13, 2011, at 7:01 AM, Detlev Zundel wrote: > Hi Andy, > >> Or PHY Lib for U-Boot. > > I've given acked-bys to parts of the changes that you sent already. As > you already ignored them the last time, I'm not reposting them. If you > want, you can add them yourself of course. I apologi

Re: [U-Boot] [RFC 2/3][v4] mmc: SEND_OP_COND considers card capabilities (voltage)

2011-04-13 Thread Andy Fleming
On Fri, Mar 11, 2011 at 6:01 AM, Raffaele Recalcati wrote: > From: Raffaele Recalcati > > The first SEND_OP_COND (CMD1) command added is used to ask card capabilities. > After it an AND operation is done between card capabilities and host > capabilities (at the moment only for the voltage field).

Re: [U-Boot] [PATCH v3 3/3] ARMV7: Vexpress: Add MMC support

2011-04-13 Thread Andy Fleming
maintainer wants to pull in the driver patch (with the previously-mentioned small change). Either way: Acked-by: Andy Fleming Andy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/3] MMC: Add support for PL180 ARM mmc device

2011-04-13 Thread Andy Fleming
On Wed, Mar 2, 2011 at 11:22 PM, wrote: > + > +static int convert_from_bytes_to_power_of_two(unsigned int x) > +{ > +       int y = 0; > +       y = (x & 0x) ? 1 : 0; > +       y |= ((x & 0x) ? 1 : 0) << 1; > +       y |= ((x & 0xF0F0) ? 1 : 0) << 2; > +       y |= ((x & 0xFF00) ? 1 : 0)

Re: [U-Boot] [U-BOOT] [PATCH] mmc: enable switch partition function

2011-04-13 Thread Andy Fleming
> >> > I want to get rid of the device argument in all these calls. >> >> So the the mmc read would becomes "mmc read [ram address] [mmc sector >> start] [sector num]"? > > Right.  That's what we use on other storage devices, too. Right now, getting rid of all of those is a bit of a chore. Persona

Re: [U-Boot] [PATCH 0/4] generic mmc_spi driver

2011-04-13 Thread Andy Fleming
On Tue, Apr 12, 2011 at 1:58 AM, Mike Frysinger wrote: > On Friday, December 24, 2010 02:16:05 Thomas Chou wrote: >> This is the v9 update of the mmc_spi driver. Please enable DEBUG on the top >> of mmc_spi.c and help me perform the tests. >> >> A new spi_set_speed() is added to meet the 400KHz cl

[U-Boot] [RFC] Allow for parallel builds and saved output

2011-04-13 Thread Andy Fleming
to work (only took 16 min on our 24-core server). Signed-off-by: Andy Fleming --- MAKEALL | 67 +++--- 1 files changed, 59 insertions(+), 8 deletions(-) diff --git a/MAKEALL b/MAKEALL index e1b928f..071027c 100755 --- a/MAKEALL +++

[U-Boot] [PATCH v5 2/9] tsec: arrange the code to avoid useless function declaration

2011-04-13 Thread Andy Fleming
From: Mingkai Hu This is merely a rearrangement. No changes to the code, except to remove now-useless declarations. Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- drivers/net/tsec.c | 855 +--- 1 files changed

[U-Boot] [PATCH v5 6/9] phylib: Add a bunch of PHY drivers from tsec

2011-04-13 Thread Andy Fleming
possible). Also, noticed that almost all of the vitesse/cicada PHYs had the same config/parse/startup functions, so those have been collapsed into one. Signed-off-by: Andy Fleming Signed-off-by: Kumar Gala --- v5: * Fix Marvell PHY drivers so they reset after a reconfig * Modify Teranetics

[U-Boot] [PATCH v5 9/9] Add mdio command for new PHY infrastructure

2011-04-13 Thread Andy Fleming
ent, though for clause 22 PHYs, the argument can be "-". Signed-off-by: Andy Fleming --- common/Makefile |3 + common/cmd_mdio.c | 286 + 2 files changed, 289 insertions(+), 0 deletions(-) create mode 100644 common/cmd_md

[U-Boot] [PATCH v5 8/9] fsl: Change fsl_phy_enet_if to phy_interface_t

2011-04-13 Thread Andy Fleming
switch all clients of fsl_phy_enet_if over to phy_interface_t, which should become the standard, anyway. Signed-off-by: Andy Fleming --- arch/powerpc/cpu/mpc8xxx/fdt.c| 23 ++-- arch/powerpc/include/asm/fsl_enet.h | 17 + board/freescale/mpc8360emds

[U-Boot] [PATCH v5 4/9] miiphy: Fix some formatting issues

2011-04-13 Thread Andy Fleming
Mostly putting a space between function name and "(", and doing return (foo) Signed-off-by: Andy Fleming --- v3: split off from the phylib changes to miiphyutil.c and miiphy.h common/miiphyutil.c | 144 +- include/miiphy.h

[U-Boot] [PATCH v5 3/9] Remove instances of phy_read/write

2011-04-13 Thread Andy Fleming
rvell_init function which I renamed to not conflict with the one in marvell.c Lastly, uec_phy.c was putting a space between the phy writing function names, and the open paren, so I fixed that Signed-off-by: Andy Fleming --- drivers/net/dm9000x.c | 18 +++--- drivers/net/enc28j60.c | 24 ---

[U-Boot] [PATCH v5 0/9] Universal PHY Infrastructure

2011-04-13 Thread Andy Fleming
this new version to git://git.denx.de/u-boot/u-boot-mmc.git in the phylib branch Andy Fleming (7): Remove instances of phy_read/write miiphy: Fix some formatting issues Create PHY Lib for U-Boot phylib: Add a bunch of PHY drivers from tsec tsec: Convert tsec to use PHY Lib fsl: Change

[U-Boot] [PATCH v5 1/9] tsec: use IO accessors for IO accesses

2011-04-13 Thread Andy Fleming
From: Mingkai Hu Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- v3: Removed unnecessary syncs v2: Fixed the commit message's spelling drivers/net/tsec.c | 249 ++-- include/tsec.h |8 +- 2 files ch

Re: [U-Boot] [PATCH v3 0/8] Universal PHY Infrastructure

2011-04-08 Thread Andy Fleming
Latest changes are now in the u-boot-mmc.git repo, in the phylib branch. I changed patches 5 and 7, the new versions of which are being sent now. On Thu, Apr 7, 2011 at 11:49 PM, Mike Frysinger wrote: > do you have a git tree hosting these changes ? > -mike > > __

[U-Boot] [PATCH v3 6/8] phylib: Add a bunch of PHY drivers from tsec

2011-04-07 Thread Andy Fleming
possible). Also, noticed that almost all of the vitesse/cicada PHYs had the same config/parse/startup functions, so those have been collapsed into one. Signed-off-by: Andy Fleming --- v3: * Add phy_ prefix to PHY driver init functions * Rename phylib_all_drivers.h to config_phylib_all_drivers.h

[U-Boot] [PATCH v3 3/8] Remove instances of phy_read/write

2011-04-07 Thread Andy Fleming
rvell_init function which I renamed to not conflict with the one in marvell.c Lastly, uec_phy.c was putting a space between the phy writing function names, and the open paren, so I fixed that Signed-off-by: Andy Fleming --- drivers/net/dm9000x.c | 18 +++--- drivers/net/enc28j60.c | 24 ---

[U-Boot] [PATCH v3 8/8] Add mdio command for new PHY infrastructure

2011-04-07 Thread Andy Fleming
ent, though for clause 22 PHYs, the argument can be "-". Signed-off-by: Andy Fleming --- * Eliminate busname:addr mechanism * Switch to specifying devad like in the spec: "devad.reg". This means accessing Clause-22-style buses doesn't require a '-' arg

[U-Boot] [PATCH v3 4/8] miiphy: Fix some formatting issues

2011-04-07 Thread Andy Fleming
Mostly putting a space between function name and "(", and doing return (foo) Signed-off-by: Andy Fleming --- This is split off from the phylib changes to miiphyutil.c and miiphy.h common/miiphyutil.c | 144 +- include/miiphy.h

[U-Boot] [PATCH v3 1/8] tsec: use IO accessors for IO accesses

2011-04-07 Thread Andy Fleming
From: Mingkai Hu Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- v2: Fixed the commit message's spelling v3: Removed unnecessary syncs drivers/net/tsec.c | 249 ++-- include/tsec.h |8 +- 2 files ch

[U-Boot] [PATCH v3 2/8] tsec: arrange the code to avoid useless function declaration

2011-04-07 Thread Andy Fleming
From: Mingkai Hu This is merely a rearrangement. No changes to the code, except to remove now-useless declarations. Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- drivers/net/tsec.c | 855 +--- 1 files changed

[U-Boot] [PATCH v3 0/8] Universal PHY Infrastructure

2011-04-07 Thread Andy Fleming
are described in the specs and in the data sheets. ie: Register 7.1 - AN Status I've put the relevant changelogs in the patches. Enjoy! Andy Fleming (6): Remove instances of phy_read/write miiphy: Fix some formatting issues Create PHY Lib for U-Boot phylib: Add a bunch of PHY driver

Re: [U-Boot] [PATCH v2 4/6] Create PHY Lib for U-Boot

2011-04-07 Thread Andy Fleming
On Apr 6, 2011, at 6:09 PM, Mike Frysinger wrote: > On Tuesday, April 05, 2011 17:59:52 Andy Fleming wrote: >> -#define debug(fmt,args...) printf (fmt ,##args) >> +#define debug(fmt, args...) printf(fmt, ##args) > > it'd be nice if all these unrelated formatting c

Re: [U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure

2011-04-07 Thread Andy Fleming
On Apr 6, 2011, at 7:07 AM, Detlev Zundel wrote: > Hi Andy, > >> This second version cleans up all checkpatch errors that I reasonably could, >> and addresses most of the comments from the first round of reviews. > > WARNING: Use of volatile is usually wrong: see > Documentation/volatile-cons

[U-Boot] [PATCH v2 5/6] phylib: Add a bunch of PHY drivers from tsec

2011-04-05 Thread Andy Fleming
possible). Also, noticed that almost all of the vitesse/cicada PHYs had the same config/parse/startup functions, so those have been collapsed into one. Signed-off-by: Andy Fleming --- * Added teranetics_init() to init function * Sorted init functions in phy_init and in phy.h * Sorted PHYs in

[U-Boot] [PATCH v2 2/6] tsec: arrange the code to avoid useless function declaration

2011-04-05 Thread Andy Fleming
From: Mingkai Hu This is merely a rearrangement. No changes to the code, except to remove now-useless declarations. Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- Added clarification to the commit message drivers/net/tsec.c | 861

[U-Boot] [PATCH v2 0/6] Universal PHY Infrastructure

2011-04-05 Thread Andy Fleming
mmand line. I should submit a new version of that, soon. I also got Kumar to remove the tsec patches I reworked slightly from his tree, so that these can go in without conflict. Andy Fleming (4): Remove instances of phy_read/write Create PHY Lib for U-Boot phylib: Add a bunch of PHY dr

[U-Boot] [PATCH v2 1/6] tsec: use IO accessors for IO accesses

2011-04-05 Thread Andy Fleming
From: Mingkai Hu Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- Fixed the commit message's spelling drivers/net/tsec.c | 242 +++- include/tsec.h |8 +- 2 files changed, 130 insertions(+), 120 dele

[U-Boot] [PATCH v2 3/6] Remove instances of phy_read/write

2011-04-05 Thread Andy Fleming
rvell_init function which I renamed to not conflict with the one in marvell.c Lastly, uec_phy.c was putting a space between the phy writing function names, and the open paren, so I fixed that Signed-off-by: Andy Fleming --- Fixed some sparse errors/warnings drivers/net/dm9000x.c | 18 +++--- d

Re: [U-Boot] [PATCH 1/2] env_mmc: Allow board code to override the environment address

2011-04-04 Thread Andy Fleming
t; > Signed-off-by: Mingkai Hu > Signed-off-by: Jerry Huang > Signed-off-by: Zhao Chenhui > Signed-off-by: Kumar Gala Acked-by: Andy Fleming I just transferred the patchworks "todo" to galak, to make it easier for the follow-on patch to be applied, and an

Re: [U-Boot] mpq101 board broken

2011-03-31 Thread Andy Fleming
I ran into this, too, but it went away when I updated my compiler. It looks like the beginning was set a little too close to the end? On Thu, Mar 31, 2011 at 9:55 AM, Wolfgang Denk wrote: > Dear Alex, > > the mpq101 board support is broken in recent versions of U-Boot: > > Configuring for mpq101

Re: [U-Boot] [PATCH 6/7] phylib: Add a bunch of PHY drivers from tsec

2011-03-30 Thread Andy Fleming
On Mar 30, 2011, at 7:26 AM, Detlev Zundel wrote: > Hi Andy, > >> The tsec driver had a bunch of PHY drivers already written. This >> converts them all into PHY Lib drivers, and serves as the first >> set of PHY drivers for PHY Lib. >> >> Signed-off-by:

Re: [U-Boot] [PATCH 5/7] Add mdio command for new PHY infrastructure

2011-03-30 Thread Andy Fleming
On Mar 30, 2011, at 6:55 AM, Detlev Zundel wrote: > Hi Andy, > > >> +static int extract_range(char *input, int *plo, int *phi) >> +{ >> +char * end; >> +*plo = simple_strtol(input, &end, 0); >> +if (end == input) >> +return -1; >> + >> +if (*end == '-') { > > What a

[U-Boot] [PATCH 3/7] Remove instances of phy_read/write

2011-03-29 Thread Andy Fleming
rvell_init function which I renamed to not conflict with the one in marvell.c Signed-off-by: Andy Fleming --- drivers/net/dm9000x.c | 18 +++--- drivers/net/enc28j60.c | 24 drivers/net/uli526x.c | 24 drivers/qe/uec.c |3 - drivers/qe/uec_phy.

[U-Boot] [PATCH 5/7] Add mdio command for new PHY infrastructure

2011-03-29 Thread Andy Fleming
ent, though for clause 22 PHYs, the argument can be "-". Signed-off-by: Andy Fleming --- common/Makefile |3 + common/cmd_mdio.c | 293 + 2 files changed, 296 insertions(+), 0 deletions(-) create mode 100644 common/cmd_md

[U-Boot] [PATCH 6/7] phylib: Add a bunch of PHY drivers from tsec

2011-03-29 Thread Andy Fleming
The tsec driver had a bunch of PHY drivers already written. This converts them all into PHY Lib drivers, and serves as the first set of PHY drivers for PHY Lib. Signed-off-by: Andy Fleming --- drivers/net/phy/Makefile | 10 ++ drivers/net/phy/atheros.c| 37 + drivers/net/phy

[U-Boot] [PATCH 2/7] tsec: arrange the code to avoid useless function declaration

2011-03-29 Thread Andy Fleming
From: Mingkai Hu Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- drivers/net/tsec.c | 857 +--- 1 files changed, 416 insertions(+), 441 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index

[U-Boot] [RFC 0/7] Universal PHY Infrastructure

2011-03-29 Thread Andy Fleming
to Mingkai Hu, who did a substantial amount of work up front to convert the tsec PHY code into something more usable, which I have mostly copied for the purposes of PHY Lib. As the subject says, these are submitted here for comment. I hope they will go in for the presumptive June release. Andy

[U-Boot] [PATCH 4/7] Create PHY Lib for U-Boot

2011-03-29 Thread Andy Fleming
ivers interact with the PHY Lib using these functions: phy_connect() phy_config() phy_startup() phy_shutdown() Each PHY driver can be configured separately, or all at once using phylib_all_drivers.h (added in the patch which adds the drivers) Signed-off-by: Andy Fleming --- common/Mak

[U-Boot] [PATCH 1/7] tsec: use IO accessories to access the register

2011-03-29 Thread Andy Fleming
From: Mingkai Hu Signed-off-by: Mingkai Hu Acked-by: Andy Fleming Signed-off-by: Kumar Gala --- drivers/net/tsec.c | 234 ++- include/tsec.h |8 +- 2 files changed, 123 insertions(+), 119 deletions(-) diff --git a/drivers/net/tsec.c b

Re: [U-Boot] [PATCH] fsl_esdhc: Correcting esdhc timeout counter calculation

2011-02-24 Thread Andy Fleming
On Thu, Feb 24, 2011 at 3:50 AM, Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <1298537614-20797-1-git-send-email-ga...@kernel.crashing.org> you > wrote: >> >> - Timeout counter value is set as DTOCV bits in SYSCTL register >>   For counter value set as x, >>   Timeout period = (2^(13+x)

Re: [U-Boot] [PATCH 08/14] tsec: arrange the code to avoid useless function declaration

2011-02-02 Thread Andy Fleming
On Jan 26, 2011, at 10:52 PM, Mingkai Hu wrote: > Signed-off-by: Mingkai Hu Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 07/14] tsec: use IO accessories to access the register

2011-02-02 Thread Andy Fleming
On Jan 26, 2011, at 10:52 PM, Mingkai Hu wrote: > Signed-off-by: Mingkai Hu Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [STATUS] Custodian changes, using Patchwork

2010-11-16 Thread Andy Fleming
I'm afleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

2010-06-29 Thread Andy Fleming
d add a working > configuration for P2020RDB. > > Signed-off-by: Felix Radensky Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] 85xx/p1_p2_rdb: Modify the CLK_CTRL value for DDR at 667MHz

2010-06-29 Thread Andy Fleming
wal Oops, forgot to reply all: Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] [Bugfix] 85xx/p1_p2_rdb: not able to modify "$bootfile" environment variable

2010-06-29 Thread Andy Fleming
On Wed, Jun 23, 2010 at 9:12 AM, Poonam Aggrwal wrote: > Because the variable was getting defined twice. > Signed-off-by: Poonam Aggrwal Acked-by: Andy Fleming > --- >  include/configs/P1_P2_RDB.h |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) > > diff --

Re: [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()

2010-06-04 Thread Andy Fleming
On Jun 4, 2010, at 4:01 PM, Timur Tabi wrote: > Andy Fleming wrote: > >> The old way continued even if one of the tsecs failed to initialize. Let's >> preserve the original behavior in that sense: >> >> for (i = 0; i < num; i++) { >> ret =

Re: [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()

2010-06-04 Thread Andy Fleming
On Jun 4, 2010, at 3:50 PM, Timur Tabi wrote: > The Ethernet initialization functions are supposed to return the number of > devices initialized, so fix tsec_eth_init() so that it returns the number of > TSECs initialized instead of just zero. This is safe because the return value > is currently

Re: [U-Boot] [PATCH RFC v2] OMAP: mmc: add support for second and third mmc channels

2010-05-14 Thread Andy Fleming
On Thu, Apr 29, 2010 at 3:26 PM, Steve Sakoman wrote: > This patch adds support for the second and third mmc channels on OMAP3 > processors > > Boards wishing to use this feature should define CONFIG_SYS_MMC_SET_DEV > > Tested on Overo > > Signed-off-by: Steve Sakoman Applied, thanks! __

Re: [U-Boot] [PATCH 3/5] Davinci Multiblock MMC

2010-05-14 Thread Andy Fleming
On Wed, May 12, 2010 at 4:48 AM, Alagu Sankar wrote: > Multi-block Read/Write support for Davinci.  Uses the new CONFIG_MMC_MBLOCK > feature under Generic MMC framework. > > Signed-off-by: Alagu Sankar You'll have to modify this, as I've gone and eliminated the MBLOCK config option, so now you j

Re: [U-Boot] [PATCH 2/5] Davinci MMCSD Support

2010-05-14 Thread Andy Fleming
controllers. > > Signed-off-by: Alagu Sankar I'm thinking this is probably the ARM maintainer's domain, so I'll just say: Acked-by: Andy Fleming ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/4] MMC Multi-block Support

2010-05-14 Thread Andy Fleming
On Wed, May 12, 2010 at 4:38 AM, Alagu Sankar wrote: > Added Multi-Block Read support for Generic MMC. Modified existing multi-block > write to limit the maximum number of blocks per transfer.  This feature is > enabled with CONFIG_MMC_MBLOCK option.  A new member is added in the mmc > structure f

<    1   2   3   4   5   6   >