On 09/05/24 19:50, Hari Nagalla wrote:
> Add AM62a remote proc firmware names to environment variables for
> loading of C7x DSP and R5F processors.
>
> Signed-off-by: Hari Nagalla
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> board/ti/am62ax/am62ax.env | 4
&g
On 09/05/24 19:50, Hari Nagalla wrote:
> Enable K3-DSP and K3-R5FSS remote proc drivers for am62ax.
>
> Signed-off-by: Hari Nagalla
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> configs/am62ax_evm_a53_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
&
On 09/05/24 19:50, Hari Nagalla wrote:
> AM62A has a R5F core in MCU voltage domain.
> Extend support for R5F remote proc driver on AM62A with compatible
> strings.
>
> Signed-off-by: Hari Nagalla
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> drivers/remoteproc/t
On 09/05/24 19:50, Hari Nagalla wrote:
> AM62A SoC has a single C71x DSP subsystem with analytics engine in
> main voltage domain. Extend support to AM62A with compatible strings.
>
> Signed-off-by: Hari Nagalla
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
>
Gentle Reminder.
On 08/03/24 16:38, Devarsh Thakkar wrote:
> Hi Tom, Anatolij, Simon,
>
> On 22/02/24 18:38, Devarsh Thakkar wrote:
>> This adds support for simple-framebuffer reservation using video handoff
>> when splash is enabled at SPL stage.
>>
>> Also ad
mory that SPL will be running from.
>
> +config SPL_SOC_INIT
> + bool "Call arch-specific initialization in SPL"
Call SoC specific intialization in SPL
With above change,
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> + help
> + If this option is enabl
Hi Tom, Lukas,
Thanks for the patch Lukas.
On 20/03/24 20:00, Tom Rini wrote:
> On Wed, Mar 20, 2024 at 02:19:26PM +0100, lukas.funke-...@weidmueller.com
> wrote:
>
>> From: Lukas Funke
>>
>> Some architectures use spl_board_init() in their architecture specific
>> implementation. Board
Hi Tom, Anatolij, Simon,
On 22/02/24 18:38, Devarsh Thakkar wrote:
> This adds support for simple-framebuffer reservation using video handoff
> when splash is enabled at SPL stage.
>
> Also adds helper function to only enable framebuffer reservation without
> enabling simple-fram
Hi,
On 22/02/24 18:38, Devarsh Thakkar wrote:
> Update simple-framebuffer device-tree node by enumerating framebuffer
> related information in existing simple-framebuffer node in Linux
> device-tree file and enabling it.
>
> In case there is no simple-framebuffer stub detected
the device-tree to
reserve the framebuffer region for the active splash screen.
This helps preserve the splash screen till the display server takes over
after OS is booted.
Signed-off-by: Devarsh Thakkar
---
board/ti/am62x/evm.c | 19 +++
1 file changed, 19 insertions(+)
diff --git
and thus not requiring
simple-framebuffer.
Signed-off-by: Devarsh Thakkar
---
boot/fdt_simplefb.c | 12 +---
boot/fdt_support.c| 21 +
include/fdt_support.h | 2 ++
3 files changed, 24 insertions(+), 11 deletions(-)
diff --git a/boot/fdt_simplefb.c b/boot
If SPL is passing video handoff structure to U-boot then it is safe to
assume that SPL has already enabled video and that's why it is passing
video handoff structure to U-boot so that U-boot can preserve the
framebuffer.
Signed-off-by: Devarsh Thakkar
---
drivers/video/video-uclass.c | 4
Enable and update simple-framebuffer node using the video handoff
bloblist if video was enabled at SPL stage and corresponding video
bloblist was received at u-boot proper with necessary parameters.
Signed-off-by: Devarsh Thakkar
---
boot/fdt_simplefb.c | 34
else in between until
kernel boots up.
Lastly, it enables above support on AM62x.
Devarsh Thakkar (4):
boot: fdt_simplefb: Enumerate framebuffer info from video handoff
video: Assume video to be active if SPL is passing video hand-off
boot: Move framebuffer reservation to separate helper
Hi Anatolij, Tom,
On 08/01/24 13:32, Devarsh Thakkar wrote:
Hi Anatolij, Tom,
On 26/12/23 15:17, Simon Glass wrote:
On Wed, Dec 13, 2023 at 2:56 PM Devarsh Thakkar wrote:
Hi Antoine,
On 05/12/23 21:25, Devarsh Thakkar wrote:
Move video memory reservation for SPL at end of RAM so
Hi Anatolij,Tom
On 24/01/24 17:28, Nikhil Jain wrote:
Hi Devarsh,
On 24/01/24 14:37, Devarsh Thakkar wrote:
Use device-tree node property names for parsing nodes instead of
indexing as indexing could be different between different SoCs based on
number of DSS entities available
Hi Simon, Tom,
On 24/01/24 17:26, Nikhil Jain wrote:
Hi Devarsh,
On 24/01/24 14:35, Devarsh Thakkar wrote:
Don't compile ubifs splash mount command for SPL build as this command
is not supported (and also not enabled) during SPL stage.
This fixes below compilation error, when
/v6.8-rc1/arch/arm64/boot/dts/ti/k3-am62-main.dtsi#L774
Fixes: 5f9f816bb8 ("drivers: video: tidss: TIDSS video driver support
for AM62x")
Signed-off-by: Devarsh Thakkar
---
drivers/video/tidss/tidss_drv.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dri
PL")
Signed-off-by: Devarsh Thakkar
---
V2: Drop repeat sentence in commit msg
common/splash_source.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/splash_source.c b/common/splash_source.c
index 7223a1aae7..2ce0768833 100644
--- a/common/splash_source.c
+++ b/co
make: ***
[Makefile:177: sub-make] Error 2"
Fixes: eb9217dc03 ("common: Enable splash functions at SPL")
Signed-off-by: Devarsh Thakkar
---
common/splash_source.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/splash_source.c b/common/splash_source.c
index 7223a1aae
Hi Anatolij, Tom,
On 26/12/23 15:17, Simon Glass wrote:
> On Wed, Dec 13, 2023 at 2:56 PM Devarsh Thakkar wrote:
>>
>> Hi Antoine,
>>
>> On 05/12/23 21:25, Devarsh Thakkar wrote:
>>> Move video memory reservation for SPL at end of RAM so that it does
>>&
Hi Antoine,
On 05/12/23 21:25, Devarsh Thakkar wrote:
> Move video memory reservation for SPL at end of RAM so that it does
> not interefere with reservations for next stage so that the next stage
> need not have holes in between for passed regions and instead it can
> maintai
Add details regarding scheme which need to be followed in SPL and
further stages for those regions which need to be preserved across
bootstages.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V1->V3:
No change.
V4:
Split this to separate patch and add more details regarding
mem
Add info regarding splash screen, video, bloblist and GPIO related
Kconfigs which were missing in the documentation.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2: No change
V3: No change
V4: Patch split from parent
V5: Add Reviewed-by
---
doc/develop/spl.rst | 9 +
1
that
address in discussion is of framebuffer and not bloblist and also match
it with printing scheme followed in video_reserve function.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2:
- Add debug prints
- Fix commenting style
V3:
- Fix commenting style
V4:
- Remove extra checks on gd
framebuffer size in video hand-off structure use the
actual framebuffer region size as derived from gd->video_top and
gd->video_bottom instead of directly using the size populated in
video_uc_plat as it contains unaligned size.
Reported-by: Simon Glass
Signed-off-by: Devarsh Thakkar
Re
reservations start only after regions
reserved for previous stages
Skip reservation for video memory if it was already filled by a
bloblist.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2: Fix typo in commit title and checkpatch warnings/checks
V3: No change
V4: Add Reviewed-by
V5
Remove video_setup from evm_init sequence since video memory is getting
called at an earlier place to make sure video memory is reserved at
the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2: No change
V3: No change
V4: Add Reviewed-by
V5
out
having to make any gaps/holes to accommodate those regions which was the
case before as previous stage reserved region not from the end of RAM.
Use gd->ram_top instead of local ram_top and update gd->reloc_addr after
each reservation to ensure further regions are reserved properly.
Signed
Add an API which enforces framebuffer reservation from end of RAM.
This is done so that next stage can directly skip this region before
carrying out further reservations.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2:
No change.
V3:
Change spl_reserve_video
essage
for video memory reservation from bloblist.
- Add Reviewed-By.
V5:
- Add comment for filling video handoff size with aligned size
- Use PHASE_BOARD_F while checking for U-boot proper stage
- Add Reviewed-by
Test logs:
https://gist.github.com/devarsht/30a3c1591270c9ebae00714b48d33058
Devarsh T
watchdog.h
> inclusion to outside the USE_HOSTCC area. But at some point the #ifdefs
> from these files will likely be removed, so there is no benefit in
> going that way.
>
> Signed-off-by: Simon Glass
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
>
> Chang
Hi Simon,
Thanks for the review.
On 02/12/23 23:53, Simon Glass wrote:
> Hi Devarsh,
>
> On Sat, 25 Nov 2023 at 07:27, Devarsh Thakkar wrote:
>>
>> Hi Simon,
>>
>> Thanks for the review.
>>
>> On 13/11/23 01:31, Simon Glass wrote:
>>> Hi
Add details regarding scheme which need to be followed in SPL and
further stages for those regions which need to be preserved across
bootstages.
Signed-off-by: Devarsh Thakkar
---
V1->V3:
No change.
V4:
Split this to separate patch and add more details regarding
memory reservation sch
Add info regarding splash screen, video, bloblist and GPIO related
Kconfigs which were missing in the documentation.
Signed-off-by: Devarsh Thakkar
---
V2: No change
V3: No change
V4: Patch split from parent
---
doc/develop/spl.rst | 9 +
1 file changed, 9 insertions(+)
diff --git
-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2:
- No change
V3:
- Fix commit message per review comment
- Add a note explaining assumption of single framebuffer
V4:
- Wrap message to 72 chars
---
drivers/video/video-uclass.c | 29 +++--
1 file changed, 19 insertions
that
address in discussion is of framebuffer and not bloblist and also match
it with printing scheme followed in video_reserve function.
Signed-off-by: Devarsh Thakkar
---
V2:
- Add debug prints
- Fix commenting style
V3:
- Fix commenting style
V4:
- Remove extra checks on gd for video data in video_reserve
reservations start only after regions
reserved for previous stages
Skip reservation for video memory if it was already filled by a
bloblist.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2: Fix typo in commit title and checkpatch warnings/checks
V3: No change
V4: Add Reviewed-by
---
common
Remove video_setup from evm_init sequence since video memory is getting
called at an earlier place to make sure video memory is reserved at
the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2: No change
V3: No change
V4: Add Reviewed
Add an API which enforces framebuffer reservation from end of RAM.
This is done so that next stage can directly skip this region before
carrying out further reservations.
Signed-off-by: Devarsh Thakkar
---
V2:
No change.
V3:
Change spl_reserve_video to spl_reserve_video_from_ram_top
which
essage
for video memory reservation from bloblist.
- Add Reviewed-By.
Test logs:
https://gist.github.com/devarsht/6a748b1d69bd2a4b60695a5e7776db73
Devarsh Thakkar (8):
spl: Enforce framebuffer reservation from end of RAM
arm: mach-k3: common: Reserve video memory from end of the RAM
board: ti: am62
out
having to make any gaps/holes to accommodate those regions which was the
case before as previous stage reserved region not from the end of RAM.
Use gd->ram_top instead of local ram_top and update gd->reloc_addr after
each reservation to ensure further regions are reserved properly.
Signed
Hi Simon,
Thanks for the review.
On 13/11/23 01:31, Simon Glass wrote:
> Hi Devarsh,
>
> On Fri, 10 Nov 2023 at 08:29, Devarsh Thakkar wrote:
>>
>> Fill video handoff fields in video_post_probe
>> as at this point we have full framebuffer-related
>> informatio
Add information regarding memory reservation scheme in SPL
and details regarding scheme which need to be followed while reserving
those areas which need to be preserved across bootstages.
Also add missing CONFIG_SPL Kconfigs and new ones which were added
recently.
Signed-off-by: Devarsh Thakkar
-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2:
- No change
V3:
- Fix commit message per review comment
- Add a note explaining assumption of single framebuffer
---
drivers/video/video-uclass.c | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git
Skip framebufer reservation if it was already reserved
from previous stage and whose information was passed
using a bloblist.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2:
- Add debug prints
- Fix commenting style
V3:
- Fix commenting style
---
drivers/video/video-uclass.c
reservations
start only after regions reserved for previous stages
Skip reservation for video memory if it was already
filled by a bloblist.
Signed-off-by: Devarsh Thakkar
---
V2: Fix typo in commit title and checkpatch warnings/checks
V3: No change
---
common/board_f.c | 33
Remove video_setup from evm_init sequence since video memory
is getting called at an earlier place to make sure
video memory is reserved at the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2: No change
V3: No change
---
board/ti/am62x/evm.c | 18
vation
- Update SPL doc with spl splash screen specific info
Test logs (at tip of U-Boot 2024.01-rc1 + these patches):
https://gist.github.com/devarsht/6a748b1d69bd2a4b60695a5e7776db73
Devarsh Thakkar (6):
arm: mach-k3: common: Reserve video memory from end of the RAM
board: ti: am62x: evm:
regions which was the case before as previous stage
reserved region not from the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2:
- Make a generic function "spl_reserve_video" under
common/spl which can be re-used by other platforms too
for reserving video m
Hi Simon,
Thanks for the review.
On 05/11/23 01:13, Simon Glass wrote:
> Hi Devarsh,
>
> On Fri, 3 Nov 2023 at 11:48, Devarsh Thakkar wrote:
>>
>> Hi Simon,
>>
>> Thanks for the review.
>>
>> On 03/11/23 04:16, Simon Glass wrote:
>>> Hi
Hi Simon,
Thanks for the review.
On 03/11/23 04:16, Simon Glass wrote:
On Tue, 31 Oct 2023 at 13:12, Devarsh Thakkar wrote:
Skip framebufer reservation if it was already reserved
from previous stage and whose information was passed
using a bloblist.
Signed-off-by: Devarsh Thakkar
Reviewed
Hi Simon,
Thanks for the review.
On 03/11/23 04:16, Simon Glass wrote:
Hi Devarsh,
On Tue, 31 Oct 2023 at 13:12, Devarsh Thakkar wrote:
Start reservations needed for init sequence only after catching
bloblists from previous stage.
This is to avoid catching bloblists in the middle causing
Hi Simon,
Thanks for the review.
On 03/11/23 04:16, Simon Glass wrote:
Hi Devarsh,
On Tue, 31 Oct 2023 at 13:12, Devarsh Thakkar wrote:
Add function spl_reserve_video which is a wrapper
around video_reserve to setup video memory and update
the relocation address pointer.
Setup video
-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2: No change
---
drivers/video/video-uclass.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index 335a1a1828..635b70f668 100644
--- a/drivers
Skip framebufer reservation if it was already reserved
from previous stage and whose information was passed
using a bloblist.
Signed-off-by: Devarsh Thakkar
Reviewed-by: Simon Glass
---
V2:
- Add debug prints
- Fix commenting style
---
drivers/video/video-uclass.c | 12
1 file
reservations
start only after regions reserved for previous stages
Skip reservation for video memory if it was already
filled by a bloblist.
Signed-off-by: Devarsh Thakkar
---
V2: Fix typo in commit title and checkpatch warnings/checks
---
common/board_f.c | 33 ++---
1 file
Remove video_setup from evm_init sequence since video memory
is getting called at an earlier place to make sure
video memory is reserved at the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2: No change
---
board/ti/am62x/evm.c | 18 --
1 file
regions which was the case before as previous stage
reserved region not from the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
V2: Make a generic function "spl_reserve_video" under
common/spl which can be re-used by other platforms too
for reserving vi
/43dbcc02c585a0b18f8f99e910bf5ef9
Devarsh Thakkar (5):
arm: mach-k3: common: Reserve video memory from end of the RAM
board: ti: am62x: evm: Remove video_setup from spl_board_init
common/board_f: Catch bloblist before starting resevations
video: Skip framebuffer reservation if already reserved
video: Fill video
Hi Simon,
Thanks for the review.
On 19/10/23 19:26, Simon Glass wrote:
> Hi Devarsh,
>
> On Mon, 16 Oct 2023 at 10:06, Devarsh Thakkar wrote:
>>
>> Move the function to setup video memory before page table
>> reservation so that framebuffer memory gets rese
Hi Simon, Tom,
On 10/10/23 20:27, Simon Glass wrote:
> Hi Devarsh,
>
> On Fri, 22 Sept 2023 at 15:49, Devarsh Thakkar wrote:
>>
>> Hi Simon,
>>
>> On 22/09/23 23:57, Simon Glass wrote:
>>> Hi Devarsh,
>>>
>>> On Tue, 12 Se
-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
drivers/video/video-uclass.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
index bac30187e7..2a605f8339 100644
--- a/drivers/video/video
Skip framebufer reservation if it was already reserved
from previous stage and whose information was passed
using a bloblist.
Signed-off-by: Devarsh Thakkar
---
drivers/video/video-uclass.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/video/video-uclass.c b/drivers/video
reservations
start only after regions reserved for previous stages
Skip reservation for video memory if it was already
filled by a bloblist.
Signed-off-by: Devarsh Thakkar
---
common/board_f.c | 36 +---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/common
Remove video_setup from evm_init sequence since it is now
getting called at an earlier place now to make sure
video memory is reserved at the end of RAM.
Suggested-by: Simon Glass
Signed-off-by: Devarsh Thakkar
---
board/ti/am62x/evm.c | 18 --
1 file changed, 18 deletions
Signed-off-by: Devarsh Thakkar
---
arch/arm/mach-k3/common.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3/common.c
index cc755dd1bf..3978b9ccca 100644
--- a/arch/arm/mach-k3/common.c
+++ b/arch/arm/mach-k3/common.c
@@ -27,6
...@mail.gmail.com/
For filling missing video handoff fields :
https://lore.kernel.org/all/CAPnjgZ1Hs0rNf0JDirp6YPsOQ5=qqqsp9g9qrwlooasuv8a...@mail.gmail.com/
*** SUBJECT HERE ***
Devarsh Thakkar (5):
arm: mach-k3: common: Reserve video memory from end of the RAM
board: ti: am62x: evm: Remove video_setup
Hi Simon,
On 22/09/23 23:57, Simon Glass wrote:
Hi Devarsh,
On Tue, 12 Sept 2023 at 08:35, Devarsh Thakkar wrote:
Hi Simon,
On 11/09/23 04:44, Simon Glass wrote:
Hi Devarsh,
On Thu, 17 Aug 2023 at 09:10, Tom Rini wrote:
On Wed, Aug 16, 2023 at 09:16:05PM +0530, Devarsh Thakkar wrote
Hi Simon,
On 11/09/23 04:44, Simon Glass wrote:
> Hi Devarsh,
>
> On Thu, 17 Aug 2023 at 09:10, Tom Rini wrote:
>>
>> On Wed, Aug 16, 2023 at 09:16:05PM +0530, Devarsh Thakkar wrote:
>>> Hi Simon,
>>>
>>> On 15/08/23 20:14, Simon Glass wrote:
>
correctly.
Fixes: bde6ac54905 ("configs: am65x_evm: Switch envboot out for
distro_bootcmd")
Signed-off-by: Devarsh Thakkar
---
Boot logs (with display overlay) :
https://gist.github.com/devarsht/2bac56933847d3e954d6ee275d711e27
---
configs/am65x_evm_a53_defconfig | 2 +-
1 file changed, 1
;
> Signed-off-by: Nikhil M Jain
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> ---
> board/ti/am62x/am62x.env | 2 +-
> tools/logos/{ti.bmp => ti_logo_414x97_32bpp.bmp} | Bin
> tools/logos/{ti.gz => ti_logo_414x97_32bpp.bmp.gz} | Bin
> 3 fi
On 25/08/23 01:29, Simon Glass wrote:
> This relates to booting, so move it there. Create a new Kconfig menu for
> things related to devicetree fixup.
>
> Signed-off-by: Simon Glass
Reviewed-by: Devarsh Thakkar
> ---
>
> boot/Kconfig| 16 +++
Hi Simon,
On 25/08/23 01:28, Simon Glass wrote:
> This relates to booting since it fixes up the devicetree for the OS. Move
> it into the boot/ directory.
>
> Signed-off-by: Simon Glass
> ---
>
> boot/Makefile | 3 +++
> {common => boot}/fdt_support.c | 0
> common/Makefile
On 25/08/23 01:28, Simon Glass wrote:
> Put the options and the common BMP code with the other related Kconfig
> options in the drivers/video directory.
>
> Signed-off-by: Simon Glass
Reviewed-by: Devarsh Thakkar
> ---
>
> common/Kconfig | 11
Hi Simon,
On 15/08/23 20:14, Simon Glass wrote:
> Hi Devarsh,
>
> On Tue, 15 Aug 2023 at 03:23, Devarsh Thakkar wrote:
>>
>> Hi Simon, Tom,
>>
>> On 15/08/23 04:13, Simon Glass wrote:
>>> Hi Devarsh, Nikhil, Tom,
>>>
>>> On Wed, 9
Hi Simon, Tom,
On 15/08/23 04:13, Simon Glass wrote:
Hi Devarsh, Nikhil, Tom,
On Wed, 9 Aug 2023 at 09:29, Bin Meng wrote:
On Thu, Aug 3, 2023 at 7:03 PM Bin Meng wrote:
On Thu, Aug 3, 2023 at 6:37 PM Bin Meng wrote:
On Tue, Aug 1, 2023 at 12:00 AM Simon Glass wrote:
When the video
Hi,
On 04/08/23 13:10, Devarsh Thakkar wrote:
> Hi Simon, Tom, Bin,
>
> Thanks for the quick feedback.
>
> On 04/08/23 04:58, Simon Glass wrote:
>> Hi Devarsh,
>>
>> On Thu, 3 Aug 2023 at 08:28, Devarsh Thakkar wrote:
>>>
>>> Hi Simon,
>
Hi Simon, Tom, Bin,
Thanks for the quick feedback.
On 04/08/23 04:58, Simon Glass wrote:
> Hi Devarsh,
>
> On Thu, 3 Aug 2023 at 08:28, Devarsh Thakkar wrote:
>>
>> Hi Simon,
>>
>> On 03/08/23 19:32, Simon Glass wrote:
>>> +Bin Meng
>>>
Hi Simon,
On 03/08/23 19:32, Simon Glass wrote:
> +Bin Meng
>
> Hi Devarsh,
>
> On Tue, 1 Aug 2023 at 08:04, Devarsh Thakkar wrote:
>>
>> When passing framebuffer address using bloblist, check
>> that passed address is overlapping with current relocation
>
Hi Tom, Simon,
Thanks for sharing all the information.
On 01/08/23 02:39, Simon Glass wrote:
> Hi Tom,
>
> On Mon, 31 Jul 2023 at 15:06, Tom Rini wrote:
>>
>> On Mon, Jul 31, 2023 at 02:49:06PM -0600, Simon Glass wrote:
>>> Hi Tom,
>>>
>>> On Mon, 31 Jul 2023 at 14:45, Tom Rini wrote:
Signed-off-by: Devarsh Thakkar
---
common/board_f.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/common/board_f.c b/common/board_f.c
index 7d2c380e91..20fa17207a 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -419,7 +419,10 @@ static int reserve_
nario, leave the power domain of DSS as "on" so that
> splash screen stays intact until kernel boots up.
>
> Signed-off-by: Nikhil M Jain
Reviewed-by: Devarsh Thakkar
> ---
> drivers/video/tidss/tidss_drv.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(
Jain
Reviewed-by: Devarsh Thakkar
> ---
> drivers/video/tidss/tidss_drv.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/video/tidss/tidss_drv.c b/drivers/video/tidss/tidss_drv.c
> index 078e3e82e3..623bf4cf31 100644
> --- a/dri
Hi Simon,
Thanks for the patch.
On 30/07/23 22:46, Simon Glass wrote:
> When the video framebuffer comes from the bloblist, we should not change
> relocaddr to this address, since it interfers with the normal memory
> allocation.
>
> This fixes a boot loop in qemu-x86_64
>
> Signed-off-by:
Hi Simon,
On 26/07/23 02:58, Simon Glass wrote:
> Hi Devarsh,
>
> On Tue, 25 Jul 2023 at 03:21, Devarsh Thakkar wrote:
>>
>> Hi Simon,
>>
>> On 24/07/23 20:22, Simon Glass wrote:
>>> When the video framebuffer comes from the bloblist, we should not c
Hi Simon,
On 24/07/23 20:22, Simon Glass wrote:
> When the video framebuffer comes from the bloblist, we should not change
> relocaddr to this address, since it interfers with the normal memory
> allocation.
>
> This fixes a boot loop in qemu-x86_64
>
> Signed-off-by: Simon Glass
> Fixes:
Hi Nikhil,
On 19/06/23 15:14, Nikhil M Jain wrote:
> During compilation splash_source puts out below warning for type
> conversion in splash_load_fit for bmp_load_addr and fit_header,
Below should be separate sentence. Also remove fullstop from subject line.
change
> their type to uintptr_t to
ddress and size in a bloblist to make them
> available at u-boot proper, if in u-boot proper CONFIG_VIDEO is defined.
>
> Signed-off-by: Nikhil M Jain
Reviewed-by: Devarsh Thakkar
> ---
> V3:
> - Clean up errors appeared in checkpatch.
>
> V2:
> - Fix commit me
Hi Nikhil,
On 14/06/23 15:04, Nikhil M Jain wrote:
> Use spl_dcache_enable, in place of setup_dram, arch_reserve_mmu to set
> up pagetable, initialise DRAM and enable Dcache.
>
I think the patch does more than just above, please mention about those
changes too in commit message for future
On 14/06/23 15:04, Nikhil M Jain wrote:
> In spl_dcache_enable after setting up page table, set gd->relocaddr
> pointer to tlb_addr, to get next location to reserve memory. Align
> tlb_addr with 64KB address.
>
> Signed-off-by: Nikhil M Jain
Reviewed-by: Devarsh T
Hi Nikhil,
Thanks for the patch.
On 11/05/23 15:29, Nikhil M Jain wrote:
> Define bloblist address.
Mention below or above what region.
Also put the updated memory map in commit message
for future reference.
>
> Signed-off-by: Nikhil M Jain
With suggested changes,
Reviewed-by
> + bool "Remove video driver after SPL stage"
> + help
> + if this option is enabled video driver will be removed at the end of
> + SPL stage, beforeloading the next stage.
> +
to call remove method of video driver in u-boot SPL stage
With suggested changes,
Reviewed-by: Devarsh Thakkar
Regards
Devarsh
> if SPL_SPLASH_SCREEN
>
> config SPL_SPLASH_SCREEN_ALIGN
On 11/05/23 15:29, Nikhil M Jain wrote:
> Use config SPL_VIDEO_REMOVE to remove video driver at SPL stage before
> jumping to next stage, in place of CONFIG_SPL_VIDEO, to allow user to
> remove video if required.
>
> Signed-off-by: Nikhil M Jain
Reviewed-by: Devarsh Thakkar
Hi Nikhil,
Thanks for the patch.
On 11/05/23 15:29, Nikhil M Jain wrote:
> When video is set up in SPL, U-Boot proper needs to use the correct
> frame buffer address to reserve particular location in memory, to avoid
> displaying artifacts on the screen.
>
U-boot proper can use frame buffer
Hi Nikhil,
Thanks for the patch.
On 11/05/23 15:29, Nikhil M Jain wrote:
> Add method to reserve video using blob.
reserve memory for video using blob
received from previous stage.
>
Mention what info is updated.
> Signed-off-by: Nikhil M Jain
> ---
> drivers/video/video-uclass.c | 12
Hi Nikhil,
Thanks for the patch.
On 11/05/23 15:29, Nikhil M Jain wrote:
> Use spl_dcache_enable, in place of setup_dram, arch_reserve_mmu to set
> up pagetable, initialise DRAM and enable Dcache.
>
> Signed-off-by: Nikhil M Jain
> ---
> arch/arm/mach-k3/am625_init.c | 1 +
>
Hi Nikhil,
Thanks for the patch,
On 11/05/23 15:29, Nikhil M Jain wrote:
> In spl_dcache_enable after setting up page table, set gd->relocaddr
> pointer with 64KB alignment, to get next location to reserve memory.
>
> Signed-off-by: Nikhil M Jain
> ---
> arch/arm/mach-k3/common.c | 2 ++
> 1
Hi Nikhil, Vignesh, Tom,
Nikhil,
Thanks for the patch.
On 11/05/23 15:29, Nikhil M Jain wrote:
I think more apt subject would be "Update stack pointer after relocation"
> At SPL stage when stack is relocated, the stack pointer needs to be
> updated,
since
the stack pointer may point to stack
Hi Nikhil,
Thanks for the series.
On 11/05/23 15:29, Nikhil M Jain wrote:
> This patch series aims at updating SPL splashscreen framework for AM62x.
>
Good to put highlights of what this series tries to cover :
e.g. :
Switch to blob-list to transfer fb info from SPL to u-boot proper
compilation
1 - 100 of 130 matches
Mail list logo
