[PATCH 2/4] clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section

2022-09-26 Thread Fabio Estevam
Ethernet is not used inside SPL, so move the IMX8MM_CLK_ENET_AXI clock inside the non-SPL block to reduce the final SPL binary size. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8mm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk

[PATCH 1/4] clk-imx8mm: Only build PWM clocks in non-SPL code

2022-09-26 Thread Fabio Estevam
PWM is not used inside SPL, so do not define the PWM clocks inside SPL to reduce the final SPL binary size. Signed-off-by: Fabio Estevam --- drivers/clk/imx/clk-imx8mm.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/clk/imx/clk

[PATCH 0/4] clk-imx8mm: Reduce SPL binary size

2022-09-26 Thread Fabio Estevam
DEFAULT1 imx8mm_clk_probe Total reduction: 4100 - 3316 = 784 bytes. Fabio Estevam (4): clk-imx8mm: Only build PWM clocks in non-SPL code clk-imx8mm: Move CLK_ENET_AXI to the non-SPL section clk-imx8mm: Only build ecspi clocks when CONFIG_DM_SPI=y clk-imx8mm: Only build QSPI clocks when

Re: [PATCH] dm: doc: Fix serial howto u-boot,dm-pre-reloc typo

2022-09-25 Thread Fabio Estevam
Hi Michal, On 25/09/2022 10:28, Michal Suchanek wrote: In a couple of places the document says u-boot,pre-reloc but all examples show u-boot,dm-pre-reloc, use the latter consistently. Signed-off-by: Michal Suchanek Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] imx8mm_evk: Add Serial Download Protocol support

2022-09-21 Thread Fabio Estevam
Hi Peng, On Wed, Sep 21, 2022 at 2:25 AM Peng Fan wrote: > I am not sure, the master branch has this issue? Any specific config > option required? Yes, to reproduce this issue on U-Boot master, just need to apply this series plus Marek's fix:

Re: [PATCH v1] verdin-imx8mm: verdin-imx8mp: drop obsolete net/phy configs

2022-09-21 Thread Fabio Estevam
Hi Marcel, On Wed, Sep 21, 2022 at 8:34 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Drop obsolete networking/PHY related configuration defines. > > Signed-off-by: Marcel Ziswiler Reviewed-by: Fabio Estevam

Re: [PATCH] kontron-sl-mx8mm: Let CONFIG_SPL_FIT_IMAGE_TINY be selected

2022-09-20 Thread Fabio Estevam
Hi Stefano and Tom, On Wed, Aug 24, 2022 at 7:09 AM Frieder Schrempf wrote: > > Hi Fabio, > > Am 24.08.22 um 03:09 schrieb Fabio Estevam: > > When CONFIG_IMX_HAB is selected the 'hab_status' command reports several > > error events, indicating that the BootROM failed

Re: [PATCH] mx8m: csf.sh: Fix the calculation of fit_block_size

2022-09-20 Thread Fabio Estevam
Hi Stefano and Tom, On Sun, Aug 14, 2022 at 2:25 PM Marek Vasut wrote: > > On 8/13/22 14:03, Fabio Estevam wrote: > > From: Fabio Estevam > > > > When running the script to sign SPL/U-Boot on a kontron-sl-mx8mm board, > > the fit_block_size was calculat

Re: [PATCH 2/2] board: tbs2910: Add serial rx buffer in defconfig

2022-09-20 Thread Fabio Estevam
serial console processing. > > Signed-off-by: Soeren Moch Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] board: tbs2910: Set all board dts files as maintained

2022-09-20 Thread Fabio Estevam
On Tue, Sep 20, 2022 at 1:05 PM Soeren Moch wrote: > > This also includes the imx6q-tbs2910-u-boot.dtsi file now. > > Signed-off-by: Soeren Moch Reviewed-by: Fabio Estevam

Re: [PATCH] gpio: uclass: Introduce gpio-hog-optional property

2022-09-20 Thread Fabio Estevam
Hi Nate, On Wed, Sep 14, 2022 at 11:31 AM Nate Drude wrote: > Thanks for the discussion and feedback. I prefer to avoid changing the > bindings in Linux if possible. > > Would it be acceptable if I rework gpio_hog_probe_all so that it prints > an error "Failed to probe device..." if any

Re: [PATCH 2/2] imx8mm_evk: Add Serial Download Protocol support

2022-09-20 Thread Fabio Estevam
hance to debug yet is that running 'ums 0 mmc 1' works only when issued for the first time. If I interrupt with CRLC+C and then launch 'ums 0 mmc 1' again, it does not work. This is unrelated to SDP and happens when I boot from SD card as well. If you have any ideas, please let me know. Thanks, Fabio Estevam

[PATCH 2/2] imx8mm_evk: Add Serial Download Protocol support

2022-09-19 Thread Fabio Estevam
-mx8menlo board. Also, to fit the SPL binary into the internal RAM, select CONFIG_LTO to reduce its size. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx8mm-evk-u-boot.dtsi | 16 configs/imx8mm_evk_defconfig| 21 + 2 files changed, 37 insertions

[PATCH 1/2] imx8mm_evk: Add an entry for USB boot

2022-09-19 Thread Fabio Estevam
Add an entry for USB boot so that U-Boot could be loaded via the Serial Download Protocol. Signed-off-by: Fabio Estevam --- board/freescale/imx8mm_evk/spl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/freescale/imx8mm_evk/spl.c b/board/freescale/imx8mm_evk/spl.c index e2eb1426c8

Re: [PATCH] usb: Add missing guard around env_get() in usb_hub

2022-09-19 Thread Fabio Estevam
x8mm-evk SDP SPL support, thanks: Tested-by: Fabio Estevam

Re: [PATCH 4/4] ARM: dts: imx8m: imx8mm-mx8menlo: Enable SPL SDP support

2022-09-19 Thread Fabio Estevam
as follows: $ uuu -brun spl flash.bin Signed-off-by: Marek Vasut This is great, I was able to test SPL SDP on an imx8mm-evk after applying these same changes to imx8mm-evk and reducing the SPL size. For the series: Reviewed-by: Fabio Estevam

Re: [PATCH V5] bsh: imx6ulz_smm_m2: Add imx6ulz BSH SMM M2 boards

2022-09-18 Thread Fabio Estevam
BOTG1 peripheral - fastboot. > > Signed-off-by: Michael Trimarchi Reviewed-by: Fabio Estevam

[PATCH v2] usb: Kconfig: Fix typo in SPL_DM_USB text

2022-09-17 Thread Fabio Estevam
Change a typo in "USB host mode". Signed-off-by: Fabio Estevam --- Changes since v1: - most->mode (Marek). drivers/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index fd13cf31b5..3afb45d5cc 100644 ---

Re: [PATCH V2] Kconfig: enlarge CONFIG_SYS_MALLOC_F_LEN

2022-09-15 Thread Fabio Estevam
_SYS_MALLOC_F_LEN as 0x2000. > > Reported-by: Heiko Thiery > Signed-off-by: Peng Fan Thanks for addressing this issue at an SoC level: Reviewed-by: Fabio Estevam

[PATCH] usb: Kconfig: Fix typo in SPL_DM_USB text

2022-09-14 Thread Fabio Estevam
From: Fabio Estevam There is an extra "most" word in the SPL_DM_USB text that makes it confusing. Remove it. Signed-off-by: Fabio Estevam --- drivers/usb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index fd

Re: [PATCH] gpio: uclass: Introduce gpio-hog-optional property

2022-09-14 Thread Fabio Estevam
Hi Nate, On Wed, Sep 14, 2022 at 11:00 AM Nate Drude wrote: > An alternate approach is to modify the default behavior so that > gpio_hog_probe_all will not trigger a fatal error. Do you think this is > better? IMHO that would be better, as we could keep using the same devicetree files from

Re: [PATCH] imx8mq_evk: enlarge SYS_MALLOC_F_LEN

2022-09-14 Thread Fabio Estevam
On Wed, Sep 14, 2022 at 1:12 AM Heiko Thiery wrote: > When changing these values on the kontron_pitx_imx8m_defconfig this > board also works again. > Maybe it could be a good idea to change these values for all imx8mq boards. Yes, agreed. It would be great if someone could align these values

Re: [PATCH] kontron_pitx_imx8m: enlarge SYS_MALLOC_F_LEN

2022-09-14 Thread Fabio Estevam
K=2400 > > It is because CONFIG_SYS_MALLOC_F_LEN is too small, enlarge it. And set > CONFIG_SPL_STACK to 0x188000 to not waste the top 16bytes. > > Signed-off-by: Heiko Thiery Reviewed-by: Fabio Estevam

Re: [PATCH] gpio: uclass: Introduce gpio-hog-optional property

2022-09-12 Thread Fabio Estevam
Hi Nate and Simon, On Mon, Sep 12, 2022 at 2:55 PM Nate Drude wrote: > > gpio_hog_probe_all is invoked by init_sequence_r in board_r.c. > If device_probe fails for any gpio-hog, boot hangs with the following error: > > > initcall sequence fffc8e18 failed at call 4023b320 > >

Re: [PATCH] board: gateworks: venice: update GW74xx PMIC config

2022-09-08 Thread Fabio Estevam
Hi Tim, On Thu, Sep 8, 2022 at 5:40 PM Tim Harvey wrote: > > Update the GW74xx PMIC configuration. Please explain why you are doing this change.

Re: [PATCH v4 2/2] serial: mxc: have putc use the TXFIFO

2022-09-06 Thread Fabio Estevam
of UTS_TXEMPTY Signed-off-by: Johannes Schneider Reviewed-by: Peng Fan Reviewed-by: Fabio Estevam

Re: [PATCH v4 1/2] serial: mxc: enable the RX pipeline

2022-09-06 Thread Fabio Estevam
readl(>cr3) | UCR3_RXDMUXSEL, >cr3); + Nitpick: the recommended style for multi-line comments is: /* * Setting the baudrate triggers a reset, returning cr3 to its * reset value but UCR3_RXDMUXSEL "should always be set." * according to the imx8 reference-manual. */ Reviewed-by: Fabio Estevam

Re: [PATCH v2 1/2] serial: mxc: enable the RX pipeline

2022-09-05 Thread Fabio Estevam
On Mon, Sep 5, 2022 at 10:43 PM Tom Rini wrote: > We allow '//' style comments, just like the linux kernel does these > days. There should be a space before the "imx8" in the first hunk here. Yes, // style comments are allowed, but for consistency with the other comments in this file, it would

Re: [PATCH v1 0/2] serial_mxc: fixing reception

2022-09-05 Thread Fabio Estevam
Hi Andrey, On Mon, Sep 5, 2022 at 6:21 AM ZHIZHIKIN Andrey wrote: > I cannot modify this part since removing you from maintainer list would > require a transfer of maintainership of this component to another name, > which I do not know. > > I've Cc:'d Tom and people from imx world here so they

[PATCH] MAINTAINERS: imx: Add an entry for the serial driver

2022-09-05 Thread Fabio Estevam
From: Fabio Estevam Currently, when running ./scripts/get_maintainer.pl on serial_mxc.c no i.MX maintainer is returned. Fix it by adding an entry for this driver. Reported-by: Pali Rohár Signed-off-by: Fabio Estevam --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] board: bsh: Update imx8mn ddr3l timing according to BSH hw team

2022-08-31 Thread Fabio Estevam
of the board. The only comment is that it is always good to include something in the commit log to explain why the change is done. With a commit log added: Reviewed-by: Fabio Estevam Regards, Fabio Estevam -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office

Re: [PATCH] ARM: imx: Update Data Modul i.MX8M Mini eDM SBC DRAM timing

2022-08-30 Thread Fabio Estevam
ubset of boards. The DDR PHY PIE block has > been updated accordingly. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic Looks like this one should be applied to 2022.10: Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: imx: Enable SPL GPIO hog on i.MX8M Plus DHCOM

2022-08-27 Thread Fabio Estevam
On 26/08/2022 18:16, Marek Vasut wrote: Enable GPIO hog support in SPL to match the GPIO hog support in U-Boot proper. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: uboot-imx Reviewed-by: Fabio Estevam

Re: [PATCH v1 3/8] imxrt1050: synchronise device tree with linux

2022-08-26 Thread Fabio Estevam
Hi Marcel, On Fri, Aug 26, 2022 at 6:55 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Synchronise device tree with linux v6.0-rc1. Thanks for working on this. > - { > - /* > -* Memory configuration from sdram datasheet IS42S16160J-6BLI > -*/ > -

Re: [PATCH v2 00/19] imx: kontron-sl-mx8mm: Improvements and OSM board support

2022-08-24 Thread Fabio Estevam
ard/kontron/sl-mx8mm/spl.c > * describe SPI NOR partitions in devicetree > * move environment to end of SPI NOR > * Add tags For the series: Reviewed-by: Fabio Estevam

[PATCH] kontron-sl-mx8mm: Let CONFIG_SPL_FIT_IMAGE_TINY be selected

2022-08-23 Thread Fabio Estevam
succeeded to authenticate the SPL. Signed-off-by: Fabio Estevam --- configs/kontron-sl-mx8mm_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/kontron-sl-mx8mm_defconfig b/configs/kontron-sl-mx8mm_defconfig index 5387f65926f6..f8589b010cce 100644 --- a/configs/kontron-sl

Re: [PATCH] ARM: imx: Deduplicate i.MX8M SNVS LPGPR unlock

2022-08-23 Thread Fabio Estevam
On 23/08/2022 14:05, Marek Vasut wrote: Pull this LPGPR unlock into common code, since it is used in multiple systems already. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: Ye Li Cc: uboot-imx Reviewed-by: Fabio Estevam

Re: [PATCH] ARM: imx: Update DDR frequency on i.MX8M Plus DHCOM

2022-08-21 Thread Fabio Estevam
ly the NXP MX8MP RPA update will follow and use the later value too. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: Ye Li Cc: uboot-imx Reviewed-by: Fabio Estevam

Re: [PATCH] imx8m: ddrphy_utils: Remove unused file

2022-08-21 Thread Fabio Estevam
Cc: Fabio Estevam Cc: Peng Fan Cc: Stefano Babic Cc: Ye Li Cc: uboot-imx Reviewed-by: Fabio Estevam

Re: [PATCH 0/7] arm: dts: Create common imx8mn-u-boot

2022-08-14 Thread Fabio Estevam
evk: Consolidate with imx8mn-u-boot > arm: dts: imx8mn-var-som-symphony: Consolidate with imx8mn-u-boot > arm: dts: imx8mn-venice: Consolidate with imx8mn-u-boot For the series: Reviewed-by: Fabio Estevam

Re: [PATCH v2 01/19] imx: kontron-sl-mx8mm: Remove LVDS board type and devicetrees

2022-08-13 Thread Fabio Estevam
ssed to the kernel there is currently no use > for this configuration. > > Selecting the proper configuration in the kernel FIT image automatically > depending on the detected hardware can be handled by a script in the > environment. > > Signed-off-by: Frieder Schrempf For the series: Reviewed-by: Fabio Estevam

Re: [PATCH v7] board: purism: add the Purism Librem5 phone

2022-08-13 Thread Fabio Estevam
USB storage support for uSD rootfs > Dropped many SPL_BUILD guarded define's > Fixed documentation index > > Signed-off-by: Angus Ainslie > Co-developed-by: Sebastian Krzyszkowiak > Signed-off-by: Sebastian Krzyszkowiak Patch looks good: Reviewed-by: Fabio Estevam I would suggest removing the changes history from the commit log and put this information below the --- line.

[PATCH] mx8m: csf.sh: Fix the calculation of fit_block_size

2022-08-13 Thread Fabio Estevam
From: Fabio Estevam When running the script to sign SPL/U-Boot on a kontron-sl-mx8mm board, the fit_block_size was calculated as 0x1000 instead of 0x1020. Add an extra parenthesis pair to fix it. Signed-off-by: Fabio Estevam --- Hi Stefano, This one applies against u-boot-imx. Since

Re: [PATCH 1/1] doc: man-page for gpio command

2022-08-03 Thread Fabio Estevam
Hi Heinrich, On Wed, Aug 3, 2022 at 11:31 AM Heinrich Schuchardt wrote: > Fabio Estevam > * mx28evk_nand_defconfig > * mx28evk_auart_console_defconfig > * mx28evk_spi_defconfig I have sent a patch removing these defconfigs: https://lore.kernel.org/u-boot/20220803020404.415

[PATCH] mx28evk: Remove AUART/NAND/SPI variants

2022-08-02 Thread Fabio Estevam
From: Fabio Estevam To ease maintenance, let's keep only the main mx28evk_defconfig and remove the other variants that have not been migrated to DM. Signed-off-by: Fabio Estevam --- board/freescale/mx28evk/MAINTAINERS | 3 -- configs/mx28evk_auart_console_defconfig | 59

Re: [PATCH 04/21] arm: Remove mx28evk board

2022-08-02 Thread Fabio Estevam
On Tue, Aug 2, 2022 at 8:08 PM Fabio Estevam wrote: > > On Tue, Aug 2, 2022 at 8:34 AM Tom Rini wrote: > > > > This board is behind on several mandatory DM migrations and is missing > > OF_CONTROL support that makes other conversions impossible. Remove it. > > Thi

Re: [PATCH 04/21] arm: Remove mx28evk board

2022-08-02 Thread Fabio Estevam
On Tue, Aug 2, 2022 at 8:34 AM Tom Rini wrote: > > This board is behind on several mandatory DM migrations and is missing > OF_CONTROL support that makes other conversions impossible. Remove it. This is not correct. The only missing DM migration is the DM_SERIAL one, which is due on v2023.04.

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Fabio Estevam
Hi Tom, On Thu, Jul 28, 2022 at 8:41 AM Tom Rini wrote: > > On Thu, Jul 28, 2022 at 10:05:40AM +0300, Josua Mayer wrote: > > > The i.MX6 Cubox-i and HummingBoards can have different PHYs at varying > > addresses. U-Boot needs to auto-detect which phy is actually present, > > and at which address

Re: [PATCH] mx6cuboxi: fix ethernet after synchronise device-tree

2022-07-28 Thread Fabio Estevam
Hi Josua, On Thu, Jul 28, 2022 at 4:08 AM Josua Mayer wrote: > > Please hold off merging this patch until someone tested it, I can not do so > this week. > @Tom Can you confirm if this fixes the networking on your Cubox? > Also note that the phy-handle property may or may not be required, I am

Re: Pull request: u-boot-imx u-boot-imx-20220726

2022-07-27 Thread Fabio Estevam
[Adding Josua] On Tue, Jul 26, 2022 at 3:12 PM Tom Rini wrote: > So, funny issue here now. With: > commit d0399a46e7cda63c07e3eb8558bef84cfb068028 > Author: Marcel Ziswiler > Date: Thu Jul 21 15:27:26 2022 +0200 > > imx6dl/imx6qdl: synchronise device trees with linux > > Synchronise

Re: [PATCH] imx: syscounter: support timer_get_boot_us

2022-07-25 Thread Fabio Estevam
-off-by: Jun Nie Reviewed-by: Fabio Estevam

Re: [PATCH v1 03/26] tbs2910: prepare to synchronise device trees with linux

2022-07-21 Thread Fabio Estevam
Hi Marcel, On Thu, Jul 21, 2022 at 3:56 PM Marcel Ziswiler wrote: > Oh, okay. No, haven't seen that one yet. So it might make sense to re-base > everything on latest -next then > which would no longer require such change. Let me re-work this in a v2. > Thanks! Yes, please sync with

[PATCH] imx8mm: Sync device tree with linux-next 20220711

2022-07-15 Thread Fabio Estevam
From: Fabio Estevam Sync imx8mm.dtsi device tree with linux-next 20220711. The main motivation for doing this sync is the sha256 regression reported by Andrey Zhizhikin [1]. The linux-next kernel has the following commit, which disables the job ring 0 and fixes the problem: https

Re: [EXT] [REGRESSION]: v2022.07: SHA256 hash is broken on imx8m series with CAAM enabled

2022-07-15 Thread Fabio Estevam
Hi Andrey, On Fri, Jul 15, 2022 at 12:06 PM ZHIZHIKIN Andrey wrote: > From what I can see, since patch from Fabio [2] is planned for inclusion to > linux-5.20.y (see [3] for PR) - it might be that the SHA computation will stay > broken on i.MX8M derivatives until v2022.10 at least, or the HW

Re: kontron_pitx_imx8m does not start

2022-07-15 Thread Fabio Estevam
On Fri, Jul 15, 2022 at 8:18 AM Fabio Estevam wrote: > > Hi Heiko, > > On Fri, Jul 15, 2022 at 5:33 AM Heiko Thiery wrote: > > > Error binding driver 'serial_mxc': -12 > > Does the attached patch help? Also, try increasing CONFIG_SYS_SPL_MALLOC_SIZE.

Re: kontron_pitx_imx8m does not start

2022-07-15 Thread Fabio Estevam
Hi Heiko, On Fri, Jul 15, 2022 at 5:33 AM Heiko Thiery wrote: > Error binding driver 'serial_mxc': -12 Does the attached patch help? From 93d2c1604f644e6362cb5dc4c434d32f3a06 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Fri, 15 Jul 2022 08:11:03 -0300 Subject: [PATCH] imx8mq-kont

[PATCH] spl: sdp: Pass the USB index to board_usb_init()

2022-07-13 Thread Fabio Estevam
From: Fabio Estevam board_usb_init() should receive the controller_index as its first parameter instead of having it hardcoded as 0. All in-tree users have CONFIG_SPL_SDP_USB_DEV as 0, so this error should not affect any board. Fix it by passing controller_index as the parameter

Re: [PATCH V4 resend] spl: imx8mm: enlarge SPL_MAX_SIZE

2022-07-11 Thread Fabio Estevam
ASE, so the SPL MAX SIZE is `256KB - 96KB - 4KB`. > > Signed-off-by: Peng Fan Reviewed-by: Fabio Estevam

[PATCH] imx8mq_phanbell: Remove custom CONFIG_SYS_MALLOC_F_LEN

2022-07-08 Thread Fabio Estevam
From: Fabio Estevam Currently, the imx8mq_phanbell board fails to boot. Remove the custom CONFIG_SYS_MALLOC_F_LEN setting in favor of the generic one done via the main Kconfig. Since commit b598957206e5 ("Kconfig: Fix SYS_MALLOC_F_LEN for i.MX8MQ") the default SYS_MALLOC_F

Re: [PATCH] mtd: mxs_nand_spl: fix nand_command protocol violation

2022-06-29 Thread Fabio Estevam
Hi Michael, On 29/06/2022 03:49, Michael Nazzareno Trimarchi wrote: It will be nice if you can pick this one too. Fabio can you review it? The change looks good to me: Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] pmic: pca9450: clear PRESET_EN bit for BUCK1/2/3 voltage settings

2022-06-28 Thread Fabio Estevam
123_PRESET_EN, 0); + } Nit: the braces could be dropped. Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] pmic: pca9450: enable system reset on WDOG_B assertion

2022-06-28 Thread Fabio Estevam
("regulator: pca9450: Enable system reset on WDOG_B assertion") 2364a64d0673 ("regulator: pca9450: Make warm reset on WDOG_B assertion") Cc: Frieder Schrempf Signed-off-by: Heiko Thiery Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Fabio Estevam
On Tue, Jun 28, 2022 at 11:01 AM Heinrich Schuchardt wrote: > The patch is merged June 19th: > > e05bd68ed5fc ("test: work around for EFI terminal size probing") > > Why do you ask? Because I haven't seen an "applied" message in this thread. I see it in mainline now, thanks.

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Fabio Estevam
On Tue, Jun 28, 2022 at 10:55 AM Tom Rini wrote: > I thought this was worked around for now? The non-testing case should > be fine again, and tests do need to do additional code to work, which is > not ideal, but good enough for the moment. I haven't realized that the patch has been applied.

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-28 Thread Fabio Estevam
Hi Heinrich, On Fri, Jun 17, 2022 at 1:59 AM Heinrich Schuchardt wrote: > > This causes: https://source.denx.de/u-boot/u-boot/-/jobs/450891#L229 > > for all instances of sandbox running that test. > > > > This is a only a bug to the test environment: > > test/py/u_boot_console_base.py:110: >

Re: [PATCH v2 2/2] imx: kontron-sl-mx8mm: Enable PCA9450 regulator driver and fix SD card access

2022-06-28 Thread Fabio Estevam
gt; a high level. > > Signed-off-by: Frieder Schrempf > Reviewed-by: Fabio Estevam Tested-by: Fabio Estevam

Re: [PATCH v2 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5

2022-06-28 Thread Fabio Estevam
to change the > driver to be able to use the LDO5CTRL_L register. > > This is a port of the same change in the Linux kernel: > 8c67a11bae88 ("regulator: pca9450: Add SD_VSEL GPIO for LDO5") > > Signed-off-by: Frieder Schrempf > Reviewed-by: Fabio Estevam Tested-by: Fabio Estevam Tom, Please apply these patches to 2022.07. Thanks

Re: [PATCH v5 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support

2022-06-26 Thread Fabio Estevam
On Sun, Jun 26, 2022 at 6:42 PM Patrick Wildt wrote: > +static iomux_v3_cfg_t const uart_pads[] = { > + IMX8MQ_PAD_UART1_RXD__UART1_RX | MUX_PAD_CTRL(UART_PAD_CTRL), > + IMX8MQ_PAD_UART1_TXD__UART1_TX | MUX_PAD_CTRL(UART_PAD_CTRL), > +}; As you use DM_SERIAL, this is no longer

Re: [PATCH v5 1/2] arm: dts: imx8mq: update MNT Reform 2 to Linux v5.19-rc3

2022-06-26 Thread Fabio Estevam
On Sun, Jun 26, 2022 at 6:41 PM Patrick Wildt wrote: > > --- Commit log and Signed-off-by are missing.

Re: [PATCH v1 2/2] board: apalis_imx6: DDR init using mx6_dram_cfg()

2022-06-24 Thread Fabio Estevam
range SKUs some > changes on ODT parameters. > > This change was validated over a range of different apalis-imx6 SoM, on > the whole working temperature range with weeks of continuous testing. > > Signed-off-by: Francesco Dolcini Reviewed-by: Fabio Estevam

Re: [PATCH v1 1/2] mx6: ddr: Fix disabling on-die termination

2022-06-24 Thread Fabio Estevam
ange (rtt_nom != 0 on all i.MX6 > ddr3 boards), this will be used by a follow-up change. > > Fixes: fe0f7f7842e1 ("mx6: add mmdc configuration for MX6Q/MX6DL") > Signed-off-by: Francesco Dolcini Reviewed-by: Fabio Estevam

Re: [PATCH] toradex: apalis/colibri_imx6: Fix CLKO1/CLKO2 output

2022-06-24 Thread Fabio Estevam
nging the clock tree (setting clk_out_sel=1 without setting > clko2_en=1) the noise would start till the actual clock was enabled > (clko2_en=1) during the SGTL5000 driver probe. > > Signed-off-by: Francesco Dolcini Reviewed-by: Fabio Estevam

Re: [PATCH v2] arm: dts: imx8mn-evk: sync dts from Linux Kernel

2022-06-24 Thread Fabio Estevam
rsion the sync was done from (thanks Fabio) > - update the patch subject to clarify that changes the evk dts (thanks Tim) Thanks for the rework. It is clear now: Reviewed-by: Fabio Estevam

Re: [PATCH 2/2] imx: kontron-sl-mx8mm: Enable PCA9450 regulator driver and fix SD card access

2022-06-23 Thread Fabio Estevam
board has a GPIO connected to the SD_VSEL signal of the PMIC. As the driver uses the LDO5CTRL_H register to set the voltage, we need to make sure that this GPIO (GPIO01_IO4) is set to a high level. Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] pmic: pca9450: Add optional SD_VSEL GPIO for LDO5

2022-06-23 Thread Fabio Estevam
. This is a port of the same change in the Linux kernel: 8c67a11bae88 ("regulator: pca9450: Add SD_VSEL GPIO for LDO5") Signed-off-by: Frieder Schrempf Reviewed-by: Fabio Estevam

Re: [PATCH 1/2] imx: kontron-sl-mx8mm: Sync dts files and fix ethernet

2022-06-23 Thread Fabio Estevam
eek and there haven't been any responses yet. > But as the 2022.07 release is approaching and you were asking for > pending fixes, this is one you might consider. Yes, this one is a bug fix, so it should go to 2022.07 final. Reviewed-by: Fabio Estevam

Re: [PATCH v2 8/8] ARM: imxrt1170_defconfig: Add i.MXRT1170 defconfig

2022-06-21 Thread Fabio Estevam
e > until one day I had time to make it work correctly, but I have no time. Thanks for the explanation. Just wanted to check if this option was left by mistake. It is clear now. Regards, Fabio Estevam

Re: [PATCH] arm: dts: imx8mn: sync dts from Linux Kernel

2022-06-21 Thread Fabio Estevam
Hi Heiko, On Tue, Jun 21, 2022 at 4:06 AM Heiko Thiery wrote: > > I think the way to sync dts is to choose one linux release RC to sync. > > not just sync partial. > > It is not partial .. I just wanted to show what changes are made. I also had the impression that this was a partial sync.

Re: [PATCH] toradex: tdx-cfg-block: add new toradex oui range

2022-06-20 Thread Fabio Estevam
is taken > For serial-numbers 16777216-33554431 OUI 8c:06:cb is taken > > Lower 24-bit of the serial number are used in the NIC part of the > MAC address, the complete serial number can be calculated using the OUI. > > Signed-off-by: Philippe Schenker > Reviewed-by: Francesco Dolcini Reviewed-by: Fabio Estevam

Re: [PATCH] pmic: pca9450: permit config on all bucks and LDOs

2022-06-20 Thread Fabio Estevam
on the ROHM BD71837 and a comment that describes a limitation about switching while the output is enabled can also be found there, the limitation probably comes from this type. Signed-off-by: Heiko Thiery Reviewed-by: Fabio Estevam

Re: [PATCH v4] ARM: imx: Switch Data Modul i.MX8M Mini eDM SBC to USB251x Hub driver

2022-06-20 Thread Fabio Estevam
On Wed, Jun 15, 2022 at 8:07 AM Marek Vasut wrote: > > Replace the ad-hoc I2C register programming scripted in board > environment with U-Boot DM driver. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Peng Fan > Cc: Stefano Babic Reviewed-by: Fabio Estevam

Re: [PATCH v2 8/8] ARM: imxrt1170_defconfig: Add i.MXRT1170 defconfig

2022-06-17 Thread Fabio Estevam
Hi Jesse, On Fri, Jun 17, 2022 at 1:42 PM Jesse Taube wrote: > > Add a base defconfig for the i.MXRT1170 This should be part of the patch that adds support for the board (1/8). > +CONFIG_ARM=y > +CONFIG_SYS_DCACHE_OFF=y Any reason to turn off DCACHE?

Re: [PATCH v3] crypto/fsl: fsl_hash: Fix crash in flush dcache

2022-06-16 Thread Fabio Estevam
ff-by: Gaurav Jain > --- > changes in v3: > - fix error: left shift count >= width of > type [-Werror=shift-count-overflow] Thanks for the rework: Reviewed-by: Fabio Estevam

Re: Extend binman to generate boot headers

2022-06-16 Thread Fabio Estevam
Hi Peng, On Thu, Jun 16, 2022 at 5:45 AM Peng Fan wrote: > > Hi all, > > I am thinking to extend binman to generate i.MX container > header and IVT header, that means to replace mkimage to generate header. > > There is an NXP downstream imx-mkimage that diverge from upstream that > double

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-15 Thread Fabio Estevam
Hi Akashi-san, On Wed, Jun 15, 2022 at 3:35 AM AKASHI Takahiro wrote: > I think that your patch is a tentative workaround. Could Heinrich's patch be applied to 2022.07 to fix the regression? Any suggestions? Thanks, Fabio Estevam

Re: [PATCH v3] crypto/fsl: fsl_rsa: Fix dcache issue in the driver

2022-06-15 Thread Fabio Estevam
Hi Gaurav, On Wed, Jun 15, 2022 at 9:35 AM Gaurav Jain wrote: > > From: Ye Li > > issue: > CAAM fails with key error when perform Modular Exponentiation > using PKHA Block in CAAM > > Fix: > add flush and invalidate dcache for keys, signature > and output decrypted data processed by CAAM. > >

Re: [PATCH v2] crypto/fsl: fsl_hash: Fix crash in flush dcache

2022-06-14 Thread Fabio Estevam
Hi Gaurav, On Thu, Jun 9, 2022 at 9:47 AM Gaurav Jain wrote: > + flush_dcache_range((ulong)ctx->sg_tbl, > + (ulong)(ctx->sg_tbl) + (ctx->sg_num * > sizeof(struct sg_entry))); > + for (i = 0; i < ctx->sg_num; i++) { > + sg_entry_len =

Re: [PATCH] tbs2910: Convert to DM_SERIAL

2022-06-14 Thread Fabio Estevam
On Sat, Mar 19, 2022 at 10:31 AM Fabio Estevam wrote: > > Fabio, will you sync the imx6qdl.dtsi changes to linux? > > Or how is this supposed to keep in sync? > > Yes, I plan to submit these imx6qdl.dtsi changes (and similar changes > to the other i.MX dtsi files too) t

Re: [PATCH 2/2] imx: kontron-sl-mx8mm: Remove deprecated phy-mode property

2022-06-14 Thread Fabio Estevam
ubject say "unneeded" instead of "deprecated"? Reviewed-by: Fabio Estevam

Re: [PATCH 1/1] efi_loader: initialize console size late

2022-06-14 Thread Fabio Estevam
autoboot. > > Only query the console size when running an EFI binary. > > Add debug output showing the determined console size. > > Reported-by: Fabio Estevam > Fixes: a9bf024b2933 ("efi_loader: disk: a helper function to create efi_disk > objects from udevice"

Re: [PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice

2022-06-13 Thread Fabio Estevam
disabling CONFIG_EFI_LOADER as a workaround. I can help to test patches, but I am not familiar with EFI to propose a fix. Thanks, Fabio Estevam

Re: [PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice

2022-06-13 Thread Fabio Estevam
Hi Mark, On Mon, Jun 13, 2022 at 7:21 PM Mark Kettenis wrote: > This looks like the reply the terminal sends in response to the "Query > cursor position" command that is sent in > lib/efi_loader/efi_console.c:query_console_serial(). > > It might be worth trying to increase the timeout in

Re: cmd: exit: Doesn't function

2022-06-13 Thread Fabio Estevam
[Adding Marek on Cc] On Mon, Jun 13, 2022 at 5:00 PM Adrian Vovk wrote: > > Hello, > > I've run into an issue trying to use a recent commit of u-boot > (v2022.07-rc3-101-g90189ecd59) with some custom scripts. Basically, I've > found that the `exit` command does not function whatsoever, and

Re: [PATCH v5 07/12] efi_loader: disk: a helper function to create efi_disk objects from udevice

2022-06-13 Thread Fabio Estevam
On Wed, May 18, 2022 at 6:23 AM Neil Armstrong wrote: > This change as commit a9bf024b2933bba0e23038892970a18b72dfaeb4 in master > makes Amlogic S905X board libretech-cc to crash: This change also causes issues on a kontron-sl-mx8mm and imx8mn ddr3 evk boards. The problem on these boards is

Re: imx8mn SPL serial output does not work after powerup

2022-06-13 Thread Fabio Estevam
Hi Heiko, On Mon, Jun 13, 2022 at 4:16 PM Heiko Thiery wrote: > Can anyone confirm the behavior? imx8mn ddr4 evk prints the SPL part just fine. Take a look at arch/arm/dts/imx8mn-ddr4-evk-u-boot.dtsi . It passes: { u-boot,dm-spl; }; _uart2 { u-boot,dm-spl; }; Are you doing the

Re: imx8m(n): garbage on serial line

2022-06-13 Thread Fabio Estevam
Hi Heiko, On Fri, Jun 10, 2022 at 7:29 AM Heiko Thiery wrote: > Hit any key to stop autoboot: 0 > u-boot=> [25;88R > Unknown command '[25' - try 'help' > Unknown command '88R' - try 'help' git bisect points me to an efi loader commit as the guilty one. Can you please pass the line below into

Re: imx8m(n): garbage on serial line

2022-06-13 Thread Fabio Estevam
On Mon, Jun 13, 2022 at 11:27 AM Fabio Estevam wrote: > U-Boot 2022.07-rc4-7-g57bd363de7 (Jun 13 2022 - 11:18:10 -0300) > > CPU: Freescale i.MX8MMQ rev1.0 1600 MHz (running at 1200 MHz) > CPU: Industrial temperature grade (-40C to 105C) at 60C > Reset cause: POR > Mode

Re: imx8m(n): garbage on serial line

2022-06-13 Thread Fabio Estevam
Hi Heiko, On Mon, Jun 13, 2022 at 10:54 AM Heiko Thiery wrote: > This is the output on the kontron bl-imx8m board: > > U-Boot SPL 2022.07-rc4-7-g8c3f838be2 (Jun 13 2022 - 15:36:08 +0200) > Kontron SL i.MX8MM (N801X) module, 1 GB RAM detected > Touch controller detected, assuming LVDS

Re: imx8m(n): garbage on serial line

2022-06-11 Thread Fabio Estevam
Hi Heiko, On Sat, Jun 11, 2022 at 3:12 AM Heiko Thiery wrote: > It took me some effort to get the current u-boot running on my imx8mq. > But finally it works and I do not see this garbage on the imx8mq. Next > week I will check on the kontron_sl_imx8mm. Thanks, appreciated it!

Re: imx8m(n): garbage on serial line

2022-06-10 Thread Fabio Estevam
Hi Heiko, On Fri, Jun 10, 2022 at 7:29 AM Heiko Thiery wrote: > > Hi, > > I just rebased my pending patch for adding support for the NXP imx8mn > ddr3l evk board. When applying on the current master I see some > garbage on the serial input. > > Can anyone confirm that behavior or is it just

<    6   7   8   9   10   11   12   13   14   15   >