--- a/boot/image.c
> +++ b/boot/image.c
> @@ -26,8 +26,6 @@
> #endif
>
> #include
> -#include
> -#include
> #include
> #include
>
> --
> 2.25.1
>
Reviewed-by: Igor Opaniuk
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk
tpc.h:84:#include
./include/configs/imx8mp_venice.h:21:#include
./include/configs/stm32f746-disco.h:30:#include
...
Hope this helps.
[1] https://developer.toradex.com/linux-bsp/os-development/boot/distro-boot/
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mail
On Tue, Apr 30, 2024 at 7:44 PM Tom Rini wrote:
>
> Remove from this board vendor directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini
> ---
> Cc: Peter Griffin
> Cc: Manivannan Sadhasivam
> Cc: Jorge Ramirez-Ortiz
> Cc:
Add additional check for buffer size when reading out persistent
storage value and provide back actual value size.
Signed-off-by: Igor Opaniuk
---
drivers/tee/sandbox.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c
USE_DT=y
> +CONFIG_BUTTON=y
> +CONFIG_BUTTON_GPIO=y
> CONFIG_CLK_SCMI=y
> CONFIG_SET_DFU_ALT_INFO=y
> CONFIG_USB_FUNCTION_FASTBOOT=y
> --
> 2.25.1
>
Reviewed-by: Igor Opaniuk
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk
T_DOWNLOAD=y
> CONFIG_ERRNO_STR=y
> # CONFIG_LMB_USE_MAX_REGIONS is not set
> CONFIG_LMB_MEMORY_REGIONS=2
> --
> 2.25.1
>
Reviewed-by: Igor Opaniuk
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk
+# Check the current BootOrder
> for i in ('test 3', 'Quit'):
> u_boot_console.p.expect([i])
>
> --
> 2.43.0
>
Reviewed-by: Igor Opaniuk
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk
}
> if (level == 0) {
> err = zio_read(bp, endian, buf, 0, data);
> endian = (zfs_to_cpu64(bp->blk_prop, endian) >>
> 63) & 1;
> --
> 2.44.0
>
>
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk <http://ua.linkedin.com/in/iopaniuk>
Apalodimas
Signed-off-by: Igor Opaniuk
---
Changes in v5:
- Extended commit message for "cmd: optee_rpmb: close tee session"
- Added R-b tag
Changes in v4:
- Rebased on the latest master and excluded "tee: sandbox: fix spelling errors",
as it was merged already by Heinrich Schu
Add read/write tests for optee_rpmb cmd.
Signed-off-by: Igor Opaniuk
---
(no changes since v1)
test/py/tests/test_optee_rpmb.py | 20
1 file changed, 20 insertions(+)
create mode 100644 test/py/tests/test_optee_rpmb.py
diff --git a/test/py/tests/test_optee_rpmb.py b
Tested-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b and T-b tags
cmd/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 61e280fb1a4..227d66a7eea 100644
--- a/cmd/Kconfig
+++ b/cmd/K
registered in OP-TEE OS core (obvious resource leak).
Signed-off-by: Igor Opaniuk
---
Changes in v5:
- Extended commit message, added more details about the reasons why the
change was needed
cmd/optee_rpmb.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff
Fix OPTEE_TA_AVB symbol description in Kconfig:
s/"write"rb"/"write_rb"/g
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Ilias Apalodimas
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b tags
drivers/tee/optee/Kconfig | 2 +-
1
in v3:
- Added calls for closing tee session after every read/write operation
Changes in v2:
- Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset'
- Applied R-b and T-b tags
Igor Opaniuk (5):
tee: optee: fix description in Kconfig
cmd: optee_rpmb: close tee session
cmd: o
Ilias,
On Thu, Apr 4, 2024 at 1:00 PM Ilias Apalodimas
wrote:
> Hi Igor,
>
> On Thu, 4 Apr 2024 at 13:18, Igor Opaniuk wrote:
> >
> > Hi Ilias,
> >
> > On Thu, Apr 4, 2024 at 10:54 AM Ilias Apalodimas <
> ilias.apalodi...@linaro.org> wrote:
> >&g
HI Ilias
On Thu, Apr 4, 2024 at 12:15 PM Igor Opaniuk wrote:
> Hi Ilias,
>
> On Thu, Apr 4, 2024 at 10:40 AM Ilias Apalodimas <
> ilias.apalodi...@linaro.org> wrote:
>
>> Hi Igor,
>>
>> I was about to apply the series, but noticed neither me or
Add orphaned TEE/OP-TEE-related files to TEE subsystem entry in
MAINTAINERS. This includes:
- optee_rpmb cmd and test for it
- Misc. OP-TEE tests
- OP-TEE SCMI agent implementation
- Documentation, including device tree bindings
Signed-off-by: Igor Opaniuk
---
MAINTAINERS | 9 +
1 file
Jens were
> cc'ed
> > on this. Adding Jens to the party
> >
> > On Thu, Apr 04, 2024 at 10:13:49AM +0200, Igor Opaniuk wrote:
> > > Add calls for closing tee session after every read/write operation.
> >
> > What the patch is pretty obvious, but I am missing
by patman. Looks like there is
no
entry in MAINTAINERS for this specific file, that's why only Tom was added.
I'll send a patch for that if you don't mind.
> On Thu, Apr 04, 2024 at 10:13:49AM +0200, Igor Opaniuk wrote:
> > Add calls for closing tee session after every read/write operation
The usage of the common.h include file is deprecated [1], and has already
been removed from several files.
Get rid of all inclusions in the "drivers/tee" directory, and replace it
with required include files directly where needed.
[1] doc/develop/codingstyle.rst
Signed-off-by: Ig
Add read/write tests for optee_rpmb cmd.
Signed-off-by: Igor Opaniuk
---
(no changes since v1)
test/py/tests/test_optee_rpmb.py | 20
1 file changed, 20 insertions(+)
create mode 100644 test/py/tests/test_optee_rpmb.py
diff --git a/test/py/tests/test_optee_rpmb.py b
Tested-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b and T-b tags
cmd/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 61e280fb1a4..227d66a7eea 100644
--- a/cmd/Kconfig
+++ b/cmd/K
Add calls for closing tee session after every read/write operation.
Signed-off-by: Igor Opaniuk
---
(no changes since v1)
cmd/optee_rpmb.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/cmd/optee_rpmb.c b/cmd/optee_rpmb.c
index e0e44bbed04
Fix OPTEE_TA_AVB symbol description in Kconfig:
s/"write"rb"/"write_rb"/g
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Ilias Apalodimas
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b tags
drivers/tee/optee/Kconfig | 2 +-
1
tee.c:37:9: error: implicit declaration of function 'memset'
- Applied R-b and T-b tags
Igor Opaniuk (5):
tee: optee: fix description in Kconfig
cmd: optee_rpmb: close tee session
cmd: optee_rpmb: build cmd for sandbox
test: py: add optee_rpmb tests
tee: remove common.h inclusion
c
[1] include/configs/mvebu_armada-37xx.h
[2] include/config_distro_bootcmd.h
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk <http://ua.linkedin.com/in/iopaniuk>
Ilias,
On Mon, Mar 4, 2024 at 6:45 PM Igor Opaniuk wrote:
> - Address some spelling errors and typos
> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> - Remove common.h inclusion for drivers/tee
> - Add calls for closing tee session after every read/wri
UP_OFFSET);
> > - if (ret < 0) {
> > - free(backup_abc);
> > - free(abc);
> > - return ret;
> > + if (CONFIG_ANDROID_AB_BACKUP_OFFSET) {
> > + /*
> > + * If t
log_err("ANDROID: Invalid backup CRC-32 ");
> log_err("expected %.8x, found %.8x),",
> crc32_le, backup_abc->crc32_le);
> #endif
> --
> 2.34.1
>
>
Reviewed-by: Igor Opaniuk
--
Best regard
t in with greater ease.
> >
> > Yeah. For this kind of thing you wouldn't want to make a bunch of
> > checkpatch changes. They sometimes pull crypto and compression
> > libraries into the Linux kernel pretty much unmodified as well for the
> > same reason.
> >
d (with CONFIG_VAL macro) as explained in [1].
-
> 2.43.2
>
>
>
>
> CONFIDENTIALITY NOTICE: This email and any attachments are for the sole
> use of the intended recipient(s) and contain information that may be Garmin
> confidential and/
Hi Ilias,
On Mon, Mar 4, 2024 at 12:16 PM Ilias Apalodimas <
ilias.apalodi...@linaro.org> wrote:
> Hi Igor,
>
> On Sun, 3 Mar 2024 at 00:01, Igor Opaniuk wrote:
> >
> >
> > - Address some spelling errors and typos
> > - Support CMD_OPTEE_RPMB for SAND
The usage of the common.h include file is deprecated [1], and has already
been removed from several files.
Get rid of all inclusions in the "drivers/tee" directory, and replace it
with required include files directly where needed.
[1] doc/develop/codingstyle.rst
Signed-off-by: Ig
Add read/write tests for optee_rpmb cmd.
Signed-off-by: Igor Opaniuk
---
(no changes since v1)
test/py/tests/test_optee_rpmb.py | 20
1 file changed, 20 insertions(+)
create mode 100644 test/py/tests/test_optee_rpmb.py
diff --git a/test/py/tests/test_optee_rpmb.py b
Tested-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b and T-b tags
cmd/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index a86b5705174..8ad8c0c542c 100644
--- a/cmd/Kconfig
+++ b/cmd/K
Add calls for closing tee session after every read/write operation.
Signed-off-by: Igor Opaniuk
---
(no changes since v1)
cmd/optee_rpmb.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/cmd/optee_rpmb.c b/cmd/optee_rpmb.c
index e0e44bbed04
Fix spelling errors in comments.
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Ilias Apalodimas
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b tags
drivers/tee/sandbox.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
Fix OPTEE_TA_AVB symbol description in Kconfig:
s/"write"rb"/"write_rb"/g
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Ilias Apalodimas
Signed-off-by: Igor Opaniuk
---
(no changes since v2)
Changes in v2:
- Applied R-b tags
drivers/tee/optee/Kconfig | 2 +-
1
/results?buildId=28=results
Changes in v3:
- Added calls for closing tee session after every read/write operation
Changes in v2:
- Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset'
- Applied R-b and T-b tags
Igor Opaniuk (6):
tee: optee: fix description in Kconfig
tee
Hi Ilias,
On Mon, Mar 4, 2024 at 12:16 PM Ilias Apalodimas <
ilias.apalodi...@linaro.org> wrote:
> Hi Igor,
>
> On Sun, 3 Mar 2024 at 00:01, Igor Opaniuk wrote:
> >
> >
> > - Address some spelling errors and typos
> > - Support CMD_OPTEE_RPMB for SAND
Hello Ilias,
On Fri, Mar 1, 2024 at 10:41 AM Ilias Apalodimas <
ilias.apalodi...@linaro.org> wrote:
> Hi Igor,
>
> On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk wrote:
> >
> > Hi Ilias,
> >
> > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk
> wrote
The usage of the common.h include file is deprecated [1], and has already
been removed from several files.
Get rid of all inclusions in the "drivers/tee" directory, and replace it
with required include files directly where needed.
[1] doc/develop/codingstyle.rst
Signed-off-by: Ig
Add read/write tests for optee_rpmb cmd.
Signed-off-by: Igor Opaniuk
---
(no changes since v1)
test/py/tests/test_optee_rpmb.py | 20
1 file changed, 20 insertions(+)
create mode 100644 test/py/tests/test_optee_rpmb.py
diff --git a/test/py/tests/test_optee_rpmb.py b
Tested-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Applied R-b and T-b tags
cmd/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index a86b5705174..8ad8c0c542c 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1370,7 +
Fix spelling errors in comments.
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Ilias Apalodimas
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Applied R-b tags
drivers/tee/sandbox.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tee/sandbox.c b/drivers
Fix OPTEE_TA_AVB symbol description in Kconfig:
s/"write"rb"/"write_rb"/g
Reviewed-by: Heinrich Schuchardt
Reviewed-by: Ilias Apalodimas
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Applied R-b tags
drivers/tee/optee/Kconfig | 2 +-
1 file changed, 1 insertio
- Address some spelling errors and typos
- Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
- Remove common.h inclusion for drivers/tee
Changes in v2:
- Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset'
- Applied R-b and T-b tags
Igor Opaniuk (5
Hi Tom,
On Sat, Mar 2, 2024 at 12:31 AM Tom Rini wrote:
> On Sun, Feb 11, 2024 at 07:56:16PM +0100, Igor Opaniuk wrote:
>
> > From: Igor Opaniuk
> >
> > Drop old implementation and use hash_command() instead, as
> > how it's currently done for crc32
Drop old implementation and use hash_command() instead, as
how it's currently done for crc32 and sha1sum cmds.
Test:
=> md5sum 0x6000 0x200
md5 for 6000 ... 61ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Addressed build issues o
Hello Tom,
On Sun, Feb 11, 2024 at 7:56 PM Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Drop old implementation and use hash_command() instead, as
> how it's currently done for crc32 and sha1sum cmds.
>
> Test:
> => md5sum 0x6000 0x200
> md
Hi Ilias,
On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk
wrote:
> - Address some spelling errors and typos
> - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
> - Remove common.h inclusion for drivers/tee
>
> Igor Opaniuk (5):
> tee: optee: fix desc
+CC Mattijs
On Mon, Feb 19, 2024 at 11:16 AM Igor Opaniuk
wrote:
> This takes the latest changes from AOSP from [1][2] (as this
> header was split on two) with minimal changes (this could lead
> to warnings reported by checkpatch).
>
> Some local changes have been appli
not too controversial) adds an ecdsa
> >>> verify driver (UCLASS_ECDSA) which utilizes tinycrypt to do the crypto
> >>> work.
> >>>
> >>
> >> Do we already use tiny crypt in the project, if not things like license
> >> need to be taken into account in the context of the GPLv2
> >>
> >> Please advise on how best to proceed. Happy to work within the confines of
> >>> what works best for the larger group.
> >>>
> >>> Thanks,
> >>> Bob Wolff
> >>>
> >>
--
Best regards - Freundliche Grüsse - Meilleures salutations
Igor Opaniuk
Senior Software Engineer, Embedded & Security
E: igor.opan...@foundries.io
W: www.foundries.io
struct udevice *dev)
> +{
> + return valid_cfgblock ? 0 : -EINVAL;
> +}
> +
> +static int tdx_get_str(struct udevice *dev, int id, size_t size, char *val)
> +{
> + int ret = -ENOTSUPP;
> +
> + switch (id) {
> + case SYSINFO_ID_BOARD_MODEL:
> + snprintf(val, size,
> +"Toradex %04d %s %s",
> +tdx_hw_tag.prodid,
> +toradex_modules[tdx_hw_tag.prodid].name,
> +tdx_board_rev_str);
> +
> + ret = 0;
> + }
> +
> + return ret;
> +}
> +
> +static const struct udevice_id sysinfo_tdx_ids[] = {
> + { .compatible = "toradex,sysinfo" },
> + { /* sentinel */ }
> +};
> +
> +static const struct sysinfo_ops sysinfo_tdx_ops = {
> + .detect = tdx_detect,
> + .get_str= tdx_get_str,
> +};
> +
> +U_BOOT_DRIVER(sysinfo_toradex) = {
> + .name = "sysinfo_toradex",
> + .id = UCLASS_SYSINFO,
> + .of_match = sysinfo_tdx_ids,
> + .ops= _tdx_ops,
> +};
> +
> #ifdef CONFIG_TDX_CFG_BLOCK_USB_GADGET_PID
> int g_dnl_bind_fixup(struct usb_device_descriptor *dev, const char *name)
> {
> --
> 2.39.2
>
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
http://ua.linkedin.com/in/iopaniuk
Hi Sam,
On Tue, Feb 20, 2024 at 7:29 PM Sam Protsenko
wrote:
>
> On Mon, Feb 19, 2024 at 4:16 AM Igor Opaniuk wrote:
> >
> > This takes the latest changes from AOSP from [1][2] (as this
> > header was split on two) with minimal changes (this could lead
> > to w
in
function `init_have_lse_atomics':
lse-init.c:(.text.startup+0xc): undefined reference to `__getauxval'
This is happening because we are linking against our own libcflat which
doesn't implement the function __getauxval().
Disable the use of the out-of-line functions by compiling with
-mno-outl
tps://android.googlesource.com/platform/hardware/interfaces/+/main/boot/1.1/default/boot_control/include/private/boot_control_definition.h
CC: Alex Deymo
CC: Sam Protsenko
CC: Eugeniu Rosca
CC: Simon Glass
Signed-off-by: Igor Opaniuk
---
include/android_bootloader_message.h |
The usage of the common.h include file is deprecated [1], and has already
been removed from several files.
Get rid of all inclusions in the "drivers/tee" directory, and replace it
with required include files directly where needed.
[1] doc/develop/codingstyle.rst
Signed-off-by: Ig
Add read/write tests for optee_rpmb cmd.
Signed-off-by: Igor Opaniuk
---
test/py/tests/test_optee_rpmb.py | 20
1 file changed, 20 insertions(+)
create mode 100644 test/py/tests/test_optee_rpmb.py
diff --git a/test/py/tests/test_optee_rpmb.py b/test/py/tests
Fix spelling errors in comments.
Signed-off-by: Igor Opaniuk
---
drivers/tee/sandbox.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c
index 86219a9bb1a..ec66401878c 100644
--- a/drivers/tee/sandbox.c
+++ b/drivers/tee
Fix OPTEE_TA_AVB symbol description in Kconfig:
s/"write"rb"/"write_rb"/g
Signed-off-by: Igor Opaniuk
---
drivers/tee/optee/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
index 9dc65b
Support CMD_OPTEE_RPMB for SANDBOX configurations.
Test:
$ ./u-boot -d arch/sandbox/dts/test.dtb
...
=> optee_rpmb write_pvalue test_variable test_value
Wrote 11 bytes
=> optee_rpmb read_pvalue test_variable 11
Read 11 bytes, value = test_value
Signed-off-by: Igor Opaniuk
---
cmd/Kconf
- Address some spelling errors and typos
- Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests
- Remove common.h inclusion for drivers/tee
Igor Opaniuk (5):
tee: optee: fix description in Kconfig
tee: sandbox: fix spelling errors
cmd: optee_rpmb: build cmd for sandbox
Hi Mattijs,
On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek
wrote:
>
> Hi Igor,
>
> On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote:
>
> > Hi Dan,
> >
> > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter
> > wrote:
> >>
> >> On
From: Igor Opaniuk
Add information about a custodian tree [1] for AVB/AB, which is
maintained by Mattijs Korpershoek.
[1] https://source.denx.de/u-boot/custodians/u-boot-dfu
Signed-off-by: Igor Opaniuk
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b
From: Igor Opaniuk
Add information about a custodian tree [1] for AVB/AB, which is
maintained by Mattijs Korpershoek.
[1] https://source.denx.de/u-boot/custodians/u-boot-dfu
Signed-off-by: Igor Opaniuk
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b
From: Igor Opaniuk
Add support for the SHA-512 Secure Hash Algorithm which uses ARMv8 Crypto
Extensions. The CPU should support ARMv8.2 instruction set and implement
SHA512H, SHA512H2, SHA512SU0, and SHA512SU1 instructions.
This information can be obtained from ID_AA64ISAR0_EL1 (AArch64
b/configs/khadas-vim3l_android_defconfig
> @@ -3,6 +3,7 @@ CONFIG_SYS_BOARD="vim3"
> CONFIG_SYS_CONFIG_NAME="khadas-vim3l_android"
> CONFIG_ARCH_MESON=y
> CONFIG_TEXT_BASE=0x0100
> +CONFIG_SYS_MALLOC_LEN=0x0800
> CONFIG_NR_DRAM_BANKS=1
>
Hi Dan,
On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter wrote:
>
> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote:
> > From: Igor Opaniuk
> >
> > mmc_switch_part() is used for switching between hw partitions
> > on eMMC (boot0, boot1, user, rpm
From: Igor Opaniuk
Drop old implementation and use hash_command() instead, as
how it's currently done for crc32 and sha1sum cmds.
Test:
=> md5sum 0x6000 0x200
md5 for 6000 ... 61ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050
Signed-off-by: Igor Opaniuk
---
cmd/md5sum.c
at and
nitpick: s/ccode/code/g
> +replace it with any required include files directly is much appreciated.
>
> If your file uses driver model, include in the C file. Do not include
> dm.h in a header file. Try to use forward declarations (e.g. ``struct
> --
> 2.34.1
>
Reviewed-by: Igor Opaniuk
--
Best regards - Atentamente - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
http://ua.linkedin.com/in/iopaniuk
Hi Tom,
On Sun, Feb 11, 2024 at 1:37 AM Tom Rini wrote:
>
> On Sat, Feb 10, 2024 at 01:07:09PM +0100, Igor Opaniuk wrote:
>
> > From: Igor Opaniuk
> >
> > Add support for the SHA-512 Secure Hash Algorithm which uses ARMv8 Crypto
> > Extensions. The CPU shoul
Hello Marc,
On Sun, Feb 11, 2024 at 12:12 AM Marc Zyngier wrote:
>
> [Fixing Ard's email address for something more current.]
>
> On Sat, 10 Feb 2024 12:07:09 +0000,
> Igor Opaniuk wrote:
> >
> > From: Igor Opaniuk
> >
> > Add support for the SHA-512
From: Igor Opaniuk
Add support for the SHA-512 Secure Hash Algorithm which uses ARMv8 Crypto
Extensions. The CPU should support ARMv8.2 instruction set and implement
SHA512H, SHA512H2, SHA512SU0, and SHA512SU1 instructions.
This information can be obtained from ID_AA64ISAR0_EL1 (AArch64
@@
>
> #include
> #include
> +#include
> #include
> #include
> #include
> @@ -99,7 +100,6 @@ int power_init_board(void)
> return 0;
> }
>
> -extern int imx9_probe_mu(void *ctx, struct event *event);
> void board_init_f(ulong dummy)
> {
>
From: Igor Opaniuk
Sync usage info with the one cmd/avb.c.
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Address Mattijs comment about usage info, sync with cmd/avb.c
doc/android/avb2.rst | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/doc/android
From: Igor Opaniuk
Use existing str_avb_slot_error() function for obtaining
verification fail reason details.
Take into account device lock state for setting correct
androidboot.verifiedbootstate kernel cmdline parameter.
Reviewed-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
From: Igor Opaniuk
Introduce str_avb_io_error() and str_avb_slot_error() functions,
that provide a pointer to AVB runtime error message.
Reviewed-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Mattijs Korpershoek R-b tag applied
common/avb_verify.c | 49
From: Igor Opaniuk
Simplify and add more context for prints where it's needed.
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Drop AVB_OPS_CHECK macro and leave previous check
cmd/avb.c | 123 +-
1 file changed, 75 insertions(+), 48
From: Igor Opaniuk
Make error prints more verbose with additional context.
Also s/print/debug/g for prints, which might be relevant only
for debugging purposes.
Reviewed-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Mattijs Korpershoek R-b tag applied
common
From: Igor Opaniuk
Move SPDX license identifiers to the first line, so it conforms
to license placement rule [1]:
Placement:
The SPDX license identifier in kernel files shall be added at the first
possible line in a file which can contain a comment. For the majority
of files this is the first
From: Igor Opaniuk
mmc_switch_part() is used for switching between hw partitions
on eMMC (boot0, boot1, user, rpmb).
There is no need to do that for SD card.
Reviewed-by: Mattijs Korpershoek
Signed-off-by: Igor Opaniuk
---
Changes in v2:
- Mattijs Korpershoek R-b tag applied
common
for eMMC.
- Rework do_avb_verify_part, take into account device lock state for setting
correct
androidboot.verifiedbootstate.
- Adjust AVB documentation, sync usage info with the one cmd/avb.c.
Igor Opaniuk (7):
common: avb_verify: don't call mmc_switch_part for SD
avb: move SPDX license
Hello Mattijs,
On Fri, Feb 9, 2024 at 11:30 AM Mattijs Korpershoek
wrote:
>
> Hi Igor,
>
> On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote:
>
> > Hi everyone,
> >
> > I'm currently planning a big overhaul of the current implementation of
> > AVB/AB
salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
http://ua.linkedin.com/in/iopaniuk
Hi Mattijs,
On Thu, Feb 8, 2024 at 3:00 PM Mattijs Korpershoek
wrote:
>
> Hi Igor,
>
> Thank you for the patch.
>
> On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
> wrote:
>
> > From: Igor Opaniuk
> >
> > Introduce AVB_OPS_CHECK macro for checkin
Hi Mattijs,
On Thu, Feb 8, 2024 at 3:12 PM Mattijs Korpershoek
wrote:
>
> Hi Igor,
>
> Thank you for the patch.
>
> On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
> wrote:
>
> > From: Igor Opaniuk
> >
> > Add info about slot_suffix param for avb v
Hello Tom, Peter,
On Wed, Feb 7, 2024 at 3:16 PM Peter Robinson wrote:
>
> On Wed, 7 Feb 2024 at 13:48, Tom Rini wrote:
> >
> > On Wed, Feb 07, 2024 at 02:00:16PM +0100, Igor Opaniuk wrote:
> > > Hello,
> > >
> > > I was playing a bit with different
Hi Tom,
On Wed, Feb 7, 2024 at 1:01 AM Igor Opaniuk wrote:
>
> From: Igor Opaniuk
>
> Add correct check for parameter count.
>
> This fixes this issue when `hash` cmd is invoked without params:
>
> => hash
> data abort
> pc : [] lr : []
> reloc
fault y
> help
> activate the command "stm32prog usb" for STM32MP soc family
> --
> 2.25.1
>
Reviewed-by: Igor Opaniuk
--
Best regards - Freundliche Grüsse - Meilleures salutations
Igor Opaniuk
Senior Software Engineer, Embedded & Security
E: igor.opan...@foundries.io
W: www.foundries.io
Hi Tom,
On Wed, Feb 7, 2024 at 2:48 PM Tom Rini wrote:
>
> On Wed, Feb 07, 2024 at 02:00:16PM +0100, Igor Opaniuk wrote:
> > Hello,
> >
> > I was playing a bit with different hash functions recently, and
> > it turned out that md5sum, crc32, sha1 cmds just duplica
sh calculation.
Comments/objections are welcome!
Regards,
Igor
--
Best regards - Freundliche Grüsse - Meilleures salutations
Igor Opaniuk
mailto: igor.opan...@gmail.com
skype: igor.opanyuk
+48 666 108 041
http://ua.linkedin.com/in/iopaniuk
g at one of the load instruction.
> + *
> +* To avoid the above two conditions disable linefill optimization
> +* inside Cortex R5F.
> +*/
> + asm("mrc p15, 0, %0, c1, c0, 1" : "=r" (actlr));
> + actlr |= (1 << 13); /* Set DLFO bit */
> + asm("mcr p15, 0, %0, c1, c0, 1" : : "r" (actlr));
> +}
> --
> 2.39.2
>
Reviewed-by: Igor Opaniuk
--
Best regards - Freundliche Grüsse - Meilleures salutations
Igor Opaniuk
Senior Software Engineer, Embedded & Security
E: igor.opan...@foundries.io
W: www.foundries.io
oaded when booting from a SPI flash memory.
> +
> +config SYS_K3_SPL_ATF
> + bool "Start Cortex-A from SPL"
> + help
> + Enabling this will try to start Cortex-A (typically with ATF)
> + after SPL from R5.
> --
> 2.39.2
>
Reviewed-by: Igo
From: Igor Opaniuk
Add correct check for parameter count.
This fixes this issue when `hash` cmd is invoked without params:
=> hash
data abort
pc : [] lr : []
reloc pc : [<60019204>]lr : [<5afcffa8>]
sp : ba6dd9c8 ip : bf7391f0 fp : bf74ec14
r10: 0001 r9 :
From: Igor Opaniuk
Add info about slot_suffix param for avb verify.
Signed-off-by: Igor Opaniuk
---
doc/android/avb2.rst | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/doc/android/avb2.rst b/doc/android/avb2.rst
index a072119574f..c0b2bedb831 100644
--- a/doc
From: Igor Opaniuk
Use existing str_avb_slot_error() function for obtaining
verification fail reason details.
Take into account device lock state for setting correct
androidboot.verifiedbootstate kernel cmdline parameter.
Signed-off-by: Igor Opaniuk
---
cmd/avb.c | 50
From: Igor Opaniuk
Introduce str_avb_io_error() and str_avb_slot_error() functions,
that provide a pointer to AVB runtime error message.
Signed-off-by: Igor Opaniuk
---
common/avb_verify.c | 49
include/avb_verify.h | 3 ++-
2 files changed, 51
From: Igor Opaniuk
Introduce AVB_OPS_CHECK macro for checking AvbOps before using
it to avoid code duplication.
Simplify and add more context for prints where it's needed.
Signed-off-by: Igor Opaniuk
---
cmd/avb.c | 156 --
1 file changed
From: Igor Opaniuk
Make error prints more verbose with additional context.
Also s/print/debug/g for prints, which might be relevant only
for debugging purposes.
Signed-off-by: Igor Opaniuk
---
common/avb_verify.c | 31 ++-
1 file changed, 18 insertions(+), 13
1 - 100 of 957 matches
Mail list logo
