Hi,
On 5/26/21 5:46 PM, ela...@denx.de wrote:
> From: Joseph Chen
Is it right patch? This patch had been already applied.
Best Regards,
Jaehoon Chung
>
> support parse regulator standard property:
> regulator-off-in-suspend;
> regulator-init-microvolt;
> regulator
Hi,
On 5/26/21 5:46 PM, ela...@denx.de wrote:
> From: Elaine Zhang
>
> Support more PMIC and improve compatibility between pmics.
I didn't see your full patchset, except [PATCH V5 1/6].
If i missed something, let me know, plz.
Best Regards,
Jaehoon Chung
>
> Change in
ath Govindraju
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/am654_sdhci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c
> index a86d96aacd2b..4305967d7845 100644
> --- a/drivers/mm
eric properties like broken-cd and
> advanced transfer modes.
>
> Drop our own code and call mmc_of_parse() instead, to get all new
> features for free.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
>
confusing nested #ifdefs.
>
> Clean up the also confusing new_mode setting on the way.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/sunxi_mmc.c | 15 ++-
> 1 file changed, 6 insertions(+)
more than 32 bits.
>
> Add the proper casts to make it compile cleanly.
>
> Signed-off-by: Andre Przywara
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/sunxi_mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --
e Przywara
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/sunxi_mmc.c | 33 +++--
> 1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> index 3503ccdb2ee.
>
You can enable MMC_TRACE, then you can see more information.
Best Regards,
Jaehoon Chung
>
> *(CLK =25MHz)*
> => run mmc_format
> eMMC: INT_STATUS = 00018000
> eMMC: INT_STATUS = 00018001
> sdhci_transfer_data: Transfer data timeout
> sdhci_transfer_data: Tran
Dear Andy,
On 5/12/21 7:09 AM, Jaehoon Chung wrote:
> Dear Andy
>
> On 5/11/21 4:39 PM, andy...@sony.com wrote:
>> Hi Jaehoon
>>
>>> If you're ok, I will test after reverted the patch on tomorrow, and I will
>>> share
>>> result.
>&
On 5/14/21 7:17 AM, Reuben Dowle wrote:
>
>>
>> Could you also update doc/usage/mmc.rst?
>>
>
> I have sent a v4 patch that also updates the documentation.
Thank you!
Best Regards,
Jaehoon Chung
>
>
> [cid:4RFLog
er partition.
>
> Signed-off-by: Reuben Dowle
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> cmd/mmc.c | 14 +-
> doc/usage/mmc.rst | 4 +++-
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/cmd/mmc.c b/cmd/mmc.c
>
; bootloader partition.
Could you also update doc/usage/mmc.rst?
>
> Signed-off-by: Reuben Dowle
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> cmd/mmc.c | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/cmd/mmc.c b/c
any update for this comments?
Sorry for replying too late. I had been doing other things.
So if you're ok, i will test on my own boards with your patch until this
weekend.
(If possible, i will also check 410c board.)
Best Regards,
Jaehoon Chung
>
> Best Regards
> Andy Wu
>
&
igned-off-by: Tero Kristo
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> cmd/ti/Kconfig | 8 ++
> cmd/ti/Makefile| 1 +
> cmd/ti/pd.c| 185 +
> drivers/po
Tero Kristo
> Signed-off-by: Tero Kristo
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/power/domain/Kconfig | 7 +
> drivers/power/domain/Makefile | 1 +
> drivers/power/domain/ti-power-domain.c | 368 +
On 5/10/21 3:32 PM, Masami Hiramatsu wrote:
> From: Jassi Brar
>
> Signed-off-by: Jassi Brar
> Signed-off-by: Masami Hiramatsu
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> Changes in v3:
> - Rename config name to MMC_SDHCI_F_SDH30.
> - Remove
Modify mmc man-page.
- Change a description about mmc erase command.
- Add whitespace to distinguish.
Signed-off-by: Jaehoon Chung
Reviewed-by: Bin Meng
---
Changelog on V2:
- Added Bin Meng's reviewed-tag
- Fixed typo in commit-msg
- Changed from count to cnt
---
doc/usage/mmc.rst | 3 +
set). In
> this case all three values are mandatory, and this is not changing.
is mandatory, and [ ] is
optional.
If optional variable will be used, those variables can be mandatory, right?
mmc partconf is displayed even without other variables.
"mmc partconf [[varname] | [
]]&q
Modify mmc man-page.
- Change a descritpion about mmc erase command.
- Add whitespace to distinguish.
Signed-off-by: Jaehoon Chung
---
doc/usage/mmc.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/usage/mmc.rst b/doc/usage/mmc.rst
index 57284ed6741e..6457c934c084
\n"
> + " - Show the bits of the PARTITION_CONFIG field of the specified
> device,\n"
> + " optionally storing the boot_partion value into "
> + "mmc partconf\n"
boot_ack / boot_partition / partition_access are option
Hi Tero,
On 5/6/21 2:55 AM, Tero Kristo wrote:
> From: Tero Kristo
>
> Normally, power domains are handled via TI-SCI in K3 SoCs. However,
> SPL is not going to have access to sysfw resources, so it must control
> them directly. Add driver for supporting this.
>
> Signed-off-by: Tero Kristo
>
On 4/26/21 2:17 PM, Ley Foon Tan wrote:
> Add FIFO mode support for SoCFPGA dwmmc, read "fifo-mode" property from DT.
>
> Signed-off-by: Ley Foon Tan
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/socfpga_dw_mmc.c | 2 ++
>
a read path and clear interrupts before
> start reading from FIFO. So, it doesn't clear the next pending
> interrupts unintentionally after read from FIFO.
>
> Signed-off-by: Ley Foon Tan
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/dw_mmc.
e sending patch, how about run checkpatch.pl?
There is checkpatch.pl under scripts directory.
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Tianrui Wei
> Signed-off-by: Jonathan Balkind
>
>
> ---
>
> drivers/mmc/Kconfig | 6 +
> drivers/mmc
On 4/26/21 7:05 AM, Jassi Brar wrote:
> On Mon, 19 Apr 2021 at 17:05, Jaehoon Chung wrote:
>
>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
>>> index d9ab6a0a83..f038debc6c 100644
>>> --- a/drivers/mmc/sdhci.c
>>> +++ b/drivers/mmc/s
On 4/23/21 11:23 PM, Heinrich Schuchardt wrote:
> On 02.04.21 02:15, Jaehoon Chung wrote:
>> Provide a man-pages for the mmc command.
>>
>> Signed-off-by: Jaehoon Chung
>> ---
>> Changelog on V2
>> - Add missing empty line
>> - Add bootbus's arg
iton_mmc.c b/drivers/mmc/piton_mmc.c
> new file mode 100644
> index ..f2ceb87f
> --- /dev/null
> +++ b/drivers/mmc/piton_mmc.c
> @@ -0,0 +1,177 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * (C) Copyright 2009 SAMSUNG Electronics
> + * Minkyu Kang
> + * J
atdata(dev);
>> + struct mmc_config *cfg = &plat->cfg;
>> +
>> + cfg->name = dev->name;
>> + upriv->mmc = &plat->mmc;
>> + upriv->mmc->has_init = 1;
>> + upriv->mmc->capacity = 0x20ULL;
>> + upriv->mmc->read_bl_len = MMC_MAX_BLOCK_LEN;
>> +
>> + return piton_mmc_init(dev);
Not need. Just return 0.
>> +}
>> +
>> +static int piton_mmc_bind(struct udevice *dev)
>> +{
>> + struct piton_mmc_plat *plat = dev_get_platdata(dev);
>> + struct mmc_config *cfg = &plat->cfg;
>> +
>> + cfg->name = dev->name;
>> + cfg->host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS | MMC_MODE_8BIT;
>> + cfg->voltages = MMC_VDD_165_195 | MMC_VDD_32_33 | MMC_VDD_33_34;
>> + cfg->f_min = 100;
>> + cfg->f_max = 5200;
>> + cfg->b_max = U32_MAX;
>> +
>> + return mmc_bind(dev, &plat->mmc, cfg);
>> +}
>> +
>> +static const struct udevice_id piton_mmc_ids[] = {
>> + {.compatible = "openpiton,piton-mmc"}, {}
>
> nits: please put {} on a separate line
Fix indetation.
>
>> +};
>> +
>> +U_BOOT_DRIVER(piton_mmc_drv) = {
>> + .name = "piton_mmc",
>> + .id = UCLASS_MMC,
>> + .of_match = piton_mmc_ids,
>> + .ofdata_to_platdata = piton_mmc_ofdata_to_platdata,
>> + .bind = piton_mmc_bind,
>> + .probe = piton_mmc_probe,
>> + .ops = &piton_mmc_ops,
>> + .platdata_auto_alloc_size = sizeof(struct piton_mmc_plat),
>> + .priv_auto_alloc_size = sizeof(struct piton_mmc_priv),
Ditto.
Best Regards,
Jaehoon Chung
>> +};
>> --
>
> Regards,
> Bin
>
On 4/20/21 9:59 AM, Masami Hiramatsu wrote:
> Hi Jaehoon,
>
> Thanks for your comments.
>
> 2021年4月20日(火) 7:05 Jaehoon Chung :
>>
>> Hi Masami,
>>
>> On 4/17/21 8:38 AM, Masami Hiramatsu wrote:
>>> From: Jassi Brar
>>>
>>&
hci.c
> @@ -708,6 +708,15 @@ static int sdhci_init(struct mmc *mmc)
>
> sdhci_set_power(host, fls(mmc->cfg->voltages) - 1);
>
> + if (IS_ENABLED(CONFIG_F_SDH30_SDHCI)) {
I don't want to add specific sdhci driver configuration in sdhci.c.
According to below com
On 4/12/21 1:28 AM, Marek Vasut wrote:
> The driver is compatible with iMX8MN, add missing compatible string.
>
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Peng Fan
> Cc: Stefano Babic
> Cc: Ye Li
> Cc: uboot-imx
Reviewed-by: Jaehoon Chung
Bes
On 4/12/21 1:28 AM, Marek Vasut wrote:
> The driver is compatible with iMX8MM, add missing compatible string.
>
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Peng Fan
> Cc: Stefano Babic
> Cc: Ye Li
> Cc: uboot-imx
Reviewed-by: Jaehoon Chung
Bes
nts initialization.
>
> Signed-off-by: Konstantin Porotchkin
> Signed-off-by: Stefan Roese
> Cc: Jaehoon Chung
> Cc: Simon Glass
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> v2:
> - Add check for uc_pdata in regulator_unset()
>
>
Hi Stefan,
On 4/9/21 2:20 PM, Stefan Roese wrote:
> Hi Jaehoon,
>
> On 09.04.21 02:37, Jaehoon Chung wrote:
>> On 4/9/21 7:52 AM, Jaehoon Chung wrote:
>>> Hi Stefan,
>>>
>>> On 4/8/21 6:20 PM, Stefan Roese wrote:
>>>> From: Konstantin Poro
On 4/9/21 7:52 AM, Jaehoon Chung wrote:
> Hi Stefan,
>
> On 4/8/21 6:20 PM, Stefan Roese wrote:
>> From: Konstantin Porotchkin
>>
>> Add support for regulator-force-boot-off DT property.
>> This property can be used by the board/device drivers for
>> turn
e other components initialization.
>
> Signed-off-by: Konstantin Porotchkin
> Signed-off-by: Stefan Roese
> Cc: Jaehoon Chung
> Cc: Simon Glass
> ---
> drivers/power/regulator/regulator-uclass.c | 38 ++
> include/power/regulator.h
On 4/6/21 4:57 PM, Patrick Delaunay wrote:
> Simplify the code of the function board_check_usb_power
> based in CONFIG_ADC and adc_measurement; the function is removed by the
> linker when the CONFIG_ADC is not activated.
>
> Signed-off-by: Patrick Delaunay
Reviewed-by: Jaeho
errors about CONFIG_ROM_SIZE being missing.
>
> Signed-off-by: Simon Glass
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
>
> arch/x86/dts/chromebook_coral.dts | 2 +-
> arch/x86/dts/chromebook_samus.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(
> Do you see any issue if revert the patch?
If you're ok, I will test after reverted the patch on tomorrow, and I will
share result.
Or I will try to reproduce timeout issue on 410c board.
Best Regards,
Jaehoon Chung
>
> Thanks,
> Peng.
>
>>
>> Best
On 4/3/21 6:47 AM, Peter Robinson wrote:
> The odroid has USB ethernet so enable DM Ethernet support.
>
> Signed-off-by: Peter Robinson
> Jaehoon Chung
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> configs/odroid_defconfig | 1 +
> 1 file changed, 1 i
On 4/5/21 11:44 PM, Aswath Govindraju wrote:
> From: Faiz Abbas
>
> Enable HS400 speed mode by writing to HOST_CONTROL2 register.
>
> Signed-off-by: Faiz Abbas
> Signed-off-by: Aswath Govindraju
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
>
have a corresponding CONFIG_SPL_MMC_VERBOSE defined in
> Kconfig.
Sorry, i didn't see your build error.
Best Regards,
Jaehoon Chung
>
> Fixes this build error:
>
> arm-linux-gnueabi-ld.bfd: drivers/built-in.o: in function
> `mmc_select_mode':
>
>
on,
>
> Do you see any issue if revert the patch?
If you're ok, I will test after reverted the patch on tomorrow, and I will
share result.
Or I will try to reproduce timeout issue on 410c board.
Best Regards,
Jaehoon Chung
>
> Thanks,
> Peng.
>
>>
>> Best
Hi Aswath,
On 4/6/21 5:26 PM, Aswath Govindraju wrote:
> Hi Jaehoon,
>
> On 06/04/21 10:50 am, Aswath Govindraju wrote:
>> Hi Jaehoon,
>>
>> On 06/04/21 3:48 am, Jaehoon Chung wrote:
>>> Hi,
>>>
>>> On 4/5/21 11:44 PM, Aswath Govindraju wrot
de/sdhci.h, it mentioned to "Non-standard".
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Faiz Abbas
> Signed-off-by: Aswath Govindraju
> ---
> drivers/mmc/sdhci.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
&
On 4/3/21 3:05 AM, Peter Robinson wrote:
> Convert Warp to use DM MMC.
>
> Signed-off-by: Peter Robinson
> Cc: Otavio Salvador
> Cc: Fabio Estevam
> Cc: Stefano Babic
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> arch/arm/dts/imx6sl-warp-u-boot.d
On 4/2/21 9:47 PM, Marek Vasut wrote:
> The driver is compatible with iMX8MM, add missing compatible string.
>
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Peng Fan
> Cc: Stefano Babic
> Cc: Ye Li
> Cc: uboot-imx
Reviewed-by: Jaehoon Chung
Bes
On 4/2/21 9:47 PM, Marek Vasut wrote:
> Add power domain nodes to DT.
>
> Signed-off-by: Marek Vasut
> Cc: Fabio Estevam
> Cc: Peng Fan
> Cc: Stefano Babic
> Cc: Ye Li
> Cc: uboot-imx
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
On 4/3/21 6:47 AM, Peter Robinson wrote:
> The odroid-xu3 has USB ethernet so enable DM Ethernet support.
>
> Signed-off-by: Peter Robinson
> Cc: Jaehoon Chung
> Cc: Lukasz Majewski
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> configs/odroid-xu3_defc
On 4/2/21 1:15 PM, Heinrich Schuchardt wrote:
> On 4/2/21 2:15 AM, Jaehoon Chung wrote:
>> Provide a man-pages for the mmc command.
>>
>> Signed-off-by: Jaehoon Chung
>> ---
>> Changelog on V2
>> - Add missing empty line
>> - Add bootbus's argu
Provide a man-pages for the mmc command.
Signed-off-by: Jaehoon Chung
---
Changelog on V2
- Add missing empty line
- Add bootbus's arguments descriptions
---
doc/usage/index.rst | 1 +
doc/usage/mmc.rst | 212
2 files changed, 213 inser
rd with eMMC.
>
> Signed-off-by: Harm Berntsen
> Tested-by: Harm Berntsen
> Reviewed-by: Simon Glass
> Reviewed-by: Stefan Roese
> CC: Pantelis Antoniou
> CC: Stefan Roese
> CC: Gerald Kerma
> CC: Simon Glass
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chu
Hi Heinrich,
Thanks for review.
On 3/30/21 7:39 PM, Heinrich Schuchardt wrote:
> On 3/30/21 1:29 AM, Jaehoon Chung wrote:
>> Provide a man-pages for the mmc command.
>>
>> Signed-off-by: Jaehoon Chung
>> ---
>> doc/usage/index.rst | 1
Provide a man-pages for the mmc command.
Signed-off-by: Jaehoon Chung
---
doc/usage/index.rst | 1 +
doc/usage/mmc.rst | 182
2 files changed, 183 insertions(+)
create mode 100644 doc/usage/mmc.rst
diff --git a/doc/usage/index.rst b/doc/usage
d.bfd: cmd/built-in.o: in function `do_mmc_setdsr':
> cmd/mmc.c:873: undefined reference to `find_mmc_device'
>
> Add missing dependency.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> cmd/Kconfig | 1 +
On 3/27/21 10:46 PM, Ying-Chun Liu wrote:
> From: "Ying-Chun Liu (PaulLiu)"
>
> Document the bindings for fsl,anatop-regulator
>
> Signed-off-by: Ying-Chun Liu (PaulLiu)
> Reviewed-by: Sean Anderson
> Cc: Fabio Estevam
> Cc: Jaehoon Chung > Cc: Peng Fa
; This patch adds the Anatop regulator driver.
>
> Signed-off-by: Ying-Chun Liu (PaulLiu)
> Reviewed-by: Sean Anderson
> Cc: Fabio Estevam
> Cc: Jaehoon Chung
> Cc: Peng Fan
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> v2: add functions for set s
On 3/25/21 4:18 PM, Aswath Govindraju wrote:
> Use dev_seq() to read aliases node's index and pass it as device number
> for creating bulk device.
>
> Suggested-by: Grygorii Strashko
> Signed-off-by: Aswath Govindraju
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chu
Dear Harm,
On 3/25/21 10:48 PM, Harm Berntsen wrote:
> This is a straightforward conversion of the old, non-dm driver. It was
> done in-place as the deadline for non-dm MMC has passed. Previous
> commits ensured that no board depends on the old, non-dm variant.
> Tested
> on a Kirkwood based board
, and SOC.
>> And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).
>> This patch adds the Anatop regulator driver.
>>
>> Signed-off-by: Ying-Chun Liu (PaulLiu)
>> Cc: Fabio Estevam
>> Cc: Jaehoon Chung
>> Cc: Peng Fan
>> Cc: Sean Anderson
>>
On 3/25/21 6:44 AM, Simon Glass wrote:
> It is useful to have a board with unit tests enabled, to check that this
> does not break.
>
> Let's choose snow, since it is not under active development and it is
> glorious.
>
> Signed-off-by: Simon Glass
Reviewed-by: Ja
On 3/25/21 6:44 AM, Simon Glass wrote:
> Add a bus driver for this and use it to configure the bus parameters for
> the Ethernet interface. Drop the old pre-driver-model code.
>
> Switch over to use driver model for Ethernet.
>
> Signed-off-by: Simon Glass
Reviewed-by: Ja
ess it maybe
another issue, and can be fixed with modification limited to stop command,
not for all response-with-busy command.
Does the SDHCI_QUIRK_BROKEN_R1B can be used for this case?
Well, it can be used.
Best Regards,
Jaehoon Chung
Best Regards
Andy Wu
-Original Message-
From:
On 3/19/21 4:57 PM, Peng Fan (OSS) wrote:
> From: Peng Fan
>
> Currently PCA9450 might have address 0x25 or 0x35, so let user
> choose the address.
>
> Signed-off-by: Peng Fan
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> board/freescale/imx8mp_ev
command.
To prevent it, it needs to increase timeout value at that time.
(Timeout value can't fix each boards, waste time to find proper value,
and be performance degradation.)
I didn't test without this patch on latest U-boot.
But if there is no critical issue, keep it, plz.
Best Regards,
On 3/18/21 8:01 AM, Michael Walle wrote:
> Am 2021-03-17 23:47, schrieb Jaehoon Chung:
>> On 3/17/21 11:01 PM, Michael Walle wrote:
>>> config SYS_FSL_ERRATUM_A011334
>>> bool
>>> +
>>> +config SYS_FSL_ESDHC_UNRELIABLE_PULSE_DETECTION_WORK
On 3/18/21 7:59 AM, Michael Walle wrote:
> Am 2021-03-17 23:49, schrieb Jaehoon Chung:
>> On 3/17/21 11:01 PM, Michael Walle wrote:
>>> Since commit 8ee802f899ef ("mmc: fsl_esdhc: make sure delay chain locked
>>> for HS400") HS400 mode is unreliable
/protect2.fireeye.com/v1/url?k=c6e5783a-997e4136-c6e4f375-000babff3563-b4c710a5ba70271e&q=1&e=5f5cbefe-f62f-4eea-8384-94747700342f&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D230325
> along with I believe I need to v2 dropping some defconfigs for I believe
> mx28evk once Stefano picks up Fabio's patch to update and maintain the
> main defconfig (he already ack'd such a removal).
If removed board not to suppport DM_MMC, I think that mmc driver can be cleaned
more than not.
Great. Thanks!
Best Regards,
Jaehoon Chung
>
ff-by: Michael Walle
It seems that this patch doesn't need. Because CONFIG_MMC_HS400_SUPPORT is
re-enabling with [PATCH 4/4].
How about dropping Drop [PATCH 1/4] and [PATCH 4/4]?
Best Regards,
Jaehoon Chung
> ---
> configs/kontron_sl28_defconfig | 2 +-
> 1 file changed, 1 insertio
config SYS_FSL_ESDHC_UNRELIABLE_PULSE_DETECTION_WORKAROUND
How about using QUIRK instead of WORKAROUD
Best Regards,
Jaehoon Chung
> + bool
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 09ea1a9de9..7501fdb71e 100644
> --- a/drivers/mmc/fsl_esdhc.c
>
On 3/17/21 7:25 AM, Tom Rini wrote:
> On Wed, Mar 17, 2021 at 06:53:16AM +0900, Jaehoon Chung wrote:
>> Dear Tom,
>>
>> On 1/28/21 8:42 PM, Jaehoon Chung wrote:
>>> It's only one board which is using max_77696_init().
>>> pmic_max77696.c didn'
Dear Tom,
On 1/28/21 8:42 PM, Jaehoon Chung wrote:
> It's only one board which is using max_77696_init().
> pmic_max77696.c didn't convert from no-DM to DM.
> So it's waste to maintain in driver directory.
Is there any opinion? If there is no objection about this, let m
On 3/15/21 7:48 PM, Aswath Govindraju wrote:
> Assign the nodes alias index as the device number in SPL too, if
> CONFIG_SPL_DM_SEQ_ALIAS is enabled.
>
> Signed-off-by: Aswath Govindraju
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc
On 3/15/21 7:48 PM, Aswath Govindraju wrote:
> First check if there is an alias for the device tree node defined with the
> given num before checking against device index.
>
> Signed-off-by: Aswath Govindraju
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
>
On 3/15/21 2:00 PM, Simon Glass wrote:
> Since the recent bug fix, it doesn't matter which GPIO phandle is used so
> long as the GPIO number is right. Still, we may as well use the correct
> one to avoid confusion.
>
> Signed-off-by: Simon Glass
Reviewed-by: Jaehoon
Signed-off-by: Simon Glass
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
>
> arch/x86/dts/chromebook_coral.dts | 1 +
> include/configs/chromebook_coral.h | 6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/
com/v1/url?k=3da6e589-623ddd40-3da76ec6-0cc47a336fae-8f68d44282000af5&q=1&e=d232145a-df26-46c6-b2ed-fd2b665c4b71&u=https%3A%2F%2Fgithub.com%2Ftorvalds%2Flinux%2Fcommit%2F2add5cacff3531e54c50b0832128299faa9f0563
> Signed-off-by: Etienne Carriere
Reviewed-by: Jaehoon Chung
Best Regar
On 3/8/21 10:04 PM, Paul Liu wrote:
> Hi Jaehoon,
>
> Thanks for the review.
>
> On Mon, 8 Mar 2021 at 07:03, Jaehoon Chung wrote:
>
>> Dear Ying-Chun
>>
>> On 3/8/21 3:18 AM, Ying-Chun Liu wrote:
>>> From: "Ying-Chun Liu (PaulLiu)"
>
On 3/6/21 7:11 AM, Fabio Estevam wrote:
> Pass "pfuze3000@8" in pmic_get() so that the PMIC node can
> be found in the devicetree.
>
> Signed-off-by: Fabio Estevam
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> board/technexion/pico-imx6ul/pi
de(dev),
> + "anatop-vol-bit-width",
> + &sreg->vol_bit_width);
> + if (ret) {
> + dev_err(dev, "no anatop-vol-bit-width property set\n");
> + return ret;
> + }
&g
frequency to a slightly higher value can solve the
> issue without any side effects.
>
> Signed-off-by: Weijie Gao
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> drivers/mmc/mtk-sd.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mmc/
lock frequency should be chosen one of {10,
20, 30, 40}.
How about defined one of them?
Best Regards,
Jaehoon Chung
> +
> #define CMD_INTS_MASK\
> (MSDC_INT_CMDRDY | MSDC_INT_RSPCRCERR | MSDC_INT_CMDTMO)
>
> @@ -1639,6 +1641,9 @@ static int msdc
serial
> Err: serial
> Net: eth0: ethernet@7d58
> Hit any key to stop autoboot: 0
> U-Boot> pci enum
> PCIe BRCM: link up, 5.0 Gbps x1 (SSC)
> U-Boot> usb start
> starting USB...
> Bus xhci_pci: Host not halted after 16000 microseconds.
> probe failed, error -16
> No working controllers found
> U-Boot>
>
> I've checked that on two RPi4 boards (one with 1GB RAM and one with 8GB).
It seems that couldn't get hc_length from capbase.
us xhci_pci: XHCI-PCI init hccr ff80 and hcor ff80 hc_length 0
xhci_register: dev='xhci_pci', ctrl=3a3679c0, hccr=ff80, hcor=ff80
When i have compared with working and not, hc_length is different.
hc_length should be to set 0x20 when it's working fine.
I don't have the knowledge of USB..So it's taking too more time for debugging.
Could you share what i do to check more?
Best Regards,
Jaehoon Chung
>
> Best regards
>
On 3/2/21 8:04 AM, Andre Przywara wrote:
> On Tue, 2 Mar 2021 07:11:54 +0900
> Jaehoon Chung wrote:
>
>> On 3/1/21 11:25 PM, Andre Przywara wrote:
>>> On Mon, 1 Mar 2021 18:47:26 +0530
>>> Amit Tomar wrote:
>>>
>>> Hi,
>>>
>&
tatic definition of mode,
> meaning it won't be initialised.
It seems that it doesn't initialize in this function.
I think that resp_type may be always matched one of condition.
I think that's why the compiler doesn't warn.
Best Regards,
Jaehoon Chung
>
>> that i
Hi Heinrich,
On 2/26/21 7:32 PM, Heinrich Schuchardt wrote:
> On 2/26/21 11:01 AM, Jaehoon Chung wrote:
>> Provide a man-pages for the mmc command.
>>
>> Signed-off-by: Jaehoon Chung
>> ---
>> doc/usage/mmc.rst | 149 +++
Provide a man-pages for the mmc command.
Signed-off-by: Jaehoon Chung
---
doc/usage/mmc.rst | 149 ++
1 file changed, 149 insertions(+)
create mode 100644 doc/usage/mmc.rst
diff --git a/doc/usage/mmc.rst b/doc/usage/mmc.rst
new file mode 100644
According to Specification, each bit have valid value.
But it doesn't check whether arguments is valid or not.
It has potential bug with arguments passed by wrong value.
Signed-off-by: Jaehoon Chung
---
cmd/mmc.c | 39 ++-
1 file changed, 38 insertions(
- <{gp1|gp2|gp3|gp4}><{on|off}>
MODE - <{check|set|complete}>
Signed-off-by: Jaehoon Chung
---
cmd/mmc.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/cmd/mmc.c b/cmd/mmc.c
index cb6b59f36a43..c1c00d0f325d 100644
--- a/cmd/mmc.c
++
On 2/26/21 3:15 PM, Rayagonda Kokatanur wrote:
> From: Bharat Gooty
>
> Add tuning functionality which is needed for HS200 mode.
> For HS200, program the correct needed 1.8 voltage
>
> Signed-off-by: Bharat Gooty
> Signed-off-by: Rayagonda Kokatanur
Reviewed-by: Jaehoon
Remove pmic_max8997/8 files about no-DM.
There are already existed max8997/8 as driver-model.
Signed-off-by: Jaehoon Chung
Reviewed-by: Simon Glass
---
drivers/power/pmic/Makefile | 2 -
drivers/power/pmic/pmic_max8997.c | 107 --
drivers/power/pmic
Convert to driver model about power_key_pressed.
Signed-off-by: Jaehoon Chung
Reviewed-by: Simon Glass
---
board/samsung/common/misc.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
elog on V2:
- Rebased on latest u-boot
- Add Simon's reviewed-tag
Jaehoon Chung (2):
board: samsung: covert to driver model about power_key_pressed
power: pmic: remove pmic_max8997/8 files
board/samsung/common/misc.c | 27
drivers/power/pmic/Makefile | 2 -
dri
ther platforms, do not has this issue.
>
> To fix this issue, fix the DTOCV to 0xE, the max setting, this also align
> with Linux configuration.
>
> Signed-off-by: Haibo Chen
> Reviewed-by: Ye Li
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> driver
x configuration.
>
> Signed-off-by: Etienne Carriere
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> Changes in v2:
> - discard adding tests on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c
>for the reason stated in commit log.
> ---
> arch/san
On 2/19/21 10:33 PM, Etienne Carriere wrote:
> Implement sandbox regulator devices for SCMI voltage domains
> and test them in DM scmi tests.
>
> Signed-off-by: Etienne Carriere
Reviewed-by: Jaehoon Chung
Best Regards,
Jaehoon Chung
> ---
> Changes in v2:
> -
com/v1/url?k=8c3fa7e5-d3a49ef4-8c3e2caa-0cc47a31cdbc-5d6f0aa01e7bcbb1&q=1&e=117141f8-c98a-4b9c-83e8-c7bbf1ffbd72&u=https%3A%2F%2Fgithub.com%2Ftorvalds%2Flinux%2Fcommit%2F2add5cacff3531e54c50b0832128299faa9f0563
>
> Signed-off-by: Etienne Carriere
Reviewed-by: Jaehoon Chung
B
On 12/16/20 7:24 AM, Jaehoon Chung wrote:
> It's confusing whether arguments are optional or mandatory.
> Update the command's usage to clarify how to use.
>
> Signed-off-by: Jaehoon Chung
> Reviewed-by: Simon Glass
Ping. Is there any progress about this patch?
Be
On 12/8/20 7:10 AM, Tom Rini wrote:
> On Fri, Dec 04, 2020 at 06:36:00AM +0900, Jaehoon Chung wrote:
>
>> Initialize an err variable to 0.
>>
>> Signed-off-by: Jaehoon Chung
>
> Reported-by: Coverity (CID: 313548)
> Reviewed-by: Tom Rini
Ping. Is there any
On 12/13/20 12:39 AM, Simon Glass wrote:
> On Mon, 7 Dec 2020 at 01:18, Jaehoon Chung wrote:
>>
>> Fix -Wint-to-pointer-cast warning
>>
>> common/splash_source.c: In function 'splash_load_raw':
>> common/splash_source.c:100:12: warning: cast to pointer f
501 - 600 of 2295 matches
Mail list logo
