Re: [PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

2020-02-20 Thread Jaehoon Chung
Hi Tom, On 2/21/20 4:57 AM, Tom Rini wrote: > On Thu, Feb 20, 2020 at 01:45:31PM +0900, Jaehoon Chung wrote: > >> CONFIG_MMC_BROKEN_CD needs not to define to Kconfig. >> broken-cd is already provide to dt-property. >> If want to poll card-detect, set to broke

[PATCH 2/3] mmc: check the flags of host_caps about broken-cd

2020-02-19 Thread Jaehoon Chung
broken-cd is provided to dt-property. Then it's set to MMC_CAP_NEEDS_POLL flag. Signed-off-by: Jaehoon Chung --- drivers/mmc/mmc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index b50fcbf6cf..cac60ea034 100644

[PATCH 1/3] mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default

2020-02-19 Thread Jaehoon Chung
Add MMC_CAP_NEEDS_POLL by default. Signed-off-by: Jaehoon Chung --- drivers/mmc/jz_mmc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/jz_mmc.c b/drivers/mmc/jz_mmc.c index 8d4f886cb4..df995bda2f 100644 --- a/drivers/mmc/jz_mmc.c +++ b/drivers/mmc

[PATCH 3/3] mmc: Kconfig: remove MMC_BROKEN_CD configuration

2020-02-19 Thread Jaehoon Chung
Remove MMC_BROKEN_CD configuration. It doesn't need to use configuration, instead use broken-cd property. Signed-off-by: Jaehoon Chung --- configs/brppt2_defconfig| 1 - configs/ci20_mmc_defconfig | 1 - configs/meerkat96_defconfig | 1 - drivers/mmc/Kconfig | 5 - 4

[PATCH 0/3] Remove CONFIG_MMC_BROKEN_CD

2020-02-19 Thread Jaehoon Chung
. Jaehoon Chung (3): mmc: jz_mmc; add MMC_CAP_NEEDS_POLL by default mmc: check the flags of host_caps about broken-cd mmc: Kconfig: remove MMC_BROKEN_CD configuration configs/brppt2_defconfig| 1 - configs/ci20_mmc_defconfig | 1 - configs/meerkat96_defconfig | 1 - drivers/mmc/Kconfig

Re: [PATCH v3 08/11] mmc: sdhci: remove unneeded casts

2020-02-18 Thread Jaehoon Chung
On 2/14/20 4:40 PM, Masahiro Yamada wrote: > host->mmc is already (struct mmc *). > > memalign() returns an opaque pointer, so there is no need for casting. > > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Chang

Re: [PATCH v3 09/11] mmc: add mmc_get_dma_dir() helper

2020-02-18 Thread Jaehoon Chung
On 2/14/20 4:40 PM, Masahiro Yamada wrote: > Copied from Linux kernel. > include/linux/mmc/host.h > > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v3: None > Changes in v2: None > > include/mmc.h |

Re: [PATCH v3 07/11] mmc: sdhci: use lower_32_bit2() and upper_32_bits() for setting adma_addr

2020-02-18 Thread Jaehoon Chung
On 2/14/20 4:40 PM, Masahiro Yamada wrote: > Use {lower,upper}_32_bits() instead of the combination of cast > and shift. > > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v3: None > Changes in v2: None &

Re: [PATCH v3 05/11] mmc: sdhci: put the aligned buffer pointer to struct sdhci_host

2020-02-18 Thread Jaehoon Chung
On 2/14/20 4:40 PM, Masahiro Yamada wrote: > Using the global variable does not look nice. > > Add a new field sthci::align_buffer to point to the bounce buffer. > > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- >

Re: [PATCH v3 06/11] mmc: sdhci: reduce code duplication for aligned buffer

2020-02-18 Thread Jaehoon Chung
On 2/14/20 4:40 PM, Masahiro Yamada wrote: > The same code is run for both SDHCI_QUIRK_32BIT_DMA_ADDR and > define(CONFIG_FIXED_SDHCI_ALIGNED_BUFFER). > > Unify the code. > > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- >

Re: RPI4: fail too boot with an initrd

2020-02-18 Thread Jaehoon Chung
device_type = "memory"; >>>>>> reg = <0 0 0>; >>>>>> }; >>>>>> >>>>>> In uboot I have: >>>>>> static struct mm_region bcm2711_mem_map[] = { >>>>>> {

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-18 Thread Jaehoon Chung
On 2/18/20 4:51 PM, Faiz Abbas wrote: > Jaehoon, > > On 18/02/20 4:54 am, Jaehoon Chung wrote: >> Hi Faiz, >> >> On 2/18/20 7:35 AM, Jaehoon Chung wrote: >>> Hi Faiz, >>> >>> On 2/17/20 9:42 PM, Faiz Abbas wrote: >>>> Jae

Re: [PATCH v3 0/3] Ethernet support for Raspberry Pi 4

2020-02-17 Thread Jaehoon Chung
Hi LABBE, On 2/17/20 8:37 PM, Jaehoon Chung wrote: > On 2/3/20 6:48 PM, LABBE Corentin wrote: >> On Wed, Jan 29, 2020 at 07:21:09AM +0900, Jaehoon Chung wrote: >>> On 1/27/20 9:06 PM, Andre Przywara wrote: >>>> On Mon, 27 Jan 2020 12:50:16 +0100 >>&g

[PATCH v2 1/3] mmc: sdhci: use phys2bus macro when dma address is accessed

2020-02-17 Thread Jaehoon Chung
Use phys2bus macro when dma address is accessed. Some targets need to use pyhs2bus macro. (e.g, RPI4) After applied it, SDMA mode can be used. Signed-off-by: Jaehoon Chung Reviewed-by: Peng Fan --- Changelog on V2 - None drivers/mmc/sdhci.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH v2 3/3] configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config

2020-02-17 Thread Jaehoon Chung
Enable SDHCI_SDMA configuration. Signed-off-by: Jaehoon Chung Reviewed-by: Peng Fan --- Changelog on V2 - None configs/rpi_4_32b_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index 72cda5d949..7189914606 100644 --- a

[PATCH v2 2/3] mmc: sdhci: not return error when SDMA is not supported

2020-02-17 Thread Jaehoon Chung
If Host controller doesn't support SDMA, it doesn't need to return error. Because it can be worked with PIO mode. Signed-off-by: Jaehoon Chung Reviewed-by: Peng Fan --- Changelog on V2 - Keep printf message instead of debug drivers/mmc/sdhci.c | 7 +++ 1 file changed, 3 insert

[PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit

2020-02-17 Thread Jaehoon Chung
;s patches. Changelog on V2 - Keep printf message instead of debug - Add Peng's Reviewed-by tag Jaehoon Chung (3): mmc: sdhci: use phys2bus macro when dma address is accessed mmc: sdhci: not return error when SDMA is not supported configs: rpi_4_32b_defconfig: enable SDHCI_SDMA c

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-17 Thread Jaehoon Chung
Hi Faiz, On 2/18/20 7:35 AM, Jaehoon Chung wrote: > Hi Faiz, > > On 2/17/20 9:42 PM, Faiz Abbas wrote: >> Jaehoon, >> >> On 17/02/20 5:47 pm, Jaehoon Chung wrote: >>> Hi, >>> >>> On 2/5/20 4:33 PM, Faiz Abbas wrote: >>>> Hi Peng,

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-17 Thread Jaehoon Chung
Hi Faiz, On 2/17/20 9:42 PM, Faiz Abbas wrote: > Jaehoon, > > On 17/02/20 5:47 pm, Jaehoon Chung wrote: >> Hi, >> >> On 2/5/20 4:33 PM, Faiz Abbas wrote: >>> Hi Peng, >>> >>> On 05/02/20 12:58 pm, Peng Fan wrote: >>>>> Subjec

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-17 Thread Jaehoon Chung
Hi, On 2/5/20 4:33 PM, Faiz Abbas wrote: > Hi Peng, > > On 05/02/20 12:58 pm, Peng Fan wrote: >>> Subject: Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static >>> >>> Hi, >>> >>> On 31/01/20 3:55 am, Simon Goldschmidt wr

Re: [PATCH v3 0/3] Ethernet support for Raspberry Pi 4

2020-02-17 Thread Jaehoon Chung
On 2/3/20 6:48 PM, LABBE Corentin wrote: > On Wed, Jan 29, 2020 at 07:21:09AM +0900, Jaehoon Chung wrote: >> On 1/27/20 9:06 PM, Andre Przywara wrote: >>> On Mon, 27 Jan 2020 12:50:16 +0100 >>> LABBE Corentin wrote: >>> >>> Hi, >>> >>&

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-01-30 Thread Jaehoon Chung
Hi Simon, On 1/29/20 11:16 PM, Simon Goldschmidt wrote: > On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung wrote: >> >> On 1/24/20 8:52 PM, Faiz Abbas wrote: >>> Expose sdhci_init() as non-static. >> >> Does it need to change to non-static? > > And even

Re: [PATCH 0/3] Support SDMA mode on RPI4 target - 32bit

2020-01-30 Thread Jaehoon Chung
On 1/30/20 8:27 PM, Matthias Brugger wrote: > > > On 30/01/2020 12:24, Matthias Brugger wrote: >> >> >> On 23/01/2020 00:15, Jaehoon Chung wrote: >>> RPI4's SDHCI controller is supported SDMA mode. (Checked on kernel side) >>> But It doesn&#

Re: [PATCH v2 08/10] arm: K3: sysfw-loader: Add a config_pm_pre_callback()

2020-01-28 Thread Jaehoon Chung
On 1/24/20 8:52 PM, Faiz Abbas wrote: > System firmware does not guarantee that clocks going out of the device > will be stable during power management configuration. There are some > DCRC errors when SPL tries to get the next stage during eMMC boot after > sysfw pm configuration. > > Therefore ad

Re: [PATCH v2 01/10] mmc: Add a saved_clock member

2020-01-28 Thread Jaehoon Chung
ed_clock in platdata? And i'm not sure but mmc->tran_speed should be kept previous speed. I will check it Best Regards, Jaehoon Chung > > Signed-off-by: Faiz Abbas > Signed-off-by: Lokesh Vutla > --- > include/mmc.h | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-01-28 Thread Jaehoon Chung
On 1/24/20 8:52 PM, Faiz Abbas wrote: > Expose sdhci_init() as non-static. Does it need to change to non-static? Best Regards, Jaehoon Chung > > Signed-off-by: Faiz Abbas > Signed-off-by: Lokesh Vutla > --- > drivers/mmc/sdhci.c | 2 +- > include/sdhci.h | 1 +

Re: mmc init fails after soft reset on T1042

2020-01-28 Thread Jaehoon Chung
ard header file, i > came to know that the eMMC fails to respond to CMD 2. It seems that you have set to wrong value for your eMMC. Could you share more information? Best Regards, Jaehoon Chung > > What can be the issue here? Can anyone guide me? > > Regards, > Amarnath MB > >

Re: [PATCH v3 0/3] Ethernet support for Raspberry Pi 4

2020-01-28 Thread Jaehoon Chung
=..." line in > config.txt)? > > I will try take a look at this later. I'm not sure, i had similar issue about failed to allocate memory cma. I had enabled CONFIG_ARCH_FIXUP_OF_MEMORY. And i changed the loading address (kernel/ramdisk/device-tree) in boot script for our environment. Because som

Re: [PATCH v4 6/6] config: enable DFU over USB on Raspberry Pi4 boards

2020-01-28 Thread Jaehoon Chung
while we have a third config rpi_arm64_defconfig > > does it make sense to add DFU support there too? > I suppose it works on RPi3 as well. If so, would you mind to send a follow-up > patch? As i know, RPI3's HW doesn't support. SO it doesn't need to apply this patch on

Re: [PATCH 0/3] Support SDMA mode on RPI4 target - 32bit

2020-01-27 Thread Jaehoon Chung
30: 1 But if you're ok about above, i will resend the patches with your reviewed-tag. And I will send patch about Host controller information. mmcinfo is displayed many informations. but it doesn't know which mode is using. e.g) SDMA, ADMA, PIO, DMA mode, etc. Those have dependent

Re: [PATCH] mmc: check the return value of mmc_select_mode_and_width()

2020-01-22 Thread Jaehoon Chung
switching to a boot partition") > Signed-off-by: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/mmc/mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c >

Re: [Patchv4 1/3] mmc: meson-gx: Fix clk phase tuning for MMC

2020-01-22 Thread Jaehoon Chung
meson_mmc_clk |= UPDATE(0, 13, 12); > +#ifdef CONFIG_MESON_GX > + /* TX clock delay line */ > + meson_mmc_clk |= GENMASK(19, 16); > + /* RX clock delay line */ > + meson_mmc_clk |= GENMASK(23, 20); > + /* clk always on */ > + meson_mmc_clk |= BIT(20);

[PATCH 1/3] mmc: sdhci: use phys2bus macro when dma address is accessed

2020-01-22 Thread Jaehoon Chung
Use phys2bus macro when dma address is accessed. Some targets need to use pyhs2bus macro. (e.g, RPI4) After applied it, SDMA mode can be used. Signed-off-by: Jaehoon Chung --- drivers/mmc/sdhci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/sdhci.c b

[PATCH 0/3] Support SDMA mode on RPI4 target - 32bit

2020-01-22 Thread Jaehoon Chung
B file Before - Read : 1.472 seconds - Write : 4.690 seconds After - Read : 0.359 seconds - Write : 0.574 seconds This patch is based on my RFC's patches. Jaehoon Chung (3): mmc: sdhci: use phys2bus macro when dma address is accessed mmc: sdhci: not return error when SDMA i

[PATCH 2/3] mmc: sdhci: not return error when SDMA is not supported

2020-01-22 Thread Jaehoon Chung
If Host controller doesn't support SDMA, it doesn't need to return error. Because it can be worked with PIO mode. Signed-off-by: Jaehoon Chung --- drivers/mmc/sdhci.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdh

[PATCH 3/3] configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config

2020-01-22 Thread Jaehoon Chung
Enable SDHCI_SDMA configuration. Signed-off-by: Jaehoon Chung --- configs/rpi_4_32b_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index 00f80f71ad..8fbadc0bc8 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs

Re: [RFC 0/4] Support SDMA mode on RPI4 target - 32bit

2020-01-20 Thread Jaehoon Chung
ck on u-boot side. I had checked RPI4 target. (1/2/4GB model) If other RPI models are using same SDHCI controller(assume that provides same functionality), it can be used SDMA mode. Best Regards, Jaehoon Chung > >> Read/write time about 8MB file >> Before >> - Read : 1.472 s

Re: [RFC 1/4] mmc: bcm2835_sdhci: use phys2bus macro when dma address is accessed

2020-01-20 Thread Jaehoon Chung
Hi Marek, On 1/20/20 7:37 PM, Marek Szyprowski wrote: > Hi Jaehoon, > > On 20.01.2020 11:20, Jaehoon Chung wrote: >> Use phys2bus macro when dma address is accessed. >> After applied it, SDMA mode can be used. >> >> When thor download is used, >> -

[RFC 3/4] mmc: bcm2835_sdhci: set SDHCI_QUIRK_BROKEN_SDMA flag

2020-01-20 Thread Jaehoon Chung
dhci_setup_cfg: Your controller doesn't support SDMA!! mmcnr@7e3 - probe failed: -22 Signed-off-by: Jaehoon Chung --- drivers/mmc/bcm2835_sdhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/bcm2835_sdhci.c b/drivers/mmc/bcm2835_sdhci.c index 222ba22d66

[RFC 1/4] mmc: bcm2835_sdhci: use phys2bus macro when dma address is accessed

2020-01-20 Thread Jaehoon Chung
Use phys2bus macro when dma address is accessed. After applied it, SDMA mode can be used. When thor download is used, - Before : 1.8MB/s - After : 7.23MB/s Signed-off-by: Jaehoon Chung --- drivers/mmc/bcm2835_sdhci.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a

[RFC 2/4] mmc: sdhci: add quriks relevant to broken SDMA

2020-01-20 Thread Jaehoon Chung
ADd quirks relevant to broken SDMA. If set to SDHCI_QUIRK_BROKEN_SDMA, it should be run the pio mode. Signed-off-by: Jaehoon Chung --- drivers/mmc/sdhci.c | 10 -- include/sdhci.h | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/sdhci.c b/drivers

[RFC 4/4] configs: rpi_4_32b_defconfig: enable SDHCI_SDMA config

2020-01-20 Thread Jaehoon Chung
Enable SDHCI_SDMA configuration. Signed-off-by: Jaehoon Chung --- configs/rpi_4_32b_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index 00f80f71ad..8fbadc0bc8 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs

[RFC 0/4] Support SDMA mode on RPI4 target - 32bit

2020-01-20 Thread Jaehoon Chung
B file Before - Read : 1.472 seconds - Write : 4.690 seconds After - Read : 0.359 seconds - Write : 0.574 seconds Jaehoon Chung (4): mmc: bcm2835_sdhci: use phys2bus macro when dma address is accessed mmc: sdhci: add quriks relevant to broken SDMA mmc: bcm2835_sdhci: set SDHCI_QUIRK_BROKEN

Re: u-boot 32-bit on Raspberry Pi 4

2020-01-17 Thread Jaehoon Chung
On 1/18/20 10:53 AM, Jaehoon Chung wrote: > Hi > > On 1/18/20 9:22 AM, Alexander von Gluck IV wrote: >> Has anyone successfully used u-boot on the Raspberry Pi 4 in 32-bit mode? > > I'm using 32-bit u-boot on RPI4 board with Tizen Platform. > You can refer to tize

Re: [PATCH 0/3] Fix Odroid U3/X2 SD-card boot

2020-01-17 Thread Jaehoon Chung
h/1223558/ > https://patchwork.ozlabs.org/patch/1224228/ Thanks for patches. I will check this patch-set. Best Regard, Jaehoon Chung > > Best regards > Marek Szyprowski > Samsung R&D Institute Poland > > > Patch summary: > > Marek Szyprowski (3): > mmc: s5p_

Re: u-boot 32-bit on Raspberry Pi 4

2020-01-17 Thread Jaehoon Chung
art.elf from > * config.txt on Fat32 partition >kernel=u-boot.bin >enable_uart=1 >arm_64bit=0 > Our config.txt is below, enable_uart=1 uart_2ndstage=1 I didn't add "arm_64bit" config. Best Regards, Jaehoon Chung > Just a black screen, however, no serial uart output > > Thanks! > > -- Alex > >

[PATCH] mmc: fix the build error when MMC_WRITE is disabled

2020-01-16 Thread Jaehoon Chung
erase_grp_size is used, when MMC_WRITE is enabled. - error: ‘struct mmc’ has no member named ‘erase_grp_size’ Signed-off-by: Jaehoon Chung --- drivers/mmc/mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index d43983d4a6..6a2b855435 100644 --- a

[U-Boot] [GIT PULL] Please pull u-boot-mmc master

2018-05-08 Thread Jaehoon Chung
live tree Jaehoon Chung (6): configs: trats2: enable the max77686 regulator config power: pmic_max77686: remove the old pmic_max77686 file lib: fdtdec: drop the old compatible about max77686 mmc: add the MMC_CLK_ENABLE/DISABLE macro in mmc.h mmc: add the debug message in

Re: [U-Boot] mainline u-boot on radxarock (rockchip rk3188) from SDcard

2018-05-03 Thread Jaehoon Chung
Dear Trevor, On 05/04/2018 12:13 AM, Trevor Woerner wrote: > Hi Jaehoon and Kever, > > On Wed, May 2, 2018 at 4:11 AM, Jaehoon Chung > wrote: > >> Hi, >> >> On 05/02/2018 04:10 PM, Kever Yang wrote: >>> Hi Trevor, >>> >>>

Re: [U-Boot] mainline u-boot on radxarock (rockchip rk3188) from SDcard

2018-05-02 Thread Jaehoon Chung
use mainline >> u-boot_2008.01 it doesn't seem to be able to find or boot from the SDcard: Do you use the dwmmc driver? or which driver are you using? And Could you share which defconfig is used? Plz, CC'd me. Best Regards, Jaehoon Chung >> >> U-Boot SPL 2018.

Re: [U-Boot] [UBOOT PATCH v3 0/7] Add support of SD3.0 UHS modes for ZynqMP

2018-05-01 Thread Jaehoon Chung
omething else. Can you > please recommend someone to take a look at these patches? Definitely > feel free to look at it self. Sorry. First, I checked the patches that delegate to me on patchwork. So I missed this patchset. I will check this on Today. Best Regards, Jaehoon Chung > > Thanks, > Michal > > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [GIT PULL] Please pull u-boot-mmc master

2018-05-01 Thread Jaehoon Chung
: remove redundant logical constraint Jaehoon Chung (1): samsung: board: init the s2mps11 pmic during booting time Peng Fan (1): mmc: fix return value check condition board/samsung/common/exynos5-dt.c | 4 drivers/mmc/mmc.c | 2 +- drivers/mmc/sdhci.c

Re: [U-Boot] [RESEND][PATCH v1 0/3] Add STM32MP157 regulator driver

2018-04-29 Thread Jaehoon Chung
Hi, On 04/27/2018 12:11 AM, Patrice CHOTARD wrote: > it misses one patch, sorry > i ressend it right now "[RESEND][PATCH v1 0/4] " are right? Best Regards, Jaehoon Chung > > Patrice > > On 04/26/2018 04:42 PM, Patrice Chotard wrote: >> >> Thi

Re: [U-Boot] dm: mmc: socfpga: call dwmci_probe()

2018-04-29 Thread Jaehoon Chung
On 04/27/2018 05:48 PM, Marek Vasut wrote: > On 04/27/2018 10:35 AM, Jaehoon Chung wrote: >> Dear Marek, >> >> On 04/26/2018 09:01 PM, Marek Vasut wrote: >>> On 04/26/2018 12:30 PM, Jaehoon Chung wrote: >>>> Hi, >>>> >>>> On 03

Re: [U-Boot] dm: mmc: socfpga: call dwmci_probe()

2018-04-27 Thread Jaehoon Chung
Dear Marek, On 04/26/2018 09:01 PM, Marek Vasut wrote: > On 04/26/2018 12:30 PM, Jaehoon Chung wrote: >> Hi, >> >> On 03/06/2018 05:07 PM, linux-kernel-...@beckhoff.com wrote: >>> From: Patrick Bruenn >>> >>> On a socfpga_cyclone5 based board

Re: [U-Boot] [PATCH v5 3/6] power: as3722: fix ldo_get/set_enable for ldo index bigger than 7

2018-04-26 Thread Jaehoon Chung
On 04/26/2018 08:04 PM, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Fix ldo_get_enable() and ldo_set_enable() functions for LDOs with an > index > 7. Turns out there are actually two separate AS3722_LDO_CONTROL > registers AS3722_LDO_CONTROL0 and AS3722_LDO_CONTROL1. Actually make use > of

Re: [U-Boot] [U-Boot, 1/1] drivers:power:max77693: remove redundant logical constraint

2018-04-26 Thread Jaehoon Chung
On 03/18/2018 07:52 PM, Heinrich Schuchardt wrote: > As ret is not set when calling max77693_get_vcell() there is no > need to check ret again. > > Signed-off-by: Heinrich Schuchardt Sorry for late. Applied to u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > --- >

Re: [U-Boot] [U-Boot, BUG] snow: mmc: SD card access broken: unable to select a mode

2018-04-26 Thread Jaehoon Chung
l access to SD card result in failure, even > when trying to setup a lower frequency mode, including SD legacy at 25 MHz. > > Any idea what is going? Maybe you have fixes pending? Sorry for late. Hmm. I will check your issue. Just disable MMC_MODE_HS, then it's working fine? or

Re: [U-Boot] mmc: fix check of returned value of sd_read_ssr function

2018-04-26 Thread Jaehoon Chung
Hi, On 04/09/2018 06:36 PM, Guillaume GARDET wrote: > sd_read_ssr returns 0 if it succeed. > > Signed-off-by: Guillaume GARDET > Cc: Jaehoon Chung Sorry for late. it's already sent the patch from Peng. It's applied to u-boot-mmc. Thanks for reporting. Best

Re: [U-Boot] [U-Boot,v2] power: pwm regulator: support live tree

2018-04-26 Thread Jaehoon Chung
Hi, On 03/27/2018 08:39 PM, Andy Yan wrote: > Use live tree compatible api for pwm regulator. > > Signed-off-by: Andy Yan > Reviewed-by: Kever Yang Sorry for late. Applied to u-boot-mmc for pmic. Thanks! Best Regards, Jaehoon Chung > --- > > Changes in v2: > -

Re: [U-Boot] mmc: fix check of returned value of sd_read_ssr function

2018-04-26 Thread Jaehoon Chung
On 04/09/2018 06:36 PM, Guillaume GARDET wrote: > sd_read_ssr returns 0 if it succeed. > > Signed-off-by: Guillaume GARDET > Cc: Jaehoon Chung Applied to u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > --- > drivers/mmc/mmc.c | 2 +- > 1 file changed, 1 ins

Re: [U-Boot] [U-Boot,2/2] mmc: fsl_esdhc: enable HS400 feature

2018-04-26 Thread Jaehoon Chung
ay time is larger than one clock cycle, > then CLK and data_strobe line will be misaligned, read error shows up. > So when the CLK is higher than 100MHz, each clock cycle is short enough, > host should configure the delay target. " Sorry for late. > > Signed-off-by

Re: [U-Boot] dm: mmc: socfpga: call dwmci_probe()

2018-04-26 Thread Jaehoon Chung
is missing for socfpga_dw_mmc. > > With this change DWMCI_PWREN is set by dmwci_init(). Sorry for late. Applied to u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > > Signed-off-by: Patrick Bruenn > Reviewed-by: Jaehoon Chung > --- > > drivers/mmc/socfpga_dw_mmc.c | 2

Re: [U-Boot] [U-Boot,1/2] mmc: add HS400 support

2018-04-26 Thread Jaehoon Chung
ing all the 8 bits. Sorry for late. > > Signed-off-by: Peng Fan > Cc: Jaehoon Chung > Cc: Jean-Jacques Hiblot > Cc: Stefano Babic > Cc: Simon Glass > Cc: Kishon Vijay Abraham I > Cc: Bin Meng > --- > drivers/mm

Re: [U-Boot] mmc: fix return value check condition

2018-04-26 Thread Jaehoon Chung
Hi, On 03/05/2018 05:20 PM, Peng Fan wrote: > sd_read_ssr returns 0, means no error. > Fixes: 5b2e72f32721484("mmc: read ssr only if MMC write support is enabled") Sorry for late. Applied to u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > > Signed-off-by: Peng Fan >

[U-Boot] [PATCH] mmc: uniphier-sd: fix the implicit-function declaration error

2018-04-04 Thread Jaehoon Chung
Fix the implicit-function declaration error. Signed-off-by: Jaehoon Chung --- drivers/mmc/uniphier-sd-rcar.c | 2 +- drivers/mmc/uniphier-sd.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/uniphier-sd-rcar.c b/drivers/mmc/uniphier-sd-rcar.c index

Re: [U-Boot] [PATCH] dm: mmc: socfpga: call dwmci_probe()

2018-03-12 Thread Jaehoon Chung
On 03/10/2018 03:13 AM, Marek Vasut wrote: > On 03/09/2018 09:24 AM, Jaehoon Chung wrote: >> Dear Patrick, >> >> On 03/09/2018 03:51 PM, Patrick Brünn wrote: >>>> From: Patrick Brünn >>>> Sent: Donnerstag, 8. März 2018 06:39 >>>>> Fr

Re: [U-Boot] [PATCH] dm: mmc: socfpga: call dwmci_probe()

2018-03-09 Thread Jaehoon Chung
Dear Patrick, On 03/09/2018 03:51 PM, Patrick Brünn wrote: >> From: Patrick Brünn >> Sent: Donnerstag, 8. März 2018 06:39 >>> From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] >>> Sent: Donnerstag, 8. März 2018 04:57 >>> On 03/08/2018 12:12 PM, Marek V

Re: [U-Boot] [PATCH] dm: mmc: socfpga: call dwmci_probe()

2018-03-07 Thread Jaehoon Chung
On 03/08/2018 12:12 PM, Marek Vasut wrote: > On 03/08/2018 03:17 AM, Jaehoon Chung wrote: >> On 03/06/2018 05:07 PM, linux-kernel-...@beckhoff.com wrote: >>> From: Patrick Bruenn >>> >>> On a socfpga_cyclone5 based board the SD card, was never powered

Re: [U-Boot] [PATCH] dm: mmc: socfpga: call dwmci_probe()

2018-03-07 Thread Jaehoon Chung
socfpga_dw_mmc. > > With this change DWMCI_PWREN is set by dmwci_init(). > > Signed-off-by: Patrick Bruenn Reviewed-by: Jaehoon Chung Will apply this patch before releasing v2018.03. (I have a problem about accessing git.denx.de. After fixing my problem, will resend email abou

Re: [U-Boot] [PATCH] mmc: fix return value check condition

2018-03-07 Thread Jaehoon Chung
Hi Peng, On 03/05/2018 05:20 PM, Peng Fan wrote: > sd_read_ssr returns 0, means no error. > Fixes: 5b2e72f32721484("mmc: read ssr only if MMC write support is enabled") > > Signed-off-by: Peng Fan > Cc: Jaehoon Chung > Cc: Jean-Jacques Hiblot Will apply your p

Re: [U-Boot] [UBOOT PATCH v2 2/2] arm64: zynqmp: mmc: Added Kconfig support for CONFIG_ZYNQ_SDHCI1

2018-03-05 Thread Jaehoon Chung
On 03/02/2018 06:18 PM, Michal Simek wrote: > On 2.3.2018 10:01, Jaehoon Chung wrote: >> On 03/02/2018 04:44 PM, Michal Simek wrote: >>> On 2.3.2018 07:27, Jaehoon Chung wrote: >>>> On 03/02/2018 12:13 AM, Michal Simek wrote: >>>>> On 28

Re: [U-Boot] [PATCH v2 1/2] mmc: sdhci: add SDHCI_QUIRK_BROKEN_HISPD_MODE

2018-03-05 Thread Jaehoon Chung
On 03/05/2018 06:22 PM, Hannes Schmelzer wrote: > Jaehoon Chung schrieb am 05.03.2018 10:19:24: > >> >> On 03/02/2018 07:00 PM, Hannes Schmelzer wrote: >>> From: Hannes Schmelzer >>> >>> Some IP-core implementations of the SDHCI have different

Re: [U-Boot] [PATCH v2 1/2] mmc: sdhci: add SDHCI_QUIRK_BROKEN_HISPD_MODE

2018-03-05 Thread Jaehoon Chung
On 03/02/2018 07:00 PM, Hannes Schmelzer wrote: > From: Hannes Schmelzer > > Some IP-core implementations of the SDHCI have different troubles on the > silicon where they are placed. > > On ZYNQ platform for example Xilinx doesn't accept the hold timing of an > eMMC chip which operates in High-S

Re: [U-Boot] [UBOOT PATCH v2 2/2] arm64: zynqmp: mmc: Added Kconfig support for CONFIG_ZYNQ_SDHCI1

2018-03-02 Thread Jaehoon Chung
On 03/02/2018 04:44 PM, Michal Simek wrote: > On 2.3.2018 07:27, Jaehoon Chung wrote: >> On 03/02/2018 12:13 AM, Michal Simek wrote: >>> On 28.2.2018 08:42, Jaehoon Chung wrote: >>>> Hi, >>>> >>>> On 02/28/2018 03:28 PM, Vipul K

Re: [U-Boot] [PATCH 04/13] mmc: uniphier-sd: Add R8A77965 M3N entries

2018-03-02 Thread Jaehoon Chung
On 03/02/2018 06:14 AM, Marek Vasut wrote: > Add entries for the R8A77965 M3N SoC. > > Signed-off-by: Marek Vasut > Cc: Nobuhiro Iwamatsu > Cc: Jaehoon Chung > Cc: Masahiro Yamada Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/uniph

Re: [U-Boot] [PATCH] mmc: sdhci: consider SDHCI_QUIRK_NO_HISPD_BIT in host_caps

2018-03-01 Thread Jaehoon Chung
se is used. Best Regards, Jaehoon Chung > please have a > look to: > > https://github.com/u-boot/u-boot/blob/master/drivers/mmc/mmc.c > > static int mmc_select_mode_and_width(struct mmc *mmc, uint card_caps) > { > .... > } > > Here is the

Re: [U-Boot] [UBOOT PATCH v2 2/2] arm64: zynqmp: mmc: Added Kconfig support for CONFIG_ZYNQ_SDHCI1

2018-03-01 Thread Jaehoon Chung
On 03/02/2018 12:13 AM, Michal Simek wrote: > On 28.2.2018 08:42, Jaehoon Chung wrote: >> Hi, >> >> On 02/28/2018 03:28 PM, Vipul Kumar wrote: >>> This patch added Kconfig support for CONFIG_ZYNQ_SDHCI1 and >>> enabled it in defconfig. >> >>

Re: [U-Boot] [PATCH] mmc: sdhci: consider SDHCI_QUIRK_NO_HISPD_BIT in host_caps

2018-03-01 Thread Jaehoon Chung
t at HOST_CNOTROL register. Instead, its bit is used to other purpose. NACK. Best Regards, Jaehoon Chung > > --- > > drivers/mmc/sdhci.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index d31793a..defe6db 100

Re: [U-Boot] [UBOOT PATCH v2 2/2] arm64: zynqmp: mmc: Added Kconfig support for CONFIG_ZYNQ_SDHCI1

2018-02-27 Thread Jaehoon Chung
#if defined(CONFIG_ZYNQ_SDHCI0) && defined(CONFIG_ZYNQ_SDHCI1) #endif If CONFIG_ZYNQ_SDHCI0 isn't enabled, doesn't it need to set CONFIG_ZYNQ_SDHCI1 in defconfigs. If i missed something, let me know, plz. Best Regards, Jaehoon Chung > > Signed-off-by: Vipul Kumar > Sig

[U-Boot] [GIT PULL ] Please pull u-boot-mmc master

2018-02-25 Thread Jaehoon Chung
Abbas (1): mmc: Drop unnecessary case for mmc_probe() Jaehoon Chung (1): mmc: synchronize the sequence with enum bus_mode in mmc.h Jean-Jacques Hiblot (4): mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat mmc: omap_hsmmc: compile out write support if not

Re: [U-Boot] [PATCH v2 4/4] mmc: omap_hsmmc: use a default 52MHz max clock rate if none is specified

2018-02-25 Thread Jaehoon Chung
lex Kiernan >> Signed-off-by: Jean-Jacques Hiblot >> > > Reviewed-by: Tom Rini Applied to u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/4] mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat

2018-02-25 Thread Jaehoon Chung
vel code declares one or two struct omap_hsmmc_plat because it doesn't >> use the Driver Model. >> >> This saves around 740 bytes for the am335x_evm SPL. >> >> Signed-off-by: Jean-Jacques Hiblot > > Reviewed-by: Tom R

Re: [U-Boot] [PATCH v2 3/4] mmc: omap_hsmmc: make it possible to compile out ADMA support

2018-02-25 Thread Jaehoon Chung
HS MMC" >>>> + depends on MMC_OMAP_HS && !OMAP34XX >>>> + default y if !AM33XX >>> Is this logic really the right restrictions? Does it work on some >>> AM33XX platforms (AM43xx?) and just never OMAP34XX? Thanks! >> Starting with platfo

Re: [U-Boot] [PATCH v2 2/4] mmc: omap_hsmmc: compile out write support if not needed

2018-02-25 Thread Jaehoon Chung
On 02/23/2018 09:21 PM, Tom Rini wrote: > On Fri, Feb 23, 2018 at 10:40:17AM +0100, Jean-Jacques Hiblot wrote: > >> This reduces the size of the binary by about 196 bytes. >> >> Signed-off-by: Jean-Jacques Hiblot > > Reviewed-by: Tom Rini Applied to u-boot-mmc.

Re: [U-Boot] [UBOOT PATCH 2/2] mmc: Added Kconfig support for CONFIG_ZYNQ_SDHCI_MIN_FREQ

2018-02-23 Thread Jaehoon Chung
t seems that 101562 is the shifted value. If ZYNQ_SDHCI_MIN_REQ is set to 100KHz, what happen? Best Regards, Jaehoon Chung > CONFIG_NAND=y > CONFIG_NAND_ARASAN=y > CONFIG_SPI_FLASH=y > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > index 42b7d21..4f2993c 100644 >

Re: [U-Boot] [PATCH v2 0/4] mmc: omap_hsmmc: Reduce the footprint of the driver and fix am335x clock

2018-02-23 Thread Jaehoon Chung
smmc: use mmc_of_parse to > populate mmc_config") which made my DM3730 unable to probe the MMC. > > Tested-by: Adam Ford #omap3_logic After testing, I will apply these patches with your tag. Best Regards, Jaehoon Chung > > >> Changes in v2: >> - Use a Kconfig o

[U-Boot] [PATCH v2] mmc: uniphier-sd: Fix a compile error relevant to unused-function

2018-02-23 Thread Jaehoon Chung
During disabled MMC_HS200_SUPPORT, some functions don't use anywhere. Signed-off-by: Jaehoon Chung --- Chnagelog on V2 - Remove functions in uniphier-sd.h drivers/mmc/uniphier-sd-rcar.c | 4 drivers/mmc/uniphier-sd.h | 9 - 2 files changed, 4 insertions(+), 9 dele

Re: [U-Boot] Support of kernels > 16 MiB on Raspberry Pi

2018-02-22 Thread Jaehoon Chung
Especially, this is occurred about arm64 kernel. Because it wil be overlapped with other image address, if kernel image is over than 16MB. In my case, i'm using the private boot.scr.img for booting script. I had just added the kernel_addr_r=0x02d00. Just Refer to below: https://review.tizen.

Re: [U-Boot] [PATCH] mmc: uniphier-sd: Fix a compile error relevant to unused-function

2018-02-22 Thread Jaehoon Chung
Hi, On 02/23/2018 04:21 PM, Jaehoon Chung wrote: > During disabled MMC_HS200_SUPPORT, it doesn't use anywhere. This patch is based on u-boot-mmc/next branch. Best Regards, Jaehoon Chung > > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/uniphier-sd-rcar.c | 4

[U-Boot] [PATCH] mmc: uniphier-sd: Fix a compile error relevant to unused-function

2018-02-22 Thread Jaehoon Chung
During disabled MMC_HS200_SUPPORT, it doesn't use anywhere. Signed-off-by: Jaehoon Chung --- drivers/mmc/uniphier-sd-rcar.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mmc/uniphier-sd-rcar.c b/drivers/mmc/uniphier-sd-rcar.c index 8baa2a9b46..894decd04d 100644 --- a/dr

Re: [U-Boot] [PATCH v1 3/4] mmc: omap_hsmmc: compile out ADMA support for am33xx and omap34xx

2018-02-22 Thread Jaehoon Chung
;> @@ -93,7 +97,7 @@ struct omap_hsmmc_data { >> enum bus_mode mode; >> #endif >> u8 controller_flags; >> -#ifndef CONFIG_OMAP34XX >> +#ifdef ADMA_SUPPORT > > How about we add CONFIG_MMC_OMAP_HS_ADMA, and select it on !AM33XX && > !OM

Re: [U-Boot] [PATCH v3 09/24] mmc: omap_hsmmc: use mmc_of_parse to populate mmc_config

2018-02-22 Thread Jaehoon Chung
> >> Logic DM37x/OMAP35x reference board + LPDDR/NAND >> >> DRAM: 256 MiB >> >> NAND: 512 MiB >> >> MMC: mmc@4809c000 - probe failed: -1 >> >> OMAP Logic # mmc info >> >> No MMC device available >> >> OMAP Logic

Re: [U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

2018-02-22 Thread Jaehoon Chung
On 02/21/2018 05:57 PM, Jaehoon Chung wrote: > Hi Alexander, > > On 02/21/2018 05:44 PM, Alexander Kochetkov wrote: >> >>> Do you mean SD-card or MMC-card? :) >>> SD doesn't have EXT_CSD register. >> >> I see now. MMC-card. So, send v2? or you can

Re: [U-Boot] [PATCH] mmc: Drop unnecessary case for mmc_probe()

2018-02-22 Thread Jaehoon Chung
On 02/19/2018 02:31 PM, Faiz Abbas wrote: > Hi, > > On Monday 12 February 2018 07:35 PM, Faiz Abbas wrote: >> Drop the unnecessary empty function case for mmc_probe(). >> >> Signed-off-by: Faiz Abbas Applied to u-boot-mmc. Best Regards, Jaehoon Chung >&

Re: [U-Boot] [PATCH] mmc: synchronize the sequence with enum bus_mode in mmc.h

2018-02-22 Thread Jaehoon Chung
On 01/30/2018 02:10 PM, Jaehoon Chung wrote: > If some configs are disabled, number of freqs array will not assigned to > correct value with bus_mode. > Synchornize the ordering with enum bus_mode in mmc.h. > > Signed-off-by: Jaehoon Chung Applied to u-boot-mmc. Best Regards

Re: [U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

2018-02-21 Thread Jaehoon Chung
ly yours after changing commit-msg. Best Regards, Jaehoon Chung > >> >> - Removed Pantelis's mail account. Instead, add my account, plz. > > I took it from here: > https://www.denx.de/wiki/U-Boot/Custodians > > Regards, > Alexander. > > >

Re: [U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

2018-02-21 Thread Jaehoon Chung
Hi, On 02/21/2018 05:03 PM, Alexander Kochetkov wrote: > >> 21 февр. 2018 г., в 9:37, Jaehoon Chung написал(а): >> >> I'm confusing about commit-msg. "SD-card with EXT_CSD_REV"? >> >> Best Regards, >> Jaehoon Chung > > I glad to

Re: [U-Boot] [PATCH] mmc: fix off-by-one bug in mmc_startup_v4()

2018-02-20 Thread Jaehoon Chung
On 02/20/2018 08:35 PM, Alexander Kochetkov wrote: > SD-card with EXT_CSD_REV value 9 will trigger off-by-one > bug while accessing mmc_versions array. The patch fix that. I'm confusing about commit-msg. "SD-card with EXT_CSD_REV"? Best Regards, Jaehoon Chung > &g

Re: [U-Boot] [PATCH] mmc: fix eMMC v5.1 incorrect version detection

2018-02-20 Thread Jaehoon Chung
sion. So EXT_CSD_REV > value 4 assigned undefined version. > > Also the patch fix mmc_versions array bounds check. Value 8 > produced out of array access. It was already fixed. http://git.denx.de/?p=u-boot/u-boot-mmc.git;a=commit;h=ace1bed327411cf3cade45599864df2d461045a0 Best Regards, J

<    5   6   7   8   9   10   11   12   13   14   >