[PATCH v2 5/5] arm: apple: Do not list bootflows on boot

2024-04-18 Thread Janne Grunau via B4 Relay
From: Janne Grunau The bootflow list is only seen briefly and is probably more confusing than helpful. Signed-off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index c30aec7c55

[PATCH v2 1/5] apple_m1_defconfig: Turn on CONFIG_SYS_64BIT_LBA

2024-04-18 Thread Janne Grunau via B4 Relay
ark Kettenis Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index e00d72e8be..31d966f0ab 100644 --- a/configs/apple_m1_defconfig +++ b/conf

[PATCH v2 3/5] configs: apple: Enable CMD_SELECT_FONT and FONT_16X32

2024-04-18 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple devices have high DPI displays so the larger fonts are preferable for improved readability. This does not yet change the used font based on the display's pixel density so the standard 8x16 font is still used by default. Reviewed-by: Mark Kettenis Reviewed-by: Neal

[PATCH v2 0/5] configs: apple: Switch to standard boot + small adjustments

2024-04-18 Thread Janne Grunau via B4 Relay
addressing Signed-off-by: Janne Grunau --- Changes in v2: - added Reviewed-by: tags - switched to BOOTSTD_FULL to enable efi_bootmgr and make interactive use easier - override BOOTCOMMAND to not list the bootflows - rebased onto v2024.04 - Link to v1: https://lore.kernel.org/r/20240317

[PATCH v2 2/5] configs: apple: Use "vidconsole,serial" as stdout/stderr

2024-04-18 Thread Janne Grunau via B4 Relay
From: Janne Grunau The display size querying in efi_console relies on this order. The display should be the primary output device and should be used to display more than 80x25 chars. Reviewed-by: Mark Kettenis Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- include/configs/apple.h

[PATCH v2 4/5] arm: apple: Switch to standard boot

2024-04-18 Thread Janne Grunau via B4 Relay
From: Janne Grunau Use standard boot instead of the distro boot scripts. Use BOOTSTD_FULL instead of BOOTSTD_DEFAULTS for easier interactive use. Signed-off-by: Janne Grunau --- arch/arm/Kconfig| 2 +- include/configs/apple.h | 20 ++-- 2 files changed, 3 insertions

Re: [PATCH 4/4] arm: apple: Switch to standard boot

2024-04-16 Thread Janne Grunau
On Mon, Apr 15, 2024 at 04:24:51PM +0200, Mark Kettenis wrote: > > From: Janne Grunau via B4 Relay > > Date: Sun, 17 Mar 2024 15:54:50 +0100 > > > > From: Janne Grunau > > > > Use standard boot instead of the distro boot scripts. > > > > Sig

Re: [PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

2024-04-08 Thread Janne Grunau
On Sun, Apr 07, 2024 at 03:05:59AM +0200, Marek Vasut wrote: > On 4/6/24 10:04 PM, Janne Grunau wrote: > > On Sat, Apr 06, 2024 at 08:52:17PM +0200, Marek Vasut wrote: > >> On 4/5/24 9:05 PM, Janne Grunau wrote: > >>> On Fri, Apr 05, 2024 at 04:52:32PM +0200, Marek V

Re: [PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

2024-04-06 Thread Janne Grunau
On Sat, Apr 06, 2024 at 08:52:17PM +0200, Marek Vasut wrote: > On 4/5/24 9:05 PM, Janne Grunau wrote: > > On Fri, Apr 05, 2024 at 04:52:32PM +0200, Marek Vasut wrote: > >> On 4/4/24 8:25 AM, Janne Grunau via B4 Relay wrote: > >>> Apple USB Keyboards from 2021 need

Re: [PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

2024-04-05 Thread Janne Grunau
On Fri, Apr 05, 2024 at 04:52:32PM +0200, Marek Vasut wrote: > On 4/4/24 8:25 AM, Janne Grunau via B4 Relay wrote: > > Apple USB Keyboards from 2021 need quirks to be useable. The boot HID > > keyboard protocol is unfortunately not described in the first interface > > desc

[PATCH v4 1/6] usb: xhci: refactor xhci_set_configuration

2024-04-04 Thread Janne Grunau via B4 Relay
From: Janne Grunau In the next step endpoints for multiple interfaces are set up. Move most of the per endpoint initialization to separate function to avoid another identation level. Reviewed-by: Marek Vasut Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- drivers/usb/host/xhci.c

[PATCH v4 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-04-04 Thread Janne Grunau via B4 Relay
From: Janne Grunau The xhci driver currently only does the necessary initialization for endpoints found in the first interface descriptor. Apple USB keyboards (released 2021) use the second interface descriptor for the HID keyboard boot protocol. To allow USB drivers to use endpoints from other

[PATCH v4 4/6] usb: Add environment based device ignorelist

2024-04-04 Thread Janne Grunau via B4 Relay
From: Janne Grunau Add the environment variable "usb_ignorelist" to prevent USB devices listed in it from being bound to drivers. This allows to ignore devices which are undesirable or trigger bugs in u-boot's USB stack. Devices emulating keyboards are one example of undesirable de

[PATCH v4 0/6] USB keyboard improvements for asahi / desktop systems

2024-04-04 Thread Janne Grunau via B4 Relay
e Yubikeys emulate a keyboard. since u-boot only binds a single keyboard block this kind of devices from the USB keyboard driver. Signed-off-by: Janne Grunau --- Changes in v4: - collects "Reviewed-by:" tagDITME: describe what is new in this series revision. - adds comment about usb_ign

[PATCH v4 5/6] usb: kbd: support Apple Magic Keyboards (2021)

2024-04-04 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple USB keyboards (Magic Keyboard from 2021 (product id 0x029c)) carry the HID keyboard boot protocol on the second interface descriptor. Probe via vendor and product IDs since the class/subclass/protocol match uses the first interface descriptor. Probe the two first

[PATCH v4 3/6] usb: xhci: Abort transfers with unallocated rings

2024-04-04 Thread Janne Grunau via B4 Relay
From: Janne Grunau Discovered while trying to use the second interface in the USB keyboard driver necessary on Apple USB keyboards. Reviewed-by: Marek Vasut Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- drivers/usb/host/xhci-ring.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v4 6/6] usb: kbd: Add probe quirk for Apple and Keychron keyboards

2024-04-04 Thread Janne Grunau via B4 Relay
From: Janne Grunau Those keyboards do not return the current device state. Polling will timeout unless there are key presses. This is not a problem during operation but the initial device state query during probing will fail. Skip this step in usb_kbd_probe_dev() to make these devices useable

Re: [PATCH v3 4/6] usb: Add environment based device ignorelist

2024-03-26 Thread Janne Grunau
On Fri, Mar 22, 2024 at 12:56:37PM +0100, Marek Vasut wrote: > On 3/22/24 8:47 AM, Janne Grunau via B4 Relay wrote: > > [...] > > > @@ -1099,6 +1142,20 @@ int usb_select_config(struct usb_device *dev) > > le16_to_cpus(>descriptor.idProduct); > > l

Re: [PATCH v3 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-03-26 Thread Janne Grunau
On Fri, Mar 22, 2024 at 09:17:08AM +0100, Heinrich Schuchardt wrote: > On 3/22/24 08:47, Janne Grunau via B4 Relay wrote: > > From: Janne Grunau > > > > The xhci driver currently only does the necessary initialization for > > endpoints found in the first interface desc

[PATCH v3 0/6] USB keyboard improvements for asahi / desktop systems

2024-03-22 Thread Janne Grunau via B4 Relay
e Yubikeys emulate a keyboard. since u-boot only binds a single keyboard block this kind of devices from the USB keyboard driver. Signed-off-by: Janne Grunau --- Changes in v3: - collected "Reviewed-by:" tags - rename usb_blocklist to usb_ignorelist - use BIT macro for USB KBD

[PATCH v3 1/6] usb: xhci: refactor xhci_set_configuration

2024-03-22 Thread Janne Grunau via B4 Relay
From: Janne Grunau In the next step endpoints for multiple interfaces are set up. Move most of the per endpoint initialization to separate function to avoid another identation level. Reviewed-by: Marek Vasut Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- drivers/usb/host/xhci.c

[PATCH v3 5/6] usb: kbd: support Apple Magic Keyboards (2021)

2024-03-22 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple USB keyboards (Magic Keyboard from 2021 (product id 0x029c)) carry the HID keyboard boot protocol on the second interface descriptor. Probe via vendor and product IDs since the class/subclass/protocol match uses the first interface descriptor. Probe the two first

[PATCH v3 4/6] usb: Add environment based device ignorelist

2024-03-22 Thread Janne Grunau via B4 Relay
From: Janne Grunau Add the environment variable "usb_ignorelist" to prevent USB devices listed in it from being bound to drivers. This allows to ignore devices which are undesirable or trigger bugs in u-boot's USB stack. Devices emulating keyboards are one example of undesirable de

[PATCH v3 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-03-22 Thread Janne Grunau via B4 Relay
From: Janne Grunau The xhci driver currently only does the necessary initialization for endpoints found in the first interface descriptor. Apple USB keyboards (released 2021) use the second interface descriptor for the HID keyboard boot protocol. To allow USB drivers to use endpoints from other

[PATCH v3 6/6] usb: kbd: Add probe quirk for Apple and Keychron keyboards

2024-03-22 Thread Janne Grunau via B4 Relay
From: Janne Grunau Those keyboards do not return the current device state. Polling will timeout unless there are key presses. This is not a problem during operation but the initial device state query during probing will fail. Skip this step in usb_kbd_probe_dev() to make these devices useable

[PATCH v3 3/6] usb: xhci: Abort transfers with unallocated rings

2024-03-22 Thread Janne Grunau via B4 Relay
From: Janne Grunau Discovered while trying to use the second interface in the USB keyboard driver necessary on Apple USB keyboards. Reviewed-by: Marek Vasut Reviewed-by: Neal Gompa Signed-off-by: Janne Grunau --- drivers/usb/host/xhci-ring.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [PATCH v3 4/7] efi_selftest: Add international characters test

2024-03-19 Thread Janne Grunau
On Sun, Mar 17, 2024 at 10:24:13AM +0100, Heinrich Schuchardt wrote: > On 3/16/24 22:50, Janne Grunau via B4 Relay wrote: > > From: Andre Przywara > > > > UEFI relies entirely on unicode output, which actual fonts displayed on > > the screen might not be ready for. &g

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-19 Thread Janne Grunau
On Mon, Mar 18, 2024 at 03:17:33PM +0100, Marek Vasut wrote: > On 3/18/24 8:33 AM, Janne Grunau wrote: > > >>>>> +static int usb_blocklist_parse_error(const char *blocklist, size_t pos) > >>>>> +{ > >>>>> + pri

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-18 Thread Janne Grunau
Hej, On Sun, Mar 17, 2024, at 22:39, E Shattow wrote: > Should be usb_denylist, since "block devices" is ambiguous meaning if > it is a list of data chunks (blocks) or if it blocks (deny). There is > no question what a denylist is. I briefly thought of that concluded that the spelling

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-18 Thread Janne Grunau
On Mon, Mar 18, 2024, at 06:06, Marek Vasut wrote: > On 3/17/24 7:15 PM, Janne Grunau wrote: >> Hej, > > Hi, > >> On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: >>> On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: >>>> From: Janne G

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Janne Grunau
Hej, On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: > On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Add the environment variable "usb_blocklist" to prevent USB devices >> listed in it from being used. This allows to

[PATCH 1/4] apple_m1_defconfig: Turn on CONFIG_SYS_64BIT_LBA

2024-03-17 Thread Janne Grunau via B4 Relay
off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index e00d72e8be..31d966f0ab 100644 --- a/configs/apple_m1_defconfig +++ b/configs/apple_m1_defconfig @@ -10,6 +10,7 @@ CONFIG_SYS_PBSIZE=

[PATCH 3/4] configs: apple: Enable CMD_SELECT_FONT and FONT_16X32

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple devices have high DPI displays so the larger fonts are preferable for improved readability. This does not yet change the used font based on the display's pixel density so the standard 8x16 font is still used by default. Signed-off-by: Janne Grunau --- configs

[PATCH 2/4] configs: apple: Use "vidconsole,serial" as stdout/stderr

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau The display size querying in efi_console relies on this order. The display should be the primary output device and should be used to display more than 80x25 chars. Signed-off-by: Janne Grunau --- include/configs/apple.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 4/4] arm: apple: Switch to standard boot

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Use standard boot instead of the distro boot scripts. Signed-off-by: Janne Grunau --- arch/arm/Kconfig| 2 +- include/configs/apple.h | 20 ++-- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig

[PATCH 0/4] configs: apple: Switch to standard boot + small adjustments

2024-03-17 Thread Janne Grunau via B4 Relay
addressing for USB storage devices larger than 2TB Signed-off-by: Janne Grunau --- Hector Martin (1): apple_m1_defconfig: Turn on CONFIG_SYS_64BIT_LBA Janne Grunau (3): configs: apple: Use "vidconsole,serial" as stdout/stderr configs: apple: Enable CMD_S

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Janne Grunau
Hej, On Sun, Mar 17, 2024, at 12:07, Janne Grunau via B4 Relay wrote: > From: Janne Grunau > > Add the environment variable "usb_blocklist" to prevent USB devices > listed in it from being used. This allows to ignore devices which > trigger bugs in u-boot's USB stack or

[PATCH v2 0/6] USB keyboard improvements for asahi / desktop systems

2024-03-17 Thread Janne Grunau via B4 Relay
e Yubikeys emulate a keyboard. since u-boot only binds a single keyboard block this kind of devices from the USB keyboard driver. Signed-off-by: Janne Grunau --- Changes in v2: - rewritten commit message for "[PATCH 2/6] usb: xhci: Set up endpoints for the first 2 interfaces" - Replaced the

[PATCH v2 5/6] usb: kbd: support Apple Magic Keyboards (2021)

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple USB keyboards (Magic Keyboard from 2021 (product id 0x029c)) carry the HID keyboard boot protocol on the second interface descriptor. Probe via vendor and product IDs since the class/subclass/protocol match uses the first interface descriptor. Probe the two first

[PATCH v2 1/6] usb: xhci: refactor xhci_set_configuration

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau In the next step endpoints for multiple interfaces are set up. Move most of the per endpoint initialization to separate function to avoid another identation level. Reviewed-by: Marek Vasut Signed-off-by: Janne Grunau --- drivers/usb/host/xhci.c | 119

[PATCH v2 6/6] usb: kbd: Add probe quirk for Apple and Keychron keyboards

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Those keyboards do not return the current device state. Polling will timeout unless there are key presses. This is not a problem during operation but the inital device state query during probing will fail. Skip this step in usb_kbd_probe_dev() to make these devices useable

[PATCH v2 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau The xhci driver currently only does the necessary initialization for endpoints found in the first interface descriptor. Apple USB keyboards (released 2021) use the second interface descriptor for the HID keyboard boot protocol. To allow USB drivers to use endpoints from other

[PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Add the environment variable "usb_blocklist" to prevent USB devices listed in it from being used. This allows to ignore devices which trigger bugs in u-boot's USB stack or are undesirable for other reasons. Devices emulating keyboards are one example. U-boot currentl

[PATCH v2 3/6] usb: xhci: Abort transfers with unallocated rings

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Discovered while trying to use the second interface in the USB keyboard driver necessary on Apple USB keyboards. Signed-off-by: Janne Grunau --- drivers/usb/host/xhci-ring.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb

[PATCH v3 7/7] efi_selftest: Update StrToFat() unit test after CP473 map extension

2024-03-16 Thread Janne Grunau via B4 Relay
From: Janne Grunau Test that Unicode code points which map to CP437 code points 1-31 are converted to '_'. This ensures no FAT file names do not contain chars which are control characters in other code pages (CP 1250 for example). Signed-off-by: Janne Grunau --- lib/efi_selftest

[PATCH v3 2/7] video: console: Parse UTF-8 character sequences

2024-03-16 Thread Janne Grunau via B4 Relay
From: Janne Grunau efi_console / UEFI applications (grub2, sd-boot, ...) pass UTF-8 character sequences to vidconsole which results in wrong glyphs for code points outside of ASCII. The truetype console expects Unicode code points and bitmap font based consoles expect code page 437 code points

[PATCH v3 1/7] lib: charset: Fix and extend utf8_to_utf32_stream() documentation

2024-03-16 Thread Janne Grunau via B4 Relay
From: Janne Grunau Suggested-by: Heinrich Schuchardt Reviewed-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- include/charset.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/include/charset.h b/include/charset.h index 44034c71d3..f1050c903d

[PATCH v3 6/7] efi_selftest: Add geometric shapes character selftest

2024-03-16 Thread Janne Grunau via B4 Relay
From: Janne Grunau Draw symbols from Unicode's "Geometric shapes" page which translate to code page 437 code points 1-31. These are used by UEFI applications to draw user interfaces using EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. The output has to be checked manually on the screen for c

[PATCH v3 5/7] efi_selftest: Add box drawing character selftest

2024-03-16 Thread Janne Grunau via B4 Relay
for correctness. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 20 1 file changed, 20 insertions(+) diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib/efi_selftest

[PATCH v3 4/7] efi_selftest: Add international characters test

2024-03-16 Thread Janne Grunau via B4 Relay
on the screen for correctness. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib

[PATCH v3 0/7] video: Add UTF-8 support for UEFI applications

2024-03-16 Thread Janne Grunau via B4 Relay
as proposed by Heinrich Link: https://lore.kernel.org/u-boot/20220110005638.21599-1-andre.przyw...@arm.com/ Signed-off-by: Janne Grunau --- Changes in v3: - added Reviewed-by tag - removed unnecessary u8 casts - limited utf-8 conversion buffer to 5 bytes as documented - added missing

[PATCH v3 3/7] lib/charset: Map Unicode code points to CP437 code points 1-31

2024-03-16 Thread Janne Grunau via B4 Relay
From: Janne Grunau Code page 437 uses code points 1-31 for glyphs instead of control characters. Map the appropriate Unicode code points to this code points. Fixes rendering of grub2's menu as EFI application using the EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL on a console with bitmap fonts. Signed-off

Re: [PATCH 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-02-26 Thread Janne Grunau
Hej, On Sun, Feb 25, 2024, at 22:47, Marek Vasut wrote: > On 2/25/24 4:28 PM, Janne Grunau wrote: >> >> >> On Wed, Feb 21, 2024, at 13:39, Marek Vasut wrote: >>> On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >>>> From: Janne Grunau >>>>

Re: [PATCH 4/6] usb: kbd: Ignore Yubikeys

2024-02-26 Thread Janne Grunau
Hej, On Mon, Feb 26, 2024, at 21:47, Mark Kettenis wrote: >> Date: Sun, 25 Feb 2024 22:57:23 +0100 >> From: Marek Vasut >> >> On 2/25/24 5:07 PM, Janne Grunau wrote: >> > Hej, >> > >> > On Wed, Feb 21, 2024, at 13:41, Marek Vasut wrote: >

Re: [PATCH 4/6] usb: kbd: Ignore Yubikeys

2024-02-25 Thread Janne Grunau
Hej, On Wed, Feb 21, 2024, at 13:41, Marek Vasut wrote: > On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >> From: Hector Martin >> >> We currently only support one USB keyboard device, but some devices >> emulate keyboards for other purposes

Re: [PATCH 3/6] usb: xhci: Abort transfers with unallocated rings

2024-02-25 Thread Janne Grunau
Hej, On Wed, Feb 21, 2024, at 13:40, Marek Vasut wrote: > On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Discovered while trying to use the second interface in the USB keyboard >> driver necessary on Apple USB keyboards. >>

Re: [PATCH 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-02-25 Thread Janne Grunau
On Wed, Feb 21, 2024, at 13:39, Marek Vasut wrote: > On 2/21/24 08:25, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Apple USB keyboards carry the HID keyboard boot protocol on the second >> interface. Using the second interface in the USB keyboard dr

Re: [PATCH v2 5/6] efi_selftest: Add box drawing character selftest

2024-02-20 Thread Janne Grunau
Hej, On Mon, Feb 12, 2024, at 17:07, Heinrich Schuchardt wrote: > On 10.02.24 13:46, Janne Grunau via B4 Relay wrote: >> From: Andre Przywara >> >> UEFI applications rely on Unicode output capability, and might use that >> for drawing pseudo-graphical interface

[PATCH 2/6] usb: xhci: Set up endpoints for the first 2 interfaces

2024-02-20 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple USB keyboards carry the HID keyboard boot protocol on the second interface. Using the second interface in the USB keyboard driver does not work since the xhci has not allocated a transfer ring. --- drivers/usb/host/xhci.c | 31 +++ include

[PATCH 6/6] usb: kbd: Add probe quirk for Apple and Keychron keyboards

2024-02-20 Thread Janne Grunau via B4 Relay
From: Janne Grunau Those keyboards do not return the current device state. Polling will timeout unless there are key presses. This is not a problem during operation but the inital device state query during probing will fail. Skip this step in usb_kbd_probe_dev() to make these devices useable

[PATCH 3/6] usb: xhci: Abort transfers with unallocated rings

2024-02-20 Thread Janne Grunau via B4 Relay
From: Janne Grunau Discovered while trying to use the second interface in the USB keyboard driver necessary on Apple USB keyboards. Signed-off-by: Janne Grunau --- drivers/usb/host/xhci-ring.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb

[PATCH 4/6] usb: kbd: Ignore Yubikeys

2024-02-20 Thread Janne Grunau via B4 Relay
From: Hector Martin We currently only support one USB keyboard device, but some devices emulate keyboards for other purposes. Most commonly, people run into this with Yubikeys, so let's ignore those. Even if we end up supporting multiple keyboards in the future, it's safer to ignore known

[PATCH 1/6] usb: xhci: refactor xhci_set_configuration

2024-02-20 Thread Janne Grunau via B4 Relay
From: Janne Grunau In the next step endpoints for multiple interfaces are set up. Move most of the per endpoint initialization to separate function to avoid another identation level. Signed-off-by: Janne Grunau --- drivers/usb/host/xhci.c | 119

[PATCH 5/6] usb: kbd: support Apple Magic Keyboards (2021)

2024-02-20 Thread Janne Grunau via B4 Relay
From: Janne Grunau Apple USB keyboards (Magic Keyboard from 2021 (product id 0x029c)) carry the HID keyboard boot protocol on the second interface descriptor. Probe via vendor and product IDs since the class/subclass/protocol match uses the first interface descriptor. Probe the two first

[PATCH 0/6] USB keyboard improvements for asahi / desktop systems

2024-02-20 Thread Janne Grunau via B4 Relay
e Yubikeys emulate a keyboard. since u-boot only binds a single keyboard block this kind of devices from the USB keyboard driver. Signed-off-by: Janne Grunau --- Hector Martin (1): usb: kbd: Ignore Yubikeys Janne Grunau (5): usb: xhci: refactor xhci_set_configuration usb: xh

[PATCH v2 6/6] efi_selftest: Add symbol character selftest

2024-02-10 Thread Janne Grunau via B4 Relay
From: Janne Grunau Draw symbols from code page 437 code points 0x01 - 01f used by UEFI applications to draw user interfaces using EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. Add a simple test to displaying the Konami code using symbols used by grub2. The output has to be checked manually on the screen

[PATCH v2 5/6] efi_selftest: Add box drawing character selftest

2024-02-10 Thread Janne Grunau via B4 Relay
for correctness. To facilitate this, add a three second delay after the output at this point. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 20 1 file changed, 20 insertions

[PATCH v2 1/6] lib: charset: Fix and extend utf8_to_utf32_stream() documentation

2024-02-10 Thread Janne Grunau via B4 Relay
From: Janne Grunau Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- include/charset.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/include/charset.h b/include/charset.h index 44034c71d3..f1050c903d 100644 --- a/include/charset.h +++ b

[PATCH v2 4/6] efi_selftest: Add international characters test

2024-02-10 Thread Janne Grunau via B4 Relay
on the screen for correctness. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib/efi_selftest

[PATCH v2 2/6] video: console: Parse UTF-8 character sequences

2024-02-10 Thread Janne Grunau via B4 Relay
From: Janne Grunau efi_console / UEFI applications (grub2, sd-boot, ...) pass UTF-8 character sequences to vidconsole which results in wrong glyphs for code points outside of ASCII. The truetype console expects Unicode code points and bitmap font based consoles expect code page 437 code points

[PATCH v2 0/6] video: Add UTF-8 support for UEFI applications

2024-02-10 Thread Janne Grunau via B4 Relay
as proposed by Heinrich Link: https://lore.kernel.org/u-boot/20220110005638.21599-1-andre.przyw...@arm.com/ Signed-off-by: Janne Grunau --- Changes in v2: - use "CONFIG_IS_ENABLED(CHARSET)" instead of EFI_LOADER - rewritten commit message for mapping CP437 cp 1-31 - extended utf8_to_ut

[PATCH v2 3/6] lib/charset: Map Unicode code points to CP437 code points 0-31

2024-02-10 Thread Janne Grunau via B4 Relay
From: Janne Grunau Code page 437 uses code points 1-31 for glyphs instead of control characters. Map the appropriate Unicode code points to this code points. Fixes rendering of grub2's menu as EFI application using the EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL on a console with bitmap fonts. Signed-off

Re: [PATCH RFC 4/6] efi_selftest: Add international characters test

2024-02-10 Thread Janne Grunau
Hej, On Thu, Jan 18, 2024, at 19:48, Heinrich Schuchardt wrote: > On 1/17/24 23:24, Janne Grunau via B4 Relay wrote: >> From: Andre Przywara >> >> UEFI relies entirely on unicode output, which actual fonts displayed on >> the screen might not be ready for. >&

Re: [PATCH RFC 0/6] video: Add UTF-8 support for UEFI applications

2024-01-18 Thread Janne Grunau
Hej Heinrich, On Thu, Jan 18, 2024, at 17:47, Heinrich Schuchardt wrote: > On 1/17/24 23:24, Janne Grunau via B4 Relay wrote: >> Andre submitted 2 years ago DM_VIDEO improvements for UEFI applications >> using UEFI's EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL but did not follow with >&

[PATCH] video: console: Fix buffer overflow in cmd 'font list'

2024-01-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau vidconsole_ops.get_font is documented to return -ENOENT after the last video_fontdata entry. Signed-off-by: Janne Grunau --- drivers/video/console_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console_core.c b/drivers/video

[PATCH] video: Support VIDEO_X2R10G10B10 in truetype console

2024-01-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Without explicit support for VIDEO_X2R10G10B10 VIDEO_X8R8G8B8 white will be rendered as cyan-ish. The conversion leaves to lowest 2 bits unset for more compact code. Signed-off-by: Janne Grunau --- drivers/video/console_truetype.c | 10 -- 1 file changed, 8

[PATCH RFC 2/6] video: console: Parse UTF-8 character sequences

2024-01-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau efi_console / UEFI applications (grub2, sd-boot, ...) pass UTF-8 character sequences to vidconsole which results in wrong glyphs for code points outside of ASCII. The truetype console expects Unicode code points and bitmap font based consoles expect code page 437 code points

[PATCH RFC 3/6] lib/charset: Map cp437 low chars (0x01 - 0x1f) from unicode

2024-01-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Add mappings for code points 1 - 31 as those code points in code page 437 are graphics. Thios fixes rendering issues of various EFI boot loaders (grub2, sd-boot, ...) using EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. Signed-off-by: Janne Grunau --- include/charset.h

[PATCH RFC 0/6] video: Add UTF-8 support for UEFI applications

2024-01-17 Thread Janne Grunau via B4 Relay
in tests as proposed by Heinrich Link: https://lore.kernel.org/u-boot/20220110005638.21599-1-andre.przyw...@arm.com/ Signed-off-by: Janne Grunau --- Andre Przywara (2): efi_selftest: Add international characters test efi_selftest: Add box drawing character selftest Janne Grunau (4

[PATCH RFC 6/6] efi_selftest: Add symbol character selftest

2024-01-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Draw symbols from code page 437 code points 0x01 - 01f used by UEFI applications to draw user interfaces using EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. Add a simple test to displaying the Konami code using symbols used by grub2. The output has to be checked manually on the screen

[PATCH RFC 5/6] efi_selftest: Add box drawing character selftest

2024-01-17 Thread Janne Grunau via B4 Relay
for correctness. To facilitate this, add a three second delay after the output at this point. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 20 1 file changed, 20 insertions

[PATCH RFC 1/6] lib: charset: Fix utf8_to_utf32_stream() return value doc string

2024-01-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau The comment appears to be copied from utf8_to_cp437_stream() but was not updated. Signed-off-by: Janne Grunau --- include/charset.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/charset.h b/include/charset.h index 44034c71d3..714382e1c1 100644

[PATCH RFC 4/6] efi_selftest: Add international characters test

2024-01-17 Thread Janne Grunau via B4 Relay
on the screen for correctness. Signed-off-by: Andre Przywara Suggested-by: Heinrich Schuchardt Signed-off-by: Janne Grunau --- lib/efi_selftest/efi_selftest_textoutput.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/efi_selftest/efi_selftest_textoutput.c b/lib/efi_selftest

[PATCH v2] arm: apple: t602x: Add missing MMIO regions to memmap

2023-11-30 Thread Janne Grunau via B4 Relay
From: Janne Grunau The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which was not used by any driver at the time. The display out exposed as simple-framebuffer use a power-domain controlled by a device in an unmapped region. Add a map covering this region as well as another MMIO

Re: [PATCH] arm: apple: t602x: Add missing MMIO regions to memmap

2023-11-30 Thread Janne Grunau
Hej Mark, On Thu, Nov 30, 2023, at 21:45, Mark Kettenis wrote: >> From: Janne Grunau via B4 Relay >> Date: Thu, 30 Nov 2023 13:42:22 +0100 >> >> From: Janne Grunau >> >> The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which >&

[PATCH] arm: apple: t602x: Add missing MMIO regions to memmap

2023-11-30 Thread Janne Grunau via B4 Relay
From: Janne Grunau The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which was not used by any driver at the time. The display out exposed as simple-framebuffer use a power-domain controlled by a device in an unmapped region. Add a map covering this region as well as another MMIO

[PATCH] arm: apple: Add initial Apple M2 Ultra support

2023-09-06 Thread Janne Grunau
Apple's M2 Ultra SoC are somewhat similar to the M1 Ultra but needs a tweaked memory map as the M2 Pro/Max SoCs. USB, NVMe, UART, WDT and PCIe are working with the existing drivers. Signed-off-by: Janne Grunau --- arch/arm/mach-apple/board.c | 183

[PATCH] apple_m1_defconfig: Bump CONFIG_LMB_MAX_REGIONS to 64

2023-03-13 Thread Janne Grunau
with the large amount of reserved-memory regions. Signed-off-by: Janne Grunau --- configs/apple_m1_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig index b4ecf73cbc78..755560971e57 100644 --- a/configs/apple_m1_defconfig +++ b/configs

[PATCH] pci: apple: Initialize only enabled ports

2023-03-13 Thread Janne Grunau
The Linux devicetrees for Apple silicon devices are after review feedback switching from deleting unused PCIe ports to disabling them. Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab0...@linaro.org/ Signed-off-by: Janne Grunau --- drivers/pci/pcie_apple.c | 2 ++ 1 file

Re: u-boot crashes if mass-storage devices are connected via USB-C

2023-03-02 Thread Janne Grunau
On 2023-03-02 22:05:43 +0100, Marek Vasut wrote: > On 3/2/23 19:51, Janne Grunau wrote: > > On 2023-03-02 18:33:15 +0100, Marek Vasut wrote: > > > On 3/2/23 10:14, Janne Grunau wrote: > > > > On 2023-03-01 23:51:14 +0100, Marek Vasut wrote: > > >

Re: u-boot crashes if mass-storage devices are connected via USB-C

2023-03-02 Thread Janne Grunau
On 2023-03-02 18:33:15 +0100, Marek Vasut wrote: > On 3/2/23 10:14, Janne Grunau wrote: > > On 2023-03-01 23:51:14 +0100, Marek Vasut wrote: > > > On 3/1/23 21:34, Simon Glass wrote: > > > > +Marek Vasut +Bin Meng +Mark Kettenis +Tom Rini > > > > >

Re: u-boot crashes if mass-storage devices are connected via USB-C

2023-03-02 Thread Janne Grunau
guided me write my bug report > > > to this email. "bluetail: please report these usb bugs upstream; they're > > > almost certainly not hardware-specific" > > > > > > But before, jannau aka Janne Grunau asked me to give the version output > >

Re: RFC: Handling of multiple EFI System Partitions

2022-12-19 Thread Janne Grunau
On 2022-12-18 20:40:20 +0100, Heinrich Schuchardt wrote: > > > Am 18. Dezember 2022 15:21:06 MEZ schrieb Mark Kettenis > : > >The Asahi installer, which is what most people use to get their Apple > >Silicon Mac into a state where it is possible to install another OS on > >the machine, offers

[PATCH v3 1/1] usb: storage: continue probe on "Invalid device"

2022-11-04 Thread Janne Grunau
iProduct2 USB3.0 Card Reader iSerial 3 201404081410 Link: https://github.com/AsahiLinux/linux/issues/44 Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html Signed-off-by: Janne Grunau Reviewed-by: Simon Glass Reviewed-by: Marek Vasut --- common

Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

2022-11-04 Thread Janne Grunau
On 2022-11-03 23:23:52 +0100, Marek Vasut wrote: > On 11/3/22 22:36, Janne Grunau wrote: > > On 2022-09-28 04:20:52 -0600, Simon Glass wrote: > > > +Marek Vasut > > > +Tom Rini > > > > > > On Sun, 25 Sept 2022 at 23:07, Janne Grunau wrote: > &g

Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

2022-11-03 Thread Janne Grunau
On 2022-09-28 04:20:52 -0600, Simon Glass wrote: > +Marek Vasut > +Tom Rini > > On Sun, 25 Sept 2022 at 23:07, Janne Grunau wrote: > > > > On 2022-08-10 21:54:22 +0200, Janne Grunau wrote: > > > Fixes a crash during probing of sd card readers without medium

Re: [PATCH] usb: Add 1ms delay after first Get Descriptor request

2022-11-03 Thread Janne Grunau
issuing subsequent requests to avoid probe failure with > > > this device, since it can be used to connect USB keyboards. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Cc: Janne Grunau > > > Cc: Mark Kettenis > > > --- > > &

Re: [PATCH 1/1] usb: request only 8 bytes for USB_SPEED_FULL bMaxPacketSize0 discovery

2022-09-25 Thread Janne Grunau
On 2022-09-26 01:52:37 +0200, Marek Vasut wrote: > On 8/29/22 08:31, Janne Grunau wrote: > > Fixes probing of various keyboards with DWC3 as integrated into Apple > > silicon SoCs. The problem appears to be requesting more data than the > > devices's bMaxPacketSize0 of 8. Ol

Re: [PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

2022-09-25 Thread Janne Grunau
On 2022-08-10 21:54:22 +0200, Janne Grunau wrote: > Fixes a crash during probing of sd card readers without medium present. > > Link: https://github.com/AsahiLinux/linux/issues/44 > Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html > Signed-off-by: Janne Grunau

[PATCH 1/1] usb: request only 8 bytes for USB_SPEED_FULL bMaxPacketSize0 discovery

2022-08-29 Thread Janne Grunau
Fixes probing of various keyboards with DWC3 as integrated into Apple silicon SoCs. The problem appears to be requesting more data than the devices's bMaxPacketSize0 of 8. Older Logitech unifying receivers (bcdDevice 12.03 or 12.10) are for eaxample affected. Signed-off-by: Janne Grunau Tested

  1   2   >