[U-Boot] [PATCH v6 11/11] board: ti: am57xx: remove USB platform code

2018-05-25 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: - Supports DM USB for peripherals - Removed DTS changes that disabled USB1 on DRA7 because DM_USB_DEV is now supported Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None board/ti/

[U-Boot] [PATCH v6 05/11] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-25 Thread Jean-Jacques Hiblot
For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2:

[U-Boot] [PATCH v6 09/11] configs: am57xx_evm: Enable DM_USB and DM_USB_DEV

2018-05-25 Thread Jean-Jacques Hiblot
Enable DM_USB and DM_USB_DEV for AM57xx based boards. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: - AM57 configs: enable DM_USB and DM_USB_DEV. Use DWC3_GENERIC in place of DWC3_OF_SIMPLE. disable non DM

[U-Boot] [PATCH v6 10/11] board: ti: dra7-evm: remove USB platform code

2018-05-25 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None board/ti/dra7xx/evm.c | 104 -- 1 file changed, 104 deletions(-) diff --git a/bo

[U-Boot] [PATCH v6 07/11] dts: dra7x: make ocp2scp@4a080000 compatible with simple-bus

2018-05-25 Thread Jean-Jacques Hiblot
This is required when DM_USB is used, to bind the USB phys. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - split dts changes in 2 commits: one for binding the children of o

[U-Boot] [PATCH v6 01/11] syscon: dm: Add a new method to get a regmap from DTS

2018-05-25 Thread Jean-Jacques Hiblot
syscon_regmap_lookup_by_phandle() can be used to get the regmap of a syscon device from a reference in the DTS. It operates similarly to the linux version of the namesake function. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: None Changes in v5: None Changes

[U-Boot] [PATCH v6 06/11] board; ti: am57xx: turn on USB clocks

2018-05-25 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Enable USB clocks in late init stage to support ports under DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes i

[U-Boot] [PATCH v6 08/11] configs: enable DM_USB and DM_USB_DEV for all DRA7 platforms

2018-05-25 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: - DRA7 configs: enable DM_USB and DM_USB_DEV. Use DWC3_GENERIC in place of DWC3_OF_SIMPLE. disable non DM USB options Changes in v5: None Changes in v4: - Remove dependency on MISC - Renamed the commit (DM_USB is a

[U-Boot] [PATCH v6 04/11] dwc3-generic: Add support for the TI DWC3 glue

2018-05-25 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/usb/dwc3/dwc3-generic.c | 86 + 1 file changed, 86 insertions(+) diff --git a/drive

[U-Boot] [PATCH v6 03/11] phy: Add a new driver for OMAP's USB2 PHYs

2018-05-25 Thread Jean-Jacques Hiblot
This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - omap-usb2-phy: Implement power_on and power_off callbacks drive

[U-Boot] [PATCH v6 02/11] phy: ti-pip3-phy: Add support for USB3 PHY

2018-05-25 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Add support to handle USB3 PHYs present on AM57xx/DRA7xx SoCs. This is needed to move AM57xx to DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v6: - ti-pipe3-phy: ta

[U-Boot] [PATCH v1 6/7] dwc3-generic: Handle the PHYs, the clocks and the reset lines

2018-05-25 Thread Jean-Jacques Hiblot
This make the driver more generic. At this point this driver can replace the dwc3-of-simple implementation. Make the description in the Kconfig more generic too. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/usb/dwc3/Kconfig| 7 +- drivers/usb/dwc3/dwc3-gen

[U-Boot] [PATCH v1 4/7] dwc3_generic: do not probe the USB device driver when it's bound

2018-05-25 Thread Jean-Jacques Hiblot
The driver will be probed when usb_gadget_initialize() is called. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/usb/dwc3/dwc3-generic.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c index 4

[U-Boot] [PATCH v1 3/7] usb: udc: implement DM versions of usb_gadget_initialize()/_release()/_handle_interrupt()

2018-05-25 Thread Jean-Jacques Hiblot
When DM_USB_DEV the platform code for the USB device must be replaced by calls to a USB device driver. usb_gadget_initialize() probes the USB device driver. usb_gadget_release() removes the USB device driver. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/usb/dwc

[U-Boot] [PATCH v1 5/7] dwc3: move phy operation to core.c

2018-05-25 Thread Jean-Jacques Hiblot
Those operations can be used for peripheral operation as well as host operation. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/usb/dwc3/core.c | 88 - drivers/usb/dwc3/ep0.c | 1 - drivers/usb/host/xhci-dwc3.

[U-Boot] [PATCH v1 7/7] dwc3-generic: Add select_dr_mode operation

2018-05-25 Thread Jean-Jacques Hiblot
The select_dr_mode operation is executed when the glue driver is probed. The role of this optional function is to configure the operating mode of the controller at the glue level. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/usb/dwc3/dwc3-generic.

[U-Boot] [PATCH v1 0/7] Improvements for the dwc3_generic driver

2018-05-25 Thread Jean-Jacques Hiblot
vice is first needed. - handles PHYs when in the peripheral mode. The code to handle the PHYs is shared with the host side - handles clock and reset - bind host controller to the more generic driver 'xhci-dwc3' Jean-Jacques Hiblot (7): usb: gadget: Do not call board_usb_xxx() directly in USB ga

[U-Boot] [PATCH v1 1/7] usb: gadget: Do not call board_usb_xxx() directly in USB gadget drivers

2018-05-25 Thread Jean-Jacques Hiblot
Add 2 functions to wrap the calls to board_usb_init() and board_usb_cleanup(). Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- cmd/fastboot.c | 4 ++-- cmd/rockusb.c | 4 ++-- cmd/thordown.c | 4 ++-- cmd/usb_gadget_sdp.c | 4 ++-

[U-Boot] [PATCH v1 2/7] usb: introduce a separate config option for DM USB device

2018-05-25 Thread Jean-Jacques Hiblot
Using CONFIG_DM_USB for this purpose prevents using DM_USB for host and not for device. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/usb/Kconfig | 6 ++ drivers/usb/dwc3/core.c | 2 +- drivers/usb/dwc3/dwc3-generic.c | 4 +++- 3 files chang

Re: [U-Boot] [PATCH v2 3/6] usb: dwc3: Add generic DWC3 glue logic driver

2018-05-18 Thread Jean-Jacques Hiblot
On 18/05/2018 15:24, Jean-Jacques Hiblot wrote: On 18/05/2018 13:15, Michal Simek wrote: By enabling BLK by default this is the next driver which needs to get support for DM_USB. Adding generic DWC3 glue logic which only parse nodes and read device mode. Based on it probe proper host

Re: [U-Boot] [PATCH v2 3/6] usb: dwc3: Add generic DWC3 glue logic driver

2018-05-18 Thread Jean-Jacques Hiblot
On 18/05/2018 13:15, Michal Simek wrote: By enabling BLK by default this is the next driver which needs to get support for DM_USB. Adding generic DWC3 glue logic which only parse nodes and read device mode. Based on it probe proper host/peripheral DWC3 drivers for it. Signed-off-by: Michal

Re: [U-Boot] [PATCH v2 1/6] usb: dwc3: Add dwc3_init/remove with DM_USB

2018-05-18 Thread Jean-Jacques Hiblot
Hi Michal, I've been trying your series on DRA7 platforms. Thanks for the work. I have a few comments though. On 18/05/2018 13:15, Michal Simek wrote: From: Mugunthan V N The patch is preparing dwc3 core for enabling DM_USB with peripheral driver with using driver

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-17 Thread Jean-Jacques Hiblot
On 16/05/2018 17:21, Tom Rini wrote: On Wed, May 16, 2018 at 11:04:18AM +0200, Marek Vasut wrote: On 05/16/2018 11:00 AM, Jean-Jacques Hiblot wrote: On 16/05/2018 00:13, Marek Vasut wrote: On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Jean-Jacques Hiblot
On 16/05/2018 11:04, Marek Vasut wrote: On 05/16/2018 11:00 AM, Jean-Jacques Hiblot wrote: On 16/05/2018 00:13, Marek Vasut wrote: On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Jean-Jacques Hiblot
On 16/05/2018 00:13, Marek Vasut wrote: On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-15 Thread Jean-Jacques Hiblot
+Lokesh On 15/05/2018 18:10, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to implement it instead of piling up

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-15 Thread Jean-Jacques Hiblot
Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to implement it instead of piling up those hacks ? I was thinking along the same lines at some

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Jean-Jacques Hiblot
On 04/05/2018 17:43, Marek Vasut wrote: On 05/04/2018 04:42 PM, Jean-Jacques Hiblot wrote: On 04/05/2018 16:38, Marek Vasut wrote: On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Jean-Jacques Hiblot
On 04/05/2018 16:38, Marek Vasut wrote: On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com>

[U-Boot] [PATCH v5 6/9] dts: dra7x: make ocp2scp@4a080000 compatible with simple-bus

2018-05-04 Thread Jean-Jacques Hiblot
This is required when DM_USB is used, to bind the USB phys. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - split dts changes in 2 commits: one for binding the children of ocp2scp@4a08, a

[U-Boot] [PATCH v5 9/9] configs: am57xx_evm: Enable DM_USB and dependencies

2018-05-04 Thread Jean-Jacques Hiblot
Enable DM_USB for AM57xx based boards. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: - Remove dependency on MISC - Remove omap specific glue layer and use dwc3-of-simple glue layer Changes

[U-Boot] [PATCH v5 1/9] syscon: dm: Add a new method to get a regmap from DTS

2018-05-04 Thread Jean-Jacques Hiblot
syscon_regmap_lookup_by_phandle() can be used to get the regmap of a syscon device from a reference in the DTS. It operates similarly to the linux version of the namesake function. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: - Fix word m

[U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Jean-Jacques Hiblot
For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None board/ti/dra7x

[U-Boot] [PATCH v5 7/9] dts: dra7x: Disable USB1 on all evms

2018-05-04 Thread Jean-Jacques Hiblot
-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files arch/arm/dts/dra7-evm-u-boot.dtsi | 8 arch/arm/dts/dra71-evm-u-boot.dtsi

[U-Boot] [PATCH v5 8/9] configs: enable OMAP_USB2_PHY for all DRA7 platforms

2018-05-04 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: - Remove dependency on MISC - Renamed the commit (DM_USB is already enabled, the only missing option is for the USB2 phy driver) Changes in v3: None Changes in v2: None configs/dra7xx_evm_def

[U-Boot] [PATCH v5 0/9] Add support for DM_USB for TI's DRA7 EVMs and AM57 EVMs platforms

2018-05-04 Thread Jean-Jacques Hiblot
- Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed) is supported. Jean-Jacques Hiblot (7): syscon: dm: Add a new method to get a regmap from DTS phy: Add a new driver for OMAP's USB2 PHYs board: ti: dra7xx-evm: turn

[U-Boot] [PATCH v5 5/9] board; ti: am57xx: turn on USB clocks

2018-05-04 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Enable USB clocks in late init stage to support ports under DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v

[U-Boot] [PATCH v5 3/9] phy: Add a new driver for OMAP's USB2 PHYs

2018-05-04 Thread Jean-Jacques Hiblot
This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - omap-usb2-phy: Implement power_on and power_off callbacks drivers/phy/Kconfig

[U-Boot] [PATCH v5 2/9] phy: ti-pip3-phy: Add support for USB3 PHY

2018-05-04 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Add support to handle USB3 PHYs present on AM57xx/DRA7xx SoCs. This is needed to move AM57xx to DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v5: None Changes in v4:

Re: [U-Boot] [PATCH] arm: mach-omap2: cache: Explicitly enable I cache

2018-05-03 Thread Jean-Jacques Hiblot
che if not enabled */ + if (!icache_status()) + icache_enable(); + dcache_enable(); } Tested-by: Jean-Jacques Hiblot <jjhib...@ti.com> ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v1 6/8] spl: Disable printf if not required

2018-04-18 Thread Jean-Jacques Hiblot
On 18/04/2018 11:02, Alex Kiernan wrote: Now we have a guard for printf, disable it in the build if it's not selected. Signed-off-by: Alex Kiernan --- lib/panic.c | 3 +++ lib/tiny-printf.c | 13 - lib/vsprintf.c| 4 +++- 3 files changed,

Re: [U-Boot] u-boot-usb/master build failure on dra7xx_evm

2018-04-17 Thread Jean-Jacques Hiblot
On 17/04/2018 20:35, Jean-Jacques Hiblot wrote: Hi Marek, that should be fixed by applying https://patchwork.ozlabs.org/patch/897532/ You should also apply https://patchwork.ozlabs.org/patch/897537/ Without it the probe fails on dra7xx-evm JJ On 17/04/2018 20:25, Marek Vasut wrote: Hi

Re: [U-Boot] u-boot-usb/master build failure on dra7xx_evm

2018-04-17 Thread Jean-Jacques Hiblot
Hi Marek, that should be fixed by applying https://patchwork.ozlabs.org/patch/897532/ JJ On 17/04/2018 20:25, Marek Vasut wrote: Hi, can you look at this build problem in u-boot-usb/master on dra7xx_evm and send me a patch? https://travis-ci.org/marex/u-boot-usb/jobs/367566783 u-boot-usb$

[U-Boot] [PATCH v4 00/11] Add support for DM_USB for TI's DRA7 EVMs and AM57 EVMs platforms

2018-04-12 Thread Jean-Jacques Hiblot
e children of ocp2scp@4a08, and one to disable USB1 on all DRA7 EVMs - Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed) is supported. Jean-Jacques Hiblot (9): usb: dwc3-of-simple: Fix dependencies usb: dwc3-of-s

[U-Boot] [PATCH v4 06/11] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-04-12 Thread Jean-Jacques Hiblot
For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v4: None Changes in v3: None Changes in v2: None board/ti/dra7x

[U-Boot] [PATCH v4 05/11] phy: Add a new driver for OMAP's USB2 PHYs

2018-04-12 Thread Jean-Jacques Hiblot
This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3: None Changes in v2: - omap-usb2-phy: Implement power_on and power_off callbacks drivers/phy/Kconfig | 8 ++ drive

[U-Boot] [PATCH v4 10/11] configs: enable OMAP_USB2_PHY for all DRA7 platforms

2018-04-12 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: - Remove dependency on MISC - Renamed the commit (DM_USB is already enabled, the only missing option is for the USB2 phy driver) Changes in v3: None Changes in v2: None configs/dra7xx_evm_defconfig| 1 + c

[U-Boot] [PATCH v4 08/11] dts: dra7x: make ocp2scp@4a080000 compatible with simple-bus

2018-04-12 Thread Jean-Jacques Hiblot
This is required when DM_USB is used, to bind the USB phys. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3: None Changes in v2: - split dts changes in 2 commits: one for binding the children of ocp2scp@4a08, and one to disable USB1 on al

[U-Boot] [PATCH v4 11/11] configs: am57xx_evm: Enable DM_USB and dependencies

2018-04-12 Thread Jean-Jacques Hiblot
Enable DM_USB for AM57xx based boards. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: - Remove dependency on MISC Changes in v3: None Changes in v2: - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed)

[U-Boot] [PATCH v4 03/11] syscon: dm: Add a new method to get a regmap from DTS

2018-04-12 Thread Jean-Jacques Hiblot
syscon_regmap_lookup_by_phandle() can be used to get the regmap of a syscon device from a reference in the DTS. It operates similarly to the linux version of the namesake function. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: - Fix word missing in commit log C

[U-Boot] [PATCH v4 09/11] dts: dra7x: Disable USB1 on all evms

2018-04-12 Thread Jean-Jacques Hiblot
-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3: None Changes in v2: - Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files arch/arm/dts/dra7-evm-u-boot.dtsi | 8 arch/arm/dts/dra71-evm-u-boot.dtsi | 9 + arch/arm/dts

[U-Boot] [PATCH v4 04/11] phy: ti-pip3-phy: Add support for USB3 PHY

2018-04-12 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Add support to handle USB3 PHYs present on AM57xx/DRA7xx SoCs. This is needed to move AM57xx to DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3:

[U-Boot] [PATCH v4 07/11] board; ti: am57xx: turn on USB clocks

2018-04-12 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Enable USB clocks in late init stage to support ports under DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3: None Changes in v2: - am57xx boards: w

[U-Boot] [PATCH v4 02/11] usb: dwc3-of-simple: Add support for DRA7/AM57 platforms.

2018-04-12 Thread Jean-Jacques Hiblot
Add the compatibility with "ti,dwc3" and enable it by default if DM_USB is enabled. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/usb/host/Kconfig | 1 + drivers/usb/host/dwc3-of-simple.

[U-Boot] [PATCH v4 01/11] usb: dwc3-of-simple: Fix dependencies

2018-04-12 Thread Jean-Jacques Hiblot
This simple glue layer does not require CONFIG_MISC, but it does require CONFIG_DM_USB. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [PATCH v3 u-boot 1/3] usb: host: Add simple of glue driver for DWC3 USB Controllers integration

2018-04-11 Thread Jean-Jacques Hiblot
int dwc3_of_simple_clk_init(struct udevice *dev, + struct dwc3_of_simple *simple) +{ + int ret; + + ret = clk_get_bulk(dev, >clks); + if (ret == -ENOTSUPP) Must be ENOSYS instead of ENOTSUPP, otherwise probe fails on platform not using the clk framewor

Re: [U-Boot] [PATCH v2 u-boot 1/2] reset: Add get/assert/deassert/release for bulk of reset signals

2018-04-11 Thread Jean-Jacques Hiblot
Hi Neil, while trying to test your patches on dwc3, I ran into a compilation issue. On 03/04/2018 11:40, Neil Armstrong wrote: This patch adds a "bulk" API to the reset API in order to get/deassert/ assert/release a group of reset signals associated with a device. This bulk API will avoid

Re: [U-Boot] [BUG] snow: mmc: SD card access broken: unable to select a mode

2018-04-09 Thread Jean-Jacques Hiblot
On 09/04/2018 16:46, Guillaume Gardet wrote: Le 09/04/2018 à 16:21, Jean-Jacques Hiblot a écrit : On 09/04/2018 16:03, Guillaume Gardet wrote: Le 09/04/2018 à 15:58, Jean-Jacques Hiblot a écrit : On 09/04/2018 14:02, Guillaume Gardet wrote: Hi Jaehoon, There are problems with SD

Re: [U-Boot] [BUG] snow: mmc: SD card access broken: unable to select a mode

2018-04-09 Thread Jean-Jacques Hiblot
On 09/04/2018 16:03, Guillaume Gardet wrote: Le 09/04/2018 à 15:58, Jean-Jacques Hiblot a écrit : On 09/04/2018 14:02, Guillaume Gardet wrote: Hi Jaehoon, There are problems with SD card access on Samsung Chromebook (snow) with latest master (and also 2018.05-rc1 and 2018.03). eMMC

Re: [U-Boot] [BUG] snow: mmc: SD card access broken: unable to select a mode

2018-04-09 Thread Jean-Jacques Hiblot
On 09/04/2018 14:02, Guillaume Gardet wrote: Hi Jaehoon, There are problems with SD card access on Samsung Chromebook (snow) with latest master (and also 2018.05-rc1 and 2018.03). eMMC is ok, but SD card access leads to 'unable to select a mode' problem. If I disable HS mode, I can access

Re: [U-Boot] [PATCH v1 0/2] Fix DM_SCSI on DRA7 platforms

2018-04-06 Thread Jean-Jacques Hiblot
On 06/04/2018 14:00, Michal Simek wrote: Hi, On 6.4.2018 11:13, Jean-Jacques Hiblot wrote: Enhancements to SCSI support for driver model have broken the support for DM_SCSI on DRA7 platforms. This series fixes it. Tested on: - dra76 evm Jean-Jacques Hiblot (2): dwc_ahci: Fix breakage

[U-Boot] [PATCH v1 2/2] configs: dra7xx_evm/dra7xx_hs_evm: Enable AHCI and PIPE3

2018-04-06 Thread Jean-Jacques Hiblot
Those options are required to enable support for SATA on DRA7 platforms. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- configs/dra7xx_evm_defconfig| 2 ++ configs/dra7xx_hs_evm_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/dra7xx_evm_defconfig b/c

[U-Boot] [PATCH v1 1/2] dwc_ahci: Fix breakage

2018-04-06 Thread Jean-Jacques Hiblot
The dwc_ahci has been broken for quite some time now. The breakage has been introduced by the series "dm: scsi: Enhance SCSI support for driver model" Use ahci_bind_scsi() and ahci_probe_scsi() to properly bind and probe the driver. Signed-off-by: Jean-Jacques Hiblot <jj

[U-Boot] [PATCH v1 0/2] Fix DM_SCSI on DRA7 platforms

2018-04-06 Thread Jean-Jacques Hiblot
Enhancements to SCSI support for driver model have broken the support for DM_SCSI on DRA7 platforms. This series fixes it. Tested on: - dra76 evm Jean-Jacques Hiblot (2): dwc_ahci: Fix breakage configs: dra7xx_evm/dra7xx_hs_evm: Enable AHCI and PIPE3 configs/dra7xx_evm_defconfig| 2

[U-Boot] [PATCH v3 00/10] Add support for DM_USB for TI's DRA7 EVMs and AM57 EVMs platforms

2018-03-27 Thread Jean-Jacques Hiblot
e children of ocp2scp@4a08, and one to disable USB1 on all DRA7 EVMs - Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed) is supported. Jean-Jacques Hiblot (8): syscon: dm: Add a new method to get a regmap from

[U-Boot] [PATCH v3 09/10] configs: enable DM_USB for all the platforms of the DRA7 family

2018-03-26 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v3: None Changes in v2: None configs/dra7xx_evm_defconfig| 2 ++ configs/dra7xx_hs_evm_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/dra7xx_e

[U-Boot] [PATCH v3 07/10] dts: dra7x: make ocp2scp@4a080000 compatible with simple-bus

2018-03-26 Thread Jean-Jacques Hiblot
This is required when DM_USB is used, to bind the USB phys. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: None Changes in v2: - split dts changes in 2 commits: one for binding the children of ocp2scp@4a08, and one to disable USB1 on all DRA7 EVMs arch/a

[U-Boot] [PATCH v3 05/10] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-03-26 Thread Jean-Jacques Hiblot
For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v3: None Changes in v2: None board/ti/dra7xx/evm.c | 19 +++ 1 file

[U-Boot] [PATCH v3 06/10] board; ti: am57xx: turn on USB clocks

2018-03-26 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Enable USB clocks in late init stage to support ports under DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: None Changes in v2: - am57xx boards: when DM

[U-Boot] [PATCH v3 03/10] phy: ti-pip3-phy: Add support for USB3 PHY

2018-03-26 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Add support to handle USB3 PHYs present on AM57xx/DRA7xx SoCs. This is needed to move AM57xx to DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: None Changes in v2:

[U-Boot] [PATCH v3 08/10] dts: dra7x: Disable USB1 on all evms

2018-03-26 Thread Jean-Jacques Hiblot
-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: None Changes in v2: - Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files arch/arm/dts/dra7-evm-u-boot.dtsi | 8 arch/arm/dts/dra71-evm-u-boot.dtsi | 9 + arch/arm/dts/dra72-evm-revc-u-boo

[U-Boot] [PATCH v3 04/10] phy: Add a new driver for OMAP's USB2 PHYs

2018-03-26 Thread Jean-Jacques Hiblot
This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: None Changes in v2: - omap-usb2-phy: Implement power_on and power_off callbacks drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile

[U-Boot] [PATCH v3 10/10] configs: am57xx_evm: Enable DM_USB and dependencies

2018-03-26 Thread Jean-Jacques Hiblot
Enable DM_USB for AM57xx based boards. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: None Changes in v2: - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed) is supported. configs/am57xx_evm_defconfig

[U-Boot] [PATCH v3 02/10] usb: omap5: Add glue logic to support DM for USB host

2018-03-26 Thread Jean-Jacques Hiblot
The omap5 uses the dwc3. The dwc3 supports the driver model but it requires some glue logic to load the the driver. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: - use the live tree API in the omap5 glue logic Changes in v2: None drivers/usb/host/K

[U-Boot] [PATCH v3 01/10] syscon: dm: Add a new method to get a regmap from DTS

2018-03-26 Thread Jean-Jacques Hiblot
syscon_regmap_lookup_by_phandle() can be used to the regmap of a syscon device from a reference in the DTS. It operates similarly to the linux version of the namesake function. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v3: - in syscon_regmap_lookup_by_phandle(

Re: [U-Boot] [PATCH v2 04/10] phy: Add a new driver for OMAP's USB2 PHYs

2018-03-14 Thread Jean-Jacques Hiblot
On 14/03/2018 18:02, Patrice CHOTARD wrote: Hi Jean Jacques On 03/14/2018 05:18 PM, Jean-Jacques Hiblot wrote: This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - omap-usb2-phy: Implement po

[U-Boot] [PATCH v2 00/10] Add support for DM_USB for TI's DRA7 EVMs and AM57 EVMs platforms

2018-03-14 Thread Jean-Jacques Hiblot
uper speed) is supported. Jean-Jacques Hiblot (7): syscon: dm: Add a new method to get a regmap from DTS usb: omap5: Add glue logic to support DM for USB host phy: Add a new driver for OMAP's USB2 PHYs board: ti: dra7xx-evm: turn on USB clocks in late init stage dts: dra7x: make ocp2sc

[U-Boot] [PATCH v2 10/10] configs: am57xx_evm: Enable DM_USB and dependencies

2018-03-14 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Enable DM_USB for AM57xx based boards. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - Enable DM_USB in am57xx_evm_defconfig. USB3 (super speed) is supported. configs/am

[U-Boot] [PATCH v2 07/10] dts: dra7x: make ocp2scp@4a080000 compatible with simple-bus

2018-03-14 Thread Jean-Jacques Hiblot
This is required when DM_USB is used, to bind the USB phys. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - split dts changes in 2 commits: one for binding the children of ocp2scp@4a08, and one to disable USB1 on all DRA7 EVMs arch/arm/dts/omap5-u-boo

[U-Boot] [PATCH v2 09/10] configs: enable DM_USB for all the platforms of the DRA7 family

2018-03-14 Thread Jean-Jacques Hiblot
Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v2: None configs/dra7xx_evm_defconfig| 2 ++ configs/dra7xx_hs_evm_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configs/dra7xx_evm_defconf

[U-Boot] [PATCH v2 08/10] dts: dra7x: Disable USB1 on all evms

2018-03-14 Thread Jean-Jacques Hiblot
-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - Instead of disabling USB1 port in dts files, use *-u-boot.dtsi files arch/arm/dts/dra7-evm-u-boot.dtsi | 8 arch/arm/dts/dra71-evm-u-boot.dtsi | 8 arch/arm/dts/dra72-evm-revc-u-boot.dtsi | 8

[U-Boot] [PATCH v2 06/10] board; ti: am57xx: turn on USB clocks

2018-03-14 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Enable USB clocks in late init stage to support ports under DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - am57xx boards: when DM_USB is used, turn on the required

[U-Boot] [PATCH v2 04/10] phy: Add a new driver for OMAP's USB2 PHYs

2018-03-14 Thread Jean-Jacques Hiblot
This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - omap-usb2-phy: Implement power_on and power_off callbacks drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile| 1 + drivers/phy/oma

[U-Boot] [PATCH v2 05/10] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-03-14 Thread Jean-Jacques Hiblot
For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> Reviewed-by: Tom Rini <tr...@konsulko.com> --- Changes in v2: None board/ti/dra7xx/evm.c | 19 +++ 1 file changed, 19 inserti

[U-Boot] [PATCH v2 03/10] phy: ti-pip3-phy: Add support for USB3 PHY

2018-03-14 Thread Jean-Jacques Hiblot
From: Vignesh R <vigne...@ti.com> Add support to handle USB3 PHYs present on AM57xx/DRA7xx SoCs. This is needed to move AM57xx to DM_USB. Signed-off-by: Vignesh R <vigne...@ti.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: - Add USB3 support to t

[U-Boot] [PATCH v2 02/10] usb: omap5: Add glue logic to support DM for USB host

2018-03-14 Thread Jean-Jacques Hiblot
The omap5 uses the dwc3. The dwc3 supports the driver model but it requires some glue logic to load the the driver. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: None drivers/usb/host/Kconfig | 10 + drivers/usb/host/Makefile | 1 + d

[U-Boot] [PATCH v2 01/10] syscon: dm: Add a new method to get a regmap from DTS

2018-03-14 Thread Jean-Jacques Hiblot
syscon_regmap_lookup_by_phandle() can be used to the regmap of a syscon device from a reference in the DTS. It operates similarly to the linux version of the namesake function. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: None drivers/core/syscon-uclass.

Re: [U-Boot] [PATCH 1/2] mmc: add HS400 support

2018-03-06 Thread Jean-Jacques Hiblot
On 06/03/2018 02:46, Peng Fan wrote: Hi, On Mon, Mar 05, 2018 at 05:29:08PM +0100, Jean-Jacques Hiblot wrote: Hi Peng, I'm glad you are adding HS400 support. Thanks. On 05/03/2018 10:11, Peng Fan wrote: Add HS400 support. Selecting HS400 needs first select HS199 according to spec, so use

Re: [U-Boot] [PATCH 1/2] mmc: add HS400 support

2018-03-05 Thread Jean-Jacques Hiblot
of EXT_CSD_CARD_TYPE, using all the 8 bits. Signed-off-by: Peng Fan <peng@nxp.com> Cc: Jaehoon Chung <jh80.ch...@samsung.com> Cc: Jean-Jacques Hiblot <jjhib...@ti.com> Cc: Stefano Babic <sba...@denx.de> Cc: Simon Glass <s...@chromium.org> Cc: Kishon Vijay Abraham

Re: [U-Boot] [PATCH v1 3/6] phy: Add a new driver for OMAP's USB2 PHYs

2018-03-05 Thread Jean-Jacques Hiblot
On 05/03/2018 12:56, Vignesh R wrote: Hi, On Friday 05 January 2018 07:20 PM, Jean-Jacques Hiblot wrote: This drivers supports the USB2 PHY found on omap5 and dra7 SOCs. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- drivers/phy/Kconfig | 8 ++ drivers/phy/Ma

[U-Boot] [PATCH v1 4/4] ARM: dts: dra7x: Make pinctrl and IOdelays for MMC2 available in SPL

2018-02-27 Thread Jean-Jacques Hiblot
The SPL can't use high speed MMC modes if the associated pinctrl and IOdelays are described in the DTS. Make them available in SPL by tagging the nodes with 'u-boot,dm-spl;' Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- arch/arm/dts/dra7-evm-u-boot.dtsi

[U-Boot] [PATCH v1 2/4] ARM: dts: dra76-evm: shift to using common IOdelay data

2018-02-27 Thread Jean-Jacques Hiblot
Now that we have a device-tree include file with common MMC/SD IOdelay data for DRA76x SoC, shift the EVM device-tree file to using that. Also fix the name of the IO voltage regulator for mmc1. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- arch/arm/dts/dra76-evm.dt

[U-Boot] [PATCH v1 1/4] ARM: dts: dra76x: create a common file with MMC/SD IOdelay data

2018-02-27 Thread Jean-Jacques Hiblot
. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- arch/arm/dts/dra76x-mmc-iodelay.dtsi | 285 +++ 1 file changed, 285 insertions(+) create mode 100644 arch/arm/dts/dra76x-mmc-iodelay.dtsi diff --git a/arch/arm/dts/dra76x-mmc-iodelay.dtsi b/arch/a

[U-Boot] [PATCH v1 3/4] configs: dra7xx_evm: Enable support for the HS200 mmc mode in the SPL

2018-02-27 Thread Jean-Jacques Hiblot
to remove only clocks and interrupts properties. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- configs/dra7xx_evm_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig index 1cc614f..2b83a0c 100644 --- a/c

[U-Boot] [PATCH v1 0/4] DRA7x: add support for HS200 in SPL

2018-02-27 Thread Jean-Jacques Hiblot
. This series has been tested on: - dra76-evm - dra7-evm - dra72-evm rev C - dra71-evm Jean-Jacques Hiblot (4): ARM: dts: dra76x: create a common file with MMC/SD IOdelay data ARM: dts: dra76-evm: shift to using common IOdelay data configs: dra7xx_evm: Enable support for the HS200 mmc mode

Re: [U-Boot] [PATCH v1 1/4] mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat

2018-02-26 Thread Jean-Jacques Hiblot
On 23/02/2018 21:59, Simon Glass wrote: Hi Jean-Jacques, On 22 February 2018 at 03:25, Jean-Jacques Hiblot <jjhib...@ti.com> wrote: The area for struct mmc can be allocated dynamically. It greatly reduces the size of struct omap_hsmmc_plat. This is useful in cases where the board leve

Re: [U-Boot] [PATCH v2 3/4] mmc: omap_hsmmc: make it possible to compile out ADMA support

2018-02-23 Thread Jean-Jacques Hiblot
On 23/02/2018 13:21, Tom Rini wrote: On Fri, Feb 23, 2018 at 10:40:18AM +0100, Jean-Jacques Hiblot wrote: Some platforms don't have ADMA controllers. For those platforms, compiling it out reduces the size of the binary by about 600 bytes. Leaving the support in doesn't break things

[U-Boot] [PATCH v2 1/4] mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat

2018-02-23 Thread Jean-Jacques Hiblot
. Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: None arch/arm/include/asm/omap_mmc.h | 2 +- drivers/mmc/omap_hsmmc.c| 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/omap_mmc.h b/arch/arm/include/asm/omap_mmc.h

[U-Boot] [PATCH v2 0/4] mmc: omap_hsmmc: Reduce the footprint of the driver and fix am335x clock

2018-02-23 Thread Jean-Jacques Hiblot
), and dra7 evm Changes in v2: - Use a Kconfig option to compile out the ADMA support instead of relying on the platform architecture Jean-Jacques Hiblot (4): mmc: omap_hsmmc: do not embed struct mmc in struct omap_hsmmc_plat mmc: omap_hsmmc: compile out write support if not needed mmc: omap_hsmmc

[U-Boot] [PATCH v2 4/4] mmc: omap_hsmmc: use a default 52MHz max clock rate if none is specified

2018-02-23 Thread Jean-Jacques Hiblot
mmc_of_parse() doesn't set a default value if none is available in DT. In that case, use a default 52MHz clock rate. Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> Signed-off-by: Jean-Jacques Hiblot <jjhib...@ti.com> --- Changes in v2: None drivers/mmc/omap_hsmmc.c |

<    4   5   6   7   8   9   10   11   12   13   >