Re: [U-Boot] [PATCH 1/1] net: nfs: remove superfluous conversions

2019-09-03 Thread Joe Hershberger
ing them to memcpy(). > > In ntohl(data[1]) != 0 calling ntohl() is superfluous. If the value is > zero, does not depend on the byte order. > > Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@li

Re: [U-Boot] [PATCH 1/1] env: net: U_BOOT_ENV_CALLBACKs should not depend on CMD_NET

2019-09-03 Thread Joe Hershberger
etwork > sub-system. > > In the UEFI subsystem we can use the network even if CONFIG_CMD_NET is not > defined. > > Let the usage of the U_BOOT_ENV_CALLBACKs depend on CONFIG_NET and not on > CONFIG_CMD_NET. > > Signed-off-by: Heinrich

Re: [U-Boot] [PATCH v2 5/5] CVE-2019-14196: nfs: fix unbounded memcpy with a failed length check at nfs_lookup_reply //RE: [PATCH 5/5] CVE-2019-14196: nfs: fix unbounded memcpy with a failed length ch

2019-09-03 Thread Joe Hershberger
length check at > nfs_lookup_reply > > This patch adds a check to rpc_pkt.u.reply.data at nfs_lookup_reply. > > Signed-off-by: Cheng Liu > Reported-by: Fermín Serna Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v2 4/5] CVE-2019-14195: nfs: fix unbounded memcpy with unvalidated length at nfs_readlink_reply //RE: [PATCH 4/5] CVE-2019-14195: nfs: fix unbounded memcpy with unvalidated length

2019-09-03 Thread Joe Hershberger
dated length at > nfs_readlink_reply > > This patch adds a check to rpc_pkt.u.reply.data at nfs_readlink_reply. > > Signed-off-by: Cheng Liu > Reported-by: Fermín Serna Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.

Re: [U-Boot] [PATCH v2 3/5] CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded memcpy with a failed length check at nfs_read_reply //RE: [PATCH 3/5] CVE-2019-14194/CVE-2019-14198: nfs: fix unbounded me

2019-09-03 Thread Joe Hershberger
y with a failed length > check at nfs_read_reply > > This patch adds a check to rpc_pkt.u.reply.data at nfs_read_reply. > > Signed-off-by: Cheng Liu > Reported-by: Fermín Serna Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@li

Re: [U-Boot] [PATCH v2 1/5] CVE: net: fix unbounded memcpy of UDP packet//RE: [PATCH 1/5] CVE: net: fix unbounded memcpy of UDP packet

2019-09-03 Thread Joe Hershberger
packet > > This patch adds a check to udp_len to fix unbounded memcpy for > CVE-2019-14192, CVE-2019-14193 and CVE-2019-14199. > > Signed-off-by: Cheng Liu > Reviewed-by: Simon Goldschmidt > Reported-by: Fermín Serna Acked-by: Joe Hershberger _

Re: [U-Boot] [PATCH v2 2/5] CVE: nfs: fix stack-based buffer overflow in some nfs_handler reply helper functions //RE: [PATCH 2/5] CVE: nfs: fix stack-based buffer overflow in some nfs_handler reply h

2019-09-03 Thread Joe Hershberger
s_handler reply helper > functions > > This patch adds a check to nfs_handler to fix buffer overflow for > CVE-2019-14197, > CVE-2019-14200, CVE-2019-14201, CVE-2019-14202, CVE-2019-14203 and > CVE-2019-14204. > > Signed-off-by: Cheng Liu > Reported-by

Re: [U-Boot] [BUG] include/net.h: warning: 'eth_is_on_demand_init' defined but not used

2019-09-03 Thread Joe Hershberger
Hi Heinrich, On Fri, Aug 30, 2019 at 12:21 PM Heinrich Schuchardt wrote: > > Hello Joe, > > compiling U-Boot creates dozens of warnings for include/net.h: > >CC arch/arm/lib/asm-offsets.s > In file included from include/common.h:342, > from lib/asm-offsets.c:14: > inclu

Re: [U-Boot] [PATCH 1/2] net: dwc_eth_qos: Change eqos_ops function to static

2019-08-15 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 4:31 AM Patrick Delaunay wrote: > > This patch solves many warnings when compiling with W=1: > warning: no previous prototype for '' [-Wmissing-prototypes] > > Signed-off-by: Patrice Chotard > Signed-off-by: Patrick Delaunay

Re: [U-Boot] [U-Boot-Custodians] RFC: Migration target date for DM_ETH

2019-08-14 Thread Joe Hershberger
Hi Heinrich, On Fri, Aug 9, 2019 at 4:41 PM Heinrich Schuchardt wrote: > > On 8/9/19 7:02 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Fri, 9 Aug 2019 at 00:31, Heinrich Schuchardt wrote: > >> > >> Currently dozens of boards still do not use the driver model for the > >> network devices. T

Re: [U-Boot] [PATCH] Revert "net: macb: Fixed reading MII_LPA register"

2019-08-14 Thread Joe Hershberger
MII_LPA register") > causes 100Mbps does not work any more with SiFive FU540 GEM on the > HiFive Unleashed board. Revert it. > > Signed-off-by: Bin Meng Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/7] net: mvpp2: Replace SMI implementation with marvell MDIO API

2019-08-14 Thread Joe Hershberger
On Wed, Aug 14, 2019 at 12:09 PM Nevo Hed wrote: > > On Wed, Aug 14, 2019 at 11:39 AM Joe Hershberger > wrote: > > > > On Fri, Aug 2, 2019 at 12:54 PM wrote: > > > > > > From: Ken Ma > > > > > > > - > > > -static int m

Re: [U-Boot] [PATCH v3 1/7] net: mvpp2x: fix traffic stuck after PHY start error

2019-08-14 Thread Joe Hershberger
t initiation. > > Signed-off-by: Stefan Chulski > Reviewed-by: Igal Liberman > Tested-by: Igal Liberman Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 6/7] net: mvpp2: use new MVMDIO driver

2019-08-14 Thread Joe Hershberger
t; that is based on a more universal mdio-uclass implementation. > > Signed-off-by: Nevo Hed You are missing Ramon's review tag in v3. Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 5/7] arm: dts: armada-cp110-*dtsi: add xmdio nodes

2019-08-14 Thread Joe Hershberger
ls own repo bump it > to 0x200 (512) bytes but I did not see the reasoning for that. > > https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/4d932b4. > > Also added device-name attributes to prevent ambiguity in the `mdio` > command. > > Sig

Re: [U-Boot] [PATCH 1/7] net: mvpp2x: fix traffic stuck after PHY start error

2019-08-14 Thread Joe Hershberger
On Wed, Aug 14, 2019 at 10:36 AM Joe Hershberger wrote: > > On Fri, Aug 2, 2019 at 12:54 PM wrote: > > > > From: Stefan Chulski > > > > Issue: > > - Network stuck if autonegotion fails > > > > Issue root cause: > > - During port

Re: [U-Boot] [PATCH v3 7/7] net: mvpp2: MVPP2 now needs MVMDIO

2019-08-14 Thread Joe Hershberger
On Tue, Aug 6, 2019 at 10:52 AM wrote: > > From: Nevo Hed > > Changes to mvpp2.c require the MVMDIO module which in turn uses > DM_MDIO. > > Signed-off-by: Nevo Hed Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH 4/7] net: mvpp2: no deref null

2019-08-14 Thread Joe Hershberger
On Fri, Aug 2, 2019 at 12:54 PM wrote: > > From: Nevo Hed > > phy_dev ptr is set from return of phy_connect() and is used before > test to see if NULL. Obviously since the test already sxists someoen > made the determination that this NULL is possible. > > Signed-off-by: Nevo Hed > --- > > dri

Re: [U-Boot] [PATCH 3/7] net: mvpp2: mark phy as invalid in case of missing appropriate driver

2019-08-14 Thread Joe Hershberger
On Fri, Aug 2, 2019 at 12:54 PM wrote: > > From: Grzegorz Jaszczyk > > If the phy doesn't match with any existing u-boot drivers the phy > framework will connect it to generic one which uid == 0x. In > this case act as if the phy wouldn't be declared in dts. Otherwise in > case of 3310 (f

Re: [U-Boot] [PATCH 2/7] net: mvpp2: Replace SMI implementation with marvell MDIO API

2019-08-14 Thread Joe Hershberger
On Fri, Aug 2, 2019 at 12:54 PM wrote: > > From: Ken Ma > > Since marvell MDIO driver is added, SMI function implementation in > mvpp2 driver can be removed and NETA driver can use marvell MDIO API > directly. > This replacement also fixes 2 old issues: > 1. Each pp2 port device should have its o

Re: [U-Boot] [PATCH 1/7] net: mvpp2x: fix traffic stuck after PHY start error

2019-08-14 Thread Joe Hershberger
On Fri, Aug 2, 2019 at 12:54 PM wrote: > > From: Stefan Chulski > > Issue: > - Network stuck if autonegotion fails > > Issue root cause: > - During port open procedure if autonegotion fails, configuration of > packet processor won't be finished and open procedure exits with error. > - However t

Re: [U-Boot] [PATCH 2/7] net: sh_eth: Fix 64bit build warnings

2019-08-14 Thread Joe Hershberger
On Wed, Jul 31, 2019 at 10:25 AM Marek Vasut wrote: > > Fix various type warnings when building this driver for 64bit machine. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Nobuhiro Iwamatsu Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH 1/7] net: sh_eth: Add R8A77980 V3H gether support

2019-08-14 Thread Joe Hershberger
On Wed, Jul 31, 2019 at 10:25 AM Marek Vasut wrote: > > The R8A77980 V3H gether needs a few minor adjustments to the sh_eth > driver, add them to support ethernet on R8A77980. > > Signed-off-by: Marek Vasut > Cc: Joe Hershberger > Cc: Nobuhiro Iwamatsu Acke

Re: [U-Boot] [PATCH 1/1] network: set timeline for CONFIG_DM_ETH conversion

2019-08-12 Thread Joe Hershberger
On Fri, Aug 9, 2019 at 5:11 PM Heinrich Schuchardt wrote: > > The driver model has been supported for network drivers since 2015. It is > time to convert the remaining boards. Set July 2020 as a timeline. > > Signed-off-by: Heinrich Schuchardt Acked-by:

Re: [U-Boot] drivers: net: driver for MDIO muxes controlled over I2C

2019-08-09 Thread Joe Hershberger
On Thu, Aug 8, 2019 at 3:16 PM Alex Marginean wrote: > > Hi Joe, > > On 7/25/2019 9:41 PM, Joe Hershberger wrote: > > Hi Alex, > > > > https://patchwork.ozlabs.org/patch/1132514/ was applied to > > http://git.denx.de/?p=u-boot/u-boot-net.git > > can

Re: [U-Boot] [PATCH v3 32/40] env: Drop _ENTRY

2019-08-02 Thread Joe Hershberger
On Fri, Aug 2, 2019 at 10:46 AM Simon Glass wrote: > > This typedef does not need to be defined in the search.h header since it > is only used in one file (hashtable.c). Remove it from the header and > change it to a struct. > > Signed-off-by: Simon Glass Acked-b

Re: [U-Boot] [PATCH v2 34/40] env: Drop the ACTION typedef

2019-08-02 Thread Joe Hershberger
o that it is clear what they relate > to. Also move them to env.h since they are part of the public API. Use an > enum rather than a #define to tie them together. > > Signed-off-by: Simon Glass Acked-by :Joe Hershberger ___ U-Boot mailing list U-

Re: [U-Boot] [PATCH v3 00/40] env: common: Remove environment definitions from common.h

2019-08-02 Thread Joe Hershberger
On Fri, Aug 2, 2019 at 10:44 AM Simon Glass wrote: > > At present common.h has a lot of uncommon declarations in it. Many of > these would be better placed elsewhere, in header files more related to > their purpose. In particular the environnment functions should move to > the environment headers.

Re: [U-Boot] [PATCH v2 19/40] env: net: Move eth_parse_enetaddr() to net.c/h

2019-08-02 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 10:57 AM Simon Glass wrote: > > This function fits better with the network subsystem, so move it. > > Signed-off-by: Simon Glass > Suggested-by: Joe Hershberger Acked-by :Joe Hershberger ___ U-Boot mail

Re: [U-Boot] [PATCH v2 20/40] env: Move env_fix_drivers() to env.h

2019-08-02 Thread Joe Hershberger
On Thu, Aug 1, 2019 at 10:55 AM Simon Glass wrote: > > Move this function over to the new header file. > > Signed-off-by: Simon Glass Acked-by :Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 32/39] env: Rename the redundancy flags

2019-07-31 Thread Joe Hershberger
Hi Tom, On Wed, Jul 31, 2019 at 7:53 PM Tom Rini wrote: > > On Wed, Jul 31, 2019 at 09:20:58PM +0000, Joe Hershberger wrote: > > On Wed, Jul 31, 2019 at 4:00 PM Simon Glass wrote: > > > > > > Hi Joe, > > > > > > On Tue, 30 Jul 2019 at 15:42, Joe H

Re: [U-Boot] [PATCH 31/39] env: Drop _ENTRY

2019-07-31 Thread Joe Hershberger
On Wed, Jul 31, 2019 at 4:56 PM Simon Glass wrote: > > Hi, > > On Wed, 31 Jul 2019 at 15:07, Joe Hershberger wrote: > > > > On Wed, Jul 31, 2019 at 3:57 PM Simon Glass wrote: > > > > > > Hi Joe, > > > > > > On Tue, 30 Jul 2019 at 15:35

Re: [U-Boot] [PATCH 32/39] env: Rename the redundancy flags

2019-07-31 Thread Joe Hershberger
On Wed, Jul 31, 2019 at 4:00 PM Simon Glass wrote: > > Hi Joe, > > On Tue, 30 Jul 2019 at 15:42, Joe Hershberger wrote: > > > > On Sun, Jul 28, 2019 at 9:27 AM Simon Glass wrote: > > > > > > Add an ENV prefix to these two flags so that it is clear wh

Re: [U-Boot] [PATCH 31/39] env: Drop _ENTRY

2019-07-31 Thread Joe Hershberger
On Wed, Jul 31, 2019 at 3:57 PM Simon Glass wrote: > > Hi Joe, > > On Tue, 30 Jul 2019 at 15:35, Joe Hershberger wrote: > > > > On Sun, Jul 28, 2019 at 9:28 AM Simon Glass wrote: > > > > > > This typedef does not need to be defined in the search.h head

Re: [U-Boot] [PATCH v2 1/1] test: dm_mdio: avoid out of bounds access

2019-07-30 Thread Joe Hershberger
uot;) > Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] drivers: net: pfe_eth: undefined return value

2019-07-30 Thread Joe Hershberger
On Tue, Jul 30, 2019 at 5:01 PM Heinrich Schuchardt wrote: > > Do not use random value from stack as return value of pfe_phy_write(). > > Indicated by cppcheck. > > Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger ___ U

Re: [U-Boot] [PATCH v2] net: mvpp2: support setting hardware addresses from ethernet core

2019-07-30 Thread Joe Hershberger
onment are correctly applied before Linux boots. > > Signed-off-by: Matt Pelland Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/2] net: Fix Covarity Defect 244093

2019-07-30 Thread Joe Hershberger
Don't allow unterminated strings Signed-off-by: Joe Hershberger --- net/mdio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mdio-uclass.c b/net/mdio-uclass.c index 36a404ff44..1c0d25272a 100644 --- a/net/mdio-uclass.c +++ b/net/mdio-uclass.c @@ -75,7

[U-Boot] [PATCH 2/2] net: mdio: Clarify code flow Covarity 244085 & 244090

2019-07-30 Thread Joe Hershberger
Document that the lack of breaks is intentional. Signed-off-by: Joe Hershberger --- cmd/mdio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/mdio.c b/cmd/mdio.c index add6440813..22c8fbe856 100644 --- a/cmd/mdio.c +++ b/cmd/mdio.c @@ -253,12 +253,13 @@ static int

Re: [U-Boot] [PATCH 32/39] env: Rename the redundancy flags

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:27 AM Simon Glass wrote: > > Add an ENV prefix to these two flags so that it is clear what they relate > to. Also move them to env.h since they are part of the public API. Use an > enum rather than a #define to tie them together. > > Signed-off-by: Simon Glass > --- > >

Re: [U-Boot] [PATCH 31/39] env: Drop _ENTRY

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:28 AM Simon Glass wrote: > > This typedef does not need to be defined in the search.h header since it > is only used in one file (hashtable.c). Remove it from the header and > change it to a struct. > > Signed-off-by: Simon Glass > --- > > include/search.h | 2 +- > lib

Re: [U-Boot] [PATCH 34/39] env: Drop the double underscores in search.h

2019-07-30 Thread Joe Hershberger
' as well. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 29/39] env: Move callback definitions to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:28 AM Simon Glass wrote: > > These definitions are effectively part of the 'public' API of the > environment implementation since they do not require access to any > internal variables. Move them to the env.h header. > > Signed-off-by:

Re: [U-Boot] [PATCH 27/39] env: Rename environment to embedded_environment

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:29 AM Simon Glass wrote: > > The name 'environment' is widely used in U-Boot so is not a very useful > name of a variable. Rename it to better indicate its purpose. > > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 26/39] env: Move env_reloc() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:29 AM Simon Glass wrote: > > Move env_reloc() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 23/39] env: Drop env_crc_update()

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:27 AM Simon Glass wrote: > > This function is not defined or used in U-Boot. Drop it. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.d

Re: [U-Boot] [PATCH 25/39] env: Move env_get_char() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:26 AM Simon Glass wrote: > > Move env_get_char() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 36/39] env: Drop environment.h header file where not needed

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:24 AM Simon Glass wrote: > > This header file is now only used by files that access internal > environment features. Drop it from various places where it is not needed. > > Signed-off-by: Simon Glass Acked-by:

Re: [U-Boot] [PATCH 16/39] env: Move env_set() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:24 AM Simon Glass wrote: > > Move env_set() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 30/39] env: Drop the ENTRY typdef

2019-07-30 Thread Joe Hershberger
ypedef and rename the struct to env_entry to reduce confusion. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 35/39] env: Move TOTAL_MALLOC_LEN to environment.h

2019-07-30 Thread Joe Hershberger
header must be included anyway, for TOTAL_MALLOC_LEN to be > correct. > > Nove it to environment.h to simplify the common file. Nove -> Move > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@li

Re: [U-Boot] [PATCH 33/39] env: Drop the ACTION typedef

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:22 AM Simon Glass wrote: > > Avoid using a typedef here which is unnecessary. Add an 'env_' prefix to > both the enum and its members to make it clear that these are related to > the environment. > > Add an ENV prefix to these two flags so that it is clear what they relat

Re: [U-Boot] [PATCH 12/39] env: Move env_set_ulong() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:22 AM Simon Glass wrote: > > Move env_set_ulong() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 17/39] env: Move env_get() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:22 AM Simon Glass wrote: > > Move env_get() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 37/39] env: Rename environment.h to env_internal.h

2019-07-30 Thread Joe Hershberger
nature. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 10/39] env: Move envmatch() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:15 AM Simon Glass wrote: > > Move envmatch() over to the new header file. Also rename it to env_match() > to better line up with other functions. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___

Re: [U-Boot] [PATCH 19/39] env: Move uncommon functions to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:21 AM Simon Glass wrote: > > Move eth_parse_enetaddr() and env_fix_drivers() over to the new header > file. > > Signed-off-by: Simon Glass > --- > > cmd/ethsw.c | 1 + > include/env.h | 16 > include/environment.h | 7 --- > 3 fi

Re: [U-Boot] [PATCH 20/39] env: Move set_default_vars to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:21 AM Simon Glass wrote: > > Move this function to the new header file and rename it so it has an env_ > prefix. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@list

Re: [U-Boot] [PATCH 22/39] env: Move env import/export functions to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:20 AM Simon Glass wrote: > > Move these functions to the new header file. > > Signed-off-by: Simon Glass Nit below. Acked-by: Joe Hershberger > > include/env.h | 38 ++ > include/environment.h | 12 --

Re: [U-Boot] [PATCH 21/39] env: Move env_load/save functions to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:19 AM Simon Glass wrote: > > Move these function to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 28/39] env: Move env_valid to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:19 AM Simon Glass wrote: > > This enum is somewhat widely used to determine if the environment is valid > or not. Move it to the common environment header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger __

Re: [U-Boot] [PATCH 18/39] env: Move eth_env_get/set_enetaddr() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:16 AM Simon Glass wrote: > > Move these two functions over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 24/39] env: Move get/set_default_env() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:12 AM Simon Glass wrote: > > Move these functions to the new header file and rename set_default_env() > to env_set_default() so that it has a consistent env_ prefix. > > Signed-off-by: Simon Glass Acked-by:

Re: [U-Boot] [PATCH 13/39] env: Move env_get_ulong() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:09 AM Simon Glass wrote: > > Move env_get_ulong() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 08/39] env: Move env_init() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:16 AM Simon Glass wrote: > > Move env_init() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 05/39] env: Create a new file for environment functions

2019-07-30 Thread Joe Hershberger
used > environment functions, so that most files can avoid including all of this > unnecessary stuff. > > Create a new env.h header and move one function over to it. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mai

Re: [U-Boot] [PATCH 06/39] env: Move get_env_id() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:11 AM Simon Glass wrote: > > Move this function over to the new header file. Also rename it to have an > env_ prefix like the other functions. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Bo

Re: [U-Boot] [PATCH 07/39] env: Move env_get_f() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:11 AM Simon Glass wrote: > > Move this function over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 11/39] env: Move env_set_hex() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:10 AM Simon Glass wrote: > > Move env_set_hex() over to the new header file along with env_set_addr() > which uses it. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH 14/39] env: Move env_get_yesno() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:10 AM Simon Glass wrote: > > Move env_get_yesno() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 15/39] env: Move env_get_hex() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:09 AM Simon Glass wrote: > > Move env_get_hex() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 09/39] env: Move env_relocate() to env.h

2019-07-30 Thread Joe Hershberger
On Sun, Jul 28, 2019 at 9:09 AM Simon Glass wrote: > > Move env_relocate() over to the new header file. > > Signed-off-by: Simon Glass Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices

2019-07-29 Thread Joe Hershberger
27;indirect mii' bus for easier PHY register > access by 'mii' command. > > Signed-off-by: Anatolij Gustschin > Reviewed-by: Chris Packham > Tested-by: Chris Packham Acked-by: Joe Hershberger Nit below. > --- > drivers/net/phy/mv88e61xx.c | 113 +

Re: [U-Boot] [PATCH v3 5/6] net: phy: mv88e61xx: register phy_driver struct for 88E6071

2019-07-29 Thread Joe Hershberger
On Mon, Jul 29, 2019 at 2:02 PM Anatolij Gustschin wrote: > > Support probing and init for 88E6071 switch. > > Signed-off-by: Anatolij Gustschin > Reviewed-by: Chris Packham > Tested-by: Chris Packham Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH v3 3/6] net: phy: mv88E61xx: fix ENERGY_DET init for mv88E6071

2019-07-29 Thread Joe Hershberger
t; > Signed-off-by: Anatolij Gustschin > Reviewed-by: Chris Packham > Tested-by: Chris Packham Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/6] net: phy: mv88e61xx: add CPU port parameter init for 88E6071

2019-07-29 Thread Joe Hershberger
for proper port speed > detection on 88E6071. > > Signed-off-by: Anatolij Gustschin > Reviewed-by: Chris Packham > Tested-by: Chris Packham Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 6/6] net: phy: fix switch vendor name

2019-07-29 Thread Joe Hershberger
On Mon, Jul 29, 2019 at 2:02 PM Anatolij Gustschin wrote: > > Fix vendor name in MV88E61xx option description. > > Signed-off-by: Anatolij Gustschin > Reviewed-by: Chris Packham > Tested-by: Chris Packham Acked-by: Joe Hershberger

Re: [U-Boot] [PATCH v2 4/6] net: phy: mv88E61xx: add config option for mv88E6071 support

2019-07-29 Thread Joe Hershberger
On Thu, Jul 25, 2019 at 4:42 PM Anatolij Gustschin wrote: > > On Tue, 23 Jul 2019 04:26:17 +0000 > Joe Hershberger joe.hershber...@ni.com wrote: > ... > > > +config MV88E61XX_88E6020_FAMILY > > > + bool "Marvell MV88E6020 family support." >

Re: [U-Boot] [PATCH v2 00/14] ARM: davinci: driver-model improvements

2019-07-29 Thread Joe Hershberger
On Mon, Jul 29, 2019 at 1:56 AM Bartosz Golaszewski wrote: > > niedz., 28 lip 2019 o 19:12 Tom Rini napisał(a): > > > > On Sun, Jul 28, 2019 at 06:46:57PM +0200, Bartosz Golaszewski wrote: > > > śr., 24 lip 2019 o 21:06 Joe Hershberger > > > napisał(a): >

Re: [U-Boot] Pull request: u-boot-net.git master

2019-07-26 Thread Joe Hershberger
Hi Tom, On Fri, Jul 26, 2019 at 2:38 PM Tom Rini wrote: > > On Thu, Jul 25, 2019 at 01:38:29PM -0500, Joe Hershberger wrote: > > > Hi Tom, > > > > These changes passed Travis-CI here: > > https://travis-ci.org/jhershbe/u-boot/builds/562815175 > >

Re: [U-Boot] [PATCH v2 1/6] net: phy: mv88e61xx: rework to enable detection of 88E6071 devices

2019-07-26 Thread Joe Hershberger
On Fri, Jul 26, 2019 at 9:48 AM Anatolij Gustschin wrote: > > On Tue, 23 Jul 2019 04:07:04 +0000 > Joe Hershberger joe.hershber...@ni.com wrote: > > > > > static int mv88e61xx_phy_wait(struct phy_device *phydev) > > > > { > > > > +

Re: [U-Boot] [PATCH v10 4/4] doc: sifive-fu540: Update README to explicitly load DTB for Linux

2019-07-25 Thread Joe Hershberger
On Mon, Jul 22, 2019 at 2:59 AM Anup Patel wrote: > > We should explicitly load DTB from TFTP server or MMC/SD card > for Linux booting. This will allow us: > 1. To use different Linux DTB for SiFive Unleashed board with >expansion board connected. > 2. Avoid re-flashing OpenSBI firmware whene

Re: [U-Boot] net: sun8i_emac: Test the correct phy

2019-07-25 Thread Joe Hershberger
Hi Emmanuel, https://patchwork.ozlabs.org/patch/1134275/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] riscv: sifive: fu540: Sync-up config header with RISC-V QEMU support

2019-07-25 Thread Joe Hershberger
Hi Anup, https://patchwork.ozlabs.org/patch/1136028/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: macb: Extend MACB driver for SiFive Unleashed board

2019-07-25 Thread Joe Hershberger
Hi Anup, https://patchwork.ozlabs.org/patch/1136027/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133862/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: davinci_emac: convert to using the driver model

2019-07-25 Thread Joe Hershberger
Hi Bartosz, https://patchwork.ozlabs.org/patch/1136121/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Add support for the NXP LS1021A-TSN board

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133867/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] arm: ls1021atwr: Convert to use driver model TSEC driver

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133864/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: macb: apply sane DMA configuration

2019-07-25 Thread Joe Hershberger
Hi Ramon, https://patchwork.ozlabs.org/patch/1132907/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: macb: add support for SGMII phy interface

2019-07-25 Thread Joe Hershberger
Hi Ramon, https://patchwork.ozlabs.org/patch/1132906/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: tsec: Reverse Christmas tree notation

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133861/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: macb: sync header definitions as taken from Linux

2019-07-25 Thread Joe Hershberger
Hi Ramon, https://patchwork.ozlabs.org/patch/1132898/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: macb: add support for faster clk rates

2019-07-25 Thread Joe Hershberger
Hi Ramon, https://patchwork.ozlabs.org/patch/1132908/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: tsec: Fix offset of MDIO registers for DM_ETH

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133860/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: designware: use 'phy_connect' instead of open coded

2019-07-25 Thread Joe Hershberger
Hi Simon, https://patchwork.ozlabs.org/patch/1132238/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: tsec: Common handling of MAC station address for DM_ETH

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133863/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: tsec: Refactor the readout of the tbi-handle property

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133858/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: tsec: Make errors visible

2019-07-25 Thread Joe Hershberger
Hi Vladimir, https://patchwork.ozlabs.org/patch/1133859/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] net: macb: Fix check for little-endian system in gmac_configure_dma()

2019-07-25 Thread Joe Hershberger
Hi Anup, https://patchwork.ozlabs.org/patch/1136029/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

<    1   2   3   4   5   6   7   8   9   10   >