On 26/02/2024 11:07, Varadarajan Narayanan wrote:
> Signed-off-by: Varadarajan Narayanan
> ---
>
> arch/arm/dts/Makefile |2 +
> arch/arm/dts/ipq9574-default.dts | 167 +++
> arch/arm/dts/ipq9574-rdp433-mht-phy.dts | 208 +++
>
On 29/02/2024 15:21, Volodymyr Babchuk wrote:
> Add device tree bindings and actual device trees for SM8150 SoC and
> SA8155P-ADP board. Those files were imported from Linux kernel 6.8-rc5
> as is. In this configuration they will not work with U-Boot for couple
> reasons:
>
Aren't you now
On 11/01/2024 09:48, Michal Simek wrote:
>
>
> On 1/11/24 09:18, Krzysztof Kozlowski wrote:
>> On 11/01/2024 09:10, Michal Simek wrote:
>>>
>>>
>>> On 1/11/24 08:56, Krzysztof Kozlowski wrote:
>>>> On 11/01/2024 08:09, Michal Simek wrote:
&
On 11/01/2024 09:10, Michal Simek wrote:
>
>
> On 1/11/24 08:56, Krzysztof Kozlowski wrote:
>> On 11/01/2024 08:09, Michal Simek wrote:
>>>
>>>
>>> On 1/10/24 22:27, Krzysztof Kozlowski wrote:
>>>> On 10/01/2024 14:35, Michal Simek wr
On 11/01/2024 08:09, Michal Simek wrote:
>
>
> On 1/10/24 22:27, Krzysztof Kozlowski wrote:
>> On 10/01/2024 14:35, Michal Simek wrote:
>>> Move cells to board dtsi files from generic zynqmp.dtsi. Changes are
>>> related to qspi, spi, nand, i2c and e
On 10/01/2024 14:35, Michal Simek wrote:
> Move cells to board dtsi files from generic zynqmp.dtsi. Changes are
> related to qspi, spi, nand, i2c and ethernet nodes.
>
> All errors are generated when dtbs are compiled with W=1.
>
I don't see any errors on some other platforms, like Samsung.
On 26/12/2023 08:53, Sumit Garg wrote:
>>
>> The problem I want to solve is the kernel maintainers to be aware.
>>
>
> Although Tom has already expressed in the other thread that U-Boot has
> been a long time user of upstream DT but if we want to make it more
> formal from an enforcement point of
On 18/12/2023 23:02, Rafał Miłecki wrote:
> On 14.12.2023 22:27, Simon Glass wrote:
>> On Thu, 14 Dec 2023 at 08:36, Rafał Miłecki wrote:
>>>
>>> From: Rafał Miłecki
>>>
>>> So far we had a property for "ethaddr" NVMEM cell containing base
>>> Ethernet MAC address. The problem is vendors often
On 22/12/2023 16:46, Tom Rini wrote:
> On Fri, Dec 22, 2023 at 04:38:01PM +0100, Krzysztof Kozlowski wrote:
>> On 22/12/2023 14:43, Sumit Garg wrote:
>>> On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski
>>> wrote:
>>>>
>>>> On 22/1
On 22/12/2023 16:45, Conor Dooley wrote:
>>>
>>> I suppose we have to relay information to kernel sub-arch maintainers
>>> who aren't the same as maintaining U-Boot counterparts. How about
>>> adding U-Boot ML to CC for whichever DT change gets submitted in the
>>
>> And every other project? Just
On 22/12/2023 14:43, Sumit Garg wrote:
> On Fri, 22 Dec 2023 at 13:48, Krzysztof Kozlowski
> wrote:
>>
>> On 22/12/2023 07:12, Sumit Garg wrote:
>>> Changes in v2:
>>> --
>>> - Patch #1: excluded gitab CI config check and added commit
On 22/12/2023 07:12, Sumit Garg wrote:
> Changes in v2:
> --
> - Patch #1: excluded gitab CI config check and added commit description.
> - Patch #3: s/UBOOT_DTSI_LOC/u_boot_dtsi_loc/
> - Patch #4: s/DEVICE_TREE_LOC/dt_dir/ and s/U-boot/U-Boot/
> - Patch #5: s/U-boot/U-Boot/
> - Patch
On 14/12/2023 20:48, Rob Herring wrote:
>>
>> I think some of the important questions to ask are, how often / likely
>> are the breakages to occur? It seems like these days it's either:
>> - U-Boot had an early version of the binding and we already state we
>> don't support backwards
On 05/12/2023 10:45, Sumit Garg wrote:
> + U-boot custodians list
>
> On Tue, 5 Dec 2023 at 12:58, Krzysztof Kozlowski
> wrote:
>>
>> On 05/12/2023 08:13, Sumit Garg wrote:
>>>>> @DT bindings maintainers,
>>>>>
>>>>> Given th
On 05/12/2023 08:13, Sumit Garg wrote:
>>> @DT bindings maintainers,
>>>
>>> Given the ease of maintenance of DT bindings within Linux kernel
>>> source tree, I don't have a specific objection there. But can we ease
>>> DTS testing for firmware/bootloader projects by providing a versioned
>>>
On 04/12/2023 15:38, ff wrote:
>
>
>> Le 4 déc. 2023 à 12:00, Daniel Thompson a écrit
>> :
>>
>> On Mon, Dec 04, 2023 at 11:02:57AM +0530, Sumit Garg wrote:
>>> + Linux kernel DT bindings maintainers, EBBR ML
>>>
On Thu, 30 Nov 2023 at 20:05, Tom Rini wrote:
On Thu, Nov 30, 2023 at
On 04/12/2023 14:24, Sumit Garg wrote:
> On Mon, 4 Dec 2023 at 16:30, Daniel Thompson
> wrote:
>>
>> On Mon, Dec 04, 2023 at 11:02:57AM +0530, Sumit Garg wrote:
>>> + Linux kernel DT bindings maintainers, EBBR ML
>>>
>>> On Thu, 30 Nov 2023 at 20:05, Tom Rini wrote:
On Thu, Nov 30, 2023 at
On 21/09/2023 20:45, Simon Glass wrote:
> Binman[1] is a tool for creating firmware images. It allows you to
> combine various binaries and place them in an output file.
>
> Binman uses a DT schema to describe an image, in enough detail that
> it can be automatically built from component parts,
On 03/05/2023 18:26, Tom Rini wrote:
I think we do not review U-Boot bindings usually, except these put in
the Linux kernel. There were few targeting U-Boot specifically (e.g.
Documentation/devicetree/bindings/mtd/partitions/u-boot.yaml and
On 03/05/2023 16:51, Nishanth Menon wrote:
> On 20:17-20230503, Udit Kumar wrote:
>> Mark atf, l3-cache and tifs node as reserved.
>
> why? (I am not reading the cover-letter for a 1 patch)
And you should not have to. :) The commit msg should explain why it is
useful.
Best regards,
Krzysztof
On 03/05/2023 16:37, Ilias Apalodimas wrote:
> Hi Krzysztof,
>
> On Tue, Apr 11, 2023 at 07:38:11AM +0200, Krzysztof Kozlowski wrote:
>> On 11/04/2023 01:21, jaswinder.si...@linaro.org wrote:
>>> From: Jassi Brar
>>>
>>> Any requirement of FWU should no
On 17/04/2023 10:56, Neha Malcom Francis wrote:
> Hi Krzysztof
>
> On 14/04/23 17:10, Krzysztof Kozlowski wrote:
>> On 14/04/2023 12:52, Neha Malcom Francis wrote:
>>> Document the binding for TI K3 ESM (Error Signaling Module) block.
>>>
>&
On 14/04/2023 12:52, Neha Malcom Francis wrote:
> Document the binding for TI K3 ESM (Error Signaling Module) block.
>
> Signed-off-by: Neha Malcom Francis
> ---
> .../devicetree/bindings/misc/esm-k3.yaml | 54 +++
> 1 file changed, 54 insertions(+)
> create mode 100644
On 11/04/2023 01:21, jaswinder.si...@linaro.org wrote:
> From: Jassi Brar
>
> Any requirement of FWU should not require changes to bindings
> of other subsystems. For example, for mtd-backed storage we
> can do without requiring 'fixed-partitions' children to also
> carry 'uuid', a property
On 09/12/2022 16:19, Michal Simek wrote:
> cdns prefix was deprecated and replaced by xlnx one.
>
> Signed-off-by: Michal Simek
> ---
>
> Link:
> https://lore.kernel.org/r/20220726070802.26579-1-krzysztof.kozlow...@linaro.org
Thanks.
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
13 -
> 2 files changed, 15 deletions(-)
>
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Thu, Sep 17, 2020 at 08:52:03AM +0200, Andre Heider wrote:
> Unused.
>
> Signed-off-by: Andre Heider
> ---
> include/configs/smdkv310.h | 3 ---
> 1 file changed, 3 deletions(-)
>
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
> include/configs/s5p_goni.h | 8 +---
> include/configs/s5pc210_universal.h | 7 +--
> include/configs/trats.h | 5 +
> include/configs/trats2.h| 7 +--
> 6 files changed, 6 insertions(+), 34 deletions(-)
>
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
dkv310.h | 2 --
> include/configs/snow.h | 2 --
> include/configs/spring.h | 2 --
> 10 files changed, 29 deletions(-)
>
Acked-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Thu, 30 May 2019 at 09:11, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Wed, 29 May 2019 at 14:15, Krzysztof Kozlowski wrote:
> >
> > On Fri, 24 May 2019 at 10:51, Anand Moon wrote:
> > >
> > > Fix the confict of scriptaddr address with ramdi
On Fri, 24 May 2019 at 10:51, Anand Moon wrote:
>
> Fix the confict of scriptaddr address with ramdisk_addr_r used
> in EXTRA_ENV_SETTINGS.
>
> Signed-off-by: Anand Moon
My comment from previous patch stays valid:
"... but there is no conflict in the first place. These addresses are
not used in
dale board is not configuring its PMIC (S5M8767) which
uses I2C bus. This setting can be thus safely removed to fix build
warning:
This board uses CONFIG_DM_I2C_COMPAT. Please remove
(possibly in a subsequent patch in your series)
before sending patches to the mailing list.
Signed-off-by: Krzysztof
indeed has Exynos5250 and some similarities with
Arndale 5250 board but the USB/Ethernet chip used there is apparently
different.
Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig")
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
---
Not tested.
on Arndale and SMDK5250 boards. It seems the commit
fixed nothing and just added unused defines.
In fact, the Arndale board is not configuring its PMIC (S5M8767) which
uses I2C bus.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Simon Glass
---
Not tested on Arndale board. Testing is welcomed
On Tue, 2 Apr 2019 at 09:52, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Tue, 2 Apr 2019 at 12:32, Krzysztof Kozlowski wrote:
> >
> > On Mon, 1 Apr 2019 at 19:17, Anand Moon wrote:
> > >
> > > Hi Krzysztof,
> > >
> >
The ohci driver calls board_usb_init(), not usb_board_init().
Signed-off-by: Krzysztof Kozlowski
---
doc/README.generic_usb_ohci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/README.generic_usb_ohci b/doc/README.generic_usb_ohci
index 61300c35758a..65b0896c7fd2 100644
On Mon, 1 Apr 2019 at 19:17, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Mon, 1 Apr 2019 at 21:46, Krzysztof Kozlowski wrote:
> >
> > On Mon, 1 Apr 2019 at 17:50, Anand Moon wrote:
> > >
> > > Hi Krzysztof,
> > >
> >
On Mon, 1 Apr 2019 at 17:50, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Mon, 1 Apr 2019 at 18:27, Krzysztof Kozlowski wrote:
> >
> > On Mon, 1 Apr 2019 at 13:53, Anand Moon wrote:
> > >
> > > Add new CONFIG_SYS_ODROID_USB flag to avoid compliati
On Mon, 1 Apr 2019 at 18:05, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Mon, 1 Apr 2019 at 18:25, Krzysztof Kozlowski wrote:
> >
> > On Mon, 1 Apr 2019 at 13:53, Anand Moon wrote:
> > >
> > > Some host controllers need addidional re-initialization
>
On Mon, 1 Apr 2019 at 17:57, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Mon, 1 Apr 2019 at 18:21, Krzysztof Kozlowski wrote:
> >
> > On Mon, 1 Apr 2019 at 13:52, Anand Moon wrote:
> > >
> > > Add board_usb_cleanup routine to cleanup after
>
On Mon, 1 Apr 2019 at 13:53, Anand Moon wrote:
>
> Add usbnet_devaddr mac address to extra env setting
> to avoid failure of ethernet driver while usb start.
>
> Odroid # usb start
> starting USB...
> USB0: USB EHCI 1.00
> scanning bus 0 for devices... 3 USB Device(s) found
>scanning
On Mon, 1 Apr 2019 at 13:53, Anand Moon wrote:
>
> fix the confict of scriptaddr address with ramdisk_addr_r
Start with capital letter, so s/fix/Fix. End with a full-stop.
> also add missing pxefile_addr_r u-boot extras env setting.
s/also/Also/
... but there is no conflict in the first
On Mon, 1 Apr 2019 at 13:53, Anand Moon wrote:
>
> Add new CONFIG_SYS_ODROID_USB flag to avoid compliation
> error on other development boards.
>
> Fix below compilation error:
> Error: You must add new CONFIG options using Kconfig
> The following new ad-hoc CONFIG options were detected:
>
On Mon, 1 Apr 2019 at 13:53, Anand Moon wrote:
>
> Some host controllers need addidional re-initialization
Please run spell-check.
> after ehci_reset() so we add .init_after_reset callback
> which is requires to reinit the phy after controller reset.
s/requires/required/
but you do not
On Mon, 1 Apr 2019 at 13:52, Anand Moon wrote:
>
> Add board_usb_cleanup routine to cleanup after
> de-registering it usb devices. Also fixed the
> compilation error for other board.
Fix for build error should be in separate commit. Please also quote
the error you are fixing... because the code
On Mon, 1 Apr 2019 at 13:52, Anand Moon wrote:
>
> From: Tobias Jakobi
>
> Rename board_usb_init() to exynos_usb_init() and call it
> early in the Exynos EHCI driver when probing.
>
> This kind of works. After a 'usb start; usb stop; usb start'
> cycle the attached devices are recognized.
>
>
On Mon, 18 Mar 2019 at 18:49, Anand Moon wrote:
>
> Hi Krzysztof,
>
> On Mon, 18 Mar 2019 at 18:20, Krzysztof Kozlowski wrote:
> >
> > On Mon, 18 Mar 2019 at 13:32, Anand Moon wrote:
> > >
> > > Hi Krzysztof / Marek,
> > >
> > > After
On Mon, 18 Mar 2019 at 13:32, Anand Moon wrote:
>
> Hi Krzysztof / Marek,
>
> After I update the latest u-boot on my Odroud U3+ it fails to load the
> kernel it hangs.
> I am using Archlinux on Odroid U3.
>
> U-Boot 2019.04-rc3-00131-g8303467e80d-dirty (Mar 18 2019 - 12:12:23 +)
>
> CPU:
on Arndale and SMDK5250 boards. It seems the commit
fixed nothing and just added unused defines.
In fact, the Arndale board is not configuring its PMIC (S5M8767) which
uses I2C bus.
Signed-off-by: Krzysztof Kozlowski
---
Not tested on Arndale board. Testing is welcomed.
---
include/configs/arn
dale board is not configuring its PMIC (S5M8767) which
uses I2C bus. This setting can be thus safely removed to fix build
warning:
This board uses CONFIG_DM_I2C_COMPAT. Please remove
(possibly in a subsequent patch in your series)
before sending patches to the mailing list.
Signed-off-by: Krzysztof
On Thu, 14 Mar 2019 at 20:24, Tom Rini wrote:
> I'm taking your patch to the MAINTAINERS file now. That said, generally
> "odd fixes" are what's required of board maintainers, once the port is
> in. However, as we push forward on moving to various frameworks that
> should make life easier
The MAINTAINERS file was copied from Linux Kernel along with all its
statuses of maintainership. However tools/genboardscfg.py accepts only
Maintained, Supported and Orphan. Remove then the Odd Fixes and
Obsolete from MAINTAINERS file to avoid confusion.
Signed-off-by: Krzysztof Kozlowski
On Thu, 14 Mar 2019 at 01:32, Tom Rini wrote:
>
> On Tue, Mar 12, 2019 at 05:23:37PM +0900, Minkyu Kang wrote:
>
> > Hi Tom,
> >
> > The following changes since commit e8e3f2d2d48f97b2c79b698eccedce8f4f880993:
> >
> > Merge branch '2019-03-08-master-imports' (2019-03-08 18:04:13 -0500)
> >
> >
On Thu, 14 Mar 2019 at 09:15, Minkyu Kang wrote:
>
> Hi,
>
> On 14/03/2019 16:38, Krzysztof Kozlowski wrote:
> > On Thu, 14 Mar 2019 at 05:10, Minkyu Kang wrote:
> >>
> >> On 14/03/2019 09:44, Minkyu Kang wrote:
> >>> set status to Maintained
On Thu, 14 Mar 2019 at 05:10, Minkyu Kang wrote:
>
> On 14/03/2019 09:44, Minkyu Kang wrote:
> > set status to Maintained
> >
> > Signed-off-by: Minkyu Kang
> > Cc: Krzysztof Kozlowski
> > ---
> > board/samsung/arndale/MAINTAINERS | 2 +-
>
after changing it. Although the proper value of ramp delay for
LDOs is unknown, it seems safer to use at least some value from
reference kernel than to leave it unset.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
arch/arm/dts/exynos5422-odroidxu3.dts
reads on Odroid HC1 return 305, 1207, 1297 and finally 1308
(reference value is 1309).
Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
---
board/samsung/common/exynos5-dt-types.c | 38 -
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/board/samsung
According to datasheet, the output on LDO regulators will start
appearing after 10-15 us.
Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
---
drivers/power/regulator/s2mps11_regulator.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/power
The ADC block requires VDD supply to be on so provide one.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
arch/arm/dts/exynos5422-odroidxu3.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts
b/arch/arm/dts
LDO27 and LDO35 have 25 mV step, not 50 mV.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
drivers/power/regulator/s2mps11_regulator.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/power/regulator/s2mps11_regulator.c
b/drivers
Printing the "Type" of board requires proper detection of revision which
can happen only late because regulators are needed.
Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
---
board/samsung/common/board.c | 2 +-
configs/odroid-xu3_defconfig | 2 ++
2 files changed, 3
Changing voltage and enabling regulator might require delays so the
regulator stabilizes at expected level.
Add support for "regulator-ramp-delay" binding which can introduce
required time to both enabling the regulator and to changing the
voltage.
Signed-off-by: Krzysztof Kozlows
regulator.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
board/samsung/common/board.c| 23 ++-
board/samsung/common/exynos5-dt-types.c | 16 +---
board/samsung/odroid/odroid.c | 8
include
When stopping the ADC_V2_CON1_STC_EN should be cleared.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
drivers/adc/exynos-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c
alized),
2. Turning VDD_ADC should wait with ramp delay,
3. Reading the value from ADC should wait for it to stabilize.
Tested on Odroid XU3-Lite and Odroid HC1.
Comments and testing are welcomed.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
adc: exynos-adc: Fix wrong bit operation used to st
: In function 'board_usb_init':
board/samsung/odroid/odroid.c:473:8: error: 'gd_t' {aka 'volatile struct
global_data'} has no member named 'board_type'
if (gd->board_type == ODROID_TYPE_U3)
^~
Signed-off-by: Krzysztof Kozlowski
---
board/samsung/odroid/odroid.c |
On Wed, 6 Mar 2019 at 08:03, Minkyu Kang wrote:
>
> Dear Krzysztof Kozlowski,
>
> On 06/03/2019 04:57, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > Changes since v3
> >
> > 1. Add accumulated review and test tags.
> > 2. Patch 6:
after changing it. Although the proper value of ramp delay for
LDOs is unknown, it seems safer to use at least some value from
reference kernel than to leave it unset.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
arch/arm/dts/exynos5422-odroidxu3.dts
According to datasheet, the output on LDO regulators will start
appearing after 10-15 us.
Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
---
drivers/power/regulator/s2mps11_regulator.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/power
Changing voltage and enabling regulator might require delays so the
regulator stabilizes at expected level.
Add support for "regulator-ramp-delay" binding which can introduce
required time to both enabling the regulator and to changing the
voltage.
Signed-off-by: Krzysztof Kozlows
reads on Odroid HC1 return 305, 1207, 1297 and finally 1308
(reference value is 1309).
Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
---
board/samsung/common/exynos5-dt-types.c | 38 -
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/board/samsung
The ADC block requires VDD supply to be on so provide one.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
arch/arm/dts/exynos5422-odroidxu3.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts
b/arch/arm/dts
regulator.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
board/samsung/common/board.c| 22 +-
board/samsung/common/exynos5-dt-types.c | 16 +---
board/samsung/odroid/odroid.c | 8
include
Printing the "Type" of board requires proper detection of revision which
can happen only late because regulators are needed.
Signed-off-by: Krzysztof Kozlowski
Tested-by: Anand Moon
---
board/samsung/common/board.c | 2 +-
configs/odroid-xu3_defconfig | 2 ++
2 files changed, 3
LDO27 and LDO35 have 25 mV step, not 50 mV.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
drivers/power/regulator/s2mps11_regulator.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/power/regulator/s2mps11_regulator.c
b/drivers
When stopping the ADC_V2_CON1_STC_EN should be cleared.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
Tested-by: Anand Moon
---
drivers/adc/exynos-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c
and Odroid HC1.
Comments and testing are welcomed.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
adc: exynos-adc: Fix wrong bit operation used to stop the ADC
power: regulator: s2mps11: Fix step for LDO27 and LDO35
arm: exynos: Detect revision later, when all resources are ready
a
On Tue, 5 Mar 2019 at 11:16, Minkyu Kang wrote:
>
> Dear Krzysztof Kozlowski,
>
> On 24/02/2019 21:55, Anand Moon wrote:
> > Hi Krzysztof,
> >
> > Please add my. on Odroid HC1
> >
> > Tested-by: Anand Moon
> >
> > Best Regards
> > -Ana
On Sun, 24 Feb 2019 at 13:41, Anand Moon wrote:
>
> This commit enables support for I2C S3C424X0 driver.
>
> Signed-off-by: Anand Moon
> ---
>
> ODROID-XU3 # i2c bus
> Bus 0: i2c@12C6
> Bus 1: i2c@12C7
> Bus 2: i2c@12C8
> Bus 3: i2c@12C9
> Bus 4: i2c@12CA (active 4)
>
Last activity from Arndale (Exynos5250) board maintainer Chander Kashyap
was in January 2014 (Signed-off). Recently his samsung.com email
bounces with 550 (5.1.1 Recipient address rejected: User unknown).
Add Krzysztof Kozlowski as odd fixer for this board.
Signed-off-by: Krzysztof Kozlowski
Various places in the code set "boardname" env property. It was used
for booting from ITB images and choosing proper DTB file name. Instead
of duplicating it, use existing U-Boot wide - "board_name".
Signed-off-by: Krzysztof Kozlowski
---
Tested only on Odroid XU3.
T
When including other header from configs, use consistent <> syntax.
Signed-off-by: Krzysztof Kozlowski
---
include/configs/odroid_xu3.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h
index f17854
File mixed space and tab indentation. Unify it.
Signed-off-by: Krzysztof Kozlowski
---
include/configs/odroid_xu3.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h
index 7f4cff186151..5e765a2b2b02 100644
indeed has Exynos5250 and some similarities with
Arndale 5250 board but the USB/Ethernet chip used there is apparently
different.
Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig")
Signed-off-by: Krzysztof Kozlowski
---
Not tested.
---
configs/arndale_defconfig |
Just add spaces around '=' sign for clarity.
Signed-off-by: Krzysztof Kozlowski
---
arch/arm/dts/exynos5422-odroidxu3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts
b/arch/arm/dts/exynos5422-odroidxu3.dts
index e859dd1b981a
On Mon, 18 Feb 2019 at 16:27, Torsten Duwe wrote:
> > > But my main point is: is the required delay always a linear
> > > function of the voltage jump? Depending on the dampening and
> > > load on the rail this could be an overshoot and settle, no?
> > >
> > > So I suggest to make that an array
On Mon, 18 Feb 2019 at 15:03, Torsten Duwe wrote:
>
> On Sat, Feb 16, 2019 at 10:45:45AM +0100, Krzysztof Kozlowski wrote:
> > Changing voltage and enabling regulator might require delays so the
> > regulator stabilizes at expected level.
> >
> > Add support for
The ADC block requires VDD supply to be on so provide one.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
---
arch/arm/dts/exynos5422-odroidxu3.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts
b/arch/arm/dts/exynos5422-odroidxu3
According to datasheet, the output on LDO regulators will start
appearing after 10-15 us.
Signed-off-by: Krzysztof Kozlowski
---
drivers/power/regulator/s2mps11_regulator.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/power/regulator
regulator.
Signed-off-by: Krzysztof Kozlowski
---
board/samsung/common/board.c| 22 +-
board/samsung/common/exynos5-dt-types.c | 16 +---
board/samsung/odroid/odroid.c | 8
include/samsung/misc.h | 1 +
4 files
after changing it. Although the proper value of ramp delay for
LDOs is unknown, it seems safer to use at least some value from
reference kernel than to leave it unset.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
---
arch/arm/dts/exynos5422-odroidxu3.dts | 19
Changing voltage and enabling regulator might require delays so the
regulator stabilizes at expected level.
Add support for "regulator-ramp-delay" binding which can introduce
required time to both enabling the regulator and to changing the
voltage.
Signed-off-by: Krzysztof
and finally 1308
(reference value is 1309).
Signed-off-by: Krzysztof Kozlowski
---
board/samsung/common/exynos5-dt-types.c | 38 -
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/board/samsung/common/exynos5-dt-types.c
b/board/samsung/common/exynos5-dt-types.c
index
Printing the "Type" of board requires proper detection of revision which
can happen only late because regulators are needed.
Signed-off-by: Krzysztof Kozlowski
---
board/samsung/common/board.c | 2 +-
configs/odroid-xu3_defconfig | 2 ++
2 files changed, 3 insertions(+), 1 deletio
LDO27 and LDO35 have 25 mV step, not 50 mV.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
---
drivers/power/regulator/s2mps11_regulator.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/power/regulator/s2mps11_regulator.c
b/drivers/power/regulator
delay,
3. Reading the value from ADC should wait for it to stabilize.
Tested on Odroid XU3-Lite and Odroid HC1.
Commends and testing are welcomed.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
adc: exynos-adc: Fix wrong bit operation used to stop the ADC
power: regulator: s2mps11: Fix
When stopping the ADC_V2_CON1_STC_EN should be cleared.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Lukasz Majewski
---
drivers/adc/exynos-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c
index d33e3d632afc
On Fri, Feb 15, 2019 at 08:15:45AM +0100, Lukasz Majewski wrote:
> On Wed, 13 Feb 2019 17:46:44 +0100
> Krzysztof Kozlowski wrote:
>
> > Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel
> > disabled the LDO4/VDD_ADC regulator.
> >
> > The LDO4 su
On Fri, Feb 15, 2019 at 06:11:34PM +0100, Simon Glass wrote:
> Hi Krzysztof,
>
> On Wed, 13 Feb 2019 at 17:47, Krzysztof Kozlowski wrote:
> >
> > According to datasheet, the output on LDO regulators will start
> > appearing after 10-15 us.
> >
>
On Fri, 15 Feb 2019 at 08:04, Lukasz Majewski wrote:
>
> On Wed, 13 Feb 2019 17:46:46 +0100
> Krzysztof Kozlowski wrote:
>
> > According to datasheet, the output on LDO regulators will start
> > appearing after 10-15 us.
> >
> > Signed-off-by: Krzysztof K
1 - 100 of 126 matches
Mail list logo
