Re: Pull request for tpm-master-27052024

2024-05-27 Thread Miquel Raynal
Hi Ilias, ilias.apalodi...@linaro.org wrote on Mon, 27 May 2024 15:01:10 +0300: > Hi Tom, > > Don't pull this please. Miquel added his r-b tags in the meantime, > I'll queue up a new one It's okay, I thought you just merged the patches in your tree, but if you already sent the PR to Tom it's

Re: [PATCH v5 2/2] tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend

2024-05-27 Thread Miquel Raynal
Hi Ilias, ilias.apalodi...@linaro.org wrote on Mon, 27 May 2024 12:44:11 +0300: > Hi Miquel > > On Mon, 27 May 2024 at 11:59, Miquel Raynal wrote: > > > > Hi Tim, > > > > thar...@gateworks.com wrote on Sat, 25 May 2024 13:00:49 -0700: > > > >

Re: [PATCH v5 2/2] tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend

2024-05-27 Thread Miquel Raynal
te test_tpm2.py for the changes in output in pcr_read > which now shows the algo and algo length in the output. > > A follow-on to this could be to extend all PCR banks with the detected > algo when the argument is 'auto'. > > Signed-off-by: Tim Harvey > Reviewed-by: Ilias Apa

Re: [PATCH v5 1/2] tpm-v2: add support for mapping algorithm names to algos

2024-05-27 Thread Miquel Raynal
. > > Fixes: 97707f12fdab ("tpm: Support boot measurements") > Signed-off-by: Tim Harvey > Reviewed-by: Ilias Apalodimas > Cc: Eddie James > Cc: Ilias Apalodimas > --- Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Miquel Raynal
> > > Signed-off-by: Jorge Ramirez-Ortiz > > > > You cannot send your SoB like this. SoB means you are carrying some > > code which complies with the license, etc. > > > > Either you were part of the original writing and want to be credited > > for that (you can be the author and first SoB,

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Miquel Raynal
cification_TIS__1-3_27_03212013.pdf > > > > > > Signed-off-by: Tim Harvey > > > > Looks way cleaner, thanks. > > > > Reviewed-by: Miquel Raynal > > > > Miquèl > > nice. if needed > > Signed-off-by: Jorge Ramirez-Ortiz Yo

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Miquel Raynal
, DeviceID 0x3205, RevisionID 0x01 [open] > > [1] > https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf > > Signed-off-by: Tim Harvey Looks way cleaner, thanks. Reviewed-by: Miquel Raynal Miquèl

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-17 Thread Miquel Raynal
Hi Ilias, ilias.apalodi...@linaro.org wrote on Wed, 17 Apr 2024 08:40:14 +0300: > Hi Miquel > > On Mon, 8 Apr 2024 at 10:23, Miquel Raynal wrote: > > > > Hello, > > > > ilias.apalodi...@linaro.org wrote on Thu, 28 Mar 2024 09:08:37 +0200: > > > >

Re: [PATCH v11 1/2] dt-bindings: mtd: fixed-partitions: Add alignment properties

2024-04-15 Thread Miquel Raynal
On Fri, 2024-04-12 at 15:32:48 UTC, Simon Glass wrote: > Add three properties for controlling alignment of partitions, aka > 'entries' in fixed-partition. > > For now there is no explicit mention of hierarchy, so a 'section' is > just the 'fixed-partitions' node. > > These new properties are

Re: [PATCH v11 2/2] dt-bindings: mtd: fixed-partition: Add binman compatibles

2024-04-15 Thread Miquel Raynal
On Fri, 2024-04-12 at 15:32:49 UTC, Simon Glass wrote: > Add two compatibles for binman entries, as a starting point for the > schema. > > Note that, after discussion on v2, we decided to keep the existing > meaning of label so as not to require changes to existing userspace > software when

Re: [PATCH v10 1/2] dt-bindings: mtd: fixed-partitions: Add alignment properties

2024-04-08 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Tue, 26 Mar 2024 14:06:44 -0600: > Add three properties for controlling alignment of partitions, aka > 'entries' in fixed-partition. > > For now there is no explicit mention of hierarchy, so a 'section' is > just the 'fixed-partitions' node. > > These new

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-08 Thread Miquel Raynal
Hello, ilias.apalodi...@linaro.org wrote on Thu, 28 Mar 2024 09:08:37 +0200: > Thanks Tim > > On Thu, 28 Mar 2024 at 00:12, Tim Harvey wrote: > > > > Instead of displaying what looks like an error message if a > > gpio-reset dt prop is missing for a TPM display a warning that > > having a gpio

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-03-13 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Wed, 13 Mar 2024 11:25:42 +1300: > Hi Miquel, > > On Fri, 8 Mar 2024 at 20:42, Miquel Raynal wrote: > > > > Hi Simon, > > > > s...@chromium.org wrote on Fri, 8 Mar 2024 15:44:25 +1300: > > > > > Hi Miquel,

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-03-07 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Fri, 8 Mar 2024 15:44:25 +1300: > Hi Miquel, > > On Tue, 6 Feb 2024 at 01:17, Miquel Raynal wrote: > > > > Hi Simon, > > > > > > > > > > > > > > > > +description: | > >

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-02-05 Thread Miquel Raynal
Hi Simon, > > > > > > > > > > > > +description: | > > > > > > > > > > > > + The binman node provides a layout for firmware, used > > > > > > > > > > > > when packaging firmware > > > > > > > > > > > > + from multiple projects. It is based on > > > > > > > > > > > > fixed-partitions, with some

Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2024-02-04 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Sun, 4 Feb 2024 05:07:38 -0700: > Hi Rob, > > On Wed, 17 Jan 2024 at 08:56, Rob Herring wrote: > > > > On Thu, Jan 4, 2024 at 3:54 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Thu, Dec 14, 2023 at 2:09 PM Simon Glass wrote: > > > > > > > >

Re: [PATCH V3 1/6] dt-bindings: nvmem: layouts: add U-Boot environment variables layout

2024-01-15 Thread Miquel Raynal
Hi Rob, r...@kernel.org wrote on Mon, 15 Jan 2024 11:09:03 -0600: > On Thu, Jan 04, 2024 at 10:10:13AM +0100, Rafał Miłecki wrote: > > On 4.01.2024 08:58, Miquel Raynal wrote: > > > r...@kernel.org wrote on Wed, 3 Jan 2024 17:11:29 -0700: > > > > On Thu, Dec 21, 2

Re: [PATCH 1/1] cmd: mtd: avoid unintentional integer overflow

2024-01-10 Thread Miquel Raynal
Hi Heinrich, heinrich.schucha...@canonical.com wrote on Thu, 11 Jan 2024 08:31:55 +0100: > mtd dump beyond 4 GiB will show incorrect results. > > Multiplying two u32 will yield a u32. Add a missing cast. Good point, thanks for the fix. Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH V3 1/6] dt-bindings: nvmem: layouts: add U-Boot environment variables layout

2024-01-03 Thread Miquel Raynal
Hello, r...@kernel.org wrote on Wed, 3 Jan 2024 17:11:29 -0700: > On Thu, Dec 21, 2023 at 06:34:16PM +0100, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > U-Boot env data is a way of storing firmware variables. It's a format > > that can be used of top of various storage devices. Its

Re: [PATCH V2 5/5] nvmem: layouts: add U-Boot env layout

2023-12-19 Thread Miquel Raynal
se device_get_match_data() helper > > IMPORTANT: > This is based on top of the: > [PATCH v6.8 1/2] nvmem: layouts: refactor .add_cells() callback arguments Thanks for the move. Looks good to me: Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH V2 4/5] nvmem: u-boot-env: improve coding style

2023-12-19 Thread Miquel Raynal
)" > 2. Drop dev_err() for u_boot_env_add_cells() fail >It can fail only on -ENOMEM. We don't want to print error then. > 3. Add extra "crc32_addr" variable >It makes code reading header's crc32 easier to understand / review. > > Signed-off-by: Rafał Miłecki Loo

Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-19 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Tue, 19 Dec 2023 19:16:37 +0100: > On 19.12.2023 19:13, Greg Kroah-Hartman wrote: > > On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote: > >> From: Rafał Miłecki > >> > >> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less

Re: [PATCH 4/4] nvmem: layouts: add U-Boot env layout

2023-12-18 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Mon, 18 Dec 2023 23:10:20 +0100: > On 18.12.2023 15:21, Miquel Raynal wrote: > > Hi Rafał, > > > > zaj...@gmail.com wrote on Mon, 18 Dec 2023 14:37:22 +0100: > > > >> From: Rafał Miłecki > >> > >> T

Re: [PATCH 4/4] nvmem: layouts: add U-Boot env layout

2023-12-18 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Mon, 18 Dec 2023 14:37:22 +0100: > From: Rafał Miłecki > > This patch moves all generic (NVMEM devices independent) code from NVMEM > device driver to NVMEM layout driver. Then it adds a simple NVMEM layout > code on top of it. > > Thanks to proper layout

Re: [PATCH 2/4] nvmem: core: add nvmem_dev_size() helper

2023-12-18 Thread Miquel Raynal
Hi Rafał, zaj...@gmail.com wrote on Mon, 18 Dec 2023 14:37:20 +0100: > From: Rafał Miłecki > > This is required by layouts that need to read whole NVMEM content. It's > especially useful for NVMEM devices without hardcoded layout (like > U-Boot environment data block). Revi

Re: [PATCH 3/4] nvmem: u-boot-env: use more nvmem subsystem helpers

2023-12-18 Thread Miquel Raynal
ał Miłecki Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH] tqma6: Fix DDR configuration

2023-12-12 Thread Miquel Raynal
Hi Fabio, feste...@gmail.com wrote on Tue, 12 Dec 2023 13:11:53 -0300: > On Fri, Nov 17, 2023 at 1:50 PM Miquel Raynal > wrote: > > > > Initially investigating a Linux network issue causing a lot of drop and > > poor network performances on a custom system based on a

[PATCH] nand: Add a watch command

2023-11-28 Thread Miquel Raynal
ips: 1 Pages with bitflips: 44/130752 It is also possible to reduce the output with the .quiet suffix in order to just show the summary. => nand watch.chip device 0 whole chip size adjusted to 0xff6 (5 bad blocks) NAND watch for bitflips in area 0x0-0xff6: Maximum

Re: [PATCH] tqma6: Fix DDR configuration

2023-11-23 Thread Miquel Raynal
Hi Alexander, > > > > --- a/board/tq/tqma6/tqma6q.cfg > > > > +++ b/board/tq/tqma6/tqma6q.cfg > > > > @@ -36,7 +36,7 @@ DATA 4, MX6_IOM_DRAM_SDCLK_1, 0x8030 > > > > > > > > DATA 4, MX6_IOM_DRAM_CAS, 0x8030 > > > > DATA 4, MX6_IOM_DRAM_RAS, 0x8030 > > > > DATA 4, MX6_IOM_GRP_ADDDS,

Re: [PATCH] tqma6: Fix DDR configuration

2023-11-23 Thread Miquel Raynal
ck to 0%. > > > > Link: > > https://lore.kernel.org/netdev/20231012193410.3d1812cf@xps-13/ > > > > Link: > > https://lists.freedesktop.org/archives/dri-devel/2023-October/428251.html > > > > Link: > > https://github.com/tq-systems/u-boot-tqmax

[PATCH] tqma6: Fix DDR configuration

2023-11-17 Thread Miquel Raynal
0.3d1812cf@xps-13/ Link: https://lists.freedesktop.org/archives/dri-devel/2023-October/428251.html Link: https://github.com/tq-systems/u-boot-tqmaxx/commit/15eb6abbefbf6916c28467b85485911dad3da6bc Signed-off-by: Miquel Raynal --- board/tq/tqma6/tqma6q.cfg | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH v4 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-25 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Tue, 24 Oct 2023 14:40:54 -0700: > Hi Rob, > > On Tue, 24 Oct 2023 at 09:16, Rob Herring wrote: > > > > On Mon, Oct 09, 2023 at 04:04:14PM -0600, Simon Glass wrote: > > > Add two compatible for binman entries, as a starting point for the > > > schema. > >

Re: [PATCH v4] dt-bindings: mtd: fixed-partitions: Add compression property

2023-10-16 Thread Miquel Raynal
On Wed, 2023-09-27 at 18:05:43 UTC, Simon Glass wrote: > Sometimes the contents of a partition are compressed. Add a property to > express this and define the algorithm used. > > Signed-off-by: Simon Glass Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next,

[PATCH v3 3/3] usb: udc: Try to clarify an error message

2023-10-10 Thread Miquel Raynal
xplanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal Reviewed-by: Mattijs Korpershoek --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by def

[PATCH v3 2/3] cmd: bind: Try to improve the (un)bind help

2023-10-10 Thread Miquel Raynal
detail much more, but at least the pointer is there. While we add this message, we can also imply CMD_DM when we enable CMD_BIND so the debug message does not lead to an unknown command. This way the 'dm' command will likely be there unless explicitly disabled. Signed-off-by: Miquel Raynal Reviewed

[PATCH v3 1/3] cmd: Change the dependencies between CMD_BIND and USB_GADGET

2023-10-10 Thread Miquel Raynal
Today CMD_BIND defaults to 'y' when USB_ETHER is enabled. In practice, CMD_BIND should default to 'y' when any USB gadget is enabled not only USB_ETHER. Let's invert the logic of the dependency and use the weak 'imply' keyword to enforce this. Signed-off-by: Miquel Raynal --- cmd/Kconfig

[PATCH v3 0/3] Improve the experience with USB gadgets

2023-10-10 Thread Miquel Raynal
composite gadget support, but that is a longer term goal. Changes in v3: * First patch is new. * Collected the tags received. * Imply CMD_DM from CMD_BIND. Miquel Raynal (3): cmd: Change the dependencies between CMD_BIND and USB_GADGET cmd: bind: Try to improve the (un)bind help usb: udc: Try

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-10 Thread Miquel Raynal
Hi Marek, > >>> --- a/drivers/usb/gadget/udc/udc-core.c > >>> +++ b/drivers/usb/gadget/udc/udc-core.c > >>> @@ -323,6 +323,7 @@ err1: > >>>int usb_gadget_probe_driver(struct usb_gadget_driver *driver) > >>>{ > >>> struct usb_udc *udc = NULL; > >>> + unsigned int

Re: [PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-05 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Thu, 5 Oct 2023 15:01:51 +0200: > On 10/2/23 15:46, Miquel Raynal wrote: > > While it may sound totally obvious for the regular U-Boot developer to > > get the parameters of the bind/unbind commands from the output of 'dm > > t

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-05 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Thu, 5 Oct 2023 15:04:25 +0200: > On 10/2/23 15:46, Miquel Raynal wrote: > > At some point when trying to use USB gadgets, two situations may arise > > and lead to a failure. Either the UDC (USB Device Controller) is not > > available

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-04 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Mon, 2 Oct 2023 11:49:40 -0600: > Add a compatible string for binman, so we can extend fixed-partitions > in various ways. I've been thinking at the proper way to describe the binman partitions. I am wondering if we should really extend the fixed-partitions

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-02 Thread Miquel Raynal
Hi Massimo, massimo.pegorer+...@gmail.com wrote on Mon, 2 Oct 2023 16:37:10 +0200: > Hi Miquel, > > Il giorno lun 2 ott 2023 alle ore 15:46 Miquel Raynal > ha scritto: > > > > At some point when trying to use USB gadgets, two situations may arise > > [...cut...

[PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-02 Thread Miquel Raynal
xplanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by default with LOGLEVEL=3, so I consi

[PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-02 Thread Miquel Raynal
detail much more, but at least the pointer is there. Signed-off-by: Miquel Raynal --- Resend: no change. Changes in v2: * Moved the details in the long text section as suggested by Heinrich. * Rephrased the help text as well, not fully following Heinrich suggestion, but taking inspiration from

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-10-02 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Sat, 30 Sep 2023 23:11:17 +0200: > On 9/27/23 15:59, Miquel Raynal wrote: > > Hi Marek, > > Hi, > > > miquel.ray...@bootlin.com wrote on Fri, 22 Sep 2023 12:00:12 +0200: > > > >> Hi Marek, > >> > >

Re: [PATCH 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-01 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Wed, 27 Sep 2023 14:20:51 -0600: > Add a compatible string for binman, so we can extend fixed-partitions > in various ways. > > Signed-off-by: Simon Glass > --- > > .../bindings/mtd/partitions/binman.yaml | 49 +++ >

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-09-27 Thread Miquel Raynal
fully next week. The series looks good to me and works as well on a Beagle Bone Black with no visible functional changes regarding the use of the UDC. The whole series is: Tested-by: Miquel Raynal By the way, following your initial series there have been three followup patches trying to improve a little b

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-26 Thread Miquel Raynal
Hello, > > > > > These are firmware bindings, as indicated, but I > > > > > took them out of the /firmware node since that is for a different > > > > > purpose. Rob suggested that partitions was a good place. We have fwupd > > > > > using DT to hold the firmware-update information, so I expect it

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-25 Thread Miquel Raynal
Hi Simon, > > > > > > > > > I was assuming that I should create a top-level compatible = > > > > > > > > > "binman" > > > > > > > > > node, with subnodes like compatible = "binman,bl31-atf", for > > > > > > > > > example. > > > > > > > > > I should use the compatible string to indicate the

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-25 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Mon, 25 Sep 2023 06:33:14 -0600: > Hi Miquel, > > On Mon, 25 Sept 2023 at 01:21, Miquel Raynal > wrote: > > > > Hi Simon, > > > > s...@chromium.org wrote on Fri, 22 Sep 2023 13:51:14 -0600: > > > > > Hi

Re: [PATCH] dt-bindings: mtd: Add a schema for binman

2023-09-25 Thread Miquel Raynal
Hi Simon, s...@chromium.org wrote on Fri, 22 Sep 2023 13:51:14 -0600: > Hi Rob, > > On Fri, 22 Sept 2023 at 13:43, Rob Herring wrote: > > > > On Fri, Sep 22, 2023 at 1:12 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Fri, 22 Sept 2023 at 11:46, Rob Herring wrote: > > > > > > >

Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-09-22 Thread Miquel Raynal
attijs Korpershoek > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patr

Re: [PATCH 01/17] dm: usb: udc: Factor out plain udevice handler functions

2023-08-21 Thread Miquel Raynal
witched over to these functions and the dev_array can be dropped. > > Signed-off-by: Marek Vasut > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc: Eddie Cai > Cc: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon

[PATCH v2 2/2] usb: udc: Try to clarify an error message

2023-08-07 Thread Miquel Raynal
xplanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by default with LOGLEVEL=3, so I consi

[PATCH v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-07 Thread Miquel Raynal
detail much more, but at least the pointer is there. Signed-off-by: Miquel Raynal --- Changes in v2: * Moved the details in the long text section as suggested by Heinrich. * Rephrased the help text as well, not fully following Heinrich suggestion, but taking inspiration from it. --- cmd/bind.c | 4

Re: [PATCH 2/2] usb: udc: Try to clarify an error message

2023-08-07 Thread Miquel Raynal
Hi Heinrich, heinrich.schucha...@canonical.com wrote on Mon, 7 Aug 2023 11:29:08 +0200: > On 04.08.23 21:14, Miquel Raynal wrote: > > At some point when trying to use USB gadgets, two situations may arise > > and lead to a failure. Either the UDC (USB Device Controller) is no

Re: [PATCH 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-07 Thread Miquel Raynal
Hi Heinrich, > > U_BOOT_CMD( > > bind, 4, 0, do_bind_unbind, > > - "Bind a device to a driver", > > + "Bind a device to a driver, see 'dm tree' for the parameters\n", > > How about > > "Use 'dm tree' to list classes, drivers, and devices." > > as last line of the help

[PATCH v2] doc: ti: Explain how the various gadget devices can be used

2023-08-07 Thread Miquel Raynal
Describe the current situation wrt the handling of USB devices on AM33xx based boards, taking the example of a common board (the Beagle Bone Black) and explaining how the different USB gadgets can be used. Signed-off-by: Miquel Raynal --- I've tried to be as transparent and honnest as I could

Re: [PATCH] doc: ti: Explain how the various gadget devices can be used

2023-08-07 Thread Miquel Raynal
Hi Heinrich, xypron.g...@gmx.de wrote on Sun, 6 Aug 2023 21:29:54 +0200: > On 8/4/23 21:37, Miquel Raynal wrote: > > Describe the current situation wrt the handling of USB devices on AM33xx > > based boards, taking the example of a common board (the Beagle Bone > > Blac

Re: [PATCH v5 2/3] usb: gadget: ether: Move probe function above driver structure

2023-08-04 Thread Miquel Raynal
> Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Simon Glass > --- Tested-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v5 2/3] usb: gadget: ether: Move probe function above driver structure

2023-08-04 Thread Miquel Raynal
> Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Simon Glass > --- Tested-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v5 1/3] usb: gadget: ether: Inline functions used once

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 17:41:09 +0200: > These functions here are only ever called once since drop of non-DM > networking code. Inline them. No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Kevin Hilman > Cc: Lukasz Majewski

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Fri, 4 Aug 2023 14:51:07 -0400: > On Fri, Aug 04, 2023 at 08:01:56PM +0200, Miquel Raynal wrote: > > Hi Tom, > > > > tr...@konsulko.com wrote on Fri, 4 Aug 2023 13:20:29 -0400: > > > > > On Fri, Aug 04, 2023 at 0

[PATCH] doc: ti: Explain how the various gadget devices can be used

2023-08-04 Thread Miquel Raynal
Describe the current situation wrt the handling of USB devices on AM33xx based boards, taking the example of a common board (the Beagle Bone Black) and explaining how the different USB gadgets can be used. Signed-off-by: Miquel Raynal --- I've tried to be as transparent and honnest as I could

[PATCH 2/2] usb: udc: Try to clarify an error message

2023-08-04 Thread Miquel Raynal
xplanation of what's wrong with their workflow. Signed-off-by: Miquel Raynal --- While doing this I really wanted to add "much more" error comments but I faced another reality: often the messages are there but use pr_err/log_err which is actually silenced by default with LOGLEVEL=3, so I consi

[PATCH 1/2] cmd: bind: Try to improve the (un)bind help

2023-08-04 Thread Miquel Raynal
detail much more, but at least the pointer is there. Signed-off-by: Miquel Raynal --- cmd/bind.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/bind.c b/cmd/bind.c index 4d1b7885e60..8d29a42899e 100644 --- a/cmd/bind.c +++ b/cmd/bind.c @@ -243,14 +243,14 @@ static int

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Fri, 4 Aug 2023 13:20:29 -0400: > On Fri, Aug 04, 2023 at 07:01:46PM +0200, Miquel Raynal wrote: > > Hi Tom, > > > > > > > >>> Well, what's needed / is it possible to get to the point where we > > > > &

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 19:31:50 +0200: > On 8/4/23 19:24, Miquel Raynal wrote: > > Hi, > > >>>>>>> exit not allowed from main input shell. > >>>>>>> => unbind /ocp/usb@4740/usb@47401000 usb_ether

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 17:40:07 +0200: > On 8/4/23 17:12, Miquel Raynal wrote: > > Hi, > > > > ma...@denx.de wrote on Fri, 4 Aug 2023 17:05:01 +0200: > > > >> On 8/4/23 17:01, Tom Rini wrote: > >>> On Fri, Aug

Re: [PATCH] cmd: Enable BIND by default if we have USB_ETHER

2023-08-04 Thread Miquel Raynal
re so > that we can bind/unbind this as needed. > > Signed-off-by: Tom Rini > --- > Cc: Marek Vasut > Cc: Miquel Raynal Reviewed-by: Miquel Raynal Thanks, Miquèl

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, > > > > Cannot find a device with path /ocp/usb@4740/usb@47401000 > > > > => unbind /ocp/usb@4740/usb@47401000 > > > > => dm tree > > > > misc 0 [ + ] ti-musb-wrapper | |-- > > > > usb@4740 > > > > usb 0 [

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Tom, > > > >>> Well, what's needed / is it possible to get to the point where we > > > >>> don't > > > >>> _need_ to call bind/unbind for each of these cases? Is there something > > > >>> we're supposed to be setting in the DT that we aren't? > > > >> > > > >> You do need to unbind the

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Fri, 4 Aug 2023 17:40:07 +0200: > On 8/4/23 17:12, Miquel Raynal wrote: > > Hi, > > > > ma...@denx.de wrote on Fri, 4 Aug 2023 17:05:01 +0200: > > > >> On 8/4/23 17:01, Tom Rini wrote: > >>> On Fri, Aug

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi, ma...@denx.de wrote on Fri, 4 Aug 2023 17:05:01 +0200: > On 8/4/23 17:01, Tom Rini wrote: > > On Fri, Aug 04, 2023 at 04:42:13PM +0200, Marek Vasut wrote: > >> On 8/4/23 09:00, Miquel Raynal wrote: > >>> Hi Marek, > >>> > >>>

Re: [PATCH v4 1/4] cmd: bind: Add unbind command with driver filter

2023-08-04 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Wed, 2 Aug 2023 14:46:54 +0200: > Extend the driver core to perform lookup by both OF node and driver > bound to the node. Use this to look up specific device instances to > unbind from nodes in the unbind command. One example where this is > needed is USB

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-08-02 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Wed, 2 Aug 2023 16:38:47 +0200: > On 8/2/23 09:48, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Wed, 2 Aug 2023 01:07:46 +0200: > > > >> On 8/1/23 20:53, Miquel Raynal wrote: > >>> Hi M

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-08-02 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Wed, 2 Aug 2023 01:07:46 +0200: > On 8/1/23 20:53, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 16:40:04 +0200: > > > >> On 7/31/23 16:25, Miquel Raynal wrote: > >>> Hi M

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-08-01 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 16:40:04 +0200: > On 7/31/23 16:25, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > > > >> On 7/31/23 15:58, Miquel Raynal wrote: > >>>

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > On 7/31/23 15:58, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > > > >> On 7/31/23 15:36, Miquel Raynal wrote: > >>>

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > On 7/31/23 15:36, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: > > > >> On 7/31/23 11:31, Miquel Raynal wrote: > >>>

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: > On 7/31/23 11:31, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Sat, 29 Jul 2023 16:57:09 +0200: > > > >> Extend the driver core to perform lookup by both OF node an

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
owed from main input shell. Can you advise what bind/unbind command would be necessary here? Thanks, Miquèl > Cc: Kevin Hilman > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Simon Glass > --- > V2: No change > V3: No change > --- > cmd/bind.c| 10 +

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-28 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Sun, 23 Jul 2023 23:45:55 +0200: > On 7/23/23 19:49, Miquel Raynal wrote: > > Hi Marek, > > Hi, > > > ma...@denx.de wrote on Mon, 17 Jul 2023 13:21:34 +0200: > > > >> Extend the driver core to perform looku

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-28 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Mon, 24 Jul 2023 14:13:45 -0400: > On Sun, Jul 23, 2023 at 07:49:55PM +0200, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 17 Jul 2023 13:21:34 +0200: > > > > > Extend the driver core to perfo

Re: [PATCH v2 1/4] cmd: bind: Add unbind command with driver filter

2023-07-23 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 17 Jul 2023 13:21:34 +0200: > Extend the driver core to perform lookup by both OF node and driver > bound to the node. Use this to look up specific device instances to > unbind from nodes in the unbind command. One example where this is > needed is USB

Re: [PATCH 0/2] Fix network commands w/ USB Eth gadget

2023-07-23 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Sat, 22 Jul 2023 10:43:37 -0400: > On Sat, Jul 22, 2023 at 12:25:35AM +0200, Miquel Raynal wrote: > > > Hello, > > > > I recently came across serious issues using U-Boot on Beagle Bone > > Black. The USB Ethern

Re: data abort when run 'dhcp'

2023-07-21 Thread Miquel Raynal
Hi qianfan, qianfangui...@163.com wrote on Fri, 21 Jul 2023 08:31:17 +0800: > 在 2023/7/21 0:39, Miquel Raynal 写道: > > Hello, > > > > qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > > > >> It's very strange. And I can't detect it's a

[PATCH 2/2] net: tftp: Prevent too early device removal leading to data aborts

2023-07-21 Thread Miquel Raynal
een identified to later lead to serious data aborts within malloc() execution. Let's just drop this eth_alt() call which is happening too early, and is redundant anyway. Suggested-by: Qianfan Zhao Signed-off-by: Miquel Raynal --- net/tftp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ne

[PATCH 1/2] net: eth-uclass: Prevent data aborts with the Ethernet USB gadget

2023-07-21 Thread Miquel Raynal
-off-by: Qianfan Zhao [Miquel Raynal: Write a new commit message to argue why this fix is important] Signed-off-by: Miquel Raynal --- net/eth-uclass.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/net/eth-uclass.c b/net/eth-uclass.c index b01a910938e..bf

[PATCH 0/2] Fix network commands w/ USB Eth gadget

2023-07-21 Thread Miquel Raynal
iven how serious these issues are, so whatever solution is preferred, I hope one will soon be picked-up :-) Thanks, Miquèl Miquel Raynal (1): net: tftp: Prevent too early device removal leading to data aborts Qianfan Zhao (1): net: eth-uclass: Prevent data aborts with the Ethern

Re: data abort when run 'dhcp'

2023-07-21 Thread Miquel Raynal
Hi Tom, tr...@konsulko.com wrote on Thu, 20 Jul 2023 14:34:52 -0400: > On Thu, Jul 20, 2023 at 06:39:17PM +0200, Miquel Raynal wrote: > > Hello, > > > > qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > > > > > It's very strange.

Re: data abort when run 'dhcp'

2023-07-21 Thread Miquel Raynal
Hi Heinrich, xypron.g...@gmx.de wrote on Thu, 20 Jul 2023 19:55:39 +0200: > Am 20. Juli 2023 18:39:17 MESZ schrieb Miquel Raynal > : > >Hello, > > > >qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > > > >> It's very strange. And I can

Re: data abort when run 'dhcp'

2023-07-20 Thread Miquel Raynal
Hello, qianfangui...@163.com wrote on Fri, 25 Mar 2022 18:04:46 +0800: > It's very strange. And I can't detect it's a bug of usb or dlmalloc. > > 1. Starting u-boot and dhcp via am335x's ethernet(cpsw driver), it's ok. > > 2. Starting u-boot and dhcp via am335x's usb net, data abort. > > 3.

Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer

2023-03-09 Thread Miquel Raynal
Hello, ra...@milecki.pl wrote on Thu, 09 Mar 2023 12:52:37 +0100: > On 2023-03-09 12:44, Srinivas Kandagatla wrote: > > On 09/03/2023 11:23, Miquel Raynal wrote: > >> Hi Srinivas, > >> >> srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 >&

Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer

2023-03-09 Thread Miquel Raynal
Hi Srinivas, srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 +: > On 09/03/2023 10:32, Miquel Raynal wrote: > > Hi Srinivas, > > > > srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 +: > > > >> On 2

Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer

2023-03-09 Thread Miquel Raynal
Hi Srinivas, srinivas.kandaga...@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 +: > On 22/02/2023 17:22, Rafał Miłecki wrote: > > @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct nvmem_device > > *nvmem, > > if (!nvmem) > > return -EINVAL; > > > + /*

Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-23 Thread Miquel Raynal
Hi Marek, marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 14:56:41 +0100: > On 2/23/23 08:17, Miquel Raynal wrote: > > Hello Marek & Ralph, > > > > marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 01:12:49 +0100: > > > >> On 2/22/23 20:32, Ralph Sie

Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

2023-02-22 Thread Miquel Raynal
Hello Marek & Ralph, marek.va...@mailbox.org wrote on Thu, 23 Feb 2023 01:12:49 +0100: > On 2/22/23 20:32, Ralph Siemsen wrote: > > On Wed, Feb 22, 2023 at 07:45:45PM +0100, Marek Vasut wrote: > >> On 2/22/23 19:32, Ralph Siemsen wrote: > >>> On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-06 Thread Miquel Raynal
On Tue, 2023-01-24 at 10:44:44 UTC, Francesco Dolcini wrote: > From: Francesco Dolcini > > Add a mechanism to handle the case in which partitions are present as > direct child of the nand controller node and #size-cells is set to <0>. > > This could happen if the nand-controller node in the DTS

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-03 Thread Miquel Raynal
Hi Francesco, france...@dolcini.it wrote on Fri, 03 Feb 2023 19:03:27 +0100: > Il 3 febbraio 2023 16:12:02 CET, Miquel Raynal ha > scritto: > >Hi Francesco, > > > >france...@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34 +0100: > > > >> On Thu, Jan 26,

  1   2   3   4   5   6   7   8   9   10   >