Hi Marek, [email protected] wrote on Sat, 19 Aug 2023 16:23:51 +0200:
> Pull the functionality of UDC uclass that operates on plain udevice > and does not use this dev_array array into separate functions and > expose those functions, so that as much code as possible can be > switched over to these functions and the dev_array can be dropped. > > Signed-off-by: Marek Vasut <[email protected]> > --- > Cc: Angus Ainslie <[email protected]> > Cc: Dmitrii Merkurev <[email protected]> > Cc: Eddie Cai <[email protected]> > Cc: Kever Yang <[email protected]> > Cc: Lukasz Majewski <[email protected]> > Cc: Miquel Raynal <[email protected]> > Cc: Mattijs Korpershoek <[email protected]> > Cc: Nishanth Menon <[email protected]> > Cc: Patrice Chotard <[email protected]> > Cc: Patrick Delaunay <[email protected]> > Cc: Philipp Tomsich <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: Stefan Roese <[email protected]> > Cc: [email protected] > --- Would you mind adding a cover letter to your series? It would be easier for us to (a) know what is the final purpose of the series and (b) have a location where to send global feedback. Indeed, I did not yet investigate, in particular because every time fastboot is broken I cannot easily test new images without going through a whole recovery step with another image, but it seems like the network over USB is no longer working (not 100% sure about that one, sometimes the network is capricious) and anyway just calling unbind crashes: => dm tree [...] misc 0 [ + ] ti-musb-wrapper | |-- usb@47400000 usb 0 [ + ] ti-musb-peripheral | | |-- usb@47401000 ethernet 1 [ + ] usb_ether | | | `-- usb_ether bootdev 3 [ ] eth_bootdev | | | `-- usb_ether.bootdev usb 0 [ ] ti-musb-host | | `-- usb@47401800 => unbind ethernet 1 data abort pc : [<9ff9a0e6>] lr : [<9ff9a0e7>] reloc pc : [<808350e6>] lr : [<808350e7>] sp : 9df2f998 ip : 0000001c fp : 00000003 r10: 9df4d800 r9 : 9df44ea0 r8 : 9ffe4a0c r7 : 9ff82ad9 r6 : 9df4d800 r5 : 84000000 r4 : 9df4cf48 r3 : 9ff9a0e1 r2 : 00000000 r1 : 00000000 r0 : 00000000 Flags: NzCv IRQs off FIQs on Mode SVC_32 (T) Code: 9ffd b508 f7ec fe63 (f8d0) 00b0 Resetting CPU ... Thanks, Miquèl
