Re: [PATCH 0/3] arm: dts: am62-beagleplay: Fix Beagleplay Ethernet

2024-05-10 Thread Nishanth Menon
s on route to kernel master anyways, was planning on OF_UPSTREAM migration for beagle once we settle 6.10-rc1 settles into u-boot. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v2 3/6] arch: arm: dts: k3-am68-sk-r5: Sync with J721s2 R5 file

2024-05-09 Thread Nishanth Menon
will clarify. > new power domain helps in holding A72 in reset for configuration of > firewalls. s/A72/A72 Cluster/ [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Nishanth Menon
will be needed as well. I see the same bug on latest next as well (ab8d9ca3044a Merge tag 'v2024.04-rc5' into next) https://gist.github.com/nmenon/691ccd210ed7e1add4c865ca9a698f2e -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v2] net: ti: am65-cpsw-nuss: handle missing PHY in am65_cpsw_phy_init() gracefully

2024-03-28 Thread Nishanth Menon
EATURES; > int ret; > > + if (!priv->has_phy || !cpsw_common->bus) > + return 0; > + > phydev = phy_connect(cpsw_common->bus, >priv->phy_addr, >priv->dev, > -- > 2.44

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-26 Thread Nishanth Menon
spl/dts/k3-am625-beagleplay.dtb" > +#define BOARD_DESCRIPTION "k3-am625-beagleplay" > +#define UBOOT_BOARD_DESCRIPTION "U-Boot for AM625 BeaglePlay" > + > +#include "k3-am625-sk-binman.dtsi" Drop the "sk" ? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 2/4] arm: dts: k3-j7200: Fix support for OSPI flash

2024-03-06 Thread Nishanth Menon
; index 018faaa13b..195637a836 100644 > > --- a/arch/arm/dts/k3-j7200-r5-common-proc-board.dts > > +++ b/arch/arm/dts/k3-j7200-r5-common-proc-board.dts > > @@ -83,3 +83,8 @@ > > _vtm0 { > > bootph-pre-ram; > > }; > > + > > + { > > +reg = <0x0 0x4704 0x0 0x100>, > > + <0x0 0x5000 0x0 0x800>; > > +}; > > With change in commit message, > > Reviewed-by: Udit Kumar > > > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 1/4] configs: j7200_evm_*_defconfig: Enable OSPI configs

2024-03-06 Thread Nishanth Menon
Limaye > > --- > > configs/j7200_evm_a72_defconfig | 10 -- > > configs/j7200_evm_r5_defconfig | 9 +++-- > > 2 files changed, 15 insertions(+), 4 deletions(-) > > Could we not do fragments? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] arch: mach-k3: fix mapping higher DDR addresses as device memory

2024-02-22 Thread Nishanth Menon
.size = 0x38000UL, > .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | >PTE_BLOCK_NON_SHARE | >PTE_BLOCK_PXN | PTE_BLOCK_UXN > -- > 2.34.1 > https://lore.kernel.org/u-boot/20240119160900.GU12635@bill-the-cat/ ?? Something was missing? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH V2 4/5] board: beagle: beagleplay: Configure debounce registers

2024-02-20 Thread Nishanth Menon
Configure the debounce configuration that makes sense for BeaglePlay usage model. Signed-off-by: Nishanth Menon --- Changes since V1: * No change V1: https://lore.kernel.org/r/20240212155332.541949-5...@ti.com board/beagle/beagleplay/beagleplay.c | 24 1 file changed

[PATCH V2 3/5] arm: mach-k3: am62: Add Debounce configuration register definitions

2024-02-20 Thread Nishanth Menon
Add the Debounce configuration registers that need to be configured one time for the platform for the entire SoC. Signed-off-by: Nishanth Menon --- Changes since V1: * Fix 4080 to 0x4080 V1: https://lore.kernel.org/r/20240212155332.541949-4...@ti.com arch/arm/mach-k3/include/mach

[PATCH V2 5/5] board: beagle: beagleplay: env: Drop usb and pxe as boot targets

2024-02-20 Thread Nishanth Menon
of what ever form. This is the one that Jan noticed in his log. We can enable these on a later date once things are working. Cc: Roger Quadros Reported-by: Jan Kiszka Closes: https://lore.kernel.org/all/782ea2c0-eef5-478d-a122-cc6e2d066...@siemens.com/ Signed-off-by: Nishanth Menon --- - New

[PATCH V2 0/5] board: beagle: Enable 32k and debounce configuration and fixups

2024-02-20 Thread Nishanth Menon
noticed - Fixup for the fat finger missing 0x in 0x4080 :( V1: https://lore.kernel.org/all/20240212155332.541949-1...@ti.com/ Nishanth Menon : board: beagle: beagleplay: Enable 32k crystal configs: am62x_beagleplay_r5_defconfig: Enable SPL_BOARD_INIT arm: mach-k3: am62: Add Debounce configuration

[PATCH V2 1/5] board: beagle: beagleplay: Enable 32k crystal

2024-02-20 Thread Nishanth Menon
, do the same from R5 context. Tested-by: Robert Nelson Signed-off-by: Nishanth Menon --- Changes from V1: * Added Robert's tested by. V1: https://lore.kernel.org/r/20240212155332.541949-2...@ti.com board/beagle/beagleplay/beagleplay.c | 37 1 file changed, 37

[PATCH V2 2/5] configs: am62x_beagleplay_r5_defconfig: Enable SPL_BOARD_INIT

2024-02-20 Thread Nishanth Menon
Enable CONFIG_SPL_BOARD_INIT to configure the 32k crystal. Signed-off-by: Nishanth Menon --- Changes since V1: * No change V1: https://lore.kernel.org/r/20240212155332.541949-3...@ti.com configs/am62x_beagleplay_r5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

2024-02-20 Thread Nishanth Menon
2024.01 release. boot_targets=mmc1 mmc0 usb pxe networking ran into some significant challenges. I was hoping to get networking merged but the series got offset and network never made it.. Dropping pxe from boot_targets => setenv boot_targets mmc1 mmc0 usb => print bootmeths bootmeths=script extlinux efi pxe => print boot_targets boot_targets=mmc1 mmc0 usb => bootflow scan -l Scanning for bootflows in all bootdevs Seq Method State UclassPart Name Filename --- --- -- Scanning bootdev 'mmc@fa0.bootdev': 0 extlinux ready mmc 1 mmc@fa0.bootdev.part_ /extlinux/extlinux.conf Scanning bootdev 'mmc@fa1.bootdev': 1 extlinux ready mmc 1 mmc@fa1.bootdev.part_ /extlinux/extlinux.conf Unknown uclass 'usb' in label No more bootdevs --- --- -- (2 bootflows, 2 valid) => -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

2024-02-20 Thread Nishanth Menon
/upstream/ -> we are trying to do that on TI side, though it is still in infancy and test coverage is still more to be desired. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 12/16] arm: dts: Introduce j784s4 u-boot dts files

2024-02-16 Thread Nishanth Menon
ion to start off a series cleaning up and using templating for all the > devices. Sure, as long you can do this by the next window. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH 03/11] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3

[PATCH 10/11] board: beagle: beagleplay: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-11...@ti.com board/beagle/beagleplay

[PATCH 02/11] board: ti: common: Introduce a common fdt ops library

2024-02-12 Thread Nishanth Menon
-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-3...@ti.com board/ti/common/Kconfig | 12 board/ti/common/Makefile | 1 + board/ti/common/fdt_ops.c | 64

[PATCH 05/11] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-6...@ti.com board/ti/am64x/am64x.env | 9 - board/ti/am64x/evm.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/board/ti/am64x/am64x.env b/boar

[PATCH 06/11] board: ti: am65x: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-7...@ti.com board/ti/am65x/am65x.env | 3 --- board/ti/am65x/evm.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/board/ti/am65x/am65x.env b/board/ti/am65x/am65x

[PATCH 08/11] board: ti: j721s2: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-9...@ti.com board/ti/j721s2/evm.c | 8 board/ti/j721s2/j721s2.env | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/board/ti/j721s2/evm.c b/board

[PATCH 00/11] board/ti: k3 boards: Stop using findfdt

2024-02-12 Thread Nishanth Menon
/20240130130615.670783-1...@ti.com/ V2: https://lore.kernel.org/all/20240109191506.3820908-1...@ti.com/ V1: https://lore.kernel.org/all/20240108173301.2692332-1...@ti.com/ Nishanth Menon (11): board: ti: Add missing common/Kconfig references board: ti: common: Introduce a common fdt ops library board

[PATCH 04/11] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes since V3: * Add missing

[PATCH 11/11] include: env: ti: Drop default_findfdt

2024-02-12 Thread Nishanth Menon
We shouldn't need finfdt anymore. Drop the env script. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-12...@ti.com include/env/ti/default_findfdt.env | 12

[PATCH 09/11] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-10...@ti.com board/beagle

[PATCH 01/11] board: ti: Add missing common/Kconfig references

2024-02-12 Thread Nishanth Menon
Add missing board/ti/common/Kconfig references for the platforms that missed it. The intent is for the common Kconfig to be usable across TI reference boards as required. Reported-by: Tom Rini Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r

[PATCH 07/11] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-02-12 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes since V3: * No change V3: https://lore.kernel.org/r/20240130130615.670783-8...@ti.com board/ti/j721e/evm.c | 8 board/ti/j721e/j721e.env | 10 -- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/board/ti/j721e/evm.c b/board/ti/j

Re: [PATCH 3/4] arm: mach-k3: am62: Add Debounce configuration register definitions

2024-02-12 Thread Nishanth Menon
On 09:53-20240212, Nishanth Menon wrote: > Add the Debounce configuration registers that need to be configured one > time for the platform for the entire SoC. > > Signed-off-by: Nishanth Menon > --- > arch/arm/mach-k3/include/mach/am62_hardware.h | 3 +++ > 1 file

[PATCH 1/4] board: beagle: beagleplay: Enable 32k crystal

2024-02-12 Thread Nishanth Menon
, do the same from R5 context. Signed-off-by: Nishanth Menon --- board/beagle/beagleplay/beagleplay.c | 37 1 file changed, 37 insertions(+) diff --git a/board/beagle/beagleplay/beagleplay.c b/board/beagle/beagleplay/beagleplay.c index 20819ecf45b4..a75b3145fa37

[PATCH 4/4] board: beagle: beagleplay: Configure debounce registers

2024-02-12 Thread Nishanth Menon
Configure the debounce configuration that makes sense for BeaglePlay usage model. Signed-off-by: Nishanth Menon --- board/beagle/beagleplay/beagleplay.c | 24 1 file changed, 24 insertions(+) diff --git a/board/beagle/beagleplay/beagleplay.c b/board/beagle/beagleplay

[PATCH 2/4] configs: am62x_beagleplay_r5_defconfig: Enable SPL_BOARD_INIT

2024-02-12 Thread Nishanth Menon
Enable CONFIG_SPL_BOARD_INIT to configure the 32k crystal. Signed-off-by: Nishanth Menon --- configs/am62x_beagleplay_r5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am62x_beagleplay_r5_defconfig b/configs/am62x_beagleplay_r5_defconfig index 2f3264b7ede6..9413c859870f

[PATCH 0/4] board: beagle: Enable 32k and debounce configuration

2024-02-12 Thread Nishanth Menon
e8f2404e093d + the findfdt series[2]. Nishanth Menon (4): board: beagle: beagleplay: Enable 32k crystal configs: am62x_beagleplay_r5_defconfig: Enable SPL_BOARD_INIT arm: mach-k3: am62: Add Debounce configuration register definitions board: beagle: beagleplay: Configure debounce registers

[PATCH 3/4] arm: mach-k3: am62: Add Debounce configuration register definitions

2024-02-12 Thread Nishanth Menon
Add the Debounce configuration registers that need to be configured one time for the platform for the entire SoC. Signed-off-by: Nishanth Menon --- arch/arm/mach-k3/include/mach/am62_hardware.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-k3/include/mach/am62_hardware.h

Re: [PATCH 2/2] arm: dts: k3-am64: Sync with kernel v6.8-rc1

2024-02-02 Thread Nishanth Menon
On 16:27-20240201, Andrew Davis wrote: > Sync with kernel v6.8-rc1 and sync up the u-boot dts files accordingly. > > Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH V3 09/11] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-9...@ti.com

[PATCH V3 06/11] board: ti: am65x: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-6...@ti.com board/ti/am65x/am65x.env | 3 --- board/ti/am65x/evm.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/board/ti/am65x/am65x.env

[PATCH V3 11/11] include: env: ti: Drop default_findfdt

2024-01-30 Thread Nishanth Menon
We shouldn't need finfdt anymore. Drop the env script. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-11...@ti.com include/env/ti

[PATCH V3 04/11] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than

[PATCH V3 05/11] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-5...@ti.com board/ti/am64x/am64x.env | 9 - board/ti/am64x/evm.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/boar

[PATCH V3 07/11] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-7...@ti.com board/ti/j721e/evm.c | 8 board/ti/j721e/j721e.env | 10 -- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/boar

[PATCH V3 03/11] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than

[PATCH V3 02/11] board: ti: common: Introduce a common fdt ops library

2024-01-30 Thread Nishanth Menon
-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-2...@ti.com board/ti/common/Kconfig | 12 board/ti/common/Makefile | 1 + board/ti/common

[PATCH V3 10/11] board: beagle: beagleplay: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Reviewed-by: Jonathan Humphreys Reviewed-by: Roger Quadros Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-10...@ti.com

[PATCH V3 01/11] board: ti: Add missing common/Kconfig references

2024-01-30 Thread Nishanth Menon
Add missing board/ti/common/Kconfig references for the platforms that missed it. The intent is for the common Kconfig to be usable across TI reference boards as required. Reported-by: Tom Rini Signed-off-by: Nishanth Menon --- New patch: Fixed build fail that Tom noted: https

[PATCH V3 08/11] board: ti: j721s2: Set fdtfile from C code instead of findfdt script

2024-01-30 Thread Nishanth Menon
Signed-off-by: Nishanth Menon --- Changes in V3: - none other than picking up reviews. V2: https://lore.kernel.org/r/20240109191506.3820908-8...@ti.com board/ti/j721s2/evm.c | 8 board/ti/j721s2/j721s2.env | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/board

[PATCH V3 00/11] board/ti: k3 boards: Stop using findfdt

2024-01-30 Thread Nishanth Menon
LATE_INIT) and CHECK (fdt_ops #ifdeffery) that on closer inspection looks fine and consistent with other similar usage. V2: https://lore.kernel.org/all/20240109191506.3820908-1...@ti.com/ V1: https://lore.kernel.org/all/20240108173301.2692332-1...@ti.com/ Nishanth Menon (11): board: ti: Add missing

Re: [PATCH V4 2/2] firmware: ti_sci: Add comment explaining the is_secure code

2024-01-30 Thread Nishanth Menon
de" when it hands off from Boot > + * ROM over to the Secondary bootloader. The initial set of calls > + * we have to make need to be on a secure pipe. > + */ > if (info->is_secure) { > /* ToDo: get checksum of the entire message

Re: [PATCH V4 1/2] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-30 Thread Nishanth Menon
sures > the first 4 bytes of secure_buf are 0. > > Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control > Interface (TI SCI)") > Cc: Nishanth Menon > Cc: Andrew Davis > Cc: Manorit Chawdhry > Signed-off-by: Dhruva Gole > --- > driver

Re: [PATCH V3] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-29 Thread Nishanth Menon
On 11:44-20240129, Dhruva Gole wrote: > On Jan 24, 2024 at 12:09:06 -0600, Nishanth Menon wrote: > > On 18:37-20240124, Dhruva Gole wrote: > > > The secure_hdr needs to be 0 init-ed however this was never being put > > > into the secure_buf, leading to possi

Re: [PATCH v8 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2024-01-29 Thread Nishanth Menon
On 17:02-20240129, Apurva Nandan wrote: > Hi, > > On 24/01/24 02:17, Nishanth Menon wrote: > > On 20:21-20240123, Apurva Nandan wrote: > > [...] > > > > > +void k3_mem_init(void) > > > > > +{ > > > >

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-25 Thread Nishanth Menon
t - which again, we should probably document in the code so that people don't go scratching our heads again. That is unfortunately confusing enough for code since 99% of rest of u-boot flow does not use secure comm path. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 5

Re: [RFC PATCH v3 02/15] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-01-24 Thread Nishanth Menon
fw_ubi_mtdpart"); > ubi_volume = env_get("fw_ubi_volume"); > -- > 2.34.1 > You should move these specific patches out of the series and debate on their merits seperately. mixing things like these in a single series that needs to go to multiple u-boot custodians just creates problems for everyone. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 1/2] env: ti: mmc: add save_uenv command

2024-01-24 Thread Nishanth Menon
t} = yes || test ${boot_fdt} = try; then > if run get_fdt_mmc; then > > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH V3] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Nishanth Menon
ty on AM62x SK > https://gist.github.com/DhruvaG2000/724ceba3a0db03f4b0bff47de1160074 > > Changelog: > v2 --> v3 > Address Kamlesh's comment on v2: use sizeof(struct ti_sci_secure_msg_hdr) Lets finish discussing in: https://lore.kernel.org/all/20240124163910.sp7gt56lihoujm7k@etching/

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Nishanth Menon
On 23:07-20240124, Dhruva Gole wrote: > On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote: > > On 18:38-20240124, Dhruva Gole wrote: > > > On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote: > > > > Dhruva Gole writes: > > > > > > &g

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-24 Thread Nishanth Menon
> Fixes: 32cd25128bd849 ("firmware: Add basic support for TI System Control > > > Interface (TI SCI)") > > > Signed-off-by: Dhruva Gole > > > --- > > > > > > Boot tested for sanity on AM62x SK > > > https://gist.github.com/DhruvaG2

Re: [PATCH 07/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS

2024-01-23 Thread Nishanth Menon
On 15:49-20240122, Chintan Vankar wrote: > > On 12/01/24 18:00, Nishanth Menon wrote: > > On 12:17-20240112, Siddharth Vadapalli wrote: > > > From: Kishon Vijay Abraham I > > > > > > In order to support Ethernet boot on AM62x, probe AM65 CPSW NUSS

Re: [PATCH v8 12/16] arm: dts: Introduce j784s4 u-boot dts files

2024-01-23 Thread Nishanth Menon
dtbs it needs. > - The board binman files will include these templates and update the dtb > files in them. Correct. > - Final board.dts will use the correct board-binman.dtsi files if the templates are abstract enough, the additional code will be so minimal that we wont need a board-b

Re: [PATCH v8 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2024-01-23 Thread Nishanth Menon
> > Next time, please respond to the review comment questions so that I > > know that you have considered and decided something is not necessary > > or something was missed in the new version - for example what happened > > to mmc_stop/restart? > mmc_stop/restart were removed (mentioned in series changelog) Mentioning in diffstat of the patch helps give people the context of the change w.r.t the path itself. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 09/16] board: ti: j784s4: Add board support for J784S4 EVM

2024-01-19 Thread Nishanth Menon
nitialization for J784S4 EVM > + * > + * Copyright (C) 2023-2024 Texas Instruments Incorporated - > https://www.ti.com/ > + * Hari Nagalla > + * > + */ > + > +#include > +#include > +#include > +#include Are you sure we need all the above headers? > +#include "../common/fdt_ops.h" [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2024-01-19 Thread Nishanth Menon
break; > + } > + ctr++; What is the use of ctr++ ?? please do a limit check for instances. [...] Next time, please respond to the review comment questions so that I know that you have considered and decided something is not necessary or something was missed in the new version - for example what happened to mmc_stop/restart? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 04/16] arm: dts: Add bootph-all for memory node

2024-01-19 Thread Nishanth Menon
emory@8000 { > device_type = "memory"; > + bootph-all; > /* 32G RAM */ > reg = <0x00 0x8000 0x00 0x80000000>, > <0x08 0x8000 0x07 0x8000>; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v8 12/16] arm: dts: Introduce j784s4 u-boot dts files

2024-01-19 Thread Nishanth Menon
readily include the template for the binaries of choice and generate just relevant output. Wont it save much confusion? [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-19 Thread Nishanth Menon
quot;test: hush: dollar: fix bugous behavior" -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 0/2] arm: dts: Add Itap Delay Value For High Speed DDR

2024-01-19 Thread Nishanth Menon
.3490141.14935960940418963459.b4...@ti.com/ > > > > So , kernel and uboot dt files will remain in sync. > > > > Sorry I may be missing something. Why do we need these properties in > U-Boot now? Why not wait 2 weeks for the v6.8-rc1 tag in Linux and sync > everything all at once? I agree. NAK for the series. Please get this part of dts sync. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-01-12 Thread Nishanth Menon
about redoing work if the baseline changes or has a reasonable chance of change.. Just doing it once and cleanly is my preference. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-01-12 Thread Nishanth Menon
orms still keep u-boot in emmc boot0 and depending on the part and TEE binary size, the available space can be constraining) I am starting to wonder if https://lore.kernel.org/u-boot/20231101170519.39627-1-...@ti.com/ will help us here. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 4/5] arm: dts: k3-j721e-beagleboneai64: Fix USB operation

2024-01-12 Thread Nishanth Menon
On 15:06-20240112, Roger Quadros wrote: > > > On 12/01/2024 15:02, Nishanth Menon wrote: > > On 14:49-20240112, Roger Quadros wrote: > >> Without correct SERDES MUX and Lane control settings > >> USB0 will be broken. Set the MUX and Lane control

Re: [PATCH 4/5] arm: dts: k3-j721e-beagleboneai64: Fix USB operation

2024-01-12 Thread Nishanth Menon
oot,mux-autoprobe; > }; > > _wiz2 { > -- > 2.34.1 > Is this a u-boot thing? or a driver limitation? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 00/10] Add support for Ethernet Boot on SK-AM62

2024-01-12 Thread Nishanth Menon
On 18:17-20240112, Siddharth Vadapalli wrote: > > > On 12/01/24 18:12, Nishanth Menon wrote: > > On 18:06-20240112, Siddharth Vadapalli wrote: > >> > >> > >> On 12/01/24 18:02, Nishanth Menon wrote: > >>> On 12:17-20240112, Siddharth Va

Re: [PATCH 00/10] Add support for Ethernet Boot on SK-AM62

2024-01-12 Thread Nishanth Menon
On 18:06-20240112, Siddharth Vadapalli wrote: > > > On 12/01/24 18:02, Nishanth Menon wrote: > > On 12:17-20240112, Siddharth Vadapalli wrote: > >> Hello, > >> > >> This series enables Ethernet Boot on SK-AM62 device. > >> Product Link: htt

Re: [PATCH 01/10] board: ti: am62x: Init DRAM size in R5/A53 SPL

2024-01-12 Thread Nishanth Menon
On 18:01-20240112, Siddharth Vadapalli wrote: > Hello Nishanth, > > On 12/01/24 17:56, Nishanth Menon wrote: > > On 12:17-20240112, Siddharth Vadapalli wrote: > >> From: Kishon Vijay Abraham I > >> > >> Call dram_init_banksize() from spl_board_init() oth

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-01-12 Thread Nishanth Menon
ONFIG_USB_GADGET_PRODUCT_NUM=0x6165 > +CONFIG_USB_GADGET_DOWNLOAD=y > +CONFIG_SPL_DFU=y > +# CONFIG_SPL_MMC is not set > +# CONFIG_SPL_FS_FAT is not set > +# CONFIG_SPL_LIBDISK_SUPPORT is not set > +# CONFIG_SPL_SPI is not set > +# CONFIG_SPL_SYS_MALLOC is not set > +# CONFIG_CMD_GPT is not set > +# CONFIG_CMD_MMC is not set > +# CONFIG_CMD_FAT is not set > +# CONFIG_MMC_SDHCI is not set > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 7/7] doc: board: Add document for DFU boot on am62x SoCs

2024-01-12 Thread Nishanth Menon
reset has to be done after each upload. > + > +When using dfu-util the following commands can be used to boot to a u-boot > shell: > + > +.. prompt:: bash $ > + > + dfu-util -a bootloader -D tiboot3.bin > + dfu-util -R -a tispl -D tispl.bin > + dfu-util -R -a u-boot.img -D u-boot.img > + > +.. am62x_evm_rst_include_end_dfu_boot > + > Debugging U-Boot > > > -- > 2.43.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v4 6/7] beagleplay: Add DFU support

2024-01-12 Thread Nishanth Menon
; +CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_DWC3=y > +CONFIG_USB_DWC3=y > +CONFIG_USB_DWC3_GENERIC=y > +CONFIG_SPL_USB_DWC3_GENERIC=y > +CONFIG_SPL_USB_DWC3_AM62=y > +CONFIG_USB_DWC3_AM62=y > +CONFIG_USB_GADGET=y > +CONFIG_SPL_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="Texa

Re: [PATCH 09/10] configs: am62x_evm_a53_defconfig: Enable configs required for Ethboot

2024-01-12 Thread Nishanth Menon
;AM62X U-Boot A53 SPL" > CONFIG_SPL_POWER_DOMAIN=y > # CONFIG_SPL_SPI_FLASH_TINY is not set > CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y > @@ -61,6 +68,7 @@ CONFIG_SPL_DM=y > CONFIG_SPL_DM_SEQ_ALIAS=y > CONFIG_REGMAP=y > CONFIG_SPL_REGMAP=y > +CONFIG_SPL_SYSCON=y &

Re: [PATCH 00/10] Add support for Ethernet Boot on SK-AM62

2024-01-12 Thread Nishanth Menon
arch/arm/mach-k3/am625_init.c| 10 +++ > arch/arm/mach-k3/r5/am62x/clk-data.c | 79 > board/ti/am62x/evm.c | 3 + > configs/am62x_evm_a53_defconfig | 8 ++ > configs/am62x_evm_r5_ethboot_defconfig | 110 +++ &

Re: [PATCH 08/10] configs: am62: Add configs for enabling ETHBOOT in R5SPL

2024-01-12 Thread Nishanth Menon
y Abraham I > Signed-off-by: Andreas Dannenberg > Signed-off-by: Siddharth Vadapalli > --- > configs/am62x_evm_r5_ethboot_defconfig | 110 + NAK. use config fragments please. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 07/10] arm: mach-k3: am625_init: Probe AM65 CPSW NUSS

2024-01-12 Thread Nishanth Menon
IG_TI_AM65_CPSW_NUSS) > && > + spl_boot_device() == BOOT_DEVICE_ETHERNET) { > + struct udevice *cpswdev; > + > + if (uclass_get_device_by_driver(UCLASS_MISC, > DM_DRIVER_GET(am65_cpsw_nuss), > + )) > +

Re: [PATCH 06/10] arm: mach-k3: am62: Update SoC autogenerated data to enable Ethernet Boot

2024-01-12 Thread Nishanth Menon
.. could please elaborate in the commit message. > > Signed-off-by: Andreas Dannenberg > Signed-off-by: Siddharth Vadapalli > --- > arch/arm/mach-k3/r5/am62x/clk-data.c | 79 ++-- > 1 file changed, 39 insertions(+), 40 deletions(-) > [...] -

Re: [PATCH 01/10] board: ti: am62x: Init DRAM size in R5/A53 SPL

2024-01-12 Thread Nishanth Menon
> splash_display(); > > + if (IS_ENABLED(CONFIG_SPL_ETH)) > + /* Init DRAM size for R5/A53 SPL */ > + dram_init_banksize(); > } > > #if defined(CONFIG_K3_AM64_DDRSS) > -- > 2.34.1 > Are you sure? tftp seems to work without

Re: [PATCH v7 15/17] configs: Add am69_sk_* defconfig fragments

2024-01-11 Thread Nishanth Menon
nfigs directory? > Else we will just keep polluting the configs directory. Correct - fragments should be in board/ti/.../ folder. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH v7 15/17] configs: Add am69_sk_* defconfig fragments

2024-01-11 Thread Nishanth Menon
On 15:06-20240111, Manorit Chawdhry wrote: > Hi Nishanth, > > On 11:59-20240103, Nishanth Menon wrote: > > On 00:45-20231220, Apurva Nandan wrote: > > > From: Dasnavis Sabiya > > > > > > Add config fragments for am69_sk A72 and R

Re: [PATCH V2 10/10] include: env: ti: Drop default_findfdt

2024-01-10 Thread Nishanth Menon
_BOOTCOMMAND="run findfdt; run distro_bootcmd" > omap4_panda_defconfig:CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then run > update_to_fit; fi; run findfdt; run init_console; run envboot; run > distro_bootcmd" > omap4_sdp4430_defconfig:CONFIG_BOOTCOMMAND=&q

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
On 21:00-20240109, Francesco Dolcini wrote: > On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: > > On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: > > > On 14:26-20240109, Roger Quadros wrote: > > > > CONFIG_CMD_PMIC=y &

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
e I am not trying to diminish NAND support, we are in a constant struggle to keep SRAM viable and adding additional boot modes to a single config, IMHO is the wrong direction to go. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH] board: ti: am64: Support TMDS64EVM

2024-01-09 Thread Nishanth Menon
quot;) || \ > board_ti_k3_is("AM64-HSEVM")) > > #define board_is_am64x_skevm() (board_ti_k3_is("AM64-SKEVM") || \ > > base-commit: c2c598e87cfe56f5991730762c00733c5aa9a994 > -- > 2.34.1 > Reviewed-by: Nishanth Menon -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
IVERS=y > +CONFIG_SPL_NAND_BASE=y > +CONFIG_SPL_NAND_IDENT=y > +CONFIG_SPL_NAND_ECC=y > +CONFIG_SYS_NAND_MAX_CHIPS=1 > +CONFIG_SYS_MAX_NAND_DEVICE=1 > +# CONFIG_SPL_NAND_AM33XX_BCH is not set > +CONFIG_SPL_MTD_SUPPORT=y > +CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y > +CONFIG_SYS_NAND_U_BOOT_OFFS=0x60 > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D

[PATCH V2 04/10] board: ti: am64x: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None. I hav

[PATCH V2 10/10] include: env: ti: Drop default_findfdt

2024-01-09 Thread Nishanth Menon
We shouldn't need finfdt anymore. Drop the env script. Signed-off-by: Nishanth Menon --- Changes from V1: None. V1: https://lore.kernel.org/r/20240108173301.2692332-11...@ti.com include/env/ti/default_findfdt.env | 12 1 file changed, 12 deletions(-) delete mode 100644 include

[PATCH V2 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Signed-off-by: Nishanth Menon --- Changes from V1: * Just macro name change s/TI_EVM_FDT_FOLDER_PATH/TI_FDT_FOLDER_PATH * Commit message update to drop the "warning added to findfdt" since that is not don

[PATCH V2 00/10] board/ti: k3 boards: Stop using findfdt

2024-01-09 Thread Nishanth Menon
with other similar usage. V1: https://lore.kernel.org/all/20240108173301.2692332-1...@ti.com/ Nishanth Menon (10): board: ti: common: Introduce a common fdt ops library board: ti: am62ax: Set fdtfile from C code instead of findfdt script board: ti: am62x: Set fdtfile from C code instead

[PATCH V2 09/10] board: beagle: beagleplay: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. Signed-off-by: Nishanth Menon --- Changes from V1: * Just macro name change s/TI_EVM_FDT_FOLDER_PATH/TI_FDT_FOLDER_PATH * Commit message update to drop the "warning added to findfdt" since that is not don

[PATCH V2 06/10] board: ti: j721e: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None.

[PATCH V2 07/10] board: ti: j721s2: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
We now can provide a map and have the standard fdtfile variable set from code itself. This allows for bootstd to "just work". While at this, replace findfdt in environment with a warning as it is no longer needed. Signed-off-by: Nishanth Menon --- Changes from V1: None.

[PATCH V2 02/10] board: ti: am62ax: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- Changes from V1: None. I have retained the central call ti_set_fdt_env() to retain the population

[PATCH V2 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-09 Thread Nishanth Menon
-by: Nishanth Menon --- Changes Since v1: * s/TI_EVM_FDT_FOLDER_PATH/TI_FDT_FOLDER_PATH s/name_fdt/board_name s/TI_NAME_FDT_MAX/TI_BOARD_NAME_MAX * Comment updates in various places for review clarification. * Still maintain the fall back using CONFIG_DEFAULT_DEVICE_TREE for reasons explained

[PATCH V2 03/10] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-01-09 Thread Nishanth Menon
Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- Changes from V1: None. I have retained the central call ti_set_fdt_env() to retain the population

  1   2   3   4   5   6   7   8   9   10   >