Re: [U-Boot] [PATCH 2/2] mmc: Fix erase_grp_size for partitioned card

2013-10-31 Thread Pantelis Antoniou
AILABLE (0xff) > #define PART_ACCESS_MASK (0x7) > #define PART_SUPPORT (0x1) > +#define PART_ENH_ATTRIB (0x1f) > > /* Maximum block size for MMC */ > #define MMC_MAX_BLOCK_LEN 512 > -- > 1.8.4 > Applied, thanks. Acked-by: Pantelis Antoniou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] mmc: Fix calculation of capacity for hc cards

2013-10-31 Thread Pantelis Antoniou
Hi Oliver, On Oct 1, 2013, at 9:32 PM, Oliver Metz wrote: > When using a high capacity card with a density less than > 2 GB a wrong size is calculated. According to JEDEC 4.41 there is no > differentiation for C_SIZE register between low and high capacity cards. > Use ext_csd sector count to calc

Re: [U-Boot] Patch about mmc and sdhci, Please look it, i can not pull the patch. I copy it here.

2013-10-30 Thread Pantelis Antoniou
Hi Richie, Please take a look at our patch submission guidelines. http://www.denx.de/wiki/U-Boot/Patches Some of the methods you use are questionable to say the least. Is your magic variable something to do with a quirk? I understand what you're trying to do, but you need to be more forthcoming

Re: [U-Boot] [PATCH 2/2 V2] powerpc/esdhc: Add 3.3v voltage support in esdhc capacity register

2013-10-30 Thread Pantelis Antoniou
Hi Scott, Haijun, On Oct 30, 2013, at 8:58 PM, Scott Wood wrote: > On Wed, 2013-10-30 at 11:36 +0800, Haijun Zhang wrote: >> T4240QDS eSDHC host capabilities reigster should have VS33 bit define. >> Add quirk CONFIG_SYS_FSL_MMC_HAS_CAPBLT_VS33 to deal with capacity >> missing >> >> Signed-off-by

Re: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-29 Thread Pantelis Antoniou
Dear Przemyslaw, On Oct 29, 2013, at 3:24 PM, Przemyslaw Marczak wrote: > Dear Pantelis, > > On 10/29/2013 02:08 PM, Pantelis Antoniou wrote: >> Dear Przemyslaw, >> >> On Oct 29, 2013, at 3:02 PM, Przemyslaw Marczak wrote: >> >>> Dear Pantelis, >

Re: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-29 Thread Pantelis Antoniou
al variable cmd_timeout into function sdhci_send_command() >>> - change condition "==" to ">=" when comparing time with timeout >>> - print information about timeout increasing and card busy timeout >>> >>> Signed-off-by: Przemyslaw Ma

Re: [U-Boot] [PATCH] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-02 Thread Pantelis Antoniou
Hi Przemyslaw, On Oct 1, 2013, at 7:59 PM, Przemyslaw Marczak wrote: > Hello Pantelis, > Thank you for reply > > > On 10/01/2013 05:50 PM, Pantelis Antoniou wrote: >> while (sdhci_readl(host, SDHCI_PRESENT_STATE) & mask) { >> -if (timeou

Re: [U-Boot] [PATCH] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-01 Thread Pantelis Antoniou
Hi there, On Oct 1, 2013, at 3:16 PM, Przemyslaw Marczak wrote: > Old command timeout value was too small and it caused I/O errors which > led to uncompleted read/write/erase operations and filesystem errors. > Timeout adaptation fixes this issue. > > Changes in sdhci_send_command() function: >

Re: [U-Boot] [PATCH 2/2] Armada100: Add SD card support for Marvell gplugD

2013-09-24 Thread Pantelis Antoniou
5,6 +95,15 @@ > #define CONFIG_CMD_SF > #define CONFIG_SPI_FLASH_ATMEL > > +#define CONFIG_MV_SDHCI > +#define CONFIG_SDHCI > +#define CONFIG_CMD_MMC > +#define CONFIG_MMC > +#define CONFIG_GENERIC_MMC > +#define CONFIG_DOS_PARTITION > +#define CONFIG_MMC_SDMA >

Re: [U-Boot] [PATCH 1/2] Armada100: Adds SD/MMC Register definitions

2013-09-24 Thread Pantelis Antoniou
xD4026000 > #define ARMD1_MPMU_BASE 0xD405 > #define ARMD1_USB_HOST_BASE 0xD4209000 > +#define ARMD1_SD1_BASE 0xD428 > +#define ARMD1_SD2_BASE 0xD4281000 > #define ARMD1_APMU_BASE 0xD4282800 > #defin

[U-Boot] Pull request: u-boot-mmc #2

2013-09-20 Thread Pantelis Antoniou
Hi Tom, The following changes since commit 46ef4faed18196472eb95216b2f74c1397ecf024: Prepare v2013.10-rc3 (2013-09-16 20:08:33 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to 2c011847c129491084a19c753a039a3441b7dce4:

Re: [U-Boot] [PATCH 12/12 V3] DWMMC: SMDK5420: Disable SMU for eMMC

2013-09-19 Thread Pantelis Antoniou
Hi Rajesh, Simon, On Sep 19, 2013, at 9:12 AM, Simon Glass wrote: > Hi Rajeshwari, > > On Wed, Sep 11, 2013 at 4:01 AM, Rajeshwari S Shinde > wrote: > SMDK5420 has a new Security Management Unit added > for dwmmc driver, hence, configuring the control > registers to support booting via eMMC. >

[U-Boot] Pull request: u-boot-mmc

2013-09-17 Thread Pantelis Antoniou
Hi Tom, The following changes since commit 46ef4faed18196472eb95216b2f74c1397ecf024: Prepare v2013.10-rc3 (2013-09-16 20:08:33 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to b31c9beb9bdde1714b1131cf0e64b8b68350e824:

Re: [U-Boot] [PATCH] MMC: DWMMC: Correct the CLKDIV register value

2013-09-17 Thread Pantelis Antoniou
Hi Rajesh, I guess we wait for an updated patch here? Regards -- Pantelis On Sep 11, 2013, at 4:25 PM, Rajeshwari Birje wrote: > Hi Jaehoon Chung, > > Thank you for comments, > > > > On Wed, Sep 11, 2013 at 11:31 AM, Jaehoon Chung > wrote: >> On 09/11/2013 02:28 PM, Rajeshwari Birje wrot

Re: [U-Boot] [PATCH] mmc:sdhci: Fix card ready status timeout.

2013-09-16 Thread Pantelis Antoniou
gt; card blocks - timeout causes I/O errors. >> The timeout has been increased to 200ms after data transfer. >> For other transfers it stays unchanged. Default values are >> now defined with "if defined" directive so it can be redefined >> at board config if n

Re: [U-Boot] [PATCH v2] mmc: don't support write & erase for SPL builds

2013-09-09 Thread Pantelis Antoniou
;> Changes in v2: >>> - Move the mmc_bwrite & mmc_berase functions to a new mmc_write.c >>> file which is only compiled for non-SPL builds, as per a request >>> from Pantelis Antoniou. This requires that a few formerly static >>> functions in mmc.c be acce

Re: [U-Boot] [PATCH] mmc:sdhci: Fix card ready status timeout.

2013-09-06 Thread Pantelis Antoniou
Hi there, On Sep 6, 2013, at 6:23 PM, Przemyslaw Marczak wrote: > Hello Pantelis, > > > On 09/06/2013 03:24 PM, Pantelis Antoniou wrote: >> Hi there, >> >> Can we have a config option for these two values instead of magic numbers? >> >>

Re: [U-Boot] [PATCH v2] mmc: don't support write & erase for SPL builds

2013-09-06 Thread Pantelis Antoniou
ighly constrained. > > Signed-off-by: Paul Burton > --- > Changes in v2: > - Move the mmc_bwrite & mmc_berase functions to a new mmc_write.c >file which is only compiled for non-SPL builds, as per a request >from Pantelis Antoniou. This requires that a few

Re: [U-Boot] [PATCH] mmc:sdhci: Fix card ready status timeout.

2013-09-06 Thread Pantelis Antoniou
> For other transfers it stays unchanged. > > Tested on Goni and Trats. > > Signed-off-by: Przemyslaw Marczak > Cc: Pantelis Antoniou > --- > drivers/mmc/sdhci.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/sdhci.

Re: [U-Boot] [PATCH 5/5] mmc: don't support write & erase for SPL builds

2013-09-06 Thread Pantelis Antoniou
Hi Paul, On Sep 4, 2013, at 6:14 PM, Paul Burton wrote: > For SPL builds this is just dead code since we'll only need to read. > Eliminating it results in a significant size reduction for the SPL > binary. > > Signed-off-by: Paul Burton > --- I understand what you're trying to do, but I don't

Re: [U-Boot] [PATCH 3/5] mmc: don't call *printf or puts when SPL & !CONFIG_SPL_LIBCOMMON_SUPPORT

2013-09-06 Thread Pantelis Antoniou
Hi Paul On Sep 6, 2013, at 3:51 PM, Paul Burton wrote: > > On 06/09/13 13:48, Pantelis Antoniou wrote: >> Hi Paul >> >> On Sep 4, 2013, at 6:12 PM, Paul Burton wrote: >> >>> If we don't have CONFIG_SPL_LIBCOMMON_SUPPORT defined then stdio >>&g

Re: [U-Boot] [PATCH 3/5] mmc: don't call *printf or puts when SPL & !CONFIG_SPL_LIBCOMMON_SUPPORT

2013-09-06 Thread Pantelis Antoniou
Hi Paul On Sep 4, 2013, at 6:12 PM, Paul Burton wrote: > If we don't have CONFIG_SPL_LIBCOMMON_SUPPORT defined then stdio > & *printf functions are unavailable & calling them will cause a link > failure. > > Signed-off-by: Paul Burton > --- > drivers/mmc/mmc.c | 36

Re: [U-Boot] [PATCH] mmc: Initialize mmc_devices list statically

2013-09-06 Thread Pantelis Antoniou
Hi Taras, What are you doing that makes you call any of the mmc_devices list functions before calling mmc_initialize() Which board has this problem; this looks like a board problem to me. Regards -- Pantelis On Aug 6, 2013, at 7:41 PM, Taras Kondratiuk wrote: > Currently mmc_device list is

Re: [U-Boot] [u-boot][RFC v1] omap_hsmmc: omap4+/am335x: modify MMC controller internal fsm reset func

2013-09-06 Thread Pantelis Antoniou
t; > So, extend CMD(DATA) lines reset procedure in func > mmc_reset_controller_fsm() by adding the missing step #2 for > OMAP4+/AM335x boards. > > Signed-off-by: Oleksandr Tyshchenko Acked-by: Pantelis Antoniou Thanks ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [u-boot][RFC v1] mmc: Remove unused variable backup from mmc_send_cmd()

2013-09-06 Thread Pantelis Antoniou
Hi Oleksandr, On Aug 6, 2013, at 1:50 PM, Oleksandr Tyshchenko wrote: > Do not call a memset for unused variable backup every time. > Remove unused variable from function. > > Signed-off-by: Oleksandr Tyshchenko Acked-by: Pantelis Anton

Re: [U-Boot] [PATCH] mmc/dw_mmc: Fix DMA descriptor corruption

2013-09-06 Thread Pantelis Antoniou
igned-off-by: Mischa Jonker > Cc: Alexey Brodkin > Cc: Jaehoon Chung > Cc: Andy Fleming Acked-by: Pantelis Antoniou Thanks ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: sdhci: use the SDHCI_QUIRK_USE_WIDE8 for samsung SoC

2013-09-05 Thread Pantelis Antoniou
On Jul 19, 2013, at 11:44 AM, Jaehoon Chung wrote: > Samsung SoC is supported the WIDE8, even if Controller version is v2.0. > So add the SDHCI_QUIRK_USE_WIDE8 for Samsung-SoC. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park Acked-by: Pantelis An

Re: [U-Boot] [PATCH] mmc: sdhci: use the SDHCI_QUIRK_USE_WIDE8 for samsung SoC

2013-08-13 Thread Pantelis Antoniou
Hi Jaehoon, On Aug 13, 2013, at 11:52 AM, Jaehoon Chung wrote: > Dear Pantelis, > > Welcome to take care of u-boot-mmc. > Thanks > Could you merge this patch? > Please hold on a bit; we're still in the process of passing over the (mmc) torch. That patch looks good. > Best Regards, > Jaeh

[U-Boot] [PATCH] git-mailrc: Update MMC custodian

2013-08-08 Thread Pantelis Antoniou
Update git-mailrc with my nick and replace afleming as mmc custodian. Signed-off-by: Pantelis Antoniou --- doc/git-mailrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/git-mailrc b/doc/git-mailrc index e3a47c4..03fc482 100644 --- a/doc/git-mailrc +++ b/doc/git-mailrc

Re: [U-Boot] dfu: using dfu-util -l shows different output

2013-06-25 Thread Pantelis Antoniou
Heiko, I don't think the gadget is initialized before you issue a dfu call. So that makes sense. Let's wait until Tom wakes up and have an authoritative answer. Regards -- Pantelis On Jun 25, 2013, at 11:08 AM, Heiko Schocher wrote: > Hello, > > using "dfu-util -l" shows different output co

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Pantelis Antoniou
Heiko, On Jun 4, 2013, at 1:31 PM, Heiko Schocher wrote: > Hello Pantelis, > > Am 04.06.2013 12:08, schrieb Pantelis Antoniou: >> Hi Heiko, >> >> Just thinking out loud here. Can we have an extra option that >> allocates the buffer dynamically based on a

Re: [U-Boot] dfu: make data buffer size configurable

2013-06-04 Thread Pantelis Antoniou
e size (in bytes) of this buffer > configurable. > > Signed-off-by: Heiko Schocher > Cc: Pantelis Antoniou > Cc: Tom Rini > Cc: Lukasz Majewski > Cc: Kyungmin Park > Cc: Marek Vasut > --- > README| 5 + > drivers/dfu/dfu.c | 2 +- > include/

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-28 Thread Pantelis Antoniou
Hi On May 28, 2013, at 7:43 PM, Benoît Thébaudeau wrote: > Hi Pantelis, > > On Tuesday, May 28, 2013 6:43:06 PM, Pantelis Antoniou wrote: >> Hi Benoît >> >> On May 28, 2013, at 7:31 PM, Benoît Thébaudeau wrote: >> >>> Dear Pantelis Antoniou, &g

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-28 Thread Pantelis Antoniou
Hi Benoît On May 28, 2013, at 7:31 PM, Benoît Thébaudeau wrote: > Dear Pantelis Antoniou, > > On Tuesday, May 28, 2013 5:05:12 PM, Pantelis Antoniou wrote: >> Hi Tom, >> >> On May 28, 2013, at 6:01 PM, Tom Rini wrote: >> >>> On Tue, May 28, 201

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-28 Thread Pantelis Antoniou
Hi Tom, On May 28, 2013, at 6:01 PM, Tom Rini wrote: > On Tue, May 28, 2013 at 07:50:46AM +0200, Wolfgang Denk wrote: >> Dear Tom, >> >> In message <20130527233735.GZ17119@bill-the-cat> you wrote: >>> Where exactly is this 8 MB limit coming into play? >>> >>> In buffering the data. We ca

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-27 Thread Pantelis Antoniou
Hi On May 27, 2013, at 7:25 PM, Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message <51a30f34.7030...@denx.de> you wrote: >> >> But how to handle a raw nand partition and a ubi partition on one >> nand? >> >> If ubi is a new dfu interface, somebody must start dfu on u-boot >> with "dfu

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-27 Thread Pantelis Antoniou
Hi Guys, On May 27, 2013, at 10:28 AM, Heiko Schocher wrote: > Hello Lukasz, > > Am 27.05.2013 09:02, schrieb Lukasz Majewski: >> Hi Heiko, >> >>> Hello Tom, >>> >>> Am 24.05.2013 19:12, schrieb Tom Rini: >>>> On Fri, May 24, 2013

Re: [U-Boot] dfu: dfu and UBI Volumes

2013-05-24 Thread Pantelis Antoniou
Hi Heiko, On May 24, 2013, at 7:39 PM, Heiko Schocher wrote: > Hello, > > just digging in DFU support in U-Boot for an upcoming board support > based on an AM335x. This board support uses for example a rootfs in > an UBI Volume on a NAND flash, and this should be updated with dfu ... > > How To

Re: [U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface

2013-03-05 Thread Pantelis Antoniou
Hi Lukasz, On Mar 6, 2013, at 9:42 AM, Lukasz Majewski wrote: > Dear All, > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 03/05/2013 06:24 PM, Marek Vasut wrote: >>> Dear Lukasz Majewski, >>> Hi Marek, > Dear Lukasz Majewski, > >> This commit fixes proble

Re: [U-Boot] [PATCH 9/9] dfu: Support larger than memory transfers.

2013-01-04 Thread Pantelis Antoniou
Hi Kasim, On Jan 3, 2013, at 10:30 AM, kasim ling wrote: > Hi, Pantelis, > A little confusion about FAT fs write supporting, > > > On Sat, Dec 1, 2012 at 12:51 AM, Pantelis Antoniou > wrote: >> >> We didn't support upload/download larger than available mem

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-18 Thread Pantelis Antoniou
Hi Lukasz, Mystery solved then :) On Dec 18, 2012, at 1:25 PM, Lukasz Majewski wrote: > Hi Pantelis, > >> Can you paste the log of your dfu-util session? Are you supplying a >> transfer size for example? >> >> Regards > > u-boot-denx/master (denx.de) repository > > SHA1: fd4d564b3c80b111f18c

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Pantelis Antoniou
>> >>> Copyright 2005-2008 Weston Schmidt, Harald Welte and OpenMoko Inc. >>> Copyright 2010-2012 Tormod Volden and Stefan Schmidt >>> This program is Free Software and has ABSOLUTELY NO WARRANTY >>> Please report bugs to dfu-u...@lists.gnumonks.org &g

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Pantelis Antoniou
Length = 0 > bDescriptorType = 0 > bmAttributes= 0x00 > wDetachTimeOut = 0 > wTransferSize = 0 > bcdDFUVersion = 0x > Error obtaining DFU functional descriptor > Please report this as a bug! > Warning: Assuming DFU version 1.

Re: [U-Boot] [PULL] u-boot-usb/master

2012-12-17 Thread Pantelis Antoniou
Lukasz, I'll sent the dump in a couple of hours. Been busy with other work items... Regards -- Pantelis On Dec 17, 2012, at 1:00 PM, Lukasz Majewski wrote: > Hi Marek, > >> Pantelis Antoniou (9): >> g_dnl: Issue connect/disconnect as appropriate >> g_d

Re: [U-Boot] [PATCH] [nand] Implement nand_extent_skip_bad

2012-12-11 Thread Pantelis Antoniou
Hi Scott, On Dec 11, 2012, at 7:13 PM, Scott Wood wrote: > On 12/11/2012 03:40:53 AM, Pantelis Antoniou wrote: >> Hi Scott, >> On Dec 11, 2012, at 12:53 AM, Scott Wood wrote: >> >> +/** >> >> + * nand_extent_skip_bad: >> >> + * >> >

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-11 Thread Pantelis Antoniou
Hi Lukasz, I bet transmission is performed, but with the default settings of dfu. The DFU function descriptor is completely ignored. An easy way to verify it is to check if the DFU version of the device is the same one as the one stored in the descriptor. Same with the transmission block size. I

Re: [U-Boot] [PATCH] [nand] Implement nand_extent_skip_bad

2012-12-11 Thread Pantelis Antoniou
Hi Scott, On Dec 11, 2012, at 12:53 AM, Scott Wood wrote: > On 12/10/2012 09:24:24 AM, Pantelis Antoniou wrote: >> When accessing nand any bad blocks encountered are skipped, with no >> indication about the amount of bad blocks encountered. >> While this is normally fine, w

Re: [U-Boot] [PATCH] [DFU] Implement NAND dfu support

2012-12-11 Thread Pantelis Antoniou
Hi Scott, On Dec 11, 2012, at 3:09 AM, Scott Wood wrote: > On 12/10/2012 09:24:32 AM, Pantelis Antoniou wrote: >> Introduce on-the fly DFU NAND support. >> Signed-off-by: Pantelis Antoniou >> --- >> drivers/dfu/Makefile | 1 + >> drivers/dfu/dfu.c |

Re: [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-12-10 Thread Pantelis Antoniou
why dfu-util on my linux works OK without > this patch? > I have absolutely no idea why it works at your side. At our side it just didn't work at all without the patches. If I had to guess maybe your gadget h/w takes care of replying properly for the DFU case. >> >

[U-Boot] [PATCH] [DFU] Implement NAND dfu support

2012-12-10 Thread Pantelis Antoniou
Introduce on-the fly DFU NAND support. Signed-off-by: Pantelis Antoniou --- drivers/dfu/Makefile | 1 + drivers/dfu/dfu.c | 7 ++ drivers/dfu/dfu_nand.c | 194 + include/dfu.h | 23 ++ 4 files changed, 225 insertions

[U-Boot] [PATCH] [nand] Implement nand_extent_skip_bad

2012-12-10 Thread Pantelis Antoniou
. nand_extend_skip_bad() returns the offset where the next access should occur. Signed-off-by: Pantelis Antoniou --- drivers/mtd/nand/nand_util.c | 50 include/nand.h | 2 ++ 2 files changed, 52 insertions(+) diff --git a/drivers/mtd/nand

Re: [U-Boot] [PATCH v3 1/9] usb: Fix bug when both DFU & ETHER are defined

2012-12-03 Thread Pantelis Antoniou
Hi Marek, On Dec 1, 2012, at 7:30 AM, Marek Vasut wrote: > Dear Pantelis Antoniou, > >> When both CONFIG_USB_GADGET & CONFIG_USB_ETHER are defined >> the makefile links objects twice. >> >> The cleanest way to fix is to use a new define, CONFIG_USB_UTIL &g

[U-Boot] [PATCH] usb: Fix bug when both DFU & ETHER are defined

2012-12-03 Thread Pantelis Antoniou
When both CONFIG_USB_GADGET & CONFIG_USB_ETHER are defined the makefile links objects twice. This patch uses a Makefile specific idiom of 'if defined(CONFIG_USB_GADGET) || defined(CONFIG_USB_ETHER)' to handle the case. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget

[U-Boot] [PATCH v3 9/9] dfu: Support larger than memory transfers.

2012-11-30 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu.c | 244 +++--- drivers/dfu/dfu_mmc.c | 82 +++-- include/dfu.h | 21 - 3 files changed, 264 insertions(+), 83 deletions(-) diff --git a/drivers/dfu/dfu.c b/drivers/df

[U-Boot] [PATCH v3 7/9] dfu: Properly zero out timeout value

2012-11-30 Thread Pantelis Antoniou
Zero out timeout value; letting it filled with undefined values ends up with the dfu host hanging. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/f_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c index 6494f5e

[U-Boot] [PATCH v3 8/9] dfu: Add a partition type target

2012-11-30 Thread Pantelis Antoniou
Dealing with raw block numbers with the dfu is very annoying. Introduce a partition method. Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu_mmc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index 5d504df

[U-Boot] [PATCH v3 5/9] dfu: Fix crash when wrong number of arguments given

2012-11-30 Thread Pantelis Antoniou
Fix obvious crash when not enough arguments are given to the dfu command. Signed-off-by: Pantelis Antoniou --- common/cmd_dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 327c738..83ef324 100644 --- a/common/cmd_dfu.c +++ b

[U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup

2012-11-30 Thread Pantelis Antoniou
n the appropriate function descriptor. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/composite.c | 27 +++ drivers/usb/gadget/ep0.c | 1 + drivers/usb/gadget/f_dfu.c | 6 -- 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/driver

[U-Boot] [PATCH v3 4/9] dfu: Only perform DFU board_usb_init() for TRATS

2012-11-30 Thread Pantelis Antoniou
USB initialization shouldn't happen for all the boards. Signed-off-by: Pantelis Antoniou --- common/cmd_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 01d6b3a..327c738 100644 --- a/common/cmd_dfu.c +++ b/common/cmd_dfu.c @@ -55,7 +

[U-Boot] [PATCH v3 3/9] g_dnl: Properly terminate string list.

2012-11-30 Thread Pantelis Antoniou
Well, not terminating the list causes very interesting crashes. As in changing the vendor & product ID crashes. Fun. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/g_dnl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c i

[U-Boot] [PATCH v3 1/9] usb: Fix bug when both DFU & ETHER are defined

2012-11-30 Thread Pantelis Antoniou
well. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/Makefile | 8 ++-- include/configs/am335x_evm.h| 1 + include/configs/am3517_evm.h| 1 + include/configs/h2200.h | 1 + include/configs/omap3_beagle.h | 1 + include/configs/s5p_goni.h

[U-Boot] [PATCH v3 2/9] g_dnl: Issue connect/disconnect as appropriate

2012-11-30 Thread Pantelis Antoniou
Call usb_gadget_connect/usb_gadget_disconnect in g_dnl_bind/g_dnl_unbind. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/g_dnl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c index 7d87050

[U-Boot] [PATCH v3 0/9] USB: Gadget & DFU related fixes

2012-11-30 Thread Pantelis Antoniou
e #1 Pantelis Antoniou (9): usb: Fix bug when both DFU & ETHER are defined g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list. dfu: Only perform DFU board_usb_init() for TRATS dfu: Fix crash when wrong number of arguments given dfu: Send cor

[U-Boot] [PATCH 9/9] dfu: Support larger than memory transfers.

2012-11-30 Thread Pantelis Antoniou
Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu.c | 244 +++--- drivers/dfu/dfu_mmc.c | 82 +++-- include/dfu.h | 21 - 3 files changed, 264 insertions(+), 83 deletions(-) diff --git a/drivers/dfu/dfu.c b/drivers/df

[U-Boot] [PATCH 8/9] dfu: Add a partition type target

2012-11-30 Thread Pantelis Antoniou
Dealing with raw block numbers with the dfu is very annoying. Introduce a partition method. Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu_mmc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index 5d504df

[U-Boot] [PATCH 7/9] dfu: Properly zero out timeout value

2012-11-30 Thread Pantelis Antoniou
Zero out timeout value; letting it filled with undefined values ends up with the dfu host hanging. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/f_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c index 6494f5e

[U-Boot] [PATCH 5/9] dfu: Fix crash when wrong number of arguments given

2012-11-30 Thread Pantelis Antoniou
Fix obvious crash when not enough arguments are given to the dfu command. Signed-off-by: Pantelis Antoniou --- common/cmd_dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 327c738..83ef324 100644 --- a/common/cmd_dfu.c +++ b

[U-Boot] [PATCH 6/9] dfu: Send correct DFU response from composite_setup

2012-11-30 Thread Pantelis Antoniou
n the appropriate function descriptor. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/composite.c | 27 +++ drivers/usb/gadget/ep0.c | 1 + drivers/usb/gadget/f_dfu.c | 6 -- 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/driver

[U-Boot] [PATCH 4/9] dfu: Only perform DFU board_usb_init() for TRATS

2012-11-30 Thread Pantelis Antoniou
USB initialization shouldn't happen for all the boards. Signed-off-by: Pantelis Antoniou --- common/cmd_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 01d6b3a..327c738 100644 --- a/common/cmd_dfu.c +++ b/common/cmd_dfu.c @@ -55,7 +

[U-Boot] [PATCH 1/9] usb: Fix bug when both DFU & ETHER are defined

2012-11-30 Thread Pantelis Antoniou
well. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/Makefile | 8 ++-- include/configs/am335x_evm.h| 1 + include/configs/am3517_evm.h| 1 + include/configs/h2200.h | 1 + include/configs/omap3_beagle.h | 1 + include/configs/s5p_goni.h

[U-Boot] [PATCH 3/9] g_dnl: Properly terminate string list.

2012-11-30 Thread Pantelis Antoniou
Well, not terminating the list causes very interesting crashes. As in changing the vendor & product ID crashes. Fun. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/g_dnl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c i

[U-Boot] [PATCH 2/9] g_dnl: Issue connect/disconnect as appropriate

2012-11-30 Thread Pantelis Antoniou
Call usb_gadget_connect/usb_gadget_disconnect in g_dnl_bind/g_dnl_unbind. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/g_dnl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c index 7d87050

[U-Boot] [PATCH 0/9] USB: Gadget & DFU related fixes (v3)

2012-11-30 Thread Pantelis Antoniou
Third take of USB + DFU updates. Pantelis Antoniou (9): usb: Fix bug when both DFU & ETHER are defined g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list. dfu: Only perform DFU board_usb_init() for TRATS dfu: Fix crash when wrong number of argum

Re: [U-Boot] [PATCH 04/10] g_dnl: Properly terminate string list.

2012-11-29 Thread Pantelis Antoniou
Hi Marek, On Nov 29, 2012, at 10:20 AM, Marek Vasut wrote: > Dear Pantelis Antoniou, > >> Well, not terminating the list causes very interesting crashes. >> As in changing the vendor & product ID crashes. Fun. >> >> Signed-off-by: Pantelis Antoniou >&g

[U-Boot] [PATCH] dfu: Handle large transfers correctly (take #2)

2012-11-29 Thread Pantelis Antoniou
The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large (> 256MB) images. Also utilize a variable to handle initialization, so that we don't rely on just the counter sent by the host. Signed-off-by: Pantelis Antoniou ---

Re: [U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-29 Thread Pantelis Antoniou
he rollover that is not handled correctly. This is just bandaid, and is not fixing the problem. Regards -- Pantelis >> >> Signed-off-by: Pantelis Antoniou >> --- >> drivers/dfu/dfu.c | 28 +++- >> drivers/dfu/dfu_mmc.c | 3 +++ >> include/dfu.

Re: [U-Boot] [PATCH 01/10] usb: Remove obsolete header file

2012-11-29 Thread Pantelis Antoniou
oing more extensive tests but those takes a >>>> huge amount of time... :( >>> >>> This is because of very low DFU transmission speed (It uses only EP0 >>> with EPS=64B , so it is meant to transfer really small files). >>> >>> Updating

Re: [U-Boot] [PATCH 01/10] usb: Remove obsolete header file

2012-11-29 Thread Pantelis Antoniou
Hi Lukasz, I did found out the problem with large transfers, and there is a patch that fixes it. I'm pretty sure that the transfers are correct. Perhaps some other problem with your board? Can you use the updated patch series and try with that, with debugging enabled? Regards -- Pantelis ___

Re: [U-Boot] [PATCH 00/10] USB: Gadget & DFU related fixes

2012-11-29 Thread Pantelis Antoniou
Hi Marek, On Nov 29, 2012, at 8:32 AM, Marek Vasut wrote: > Dear Pantelis Antoniou, > >> Various bugfixes, g_dnl & DFU updates. >> >> Pantelis Antoniou (10): >> usb: Remove obsolete header file >> usb: Fix bug when both DFU & ETHER are de

[U-Boot] [PATCH] dfu: Handle large transfers correctly

2012-11-28 Thread Pantelis Antoniou
The sequence number is a 16 bit counter; make sure we handle rollover correctly. This fixes the wrong transfers for large (> 256MB) images. Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu.c | 28 +++- drivers/dfu/dfu_mmc.c | 3 +++ include/dfu.h |

Re: [U-Boot] [PATCH 01/10] usb: Remove obsolete header file

2012-11-28 Thread Pantelis Antoniou
FU would take much time. It is OK, to transfer > u-boot, uImage, some log data. > We have customers that do want to use DFU for all of their initial programming. The limitations are known, but the fact is that they find it very convenient for their use. And it's not like you're limited by t

Re: [U-Boot] [PATCH 01/10] usb: Remove obsolete header file

2012-11-28 Thread Pantelis Antoniou
tests have been downloading a small ext3 image to the mmc. I'm in the middle of doing more extensive tests but those takes a huge amount of time... :( >> 2. Please look into the TRATS board (especially the CONFIG_DFU_ALT >> constant) for reference. >> Already loo

Re: [U-Boot] [PATCH] mmc: Add an mmcsilent option

2012-11-28 Thread Pantelis Antoniou
Hi Andy, On Nov 28, 2012, at 6:49 PM, Andy Fleming wrote: > > > > On Thu, Nov 29, 2012 at 1:34 AM, Pantelis Antoniou > wrote: > When using MMC commands for dfu there is considerable noise. > Suppress mmc messages when mmcsilent is set. > > Signed-off-by: Panteli

[U-Boot] [PATCH 2/2] am335x_evm: Add DFU config

2012-11-28 Thread Pantelis Antoniou
Add configuration for using DFU on the am335x_evm boards Signed-off-by: Pantelis Antoniou --- include/configs/am335x_evm.h | 24 1 file changed, 24 insertions(+) diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h index 6c8b652..3c1d16d 100644

[U-Boot] [PATCH 1/2] am335x_evm: Define CONFIG_SYS_CACHELINE_SIZE

2012-11-28 Thread Pantelis Antoniou
drivers/usb/gadget/composite.c requires that this is defined early. Signed-off-by: Pantelis Antoniou --- include/configs/am335x_evm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h index ab9549b..6c8b652 100644 --- a/include

[U-Boot] [PATCH 0/2] AM335x_EVM DFU support

2012-11-28 Thread Pantelis Antoniou
This patchset enables DFU for the AM335x_EVM family of boards. Pantelis Antoniou (2): am335x_evm: Define CONFIG_SYS_CACHELINE_SIZE am335x_evm: Add DFU config include/configs/am335x_evm.h | 26 ++ 1 file changed, 26 insertions(+) -- 1.7.12

[U-Boot] [PATCH 02/10] usb: Fix bug when both DFU & ETHER are defined

2012-11-28 Thread Pantelis Antoniou
When both CONFIG_USB_GADGET & CONFIG_USB_ETHER are defined the makefile links objects twice. Detect this and fix it with a not very elegant way in the makefile. Revisit and clean it later. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/Makefile | 13 +++-- 1 file changed

[U-Boot] [PATCH] mmc: Add an mmcsilent option

2012-11-28 Thread Pantelis Antoniou
When using MMC commands for dfu there is considerable noise. Suppress mmc messages when mmcsilent is set. Signed-off-by: Pantelis Antoniou --- common/cmd_mmc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index 4c19df7

[U-Boot] [PATCH 10/10] dfu: Support larger than memory transfers.

2012-11-28 Thread Pantelis Antoniou
MB to just 64K, which was over the top. Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu.c | 206 ++ drivers/dfu/dfu_mmc.c | 79 --- include/dfu.h | 19 - 3 files changed, 224 insertions(+), 80 deletions(-) diff --

[U-Boot] [PATCH 09/10] dfu: Add a partition type target

2012-11-28 Thread Pantelis Antoniou
Dealing with raw block numbers with the dfu is very annoying. Introduce a partition method. Signed-off-by: Pantelis Antoniou --- drivers/dfu/dfu_mmc.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/dfu/dfu_mmc.c b/drivers/dfu/dfu_mmc.c index 5d504df

[U-Boot] [PATCH 07/10] dfu: Send correct DFU response from composite_setup

2012-11-28 Thread Pantelis Antoniou
n the appropriate function descriptor. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/composite.c | 27 +++ drivers/usb/gadget/ep0.c | 1 + drivers/usb/gadget/f_dfu.c | 6 -- 3 files changed, 32 insertions(+), 2 deletions(-) diff --git a/driver

[U-Boot] [PATCH 08/10] dfu: Properly zero out timeout value

2012-11-28 Thread Pantelis Antoniou
Zero out timeout value; letting it filled with undefined values ends up with the dfu host hanging. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/f_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c index 6494f5e

[U-Boot] [PATCH 06/10] dfu: Fix crash when wrong number of arguments given

2012-11-28 Thread Pantelis Antoniou
Fix obvious crash when not enough arguments are given to the dfu command. Signed-off-by: Pantelis Antoniou --- common/cmd_dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 327c738..83ef324 100644 --- a/common/cmd_dfu.c +++ b

[U-Boot] [PATCH 05/10] dfu: Only perform DFU board_usb_init() for TRATS

2012-11-28 Thread Pantelis Antoniou
USB initialization shouldn't happen for all the boards. Signed-off-by: Pantelis Antoniou --- common/cmd_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 01d6b3a..327c738 100644 --- a/common/cmd_dfu.c +++ b/common/cmd_dfu.c @@ -55,7 +

[U-Boot] [PATCH 04/10] g_dnl: Properly terminate string list.

2012-11-28 Thread Pantelis Antoniou
Well, not terminating the list causes very interesting crashes. As in changing the vendor & product ID crashes. Fun. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/g_dnl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c i

[U-Boot] [PATCH 03/10] g_dnl: Issue connect/disconnect as appropriate

2012-11-28 Thread Pantelis Antoniou
Call usb_gadget_connect/usb_gadget_disconnect in g_dnl_bind/g_dnl_unbind. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/g_dnl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c index 7d87050

[U-Boot] [PATCH 00/10] USB: Gadget & DFU related fixes

2012-11-28 Thread Pantelis Antoniou
Various bugfixes, g_dnl & DFU updates. Pantelis Antoniou (10): usb: Remove obsolete header file usb: Fix bug when both DFU & ETHER are defined g_dnl: Issue connect/disconnect as appropriate g_dnl: Properly terminate string list. dfu: Only perform DFU board_usb_init() for TRA

[U-Boot] [PATCH 01/10] usb: Remove obsolete header file

2012-11-28 Thread Pantelis Antoniou
usbdescriptors.h conflicts with linux/usb/ch9.h Remove it. Signed-off-by: Pantelis Antoniou --- drivers/usb/gadget/f_dfu.c | 1 - include/g_dnl.h| 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c index 3ec4c65..10547e3 100644

Re: [U-Boot] [PATCH 9/9] Add DFU config

2012-11-28 Thread Pantelis Antoniou
On Nov 28, 2012, at 5:04 AM, Tom Rini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/27/12 21:52, Marek Vasut wrote: >> Dear Pantelis Antoniou, >> >>> Add configuration for using DFU on the am335x_evm boards >>> >>>

Re: [U-Boot] [PATCH 7/9] Add a partition type target

2012-11-28 Thread Pantelis Antoniou
Hi Marek, On Nov 28, 2012, at 4:48 AM, Marek Vasut wrote: > Dear Pantelis Antoniou, > >> Dealing with raw block numbers with the dfu is very annoying. >> Introduce a partition method. >> >> Signed-off-by: Pantelis Antoniou >&g

<    1   2   3   4   5   >