Re: [PATCH v2] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-05-27 Thread Quentin Schulz
Hi Jianfeng, On 5/27/24 10:57 AM, Jianfeng Liu wrote: Hi all, However... it seems we'll likely need to also cherry-pick patches for the GPU (should probably be straightforward as nothing would be using the GPU anyway in U-Boot) and the USBDP PHY... but this one we would need to update all

Re: [PATCH 2/2] rockchip: rk3588-edgeble: Add USB OTG support

2024-05-27 Thread Quentin Schulz
Hi Jagan, On 5/27/24 10:57 AM, Jagan Teki wrote: On Mon, 27 May 2024 at 14:17, Quentin Schulz wrote: Hi Jagan, On 5/27/24 8:39 AM, Jagan Teki wrote: Add support for USB OTG with UMS to program eMMC. Add it for Edgeble NCM6A, NCM6B. Signed-off-by: Jagan Teki --- .../dts/rk3588-edgeble

Re: [PATCH 2/2] rockchip: rk3588-edgeble: Add USB OTG support

2024-05-27 Thread Quentin Schulz
Hi Jagan, On 5/27/24 8:39 AM, Jagan Teki wrote: Add support for USB OTG with UMS to program eMMC. Add it for Edgeble NCM6A, NCM6B. Signed-off-by: Jagan Teki --- .../dts/rk3588-edgeble-neu6a-io-u-boot.dtsi| 18 ++ .../dts/rk3588-edgeble-neu6b-io-u-boot.dtsi| 18

Re: [PATCH 1/2] arm64: dts: rockchip: Fix spl-boot-order for edgeble-ncm6b

2024-05-27 Thread Quentin Schulz
Hi Jagan, On 5/27/24 8:39 AM, Jagan Teki wrote: Edgeble NCM6B SoM has built-in eMMC so make sdhci has first boot priority. Fix it for NCM6A, NCM6B SoM. Signed-off-by: Jagan Teki --- arch/arm/dts/rk3588-edgeble-neu6a-io-u-boot.dtsi | 6 +-

[PATCH 3/3] rockchip: theobroma: update URLs to point to CHERRY website

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz Most of the current URLs should be redirected but some aren't already, so let's anticipate more IT hiccups by migrating to new URLs. Signed-off-by: Quentin Schulz --- board/theobroma-systems/jaguar_rk3588/MAINTAINERS | 4 ++-- board/theobroma-systems/puma_rk3399

[PATCH 0/3] fix URL and mails for Theobroma now CHERRY Embedded Solutions

2024-05-24 Thread Quentin Schulz
the press release. Signed-off-by: Quentin Schulz --- Quentin Schulz (3): .mailmap: redirect Philipp Tomsich Theobroma address to Vrull migrate Theobroma Systems mail addresses to CHERRY Embedded Solutions rockchip: theobroma: update URLs to point to CHERRY website

[PATCH 2/3] migrate Theobroma Systems mail addresses to CHERRY Embedded Solutions

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz See https://embedded.cherry.de/theobroma-systems-is-now-officially-part-of-cherry-se/ While the mail addresses on the theobroma-systems.com domain should be redirect to cherry.de, let's anticipate IT hiccups and avoid important mails not reaching us by swapping the domain

[PATCH 1/3] .mailmap: redirect Philipp Tomsich Theobroma address to Vrull

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz The Theobroma address bounces as Philipp is not working there anymore, so let's update with the one that seems to be working right now. Cc: Philipp Tomsich Signed-off-by: Quentin Schulz --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap

[PATCH next 5/5] power: rk8xx: properly print all supported PMICs name

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz The ID of the PMIC is stored in the 2 16b registers but the only part that matters right now is the 3 MSB, which make the 3 digits (in hex) of the part number. Right now, only RK808 was properly displayed, with this all currently supported PMICs should display the proper

[PATCH next 4/5] rockchip: px30-ringneck: Update SPL_PAD_TO Kconfig option

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz On px30-ringneck the FIT payload is located at sector 0x200 compared to the more Rockchip common sector 0x4000 offset: SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200 Because FIT payload is located at sector 0x200 and the TPL+SPL is located at sector 64, the combined size

[PATCH next 3/5] rockchip: rk3399-puma: remove unnecessary simple-bin:fit:offset override

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz Since commit 6007b69d544e ("rockchip: rk3399-puma: Update SPL_PAD_TO Kconfig option"), SPL_PAD_TO matches (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR - 64) * 512 and the default value for simple-bin:fit:offset in rockchip-u-boot.dtsi is SPL_PAD_TO, so let's remove thi

[PATCH next 2/5] rockchip: rk3399-puma: remove default value from defconfig

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz CONFIG_ENV_OFFSET already defaults to 0x3F8000, however it is stored in lowercase hexdigits instead of uppercase like in the defconfig. No change in behavior intended. Signed-off-by: Quentin Schulz --- configs/puma-rk3399_defconfig | 1 - 1 file changed, 1 deletion

[PATCH next 1/5] rockchip: jaguar-rk3588: use default env size for Rockchip on MMC

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz The default env size is 0x8000 when building for Rockchip SoCs with support for environment stored in MMC. Jaguar hasn't entered mass production just yet, so it's a breaking change we can afford in the name of consistency. Signed-off-by: Quentin Schulz --- configs/jaguar

[PATCH next 0/5] rockchip: display PMIC variant properly + misc fixes for Theobroma boards

2024-05-24 Thread Quentin Schulz
of the fit offset in u-boot dtsi for Puma and Ringneck. Signed-off-by: Quentin Schulz --- Quentin Schulz (5): rockchip: jaguar-rk3588: use default env size for Rockchip on MMC rockchip: rk3399-puma: remove default value from defconfig rockchip: rk3399-puma: remove unnecessary

[PATCH next v2 8/8] rockchip: px30/rk3326: migrate to OF_UPSTREAM

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz Migrate PX30/RK3326 boards that exists in Linux v6.8 to use OF_UPSTREAM. firefly-px30 is not migrated to OF_UPSTREAM because there's no Device Tree in the Linux kernel. Differences between U-Boot's Odroid-Go2 and Linux's are now moved to the -u-boot.dtsi, though I have

[PATCH next v2 7/8] rockchip: evb-px30: make UART5 the debug UART

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz In the Device Tree, UART5 is the system UART, but in the defconfig it currently is UART2. Let's sync the two by making the defconfig use UART5 as well. Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz --- configs/evb-px30_defconfig | 2 +- 1 file changed, 1

[PATCH next v2 6/8] rockchip: evb-px30: do not remove pinctrl nodes from SPL DTB

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz In order to be able to properly mux UART on PX30 EVB, the pinmux needs to be done at runtime, so let's not remove the pinctrl nodes from the SPL DTB. Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz --- configs/evb-px30_defconfig | 2 +- 1 file changed, 1 insertion

[PATCH next v2 5/8] rockchip: px30: make UART pinmux accessible to TPL/SPL DTB

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz This adds the default pinmux for UART2 and UART5 to the TPL/SPL DTB (if not removed through the CONFIG_OF_SPL_REMOVE_PROPS symbol) as those two controllers are always made available to all boards. Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz --- arch/arm/dts

[PATCH next v2 4/8] rockchip: px30-core-*: Use common bss and stack addresses

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH next v2 3/8] rockchip: odroid-go2: Use common bss and stack addresses

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH next v2 2/8] rockchip: firefly-px30: Use common bss and stack addresses

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH next v2 0/8] rockchip: px30: migrate to common bss and stack addresses and OF_UPSTREAM

2024-05-24 Thread Quentin Schulz
To: Suniel Mahesh To: Simon Glass To: Philipp Tomsich To: Quentin Schulz To: Klaus Goger Cc: u-boot@lists.denx.de Signed-off-by: Quentin Schulz Changes in v2: - remove px30-base and ringneck patches, they were sent for master - migrate boards to OF_UPSTREAM - Link to v1: https

[PATCH next v2 1/8] rockchip: evb-px30: Use common bss and stack addresses

2024-05-24 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH v2 2/3] rockchip: Use common bss and stack addresses on PX30

2024-05-23 Thread Quentin Schulz
From: Quentin Schulz See commit 008ba0d56d00 ("rockchip: Add common default bss and stack addresses") for memory layout. This migrates PX30 to use the new layout, except for TPL. Indeed, PX30 is extremely limited in SRAM, so we need to be extra careful about what goes into the TPL an

[PATCH v2 3/3] rockchip: ringneck_px30: Use common bss and stack addresses

2024-05-23 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory and it is thus impossible to boot into U-Boot CLI. Fix this by migrating to the common bss and stack addresses for PX30, which drastically increases the size of the pre-reloc allocation pool (8 times bigger now

[PATCH v2 1/3] rockchip: px30: default TPL_SYS_MALLOC_F_LEN to 0x600 on PX30 Kconfig level

2024-05-23 Thread Quentin Schulz
From: Quentin Schulz This is the kind of setting that typically doesn't need to be changed between boards based on the same SoC, so let's make it the default in PX30 Kconfig so we don't have to care about it in the defconfig if we don't want to. Reviewed-by: Heiko Stuebner Reviewed-by: Kever

[PATCH v2 0/3] rockchip: ringneck-px30: migrate to common bss and stack addresses

2024-05-23 Thread Quentin Schulz
To: Heiko Stuebner To: Jagan Teki To: Suniel Mahesh To: Quentin Schulz To: Klaus Goger Cc: tr...@konsulko.com Cc: jo...@kwiboo.se Cc: u-boot@lists.denx.de Signed-off-by: Quentin Schulz Changes in v2: - remove non-ringneck patches, they'll be for next instead - Link to v1: https://lore.kernel.org/r

Re: [PATCH 15/42] mmc: dw_mmc: Improve coding style

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:31 AM, Sam Protsenko wrote: Fix most of checkpatch warnings and other obvious style issues. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 14/42] mmc: dw_mmc: Use CONFIG_IS_ENABLED() to check config options

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:31 AM, Sam Protsenko wrote: Use CONFIG_IS_ENABLED() macro to check config options as recommended by checkpatch, instead of checking those with just #ifdef CONFIG_... No functional change. There are actual functional changes in here. defined(CONFIG_DM_MMC) !=

Re: [PATCH 09/42] mmc: dw_mmc: Extract setting the DMA descriptor into a separate routine

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:31 AM, Sam Protsenko wrote: Make dwmci_prepare_data() function easier to read by extracting the preparation of IDMAC descriptor into a dedicated function. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 08/42] mmc: dw_mmc: Extract DMA transfer handling code into a separate routine

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:31 AM, Sam Protsenko wrote: Make dwmci_send_cmd() easier to read by moving the DMA transfer handling code into a dedicated function. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 05/42] mmc: dw_mmc: Extract FIFO init into a separate routine

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:30 AM, Sam Protsenko wrote: Move FIFO threshold initialization into a separate function to make dwmci_init() more readable. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 04/42] mmc: dw_mmc: Extract waiting for data busy into a separate routine

2024-05-23 Thread Quentin Schulz
later in other cases. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 03/42] mmc: dw_mmc: Move struct idmac to dw_mmc.c

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:30 AM, Sam Protsenko wrote: struct idmac is only used in dw_mmc.c, so move it there from dwmmc.h to avoid cluttering the interface in the header. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 02/42] mmc: dw_mmc: Remove unused version field from struct dwmci_host

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:30 AM, Sam Protsenko wrote: Nobody seems to use it, so just remove it. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 01/42] mmc: dw_mmc: Remove common.h

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:30 AM, Sam Protsenko wrote: common.h header is marked for removal treewide and shouldn't be used. Remove it from DW MMC driver. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH 06/42] mmc: dw_mmc: Extract clock on/off code into a separate routine

2024-05-23 Thread Quentin Schulz
Hi Sam, On 5/23/24 1:30 AM, Sam Protsenko wrote: Extract clock control code into a separate routine to avoid code duplication in dwmci_setup_bus(). No functional change. There are some differences though. Signed-off-by: Sam Protsenko --- drivers/mmc/dw_mmc.c | 60

Re: [PATCH v2] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-05-22 Thread Quentin Schulz
Hi Jianfeng Liu, On 5/22/24 6:58 PM, Jianfeng Liu wrote: [...] Note that these commits: - e18e5e8188f2 (arm64: dts: rockchip: add USBDP phys on rk3588) - 6fca4edb93d3 (arm64: dts: rockchip: Add rk3588 GPU node) are not synced to u-boot, so I remove usb3 drd nodes and gpu from kernel devicetree.

Re: [PATCH RESEND] clk: rockchip: rk3588: Set SPLL frequency during SPL stage

2024-05-22 Thread Quentin Schulz
Hi Heiko, On 5/22/24 4:18 PM, Heiko Stübner wrote: Hi Quentin, Am Mittwoch, 22. Mai 2024, 15:59:24 CEST schrieb Quentin Schulz: On 5/22/24 2:15 PM, Heiko Stuebner wrote: [...] I'm also a bit wary of defining SPLL (and for that matter also V0PLL to PPLL) with offsets relative to a different

Re: [PATCH RESEND] clk: rockchip: rk3588: Set SPLL frequency during SPL stage

2024-05-22 Thread Quentin Schulz
Hi Heiko, On 5/22/24 2:15 PM, Heiko Stuebner wrote: From: Heiko Stuebner All parts expect the SPLL to run at 702MHz. In U-Boot it's the SPLL_HZ declaring this rate and in the kernel it's a fixed clock definition. While everything is expecting 702MHz, the SPLL is not running that frequency

Re: [PATCH 00/10] rockchip: px30: migrate to common bss and stack addresses + UART fixes for evb-px30

2024-05-22 Thread Quentin Schulz
Hi Tom, On 5/21/24 8:04 PM, Tom Rini wrote: On Tue, May 21, 2024 at 07:39:53PM +0200, Quentin Schulz wrote: PX30 Ringneck ran out of memory in the allocation pool of U-Boot proper pre-reloc. Something needed to be done. Jonas did migrate a few SoCs already to this common bss+stack addresses so

[PATCH 10/10] rockchip: evb-px30: make UART5 the debug UART

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz In the Device Tree, UART5 is the system UART, but in the defconfig it currently is UART2. Let's sync the two by making the defconfig use UART5 as well. Signed-off-by: Quentin Schulz --- configs/evb-px30_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 09/10] rockchip: evb-px30: do not remove pinctrl nodes from SPL DTB

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz In order to be able to properly mux UART on PX30 EVB, the pinmux needs to be done at runtime, so let's not remove the pinctrl nodes from the SPL DTB. Signed-off-by: Quentin Schulz --- configs/evb-px30_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 08/10] rockchip: px30: make UART pinmux accessible to TPL/SPL DTB

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz This adds the default pinmux for UART2 and UART5 to the TPL/SPL DTB (if not removed through the CONFIG_OF_SPL_REMOVE_PROPS symbol) as those two controllers are always made available to all boards. Signed-off-by: Quentin Schulz --- arch/arm/dts/px30-u-boot.dtsi | 16

[PATCH 07/10] rockchip: px30-core-*: Use common bss and stack addresses

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH 06/10] rockchip: odroid-go2: Use common bss and stack addresses

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH 05/10] rockchip: firefly-px30: Use common bss and stack addresses

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH 04/10] rockchip: evb-px30: Use common bss and stack addresses

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory on PX30 Ringneck and it is thus impossible to boot into U-Boot CLI. It is assumed the same problem can be seen on other PX30 boards though I cannot guarantee it since I don't have access to them. Fix

[PATCH 03/10] rockchip: ringneck_px30: Use common bss and stack addresses

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz U-Boot proper pre-reloc is currently running out of memory and it is thus impossible to boot into U-Boot CLI. Fix this by migrating to the common bss and stack addresses for PX30, which drastically increases the size of the pre-reloc allocation pool (8 times bigger now

[PATCH 02/10] rockchip: Use common bss and stack addresses on PX30

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz See commit 008ba0d56d00 ("rockchip: Add common default bss and stack addresses") for memory layout. This migrates PX30 to use the new layout, except for TPL. Indeed, PX30 is extremely limited in SRAM, so we need to be extra careful about what goes into the TPL an

[PATCH 01/10] rockchip: px30: default TPL_SYS_MALLOC_F_LEN to 0x600 on PX30 Kconfig level

2024-05-21 Thread Quentin Schulz
From: Quentin Schulz This is the kind of setting that typically doesn't need to be changed between boards based on the same SoC, so let's make it the default in PX30 Kconfig so we don't have to care about it in the defconfig if we don't want to. Signed-off-by: Quentin Schulz --- arch/arm/mach

[PATCH 00/10] rockchip: px30: migrate to common bss and stack addresses + UART fixes for evb-px30

2024-05-21 Thread Quentin Schulz
related to UART on the PX30 Mini EVB I could test. Boot (to U-Boot CLI) tested on PX30 Ringneck and PX30 Mini-EVB. Thanks to Jonas for hinting where to look at. Signed-off-by: Quentin Schulz --- Quentin Schulz (10): rockchip: px30: default TPL_SYS_MALLOC_F_LEN to 0x600 on PX30 Kconfig level

Re: [ANN] U-Boot v2024.07-rc3 released

2024-05-21 Thread quentin . schulz
Hi Jonas, On 5/21/24 1:57 PM, Jonas Karlman wrote: Hi Quentin, On 2024-05-21 11:53, Quentin Schulz wrote: > Hi all, > > On 5/20/24 6:06 PM, Tom Rini wrote: >> Hey all, >> >> It's release day and here is -rc3. At this point, I think we're firmly >> on "bu

Re: [ANN] U-Boot v2024.07-rc3 released

2024-05-21 Thread Quentin Schulz
Hi all, On 5/20/24 6:06 PM, Tom Rini wrote: Hey all, It's release day and here is -rc3. At this point, I think we're firmly on "bug fix and documentation" ground moving forward for changes to v2024.07 and the next branch is open and ready for use and pull requests. In terms of a changelog,

Re: [v3 2/2] doc: process.rst: Document device tree resync rules

2024-05-21 Thread Quentin Schulz
: - Address Quentin's feedback Cc: Heinrich Schuchardt Cc: Quentin Schulz --- doc/develop/devicetree/control.rst | 9 ++--- doc/develop/process.rst| 13 + 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/doc/develop/devicetree/control.rst b/doc/develop

Re: [v3 1/2] doc: process.rst: Use subsubheading for "Phases of the Development Process"

2024-05-21 Thread Quentin Schulz
Development Process section under the "Phases of the development process" section as well? Otherwise, Reviewed-by: Quentin Schulz Thanks! Quentin

Re: [PATCH 2/2] doc: process.rst: Document device tree resync rules

2024-05-17 Thread Quentin Schulz
Hi Tom, On 5/16/24 10:34 PM, Tom Rini wrote: Document the logic of when we do a full resync of the device trees used by OF_UPSTREAM as well as that cherry-picking is allowed as needed. Signed-off-by: Tom Rini --- Cc: Heinrich Schuchardt --- doc/develop/process.rst | 13 + 1

Re: [PATCH v1 5/9] arm: rockchip: Enable display cpuinfo to be build with SPL_BUILD

2024-05-16 Thread Quentin Schulz
Hi Anand, On 5/16/24 10:59 AM, Anand Moon wrote: Changes help enable CONFIG_DISPLAY_CPUINFO to build with SPL_BUILD for SoC RK356x and RK3588. > Cc: Jagan Teki Signed-off-by: Anand Moon --- arch/arm/mach-rockchip/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v1 1/9] rockchip: RK3328: Read the reset cause from clock reset unit for RK3328 SoC

2024-05-16 Thread Quentin Schulz
Hi Anand, On 5/16/24 10:59 AM, Anand Moon wrote: Read the reset cause from clock reset unit for RK3328 SoC. Cc: Jagan Teki Signed-off-by: Anand Moon --- arch/arm/mach-rockchip/cpu-info.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v1 9/9] rockchip: RK3588: Enable display cpuinfo support on all boards

2024-05-16 Thread Quentin Schulz
Hi Anand, On 5/16/24 12:12 PM, Anand Moon wrote: Hi Quentin On Thu, 16 May 2024 at 14:52, Quentin Schulz wrote: Hi Anand, This is patch 9/9 but somehow I didn't receive any other patch, nor did the mailing list? c.f. https://lists.denx.de/pipermail/u-boot/2024-May/thread.html and https

Re: [PATCH v1 9/9] rockchip: RK3588: Enable display cpuinfo support on all boards

2024-05-16 Thread Quentin Schulz
Hi Anand, This is patch 9/9 but somehow I didn't receive any other patch, nor did the mailing list? c.f. https://lists.denx.de/pipermail/u-boot/2024-May/thread.html and https://lore.kernel.org/u-boot/. Are you registered on the ML? On 5/16/24 10:59 AM, Anand Moon wrote: Imply

Re: [PATCH v3] rockchip: rv1126: Migrate to OF_UPSTREAM

2024-05-13 Thread Quentin Schulz
Hi Anand, On 5/13/24 2:07 PM, Anand Moon wrote: [You don't often get email from an...@edgeble.ai. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hi Quentin, On Mon, 13 May 2024 at 16:10, Quentin Schulz wrote: Hi Anand, On 5/11/24 6:12 PM, Anand Moon wrote

Re: [PATCH v3] rockchip: rv1126: Migrate to OF_UPSTREAM

2024-05-13 Thread Quentin Schulz
Hi Anand, On 5/11/24 6:12 PM, Anand Moon wrote: [You don't often get email from an...@edgeble.ai. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Migrate RV1126 boards that exists in Linux v6.8 to use OF_UPSTREAM. Following targets is migrated to use

Re: [PATCH v2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-05-08 Thread Quentin Schulz
Hi Kever, On 5/8/24 4:42 AM, Kever Yang wrote: Hi Quentin,     Could you please update this patch with OF_UPSTREAM support? No, I cannot yet :/ Tiger is only available in Linux kernel v6.9-rcX and dts/ in U-Boot is currently at v6.8. What are we supposed to do for this then? Would

Re: [PATCH v2 03/22] clk: rockchip: rk3399: Improve support for SCLK_PCIEPHY_REF clock

2024-05-06 Thread Quentin Schulz
Hi Jonas, On 5/6/24 5:17 PM, Jonas Karlman wrote: Hi Quentin, On 2024-05-06 13:07, Quentin Schulz wrote: Hi Jonas, On 5/1/24 6:22 PM, Jonas Karlman wrote: rk3399-nanopi-4.dtsi try to set parent of and set rate to 100 MHz of the SCLK_PCIEPHY_REF clock. The existing enable/disable ops

Re: [PATCH v2 03/22] clk: rockchip: rk3399: Improve support for SCLK_PCIEPHY_REF clock

2024-05-06 Thread Quentin Schulz
Hi Jonas, On 5/1/24 6:22 PM, Jonas Karlman wrote: rk3399-nanopi-4.dtsi try to set parent of and set rate to 100 MHz of the SCLK_PCIEPHY_REF clock. The existing enable/disable ops for SCLK_PCIEPHY_REF currently force use of 24 MHz parent and rate. Add improved support for setting parent and

Re: [PATCH] board: rockchip: add ArmSoM Sige7 Rk3588 board

2024-05-06 Thread Quentin Schulz
Hi Jianfeng Liu, On 5/4/24 7:05 PM, Jianfeng Liu wrote: [You don't often get email from liujianfeng1...@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] ArmSoM Sige7 is a Rockchip RK3588 based SBC (Single Board Computer) by ArmSoM. There are two

Re: [PATCH v3] configs: rk3588-turing-rk1: disable SPI flash by default

2024-05-03 Thread Quentin Schulz
Reviewed-by: Jonas Karlman Reviewed=by: Quentin Schulz Thanks, Quentin

Re: [PATCH V2] board: rockchip: Add Indiedroid Nova

2024-05-03 Thread Quentin Schulz
Hi Chris, On 5/2/24 8:57 PM, Chris Morgan wrote: From: Chris Morgan The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid. Specifications: Rockchip RK3588S SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 4/8/16GB memory LPDDR4x Mali G610MC4 GPU Optional eMMC

Re: [PATCH] rockchip: Correct UUID for root partitions

2024-05-03 Thread Quentin Schulz
Hi Chris, On 4/26/24 5:33 PM, Chris Morgan wrote: From: Chris Morgan For root partitions, the UUID should still be random but the partition type uuid should either be b921b045-1df0-41c3-af44-4c6f280d3fae for aarch64 or 69dad710-2ce4-4e3c-b16c-21a1d49abed3 for aarch32. Correct the attribute so

Re: [PATCH] binman: Fix typo in mkimage etype description

2024-05-02 Thread Quentin Schulz
Hi Marek, On 4/26/24 12:54 AM, Marek Vasut wrote: Fix a typo, no functional change. Signed-off-by: Marek Vasut Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH v4 01/11] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-26 Thread Quentin Schulz
Hi Kever, On 4/26/24 09:41, Kever Yang wrote: Hi Quentin, On 2024/4/25 18:46, Quentin Schulz wrote: From: Quentin Schulz Allow RK3568 and RK3588 based boards to get the RAM bank configuration from the ROCKCHIP_TPL stage instead of the current logic. This fixes both an issue where 256MB

[PATCH v4 11/11] rockchip: rk356x: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK356x-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. The CONFIG_NR_DRAM_BANK now defaults to 10 which is a safe bet for reading banks from ATAGS, so let's use the default

[PATCH v4 10/11] rockchip: rk3588: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. The CONFIG_NR_DRAM_BANK now defaults to 10 which is a safe bet for reading banks from ATAGS, so let's use the default

[PATCH v4 09/11] rockchip: turing-rk1-rk3588: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 08/11] rockchip: toybrick_rk3588: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 07/11] rockchip: evb_rk3588 et al.: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 06/11] rockchip: rock5b-rk3588: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 05/11] rockchip: rock5a-rk3588s: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 04/11] rockchip: quartzpro64-rk3588: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 03/11] rockchip: nanopc-t6-rk3588: use DRAM banks from ATAGS

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting CONFIG_OF_BOARD_SETUP. Similarly, because

[PATCH v4 02/11] rockchip: NR_DRAM_BANKS now defaults to 10 when Rockchip TPL blob is used

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz When Rockchip TPL blob is used, the memory areas that can be used for DRAM is gotten from ATAGS passed through the DRAM at a specific address. The DDR_MEM tag contains at most 10 areas, so we should default to 10 if Rockchip TPL blob is used. Note that it is technically

[PATCH v4 01/11] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-25 Thread Quentin Schulz
From: Quentin Schulz Allow RK3568 and RK3588 based boards to get the RAM bank configuration from the ROCKCHIP_TPL stage instead of the current logic. This fixes both an issue where 256MB of RAM is blocked for devices with >= 4GB of RAM and where memory holes need to be defined for devi

[PATCH v4 00/11] rockchip: Support getting DRAM banks from TPL for rk3568 and rk3588

2024-04-25 Thread Quentin Schulz
mory areas from the memory areas to consider for putting holes in DRAM banks based on mem_map struct may conflict with SDRAM, ROM or flashes if we ever add those to the SoC's mem_map... Something we can tackle the day we do it, it's good enough for now. Co-Developed-by: Chris Morgan Signed-off-

Re: [PATCH 2/2] armv8: generic_timer: Use event stream for udelay

2024-04-24 Thread Quentin Schulz
Hi Peter, Andre, On 4/24/24 12:29, Andre Przywara wrote: On Tue, 23 Apr 2024 12:55:55 +0200 Quentin Schulz wrote: Hi Peter, On 4/23/24 10:10, Peter Hoyes wrote: From: Peter Hoyes Polling cntpct_el0 in a tight loop for delays is inefficient. This is particularly apparent on Arm FVPs

Re: [PATCH v3 01/11] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-24 Thread Quentin Schulz
Hi Jonas, On 4/24/24 00:40, Jonas Karlman wrote: Hi Quentin, On 2024-04-15 16:16, Quentin Schulz wrote: From: Quentin Schulz [...] + if (!(tmp_mem_map->attrs & PTE_BLOCK_NON_SHARE)) { This check does not seem to work because PTE_BLOCK_NON_SHARE evaluat

Re: [PATCH 2/2] armv8: generic_timer: Use event stream for udelay

2024-04-23 Thread Quentin Schulz
Hi Peter, On 4/23/24 10:10, Peter Hoyes wrote: From: Peter Hoyes Polling cntpct_el0 in a tight loop for delays is inefficient. This is particularly apparent on Arm FVPs, which do not simulate real time, meaning that a 1s sleep can take a couple of orders of magnitude longer to execute in wall

[PATCH v2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-23 Thread Quentin Schulz
From: Quentin Schulz The RK3588-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 connector) system-on-module from Theobroma Systems, featuring the Rockchip RK3588. It provides the following feature set: * up to 16GB LPDDR4x * on-module eMMC * SD card (on a baseboard) via edge connector

Re: [PATCH 2/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-23 Thread Quentin Schulz
Hi Jonas, On 4/22/24 19:54, Jonas Karlman wrote: Hi Quentin, On 2024-04-22 18:41, Quentin Schulz wrote: From: Quentin Schulz [...] diff --git a/arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi b/arch/arm/dts/rk3588-tiger-haikou-u-boot.dtsi new file mode 100644 index 000..4259399193a

Re: [PATCH 1/2] rockchip: rk3588: add support for UART2 M1 and M2 in SPL

2024-04-23 Thread Quentin Schulz
Hi Kever, On 4/23/24 03:09, Kever Yang wrote: Hi Quentin, On 2024/4/23 00:41, Quentin Schulz wrote: From: Quentin Schulz UART2 controller is the controller in the reference design for debug console. The default mux is M0 in that reference design. Until now, all boards seemed to be using

Re: [PATCH 1/2] rockchip: rk3588: add support for UART2 M1 and M2 in SPL

2024-04-23 Thread Quentin Schulz
Hi Jonas, On 4/22/24 19:41, Jonas Karlman wrote: Hi Quentin, On 2024-04-22 18:41, Quentin Schulz wrote: From: Quentin Schulz UART2 controller is the controller in the reference design for debug console. The default mux is M0 in that reference design. Until now, all boards seemed to be using

[PATCH 2/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-22 Thread Quentin Schulz
From: Quentin Schulz The RK3588-Q7 SoM is a Qseven-compatible (70mm x 70mm, MXM-230 connector) system-on-module from Theobroma Systems, featuring the Rockchip RK3588. It provides the following feature set: * up to 16GB LPDDR4x * on-module eMMC * SD card (on a baseboard) via edge connector

[PATCH 1/2] rockchip: rk3588: add support for UART2 M1 and M2 in SPL

2024-04-22 Thread Quentin Schulz
From: Quentin Schulz UART2 controller is the controller in the reference design for debug console. The default mux is M0 in that reference design. Until now, all boards seemed to be using UART2M0 but RK3588 Tiger for example will be using UART2M2 instead. Therefore, let's add support

[PATCH 0/2] rockchip: add support for Theobroma Systems SOM-RK3588-Q7 Tiger module

2024-04-22 Thread Quentin Schulz
properly. This has a light dependency on https://lore.kernel.org/u-boot/20240415-rk35xx-dram-atags-v3-0-5bc5475b3...@theobroma-systems.com/ (the Tiger defconfig can be updated to remove the dependency if required) Signed-off-by: Quentin Schulz --- Quentin Schulz (2): rockchip: rk3588: add

Re: [PATCH 1/1] Makefile: don't add -Wno-maybe-uninitialized twice

2024-04-22 Thread Quentin Schulz
Hi Heinrich, On 4/16/24 09:35, Heinrich Schuchardt wrote: Avoid adding the same flag to KBUILD_CFLAGS twice. Fixes: 8602d97ca2cf ("Makefile: avoid false positive -Wmaybe-uninitialized") Signed-off-by: Heinrich Schuchardt Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH] ram: rockchip: px30: Replace misleading log message

2024-04-17 Thread Quentin Schulz
BTW, On 4/17/24 13:16, lukasz.czechow...@thaumatec.com wrote: From: Lukasz Czechowski There is a typo in your mail address. I assume your git config user.email may be wrong, because your signed-off-by is correct. Cheers, Quentin

Re: [PATCH] ram: rockchip: px30: Replace misleading log message

2024-04-17 Thread Quentin Schulz
Hi Lukasz, On 4/17/24 13:16, lukasz.czechow...@thaumatec.com wrote: From: Lukasz Czechowski Remove the log message "out" from sdram_init function which pollutes the console. It brings no meaningful information and might be unwanted in case silencing the console is required. Instead, add a

Re: [PATCH v3] rockchip: px30-board-tpl: Sync ifdef guards with full TPL

2024-04-17 Thread Quentin Schulz
-by: Quentin Schulz Thanks, Quentin

Re: [PATCH v2] rockchip: px30-board-tpl: Use CONFIG_TPL_BANNER_PRINT flag

2024-04-17 Thread Quentin Schulz
e should change arch/arm/mach-rockchip/Kconfig to use an `imply` instead of `select`. Anyway, no change required on my side. Only, if there's a v3 (for the Cc and commit title, the Kconfig change would be a separate patch anyway). Reviewed-by: Quentin Schulz Thanks, Quentin

Re: [PATCH] rockchip: px30-board-tpl: Use CONFIG_TPL_BANNER_PRINT flag

2024-04-16 Thread Quentin Schulz
: Display TPL init information message only when TPL_BANNER_PRINT configuration entry is set. This allows to disable information message in case logs on UART are unwanted. Signed-off-by: Lukasz Czechowski This matches Rockchip's non-PX30 TPL, so: Reviewed-by: Quentin Schulz --- arch/arm/mach

  1   2   3   4   5   6   7   8   9   >