On 21/05/2024 13.54, Stefan Roese wrote:
> On 5/21/24 11:47, Rasmus Villemoes wrote:
>> On 21/05/2024 10.46, Rasmus Villemoes wrote:
>>> A bit of a mixed bag. I've been wanting to submit something like 3/3
>>> for a while. So when I stumbled on Marek's patch
>>
On 21/05/2024 10.46, Rasmus Villemoes wrote:
> A bit of a mixed bag. I've been wanting to submit something like 3/3
> for a while. So when I stumbled on Marek's patch
> https://lore.kernel.org/u-boot/20240316201416.211480-1-marek.vasut+rene...@mailbox.org/
> , I got reminded of that
that it can actually
never be reached, so not emit any code for it.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
board/Marvell/octeon_nic23/board.c | 9 +---
cmd/cyclic.c | 12 +-
common/cyclic.c| 22 +--
doc
, we cannot just skip the registration,
as the (new) timeout value may mean that we have to ask the cyclic
framework to call us more often. So if we're already running,
first unregister the old cyclic instance.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
drivers/watc
ake
that a requirement.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
common/cyclic.c | 2 +-
include/cyclic.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cyclic.c b/common/cyclic.c
index a49bfc88f5c..c62e7fa7d19 100644
--- a/common/cyclic.c
++
in the doc/ part. Rebase
to current master (676903c1b97), fixing trivial conflict with
301bac6047c8.
Rasmus Villemoes (3):
cyclic: stop strdup'ing name in cyclic_register()
wdt-uclass: prevent multiple cyclic_register calls
cyclic: make clients embed a struct cyclic_info in their own data
On 21/05/2024 08.57, Stefan Roese wrote:
> On 5/19/24 21:44, Rasmus Villemoes wrote:
>> On 18/05/2024 09.34, Stefan Roese wrote:
>>
>>> This introduces some problems when compiling e.g. sandbox:
>>>
>>> In file included from test/common/cyclic.c
that it can actually
never be reached, so not emit any code for it.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
board/Marvell/octeon_nic23/board.c | 9 +---
cmd/cyclic.c | 12 +--
common/cyclic.c| 22
to the new API.
v2: Add R-bs from Stefan. Fixup whitespace in the doc/ part. Rebase
to current master (676903c1b97), fixing trivial conflict with
301bac6047c8.
Rasmus Villemoes (3):
cyclic: stop strdup'ing name in cyclic_register()
wdt-uclass: prevent multiple cyclic_register calls
cyclic: make
, we cannot just skip the registration,
as the (new) timeout value may mean that we have to ask the cyclic
framework to call us more often. So if we're already running,
first unregister the old cyclic instance.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
drivers/watc
ake
that a requirement.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
common/cyclic.c | 2 +-
include/cyclic.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cyclic.c b/common/cyclic.c
index a49bfc88f5c..c62e7fa7d19 100644
--- a/common/cyclic.c
++
On 18/05/2024 09.34, Stefan Roese wrote:
> This introduces some problems when compiling e.g. sandbox:
>
> In file included from test/common/cyclic.c:10:
> test/common/cyclic.c: In function ‘dm_test_cyclic_running’:
> test/common/cyclic.c:25:42: warning: passing argument 1 of
> ‘cyclic_register’
On 16/05/2024 10.25, Claudius Heine wrote:
> Hi Tim and Marek,
>
> On 2024-05-16 12:46 am, Tim Harvey wrote:
>> On Tue, May 14, 2024 at 11:50 AM Tim Harvey
>> wrote:
>>> On Sun, May 12, 2024 at 10:08 PM Marek Vasut wrote:
On 5/8/24 9:23 AM, Claudius Heine wrote:
> On 2024-05-07 3:28
that it can actually
never be reached, so not emit any code for it.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
board/Marvell/octeon_nic23/board.c | 9 +---
cmd/cyclic.c | 12 +--
common/cyclic.c| 22
, we cannot just skip the registration,
as the (new) timeout value may mean that we have to ask the cyclic
framework to call us more often. So if we're already running,
first unregister the old cyclic instance.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
drivers/watc
trivial conflict with
301bac6047c8.
Rasmus Villemoes (3):
cyclic: stop strdup'ing name in cyclic_register()
wdt-uclass: prevent multiple cyclic_register calls
cyclic: make clients embed a struct cyclic_info in their own data
structure
board/Marvell/octeon_nic23/board.c | 9 ---
cmd
ake
that a requirement.
Reviewed-by: Stefan Roese
Signed-off-by: Rasmus Villemoes
---
common/cyclic.c | 2 +-
include/cyclic.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cyclic.c b/common/cyclic.c
index a49bfc88f5c..c62e7fa7d19 100644
--- a/common/cyclic.c
++
some tracked fork).
Signed-off-by: Rasmus Villemoes
---
Makefile| 5 +-
scripts/setlocalversion | 226
2 files changed, 116 insertions(+), 115 deletions(-)
diff --git a/Makefile b/Makefile
index efaf24e58e7..14acea9c6b9 100644
--- a/Makef
The first commit is trivial cleanup. The second syncs
scripts/setlocalversion with linux 6.9, with just a one-line change on
top to account for a Kbuild change that U-Boot has not yet adopted.
Rasmus Villemoes (2):
Makefile: refactor ubootrelease target
scripts/setlocalversion: sync
Instead of duplicating the contents of the filechk_uboot.release
variable, use it directly.
This is preparation for the next patch which will modify
filechk_uboot.release, and reflects what the linux kernel does
nowadays:
kernelrelease:
@$(filechk_kernel.release)
Signed-off-by: Rasmus
On 13/05/2024 12.40, Stefan Roese wrote:
> On 5/9/24 02:47, Rasmus Villemoes wrote:
>> Currently, the cyclic_register() done in wdt_start() is not undone in
>> wdt_stop(). Moreover, calling wdt_start multiple times (which is
>> perfectly allowed on an already started d
On 13/05/2024 11.03, Yoann Congal wrote:
>
>
> Le 13/05/2024 à 10:28, Rasmus Villemoes a écrit :
>> On 07/05/2024 19.23, Tom Rini wrote:
>>> On Tue, May 07, 2024 at 09:17:46AM +0200, Yoann Congal wrote:
>>>> But, my more general use case is the Y
On 13/05/2024 10.28, Rasmus Villemoes wrote:
> On 07/05/2024 19.23, Tom Rini wrote:
>> On Tue, May 07, 2024 at 09:17:46AM +0200, Yoann Congal wrote:
>>> Le 06/05/2024 à 19:43, Tom Rini a écrit :
>>>> On Sun, May 05, 2024 at 03:53:53PM +0200, Yoann Congal wrote:
&g
On 07/05/2024 19.23, Tom Rini wrote:
> On Tue, May 07, 2024 at 09:17:46AM +0200, Yoann Congal wrote:
>> Le 06/05/2024 à 19:43, Tom Rini a écrit :
>>> On Sun, May 05, 2024 at 03:53:53PM +0200, Yoann Congal wrote:
>>>
From: Masahiro Yamada
This is a cherry-pick from the kernel
that it can actually
never be reached, so not emit any code for it.
Signed-off-by: Rasmus Villemoes
---
board/Marvell/octeon_nic23/board.c | 9 +---
cmd/cyclic.c | 12 +--
common/cyclic.c| 22 +--
doc/develop/cyclic.rst
this model.
While actually doing those mostly mechanical changes, I stumbled on
two separate issues that probably want fixing regardless of the fate
of 3/3.
For now only compile-tested.
Rasmus Villemoes (3):
cyclic: stop strdup'ing name in cyclic_register()
wdt-uclass: prevent multiple
ake
that a requirement.
Signed-off-by: Rasmus Villemoes
---
common/cyclic.c | 2 +-
include/cyclic.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/cyclic.c b/common/cyclic.c
index a49bfc88f5c..c62e7fa7d19 100644
--- a/common/cyclic.c
+++ b/common/cyclic.c
@@ -4
, we cannot just skip the registration,
as the (new) timeout value may mean that we have to ask the cyclic
framework to call us more often. So if we're already running,
first unregister the old cyclic instance.
Signed-off-by: Rasmus Villemoes
---
drivers/watchdog/wdt-uclass.c | 9 +++
On 10/04/2024 14.24, Quentin Schulz wrote:
> Hi Rasmus,
>
>> @@ -321,6 +322,13 @@ static int pca953x_probe(struct udevice *dev)
>> driver_data = dev_get_driver_data(dev);
>> + /* If a reset-gpios property is present, take the device out of
>> reset. */
>> + ret =
The DT bindings for the pca953x family has an optional reset-gpios
property. If present, ensure that the device is taken out of reset
before attempting to read from it.
Signed-off-by: Rasmus Villemoes
---
drivers/gpio/pca953x_gpio.c | 8
1 file changed, 8 insertions(+)
diff --git
On 14/12/2023 08.33, Masahiro Yamada wrote:
> On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada wrote:
>>
> One more question to confirm if I can use this
> for my practical use-cases.
>
> Is U-Boot able to handle FIT (includes kernel + DTs)
> and a separate initrd?
>
> # bootm :
>
>
>
Such a config option does not exist. Rephrase, and avoid mentioning
MEM_SUPPORT_64BIT_DATA, which is an implementation detail.
Signed-off-by: Rasmus Villemoes
---
doc/usage/cmd/cmp.rst | 2 +-
doc/usage/cmd/cp.rst | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/usage
the proper "#if" instead.
There's really no point defining another similarly-named macro with
exactly the same value, so just use MEM_SUPPORT_64BIT_DATA throughout.
Signed-off-by: Rasmus Villemoes
---
cmd/mem.c | 38 ++
1 file changed, 18 insertions(+), 2
s expected.
It would probably be possible to make all such code explicitly use u64
and thus make it work on 32 bit targets, but until that is done, do
not pretend that it's ok to override the automatic value of
MEM_SUPPORT_64BIT_DATA.
Signed-off-by: Rasmus Villemoes
---
README | 3 ---
1 file
Signed-off-by: Rasmus Villemoes
---
test/cmd/Makefile | 1 +
test/cmd/mem_copy.c | 169
2 files changed, 170 insertions(+)
create mode 100644 test/cmd/mem_copy.c
diff --git a/test/cmd/Makefile b/test/cmd/Makefile
index e296ba1192b..b26b5b1ea85
This function obviously does not and must not modify "arg". Change the
prototype to allow passing an argument of type "const char*" without
requiring a cast.
Signed-off-by: Rasmus Villemoes
---
common/command.c | 2 +-
include/command.h | 2 +-
2 files changed, 2 insert
Now that the cp command is changed to use memmove() internally, update
the documentation to explicitly state that overlapping regions are
allowed.
Signed-off-by: Rasmus Villemoes
---
doc/usage/cmd/cp.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/usage/cmd/cp.rst
), which is of course completely in the noise
with all the string processing that a shell command does.
Reviewed-by: Simon Glass
Signed-off-by: Rasmus Villemoes
---
cmd/mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/mem.c b/cmd/mem.c
index 66c2d36a148..c696b92a274
Just check that the length is at least 2. This allows passing strings
like ".b", which can be convenient when constructing
tests (i.e. parametrizing the suffix used).
Signed-off-by: Rasmus Villemoes
---
common/command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
into patch 1.
3 and 4 are preparations for the test cases added in patch 5.
6 is an actual fix; 32 bit targets wrongly list .q in their help texts.
7 and 8 fix stale documentation.
Rasmus Villemoes (8):
cmd/mem.c: use memmove in do_mem_cp()
doc/usage/cmd/cp.rst: document that overlapping
On 20/12/2023 09.59, Sébastien Szymanski wrote:
> Without the '-ansi' option, the 'linux' string in env. files is replaced
> with the string '1 '. For example, in the
> board/armadeus/opos6uldev/opos6uldev.env file,
>
> kernelimg=opos6ul-linux.bin
>
> becomes
>
> kernelimg=opos6ul-1 .bin
>
>
), which is of course completely in the noise
with all the string processing that a shell command does.
Signed-off-by: Rasmus Villemoes
---
cmd/mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/mem.c b/cmd/mem.c
index 66c2d36a148..c696b92a274 100644
--- a/cmd/mem.c
On 29/11/2023 16.23, Tom Rini wrote:
> On Fri, Nov 17, 2023 at 12:38:11PM +0100, Rasmus Villemoes wrote:
>
>> ---
>> doc/device-tree-bindings/leds/leds-lp5562.txt | 63 ++
>> drivers/led/Kconfig | 8 +
>> drivers/led/Makefile
On 19/11/2023 20.09, Simon Glass wrote:
> On Fri, 17 Nov 2023 at 15:52, Tom Rini wrote:
>>
>> With commit 3609e1dc ("dts: automatically build necessary .dtb files")
>> we now have logic that will ensure that all device trees needed in the
>> binary are built automatically. Any device tree that
Use the helper led_bind_generic() to reduce code duplication.
Signed-off-by: Rasmus Villemoes
---
drivers/led/led_pwm.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/led/led_pwm.c b/drivers/led/led_pwm.c
index 7c8eae9337b..ae6de3087ab 100644
.
As our boards only have the R,G,B outputs connected, I have not
actually tested how the white channel behaves, but the R,G,B work
exactly as expected.
[1]
https://lore.kernel.org/u-boot/1547150757-1561-1-git-send-email-douglas.zo...@climate.com/
Cc: Doug Zobel
Signed-off-by: Rasmus Villemoes
to the LED driver explicitly via
device_bind_driver_to_node(). This is similar to what e3aa76644c2a did
for gpio_led, but that fix was then supplanted by 01074697801b.
Fixes: 83c63f0d1185 ("led: Move OF "label" property parsing to core")
Signed-off-by: Rasmus Villemoes
---
drivers/led/l
Use the helper led_bind_generic() to reduce code duplication.
Signed-off-by: Rasmus Villemoes
---
drivers/led/led_gpio.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c
index fbed151b5d9..71421de628c 100644
All existing drivers in drivers/led/ contain a .bind method that does
exactly the same thing, with just the actual driver name
differing. Create a helper so all those individual methods can be
changed to one-liners.
Reviewed-by: Marek Vasut
Signed-off-by: Rasmus Villemoes
---
drivers/led/led
If the driver's own .bind method has populated uc_plat->label, don't
override that. This is necessary for an upcoming driver for ti,lp5562,
where the DT binding unfortunately says to use "chan-name" and not
"label".
Reviewed-by: Christian Gmeiner
Reviewed-by: Marek Vasut
oug Zobel (1):
led: add TI LP5562 LED driver
Rasmus Villemoes (5):
led-uclass: honour ->label field populated by driver's own .bind
led-uclass: do not create fallback label for top-level node
led: introduce led_bind_generic()
led: led_gpio: use led_bind_generic() helper
led: led_pw
On 05/11/2023 21.03, Simon Glass wrote:
> This little series corrects a problem I noticed with arm64 images,
> where the kernel is not recognised:
The $subject is misleading, bootm works just fine with compressed arm64
images, with the type set to "kernel".
> Type: Kernel Image
On 07/11/2023 08.30, Rasmus Villemoes wrote:
> I'll send a revert to Tom for the prematurely applied fixup.
Oh, I see that's already done. Good.
Rasmus
On 07/11/2023 01.46, Sean Anderson wrote:
> On 10/13/23 14:30, Rasmus Villemoes wrote:
>> On 12/10/2023 04.17, Sean Anderson wrote:
>>
>>> I was hoping you would respond to my most-recent email regarding this
>>> series.
>>> In particular:
>>>
>
On 04/11/2023 20.43, Simon Glass wrote:
> Hi Rasmus,
> Are you planning a new version of this series?
No. AFAICT there's nothing to be done on my end.
Rasmus
pagesize. Fix this by recording the actual bytes downloaded.
>
> Fixes: 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of
> spl_load_simple_fit() to get full FIT size")
> Signed-off-by: Marcel Ziswiler
>
Thanks for reporting and fixing this, and sorry for the trouble.
Acked-by: Rasmus Villemoes
On 25/10/2023 18.01, Marcel Ziswiler wrote:
> Hi Rasmus
>
> On Tue, 2023-10-24 at 16:32 +0200, Rasmus Villemoes wrote:
>> What am I missing?
>
> Good question. Some more debugging revealed that we are missing 464 bytes at
> the beginning of the buffer. Why
> woul
de-effect of
swallowing the first following char. But I never found the time to dig
into why or if it was even fixable.
Tom has already applied this, but nevertheless
Tested-by: Rasmus Villemoes
Rasmus
"(pagesize > 1 ?
1024 : 1)" or something like that.
I don't think it will work, but OTOH my analysis below doesn't find any
other (fundamental) difference between the old and new code.
>
> On Tue, 2023-10-24 at 13:17 +0200, Rasmus Villemoes wrote:
>
>>
>> and this
On 24/10/2023 12.03, Marcel Ziswiler wrote:
> Hi Rasmus
>
> Thanks for your help.
>
> On Tue, 2023-10-24 at 11:18 +0200, Rasmus Villemoes wrote:
>
>
> [snip]
>
>> Hm. Can you show the result of 'fdtdump u-boot.itb | head'
>
> ⬢[zim@toolbox
On 24/10/2023 09.39, Marcel Ziswiler wrote:
> Hi
>
> On our weekly master upstream CI build we noticed Verdin iMX8M Plus boot
> looping.
>
> Bisecting pointed to the following commit:
>
> commit 4b4472438f5a ("imx: spl_imx_romapi: avoid tricky use of
> spl_load_simple_fit() to get full FIT
On 23/10/2023 11.39, Marek Vasut wrote:
> On 10/23/23 11:11, Rasmus Villemoes wrote:
>> On 19/10/2023 15.58, Marek Vasut wrote:
>>> On 10/19/23 11:58, Rasmus Villemoes wrote:
>>>> From: Doug Zobel
>>>>
>>>> Driver for the TI LP5562 4 ch
On 19/10/2023 15.58, Marek Vasut wrote:
> On 10/19/23 11:58, Rasmus Villemoes wrote:
>> From: Doug Zobel
>>
>> Driver for the TI LP5562 4 channel LED controller. Supports
>> independent on/off control of all 4 channels. Supports LED_BLINK on 3
>> independent ch
On 19/10/2023 15.54, Marek Vasut wrote:
> On 10/19/23 11:58, Rasmus Villemoes wrote:
>> If the driver's own .bind method has populated uc_plat->label, don't
>> override that. This is necessary for an upcoming driver for ti,lp5562,
>> where the DT binding unfortunatel
On 19/10/2023 15.51, Marek Vasut wrote:
> On 10/19/23 11:58, Rasmus Villemoes wrote:
>> Many existing drivers, and led-uclass itself, rely on uc_plat->label
>> being NULL for the device representing the top node, as opposed to the
>> child nodes representing ind
On 19/10/2023 15.04, Richard Marko wrote:
> If we try to build using external dtc using
>
>> make DTC=dtc
>
> we get a confusing error like
>
>> make[2]: *** No rule to make target 'arch/x86/dts/bayleybay.dtb',
>> needed by 'dtbs'. Stop.
>
> Workaround is to use
>
>> make DTC=$( which dtc )
.
As our boards only have the R,G,B outputs connected, I have not
actually tested how the white channel behaves, but the R,G,B work
exactly as expected.
[1]
https://lore.kernel.org/u-boot/1547150757-1561-1-git-send-email-douglas.zo...@climate.com/
Cc: Doug Zobel
Signed-off-by: Rasmus Villemoes
Signed-off-by: Rasmus Villemoes
---
drivers/led/led_pwm.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/led/led_pwm.c b/drivers/led/led_pwm.c
index 7c8eae9337..ae6de3087a 100644
--- a/drivers/led/led_pwm.c
+++ b/drivers/led/led_pwm.c
@@ -9,7 +9,6
Signed-off-by: Rasmus Villemoes
---
drivers/led/led_gpio.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c
index fbed151b5d..71421de628 100644
--- a/drivers/led/led_gpio.c
+++ b/drivers/led/led_gpio.c
@@ -11,7
All existing drivers in drivers/led/ contain a .bind method that does
exactly the same thing, with just the actual driver name
differing. Create a helper so all those individual methods can be
changed to one-liners.
Signed-off-by: Rasmus Villemoes
---
drivers/led/led-uclass.c | 18
If the driver's own .bind method has populated uc_plat->label, don't
override that. This is necessary for an upcoming driver for ti,lp5562,
where the DT binding unfortunately says to use "chan-name" and not
"label".
Signed-off-by: Rasmus Villemoes
---
drivers/led/led-uc
to
what e3aa76644c2a did, but that then vanished with the next commit.]
Fixes: 83c63f0d1185 ("led: Move OF "label" property parsing to core")
Signed-off-by: Rasmus Villemoes
---
drivers/led/led-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
ith the linux driver), most of the
logic is unchanged from Doug's original patch, so he is still listed
as author.
Doug Zobel (1):
led: add TI LP5562 LED driver
Rasmus Villemoes (5):
led-uclass: do not create fallback label for top-level node
led-uclass: honour ->label field populated by dr
On 18/10/2023 09.43, Rasmus Villemoes wrote:
> On 17/10/2023 17.33, Marek Vasut wrote:
>> Which string ? The "bcm6753-led" is driver name , so that would have to
>> be parametrized.
>
> Exactly. The only difference between the two examples (apart from the
> sco
On 17/10/2023 17.33, Marek Vasut wrote:
> On 10/17/23 15:29, Rasmus Villemoes wrote:
>> static int led_gpio_bind(struct udevice *parent)
>> {
...
>> ret = device_bind_driver_to_node(parent, "gpio_led",
>> ofnode_get_name(no
Hi,
I'm trying to resurrect an old submission of a driver for ti,lp5562, so
had occasion to dig into drivers/led/. And I think commit 83c63f0d118 is
buggy or at least incomplete.
Many of the drivers that were subsequently modified to not do that
"label" parsing rely, in their .probe method, on
On 17/10/2023 12.44, Richard Marko wrote:
> If we try to build using external dtc using
>
>> make DTC=dtc
>
> we get a confusing error like
>
>> make[2]: *** No rule to make target 'arch/x86/dts/bayleybay.dtb',
>> needed by 'dtbs'. Stop.
>
> Workaround is to use
>
>> make DTC=$( which dtc )
of cpp ifdef, we can remove the
ifdef around the _serial_flush() definition - if neither
CONSOLE_FLUSH_SUPPORT or CONSOLE_FLUSH_ON_NEWLINE are enabled, the
compiler elides _serial_flush(), but it won't warn about it being
unused.
Signed-off-by: Rasmus Villemoes
---
common/Kconfig | 10
has time to actually emit all the characters. That
can be very confusing, because one doesn't then know exactly where the
hang happens.
Rasmus Villemoes (2):
serial: serial-uclass.c: move definition of _serial_flush up a bit
serial: introduce CONFIG_CONSOLE_FLUSH_ON_NEWLINE
common/Kconfig
Preparation for next patch.
Reviewed-by: Simon Glass
Signed-off-by: Rasmus Villemoes
---
drivers/serial/serial-uclass.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index
On 12/10/2023 04.17, Sean Anderson wrote:
> I was hoping you would respond to my most-recent email regarding this
> series.
> In particular:
>
> | Why does mkimage have to do this? Can't you just use truncate or, in a
> | binman context, align-size?
In both cases, that just affects the size of
On 11/10/2023 20.37, Tom Rini wrote:
> On Thu, Sep 28, 2023 at 10:02:57AM +0200, Rasmus Villemoes wrote:
>
>> The man page correctly said that -B was ignored without -E, while the
>> `mkimage -h` output suggested otherwise. Now that -B can actually be
>> used by its
On 04/10/2023 04.10, Simon Glass wrote:
> On Tue, 3 Oct 2023 at 04:02, Rasmus Villemoes
> wrote:
>>
>> We're seeing sporadic errors like
>>
>> ENVCinclude/generated/env.txt
>> HOSTCC scripts/basic/fixdep
>> ENVPinclude/generated/env.in
&g
depend on the phony scripts_basic
target.
Signed-off-by: Rasmus Villemoes
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 8af1fa9468..069c03696a 100644
--- a/Makefile
+++ b/Makefile
@@ -2447,7 +2447,7 @@ cmd_genenv = \
On 03/10/2023 00.46, Tom Rini wrote:
> On Tue, Oct 03, 2023 at 12:27:25AM +0200, Heinrich Schuchardt wrote:
>>
>> error = stdio_register(dev);
>> -#if !defined(CONFIG_SPL_BUILD) || CONFIG_IS_ENABLED(ENV_SUPPORT)
>> -/* check if this is the standard input device */
>> -if (!error &&
On 02/10/2023 20.56, Simon Glass wrote:
> Hi Tom,
>
> On Mon, 2 Oct 2023 at 10:22, Tom Rini wrote:
>>
>>> I'm really not sure that replacing build rules with a board CONFIG is
>>> a good idea. I suppose part of my confusion is why the Makefile is
>>> considered a problem?
>>
>> Because it's
On 29/09/2023 18.02, Tom Rini wrote:
> On Fri, Sep 29, 2023 at 09:15:00AM -0600, Simon Glass wrote:
>> Honestly at this point I've forgotten what this is all about.
Fair enough, let me try to recap, though even a summary is a bit long.
(1) I wanted to do what $subject says, and you seemed to be
On 20/06/2023 00.41, Tobias Deiminger wrote:
> quiet_cmd_wrap = WRAP$@
> -cmd_wrap = echo "\#include <../$(patsubst $(obj)/%,%,$@)>" >$@
> +cmd_wrap = echo "\#include <../$(patsubst $(obj)/generated/%,%,$@)>" >$@
>
> -$(obj)/boot/%.c $(obj)/common/%.c $(obj)/env/%.c $(obj)/lib/%.c:
>
Signed-off-by: Rasmus Villemoes
---
doc/mkimage.1 | 6 --
tools/mkimage.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/doc/mkimage.1 b/doc/mkimage.1
index 76c7859bb0..1a4bc25936 100644
--- a/doc/mkimage.1
+++ b/doc/mkimage.1
@@ -281,8 +281,10 @@ properties. A \(oqdata
On 27/09/2023 21.02, Sean Anderson wrote:
> On 9/19/23 07:37, Rasmus Villemoes wrote:
>> In some cases, using the "external data" feature is impossible or
>> undesirable, but one may still want (or need) the FIT image to have a
>> certain alignment. Also, given
On 25/09/2023 17.14, Jonas Karlman wrote:
>> fit,align
>> -Indicates what alignment to use for the FIT and its external data,
>> -and provides the alignment to use. This is passed to mkimage via
>> -the -B flag.
>> +Indicates what alignment to use for the FIT
On 25/09/2023 20.19, Tom Rini wrote:
> On Mon, Sep 25, 2023 at 10:27:43AM +0200, Rasmus Villemoes wrote:
>> On 04/05/2023 14.35, Rasmus Villemoes wrote:
>>> On 03/05/2023 16.54, Tom Rini wrote:
>>
>>>> The one last problem now is on stm32mp15_dhcor_basic which
On 25/09/2023 15.10, Simon Glass wrote:
> Hi Rasmus,
>
> On Mon, 25 Sept 2023 at 02:47, Rasmus Villemoes
> wrote:
>> Since patches 2,3,4 touch binman code, could you take all four?
>
> Yes, will do. I didn't pick them up in the most recent PR as I try to
> have t
one doesn't then know exactly where the
hang happens.
Introduce a config knob allowing one to wait for the uart fifo to
drain whenever a newline character is printed, roughly corresponding
to the effect of setvbuf(..., _IOLBF, ...) in ordinary C programs.
Signed-off-by: Rasmus Villemoes
Preparation for next patch.
Signed-off-by: Rasmus Villemoes
---
drivers/serial/serial-uclass.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 067fae2614..2f75ff878c 100644
programs.
Rasmus Villemoes (2):
serial: serial-uclass.c: move definition of _serial_flush up a bit
serial: introduce CONFIG_CONSOLE_FLUSH_ON_NEWLINE
common/Kconfig | 11 +++
drivers/serial/serial-uclass.c | 28
2 files changed, 27 insertions
On 21/09/2023 03.02, Simon Glass wrote:
> Hi Rasmus,
>
> On Fri, 15 Sept 2023 at 11:51, Rasmus Villemoes
> wrote:
>>
>> Currently, setting both CONFIG_SPL_SYS_MALLOC_SIMPLE and
>> CONFIG_SYS_SPL_MALLOC (but not CONFIG_SPL_STACK_R) doesn't work as
>> expect
On 22/09/2023 17.26, Simon Glass wrote:
>>> Shouldn't this be fdt_open_into()?
>>
>> I honestly just copy-pasted fit_extract_data() and shaved it down to the
>> part that does the "align the FDT part of the file".
>>
>> I don't really understand your question. Are you saying this doesn't
>> work
On 04/05/2023 14.35, Rasmus Villemoes wrote:
> On 03/05/2023 16.54, Tom Rini wrote:
>> The one last problem now is on stm32mp15_dhcor_basic which is a
>> defconfig missing one from OF_LIST but including it in the its file, so
>> the above is the patch we need.
>>
>
Moving towards using .dtso for overlay sources, update the
documentation examples to follow that pattern.
Signed-off-by: Rasmus Villemoes
---
doc/develop/uefi/uefi.rst | 4 ++--
doc/usage/fdt_overlays.rst | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/develop/uefi
1 - 100 of 838 matches
Mail list logo
