Re: [PATCH v4 3/3] MAINTAINERS: add myself as Methode maintainer

2022-05-20 Thread Stefan Roese
On 20.05.22 13:26, Robert Marko wrote: On Fri, May 20, 2022 at 1:17 PM Stefan Roese wrote: On 20.05.22 13:12, Robert Marko wrote: I am currently maintaing the Methode uDPU and eDPU boards so add myself as the maintainer for them. Signed-off-by: Robert Marko --- MAINTAINERS | 8

Re: [PATCH v4 3/3] MAINTAINERS: add myself as Methode maintainer

2022-05-20 Thread Stefan Roese
Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] board: turris: Find atsha device by atsha driver

2022-05-19 Thread Stefan Roese
: Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_atsha_otp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/board/CZ.NIC/turris_atsha_otp.c b/board/CZ.NIC/turris_atsha_otp.c index 8c39f5e52414..e62b7ee2a49a 100644 --- a/board/CZ.NIC

Re: [PATCH] arm64: mvebu: handle non-zero base address for RAM

2022-05-19 Thread Stefan Roese
eturn USABLE_RAM_SIZE; + unsigned long top = CONFIG_SYS_SDRAM_BASE + min(gd->ram_size, USABLE_RAM_SIZE); - return gd->ram_size; + return (gd->ram_top > top) ? top : gd->ram_top; } Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] pci: Handle failed calloc in decode_regions()

2022-05-19 Thread Stefan Roese
On 19.05.22 18:48, Pierre-Clément Tosi wrote: Add a check for calloc() failing to allocate the requested memory. Make decode_regions() return an error code. Cc: Bin Meng Cc: Simon Glass Cc: Stefan Roese Signed-off-by: Pierre-Clément Tosi Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH] ubifs: Fix lockup/crash when reading files

2022-05-18 Thread Stefan Roese
ENOENT. This patch fixes ubifsload on P2020. Fixes: b1a14f8a1c2e ("UBIFS: Change ubifsload to not read beyond the requested size") Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese --- Stefan, could you please look at this patch? Mentioned commit was introduced by you more than 11

Please pull u-boot-marvell/master

2022-05-17 Thread Stefan Roese
Hi Tom, please pull this next batch of mostly Marvell related patches: - Misc Kconfig cleanups (Chris & Pali) - turris_omnia: Fix hangup in debug UART (this introduces TPL/SPL_DEBUG_UART_BASE) Pali - mvebu: uDPU: include fixed-ph

Re: [PATCH 1/2] pinctrl: probe pinctrl drivers during post-bind

2022-05-17 Thread Stefan Roese
set. Do not bind.\n"); return -EINVAL; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] mvebu: uDPU: include fixed-phy support

2022-05-17 Thread Stefan Roese
NFIG_PHY_FIXED=y CONFIG_PHY_GIGE=y CONFIG_E1000=y CONFIG_MVNETA=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] arm: mvebu: turris_{omnia,mox}: Enable CONFIG_NETCONSOLE

2022-05-17 Thread Stefan Roese
+68,7 @@ CONFIG_USE_ETHPRIME=y CONFIG_ETHPRIME="ethernet@34000" CONFIG_ARP_TIMEOUT=200 CONFIG_NET_RETRY_COUNT=50 +CONFIG_NETCONSOLE=y CONFIG_SPL_OF_TRANSLATE=y CONFIG_AHCI_PCI=y CONFIG_AHCI_MVEBU=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managin

Re: [PATCH 0/5] arm: mvebu: turris_omnia: Fix hangup in debug UART

2022-05-17 Thread Stefan Roese
On 06.05.22 11:05, Pali Rohár wrote: If proper U-Boot on Turris Omnia tries to print something on debug UART then CPU hangs. Reason is that debug UART in proper U-Boot for Turris Omnia has incorrect configuration of base register. Base register is different in SPL and also in different stages of

Re: [PATCH 7/5] serial: Add new config option TPL_DEBUG_UART_BASE

2022-05-17 Thread Stefan Roese
On 16.05.22 18:49, Pali Rohár wrote: TPL_DEBUG_UART_BASE is same as DEBUG_UART_BASE, but applies only for TPL. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/serial/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/serial

Re: [PATCH] cmd: mvebu: Hide bubt specific options when bubt is disabled

2022-05-17 Thread Stefan Roese
quot; command if the source file name is omitted +endif + config CMD_MVEBU_COMPHY_RX_TRAINING bool "mvebu_comphy_rx_training" depends on ARMADA_8K Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich,

Re: [PATCH] arm: mvebu: Remove unused ARMADA_64BIT

2022-05-17 Thread Stefan Roese
SPL_SYS_NO_VECTOR_TABLE if SPL -config ARMADA_64BIT - bool - select ARM64 - # ARMv7 SoCs... config ARMADA_375 bool Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCH 0/5] arm: mvebu: turris_omnia: Fix hangup in debug UART

2022-05-16 Thread Stefan Roese
Hi Pali, On 06.05.22 11:05, Pali Rohár wrote: If proper U-Boot on Turris Omnia tries to print something on debug UART then CPU hangs. Reason is that debug UART in proper U-Boot for Turris Omnia has incorrect configuration of base register. Base register is different in SPL and also in different

Re: [PATCH] arm: mvebu: Espressobin: Add NVMe to boot targets

2022-05-16 Thread Stefan Roese
Hi Pali, On 03.05.22 11:01, Pali Rohár wrote: NVMe support is already enabled, so add it into boot targets. Signed-off-by: Pali Rohár --- include/configs/mvebu_armada-37xx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/mvebu_armada-37xx.h b/include/configs/mvebu_arma

Re: [PATCH 2/2] arm: mvebu: add support for Methode eDPU

2022-05-16 Thread Stefan Roese
On 16.05.22 10:52, Robert Marko wrote: On Mon, May 16, 2022 at 8:40 AM Stefan Roese wrote: On 06.05.22 20:01, Robert Marko wrote: Methode eDPU is an Armada 3720 power board based on the Methode uDPU. They feature the same CPU, RAM, and storage as well as the form factor. However, eDPU only

Re: [PATCH 2/2] arm: mvebu: add support for Methode eDPU

2022-05-15 Thread Stefan Roese
duplication, split the uDPU DTS into a common one. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 45 ++ arch/arm/dts/armada-3720-eDPU.dts | 14 ++ arch/arm/dts/armada-3720-uDPU.dts | 153

Re: [PATCH 1/2] pinctrl: probe pinctrl drivers during post-bind

2022-05-15 Thread Stefan Roese
s does. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/pinctrl/pinctrl-uclass.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index 4462ed20e2..38ce2b5e0a 100644 --- a/drivers/

Re: [PATCH 6/5] arm: mvebu: Fix DEBUG_UART_BASE for all 32-bit boards

2022-05-15 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- configs/clearfog_defconfig | 3 ++- configs/controlcenterdc_defconfig | 3 ++- configs/db-88f6820-amc_defconfig| 3 ++- configs/db-88f6820-gp_defconfig | 3 ++- configs/db-mv784mp-gp_defconfig | 3 ++- configs

Re: [PATCH 5/5] arm: mvebu: turris_omnia: Fix DEBUG_UART_BASE

2022-05-15 Thread Stefan Roese
proper U-Boot when it is trying to print something via debug UART. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/turris_omnia_defconfig b/configs

Re: [PATCH 4/5] serial: ns16550: Add support for SPL_DEBUG_UART_BASE

2022-05-15 Thread Stefan Roese
On 06.05.22 11:05, Pali Rohár wrote: Use CONFIG_VAL(DEBUG_UART_BASE) instead of CONFIG_DEBUG_UART_BASE, so proper config value (CONFIG_DEBUG_UART_BASE or CONFIG_SPL_DEBUG_UART_BASE) is used based on building target. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH 3/5] serial: Add new config option SPL_DEBUG_UART_BASE

2022-05-15 Thread Stefan Roese
On 06.05.22 11:05, Pali Rohár wrote: SPL_DEBUG_UART_BASE is same as DEBUG_UART_BASE, but applies only for SPL. In some cases base address of UART is different in SPL and proper U-Boot. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/serial/Kconfig | 7

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-15 Thread Stefan Roese
arch_cpu_init(). Movement is done in proper U-Boot, not in SPL. SPL may return to bootrom and bootrom requires internal registers at (old) expected location. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig| 1 + arch/arm/mach-mvebu/Makefile

Re: [PATCH 1/5] arm: Add new config option ARCH_VERY_EARLY_INIT

2022-05-15 Thread Stefan Roese
Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/Kconfig| 6 ++ arch/arm/lib/crt0.S | 5 + 2 files changed, 11 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 0afec5155b1b..9898c7d68e1b 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -401,6

[PATCH 1/2] watchdog: octeontx_wdt: Add MIPS Octeon support

2022-05-11 Thread Stefan Roese
the EBB7304 eval board. Signed-off-by: Stefan Roese Cc: Aaron Williams Cc: Chandrakala Chavva --- drivers/watchdog/Kconfig| 9 ++--- drivers/watchdog/octeontx_wdt.c | 67 - 2 files changed, 53 insertions(+), 23 deletions(-) diff --git a/drivers/watc

[PATCH 2/2] mips: octeon: octeon_ebb7304_defconfig: Enable watchdog support

2022-05-11 Thread Stefan Roese
This patch enables the recently added watchdog support on the MIPS Octeon EBB7304 eval board. Signed-off-by: Stefan Roese Cc: Aaron Williams Cc: Chandrakala Chavva Cc: Daniel Schwierzeck --- configs/octeon_ebb7304_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs

Re: [PATCH] net: fix phy_string_for_interface

2022-05-10 Thread Stefan Roese
d-off-by: Tim Harvey Cc: Marek Behún Cc: Stefan Roese Cc: Ramon Fried Cc: Vladimir Oltean Reviewed-by: Stefan Roese Thanks, Stefan --- include/phy_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/phy_interface.h b/include/phy_interface.

Re: [PATCH v4 06/25] mips: mtmips: add two reference boards for mt7621

2022-05-10 Thread Stefan Roese
SDXC is not available. Reviewed-by: Daniel Schwierzeck Signed-off-by: Weijie Gao Reviewed-by: Stefan Roese Thanks, Stefan --- v4 changes: Modify defconfig files for booting from flash v3 changes: none v2 changes: Add config file for mt7621-rfb boards --- arch/mips/dts/Makefile

Re: [PATCH] arm: mvebu: turris_{omnia,mox}: Enable CONFIG_NETCONSOLE

2022-05-09 Thread Stefan Roese
On 09.05.22 11:12, Pali Rohár wrote: This allows to use U-Boot console on Turris devices via network. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_mox_defconfig | 1 + configs/turris_omnia_defconfig | 1 + 2 files changed, 2 insertions

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-06 Thread Stefan Roese
On 06.05.22 14:16, Stefan Roese wrote: On 06.05.22 14:09, Pali Rohár wrote: On Friday 06 May 2022 14:04:53 Stefan Roese wrote: On 06.05.22 11:05, Pali Rohár wrote: Moving of internal registers from INTREG_BASE_ADDR_REG to SOC_REGS_PHY_BASE needs to be done very early, prior calling any

Re: [PATCH] mvebu: uDPU: include fixed-phy support

2022-05-06 Thread Stefan Roese
it not enabling fixed-phy support in defconfig like it did for other boards. Fixes: 77fcf3cf1251 ("net: mvneta: Convert to use PHY_FIXED for fixed-link") Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Thanks, Stefan --- configs/uDPU_defconfig | 1 + 1 file changed, 1 in

Re: [PATCH 5/5] arm: mvebu: turris_omnia: Fix DEBUG_UART_BASE

2022-05-06 Thread Stefan Roese
Isn't such a change now needed for all 32bit Armada MVEBU targets? Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-06 Thread Stefan Roese
On 06.05.22 14:09, Pali Rohár wrote: On Friday 06 May 2022 14:04:53 Stefan Roese wrote: On 06.05.22 11:05, Pali Rohár wrote: Moving of internal registers from INTREG_BASE_ADDR_REG to SOC_REGS_PHY_BASE needs to be done very early, prior calling any function which may touch internal registers

Re: [PATCH 2/5] arm: mvebu: Move internal registers in arch_very_early_init() function

2022-05-06 Thread Stefan Roese
to SOC_REGS_PHY_BASE */ + ldr r0, =SOC_REGS_PHY_BASE + ldr r1, =INTREG_BASE_ADDR_REG + str r0, [r1] + add r0, r0, #0xC000 + mcr p15, 4, r0, c15, c0 + + bx lr +ENDPROC(arch_very_early_init) Viele Grüße, Stefan Roese -- DENX Software Engin

Re: [PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-06 Thread Stefan Roese
dt_ids, + .probe = max6370_wdt_probe, + .priv_auto = sizeof(struct max6370_wdt), + .ops = &max6370_wdt_ops, +}; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Please pull u-boot-watchdog/master

2022-05-06 Thread Stefan Roese
Hi Tom, please pull the following watchdog related patch: - Add MAX6370 watchdog timer driver (Pali) Here the Azure build, without any issues: https://dev.azure.com

Re: [PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-05 Thread Stefan Roese
On 05.05.22 19:15, Pali Rohár wrote: On Thursday 05 May 2022 11:36:09 Pali Rohár wrote: On Tuesday 03 May 2022 07:16:34 Stefan Roese wrote: On 02.05.22 18:41, Pali Rohár wrote: MAX6370 watchdog is available e.g. on Freescale P1/P2 RDB-PC boards. Signed-off-by: Pali Rohár --- drivers

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-04 Thread Stefan Roese
Hi Josua, On 03.05.22 21:09, Josua Mayer wrote: \o/ Am 03.05.22 um 13:54 schrieb Stefan Roese: Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc

Re: [PATCH] arm: mvebu: Remove unused ARMADA_64BIT

2022-05-04 Thread Stefan Roese
On 05.05.22 04:09, Chris Packham wrote: Nothing selects ARMADA_64BIT. Instead the 64-bit SoCs just select ARM64 directly. Remove the unused config item. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 4 1 file changed, 4

Please pull u-boot-marvell/master

2022-05-04 Thread Stefan Roese
PHY_FIXED is not compiled in net: mvneta: Drop unneeded macro Stefan Roese (12): mips: octeon: Misc changes to existing headers for upcoming eth support mips: octeon: Misc changes to existing C files for upcoming eth support mips: octeon: Makefile: Enable building of the ne

Re: [PATCH u-boot-marvell 00/19] some mvneta changes, cleanups, fixes

2022-05-04 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Hello Stefan, here come some refactors, cleanups and fixed for the mvneta driver. Marek Behún (19): net: mvneta: Get rid of platdata net: mvneta: Fix 10Mbps speed net: mvneta: Use DM MDIO API for connecting PHY net: mvneta: R

Re: [PATCH v2 00/52] mips: octeon: Add ethernet support

2022-05-04 Thread Stefan Roese
On 07.04.22 09:11, Stefan Roese wrote: This patchset adds the networking files and drivers including device helper headers and C files. Please excuse the massive amount of files in this patch series. Also the sometimes huge files (mostly headers with register definitions) that I needed to

Re: [PATCH] Convert CONFIG_MTD_CONCAT to Kconfig

2022-05-03 Thread Stefan Roese
. Reviewed-by: Stefan Roese Thanks, Stefan configs/etamin_defconfig | 1 + drivers/mtd/Kconfig | 8 include/configs/etamin.h | 1 - include/configs/octeontx_common.h | 1 - scripts/config_whitelist.txt | 1 - 5 files changed, 9 insertions(+), 3

Re: [PATCH] cmd: mvebu: Hide bubt specific options when bubt is disabled

2022-05-03 Thread Stefan Roese
On 03.05.22 11:13, Pali Rohár wrote: CONFIG_MVEBU_NAND_BOOT, CONFIG_MVEBU_SPI_BOOT, CONFIG_MVEBU_MMC_BOOT and CONFIG_MVEBU_UBOOT_DFLT_NAME are unused when CONFIG_CMD_MVEBU_BUBT is not enabled. So hide them. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- cmd

Re: [PATCH] arm: mvebu: Espressobin: Add NVMe to boot targets

2022-05-03 Thread Stefan Roese
On 03.05.22 11:01, Pali Rohár wrote: NVMe support is already enabled, so add it into boot targets. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/configs/mvebu_armada-37xx.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-03 Thread Stefan Roese
Hi Josua, On 03.05.22 09:17, Josua Mayer wrote: Am 03.05.22 um 09:16 schrieb Stefan Roese: On 02.05.22 16:18, Josua Mayer wrote: - prog_eeprom: write_tlvinfo_tlv_eeprom - update_crc: tlvinfo_update_crc - is_valid_tlv: is_valid_tlvinfo_entry - is_checksum_valid: tlvinfo_check_crc So while

Re: [PATCH 04/12] cmd: tlv_eeprom: convert functions used by command to api functions

2022-05-02 Thread Stefan Roese
ty checks on a TLV field. The TLV is pointed to + * by the parameter provided. + * 1. The type code is not reserved (0x00 or 0xFF) + */ +static inline bool is_valid_tlvinfo_entry(struct tlvinfo_tlv *tlv) +{ + return((tlv->type != 0x00) && (tlv->type != 0xFF)); +} + #

Re: [PATCH 03/12] cmd: tlv_eeprom: do_tlv_eeprom: stop using non-api read_eeprom function

2022-05-02 Thread Stefan Roese
On 02.05.22 16:18, Josua Mayer wrote: IN the scope of do_tlv_eeprom, the error-checking provided by the Nitpicking: "In ..." read_eeprom function is not required. Instead use the API function read_tlv_eeprom. Signed-off-by: Josua Mayer Reviewed-by: Stefan Roese Than

Re: [PATCH 02/12] cmd: tlv_eeprom: remove use of global variable has_been_read

2022-05-02 Thread Stefan Roese
+ static int has_been_read = -1; You are not introducing this variable but still it would be "better" to change it to bool instead IMHO. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan // If no arguments, read the EERPOM and display its content

Re: [PATCH 01/12] cmd: tlv_eeprom: remove use of global variable current_dev

2022-05-02 Thread Stefan Roese
02.05.22 16:18, Josua Mayer wrote: Make tlv_eeprom command device selection an explicit parameter of all function calls. Signed-off-by: Josua Mayer Reviewed-by: Stefan Roese Thanks, Stefan --- cmd/tlv_eeprom.c | 50 ++-- include/tlv_eeprom.h | 3

Re: [PATCH] watchdog: Add MAX6370 watchdog timer driver

2022-05-02 Thread Stefan Roese
2.0+ +// (C) 2022 Pali Rohár + +#include AFAIK, it's not recommended any more to include "common.h" in general. Looks good, other than this: Reviewed-by: Stefan Roese Thanks, Stefan +#include +#include +#include +#include +#include + +#define MAX6370_SET_MASK 0x7

Re: [PATCH v2 00/52] mips: octeon: Add ethernet support

2022-05-02 Thread Stefan Roese
Hi Daniel, On 07.04.22 09:11, Stefan Roese wrote: This patchset adds the networking files and drivers including device helper headers and C files. Please excuse the massive amount of files in this patch series. Also the sometimes huge files (mostly headers with register definitions) that I

Please pull u-boot-marvell/master

2022-05-02 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - Misc turris_omnia/mox related Fixes and impovements (Pali) - Turris Omnia: Add support for configuring mSATA and WWAN slots via env variables (Pali) - net: mvgbe:

Re: [PATCH] ARM: mvebu: x530: set MPP55 to gpio

2022-05-02 Thread Stefan Roese
urn 0; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] arm: mvebu: clearfog_defconfig: enable setexpr command

2022-05-02 Thread Stefan Roese
b/configs/clearfog_defconfig @@ -34,7 +34,6 @@ CONFIG_CMD_MMC=y CONFIG_CMD_PCI=y CONFIG_CMD_SPI=y CONFIG_CMD_USB=y -# CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TFTPPUT=y CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director

Re: [PATCH] arm: mvebu: turris_omnia: Fix SYS_RSTOUT_* macro names

2022-05-02 Thread Stefan Roese
, SYS_RSTOUT_MASK_WD); + clrbits_32(A385_SYS_RSTOUT_MASK, A385_SYS_RSTOUT_MASK_WD); } static bool disable_mcu_watchdog(void) Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCH] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-05-02 Thread Stefan Roese
/* enable port 0 only */ #define CONFIG_PHY_BASE_ADR 1 -#endif /* CONFIG_CMD_NET */ -/* SATA driver configuration */ -#ifdef CONFIG_SATA +/* Support large HDDs for USB and SATA */ #define CONFIG_LBA48 -#endif /* CONFIG_SATA */ +#define CONFIG_SYS_64BIT_LBA #endif /* _CONFIG_NSA310S_H */ Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-05-02 Thread Stefan Roese
Applied to u-boot-marvell/master Thanks, Stefan On 26.04.22 00:01, Tony Dinh wrote: Hi Stefan, On Mon, Apr 25, 2022 at 4:18 AM Stefan Roese wrote: Hi Tony, On 4/25/22 11:33, Tony Dinh wrote: Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: Hi Tony, On 4/23/22 04:15

Re: [PATCH 5/5] arm: mvebu: turris_mox: Add NVMe and SCSI to boot targets

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: U-Boot for Turris Mox has already enabled NVMe and SCSI support. So add NVMe and SCSI to boot targets. Signed-off-by: Pali Rohár --- include/configs/turris_mox.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/turris_mox.h b/include/

Re: [PATCH 4/5] arm: mvebu: turris_omnia: Add NVMe to boot targets

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: U-Boot for Turris Omnia has already enabled NVMe support. So add NVMe to boot targets. Signed-off-by: Pali Rohár --- include/configs/turris_omnia.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/turris_omnia.h b/include/configs/turris

Re: [PATCH 3/5] arm: mvebu: turris_omnia: Always enable MMC, SCSI and USB boot targets

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: U-Boot for Turris Omnia is always compiled with MMC, SCSI and USB support, so always enable macros for booting from these devices. Signed-off-by: Pali Rohár --- include/configs/turris_omnia.h | 24 +++- 1 file changed, 3 insertions(+),

Re: [PATCH 2/5] arm: mvebu: turris_omnia: Define CONFIG_ETHPRIME instead of ethact= ENV

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: CONFIG_ETHPRIME defines primary ethernet device and env variable $ethact stores currently active ethernet device. So there is no point to set ethact= in default environment. Instead set CONFIG_ETHPRIME properly. Signed-off-by: Pali Rohár --- include/confi

Re: [PATCH 1/5] arm: mvebu: turris_omnia: Fix RESET button message

2022-05-02 Thread Stefan Roese
On 06.04.22 11:39, Pali Rohár wrote: Signed-off-by: Pali Rohár --- board/CZ.NIC/turris_omnia/turris_omnia.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c index 83cfc80d1930..97292456f148

Re: [PATCH u-boot-marvell 0/8] Turris Omnia: Add support for configuring mSATA and WWAN slots via env variables

2022-05-02 Thread Stefan Roese
On 02.03.22 12:47, Pali Rohár wrote: Some mPCIe cards are broken and their PIN 43 incorrectly that card is mSATA. U-Boot SPL on Turris Omnia is using PIN 43 for configuring PCIe vs SATA functionality on SerDes. Allow to configure functionality via additional env variable "omnia_msata_slot" which

Re: [PATCH u-boot-marvell 13/19] net: mvneta: Don't check for CONFIG_PHYLIB

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop checking for CONFIG_PHYLIB in mvneta, this is already done in Kconfig. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 4 1 file changed, 4 deletions(-) diff --git a

Re: [PATCH u-boot-marvell 19/19] net: mvneta: Drop unneeded macro

2022-05-02 Thread Stefan Roese
en as MVNETA_GMAC_FORCE_LINK_DOWN | MVNETA_GMAC_FORCE_LINK_PASS, and so the macro definition can also be dropped. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mvneta.c b/driver

Re: [PATCH u-boot-marvell 18/19] net: mvneta: Disable fixed PHY code if PHY_FIXED is not compiled in

2022-05-02 Thread Stefan Roese
On 27.04.22 12:42, Marek Behún wrote: From: Marek Behún Guard the code handling the fixed PHY case by CONFIG_IS_ENABLED(PHY_FIXED). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

Re: [PATCH u-boot-marvell 16/19] net: mvneta: Write PHY address just before enabling HW polling

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Write PHY address just before enabling HW polling of the PHY. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH u-boot-marvell 17/19] net: mvneta: Drop fixed_link member from private struct

2022-05-02 Thread Stefan Roese
On 27.04.22 12:42, Marek Behún wrote: From: Marek Behún Since this member is checked only at two places drop it and inline it's usage. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 7 ++- 1 file changed, 2 insertions(

Re: [PATCH u-boot-marvell 15/19] net: mvneta: Convert to use PHY_FIXED for fixed-link

2022-05-02 Thread Stefan Roese
Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/mvebu_espressobin-88f3720_defconfig | 1 + configs/turris_omnia_defconfig | 1 + drivers/net/mvneta.c| 98 - 3 files changed, 39 insertions(+), 61 deletions(-) diff

Re: [PATCH u-boot-marvell 14/19] net: mvneta: Rename CONFIG_NR_CPUS to MVNETA_NR_CPUS

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún The CONFIG_* macros are reserved for Kconfig. This was probably done when this driver was being imported from Linux. Rename the macro. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c

Re: [PATCH u-boot-marvell 12/19] net: mvneta: Drop unnecessary space

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop unnecessary space in mvneta_adjust_link(). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

Re: [PATCH u-boot-marvell 11/19] net: mvneta: Use bool instead of int for boolean variable

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Use the bool type instead of int for status_change variable. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH u-boot-marvell 10/19] net: mvneta: Drop one indentation level in mvneta_adjust_link()

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop one indentation level in the mvneta_adjust_link() function. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 38 ++ 1 file changed, 18

Re: [PATCH u-boot-marvell 09/19] net: mvneta: Fix unused variable warning if DM_GPIO is disabled

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún The `ret` variable in mvneta_probe() is unused if DM_GPIO is disabled. Since the variable is used only once after assigning value, we can inline the usage and drop the variable. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese

Re: [PATCH u-boot-marvell 08/19] net: mvneta: Don't register MDIO bus

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún This MDIO bus is now handled by a proper mvmdio DM driver. Remove it from mvneta. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 143

Re: [PATCH u-boot-marvell 06/19] net: mdio-uclass: add dm_phy_find_by_ofnode() helper

2022-05-02 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Add helper to resolve PHY node from it's ofnode via DM MDIO subsystem. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- include/miiphy.h | 9 + net/mdio-uclass.c | 22 +

Re: [PATCH u-boot-marvell 07/19] arm: mvebu: turris_mox: Use DM registered MDIO

2022-05-02 Thread Stefan Roese
ff-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- .../dts/armada-3720-turris-mox-u-boot.dtsi| 19 board/CZ.NIC/turris_mox/turris_mox.c | 88 +-- 2 files changed, 44 insertions(+), 63 deletions(-) diff --git a/arch/arm/dts/armada-3720-turris-

Re: [PATCH u-boot-marvell 05/19] arm: mvebu: Espressobin: Use DM registered MDIO to configure switch

2022-05-01 Thread Stefan Roese
Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/Marvell/mvebu_armada-37xx/board.c | 26 - configs/mvebu_espressobin-88f3720_defconfig | 1 + 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board

Re: [PATCH u-boot-marvell 04/19] net: mvneta: Remember fixed link instead of PHY address in priv data

2022-05-01 Thread Stefan Roese
Drop phyaddr add fixed_link in driver private structure. This simplifies code a little. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/drivers/net/mvnet

Re: [PATCH u-boot-marvell 03/19] net: mvneta: Use DM MDIO API for connecting PHY

2022-05-01 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Use the modern DM MDIO API for connecting PHY in the mvneta driver. This requires enabling MVMDIO driver in several config files. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs

Re: [PATCH u-boot-marvell 02/19] net: mvneta: Fix 10Mbps speed

2022-05-01 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún In mvneta_adjust_link() we need to set MII_SPEED bit only if PHY reports the speed at 100Mbps. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH u-boot-marvell 01/19] net: mvneta: Get rid of platdata

2022-05-01 Thread Stefan Roese
On 27.04.22 12:41, Marek Behún wrote: From: Marek Behún Drop .of_to_plat() from the mvneta driver and parse the two properties in .probe(). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/mvneta.c | 24 1 file changed, 4

Re: [PATCH 2/5] arm: mvebu: turris_omnia: Define CONFIG_ETHPRIME instead of ethact= ENV

2022-05-01 Thread Stefan Roese
"console=ttyS0,115200\0" \ - "ethact=ethernet@34000\0" \ "bootcmd_rescue=" TURRIS_OMNIA_BOOTCMD_RESCUE "\0" \ BOOTENV Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, O

Re: [PATCH u-boot-marvell 00/19] some mvneta changes, cleanups, fixes

2022-05-01 Thread Stefan Roese
ers/net/Kconfig | 1 + drivers/net/mvneta.c | 343 -- include/miiphy.h | 9 + net/mdio-uclass.c | 22 ++ 20 files changed, 181 insertions(+), 343 deletions(-) Viele Grüß

Re: [PATCH] arm: mvebu: turris_omnia: Fix SYS_RSTOUT_* macro names

2022-05-01 Thread Stefan Roese
On 29.04.22 13:53, Pali Rohár wrote: This is A385 register. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/board/CZ.NIC/turris_omnia

Re: [PATCH] arm: mvebu: clearfog_defconfig: enable setexpr command

2022-05-01 Thread Stefan Roese
ned-off-by: Josef Schlehofer Reviewed-by: Stefan Roese Thanks, Stefan --- configs/clearfog_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig index 880f16a6e0..1e9c389deb 100644 --- a/configs/clearfog_defconfig +++

Re: [PATCH] ARM: mvebu: x530: set MPP55 to gpio

2022-05-01 Thread Stefan Roese
On 02.05.22 05:16, Chris Packham wrote: MPP55 is used as a reset connected to the L3 switch chip. This doesn't matter for u-boot as it doesn't use the L3 switch but it is useful to be able to toggle the switch in/out of reset for the OS. Signed-off-by: Chris Packham Reviewed-by: St

[PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

2022-04-29 Thread Stefan Roese
esting and checking with Gaurav Jain from NXP has revealed, that this alignment check is not necessary here at all. So let's remove this check completely. Signed-off-by: Stefan Roese Cc: Gaurav Jain Cc: dullf...@yahoo.com --- drivers/crypto/fsl/fsl_hash.c | 6 -- 1 file change

Re: [EXT] fsl_hash.c: Alignment problem when using caam_hash() for FIT images

2022-04-29 Thread Stefan Roese
On 4/29/22 15:22, Gaurav Jain wrote: Hello Stefan -Original Message- From: Stefan Roese Sent: Friday, April 29, 2022 6:24 PM To: U-Boot Mailing List Cc: Gaurav Jain ; 'dullf...@yahoo.com Subject: [EXT] fsl_hash.c: Alignment problem when using caam_hash() for FIT images Caution

fsl_hash.c: Alignment problem when using caam_hash() for FIT images

2022-04-29 Thread Stefan Roese
Hi, while working on an LX2160 based board and updating to latest mainline I noticed problems using the HW accelerated hash functions on this platform, when trying to boot a FIT Kernel image. Here the resulting error message: ## Loading kernel from FIT Image at a000 ... Using 'conf-freesc

Re: [PATCH] watchdog: Fix SPL build with watchdog disabled in asm files

2022-04-28 Thread Stefan Roese
ot;) for C source files, but not for assembler source files. Currently the only assembler source file which calls WATCHDOG_RESET is arch/powerpc/lib/ticks.S, so this patch affects and fixes powerpc SPL builds. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan --- include/

Re: [PATCH v3 02/15] mips: mtmips: add two reference boards for mt7621

2022-04-28 Thread Stefan Roese
e mode 100644 index 00..2287cb1103 --- /dev/null +++ b/include/configs/mt7621-rfb.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2021 MediaTek Inc. All Rights Reserved. + * + * Author: Weijie Gao + */ + +#ifndef __CONFIG_MT7621_RFB_H +#define __CONFIG_MT7621_RFB_H + +#

Re: [PATCH v3 00/15] Add support for MediaTek MT7621 SoC

2022-04-28 Thread Stefan Roese
ired in 2016 for MqMaker WitiBoard. Marek Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH] net: e1000: Depend on CONFIG_PCI

2022-04-26 Thread Stefan Roese
On 4/26/22 20:35, Sean Anderson wrote: This driver depends on PCI. Update the Kconfig accordingly. Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/net/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/Kconfig b/drivers/net

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-25 Thread Stefan Roese
Hi Tony, On 4/25/22 11:33, Tony Dinh wrote: Hi Stefan, On Sun, Apr 24, 2022 at 11:00 PM Stefan Roese wrote: Hi Tony, On 4/23/22 04:15, Tony Dinh wrote: Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: Hi

Re: [PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-24 Thread Stefan Roese
Hi Tony, On 4/23/22 04:15, Tony Dinh wrote: Hi Stefan, Please see my various comments below. And my thoughts at the end. On Thu, Apr 21, 2022 at 11:15 PM Stefan Roese wrote: Hi Tony, On 4/21/22 23:21, Tony Dinh wrote: What really puzzles me is, why the page address is set to a non

Re: [PATCH][RESEND] mtd: spi-nor-ids: Add Winbond W25Q128JW ID

2022-04-24 Thread Stefan Roese
On 4/24/22 23:39, Marek Vasut wrote: Add ID for Winbond W25Q128JW device. This is a 128 Mbit QSPI NOR. Tested on W25Q128JWPIM part. Signed-off-by: Marek Vasut Cc: Horatiu Vultur Cc: Jagan Teki Cc: Simon Goldschmidt Cc: Stefan Roese Cc: Vignesh R Reviewed-by: Stefan Roese Thanks

Please pull u-boot-watchdog/master

2022-04-22 Thread Stefan Roese
Hi Tom, please pull the following watchdog related patches: - device-tree-bindings: watchdog: document common properties (Philippe) - nuvoton: Add support for Nuvoton (Jim) --

<    5   6   7   8   9   10   11   12   13   14   >