Re: [PATCH] ARM: tegra: p2371-2180: add I2C nodes to DT

2020-03-18 Thread Stephen Warren
On 3/18/20 4:18 PM, twar...@nvidia.com wrote: > From: Tom Warren > > This adds to the DT the I2C controllers that connect to the board ID > EEPROM, camera board EEPROM, etc. With this change, you can now probe > all I2C devices on a TX1 board. Acked-by: Stephen Warren

Re: [PATCH] t210: pinmux: Remove pinmux/GPIO init from T210 boards

2020-03-18 Thread Stephen Warren
> e2220-1170 > p2571 Acked-by: Stephen Warren It may be worth updating the commit description to mention explicitly which L4T release's FW is required when using a U-Boot that has this patch applied. Can we remove the T210 pinmux driver from U-Boot with this patch applied?

Re: [PATCH 5/5] ARM: Tegra: Use calc env var feature on all boards

2020-03-17 Thread Stephen Warren
On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: Tom Warren > > Large kernels (>32MB) can fail to boot because they overwrite the FDT > address, corrupting the DTB. Stephen Warren had created a fix to > dynamically adjust the fdt/ramdisk/pxefile/kernel addr vars at bo

Re: [PATCH 4/5] fdt: Fix 'system' command

2020-03-17 Thread Stephen Warren
urther down from executing. Changed > to test for "se" instead, now 'fdt systemsetup' works (to test the > ft_system_setup proc w/o having to boot a kernel). Reviewed-by: Stephen Warren (Although I wonder if this shouldn't just test the entire string to avoid any possible future ambigui

Re: [PATCH 3/5] ARM: tegra: p2771-0000: enable PIE relocation

2020-03-17 Thread Stephen Warren
On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: Vishruth > > U-Boot is configured to build as position independent executable. Enable > relocation of RELA section required to work with different load > addresses. Reviewed-by: Stephen Warren

Re: [PATCH 2/5] t210: do not enable PLLE and UPHY PLL HW PWRSEQ

2020-03-17 Thread Stephen Warren
On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: JC Kuo > > This commit removes the programming sequence that enables PLLE and UPHY > PLL hardware power sequencers. Per TRM, boot software should enable PLLE > and UPHY PLLs in software controlled power-on state and should power > down PLL

Re: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one

2020-03-17 Thread Stephen Warren
On 3/17/20 11:16 AM, Stephen Warren wrote: > On 3/16/20 1:40 PM, twar...@nvidia.com wrote: >> From: Stephen Warren >> >> Reword fdt_serial_tag_setup_one() so that the types it uses aren't tied >> to CONFIG_SERIAL_TAG, and rename the function to better indicate its

Re: [PATCH 1/5] ARM: tegra: rework fdt_serial_tag_setup_one

2020-03-17 Thread Stephen Warren
On 3/16/20 1:40 PM, twar...@nvidia.com wrote: > From: Stephen Warren > > Reword fdt_serial_tag_setup_one() so that the types it uses aren't tied > to CONFIG_SERIAL_TAG, and rename the function to better indicate its > purpose. This will allow it to be re-used by future board info

Re: [PATCH v2 23/23] test/py: Allow using buildman to build U-Boot

2020-03-16 Thread Stephen Warren
ipts which relate to running test and building a > suitable U-Boot to run the tests on. Reviewed-by: Stephen Warren

Re: [PATCH v2] Makefile: doesn't need check stack size when dtb is not built

2020-03-10 Thread Stephen Warren
e commit description, since they won't have to know to search for a substring of the the description instead of the whole thing. Reviewed-by: Stephen Warren

Re: [PATCH 19/20] test/py: Use buildman to build U-Boot

2020-03-09 Thread Stephen Warren
On 3/6/20 8:07 PM, Simon Glass wrote: It is a pain to have to set the ARCH and CROSS_COMPILE environment variables when using test.py's --build option. It is possible to get these using the -A and -a options from buildman. But it seems better to just use buildman to do the build. Remove the

Re: [PATCH v3 4/4] board_f.c: Insure 16 alignment of start_addr_sp and reserved memory

2020-03-06 Thread Stephen Warren
so, Acked-by: Stephen Warren Nit: Ensure not insure, in a number of places.

Re: [PATCH] Makefile: doesn't need check stack size when dtb is not built

2020-03-05 Thread Stephen Warren
On 3/4/20 5:39 PM, AKASHI Takahiro wrote: On Wed, Mar 04, 2020 at 05:22:25PM -0700, Stephen Warren wrote: On 3/4/20 5:15 PM, AKASHI Takahiro wrote: On Wed, Mar 04, 2020 at 09:21:29AM -0700, Stephen Warren wrote: On 3/3/20 11:54 PM, AKASHI Takahiro wrote: The commit 5fed97af20da ("Mak

Re: [PATCH] Makefile: doesn't need check stack size when dtb is not built

2020-03-04 Thread Stephen Warren
On 3/4/20 5:15 PM, AKASHI Takahiro wrote: On Wed, Mar 04, 2020 at 09:21:29AM -0700, Stephen Warren wrote: On 3/3/20 11:54 PM, AKASHI Takahiro wrote: The commit 5fed97af20da ("Makefile: ensure DTB doesn't overflow into initial stack") adds an extra check for stack s

Re: [PATCH] Makefile: doesn't need check stack size when dtb is not built

2020-03-04 Thread Stephen Warren
On 3/3/20 11:54 PM, AKASHI Takahiro wrote: The commit 5fed97af20da ("Makefile: ensure DTB doesn't overflow into initial stack") adds an extra check for stack size in BSS if CONFIG_SYS_INIT_SP_BSS_OFFSET is enabled. This check, however, doesn't make sense under the configuration where control dtb

Re: [PATCH 1/1] travis-ci: provide env__efi_fit_tftp_file

2020-02-21 Thread Stephen Warren
On 2/21/20 12:35 PM, Heinrich Schuchardt wrote: On 1/8/20 2:16 AM, Stephen Warren wrote: On 1/7/20 10:06 AM, Heinrich Schuchardt wrote: Provide dictionary env__efi_fit_tftp_file describing the file used for the UEFI FIT image test. Acked-by: Stephen Warren Hello Stephen, this patch

Re: [RESEND PATCH 10/10] test: sandbox: add test for erase command

2020-02-19 Thread Stephen Warren
On 2/12/20 11:45 AM, Patrick Delaunay wrote: Add test for the erase command tested on ENV in EXT4. -""" env_location: ENVL_EXT4 (2) +""" env location: ENVL_EXT4 (2) -""" restore env_location: ENVL_NOWHERE (12) +""" restore env location: ENVL_NOWHERE (12) Was there a

Re: [RESEND PATCH 06/10] test: environment in ext4

2020-02-19 Thread Stephen Warren
On 2/12/20 11:44 AM, Patrick Delaunay wrote: Add basic test to persistent environment in ext4: save and load in host ext4 file 'uboot.env'. On first execution a empty EXT4 file system is created in persistent data dir: env.ext4.img. diff --git a/test/py/tests/test_env.py

Re: FYI: Please pull u-boot-dm

2020-02-12 Thread Stephen Warren
On 2/11/20 5:29 PM, Tom Rini wrote: On Tue, Feb 11, 2020 at 05:15:39PM -0700, Stephen Warren wrote: On 2/11/20 3:06 PM, Tom Rini wrote: On Tue, Feb 11, 2020 at 03:02:12PM -0700, Stephen Warren wrote: On 2/11/20 11:27 AM, Tom Rini wrote: On Tue, Feb 11, 2020 at 11:20:36AM -0700, Simon Glass

Re: FYI: Please pull u-boot-dm

2020-02-11 Thread Stephen Warren
On 2/11/20 3:06 PM, Tom Rini wrote: On Tue, Feb 11, 2020 at 03:02:12PM -0700, Stephen Warren wrote: On 2/11/20 11:27 AM, Tom Rini wrote: On Tue, Feb 11, 2020 at 11:20:36AM -0700, Simon Glass wrote: Hi Tom, On Sat, 8 Feb 2020 at 07:51, Simon Glass wrote: Hi Stephen, On Thu, 6 Feb 2020

Re: FYI: Please pull u-boot-dm

2020-02-11 Thread Stephen Warren
On 2/11/20 11:27 AM, Tom Rini wrote: On Tue, Feb 11, 2020 at 11:20:36AM -0700, Simon Glass wrote: Hi Tom, On Sat, 8 Feb 2020 at 07:51, Simon Glass wrote: Hi Stephen, On Thu, 6 Feb 2020 at 15:38, Simon Glass wrote: Hi Stephen, On Thu, 6 Feb 2020 at 15:32, Stephen Warren wrote: On 2/6

Re: [PATCH v2 7/7] test: env: add test for env info sub-command

2020-02-10 Thread Stephen Warren
; function name suffix meant. Perhaps _retcode might be a better function name suffix? Acked-by: Stephen Warren

Re: [PATCH] sandbox: p2sb: Silence compiler warning

2020-02-10 Thread Stephen Warren
On 2/8/20 8:21 AM, Bin Meng wrote: On Sat, Feb 8, 2020 at 10:53 PM Simon Glass wrote: Some compilers produce a warning about 'child' being used before init. Silence this by setting to NULL at the start. Should be a compiler bug I think. Which compiler has such issue? gcc 7.2.1 (Linaro

Re: FYI: Please pull u-boot-dm

2020-02-06 Thread Stephen Warren
On 2/6/20 2:55 PM, Simon Glass wrote: Hi Tom, This cannot be pulled yet since we need to update gitlab's docker image to include SDL2. But gitlab seems to be having various problems this week and today i won't work at all: ... I see the following build error in u-boot-dm/master via Jenkins:

Re: [U-Boot] Sharing a hardware lab

2020-02-05 Thread Stephen Warren
. This is because as best I can tell there isn't a way to include an optional stage/portion of a CI job. So the model here is that people with a lab 'watch' various repos? I think that would be useful. Stephen Warren does this I think, but I'm not sure how the builds are kicked off. Yes, my Jenkins

Re: [PATCH v3 04/17] tegra: i2c: Change driver to use helper function

2020-02-05 Thread Stephen Warren
On 2/4/20 7:03 PM, Simon Glass wrote: Now that we have uclass_first_device_drvdata(), use it from the I2C driver to reduce code duplication. Acked-by: Stephen Warren

Re: [PATCH] distro_bootcmd: Add support for loading user environment

2020-01-31 Thread Stephen Warren
On 1/31/20 7:54 AM, Tom Rini wrote: On Fri, Jan 31, 2020 at 02:42:25PM +, Jon Hunter wrote: On 31/01/2020 14:05, Tom Rini wrote: On Fri, Jan 31, 2020 at 01:24:21PM +, Jon Hunter wrote: On 31/01/2020 12:42, Soeren Moch wrote: On 31.01.20 11:59, Jon Hunter wrote: U-Boot supports

Re: [PATCH v2 4/4] board_f.c: Insure 16 alignment of start_addr_sp and reserved memory

2020-01-22 Thread Stephen Warren
On 1/22/20 6:52 AM, Patrick Delaunay wrote: Add a function reserve_sp() to reserved memory with 16 bits alignment after the stack pointer (gd->start_addr_sp) and use this new function in board_f.c to reserve all the memory area (malloc, board, gd, fdt, bootstage, stacks). This 16 byte alignment

Re: [PATCH v2 1/4] board_f.c: Insure gd->new_bootstage alignment

2020-01-22 Thread Stephen Warren
On 1/22/20 6:52 AM, Patrick Delaunay wrote: From: Patrice Chotard In reserve_bootstage(), in case size is odd, gd->new_bootstage is not aligned. In bootstage_relocate(), the platform hangs when getting access to data->record[i].name. To avoid this issue, make gd->new_bootstage 16 byte aligned.

Re: Error handling broken for block devices

2020-01-20 Thread Stephen Warren
test hint that FOOBAR is some device > type it does not know. ... > No error messages get printed here, but I think these are mandatory > in such a case. > > > Stephen, this code was added as part of your commit: > > commit 10a37fd7a40826c43a63591855346adf1a1ac02d

Re: [PATCH] tegra: fdt: Add tegra186-u-boot.dtsi

2020-01-14 Thread Stephen Warren
On 1/7/20 11:17 AM, Stephen Warren wrote: From: Stephen Warren All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate Tegra210's copy of this file for Tegra186. This ensures that a /binman node exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0 ("binman: Add a li

Re: [PATCH 1/1] travis-ci: provide env__efi_fit_tftp_file

2020-01-07 Thread Stephen Warren
On 1/7/20 10:06 AM, Heinrich Schuchardt wrote: Provide dictionary env__efi_fit_tftp_file describing the file used for the UEFI FIT image test. Acked-by: Stephen Warren

[PATCH] tegra: fdt: Add tegra186-u-boot.dtsi

2020-01-07 Thread Stephen Warren
From: Stephen Warren All Tegra chips except Tegra186 have a tegraNNN-u-boot.dtsi. Duplicate Tegra210's copy of this file for Tegra186. This ensures that a /binman node exists in U-Boot's control DT. Subsequent to 3c10dc95bdd0 ("binman: Add a library to access binman entries") th

Re: [PATCH v6 001/102] binman: Add a library to access binman entries

2020-01-07 Thread Stephen Warren
On 1/7/20 10:32 AM, Stephen Warren wrote: On 12/7/19 6:08 PM, Bin Meng wrote: On Sat, Dec 7, 2019 at 12:45 PM Simon Glass wrote: SPL and TPL can access information about binman entries using link-time symbols but this is not available in U-Boot proper. Of course it could be made available

Re: [PATCH v6 001/102] binman: Add a library to access binman entries

2020-01-07 Thread Stephen Warren
On 12/7/19 6:08 PM, Bin Meng wrote: On Sat, Dec 7, 2019 at 12:45 PM Simon Glass wrote: SPL and TPL can access information about binman entries using link-time symbols but this is not available in U-Boot proper. Of course it could be made available, but the intention is to just read the device

Re: [PATCH v2 1/1] travis-ci: provide env__efi_fit_tftp_file

2020-01-04 Thread Stephen Warren
On 12/31/19 3:42 AM, Cristian Ciocaltea wrote: On Mon, Dec 30, 2019 at 09:03:38PM +0100, Heinrich Schuchardt wrote: On 12/30/19 8:32 PM, Stephen Warren wrote: On 12/30/19 12:05 PM, Heinrich Schuchardt wrote: On 12/30/19 5:38 PM, Stephen Warren wrote: On 12/30/19 3:52 AM, Heinrich Schuchardt

Re: [PATCH v2 1/1] travis-ci: provide env__efi_fit_tftp_file

2019-12-30 Thread Stephen Warren
On 12/30/19 12:05 PM, Heinrich Schuchardt wrote: On 12/30/19 5:38 PM, Stephen Warren wrote: On 12/30/19 3:52 AM, Heinrich Schuchardt wrote: Provide dictionary env__efi_fit_tftp_file describing the file used for the UEFI FIT image test. diff --git a/py/travis-ci/travis_tftp.py b/py/travis-ci

Re: [PATCH v2 1/1] travis-ci: Fix "ResourceWarning: unclosed file"

2019-12-30 Thread Stephen Warren
than "fd" for "file descriptor" (usually an integer) would have been a better variable name. No need to resend to change this though. Reviewed-by: Stephen Warren

Re: [PATCH v2 1/1] travis-ci: provide env__efi_fit_tftp_file

2019-12-30 Thread Stephen Warren
On 12/30/19 3:52 AM, Heinrich Schuchardt wrote: Provide dictionary env__efi_fit_tftp_file describing the file used for the UEFI FIT image test. diff --git a/py/travis-ci/travis_tftp.py b/py/travis-ci/travis_tftp.py +def efifit2env(addr=None): +"""Create dictionary describing file for

Re: [PATCH 1/1] test/py: Fix broken 'notbuildconfigspec' marker

2019-12-24 Thread Stephen Warren
s, > the test ends up being skipped with the message: > > ('/uboot/test/py/conftest.py', 463, > 'Skipped: .config feature "fit" enabled') Reviewed-by: Stephen Warren

[PATCH] test_env: don't strip() printenv results

2019-12-18 Thread Stephen Warren
From: Stephen Warren get_env() was originally written to strip() the output of printenv to isolate the test from any whitespace changes in printenv's output. However, this throws away any whitespace in the variable value, which can cause issues when test code expects to see that whitespace

Re: [PATCH 0/2] travis-ci: provide 'addr' in file2env()

2019-12-06 Thread Stephen Warren
On 12/5/19 10:50 AM, Stephen Warren wrote: On 12/4/19 11:42 PM, Heinrich Schuchardt wrote: Function fetch_tftp_file() in test/py/tests/test_efi_loader.py expects that the dictionary describing a file contains an entry 'addr' specifying the loading address. Otherwise it defaults to the start

Re: [PATCH 0/2] travis-ci: provide 'addr' in file2env()

2019-12-05 Thread Stephen Warren
On 12/4/19 11:42 PM, Heinrich Schuchardt wrote: Function fetch_tftp_file() in test/py/tests/test_efi_loader.py expects that the dictionary describing a file contains an entry 'addr' specifying the loading address. Otherwise it defaults to the start of RAM. On qemu_arm64_defconfig and

Re: [U-Boot] [PATCH] test.py: Make search for autoconf.mk more permission

2019-12-02 Thread Stephen Warren
On 12/1/19 7:34 PM, Simon Glass wrote: Buildman doesn't store this file in the same directory as a normal build. Update the conftest code to handle both cases. Shouldn't we just fix buildman so that it puts the files in the standard locations? That way, we don't have to separately update

Re: [U-Boot] [PATCH] binman: tegra: Adjust symbol calculation depending on end-at-4gb

2019-11-12 Thread Stephen Warren
a note to the documentation - add a separate test to cover x86 behaviour Fixes: 15c981cc (binman: Correct symbol calculation with non-zero image base) Signed-off-by: Simon Glass Tested-by: Stephen Warren Applied to u-boot/master, thanks! Thanks. u-boot/master and u-boot-video/master both now

Re: [U-Boot] [PATCH] binman: tegra: Adjust symbol calculation depending on end-at-4gb

2019-11-08 Thread Stephen Warren
On 11/7/19 9:25 AM, Stephen Warren wrote: On 11/6/19 5:22 PM, Simon Glass wrote: A recent change adjusted the symbol calculation to work on x86 but broke it for Tegra. In fact this is because they have different needs. On x86 devices the code is linked to a ROM address and the end-at-4gb

Re: [U-Boot] [PATCH] Revert "binman: Correct symbol calculation with non-zero image base"

2019-11-07 Thread Stephen Warren
On 11/5/19 9:21 AM, Stephen Warren wrote: From: Stephen Warren This reverts commit 15c981cc8adc26501e3a19ca7fb35705870ef597. "binman: Correct symbol calculation with non-zero image base". This was previously reported to break initial boot on Jetson TK1, and Simon dropped the patc

Re: [U-Boot] [PATCH] binman: tegra: Adjust symbol calculation depending on end-at-4gb

2019-11-07 Thread Stephen Warren
behaviour Fixes: 15c981cc (binman: Correct symbol calculation with non-zero image base) Tested-by: Stephen Warren Thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH] Revert "binman: Correct symbol calculation with non-zero image base"

2019-11-05 Thread Stephen Warren
From: Stephen Warren This reverts commit 15c981cc8adc26501e3a19ca7fb35705870ef597. "binman: Correct symbol calculation with non-zero image base". This was previously reported to break initial boot on Jetson TK1, and Simon dropped the patch from his branch. However, it seems to hav

Re: [U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base

2019-11-04 Thread Stephen Warren
On 10/15/19 10:09 AM, Stephen Warren wrote: On 10/15/19 8:07 AM, Simon Glass wrote: Hi Stephen, On Mon, 14 Oct 2019 at 09:49, Stephen Warren wrote: On 9/26/19 6:38 PM, s...@google.com wrote: At present binman adds the image base address to the symbol value before it writes

Re: [U-Boot] [PATCH] test/py: Set cache_dir to /tmp/.pytest_cache

2019-10-31 Thread Stephen Warren
On 10/31/19 10:17 AM, Tom Rini wrote: On Thu, Oct 31, 2019 at 10:12:06AM -0600, Stephen Warren wrote: On 10/31/19 10:07 AM, Tom Rini wrote: On Thu, Oct 31, 2019 at 10:04:18AM -0600, Stephen Warren wrote: On 10/31/19 8:51 AM, Tom Rini wrote: For some time now, pytest has supported setting

Re: [U-Boot] [PATCH] test/py: Set cache_dir to /tmp/.pytest_cache

2019-10-31 Thread Stephen Warren
On 10/31/19 10:07 AM, Tom Rini wrote: On Thu, Oct 31, 2019 at 10:04:18AM -0600, Stephen Warren wrote: On 10/31/19 8:51 AM, Tom Rini wrote: For some time now, pytest has supported setting where a cache directory that it will use is located (and in turn has logic to re-use this cache and speed

Re: [U-Boot] [PATCH] test/py: Set cache_dir to /tmp/.pytest_cache

2019-10-31 Thread Stephen Warren
-only and we now see a warning about being unable to create the .pytest_cache directory as the default is in the same place as pytest.ini. Set cache_dir to /tmp/.pytest_cache so that it will always be placed in a read/write location. Cc: Stephen Warren Cc: Simon Glass Cc: Bin Meng Signed-off

Re: [U-Boot] [PATCHv2 10/13] test/py: Rework test.py to be a different kind of wrapper

2019-10-23 Thread Stephen Warren
On 10/23/19 12:17 PM, Tom Rini wrote: On Wed, Oct 23, 2019 at 12:04:30PM -0600, Stephen Warren wrote: On 10/23/19 11:29 AM, Stephen Warren wrote: On 10/23/19 11:12 AM, Tom Rini wrote: On Wed, Oct 23, 2019 at 11:03:38AM -0600, Stephen Warren wrote: On 10/23/19 10:58 AM, Tom Rini wrote

Re: [U-Boot] [PATCHv2 06/13] test/py: Manual python3 fixes

2019-10-23 Thread Stephen Warren
On 10/23/19 1:01 PM, Tom Rini wrote: On Wed, Oct 23, 2019 at 12:50:12PM -0600, Stephen Warren wrote: On 10/22/19 9:20 PM, Tom Rini wrote: - Modern pytest is more visible in telling us about parameters that we had not described, so describe a few more. - ConfigParser.readfp(...) is now

Re: [U-Boot] [PATCHv2 06/13] test/py: Manual python3 fixes

2019-10-23 Thread Stephen Warren
On 10/22/19 9:20 PM, Tom Rini wrote: - Modern pytest is more visible in telling us about parameters that we had not described, so describe a few more. - ConfigParser.readfp(...) is now configparser.read_file(...) - As part of the "strings vs bytes" conversions in Python 3, we use the

Re: [U-Boot] [PATCHv2 11/13] test/py: Update docs, add requirements.txt for pip

2019-10-23 Thread Stephen Warren
On 10/22/19 9:20 PM, Tom Rini wrote: To be more closely aligned with Python community best practices, we need to better document our usage of pip and make use of a requirements.txt file that shows the versions of the tools that we are using. This will aide in ensuring reproducibility of our

Re: [U-Boot] [PATCHv2 10/13] test/py: Rework test.py to be a different kind of wrapper

2019-10-23 Thread Stephen Warren
On 10/23/19 11:29 AM, Stephen Warren wrote: On 10/23/19 11:12 AM, Tom Rini wrote: On Wed, Oct 23, 2019 at 11:03:38AM -0600, Stephen Warren wrote: On 10/23/19 10:58 AM, Tom Rini wrote: On Wed, Oct 23, 2019 at 10:55:57AM -0600, Stephen Warren wrote: On 10/22/19 9:20 PM, Tom Rini wrote: Now

Re: [U-Boot] [PATCHv2 10/13] test/py: Rework test.py to be a different kind of wrapper

2019-10-23 Thread Stephen Warren
On 10/23/19 11:12 AM, Tom Rini wrote: On Wed, Oct 23, 2019 at 11:03:38AM -0600, Stephen Warren wrote: On 10/23/19 10:58 AM, Tom Rini wrote: On Wed, Oct 23, 2019 at 10:55:57AM -0600, Stephen Warren wrote: On 10/22/19 9:20 PM, Tom Rini wrote: Now that we have moved to being based on pytest

Re: [U-Boot] [PATCHv2 10/13] test/py: Rework test.py to be a different kind of wrapper

2019-10-23 Thread Stephen Warren
On 10/23/19 10:58 AM, Tom Rini wrote: On Wed, Oct 23, 2019 at 10:55:57AM -0600, Stephen Warren wrote: On 10/22/19 9:20 PM, Tom Rini wrote: Now that we have moved to being based on pytest for python3 we need to make our test.py wrapper more robust in terms of only calling python3 rather than

Re: [U-Boot] [PATCHv2 10/13] test/py: Rework test.py to be a different kind of wrapper

2019-10-23 Thread Stephen Warren
On 10/22/19 9:20 PM, Tom Rini wrote: Now that we have moved to being based on pytest for python3 we need to make our test.py wrapper more robust in terms of only calling python3 rather than possibly finding and using python2. To do this, change from execvp()'ing pytest to invoking the package

Re: [U-Boot] [PATCHv2 08/13] test/py: test_efi_selftest.py: Updates for python 3 support

2019-10-23 Thread Stephen Warren
On 10/22/19 9:20 PM, Tom Rini wrote: - In python 3 you must use raw strings for regex as other forms are deprecated and would require further changes to the pattern here. In one case this lets us have a simpler match pattern. I'm not sure the code was really correct even for Python 2.

Re: [U-Boot] [PATCH] test/py: hush_if_test: Add tests to cover octal/hex values

2019-10-22 Thread Stephen Warren
On 10/21/19 5:46 PM, Simon Glass wrote: Hi Stephen, On Mon, 21 Oct 2019 at 17:04, Stephen Warren wrote: On 10/21/19 4:53 PM, Simon Glass wrote: Hi Michal, On Tue, 15 Oct 2019 at 00:09, Michal Simek wrote: Hi Simon, On 11. 10. 19 17:53, Simon Glass wrote: Hi Michal, On Fri, 11 Oct

Re: [U-Boot] [PATCH] test/py: hush_if_test: Add tests to cover octal/hex values

2019-10-21 Thread Stephen Warren
ser0m1,263s sys 0m0,299s After [u-boot]$ time ./test/py/test.py --bd sandbox -s -k hush >/dev/null real0m2,864s user0m1,563s sys 0m0,305s And if 0.4s on testing will cause issues somewhere else we have different kind of problem. +Stephen Warren I originally men

Re: [U-Boot] [PATCH 00/10] Moving test/py to Python 3

2019-10-18 Thread Stephen Warren
posted this, aside from any feedback I'm going to look at the fs tests and see what's going on there as I'm not sure if we have regressions in the fs code or lack of host tools being installed or possibly both. Aside from the comments I posted, the entire series, Reviewed-by: Stephen Warren

Re: [U-Boot] [PATCH 10/10] HACK: test.py: Disable EFI tests for now

2019-10-18 Thread Stephen Warren
On 10/18/19 2:53 PM, Tom Rini wrote: When running these tests currently we see both warnings about how escape sequences need to be updated and then we see failures of some tests related to finding expected strings and so forth. It seems quite likely that these tests need work to function with

Re: [U-Boot] [PATCH 09/10] WORKAROUND: test/py: Skip fs tests for now

2019-10-18 Thread Stephen Warren
On 10/18/19 2:53 PM, Tom Rini wrote: Currently, these tests are skipped when run in CI. How? If they're being skipped by some other mechanism, do we need to remove that other mechanism now that we're actively specifying "not fs" when running under CI?

Re: [U-Boot] [PATCH 04/10] test/py: Automated conversion to Python 3

2019-10-18 Thread Stephen Warren
On 10/18/19 2:53 PM, Tom Rini wrote: Use the 2to3 tool to perform numerous automatic conversions from Python 2 syntax to Python 3. Also fix whitespace problems that Python 3 catches that Python 2 did not. diff --git a/test/py/conftest.py b/test/py/conftest.py import pytest from

Re: [U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base

2019-10-15 Thread Stephen Warren
On 10/15/19 8:07 AM, Simon Glass wrote: Hi Stephen, On Mon, 14 Oct 2019 at 09:49, Stephen Warren wrote: On 9/26/19 6:38 PM, s...@google.com wrote: At present binman adds the image base address to the symbol value before it writes it to the binary. This is not correct since the symbol value

Re: [U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base

2019-10-14 Thread Stephen Warren
On 9/26/19 6:38 PM, s...@google.com wrote: At present binman adds the image base address to the symbol value before it writes it to the binary. This is not correct since the symbol value itself (e.g. image position) has no relationship to the image base. Fix this and update the tests to cover

Re: [U-Boot] [PATCH] test/py: hush_if_test: Add tests to cover octal/hex values

2019-10-10 Thread Stephen Warren
On 10/10/19 5:44 AM, Michal Simek wrote: Extend test suite to cover also automatic octal/hex converstions which haven't been implemented in past. Acked-by: Stephen Warren ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u

Re: [U-Boot] [PATCH v2 1/3] buildman: Perform tests in a temporary directory

2019-10-08 Thread Stephen Warren
On 10/7/19 3:17 PM, Tom Rini wrote: We may not always be able to write to the default output directory so have a temporary directory for our output be created. Reviewed-by: Stephen Warren ___ U-Boot mailing list U-Boot@lists.denx.de https

Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp

2019-10-04 Thread Stephen Warren
On 10/4/19 11:26 AM, Tom Rini wrote: On Fri, Oct 04, 2019 at 10:32:42AM -0600, Stephen Warren wrote: On 10/4/19 10:12 AM, Tom Rini wrote: We may not always be able to write to the default output directory but we will always have a usable /tmp. Is that a valid assumption? Surely $TMPDIR

Re: [U-Boot] [PATCH 2/3] gitlab-ci: Have buildman use /tmp for output

2019-10-04 Thread Stephen Warren
On 10/4/19 10:12 AM, Tom Rini wrote: When running as another user we might not be able to use '..' for certain directories and this is the default for buildman. Specify an output directory instead. What if multiple invocations run in parallel on the same machine? They'll use the same path

Re: [U-Boot] [PATCH 1/3] buildman: Perform tests in /tmp

2019-10-04 Thread Stephen Warren
On 10/4/19 10:12 AM, Tom Rini wrote: We may not always be able to write to the default output directory but we will always have a usable /tmp. Is that a valid assumption? Surely $TMPDIR should be used if set in the environment, falling back to a hard-coded /tmp if that isn't set?

Re: [U-Boot] [PATCH 1/3] ARM: bcm283x: Move BCM283x_BASE to a global variable

2019-09-27 Thread Stephen Warren
On 9/27/19 9:22 AM, Alexander Graf wrote: On 27.09.19 17:01, Stephen Warren wrote: On 9/27/19 3:00 AM, matthias@kernel.org wrote: From: Matthias Brugger We move the per SOC define BCM283x_BASE to a global variable. This is a first step to provide a single binary for several bcm283x SoCs

Re: [U-Boot] [PATCH 1/3] ARM: bcm283x: Move BCM283x_BASE to a global variable

2019-09-27 Thread Stephen Warren
On 9/27/19 3:00 AM, matthias@kernel.org wrote: From: Matthias Brugger We move the per SOC define BCM283x_BASE to a global variable. This is a first step to provide a single binary for several bcm283x SoCs. How will this work, given that the memory layout is hard-coded into the the DTB?

Re: [U-Boot] [PATCH 002/126] dm: core: Correct low cell in ofnode_read_pci_addr()

2019-09-25 Thread Stephen Warren
can only assume the mid/low values were always both set to 0, or unused, or something? Tested-by: Stephen Warren ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] Revert "ARM: tegra: reserve unmapped RAM so EFI doesn't use it"

2019-09-24 Thread Stephen Warren
-by: Stephen Warren ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [RFC] FAT errors

2019-09-05 Thread Stephen Warren
so used for Arduinos: https://github.com/stm32duino/FatFs Shouldn't we try just the same? I think that or similar has been suggested before.  Are you volunteering to maintain the wrapper and keep it in-sync?  Thanks! Here is the reference Stephen Warren [PATCH 0/9] Replace the FAT f

Re: [U-Boot] [PATCH v2] cmd: pxe: Use internal FDT if retrieving from FDTDIR fails

2019-09-03 Thread Stephen Warren
On 9/3/19 1:52 AM, Anton Leontiev wrote: From: Anton Leontiev As FDTDIR label doesn't specify exact file to be loaded, it should not fail if no file exists in the directory. In this case try to boot with internal FDT if it exists. Signed-off-by: Anton Leontiev --- cmd/pxe.c | 21

Re: [U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved

2019-09-03 Thread Stephen Warren
On 8/31/19 1:52 PM, Anton Leontiev wrote: чт, 29 авг. 2019 г. в 23:35, Stephen Warren : On 8/29/19 5:20 AM, Anton Leontiev wrote: 2019-08-26 at 18:59, Stephen Warren : We have a GNU/Linux distribution that use FDTDIR in its extlinux.conf to support several boards. But some boards have FDT

Re: [U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved

2019-08-29 Thread Stephen Warren
On 8/29/19 5:20 AM, Anton Leontiev wrote: 2019-08-26 at 18:59, Stephen Warren : On 8/23/19 8:40 AM, Anton Leontiev wrote: From: Anton Leontiev Original commit c61d94d86035 ("pxe: implement fdtdir extlinux.conf tag") states, that if FDT file cannot be retrieved then FDT packaged i

Re: [U-Boot] [PATCH] board_f: fix noncached reservation calculation

2019-08-27 Thread Stephen Warren
On 8/27/19 6:01 PM, Vikas MANOCHA wrote: > Stephen Warren wrote at Tuesday, August 27, 2019 3:50 PM >> On 8/27/19 4:10 PM, Vikas MANOCHA wrote: >>> Stephen Warren wrote at Tuesday, August 27, 2019 10:55 AM >>>> The current code in reserve_noncached() has two issues:

Re: [U-Boot] [PATCH] board_f: fix noncached reservation calculation

2019-08-27 Thread Stephen Warren
On 8/27/19 4:10 PM, Vikas MANOCHA wrote: Hi Stephen, -Original Message- From: Stephen Warren Sent: Tuesday, August 27, 2019 10:55 AM To: Tom Rini Cc: twar...@wwwdotorg.org; u-boot@lists.denx.de; Stephen Warren ; Vikas MANOCHA Subject: [PATCH] board_f: fix noncached reservation

[U-Boot] [PATCH] board_f: fix noncached reservation calculation

2019-08-27 Thread Stephen Warren
From: Stephen Warren The current code in reserve_noncached() has two issues: 1) The first update of gd->start_addr_sp always rounds down to a section start. However, the equivalent calculation in cache.c:noncached_init() always first rounds up to a section start, then subtracts a section s

Re: [U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved

2019-08-26 Thread Stephen Warren
On 8/23/19 8:40 AM, Anton Leontiev wrote: From: Anton Leontiev Original commit c61d94d86035 ("pxe: implement fdtdir extlinux.conf tag") states, that if FDT file cannot be retrieved then FDT packaged in firmware should be used. It's not meant to say that. I believe the part of the description

Re: [U-Boot] Travis test/py sandbox_spl test fail

2019-08-19 Thread Stephen Warren
On 8/18/19 7:01 PM, Kever Yang wrote: Hi Simon, Stephen,     Could you help to comment on my other mail, which patch cause this failure. If you run "git bisect", you should be able to track down which patch introduced the problem. Thanks, - Kever On 2019/8/14 下午11:49, Step

Re: [U-Boot] [PATCH] test/py: Add cmd_memory dependency back to test_mmc_wr

2019-08-19 Thread Stephen Warren
On 8/19/19 3:06 AM, Michal Simek wrote: Based on discussion with Stephen Warren there was recommendation to list both memory and random command dependencies just in case that dependency is not properly handled by Kconfig. Acked-by: Stephen Warren

Re: [U-Boot] [PATCH] test/py: Fix MMC/SD block write test dependency

2019-08-15 Thread Stephen Warren
On 8/15/19 12:26 AM, Michal Simek wrote: On 14. 08. 19 17:51, Stephen Warren wrote: On 8/14/19 12:12 AM, Michal Simek wrote: On 13. 08. 19 23:21, Stephen Warren wrote: On 8/1/19 10:48 PM, Michal Simek wrote: Test is using random command which has own Kconfig symbol CMD_RANDOM which already

Re: [U-Boot] [PATCH] test/py: Fix MMC/SD block write test dependency

2019-08-14 Thread Stephen Warren
On 8/14/19 12:12 AM, Michal Simek wrote: On 13. 08. 19 23:21, Stephen Warren wrote: On 8/1/19 10:48 PM, Michal Simek wrote: Test is using random command which has own Kconfig symbol CMD_RANDOM which already depends on CMD_MEMORY. That's why replace cmd_memory by cmd_random. This might

Re: [U-Boot] Travis test/py sandbox_spl test fail

2019-08-14 Thread Stephen Warren
On 8/13/19 8:06 PM, Kever Yang wrote: Hi Stephen, On 2019/8/14 上午4:54, Stephen Warren wrote: On 8/13/19 3:39 AM, Simon Glass wrote: +Stephen Hi Kever, On Tue, 13 Aug 2019 at 03:35, Kever Yang wrote: Hi Simon, I got fail in test/py sandbox_spl, and the log says: E OSError: [Errno

Re: [U-Boot] [PATCH] test/py: Fix MMC/SD block write test dependency

2019-08-13 Thread Stephen Warren
On 8/1/19 10:48 PM, Michal Simek wrote: Test is using random command which has own Kconfig symbol CMD_RANDOM which already depends on CMD_MEMORY. That's why replace cmd_memory by cmd_random. This might not always be true; I think it'd be better to keep the existing dependency list entries and

Re: [U-Boot] Travis test/py sandbox_spl test fail

2019-08-13 Thread Stephen Warren
On 8/13/19 3:39 AM, Simon Glass wrote: +Stephen Hi Kever, On Tue, 13 Aug 2019 at 03:35, Kever Yang wrote: Hi Simon, I got fail in test/py sandbox_spl, and the log says: E OSError: [Errno 5] Input/output error I have no idea about what's wrong in source code, could you help to take

Re: [U-Boot] 32-bit Tegra build failure in u-boot-dm

2019-07-19 Thread Stephen Warren
On 7/18/19 7:21 PM, Simon Glass wrote: Hi Stephen, On Thu, 18 Jul 2019 at 09:52, Stephen Warren wrote: Simon, All 32-bit Tegra boards appear to be failing to build in u-boot-dm.git master branch with: BINMAN u-boot-tegra.bin binman: Unknown entry type 'u-boot-spl' in node '/binman

[U-Boot] [PATCH] Makefile: fix implementation of BINMAN_DEBUG

2019-07-19 Thread Stephen Warren
From: Stephen Warren binman only accepts the -D argument early on the command-line, yet the Makefile currently passes it near the end. This causes the build to fail if this feature is used. Re-order the command-line to fix this. Signed-off-by: Stephen Warren --- Note: This appears

Re: [U-Boot] test.py failure in test_ut[ut_dm_pci_ep_base]

2019-07-19 Thread Stephen Warren
On 7/15/19 2:07 PM, Ramon Fried wrote: On Mon, Jul 15, 2019 at 6:25 PM Tom Rini <mailto:tr...@konsulko.com>> wrote: On Mon, Jul 15, 2019 at 09:14:03AM -0600, Stephen Warren wrote: > Running test.py on sandbox now fails test_ut[ut_dm_pci_ep_base] with: >

[U-Boot] 32-bit Tegra build failure in u-boot-dm

2019-07-18 Thread Stephen Warren
Simon, All 32-bit Tegra boards appear to be failing to build in u-boot-dm.git master branch with: BINMAN u-boot-tegra.bin binman: Unknown entry type 'u-boot-spl' in node '/binman/image1/u-boot-spl' /var/lib/jenkins/workspace/u-boot-denx_uboot_dm-master-build/src/u-boot/Makefile:1437:

Re: [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing

2019-07-17 Thread Stephen Warren
On 7/16/19 5:35 PM, Heinrich Schuchardt wrote: When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr "Parameter 'id' is missing". A command launching qemu-riscv64_defconfig successfully on Debian is: qemu-system-riscv64 \ -machine virt \ -kernel u-boot \ -m 1G -nographic -netdev

Re: [U-Boot] [PATCH v2 1/2] flash: Script to create a flash image from u-boot

2019-07-16 Thread Stephen Warren
On 7/15/19 5:14 PM, Joel Stanley wrote: This creates an empty flash image and places u-boot at the start of it. It will be used by the ASPEED Qemu tests which boot u-boot from an emaulated flash device. diff --git a/bin/flash.create_image_32mb b/bin/flash.create_image_32mb I can foresee a

<    1   2   3   4   5   6   7   8   9   10   >